[Bug 61584] NPE in XDGFPage getPageOffset: check for x instead of y

2017-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=61584

--- Comment #4 from virtuald  ---
No longer have Visio installed either*

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: [GitHub] poi pull request #79: Remove the method invocation of toString on a string.

2017-10-15 Thread Javen O'Neal 
Looks like all of the String.toString() calls have been removed. I added
this to the forbidden APIs list in r1812239 to eliminate this problem from
recurring.

On Oct 15, 2017 17:42, "Javen O'Neal"  wrote:

We can probably add String.toString() to forbidden APIs to make sure there
aren't other usages of String.toString and that this stays fixed in the
future. Even if String.toString gets compiled out and therefore doesn't
affect library performance,  it could be confusing for someone reading the
code.

Are there any reasons to keep String.toString() usages? Perhaps
String.toString(Locale).

On Oct 15, 2017 13:34, "asfgit"  wrote:

> Github user asfgit closed the pull request at:
>
> https://github.com/apache/poi/pull/79
>
>
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

[Bug 61584] NPE in XDGFPage getPageOffset: check for x instead of y

2017-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=61584

virtuald  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEEDINFO|RESOLVED

--- Comment #3 from virtuald  ---
I no longer have Visio installed with, but you're right that this is obviously
a typo. Pushed fix @ 1812240.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: [GitHub] poi pull request #79: Remove the method invocation of toString on a string.

2017-10-15 Thread Javen O'Neal 
We can probably add String.toString() to forbidden APIs to make sure there
aren't other usages of String.toString and that this stays fixed in the
future. Even if String.toString gets compiled out and therefore doesn't
affect library performance,  it could be confusing for someone reading the
code.

Are there any reasons to keep String.toString() usages? Perhaps
String.toString(Locale).

On Oct 15, 2017 13:34, "asfgit"  wrote:

> Github user asfgit closed the pull request at:
>
> https://github.com/apache/poi/pull/79
>
>
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

[GitHub] poi pull request #78: Add the "final" modifier to public static fields.

2017-10-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/poi/pull/78


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[GitHub] poi pull request #79: Remove the method invocation of toString on a string.

2017-10-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/poi/pull/79


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[GitHub] poi pull request #80: Remove the useless object.

2017-10-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/poi/pull/80


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org