Re: Adding a function or two...

2018-03-27 Thread Javen O'Neal 
HSSF and SS Common tests live here:
https://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/

XSSF and SS Common tests live here:
https://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/

We separated the tests because HSSF code is compiled and tested without
providing ooxml-schema.jar or poi-ooxml-schema.jar on the class path. This
way we can guarantee that poi.jar doesn't require ooxml as a dependency, to
keep projects small where they're only using the binary formats.

On Tue, Mar 27, 2018, 20:09 Blake Watson  wrote:

> I was just scouring the whole project for XSSFWorkbook and not finding
> nearly as much as I thought.
>
> How does one properly add to functionMetaData.txt?
>
> On Tue, Mar 27, 2018 at 6:38 PM, Greg Woolsey 
> wrote:
>
> > Tests in that package are run in a context without the xssf code. Xssf
> > specific tests need to go in a different location. I don't have it on my
> > phone, but some searching should reveal them, the naming conventions are
> > strong.
> >
> > On Tue, Mar 27, 2018, 17:45 Blake Watson  wrote:
> >
> > > The tests seem to be mostly HSSF based. Is that right? (I guess it
> > > shouldn't matter?)
> > >
> > > On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson 
> > > wrote:
> > >
> > > > Yeah, I was gonna use the Git.
> > > >
> > > > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <
> > > dominik.stad...@gmx.at>
> > > > wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> Tests are part of the published sources in separate directories
> under
> > > >> "src", for functions mostly under "src/testsources", e.g.
> > > >> src/testcases/org/apache/poi/ss/formula/functions seems a good place
> > for
> > > >> unit-tests that cover specific functions.
> > > >>
> > > >> Maybe also good if you use either the SVN or Git repository
> directly,
> > > then
> > > >> it is easier to contribute changes as patch or pull-request.
> > > >>
> > > >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > > >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
> > > >> LO7ywUomDopdFrs&e= and
> > > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > > >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
> > > >> 87GDNNpu7RkO50Q&e= for working with the code,
> > > >>
> > > >> Thanks... Dominik.
> > > >>
> > > >>
> > > >>
> > > >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <
> blake.wat...@pnmac.com
> > >
> > > >> wrote:
> > > >>
> > > >> > I was going to try adding functions to POI (IFNA seems like a
> likely
> > > >> first
> > > >> > shot). I've imported the sources from the ZIP (NetBeans) and I can
> > > build
> > > >> > and run tests. But I don't see where the source code for the tests
> > is.
> > > >> (I
> > > >> > assume I start with the tests...)
> > > >> >
> > > >> > Also open to any suggestions for...whatever.
> > > >> > --
> > > >> >
> > > >> > *Blake Watson*
> > > >> >
> > > >> > *PNMAC*
> > > >> > Application Development Manager
> > > >> > 5898 Condor Drive
> > > >> > Moorpark, CA 93021
> > > >> > (805) 330.4911 x7742
> > > >> > blake.wat...@pnmac.com
> > > >> > www.PennyMacUSA.com 
> > > >> >
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > >
> > > > *Blake Watson*
> > > >
> > > > *PNMAC*
> > > > Application Development Manager
> > > > 5898 Condor Drive
> > > > Moorpark, CA 93021
> > > > (805) 330.4911 x7742
> > > > blake.wat...@pnmac.com
> > > > www.PennyMacUSA.com 
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > *Blake Watson*
> > >
> > > *PNMAC*
> > > Application Development Manager
> > > 5898 Condor Drive
> > > Moorpark, CA 93021
> > > (805) 330.4911 x7742
> > > blake.wat...@pnmac.com
> > > www.PennyMacUSA.com 
> > >
> >
>
>
>
> --
>
> *Blake Watson*
>
> *PNMAC*
> Application Development Manager
> 5898 Condor Drive
> Moorpark, CA 93021
> (805) 330.4911 x7742
> blake.wat...@pnmac.com
> www.PennyMacUSA.com 
>

Re: Adding a function or two...

2018-03-27 Thread Blake Watson 
I was just scouring the whole project for XSSFWorkbook and not finding
nearly as much as I thought.

How does one properly add to functionMetaData.txt?

On Tue, Mar 27, 2018 at 6:38 PM, Greg Woolsey 
wrote:

> Tests in that package are run in a context without the xssf code. Xssf
> specific tests need to go in a different location. I don't have it on my
> phone, but some searching should reveal them, the naming conventions are
> strong.
>
> On Tue, Mar 27, 2018, 17:45 Blake Watson  wrote:
>
> > The tests seem to be mostly HSSF based. Is that right? (I guess it
> > shouldn't matter?)
> >
> > On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson 
> > wrote:
> >
> > > Yeah, I was gonna use the Git.
> > >
> > > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <
> > dominik.stad...@gmx.at>
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> Tests are part of the published sources in separate directories under
> > >> "src", for functions mostly under "src/testsources", e.g.
> > >> src/testcases/org/apache/poi/ss/formula/functions seems a good place
> for
> > >> unit-tests that cover specific functions.
> > >>
> > >> Maybe also good if you use either the SVN or Git repository directly,
> > then
> > >> it is easier to contribute changes as patch or pull-request.
> > >>
> > >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
> > >> LO7ywUomDopdFrs&e= and
> > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
> > >> 87GDNNpu7RkO50Q&e= for working with the code,
> > >>
> > >> Thanks... Dominik.
> > >>
> > >>
> > >>
> > >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson  >
> > >> wrote:
> > >>
> > >> > I was going to try adding functions to POI (IFNA seems like a likely
> > >> first
> > >> > shot). I've imported the sources from the ZIP (NetBeans) and I can
> > build
> > >> > and run tests. But I don't see where the source code for the tests
> is.
> > >> (I
> > >> > assume I start with the tests...)
> > >> >
> > >> > Also open to any suggestions for...whatever.
> > >> > --
> > >> >
> > >> > *Blake Watson*
> > >> >
> > >> > *PNMAC*
> > >> > Application Development Manager
> > >> > 5898 Condor Drive
> > >> > Moorpark, CA 93021
> > >> > (805) 330.4911 x7742
> > >> > blake.wat...@pnmac.com
> > >> > www.PennyMacUSA.com 
> > >> >
> > >>
> > >
> > >
> > >
> > > --
> > >
> > > *Blake Watson*
> > >
> > > *PNMAC*
> > > Application Development Manager
> > > 5898 Condor Drive
> > > Moorpark, CA 93021
> > > (805) 330.4911 x7742
> > > blake.wat...@pnmac.com
> > > www.PennyMacUSA.com 
> > >
> >
> >
> >
> > --
> >
> > *Blake Watson*
> >
> > *PNMAC*
> > Application Development Manager
> > 5898 Condor Drive
> > Moorpark, CA 93021
> > (805) 330.4911 x7742
> > blake.wat...@pnmac.com
> > www.PennyMacUSA.com 
> >
>



-- 

*Blake Watson*

*PNMAC*
Application Development Manager
5898 Condor Drive
Moorpark, CA 93021
(805) 330.4911 x7742
blake.wat...@pnmac.com
www.PennyMacUSA.com

Re: Adding a function or two...

2018-03-27 Thread Greg Woolsey 
Tests in that package are run in a context without the xssf code. Xssf
specific tests need to go in a different location. I don't have it on my
phone, but some searching should reveal them, the naming conventions are
strong.

On Tue, Mar 27, 2018, 17:45 Blake Watson  wrote:

> The tests seem to be mostly HSSF based. Is that right? (I guess it
> shouldn't matter?)
>
> On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson 
> wrote:
>
> > Yeah, I was gonna use the Git.
> >
> > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <
> dominik.stad...@gmx.at>
> > wrote:
> >
> >> Hi,
> >>
> >> Tests are part of the published sources in separate directories under
> >> "src", for functions mostly under "src/testsources", e.g.
> >> src/testcases/org/apache/poi/ss/formula/functions seems a good place for
> >> unit-tests that cover specific functions.
> >>
> >> Maybe also good if you use either the SVN or Git repository directly,
> then
> >> it is easier to contribute changes as patch or pull-request.
> >>
> >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
> >> LO7ywUomDopdFrs&e= and
> >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
> >> 87GDNNpu7RkO50Q&e= for working with the code,
> >>
> >> Thanks... Dominik.
> >>
> >>
> >>
> >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson 
> >> wrote:
> >>
> >> > I was going to try adding functions to POI (IFNA seems like a likely
> >> first
> >> > shot). I've imported the sources from the ZIP (NetBeans) and I can
> build
> >> > and run tests. But I don't see where the source code for the tests is.
> >> (I
> >> > assume I start with the tests...)
> >> >
> >> > Also open to any suggestions for...whatever.
> >> > --
> >> >
> >> > *Blake Watson*
> >> >
> >> > *PNMAC*
> >> > Application Development Manager
> >> > 5898 Condor Drive
> >> > Moorpark, CA 93021
> >> > (805) 330.4911 x7742
> >> > blake.wat...@pnmac.com
> >> > www.PennyMacUSA.com 
> >> >
> >>
> >
> >
> >
> > --
> >
> > *Blake Watson*
> >
> > *PNMAC*
> > Application Development Manager
> > 5898 Condor Drive
> > Moorpark, CA 93021
> > (805) 330.4911 x7742
> > blake.wat...@pnmac.com
> > www.PennyMacUSA.com 
> >
>
>
>
> --
>
> *Blake Watson*
>
> *PNMAC*
> Application Development Manager
> 5898 Condor Drive
> Moorpark, CA 93021
> (805) 330.4911 x7742
> blake.wat...@pnmac.com
> www.PennyMacUSA.com 
>

Re: Adding a function or two...

2018-03-27 Thread Blake Watson 
The tests seem to be mostly HSSF based. Is that right? (I guess it
shouldn't matter?)

On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson 
wrote:

> Yeah, I was gonna use the Git.
>
> On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler 
> wrote:
>
>> Hi,
>>
>> Tests are part of the published sources in separate directories under
>> "src", for functions mostly under "src/testsources", e.g.
>> src/testcases/org/apache/poi/ss/formula/functions seems a good place for
>> unit-tests that cover specific functions.
>>
>> Maybe also good if you use either the SVN or Git repository directly, then
>> it is easier to contribute changes as patch or pull-request.
>>
>> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
>> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
>> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
>> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
>> LO7ywUomDopdFrs&e= and
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
>> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
>> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
>> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
>> 87GDNNpu7RkO50Q&e= for working with the code,
>>
>> Thanks... Dominik.
>>
>>
>>
>> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson 
>> wrote:
>>
>> > I was going to try adding functions to POI (IFNA seems like a likely
>> first
>> > shot). I've imported the sources from the ZIP (NetBeans) and I can build
>> > and run tests. But I don't see where the source code for the tests is.
>> (I
>> > assume I start with the tests...)
>> >
>> > Also open to any suggestions for...whatever.
>> > --
>> >
>> > *Blake Watson*
>> >
>> > *PNMAC*
>> > Application Development Manager
>> > 5898 Condor Drive
>> > Moorpark, CA 93021
>> > (805) 330.4911 x7742
>> > blake.wat...@pnmac.com
>> > www.PennyMacUSA.com 
>> >
>>
>
>
>
> --
>
> *Blake Watson*
>
> *PNMAC*
> Application Development Manager
> 5898 Condor Drive
> Moorpark, CA 93021
> (805) 330.4911 x7742
> blake.wat...@pnmac.com
> www.PennyMacUSA.com 
>



-- 

*Blake Watson*

*PNMAC*
Application Development Manager
5898 Condor Drive
Moorpark, CA 93021
(805) 330.4911 x7742
blake.wat...@pnmac.com
www.PennyMacUSA.com

[Bug 62222] getLabel for Hyperlink returns always null for xlsx files

2018-03-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=6

Alexander Vitkovskiy  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #5 from Alexander Vitkovskiy  ---
Also there same issue if you writing Hyperlink to Excel file. Setting address
works, but label not shows in MS Excel (cell will have blank text, but style
will be hyperlink and navigation will work)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62222] getLabel for Hyperlink returns always null for xlsx files

2018-03-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=6

--- Comment #4 from Alexander Vitkovskiy  ---
File created in Excel 2013.

Sheet looks like this:


http://schemas.openxmlformats.org/spreadsheetml/2006/main";
xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships";
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006";
mc:Ignorable="x14ac"
xmlns:x14ac="http://schemas.microsoft.com/office/spreadsheetml/2009/9/ac";>0

that points to hyperlynk (but there no display text):


http://schemas.openxmlformats.org/package/2006/relationships";>http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink";
Target="pom.xml" TargetMode="External"/>

Found it ("MavenPom") in sharedStrings.xml:


http://schemas.openxmlformats.org/spreadsheetml/2006/main";
count="1" uniqueCount="1">MavenPom


I attached XLSX file to bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62222] getLabel for Hyperlink returns always null for xlsx files

2018-03-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=6

Nick Burch  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Nick Burch  ---
The XSSF code (for XLSX) is returning the "display" property of the underlying
CT Hyperlink xml.

Could you try renaming your .xlsx file to .zip, unzipping it, and looking in
the XML to see what your version of Excel decided to store the label as/in?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62222] getLabel for Hyperlink returns always null for xlsx files

2018-03-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=6

Alexander Vitkovskiy  changed:

   What|Removed |Added

 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62222] getLabel for Hyperlink returns always null for xlsx files

2018-03-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=6

--- Comment #1 from Alexander Vitkovskiy  ---
Created attachment 35814
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35814&action=edit
xls file

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62222] getLabel for Hyperlink returns always null for xlsx files

2018-03-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=6

--- Comment #2 from Alexander Vitkovskiy  ---
Created attachment 35815
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35815&action=edit
xlsx file

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62222] New: getLabel for Hyperlink returns always null for xlsx files

2018-03-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=6

Bug ID: 6
   Summary: getLabel for Hyperlink returns always null for xlsx
files
   Product: POI
   Version: 3.17-FINAL
  Hardware: PC
Status: NEW
  Severity: critical
  Priority: P2
 Component: XSSF
  Assignee: dev@poi.apache.org
  Reporter: sasha.v...@gmail.com
  Target Milestone: ---

Created attachment 35813
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35813&action=edit
Java class

hyperlink.getLabel() returns null instead of display text for hyperlink.

But in normally works for xls files and HSSF.

See attached example that shows bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org