[GitHub] poi pull request #114: Enhancement to XWPFFootnote and related APIs

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/poi/pull/114


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[GitHub] poi pull request #114: Enhancement to XWPFFootnote and related APIs

[drmacro]

GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/114

Enhancement to XWPFFootnote and related APIs

My first pass at enhancing the XWPFFootnote API.

Adds new methods createParagraph() and createTable()/createTable(rows, 
cols) to XWPFFootnote.

Adds new methods createFootnote() and removeFootnote() to XWPFDocument and 
XWPFFootnotes

Adds new method addFootnoteReference(XWPFFootnote) to XWPFParagraph

Creation of new footnote does not add any body elements. However, adding 
the first paragraph or table automatically creates the required footnote ref 
run in the first paragraph (adding the paragraph if necessary).

I also made a pass over the javadocs for XWPFFootnote.

I tested with the included unit tests and also in the context of my 
real-world project that is driving this update. That verifies, for example, 
that a multi-paragraph footnote with a table works as it should.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/XWPFFootnote-enhancements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #114


commit 57d4765dea96ba3187b9c317ec466f9165446e64
Author: Eliot Kimber 
Date:   2018-07-21T14:43:56Z

Enhancement to XWPFFootnote and related APIs




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Jenkins build is back to normal : POI-DSL-Windows-1.8 #228

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: Apache Forrest 0.9 update

[Andreas Beeker]

Hi Dominik,

I hope it works now - when running gradle (without gradlew), I run into an 
exception [1]
I also removed the note about the xml-resolver, so this is not necessary 
anymore.

Andi

java.lang.NoSuchMethodError: 
org.apache.tools.ant.types.resources.Resources.stream()Ljava/util/stream/Stream;

On 7/21/18 8:50 AM, Dominik Stadler wrote:
> Hi Andi,
>
> I see failures when the environment variable for forrest is not configured,
> this seems to have worked before and probably would be good to not require
> forrest when people just want to compile the sources:
>
>
> BUILD FAILED
> /opt/poi-benchmark/sources/build.xml:64: Cannot find
> /opt/poi-benchmark/sources/${env.FORREST_HOME}/main/forrest.build.xml
> imported from /opt/poi-benchmark/sources/build.xml
>
>
> If I specify "optional=true" for the import, then some targets like "site"
> are missing and ant still complains, seems the dependency on
> forrest-sources is a bit to tight now, would probably be better to invoke
> the forrest-tasks via a nested ant-call instead.
>
>
> Dominik.
>
>
> On Fri, Jul 20, 2018 at 5:17 PM, Mark Murphy  wrote:
>
>> Looks good except the Powered by Apache logo is partially blocked by the
>> search tab.
>>
>> On Thu, Jul 19, 2018 at 5:56 PM Andreas Beeker 
>> wrote:
>>
>>> Hi,
>>>
>>> I've fixed the rewrite rules and the build.
>>>
>>> AFAIK there's no jenkins job to generate the site - only the javadoc,
>>> otherwise we would need to find a way to inject the forrest resolver into
>>> the ant runtime.
>>>
>>> What do you think about the new tabs layout?
>>>
>>> The reason for the site subdirs were the corresponding tab dir relations.
>>>
>>> Andi
>>>
>>>
>>>




signature.asc
Description: OpenPGP digital signature

Re: Apache Forrest 0.9 update

[Dominik Stadler]

Hi Andi,

I see failures when the environment variable for forrest is not configured,
this seems to have worked before and probably would be good to not require
forrest when people just want to compile the sources:


BUILD FAILED
/opt/poi-benchmark/sources/build.xml:64: Cannot find
/opt/poi-benchmark/sources/${env.FORREST_HOME}/main/forrest.build.xml
imported from /opt/poi-benchmark/sources/build.xml


If I specify "optional=true" for the import, then some targets like "site"
are missing and ant still complains, seems the dependency on
forrest-sources is a bit to tight now, would probably be better to invoke
the forrest-tasks via a nested ant-call instead.


Dominik.


On Fri, Jul 20, 2018 at 5:17 PM, Mark Murphy  wrote:

> Looks good except the Powered by Apache logo is partially blocked by the
> search tab.
>
> On Thu, Jul 19, 2018 at 5:56 PM Andreas Beeker 
> wrote:
>
> > Hi,
> >
> > I've fixed the rewrite rules and the build.
> >
> > AFAIK there's no jenkins job to generate the site - only the javadoc,
> > otherwise we would need to find a way to inject the forrest resolver into
> > the ant runtime.
> >
> > What do you think about the new tabs layout?
> >
> > The reason for the site subdirs were the corresponding tab dir relations.
> >
> > Andi
> >
> >
> >
>