[Bug 67579] POI 5.2.4 is closing the input stream used in the XSSFWorkbook constructor which explicitly specifies closeStream=false

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67579

Dominik Stadler  changed:

   What|Removed |Added

 Depends on||66584


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=66584
[Bug 66584] ZipPackage can fail to handle excepions.
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 66584] ZipPackage can fail to handle excepions.

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66584

Dominik Stadler  changed:

   What|Removed |Added

 Blocks||67579


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=67579
[Bug 67579] POI 5.2.4 is closing the input stream used in the XSSFWorkbook
constructor  which explicitly specifies closeStream=false
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 67579] POI 5.2.4 is closing the input stream used in the XSSFWorkbook constructor which explicitly specifies closeStream=false

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67579

PJ Fanning  changed:

   What|Removed |Added

 OS|Mac OS X 10.1   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 67579] POI 5.2.4 is closing the input stream used in the XSSFWorkbook constructor which explicitly specifies closeStream=false

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67579

--- Comment #4 from PJ Fanning  ---
breaking change was in https://bz.apache.org/bugzilla/show_bug.cgi?id=66584

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 67579] POI 5.2.4 is closing the input stream used in the XSSFWorkbook constructor which explicitly specifies closeStream=false

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67579

--- Comment #3 from PJ Fanning  ---
added r1912700

will wait a week or so to see if other regressions are reported before seeing
about a POI 5.2.5 RC

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: [PR] Bump de.thetaphi.forbiddenapis from 3.5.1 to 3.6 [poi]

2023-10-02 Thread via GitHub


dependabot[bot] commented on PR #526:
URL: https://github.com/apache/poi/pull/526#issuecomment-1743946678

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: [PR] Bump de.thetaphi.forbiddenapis from 3.5.1 to 3.6 [poi]

2023-10-02 Thread via GitHub


asfgit closed pull request #526: Bump de.thetaphi.forbiddenapis from 3.5.1 to 
3.6
URL: https://github.com/apache/poi/pull/526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 67579] POI 5.2.4 is closing the input stream used in the XSSFWorkbook constructor which explicitly specifies closeStream=false

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67579

--- Comment #2 from nniesen...@gmail.com ---
ZipPackage 5.2.4 changed to a try-with-resources which is : 

130:ZipPackage(InputStream in, PackageAccess access) throws IOException {
131:super(access);
132:try (ZipArchiveThresholdInputStream zis =
ZipHelper.openZipStream(in)) {
133:this.zipArchive = new ZipInputStreamZipEntrySource(zis);


ZipPackage 5.2.3 didn't close the input stream:
128:ZipPackage(InputStream in, PackageAccess access) throws IOException {
129:super(access);
130:ZipArchiveThresholdInputStream zis = ZipHelper.openZipStream(in);
// NOSONAR
131:try {
132:this.zipArchive = new ZipInputStreamZipEntrySource(zis);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 67579] POI 5.2.4 is closing the input stream used in the XSSFWorkbook constructor which explicitly specifies closeStream=false

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67579

--- Comment #1 from nniesen...@gmail.com ---
Test comment was supposed to read:
// poi-ooxml:5.2.4 throws java.io.IOException: Stream closed

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 67579] New: POI 5.2.4 is closing the input stream used in the XSSFWorkbook constructor which explicitly specifies closeStream=false

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67579

Bug ID: 67579
   Summary: POI 5.2.4 is closing the input stream used in the
XSSFWorkbook constructor  which explicitly specifies
closeStream=false
   Product: POI
   Version: unspecified
  Hardware: PC
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: XSSF
  Assignee: dev@poi.apache.org
  Reporter: nniesen...@gmail.com
  Target Milestone: ---

Created attachment 39088
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=39088&action=edit
Zip file with 2 POI XSSFWorkbook exports

Version 5.2.4 started closing the InputStream for 'new
XSSFWorkbook(zipInputStream)' which explicitly specifies closeStream=false

MavenCentral artifact:
implementation 'org.apache.poi:poi-ooxml:5.2.4'

Spock test (works with 5.2.3, fails with 5.2.4):

def 'testExportAll'() {
given:
InputStream fileInputStream = new
File('src/test/groovy/ExportAll.zip').newInputStream()

when: 'export all zip unpacked'
ZipInputStream zipInputStream = new ZipInputStream(fileInputStream)

then: 'read first file (entry)'
ZipEntry zipEntry1 = zipInputStream.getNextEntry()
assert zipEntry1.name == 'testExport1.xlsx'
Workbook workbook1 = new XSSFWorkbook(zipInputStream)
assert workbook1.getSheetAt(0).sheetName == 'testExport1'

and: 'read first file (entry)'
ZipEntry zipEntry2 = zipInputStream.getNextEntry() // poi-ooxml:5.2.2
throws java.io.IOException: Stream closed

assert zipEntry2.name == 'testExport2.xlsx'
Workbook workbook2 = new XSSFWorkbook(zipInputStream)
assert workbook2.getSheetAt(0).sheetName == 'testExport2'

and: 'should be no more'
assert zipInputStream.getNextEntry() == null
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[PR] Bump de.thetaphi.forbiddenapis from 3.5.1 to 3.6 [poi]

2023-10-02 Thread via GitHub


dependabot[bot] opened a new pull request, #526:
URL: https://github.com/apache/poi/pull/526

   Bumps de.thetaphi.forbiddenapis from 3.5.1 to 3.6.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=de.thetaphi.forbiddenapis&package-manager=gradle&previous-version=3.5.1&new-version=3.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 67475] [PATCH] TEXT function corner cases

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67475

Jakub  changed:

   What|Removed |Added

 OS||All
Summary|TEXT function corner cases  |[PATCH] TEXT function
   ||corner cases

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 67475] TEXT function corner cases

2023-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67475

Jakub  changed:

   What|Removed |Added

 CC||jakub.vojti...@gmail.com

--- Comment #1 from Jakub  ---
Created attachment 39086
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=39086&action=edit
A patch fixing corner cases mark as yellow, adding unit tests

Please see the attached patch for the TEXT function corner cases marked as
yellow in the attached workbook as per my previous comment. The patch also adds
corresponding test cases to the ss.formula.functions.TestText.java class.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org