[Bug 68094] In 5.2.4 After called autoSizeColumn function, the returned column width is smaller than in 5.2.3, which makes the columns to be cut off

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68094

--- Comment #11 from Dominik Stadler  ---
See https://bz.apache.org/bugzilla/attachment.cgi?id=39602 in bug #68245 for a
standalone project to compare results of the two versions.

Things to note from this test-case:
* LibreOffice shows the columns properly, only Excel shows columns as "too
small", so not even the UIs agree on how to handle this :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68094] In 5.2.4 After called autoSizeColumn function, the returned column width is smaller than in 5.2.3, which makes the columns to be cut off

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68094

Dominik Stadler  changed:

   What|Removed |Added

 CC||keilho...@gmail.com

--- Comment #10 from Dominik Stadler  ---
*** Bug 68245 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68245] Unable to autosize columns since 5.2.4

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68245

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE

--- Comment #5 from Dominik Stadler  ---
Thanks for the updated information, you are right, Excel shows the columns too
small, while LibreOffice displays it properly (also on Windows).

We are discussing some changes between in 5.2.3/4 -> 5.2.5 at bug #68094,
hopefully it will also cover this one.

*** This bug has been marked as a duplicate of bug 68094 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68245] Unable to autosize columns since 5.2.4

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68245

--- Comment #4 from keilho...@gmail.com ---
Created attachment 39602
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=39602&action=edit
sample project V2 with screenshots

I added v2 of the project. I updated all other dependencies.
Added two screenshots under src/main/resources
Also added two Excels under src/main/test

If I change poiOoxmlVersion in gradle.properties to 5.2.5 the error occurs:
## set to 5.2.3 in order to work!!
poiOoxmlVersion=5.2.5

with 5.2.3 autosizing works fine.

No other changes on the computer between the changes.

I open the Excel with Microsoft Excel, not with OpenOffice...

Maybe that is the problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68524] Writing XLSX fails silently in POI 5.2.5

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68524

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Dominik Stadler  ---
No update for some time, thus closing, please reopen with code which allows to
reproduce the problem if you are still having issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67646] Append rows in SXSSF workbook does not work

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67646

Dominik Stadler  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67646] Append rows in SXSSF workbook does not work

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67646

Dominik Stadler  changed:

   What|Removed |Added

   Keywords|PatchAvailable  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67646] Append rows in SXSSF workbook does not work

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67646

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Dominik Stadler  ---
Please attach the proposed changes or create a pull-request at
https://github.com/apache/poi so we can take a look if it is generally useful
to change things here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67774] Support empty string ContentType in OPC package

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67774

Dominik Stadler  changed:

   What|Removed |Added

 OS||All
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68137] PPTX2PNG doesn't use fonts supplied via -fontdir

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68137

Dominik Stadler  changed:

   What|Removed |Added

 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68231] removeAllCells()@HSSFRow can raise an exception issue

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68231

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Dominik Stadler  ---
This is not an issue Apache POI as the cell-array is not changed when removing.
Also it seems a similar change was already applied in 2016.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68233] addDataField(DataConsolidateFunction,int,String,String)@XSSFPivotTable can build a wrong mapping

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68233

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEEDINFO|RESOLVED

--- Comment #2 from Dominik Stadler  ---
No update for some time, thus closing this for now as we likely won't fix
anything until it is clear that this is a real problem.

Furthermore when looking at STDataConsolidateFunction.Enum and
DataConsolidateFunction, I think the indices of the two enums are equal, so it
would even introduce a bug if we would apply this change. 

Not sure if things are different for NPOI, but you might check if the change is
even useful there or actually introduced a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68234] getBytesInCodePage(String,int)@CodePageUtil can fail to set encoding.

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68234

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEEDINFO|RESOLVED

--- Comment #2 from Dominik Stadler  ---
As mentioned by PJ, this is likely not something that we want to change even if
NPOI decided to handle it this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68094] In 5.2.4 After called autoSizeColumn function, the returned column width is smaller than in 5.2.3, which makes the columns to be cut off

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68094

--- Comment #9 from Dominik Stadler  ---
Unfortunately autosizing often cannot be 100% accurate because of different
font-installations, special characters, operating-systems, Excel vs.
LibreOffice and other factors, so we likely cannot make it work always
perfectly!

Even when opening the same Excel file in Excel and LibreOffice, there is very
often a difference in how wide columns are.

We might consider a customizable "adjustment factor" which would allow users to
adjust it to their given environment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 51554] autoSizeColumn sets column width too small for some capital letters

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=51554

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #9 from Dominik Stadler  ---
No progress on this one for a long time, thus I am closing this for now.

Autosizing often cannot be 100% accurate because of different
font-installations, special characters, operating-systems, Excel vs.
LibreOffice and other factors, so we likely cannot make it work always
perfectly!

Even when opening the same Excel file in Excel and LibreOffice, there is very
often a big difference in how wide columns are!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 64811] autoSizeColumn too small if cell contains special characters

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64811

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Dominik Stadler  ---
No response for a long time, thus closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68245] Unable to autosize columns since 5.2.4

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68245

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #3 from Dominik Stadler  ---
I tried to reproduce this but could not see any difference between 5.2.3 and
5.2.5 when using LibreOffice to display the resulting file.

Maybe there is some other change locally for you which affects this? 

Maybe some font-installation issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68666] Bump max record size in PropertySet->VariantSupport

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68666

--- Comment #4 from Dominik Stadler  ---
FYI, this uses CodePageString#getMaxRecordLength(), so
CodePageString#setMaxRecordLength() can be used to allow more in case it is
really needed. 

Also the generic IOUtils.setByteArrayMaxOverride() can already be used to
provide a global higher value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60417] autoSizeColumn(int i) swallows interrupted exception and resets interrupted flag

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60417

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #2 from Dominik Stadler  ---
Tried to analyze this, but I fear there is nothing we can do about it. 

It seems to happen deep inside AWT text handling and it seems to be related to
how much time elapsed, i.e. doing the calls quicker allows more iterations
until the state is cleared. 

So I believe AWT is doing some "time-based cleanup" here, so likely not much we
can do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Build failed in Jenkins: POI » POI-DSL-Windows-1.22 #28

[Apache Jenkins Server]

See 


Changes:

[Axel Howind] Math.toIntExact is unnecessary because value is guaranteed to be 
between 0 and 15

[Axel Howind] replace List with ByteArrayOutputStream to avoid 
boxing/unboxing and repeated copying of data

[PJ Fanning] xmlsec 3.0.4

[Axel Howind] do not write single bytes

[Axel Howind] fix Logging issues:

- don't use foreign class in Logger initialization
- update log statements to use MessageFormat syntax

[Axel Howind] make loggers static final


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
[EnvInject] - Preparing an environment for the build.
[EnvInject] - Keeping Jenkins system variables.
[EnvInject] - Keeping Jenkins build variables.
[EnvInject] - Injecting as environment variables the properties content 
FORREST_HOME=f:\jenkins\tools\forrest\latest
LANG=en_US.UTF-8
CI_BUILD=TRUE

[EnvInject] - Variables injected successfully.
[EnvInject] - Injecting contributions.
Building remotely on jenkins-win-azr-10 (Windows-Docker Windows) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Done
Updating https://svn.apache.org/repos/asf/poi/trunk at revision 
'2024-02-25T17:02:06.060 +'
U poi\src\main\java\org\apache\poi\util\HexDump.java
U poi\src\main\java\org\apache\poi\util\HexRead.java
U poi\src\main\java\org\apache\poi\util\CodepointsUtil.java
U poi\src\main\java\org\apache\poi\ss\format\CellFormat.java
U poi\src\main\java\org\apache\poi\ss\format\CellFormatPart.java
U poi\src\main\java\org\apache\poi\ss\formula\WorkbookEvaluator.java
U poi\src\main\java\org\apache\poi\ss\util\SheetUtil.java
U 
poi\src\main\java\org\apache\poi\poifs\filesystem\TempFilePOIFSFileSystem.java
U 
poi\src\main\java\org\apache\poi\poifs\filesystem\POIFSDocumentPath.java
U 
poi\src\main\java\org\apache\poi\poifs\crypt\agile\AgileEncryptionVerifier.java
U poi\src\main\java\org\apache\poi\hssf\usermodel\HSSFChart.java
U 
poi\src\main\java\org\apache\poi\hssf\usermodel\helpers\HSSFColumnShifter.java
U 
poi\src\main\java\org\apache\poi\hssf\usermodel\helpers\HSSFRowShifter.java
U 
poi\src\main\java\org\apache\poi\hssf\record\AbstractEscherHolderRecord.java
U poi\src\main\java\org\apache\poi\hssf\model\InternalSheet.java
U build.gradle
U build.xml
U osgi\README.md
U osgi\pom.xml
U poi-ooxml\build.gradle
U poi-ooxml\src\main\java\org\apache\poi\xssf\streaming\Zip64Impl.java
U 
poi-ooxml\src\main\java\org\apache\poi\xssf\streaming\SXSSFCreationHelper.java
U poi-ooxml\src\main\java\org\apache\poi\xssf\binary\XSSFBRelation.java
U 
poi-ooxml\src\main\java\org\apache\poi\openxml4j\util\ZipSecureFile.java
U 
poi-ooxml\src\main\java\org\apache\poi\openxml4j\util\ZipArchiveThresholdInputStream.java
U 
poi-ooxml\src\main\java\org\apache\poi\xddf\usermodel\chart\XDDFChartData.java
U 
poi-ooxml\src\main\java\org\apache\poi\xslf\usermodel\XSLFGraphicFrame.java
U 
poi-ooxml\src\test\java\org\apache\poi\openxml4j\opc\TestRelationships.java
U 
poi-scratchpad\src\main\java\org\apache\poi\hslf\record\EscherPlaceholder.java
U 
poi-scratchpad\src\main\java\org\apache\poi\hslf\record\SSSlideInfoAtom.java
U 
poi-scratchpad\src\main\java\org\apache\poi\hwpf\model\OfficeArtContent.java
U poi-scratchpad\src\main\java\org\apache\poi\hwpf\model\StyleSheet.java
U poi-scratchpad\src\main\java\org\apache\poi\hwpf\HWPFDocumentCore.java
U 
poi-scratchpad\src\test\java\org\apache\poi\hwpf\converter\TestWordToTextConverter.java
U poi-scratchpad\src\test\java9\module-info.java
U jenkins\create_jobs.groovy
U poi-ooxml-lite-agent\build.gradle
U poi-excelant\build.gradle
U poi-integration\build.gradle
U poi-integration\src\test\java\org\apache\poi\stress\TestAllFiles.java

<-- Got one external: forrest.properties, svn url: 
https://svn.apache.org/repos/asf/poi/site/forrest.properties -->
Fetching 'https://svn.apache.org/repos/asf/poi/site/forrest.properties' at -1 
into 
'F:\jenkins\jenkins-home\712657a4\workspace\POI\POI-DSL-Windows-1.22\forrest.properties'
At revision 1915996


<-- Got one external: documentation, svn url: 
https://svn.apache.org/repos/asf/poi/site/src/documentation -->
Fetching 'https://svn.apache.org/repos/asf/poi/site/src/documentation' at -1 
into 
'F:\jenkins\jenkins-home\712657a4\workspace\POI\POI-DSL-Windows-1.22\src\documentation'
U src\documentation\content\xdocs\changes.xml
U src\documentation\content\xdocs\components\index.xml
At revision 1915996

At revision 1915996

No changes for https://svn.apache.org/repos/asf/poi/si

[Bug 68666] Bump max record size in PropertySet->VariantSupport

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68666

--- Comment #3 from Tim Allison  ---
Here's the stacktrace:

WARN  [pool-3-thread-6] 08:45:01,740
org.apache.tika.parser.microsoft.AbstractPOIFSExtractor Ignoring unexpected
exception while parsing summary entry DOCUMENTSUMMARYINFORMATION
org.apache.poi.util.RecordFormatException: Tried to allocate an array of length
743,564, but the maximum length for this record type is 100,000.
If the file is not corrupt and not large, please open an issue on bugzilla to
request 
increasing the maximum allowable size for this record type.
You can set a higher override value with IOUtils.setByteArrayMaxOverride()
at org.apache.poi.util.IOUtils.throwRFE(IOUtils.java:596)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.poi.util.IOUtils.checkLength(IOUtils.java:281)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.poi.util.IOUtils.safelyAllocateCheck(IOUtils.java:560)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.poi.util.IOUtils.safelyAllocate(IOUtils.java:546)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.poi.hpsf.VariantSupport.read(VariantSupport.java:255)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.poi.hpsf.Property.(Property.java:182)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.poi.hpsf.Section.(Section.java:240)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.poi.hpsf.PropertySet.init(PropertySet.java:493)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.poi.hpsf.PropertySet.(PropertySet.java:194)
~[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at
org.apache.tika.parser.microsoft.SummaryExtractor.parseSummaryEntryIfExists(SummaryExtractor.java:116)
[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at
org.apache.tika.parser.microsoft.SummaryExtractor.parseSummaries(SummaryExtractor.java:97)
[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at
org.apache.tika.parser.microsoft.OfficeParser.parse(OfficeParser.java:211)
[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at
org.apache.tika.parser.microsoft.OfficeParser.parse(OfficeParser.java:183)
[tika-app-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68666] Bump max record size in PropertySet->VariantSupport

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68666

--- Comment #2 from Tim Allison  ---
Y, completely agree, Dominik. I'll attach a stacktrace tomorrow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: Java 11 for POI 5?

[Dominik Stadler]

So I see two +1 and one -1 from comitters, one user stated a +1 for
updating support to Java 11+ in the next major version of Apache POI.

Unfortunately still not a very decisive outcome :(

So let's ask another way:


*Are you using Apache POI with Java 8 and do you think that it needs to
continue to support it in the next major version? If so, please speak up so
we know about it!*

Thanks... Dominik.


On Thu, Feb 22, 2024 at 3:59 PM Axel Howind  wrote:

> I feel really bad that I mixed up versions when I asked this. POI 5 can of
> course stay on Java 8 and everybody can be using POI 5 for as long as they
> want. With Java 11 having reached Premier Support EOL in September last
> year, we should be really having this conversation about Java 17 for POI 6
> now.
>
> IMHO anyone still running on Java 8 in 2024 either does not care about
> running the latest version of every library they use, or accepts that
> rather sooner than later his dependencies might not provide fixes for bugs
> and security issues any more.
>
> > * I am not aware of any dependency that we rely on that has fixes that
> we can't uptake if we stick to Java 8 - ie the projects still publish Java
> 8 friendly releases even if they have higher version releases that don't
> support Java 8
>
> We are talking about the next major release of POI that will be in
> production through the coming years. Dependencies that come to mind:
> - javax.xml.bind is deprecated. The natural replacement would be
> jakarta.xml.bind that already requires Java 11.
> - PDFBox will move to Java 11 in their next major version.
> - Log4J 3 is currently in beta and has bumped the required runtime version
> to Java 17 (https://logging.apache.org/log4j/3.x/release-notes.html).
>
> Why can’t we do the same thing as those dependencies you mentioned?
> Publish a Java 8 friendly POI 5 and POI 6 using a newer Java baseline?
>
> > * I am not aware of any major Java runtime features that we need to
> uptake that are not in Java 8
>
> I am also not aware of any runtime features that POI needs that could not
> have been solved in Java 4. But what we end up with is code that is slow
> and adds maintenance cost that enables POI to be compatible with Java 8 and
> is completely useless on Java 11+.
>
> - Improved I/O in Java 11:
>
>   Take the IOUtils.copy() methods as an example. They could be replaced by
> a single IOStream.transferTo() call in Java 11 but we still copy every byte
> manually.
>
>   Another example: there are several toByteARRAY() METHODS IN IoUtils that
> are all implemented by calling this method:
>
> private static byte[] toByteArray(InputStream stream, final int
> length, final int maxLength,
>   final boolean checkEOFException,
> final boolean isLengthKnown) throws IOException {
> if (length < 0 || maxLength < 0) {
> throw new RecordFormatException("Can't allocate an array of
> length < 0");
> }
> final int derivedMaxLength = Math.max(maxLength,
> BYTE_ARRAY_MAX_OVERRIDE);
> if ((length != Integer.MAX_VALUE) || (derivedMaxLength !=
> Integer.MAX_VALUE)) {
> checkLength(length, derivedMaxLength);
> }
>
> final int derivedLen = isLengthKnown ? Math.min(length,
> derivedMaxLength) : derivedMaxLength;
> final int byteArrayInitLen =
> calculateByteArrayInitLength(isLengthKnown, length, derivedMaxLength);
> final int internalBufferLen = DEFAULT_BUFFER_SIZE;
> try (UnsynchronizedByteArrayOutputStream baos =
> UnsynchronizedByteArrayOutputStream.builder().setBufferSize(byteArrayInitLen).get())
> {
> byte[] buffer = new byte[internalBufferLen];
> int totalBytes = 0, readBytes;
> do {
> readBytes = stream.read(buffer, 0,
> Math.min(internalBufferLen, derivedLen - totalBytes));
> totalBytes += Math.max(readBytes, 0);
> if (readBytes > 0) {
> baos.write(buffer, 0, readBytes);
> }
> checkByteSizeLimit(totalBytes);
> } while (totalBytes < derivedLen && readBytes > -1);
>
> if (BYTE_ARRAY_MAX_OVERRIDE < 0 && readBytes > -1 &&
> !isLengthKnown && stream.read() >= 0) {
> throwRecordTruncationException(derivedMaxLength);
> }
>
> if (checkEOFException && derivedLen != Integer.MAX_VALUE &&
> totalBytes < derivedLen) {
> throw new EOFException("unexpected EOF - expected len: " +
> derivedLen + " - actual len: " + totalBytes);
> }
>
> return baos.toByteArray();
> }
> }
>
> In Java 11, you’d call either stream.readNBytes() or stream.readAllBytes()
> and put away with the IoUtils.toByteArray() implementation.
>
> - String improvements:
>
>   Currently we have to use code like `textContent.trim().split("\n“)` to
> create an array of lines and then use a for-each loop to process the
> entries. Not only i

[Bug 67778] null pointer Exception for Area3Dpxg type in ExternalReference in Formula Evaluation

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67778

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Dominik Stadler  ---
Seems some checks were added here, thus closing this for now. 

Please report new issues if there are still some missing in latest versions of
Apache POI. At least version 5.2.5 should include the changes from here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 66679] Cells without explicit style use column style as default

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66679

Dominik Stadler  changed:

   What|Removed |Added

 Blocks||68031


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=68031
[Bug 68031] The inconsistency about default column style
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 56525] XSSFSheet.getColumnStyle doesn't conform to Sheet.getColumnStyle API doc

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=56525

Dominik Stadler  changed:

   What|Removed |Added

 Blocks||68031


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=68031
[Bug 68031] The inconsistency about default column style
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68031] The inconsistency about default column style

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68031

Dominik Stadler  changed:

   What|Removed |Added

 Depends on||56525, 66679
 OS||All


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=56525
[Bug 56525] XSSFSheet.getColumnStyle doesn't conform to Sheet.getColumnStyle
API doc
https://bz.apache.org/bugzilla/show_bug.cgi?id=66679
[Bug 66679] Cells without explicit style use column style as default
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68094] In 5.2.4 After called autoSizeColumn function, the returned column width is smaller than in 5.2.3, which makes the columns to be cut off

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68094

Dominik Stadler  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 55324] formula returning #VALUE

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=55324

Dominik Stadler  changed:

   What|Removed |Added

 Blocks||68258


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=68258
[Bug 68258] Nested functions in IF formulas don't get evaluated
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 55747] nested function in IF's in formulas produce #VALUE! error in excel

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=55747

Dominik Stadler  changed:

   What|Removed |Added

 Blocks||68258


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=68258
[Bug 68258] Nested functions in IF formulas don't get evaluated
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68258] Nested functions in IF formulas don't get evaluated

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68258

Dominik Stadler  changed:

   What|Removed |Added

 Depends on||55747, 55324


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=55324
[Bug 55324] formula returning #VALUE
https://bz.apache.org/bugzilla/show_bug.cgi?id=55747
[Bug 55747] nested function in IF's in formulas produce #VALUE! error in excel
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68298] SXSSF hyperlink shows as 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68298

Dominik Stadler  changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO

--- Comment #4 from Dominik Stadler  ---
Can you provide sample files and self-sufficient test-code which allows to 
reproduce this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68305] Invalid sheetIndex Error in formulaEvaluator.evaluate(cell) for Cell Formula with Escaped Apostrophe in Sheet Name

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68305

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Dominik Stadler  ---
Can you provide sample files and code to reproduce this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68335] java.lang.IllegalArgumentException in org.apache.poi.hssf

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68335

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #7 from Dominik Stadler  ---
Apache POI does not try to handle broken documents without throwing exceptions.

It tries to not allocate endless amounts of memory and not run into endless
loops/stackoverflow-exceptions. 

Therefore in this case it seems fine to get this type of exception when the
input data is actually a document produced by a fuzzer. 

See
https://github.com/google/oss-fuzz/tree/master/projects/apache-poi/src/main/java/org/apache/poi
for some fuzz-targets and which exceptions they currently handle "gracefully".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68358] XWPFTable.addRow places copy of XWPFTableRow CTRow in XWPFTable CTTbl

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68358

Dominik Stadler  changed:

   What|Removed |Added

 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68384] Incorrect numbering when convert PPTX to image if the slide contains sub-bullet/sub-numbering.

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68384

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 OS||All

--- Comment #1 from Dominik Stadler  ---
Please provide more information how to reproduce this, ideally as
self-sufficient test-case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68385] Getting Repaired Records: Drawing from /xl/drawings/drawing1.xml part (Drawing shape)

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68385

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Dominik Stadler  ---
Please provide more information how to reproduce this, ideally as
self-sufficient test-case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68385] Getting Repaired Records: Drawing from /xl/drawings/drawing1.xml part (Drawing shape)

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68385

Dominik Stadler  changed:

   What|Removed |Added

 OS||All
   Severity|normal  |regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68387] Issue with adding photos when working concurrently with SXSSFWorkbook.

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68387

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #1 from Dominik Stadler  ---
See item "20. Can I access/modify workbooks/documents/slideshows in multiple
threads?" in the FAQ at https://poi.apache.org/help/faq.html

"In short: Handling different document-objects in different threads will work.
Accessing the same document in multiple threads will not work."

Feel free to suggest PRs, but keep in mind that we do not plan to allow to
process a single workbook object in multiple threads as it is very hard to do
correctly and it would likely degrade performance when processing very large
files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68490] in class XWPFDocument, there is no possiblity to add new XWPFSDT to the IBodyElement list

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68490

Dominik Stadler  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: Why is org.gradle.caching not enabled?

[Dominik Stadler]

Hi,

Thanks for the research,it seems I committed this back in 2021:

Use parallel build to speed up building and running tests
>
> Enable parallel building and parallel test-execution
> Provide a configuration to still build/test serially on CI
> via CI_BUILD=TRUE gradle --no-parallel --max-workers=1 clean build
> Adjust Jenkins DSL to set CI_BUILD to avoid problems in CI
> Adjust TestAllFiles to not fail when parallel builds are enabled
> Reduce memory settings to reduce requirements on build-environments
> Add gradle plugin to list task-dependencies
>
> Thanks to Andreas Reichel for the PR
>
> Closes #275


Some more details are at https://github.com/apache/poi/pull/275

I could not find a reason why we needed to keep caching disabled back then,
so I'd say go for it, we can revert it easily if we find issues with it.

Thanks... Dominik.


On Sun, Feb 25, 2024 at 11:38 AM Axel Howind  wrote:

> Hi,
>
> PJ mentioned in the "Java 11“ thread that poi-ooxml-lite build times were
> slow, so I eaned to look into this. I saw the following comment in
> build.gradle.properties:
>
> # Activating will be much faster, but break the build of
> 'poi-ooxml-lite‘
> # @todo: look into poi-ooxml-lite task generateModuleInfo and enforce
> running whatever is needed before
> org.gradle.caching=false
>
> To test, I set org.gradle.caching to true and did several clean and build
> runs both of the parent project and ooxml-lite and everything passed
> without error. Is the problem maybe already solved? Could be a change in
> the build files or fixed by a gradle update. If nobody knows why it is
> still disabled, maybe we should try to enable the caching again and see if
> it works now. If not, we at least know that it really still breaks the
> build.
>
> I am sorry if this has been discussed on the mailing list and I missed it.
> I have been away for a while because of my day job and more pressing
> problems I had with other projects that I need for my project.
>
> Cheers,
> Axel
>
>

Spill with XLOOKUP function

[百瀬孝紀]

Are there any plans to release the following?
Spill with XLOOKUP function on MicroSoft Excel.

May I help implements this feature?

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Why is org.gradle.caching not enabled?

[Axel Howind]

Hi,

PJ mentioned in the "Java 11“ thread that poi-ooxml-lite build times were slow, 
so I eaned to look into this. I saw the following comment in 
build.gradle.properties:

# Activating will be much faster, but break the build of 'poi-ooxml-lite‘
# @todo: look into poi-ooxml-lite task generateModuleInfo and enforce 
running whatever is needed before
org.gradle.caching=false

To test, I set org.gradle.caching to true and did several clean and build runs 
both of the parent project and ooxml-lite and everything passed without error. 
Is the problem maybe already solved? Could be a change in the build files or 
fixed by a gradle update. If nobody knows why it is still disabled, maybe we 
should try to enable the caching again and see if it works now. If not, we at 
least know that it really still breaks the build.

I am sorry if this has been discussed on the mailing list and I missed it. I 
have been away for a while because of my day job and more pressing problems I 
had with other projects that I need for my project.

Cheers,
Axel

[Bug 68652] Add constructor which allows to prevent writing changes to XSSFWorkbook back to the source file upon closing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68652

Dominik Stadler  changed:

   What|Removed |Added

Summary|Creating XSSFWorkbook with  |Add constructor which
   |path argument in|allows to prevent writing
   |constructor cause   |changes to XSSFWorkbook
   |unexpected and not  |back to the source file
   |transparent source file |upon closing
   |modification.   |
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 68666] Bump max record size in PropertySet->VariantSupport

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=68666

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Dominik Stadler  ---
A stacktrace would be good to see where exactly this is hit. 

Also we should not just increase such limits as soon as there are a few
documents which exceed them as it will dilute such safeguards over time and
would make them useless at some point.

If some are using higher values, we can add a way to configure/disable the
limit, but the default should be to stop at some point before memory is
exhausted with a certain amount of memory (a few GB?).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org