[GitHub] poi pull request #80: Remove the useless object.
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/poi/pull/80 Remove the useless object. The styly is created and modified, but its value never go outside of the method or produce any side-effect. It can be removed. http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_OBJECT You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/poi master4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit 3f51d03b3000a3527f8a1b413037412806a08f24 Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-14T17:19:35Z Remove the useless object. The styly is created and modified, but its value never go outside of the method or produce any side-effect. It can be removed. http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_OBJECT --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] poi pull request #79: Remove the method invocation of toString on a string.
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/poi/pull/79 Remove the method invocation of toString on a string. Calling String.toString() is just a redundant operation. Just use the String. http://findbugs.sourceforge.net/bugDescriptions.html#DM_STRING_TOSTRING You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/poi trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 commit 28e706c86187d033619c9590d48b16778535f88f Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-12T21:16:12Z Remove the method invocation of toString on a string. Calling String.toString() is just a redundant operation. Just use the String. http://findbugs.sourceforge.net/bugDescriptions.html#DM_STRING_TOSTRING --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] poi pull request #78: Add the "final" modifier to public static fields.
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/poi/pull/78 Add the "final" modifier to public static fields. This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/poi master6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit 6c8aa937d52f12dbc996105c89868dfaf0950c80 Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-14T18:15:34Z Add the "final" modifier to public static fields. This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL commit 6e57586107eb2f06db47d4bb7f5202f953ce017e Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-14T18:19:48Z Add the "final" modifier to public static fields. This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] poi pull request #76: Remove the redundant nullcheck of value known to be no...
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/poi/pull/76 Remove the redundant nullcheck of value known to be non-null. These source code contains redundant checks of known non-null values against the constant null. http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/poi master2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit 173e80cf132be0a6cebd6152eafd73e2538cb780 Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-12T22:17:07Z Remove the redundant nullcheck of value known to be non-null. These source code contains redundant checks of known non-null values against the constant null. http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] poi pull request #75: Replace the inefficient Number constructor with static...
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/poi/pull/75 Replace the inefficient Number constructor with static Number.valueOf() method. Using new NumberConstructor(num) is guaranteed to always result in a new object whereas Number.valueOf(num) allows caching of values to be done by the compiler, class library, or JVM. Using of cached values avoids object allocation and the code will be faster. http://findbugs.sourceforge.net/bugDescriptions.html#DM_NUMBER_CTOR http://findbugs.sourceforge.net/bugDescriptions.html#DM_FP_NUMBER_CTOR You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/poi master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/75.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #75 commit b8105b6c54da21658dea7b00966a2d57eb33bc8c Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-12T21:47:27Z Replace the inefficient Number constructor with static Number.valueOf() method. Using new NumberConstructor(num) is guaranteed to always result in a new object whereas Number.valueOf(num) allows caching of values to be done by the compiler, class library, or JVM. Using of cached values avoids object allocation and the code will be faster. http://findbugs.sourceforge.net/bugDescriptions.html#DM_NUMBER_CTOR http://findbugs.sourceforge.net/bugDescriptions.html#DM_FP_NUMBER_CTOR --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] poi pull request #74: Remove the useless condition.
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/poi/pull/74 Remove the useless condition. The value of the condition "numChars < 0" has been narrowed by a previous IfStatement. It has no effect on the current control flow. http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_CONDITION You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/poi master3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit 27d81d4211206f881306d11c46be83ee5706e8b3 Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-12T22:12:31Z Remove the useless condition. The value of the condition "numChars < 0" has been narrowed by a previous IfStatement. It has no effect on the current control flow. http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_CONDITION --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
