[GitHub] poi pull request #122: Set table and table cell widths to percentage, twips,...

2018-08-16 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/122

Set table and table cell widths to percentage, twips, or "auto".

Tested in context of real-world code

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/set-table-width

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #122


commit 2026c293d022d5931304f03b2c31b289ddb0ae23
Author: Eliot Kimber 
Date:   2018-08-15T23:03:28Z

Set table and table cell widths to percentage, twips, or "auto".




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #121: Corrected bugs in setting vertical alignment and emph...

2018-08-15 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/121

Corrected bugs in setting vertical alignment and emphasis mark. 

Refined test cases to catch the bug.

Tested with real-world code (where the failure was originally detected).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/set-vertical-align-bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #121


commit f8bc74dab1739bb635e21da318199f6351bc2dc7
Author: Eliot Kimber 
Date:   2018-08-15T17:20:16Z

Corrected bugs in setting vertical alignment and emphasis mark. Refined 
test cases to catch the bug.




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #120: Per Mark Murphy's request, make "XWPF" start of names...

2018-08-02 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/120

Per Mark Murphy's request, make "XWPF" start of names of abstract cla…



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/rename-abstract-classes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #120


commit 9271af047a3ff6d42224924ca06cf6fe01bcabc0
Author: Eliot Kimber 
Date:   2018-08-02T12:37:53Z

Per Mark Murphy's request, make "XWPF" start of names of abstract classes.




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #119: Implemented a number of new set and get methods for u...

2018-08-01 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/119

Implemented a number of new set and get methods for useful formatting…

This adds getters and setters for additional Run formatting properties. My 
goal was to implement the properties likely to be used in generating DOCX from 
non-trivial HTML documents. The only property I couldn't figure out how to set 
was underline color, which I can come back to.

I also fixed a bug in isHighlight() that returned a false positive if 
highlight was not set at all (the test case was flawed and didn't catch this 
case).

I used the built-in OOXML enums so that I could set values using the same 
strings as specified in the OO XML spec rather than having to translate them to 
e.g., uppercase keywords as used with the custom enumerations (this is why I 
implemented setVerticalAlignment() as a replacement for setSubscript() [which 
was a bad method name anyway.]

I did not implement versions of the methods that involve enumerations to 
also allow direct specification of the enumeration values themselves--I can if 
there's a need for it, but for most uses it seems more likely that string 
values will be the input, e.g., from parsing of XML or HTML or whatever.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/run-formatting-settings

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #119


commit d549b48a3857769b664c4c6dfa6c9e68f62981fc
Author: Eliot Kimber 
Date:   2018-08-01T21:23:47Z

Implemented a number of new set and get methods for useful formatting 
properties.




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #118: Added get/set for mirror margins setting

2018-07-30 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/118

Added get/set for mirror margins setting

Added get and set for even-and-odd headings setting.

I couldn't find any other simple settings that seemed useful for exposing 
on Document.

Added unit test and tested with real-world project.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/add-more-settings

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #118


commit 6653bd01af2a696ccacd77859a15ada2fcfa624f
Author: Eliot Kimber 
Date:   2018-07-30T21:08:10Z

Added get/set for mirror margins setting
Added get and set for even-and-odd headings setting.




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #117: Add getStyleWithName() to XWPFStyles

2018-07-25 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/117

Add getStyleWithName() to XWPFStyles

Make it possible to look up styles by style name.
Made use of paragraph.setStyle() clearer by refining the javadoc and 
parameter name
Added setStyle() to XWPFRun since I needed that too.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/get-style-by-name

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit 2cd1b1b330d6d65192986eff06a73938e1d43ef3
Author: Eliot Kimber 
Date:   2018-07-25T15:36:12Z

Add getStyleWithName() to XWPFStyles
Refine javadoc and parameter name for XWPFParagraph.setStyle()
Add setStyle to XWPFRun




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #116: Feature/xwpf implement endnote

2018-07-23 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/116

Feature/xwpf implement endnote

This adds XWPFEndnote, XWPFEndnotes, and abstract base class 
AbstractXWPFFootnoteEndnote, as well as corresponding methods on XWPFDocument 
and XWPFParagraph. Adds new FootnoteIdManager class to manage the IDs across 
footnotes and end notes.

Added unit tests and also tested with real-world application that generates 
working end notes and footnotes using this API.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/xwpf-implement-endnote

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit b741102acc70b9a563afb78b4eb5ff6ea2445fd3
Author: Eliot Kimber 
Date:   2018-07-22T11:53:10Z

Added missing reference to commons-compress JAR

commit 5c3957dfffd286f9ac5b4df121aab75de6a8f153
Author: Eliot Kimber 
Date:   2018-07-23T14:12:45Z

Implemented endnote API consistent with new footnote API.




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #115: Added missing reference to commons-compress JAR

2018-07-22 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/115

Added missing reference to commons-compress JAR

This jar reference was missing from the .classpath config

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi 
feature/missing-jar-in-eclipse-classpath

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #115


commit b741102acc70b9a563afb78b4eb5ff6ea2445fd3
Author: Eliot Kimber 
Date:   2018-07-22T11:53:10Z

Added missing reference to commons-compress JAR




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #114: Enhancement to XWPFFootnote and related APIs

2018-07-21 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/114

Enhancement to XWPFFootnote and related APIs

My first pass at enhancing the XWPFFootnote API.

Adds new methods createParagraph() and createTable()/createTable(rows, 
cols) to XWPFFootnote.

Adds new methods createFootnote() and removeFootnote() to XWPFDocument and 
XWPFFootnotes

Adds new method addFootnoteReference(XWPFFootnote) to XWPFParagraph

Creation of new footnote does not add any body elements. However, adding 
the first paragraph or table automatically creates the required footnote ref 
run in the first paragraph (adding the paragraph if necessary).

I also made a pass over the javadocs for XWPFFootnote.

I tested with the included unit tests and also in the context of my 
real-world project that is driving this update. That verifies, for example, 
that a multi-paragraph footnote with a table works as it should.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/XWPFFootnote-enhancements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #114


commit 57d4765dea96ba3187b9c317ec466f9165446e64
Author: Eliot Kimber 
Date:   2018-07-21T14:43:56Z

Enhancement to XWPFFootnote and related APIs




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org