Re: [DISCUSS] XMLBeans 5.2.1 release

2024-06-04 Thread stanton fisque
apologies if this is out of context

i cannot recall the final outcome if the 5.3 stream of POI was going to require 
java 11 or was that slated for some future 6.x stream?


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Jun 2, 2024, at 02:40 AM, Dominik Stadler  
> wrote:
> 
> Hi,
> 
> mass-regression-tests for upcoming POI 5.3.0 did finish now.
> 
> Very few documents failed compared to 5.2.5, most of which are caused by
> more testing/functionality, no big blockers or regressions as far as I see.
> 
> I pushed a few minor improvements to fix a few of those for the release.
> 
> 
> See
> http://people.apache.org/~centic/poi_regression/reports/index525RC1to530RC1.html
> and
> http://people.apache.org/~centic/poi_regression/reportsAll/index525RC1to530RC1.html
> for detailed results
> 
> 
> Thanks... Dominik
> 
> On Tue, May 21, 2024 at 4:36 PM Dominik Stadler 
> wrote:
> 
>> 
>> Hi P.J.
>> 
>> Would be nice if you can run those two releases, I can do the usual
>> large-scale regression test-run to mass-test the release somewhat.
>> 
>> Thanks... Dominik.
>> 
>> 
>> On Fri, May 17, 2024 at 4:19 PM PJ Fanning 
>> wrote:
>> 
>>> Hi everyone,
>>> 
>>> There are a few changes that are merged but not released.
>>> 
>>> 
>>> https://issues.apache.org/jira/browse/XMLBEANS-646?jql=project%20%3D%20XMLBEANS%20AND%20fixVersion%20%3D%20%22Version%205.2.1%22
>>> 
>>> POI 5.3.0 is something that I would like to release in the next few weeks
>>> and it would be good to get XMLBeans released first. Nothing in the
>>> XMLBeans changes is particularly useful for POI but if people are amenable,
>>> I can release manage an XMLBeans 5.2.1 release to at least get out the few
>>> improvements that we have in place.
>>> 
>>> Regards,
>>> PJ
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>>> For additional commands, e-mail: dev-h...@poi.apache.org
>>> 
>>> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: [Bug 68985] New: Unable to edit cell type on excel file that was generated via Apache Poi API (edit)

2024-05-08 Thread stanton fisque
this does not appear to be a bug.  reading the javadoc for Cell.setCellValue( 
String )

value - value to set the cell to. For formulas, we'll set the formula string, 
for String cells we'll set its value. For other types, we will change the cell 
to a string cell and set its value. If value is null then we will change the 
cell to a Blank cell.
 <>Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On May 8, 2024, at 13:04 PM, bugzi...@apache.org wrote:
> 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=68985
> 
>Bug ID: 68985
>   Summary: Unable to edit cell type on excel file that was
>generated via Apache Poi API (edit)
>   Product: POI
>   Version: unspecified
>  Hardware: PC
>Status: NEW
>  Severity: normal
>  Priority: P2
> Component: XSSF
>  Assignee: dev@poi.apache.org
>  Reporter: jengl...@xifin.com
>  Target Milestone: ---
> 
> To give a quick synopsis, I'm using Apache POI API to generate an excel file.
> After the file is generated, I am unable to apply formulas to the any of the
> modified rows. The reason appears to be related to the cell type of the cells,
> which cannot be updated after the file has generated. Even if I manually 
> change
> the cell type of the cells via the Excel spreadsheet, the changes do not take
> effect.
> 
> To reproduce, simply run the test below and open the generate excel file. If
> you manually add '=SUM(A1:A5)' to any cell to get the sum of the cells, you
> will notice that the formula is not calculating correctly.
> 
> Any help would be greatly appreciated.
> 
> Thank you
> 
> import org.apache.poi.ss.usermodel.CellType;
> import org.apache.poi.xssf.usermodel.XSSFCell;
> import org.apache.poi.xssf.usermodel.XSSFRow;
> import org.apache.poi.xssf.usermodel.XSSFSheet;
> import org.apache.poi.xssf.usermodel.XSSFWorkbook;
> 
> import java.io.FileOutputStream;
> 
> public class TestExcelWriter
> {
>public static void main(String[] args) throws Exception
>{
>XSSFWorkbook workbook = new XSSFWorkbook();
>workbook.setForceFormulaRecalculation(true);
>XSSFSheet sheet = workbook.createSheet();
> 
>int row = 0;
>String[] values = {"1.00", "2.00", "3.00", "4.00", "5.00",};
>for (String value : values)
>{
>XSSFRow newRow = sheet.createRow(row);
>XSSFCell newCell = newRow.createCell(0);
>newCell.setCellType(CellType.NUMERIC);
>newCell.setCellValue(value);
>row++;
>}
> 
>FileOutputStream out = new FileOutputStream("outputFile.xlsx");
>workbook.write(out);
>out.close();
>}
> }
> 
> -- 
> You are receiving this mail because:
> You are the assignee for the bug.
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 



Re: Java 11 for POI 5?

2024-02-19 Thread stanton fisque
something to consider, which kind of gathers a few of the opinions that have 
been discussed, maybe in a different light.

POI is in an odd situation because it is BOTH a consumer of dependencies, and 
IS also a dependency, since it is a library and not a stand-alone product.

as a consumer of dependencies, it should be partial to keeping pace with what 
it consumes.  it would be a big dis-service if POI lagged behind on its 
dependencies and ended up getting dinged for a CERT or other security issue and 
not be able to mitigate it due to being incompatible with newer versions of its 
dependencies.

though, on the other side, POI should not be too aggressive since it is 
consumed by so many other products "out in the wild". 

 i think a java-11 requirement would suffice for now.

i do not know if i am eligible (my tacit assumption is no, atm) to offer a +1, 
but if i could, i would.


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Feb 19, 2024, at 10:54 AM, Alain FAGOT BÉAREZ  wrote:
> 
> Hi,
> 
> +1 for moving to Java 11 as minimum
> 
> My opinion is that we should jump to the oldest LTS version each time one LTS 
> reached its end of life. This means that we would jump from 8 to 17 at 
> once... Which is also not so friendly to be done right now!
> 
> Kind regards,
> Alain FAGOT BÉAREZ
> 
> 
> 
> 
> ⁣Obter o BlueMail para Android ​
> 
> Em 17 de fev de 2024 09:39, em 09:39, Dominik Stadler 
>  escreveu:
>> Hi,
>> 
>> What do others thing?
>> 
>> We currently are at +2/-1 for moving to Java 11 minimum.
>> 
>> Would be good if we get a more significant number of votes for this.
>> 
>> Thanks... Dominik.
>> 
>> 
>> On Sat, Feb 3, 2024 at 10:04 PM Axel Howind  wrote:
>> 
>>> Hi,
>>> 
>>> for whatever reason I cannot reach both the Nabble and MarkMail
>> archives
>>> to check if this has been discussed before, but I think it would be a
>> good
>>> idea to bump the minimum Java version for POI 5 to 11. I’d also be ok
>> (or
>>> rather like) 17. What do you think?
>>> 
>>> Cheers,
>>> Axel
>>> 
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>>> For additional commands, e-mail: dev-h...@poi.apache.org
>>> 
>>> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: Java 11 for POI 5?

2024-02-03 Thread stanton fisque
that may very well be, BUT, many commercial shops are migrating apps from 8 and 
11 where able because the blood money for EoL java is starting to be a tax they 
don't want to pay if possible.  just like when we had to bite the bullet with 
1.1, 1.5 and 1.8, i recommend at the very least, moving up to 11, but seriously 
urge for 17.  TBH if people need 8 support, they can stick with 5.x if need be 
until they need to move up.

something to consider,

how many projects that are going to target the bleeding edge version of POI 
really need java 8 support?  my feeling is that number is so small to be 
trivial.  and if a project has the available resources to follow the newest 
version of POI, they probably have the resources to upgrade their app to a 
newer version of java.


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Feb 3, 2024, at 13:18 PM, PJ Fanning  wrote:
> 
> Current POI version is 5.2.5. So I presume the idea is to release a POI 6 
> with Java 11 only support. I'm -1 on this. I don't see any great advantage in 
> only supporting Java 11. Java 8 is still widely supported by vendors.
> 
> https://endoflife.date/oracle-jdk says 6 more years of Java 8.
> 
> 
> 
> 
> 
> 
> On Saturday 3 February 2024 at 22:04:26 GMT+1, Axel Howind  
> wrote: 
> 
> 
> 
> 
> 
> Hi,
> 
> for whatever reason I cannot reach both the Nabble and MarkMail archives to 
> check if this has been discussed before, but I think it would be a good idea 
> to bump the minimum Java version for POI 5 to 11. I’d also be ok (or rather 
> like) 17. What do you think?
> 
> Cheers,
> Axel
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: [Bug 68305] Invalid sheetIndex Error in formulaEvaluator.evaluate(cell) for Cell Formula with Escaped Apostrophe in Sheet Name

2023-12-19 Thread stanton fisque
one thing to be aware of with POI and functions, if you force a full 
recalculation on a spreadsheet that contains functions that are still "not yet 
implemented", the recalculation will fail.

i ran across this some years ago, and the work-around (in that case) was to do 
targeted recalculations rather than forcing the whole worksheet to recalculate. 
 the POI support for spreadsheet functions is pretty robust but last i saw, it 
is not exhaustive.


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Dec 16, 2023, at 21:06 PM, bugzi...@apache.org wrote:
> 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=68305
> 
> --- Comment #2 from Haider  ---
> Thank you for the test case in r1914511. We're encountering an issue in our
> application, which allows users to modify Excel files stored on S3 via a
> front-end interface, as well as through MS Online and SpreadJS. The problem
> arises during formula recalculation in sheets with names containing
> apostrophes, resulting in an 'Invalid sheetIndex: -1' error. It's not entirely
> clear if the error is due to modifications made through MS Online/SpreadJS or
> another factor.
> 
> To provide more context, our POI service receives the Excel file URL and the
> specific cell that needs to be updated. We locate and update the cell in the
> workbook and then initiate formula evaluation. Despite the formulas appearing
> correct in our logs, POI consistently returns the 'sheetIndex: -1' error. We
> would greatly appreciate any insights or suggestions for alternative 
> approaches
> to this problem.
> 
> -- 
> You are receiving this mail because:
> You are the assignee for the bug.
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: [Bug 68258] New: Nested functions in IF formulas don't get evaluated

2023-11-28 Thread stanton fisque
as an aside, i ran into a similar issue a couple years ago.  the problem then 
was trying to force an entire spreadsheet to update, which failed because 
evaluation was tripping over functions that were not implemented.  the 
workaround i used was to instead, do targeted re-evaluation of specific cells 
that i knew were harboring functions defined in the POI library.

this may provide a way through, IF you are tripping over a similar issue

Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Nov 28, 2023, at 09:15 AM, bugzi...@apache.org wrote:
> 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=68258
> 
>Bug ID: 68258
>   Summary: Nested functions in IF formulas don't get evaluated
>   Product: POI
>   Version: unspecified
>  Hardware: PC
>Status: NEW
>  Severity: normal
>  Priority: P2
> Component: XSSF
>  Assignee: dev@poi.apache.org
>  Reporter: spy...@neotalogic.com
>  Target Milestone: ---
> 
> Created attachment 39419
>  --> https://bz.apache.org/bugzilla/attachment.cgi?id=39419=edit
> Spreadsheet with nested IF formulas
> 
> I'm facing a problem that seems similar to bugs 55747 and 55324. In 
> particular,
> I'm trying to set values for a few cells in the attached Spreadsheet and then
> evaluate all formulas in the worksheet. All formula results come back as
> "#VALUE!". When I set the "setForceFormulaRecalculation" flag to TRUE, upon
> opening the saved Spreadsheet, Excel evaluates everything properly.
> 
> Relevant information:
> Scala version 2.13.8
> Java runtime: openjdk version "1.8.0_362" 64 bit
> org.apache.poi.poi version 5.2.5 (also reproduced in 5.2.4 and 5.2.2)
> org.apache.poi.poi-ooxml version 5.2.5 (also reproduced in 5.2.4 and 5.2.2)
> 
> I'm trying to set values for the following cells:
> Loan amount - E3
> Annual interest rate - E4
> Loan period in years - E5
> Number of payments per year - E6
> Start date of loan - E7
> Optional extra payments - E9
> 
> And I want to read back the results after computing all formulas for the
> following cells:
> Scheduled payment - I3
> Scheduled number of payments - I4
> Actual number of payments - I5
> Total early payments - I6
> Total interest - I7
> LENDER NAME - "LenderName"
> 
> Note that reading the "LenderName" cell value works just fine.
> 
> 
> What I've tried in terms of evaluation:
> val wb = XSSFWorkbookFactory.createWorkbook(pkg)
> 
> 
> Method 1:
> 1. Set all desired cell values in wb
> 2. Evaluate all formulas after all values have been set:
> XSSFFormulaEvaluator.evaluateAllFormulaCells(wb)
> 
> Method 2:
> 1. Create a single evaluator for the wb: val evaluator =
> wb.getCreationHelper.createFormulaEvaluator
> 2. Set all desired cell values in wb
> 3. Evaluate all formulas after all values have been set: evaluator.evaluateAll
> 
> Method 3:
> 1. Create a single evaluator for the wb: val evaluator =
> wb.getCreationHelper.createFormulaEvaluator
> 2. Set all desired cell values in wb
> 3. For each cell after setting its value, call notifyUpdateCell
> 4. Evaluate all formulas after all values have been set: evaluator.evaluateAll
> 
> Method 4:
> 1. Create a single evaluator for the wb: val evaluator =
> wb.getCreationHelper.createFormulaEvaluator
> 2. Set all desired cell values in wb
> 3. For each cell after setting its value, call notifySetFormula
> 4. Evaluate all formulas after all values have been set: evaluator.evaluateAll
> 
> Method 5:
> 1. Set all desired cell values in wb
> 2. For each cell after setting its value, call notifyUpdateCell
> 3. Evaluate all formulas after all values have been set:
> XSSFFormulaEvaluator.evaluateAllFormulaCells(wb)
> 
> Method 6:
> 1. Set all desired cell values in wb
> 2. For each cell after setting its value, call notifySetFormula
> 3. Evaluate all formulas after all values have been set:
> XSSFFormulaEvaluator.evaluateAllFormulaCells(wb)
> 
> Note that I'm always setting wb.setForceFormulaRecalculation(true) before
> evaluating all formulas (in case it matters)
> 
> I think I've tried all possible combinations this might work as indicated in
> the documentation. I've even tried using evaluator.evaluateInCell as an
> extension of methods 3, 4, 5 and 6 whenever setting the value for a cell, just
> in case (I've tried both creating a new evaluator for every cell, or re-using
> the same one), but nothing worked.
> 
> -- 
> You are receiving this mail because:
> You are the assignee for the bug.
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: [Bug 60848] SUMPRODUCT fails when first arg is of form --(...)

2023-10-13 Thread stanton fisque
there is a use case, and i have used it, so i will raise a counter comment for 
POI to retain running calculations:

i had a project where i built a harness to load an excel spreadsheet and then 
exercise it as a system of record.  if POI were to lose the ability to perform 
that function, it would be a loss for that use case.  i do accept that it is an 
exotic case, but i'd wager it is not the only one.

as a side note, some thought could be given to (if it were deemed necessary to 
go down this route) providing a contract layer so that existing functionality 
could be retained as an extension library.  the current implementation allows 
for runtime patching of the execution engine (i  had to use this for a missing 
function before PJF accepted  a PR from me sometime ago), so there is a minimal 
contract in place already.


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Oct 13, 2023, at 05:27 AM, bugzi...@apache.org wrote:
> 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=60848
> 
> --- Comment #15 from PJ Fanning  ---
> I think it was a big mistake for POI to start evaluating formulas. It is too
> complicated and there are not enough devs interested. It doesn't just take
> someone to submit a change. It takes multiple people to review it.
> 
> 
> Releases are irregular.
> 
> Does anyone need POI to calculate formulas? The answer is no. Excel can be 
> made
> to recalculate the formulas when you load the xlsx into Excel.
> 
> See
> https://poi.apache.org/apidocs/dev/org/apache/poi/xssf/usermodel/XSSFWorkbook.html#setForceFormulaRecalculation-boolean-
> 
> -- 
> You are receiving this mail because:
> You are the assignee for the bug.
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: POI PMC roll call

2023-03-03 Thread stanton fisque
yes, fully aware of many of these points.  i'll continue to contribute 
when/where able.

TIA


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Mar 3, 2023, at 10:53 AM, PJ Fanning  wrote:
> 
> Thanks Hamza and Stanton for expressing an interest in contributing to POI.
> 
> For newbies, the best place to start is 
> https://poi.apache.org/devel/index.html
> 
> The documentation is basic but the tools we use are well documented on the 
> web. Subversion, Git, Gradle.
> 
> If you any specific questions, the POI 'user' mailing list might be the best 
> place to ask as the 'dev' list has a lot of automated emails on it that can 
> obscure emails from real people with questions.
> 
> There is a big backlog of issues in Bugzilla [1]. We get some issues raised 
> that have good descriptions but we get lots that are not very well described 
> or that are raised due to misunderstandings as to what the POI lib does.
> 
> We don't have a road map. If you have any ideas about features that are 
> missing, raise Bugzilla issues where they can be discussed.
> 
> I'm afraid that I don't think POI is the sort of code base that you want to 
> dive into unless you have a vested interest in getting a particular problem 
> solved.
> 
> 
> 
> [1] 
> https://bz.apache.org/bugzilla/buglist.cgi?bug_status=__open___id=203815=changeddate%20DESC%2Cpriority%2Cbug_severity=POI_format=specific
> 
> 
> 
> On Friday 3 March 2023 at 17:18:48 GMT+1, stanton fisque  
> wrote: 
> 
> 
> 
> 
> 
> i am not a PMC member, BUT as one of the multitude of contributors interested 
> in the liveliness of POI, i am curious what is involved with keeping this 
> project alive and moving (even if it is at a modest rate)?
> 
> 
> Stanton Fisque
> principal technologist
> latticeware.com
> portland, oregon
> 
>> On Mar 3, 2023, at 08:14 AM, Hamza Gobir  
>> wrote:
>> 
>> I'm interested on working on tickets but I'm having issues setting up my
>> Dev environment.
>> 
>> Are there any resources you can point me to?
>> 
>> 
>> On Fri, 3 Mar 2023, 14:26 PJ Fanning,  wrote:
>> 
>>> Hi everyone,
>>> 
>>> Apologies if anyone thinks I'm going in the wrong direction here. The TLDR
>>> is: I am asking if PMC members could respond with whether they are still
>>> interested in working on POI or if they are no longer in a position to help.
>>> 
>>> There appears to only be a couple of POI PMC members that are active at
>>> this stage (on mailing lists, dealing with bugzilla, Github commits, etc.).
>>> 
>>> I'm not seeking anything drastic like considering retiring POI (aka moving
>>> to the Attic). It is suggested in ASF guidelines that mature projects
>>> occasionally do a Roll Call [1]. There doesn't appear to be many people
>>> that we could look to invite to become committers or PMC members.
>>> 
>>> I'm interested in continuing but would like to cut back my involvement. I
>>> am involved in a few other ASF projects and want to concentrate on those.
>>> 
>>> Even if we do have a few active PMC members, we might want to consider
>>> guide lines on what sort of code changes to make and how often we intend to
>>> do releases.
>>> 
>>> The code base is very large and I have to admit some of patches that I
>>> merge that are submitted by outside contributors - that I don't know that
>>> part of the code base well and am reliant on the test coverage to pick up
>>> issues. And we have a lot of code that does not have great test coverage.
>>> Most of the patches come with minimal new tests - there are definitely
>>> exceptions - some of the patches are of very high quality.
>>> 
>>> It's also hard to keep up with new features in Microsoft file formats (ie
>>> new XSDs) and the Java Runtime is being overhauled in ways that may
>>> eventually break some POI code.
>>> 
>>> Regards,
>>> PJ
>>> 
>>> 
>>> [1] https://www.apache.org/dev/pmc.html#move-to-attic
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>>> For additional commands, e-mail: dev-h...@poi.apache.org
> 
>>> 
>>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: POI PMC roll call

2023-03-03 Thread stanton fisque
i am not a PMC member, BUT as one of the multitude of contributors interested 
in the liveliness of POI, i am curious what is involved with keeping this 
project alive and moving (even if it is at a modest rate)?


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Mar 3, 2023, at 08:14 AM, Hamza Gobir  
> wrote:
> 
> I'm interested on working on tickets but I'm having issues setting up my
> Dev environment.
> 
> Are there any resources you can point me to?
> 
> 
> On Fri, 3 Mar 2023, 14:26 PJ Fanning,  wrote:
> 
>> Hi everyone,
>> 
>> Apologies if anyone thinks I'm going in the wrong direction here. The TLDR
>> is: I am asking if PMC members could respond with whether they are still
>> interested in working on POI or if they are no longer in a position to help.
>> 
>> There appears to only be a couple of POI PMC members that are active at
>> this stage (on mailing lists, dealing with bugzilla, Github commits, etc.).
>> 
>> I'm not seeking anything drastic like considering retiring POI (aka moving
>> to the Attic). It is suggested in ASF guidelines that mature projects
>> occasionally do a Roll Call [1]. There doesn't appear to be many people
>> that we could look to invite to become committers or PMC members.
>> 
>> I'm interested in continuing but would like to cut back my involvement. I
>> am involved in a few other ASF projects and want to concentrate on those.
>> 
>> Even if we do have a few active PMC members, we might want to consider
>> guide lines on what sort of code changes to make and how often we intend to
>> do releases.
>> 
>> The code base is very large and I have to admit some of patches that I
>> merge that are submitted by outside contributors - that I don't know that
>> part of the code base well and am reliant on the test coverage to pick up
>> issues. And we have a lot of code that does not have great test coverage.
>> Most of the patches come with minimal new tests - there are definitely
>> exceptions - some of the patches are of very high quality.
>> 
>> It's also hard to keep up with new features in Microsoft file formats (ie
>> new XSDs) and the Java Runtime is being overhauled in ways that may
>> eventually break some POI code.
>> 
>> Regards,
>> PJ
>> 
>> 
>> [1] https://www.apache.org/dev/pmc.html#move-to-attic
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>> For additional commands, e-mail: dev-h...@poi.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: want to provide patch

2022-04-29 Thread stanton fisque
yes.  i figured that out after looking at the other PRs.  the gitflow mech that 
i'm used to had us working on branches in the same repo, not forks.  but after 
inspecting other PRs, the difference became apparent.  PR has been submitted 
for review.

TIA


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Apr 28, 2022, at 23:33 PM, Dominik Stadler  wrote:
> 
> Hi,
> 
> This is the default workflow of Github-repositories. You need to create a
> fork of the code into a new repository, create the branch there and then
> send a PR to the main repo.
> 
> The following might help:
> *
> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks
> *
> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
> * https://gist.github.com/Chaser324/ce0505fbed06b947d962
> 
> Dominik.
> 
> On Fri, Apr 29, 2022 at 7:01 AM stanton fisque  wrote:
> 
>> so i've cloned the repo, created a branch locally to make changes, added
>> the code and a corresponding unit test.  but when i try to push back, i get
>> permission failure.  it appears i cannot create a new branch, so that begs
>> the question, how does one submit a PR if they cannot create a feature
>> branch for the PR source.
>> 
>> 
>> Stanton Fisque
>> principal technologist
>> latticeware.com
>> portland, oregon
>> 
>>> On Apr 28, 2022, at 09:00 AM, Nick Burch  wrote:
>>> 
>>> On Thu, 28 Apr 2022, stanton fisque wrote:
>>>> i'd like to provide a patch for some missing functionality,
>> specifically the support handler for AverageIf (the generalized version is
>> present but not the singular version).  what is the best way to provide
>> that? is there a repo where a pull request can be provided?
>>> 
>>> Great! You'll want:
>>> * https://poi.apache.org/devel/guidelines.html
>>> * https://github.com/apache/poi
>>> 
>>> For formula functions, see also
>>> * https://poi.apache.org/components/spreadsheet/eval.html
>>> *
>> http://home.apache.org/~yegor/apachecon_us2010/Evaluation_Of_Excel_Formulas_In_POI.pptx
>>> 
>>> Nick
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>>> For additional commands, e-mail: dev-h...@poi.apache.org
>>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>> For additional commands, e-mail: dev-h...@poi.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: want to provide patch

2022-04-28 Thread stanton fisque
so i've cloned the repo, created a branch locally to make changes, added the 
code and a corresponding unit test.  but when i try to push back, i get 
permission failure.  it appears i cannot create a new branch, so that begs the 
question, how does one submit a PR if they cannot create a feature branch for 
the PR source.


Stanton Fisque
principal technologist
latticeware.com
portland, oregon

> On Apr 28, 2022, at 09:00 AM, Nick Burch  wrote:
> 
> On Thu, 28 Apr 2022, stanton fisque wrote:
>> i'd like to provide a patch for some missing functionality, specifically the 
>> support handler for AverageIf (the generalized version is present but not 
>> the singular version).  what is the best way to provide that? is there a 
>> repo where a pull request can be provided?
> 
> Great! You'll want:
> * https://poi.apache.org/devel/guidelines.html
> * https://github.com/apache/poi
> 
> For formula functions, see also
> * https://poi.apache.org/components/spreadsheet/eval.html
> * 
> http://home.apache.org/~yegor/apachecon_us2010/Evaluation_Of_Excel_Formulas_In_POI.pptx
> 
> Nick
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



want to provide patch

2022-04-28 Thread stanton fisque
i'd like to provide a patch for some missing functionality, specifically the 
support handler for AverageIf (the generalized version is present but not the 
singular version).  what is the best way to provide that?  is there a repo 
where a pull request can be provided?


Stanton Fisque
principal technologist
latticeware.com
portland, oregon


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org