[Bug 56154] [CoreProperties] - get|set - lastModifiedBy missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=56154

--- Comment #6 from Javen O'Neal  ---
I renamed these new methods to getLastModifiedByUser and setLastModifiedByUser
for clarity.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 56154] [CoreProperties] - get|set - lastModifiedBy missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=56154

Javen O'Neal  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from Javen O'Neal  ---
Applied in r1751948, r1751949, and r1751950. Will be included in POI 3.15 beta
3 release.

Updated changelog in r1751952.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 56154] [CoreProperties] - get|set - lastModifiedBy missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=56154

Danil Lopatin  changed:

   What|Removed |Added

  Attachment #34026|0   |1
   is patch||

--- Comment #4 from Danil Lopatin  ---
Comment on attachment 34026
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34026
moved tests to separate method

>Index: src/ooxml/java/org/apache/poi/POIXMLProperties.java
>===
>--- src/ooxml/java/org/apache/poi/POIXMLProperties.java(revision 
>1751911)
>+++ src/ooxml/java/org/apache/poi/POIXMLProperties.java(working copy)
>@@ -301,6 +301,12 @@
> public void setLastPrinted(String date) {
> part.setLastPrintedProperty(date);
> }
>+public String getLastModifiedBy() {
>+return part.getLastModifiedByProperty().getValue();
>+}
>+public void setLastModifiedBy(String lastModifiedBy) {
>+part.setLastModifiedByProperty(lastModifiedBy);
>+}
> public Date getModified() {
> return part.getModifiedProperty().getValue();
> }
>Index: src/ooxml/testcases/org/apache/poi/TestPOIXMLProperties.java
>===
>--- src/ooxml/testcases/org/apache/poi/TestPOIXMLProperties.java   
>(revision 1751911)
>+++ src/ooxml/testcases/org/apache/poi/TestPOIXMLProperties.java   
>(working copy)
>@@ -192,7 +192,7 @@
> 
> XWPFDocument doc2 = XWPFTestDataSamples.writeOutAndReadBack(doc);
> doc.close();
>-cp = doc.getProperties().getCoreProperties();
>+cp = doc2.getProperties().getCoreProperties();
> Date dt3 = cp.getCreated();
> assertEquals(dateCreated, dt3);
> doc2.close();
>@@ -208,6 +208,14 @@
> assertEquals("20", _coreProperties.getRevision());
> }
> 
>+@Test
>+public void testLastModifiedByProperty() {
>+String lastModifiedBy = _coreProperties.getLastModifiedBy();
>+assertEquals("Paolo Mottadelli", lastModifiedBy);
>+_coreProperties.setLastModifiedBy("Test User");
>+assertEquals("Test User", _coreProperties.getLastModifiedBy());
>+}
>+
> public static boolean dateTimeEqualToUTCString(Date dateTime, String 
> utcString) {
> Calendar utcCalendar = 
> LocaleUtil.getLocaleCalendar(LocaleUtil.TIMEZONE_UTC);
> utcCalendar.setTimeInMillis(dateTime.getTime());

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 56154] [CoreProperties] - get|set - lastModifiedBy missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=56154

Danil Lopatin  changed:

   What|Removed |Added

  Attachment #34025|0   |1
is obsolete||

--- Comment #3 from Danil Lopatin  ---
Created attachment 34026
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34026=edit
moved tests to separate method

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 56154] [CoreProperties] - get|set - lastModifiedBy missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=56154

Danil Lopatin  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 56154] [CoreProperties] - get|set - lastModifiedBy missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=56154

Danil Lopatin  changed:

   What|Removed |Added

 CC||solid.da...@gmail.com

--- Comment #2 from Danil Lopatin  ---
Created attachment 34025
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34025=edit
patch and small test

Please apply this patch to 3.15 version.
It simply adds setter and getter for lastModifiedBy.
Test with core properties has been updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org