[Bug 56705] [PATCH] XSSFWorkbook.getSheet(String) is slow with many sheets
https://bz.apache.org/bugzilla/show_bug.cgi?id=56705 David North dtn-asfb...@corefiling.co.uk changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEEDINFO|RESOLVED --- Comment #4 from David North dtn-asfb...@corefiling.co.uk --- Further review at our end suggests this optimization is no longer necessary, so the simplest thing to do is WONTFIX this one for now. I had pondered a TreeSet or some other ordered set implementation as a single point of truth for the sheets in a workbook, but it can wait for concrete requirements. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56705] [PATCH] XSSFWorkbook.getSheet(String) is slow with many sheets
https://bz.apache.org/bugzilla/show_bug.cgi?id=56705 Dominik Stadler dominik.stad...@gmx.at changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Dominik Stadler dominik.stad...@gmx.at --- I'm not sure if this is a big problem in almost all other use cases of POI as usually there are only a few sheets and getSheet() is not called that often as well. So by optimizing this one specific case we would actually add a bit more to some other methods and also make the code more complex and harder to maintain. How many sheets do you have in those workbooks? And how often do you actually call it? I wouldn't optimize this inside POI if it is simply called much too often in your case. Would it maybe be better to solve your specific case here with a small cache in your code which remembers these sheet-name to index mapping outside of POI core code and then uses getSheetAt() to have quick access? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56705] [PATCH] XSSFWorkbook.getSheet(String) is slow with many sheets
https://issues.apache.org/bugzilla/show_bug.cgi?id=56705 Nick Burch apa...@gagravarr.org changed: What|Removed |Added Keywords||PatchAvailable Status|NEW |NEEDINFO --- Comment #1 from Nick Burch apa...@gagravarr.org --- Looking at the patch, we already have a list of XSSFSheet objects, and this adds a map too by name. I can't help but wonder if we couldn't have a special kind of sorted map that provides both the old give me the sheets of the list plus the new lookup by name It's possible that my approach would be more complex or slower though, even if it would mean only one object to update instead of two Thoughts? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
