[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 Dominik Stadler changed: What|Removed |Added Blocks||46136 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 Dominik Stadler changed: What|Removed |Added Blocks||58641 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 Nick Burch changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #8 from Nick Burch --- As of r1730543, I've moved the enum into the main ss package, and documented those entries that I can from the XLS spec. That leaves a couple needing descriptions that I think are XLSX-only. I haven't added the matching HSSF support using FeatFormulaErr2, that remains for #46136 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 Nick Burch changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #7 from Nick Burch --- David - are you happy to make these changes, or do you need someone else to try? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 Dominik Stadler changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 --- Comment #6 from Nick Burch --- For the HSSF stuff, look at FeatFormulaErr2 Looks at first glance like the list is almost the same. Assuming that's really the case, it'd probably be best to put the IgnoredErrorType interface into the common SS usermodel, but without the CT stuff. Add a helper / child interface in xssf that does that part It might be good to create test .xls and .xlsx files, with some ignored errors in them, then write a XSSF-specific getter test for it I think that writing a HSSF getter for existing ignores should be quite quick, as we have the record code needed. We could then use the same test to check it Writing the HSSF add will take a bit more, as you need to create / update the right records in the right order -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 David North changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 --- Comment #5 from David North --- I've checked in an attempt at a generalised API in SVN r1724469 Nick, is that approximately what you had in mind? Whether this can be generalised to cover HSSF too is best left for bug 46136, I think. It's unclear whether all the types of ignored error are applicable to the HSSF format. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 --- Comment #4 from David North --- Excel supports multiple ignoredError elements. Furthermore, the flags on each one are not mutually exclusive, so if a given cell range has the same error(s) they can be expressed by one element. I'll work on generalising the API as suggested. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 quen...@yahoo.fr changed: What|Removed |Added CC||quen...@yahoo.fr -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892 --- Comment #3 from David North --- See also bug 54868, bug 46136 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://issues.apache.org/bugzilla/show_bug.cgi?id=56892 Dominik Stadler changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://issues.apache.org/bugzilla/show_bug.cgi?id=56892 --- Comment #2 from Nick Burch --- Thanks for this Looking at the code and unit test, I wonder if it might be worth making it a bit more general? For example, define an enum of the kinds of errors that can be ignored (taken from the ones CTIgnoredError defines), then have the method be more like: addIgnoredError(CellRangeAddress, IgnoredErrorType) (Or does that need to be a list/array of ignored types? Does Excel support setting multiple?) Bonus marks (=possible pint of your choice in a handy Oxford pub!) if you could also provide a nice getter for these ignored errors too :) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://issues.apache.org/bugzilla/show_bug.cgi?id=56892 Chris Boyle changed: What|Removed |Added Keywords||PatchAvailable -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 56892] [PATCH] Ignoring number-stored-as-text warnings requires going via CTWorksheet
https://issues.apache.org/bugzilla/show_bug.cgi?id=56892 --- Comment #1 from Chris Boyle --- Created attachment 31948 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31948&action=edit Patch to add XSSFSheet.addNumberStoredAsTextIgnoredError The attached patch adds methods on XSSFSheet to set number-stored-as-text warnings as ignored for a region without requiring the caller to dig into CTWorksheet. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
