[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 Dominik Stadler changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Dominik Stadler --- This is now applied via r1691821, thanks for the nice patch and work on the stress-test-suite! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 virtuald changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from virtuald --- Sorry for the delay, was on vacation. :) Looks like there was already a vsdx file in the test data, so I've removed the non-working version of the test and added a stub for future XDGF support, which uses the behavior introduced by this patch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 --- Comment #6 from Dominik Stadler --- Yes, it would be good to have a test-file which has such a different structure so we can verify that we can at least read some information from those as well. We already have some other files in the test-suite just to ensure that we can read some properties from them. We even have test files to verify that we cannot read them because they are corrupt! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 --- Comment #5 from virtuald --- Sorry for the delay, I've been on vacation the last few days... The changes should be mostly covered by existing tests that parse files that use the PackageRelationshipTypes.CORE_DOCUMENT namespace. The only thing that isn't covered is creating a POIXMLDocument with the new constructor. I suppose I could add a test case that calls the second constructor with PackageRelationshipTypes.CORE_DOCUMENT just for coverage's sake. Or do you want me to add a document that doesn't use CORE_DOCUMENT namespace to the test suite just for completeness? AFAIK the only thing that uses a non-core namespace are visio documents, and poi doesn't support them (yet), so it'd be odd to add a vsdx to the unit tests. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 Dominik Stadler changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Dominik Stadler --- Can you also add a few unit tests which verify the changed/added code parts? This way we ensure that it does not break with future changes. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 virtuald changed: What|Removed |Added Blocks||58087 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 virtuald changed: What|Removed |Added Hardware|PC |All OS|Mac OS X 10.1 |All --- Comment #3 from virtuald --- I noticed that there was a merge conflict, so I just rebased it and it's mergable again. Is there anything I can do to speed this along? Thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 --- Comment #2 from virtuald --- This is a pretty simple fix, can this be merged in? Thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 57484] [PATCH] Allow processing of non-OOXML core namespace packages
https://bz.apache.org/bugzilla/show_bug.cgi?id=57484 virtuald changed: What|Removed |Added Summary|Allow processing of |[PATCH] Allow processing of |non-OOXML core namespace|non-OOXML core namespace |packages|packages -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
