[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 andrey_chich...@mail.ru changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #36 from andrey_chich...@mail.ru --- I'm very sorry, seems like it is a bug only for 4.1.2 version, last 4.* version for now. We'll try to update to 5.*. In 5.2.0 version XSSFCellBorder.equals() method is extended to include diagonal border checks that we need. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #35 from PJ Fanning --- Andrey - could you provide a test case? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 andrey_chich...@mail.ru changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #34 from andrey_chich...@mail.ru --- This fix seems to be incorrect. XSSFCellBorders with different diagonal border settings are considered equals. It was working when xml representations were compared. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 Dominik Stadler changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #33 from Dominik Stadler --- Applied most of the patch via r1849969, I left out the changes to object-equals-checks, I wanted to avoid changing the behavior for now here. We very rarely see derived classes for these objects and thus the differences are likely more academic than of actual relevance. For performance, I would only change it if some objective performance measurement shows that it is contributing a lot to overall run time. "it should be faster" is often a bad guidance for doing performance optimizations. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #32 from dollinger.flor...@gmx.de --- Well, I was thinking since yesterday why and which one is preferable over the other and came to the conclusion that the method I used is maybe a bit more reliable, since a.getClass() == b.getClass() returns TRUE only, if the two Classes are really the same. In contrast, a instanceOf bClass returns also true, if a is of a subclass of b. I think that violates the equals contract on transitivity. I also found a website telling the same: http://onewebsql.com/blog/on-equals -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #31 from Mark Murphy --- (In reply to dollinger.florian from comment #30) > For: > > +if (this == o) > +return true; > > I would say it's a bit faster if the object is identical to o (in terms of > "same" not just "equal") - since the method returns immediately then. But > maybe that's not the case too often... > > > The other two if's is just what i personally like > +if (o == null) > +return false; > +if (o.getClass() != getClass()) > +return false; > > Do you think it's slower in summary? It's not necessary to do it that way... > I just thought that the Patch is not applied yet and I can modify it however > I want xD Well, there is a great debate about which is correct, but in this case, sticking with instanceof seems correct to me simply because changing to getClass is an unnecessary breaking change. Unless there is a bug introduced by the instanceof, I would keep it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #30 from dollinger.flor...@gmx.de --- For: +if (this == o) +return true; I would say it's a bit faster if the object is identical to o (in terms of "same" not just "equal") - since the method returns immediately then. But maybe that's not the case too often... The other two if's is just what i personally like +if (o == null) +return false; +if (o.getClass() != getClass()) +return false; Do you think it's slower in summary? It's not necessary to do it that way... I just thought that the Patch is not applied yet and I can modify it however I want xD -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #29 from Mark Murphy --- Comment on attachment 34871 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34871 src, version 6: improved equals method What is the purpose of this adjustment, It appears multiple times in your changes. -if(!(o instanceof XSSFFont)) return false; + +if (this == o) +return true; +if (o == null) +return false; +if (o.getClass() != getClass()) +return false; How does the new code provide a different outcome? Aren't you just replacing a java construct with a bit of reflection? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Attachment #34856|0 |1 is obsolete|| --- Comment #28 from dollinger.flor...@gmx.de --- Created attachment 34871 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34871&action=edit src, version 6: improved equals method -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #26 from dollinger.flor...@gmx.de --- Created attachment 34854 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34854&action=edit java source looks like i am too stupid to use bugzilla xD -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Attachment #34848|0 |1 is obsolete|| --- Comment #25 from dollinger.flor...@gmx.de --- Created attachment 34853 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34853&action=edit testcases -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Attachment #34850|0 |1 is obsolete|| Attachment #34851|0 |1 is obsolete|| --- Comment #24 from dollinger.flor...@gmx.de --- Created attachment 34852 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34852&action=edit corrected imports marked as patch and obsolete versions -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #23 from dollinger.flor...@gmx.de --- Created attachment 34851 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34851&action=edit corrected imports -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Attachment #34847|0 |1 is obsolete|| Attachment #34849|0 |1 is obsolete|| --- Comment #22 from dollinger.flor...@gmx.de --- Created attachment 34850 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34850&action=edit version 3: non-forced font registration again a new version with a non-forced font registration (does not create a new one if the cloned one is available) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #21 from dollinger.flor...@gmx.de --- Created attachment 34849 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34849&action=edit version 3: non-forced font registration again a new version with a non-forced font registration (does not create a new one if the cloned one is available) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #20 from dollinger.flor...@gmx.de --- Created attachment 34848 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34848&action=edit corrected test cases -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Attachment #34846|0 |1 is obsolete|| --- Comment #19 from dollinger.flor...@gmx.de --- Created attachment 34847 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34847&action=edit better version -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #18 from Dominik Stadler --- Yes, unit-tests are expected to run fine always, we had some failures on Windows recently, but they should be fixed again. If they fail for you, please post on the dev-mailing-list so we can discuss if it is a dev-setup-issue or a problem in the tests themselves. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #17 from dollinger.flor...@gmx.de --- back to NEW -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Attachment #34840|0 |1 is obsolete|| --- Comment #16 from dollinger.flor...@gmx.de --- Created attachment 34846 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34846&action=edit patch as a diff file (git) Hey Dominik, thanks for the advice, i added the patch diff file - i am not very familiar with jUnit, but I will give it a try. Btw.: Should the current repository jUnit tests run without any errors? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 Dominik Stadler changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #15 from Dominik Stadler --- Please note that providing a diff instead of the whole source of the files would be better as the whole files can quickly become outdated due to other changes to the codebase and thus will make applying the changes more and more difficult over time. See http://poi.apache.org/guidelines.html#SubmittingPatches for some automated ways of creating the patch-files. Also ideally some additional unit-tests accompany a patch so the changes are verified and stay in place correctly through future changes to the code. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 Dominik Stadler changed: What|Removed |Added Attachment #34840|text/plain |application/zip mime type|| Attachment #34840|1 |0 is patch|| -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 Dominik Stadler changed: What|Removed |Added Summary|copied cell style and CF|[PATCH] copied cell style ||and CF Keywords||PatchAvailable -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
