[GitHub] poi pull request #114: Enhancement to XWPFFootnote and related APIs

2018-07-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/poi/pull/114


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #114: Enhancement to XWPFFootnote and related APIs

2018-07-21 Thread drmacro
GitHub user drmacro opened a pull request:

https://github.com/apache/poi/pull/114

Enhancement to XWPFFootnote and related APIs

My first pass at enhancing the XWPFFootnote API.

Adds new methods createParagraph() and createTable()/createTable(rows, 
cols) to XWPFFootnote.

Adds new methods createFootnote() and removeFootnote() to XWPFDocument and 
XWPFFootnotes

Adds new method addFootnoteReference(XWPFFootnote) to XWPFParagraph

Creation of new footnote does not add any body elements. However, adding 
the first paragraph or table automatically creates the required footnote ref 
run in the first paragraph (adding the paragraph if necessary).

I also made a pass over the javadocs for XWPFFootnote.

I tested with the included unit tests and also in the context of my 
real-world project that is driving this update. That verifies, for example, 
that a multi-paragraph footnote with a table works as it should.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drmacro/poi feature/XWPFFootnote-enhancements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #114


commit 57d4765dea96ba3187b9c317ec466f9165446e64
Author: Eliot Kimber 
Date:   2018-07-21T14:43:56Z

Enhancement to XWPFFootnote and related APIs




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org