[GitHub] poi pull request #136: Implemented GEOMEAN function

2018-12-16 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/poi/pull/136


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #136: Implemented GEOMEAN function

2018-12-14 Thread gallonfizik
GitHub user gallonfizik opened a pull request:

https://github.com/apache/poi/pull/136

Implemented GEOMEAN function

Tested against Excel 2007 and according to 
All POI tests pass.
GeometricMean behavior for series containing zeros is handled.
There's also a change to MultiOperandNumeric function: now it handles 
MissingArgEvals (counts as 0).

It will make sense to squash the branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gallonfizik/poi GEOMEAN

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #136


commit 9bf17eed9cb0b3bb54f95182dbf9e70713d9f3a8
Author: gallon 
Date:   2018-12-09T12:39:11Z

implemented GEOMEAN

commit 25c83b77d223ab138f9d8fa1f6aa41715c80bd95
Author: gallon 
Date:   2018-12-14T20:54:57Z

MissingOperandNumericFunction now accepts MissingArgEvals (as 0)

commit a25eefdc6aedde974230ef8d4b84fb6208cf0960
Author: gallon 
Date:   2018-12-14T21:47:53Z

fixed GEOMEAN behavior




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org