[GitHub] poi pull request #94: New module RangeCopier.

2018-02-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/poi/pull/94


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #94: New module RangeCopier.

2018-01-30 Thread zmau
GitHub user zmau opened a pull request:

https://github.com/apache/poi/pull/94

New module RangeCopier.

RangeCopier does simple copying of regions on workbook.  It comes in two 
versions - as XSSFRangeCopier and HSSFRangeCopier. It copies regions in same 
way as Excel does - tiling destination region with source region as pattern. 
Source and destination regions may be on different sheets. 
It also takes care of formulas in copied cells.
I have also provided test classes with a few test cases, for both XSSF and 
HSSF context. Files with test data are also here.

Please take a look at my method RangeCopier.cloneCellContent(). It may be 
problematic, because I have maybe omitted some Cell attributes which should 
also be cloned.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zmau/poi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #94


commit 7422de37fb4e2db27405c3a8ac75530b46973f18
Author: zmau 
Date:   2017-11-01T13:10:58Z

Formula adjusting in context of column shifting.

commit d9351b5e381a1ed4b9b73cc774fbd901c9400dd7
Author: Dragan Jovanović 
Date:   2017-11-01T13:36:23Z

Merge branch 'trunk' into trunk

commit 45066eec434d9d0102466e5230fe18047edf1f1f
Author: zmau 
Date:   2017-11-02T14:05:12Z

fixed some details

as discussed on https://github.com/apache/poi/pull/81

commit b6c9d9fffd7109fb43f9b075fb81185c8c82ff6f
Author: zmau 
Date:   2017-11-02T14:25:59Z

Merge remote-tracking branch 'origin/trunk' into trunk

commit 9ad6ed9aca5372986de4a057aeb0a8707cba1969
Author: Dragan Jovanović 
Date:   2017-11-03T12:43:23Z

Replaced tab characters with spaces

(Other commented issues are not covered in this commit.)

commit f3e0a5001328aa2bb04a909b298ad67edbcfd375
Author: zmau 
Date:   2017-11-06T14:03:22Z

Merge remote-tracking branch 'origin/trunk' into trunk

commit 09ba25b035911fad8a9d0a4f293f21fb2ef57eca
Author: zmau 
Date:   2017-11-02T14:05:12Z

fixed some details

as discussed on https://github.com/apache/poi/pull/81
# Conflicts:
#   src/java/org/apache/poi/ss/formula/FormulaShifter.java

commit 3637c17fd069978a4e76a4f924d6cb923d9eef12
Author: Dragan Jovanović 
Date:   2017-11-08T10:59:11Z

Merge branch 'trunk' into trunk

commit c71cad8b37763fc0f750c31dbce9aa24b6d563c5
Author: zmau 
Date:   2017-11-08T11:01:15Z

Merge remote-tracking branch 'origin/trunk' into trunk

commit eddb8acba795bb5562a82d56c8d3bcdb67411243
Author: zmau 
Date:   2017-11-10T16:06:49Z

Merged version from original poi trunk, and resolved arising problems.

Fixed issues with comments-shifting while column shifting.
Changed case with shifting columns to negative index. Now it raises 
exception.
Introduced ColumnShifter and RowShifter instead of ShiftingManager.
Added column-shifting methods again.
Changed project's name back to ApachePOI

commit 59aad5b2c2943ab2df3031de1a6b2289f812aa0e
Author: zmau 
Date:   2017-11-10T16:06:49Z

Merged version from original poi. Fixed comments shifting. And more.

Merged version from original poi trunk, and resolved arising problems.
Fixed issues with comments-shifting while column shifting.
Changed case with shifting columns to negative index. Now it raises 
exception.
Introduced ColumnShifter and RowShifter instead of ShiftingManager.
Added column-shifting methods again.
Changed project's name back to ApachePOI

commit 3073d48039e41d898109acc954a45bd8a6b3ae16
Author: Dragan Jovanović 
Date:   2017-11-11T22:26:33Z

Merge branch 'trunk' into trunk

commit fb70bc3694ea9c57ca91ef9496640b71fbb30091
Author: Dragan Jovanović 
Date:   2017-11-12T12:34:14Z

Refactored column shifting

It's not generic cloning solution any more. In XSSF it is now real 
shifting. In HSSF and SXSSF it is not implemented yet.
Also :
- added checking of cross-sheet references, styles, strings and boolean 
values;
- removed XSSFShiftingManager.

commit 7f30d161719e5496f92c3e95cc0a524293c396d1
Author: Dragan Jovanović 
Date:   2017-11-12T12:34:26Z

Merge remote-tracking branch 'origin/trunk' into trunk

commit 1f0a8c4fd178c39b099dd9dddaab7f83cba82cce
Author: Dragan Jovanović 
Date:   2017-11-12T21:52:28Z

HSSF column shifting

Improved HSSFSheet.shiftColumns().
Implemented column shifting for HSSFRow .
Made content of TestXSSFSheetShiftColumns generic - now it works for both 
HSSF and XSSF.
Created ColumnShifting test classes for both XSSF and HSSF variations.

commit 12e5c339bc14b00a116ce8f12b1751ae7b3781e0
Author: Dragan Jovanović 
Date:   2017-11-13T13:51:47Z

Added JUnit test for new cell shifting methods XSSFRow and HSSFRow.