[jira] [Commented] (PIO-86) Maintain a working docker container
[ https://issues.apache.org/jira/browse/PIO-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654849#comment-16654849 ] Shinsuke Sugaya commented on PIO-86: Yes. Please file a new issue. I'll close this issue. > Maintain a working docker container > --- > > Key: PIO-86 > URL: https://issues.apache.org/jira/browse/PIO-86 > Project: PredictionIO > Issue Type: Wish >Reporter: Sara Asher >Assignee: Shinsuke Sugaya >Priority: Major > Labels: needs-discussion > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (PIO-86) Maintain a working docker container
[ https://issues.apache.org/jira/browse/PIO-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinsuke Sugaya resolved PIO-86. Resolution: Fixed > Maintain a working docker container > --- > > Key: PIO-86 > URL: https://issues.apache.org/jira/browse/PIO-86 > Project: PredictionIO > Issue Type: Wish >Reporter: Sara Asher >Assignee: Shinsuke Sugaya >Priority: Major > Labels: needs-discussion > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIO-187) Livedoc and Develop-Readme Official Docker Doc Update
Wei Chen created PIO-187: Summary: Livedoc and Develop-Readme Official Docker Doc Update Key: PIO-187 URL: https://issues.apache.org/jira/browse/PIO-187 Project: PredictionIO Issue Type: Improvement Components: Documentation Affects Versions: Future, Live Documentation Reporter: Wei Chen Fix For: Future, Live Documentation Official Docker support had been provided through [#462|https://github.com/apache/predictionio/pull/462] Based on the discussion with [~shinsuke] in PIO-86 We create another issue to track the modification of livedoc and develop readme. In this issue: 1. Create a new official Docker installation page in livedoc 2. Modify the Docker installation link in livedoc and develop readme -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-187) Livedoc and Develop-Readme Official Docker Doc Update
[ https://issues.apache.org/jira/browse/PIO-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655386#comment-16655386 ] Wei Chen commented on PIO-187: -- I will be able to work on this issue in the weekend, 2018-10-21. But if anyone will like to do this before the time, please do and assign the issue to yourself. > Livedoc and Develop-Readme Official Docker Doc Update > - > > Key: PIO-187 > URL: https://issues.apache.org/jira/browse/PIO-187 > Project: PredictionIO > Issue Type: Improvement > Components: Documentation >Affects Versions: Future, Live Documentation >Reporter: Wei Chen >Priority: Minor > Fix For: Future, Live Documentation > > > Official Docker support had been provided through > [#462|https://github.com/apache/predictionio/pull/462] > Based on the discussion with [~shinsuke] in PIO-86 > We create another issue to track the modification of livedoc and develop > readme. > In this issue: > 1. Create a new official Docker installation page in livedoc > 2. Modify the Docker installation link in livedoc and develop readme -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-185) Non-tracked Link in Apache Project page
[ https://issues.apache.org/jira/browse/PIO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655749#comment-16655749 ] ASF GitHub Bot commented on PIO-185: dszeto commented on issue #485: [PIO-185] develop Gitbox link Update URL: https://github.com/apache/predictionio/pull/485#issuecomment-431122889 Hey @Wei-1 , thanks for this PR. We only need to put this change in `livedoc` and merge it back to `develop` later. Last time we did an identical change on both branch because it was my fault of not having made sure the PR was against `livedoc`. Sorry about that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Non-tracked Link in Apache Project page > --- > > Key: PIO-185 > URL: https://issues.apache.org/jira/browse/PIO-185 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Minor > > On page: [https://projects.apache.org/project.html?predictionio] > at line 15: > -> *Git repository:* > [https://git-wip-us.apache.org/repos/asf/predictionio.git] > There is no git repo with the link. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-184) Livedoc 0.9.2 upgrade typo
[ https://issues.apache.org/jira/browse/PIO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655756#comment-16655756 ] ASF GitHub Bot commented on PIO-184: dszeto closed pull request #483: [PIO-184] livedoc 0.9.2 upgrade typo URL: https://github.com/apache/predictionio/pull/483 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/manual/source/resources/upgrade.html.md b/docs/manual/source/resources/upgrade.html.md index 075ff553b..70e4311dd 100644 --- a/docs/manual/source/resources/upgrade.html.md +++ b/docs/manual/source/resources/upgrade.html.md @@ -133,7 +133,7 @@ NOTE: If `org.apache.predictionio.data.storage.Storage` is not used at all (such - remove `import org.apache.predictionio.data.storage.Storage` and replace it by `import org.apache.predictionio.data.store.LEventStore` - change `appId` to `appName` in the XXXAlgorithmParams class. - remove this line of code: `@transient lazy val lEventsDb = Storage.getLEvents()` -- locate where `LEventStore.findByEntity()` is used, change it to `LEventStore.findByEntity()`: +- locate where `lEventsDb.findSingleEntity()` is used, change it to `LEventStore.findByEntity()`: For example, change following code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Livedoc 0.9.2 upgrade typo > -- > > Key: PIO-184 > URL: https://issues.apache.org/jira/browse/PIO-184 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Affects Versions: Live Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Trivial > Labels: documentation, easyfix > Fix For: Live Documentation > > > In this section: > [https://github.com/apache/predictionio/blob/livedoc/docs/manual/source/resources/upgrade.html.md#2-in-xxxalgorithmscala] > Line 136: > locate where *LEventStore.findByEntity()* is used, change it to > *LEventStore.findByEntity()* > Should be changed to: > locate where *lEventsDb.findSingleEntity()* is used, change it to > *LEventStore.findByEntity()* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-184) Livedoc 0.9.2 upgrade typo
[ https://issues.apache.org/jira/browse/PIO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655755#comment-16655755 ] ASF GitHub Bot commented on PIO-184: dszeto commented on issue #483: [PIO-184] livedoc 0.9.2 upgrade typo URL: https://github.com/apache/predictionio/pull/483#issuecomment-431124958 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Livedoc 0.9.2 upgrade typo > -- > > Key: PIO-184 > URL: https://issues.apache.org/jira/browse/PIO-184 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Affects Versions: Live Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Trivial > Labels: documentation, easyfix > Fix For: Live Documentation > > > In this section: > [https://github.com/apache/predictionio/blob/livedoc/docs/manual/source/resources/upgrade.html.md#2-in-xxxalgorithmscala] > Line 136: > locate where *LEventStore.findByEntity()* is used, change it to > *LEventStore.findByEntity()* > Should be changed to: > locate where *lEventsDb.findSingleEntity()* is used, change it to > *LEventStore.findByEntity()* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-185) Non-tracked Link in Apache Project page
[ https://issues.apache.org/jira/browse/PIO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655759#comment-16655759 ] ASF GitHub Bot commented on PIO-185: dszeto closed pull request #484: [PIO-185] livedoc Gitbox Link Update URL: https://github.com/apache/predictionio/pull/484 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/manual/source/community/contribute-documentation.html.md b/docs/manual/source/community/contribute-documentation.html.md index 16450663b..e4b1d55fd 100644 --- a/docs/manual/source/community/contribute-documentation.html.md +++ b/docs/manual/source/community/contribute-documentation.html.md @@ -196,7 +196,7 @@ Make sure the **apache.org** remote is attached to your `predictionio` repo, and ``` $ git remote -v -$ git remote add apache https://git-wip-us.apache.org/repos/asf/predictionio.git +$ git remote add apache https://gitbox.apache.org/repos/asf/predictionio.git ``` Then, push the `livedoc` branch. (It will be published and synced with the public GitHub mirror): This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Non-tracked Link in Apache Project page > --- > > Key: PIO-185 > URL: https://issues.apache.org/jira/browse/PIO-185 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Minor > > On page: [https://projects.apache.org/project.html?predictionio] > at line 15: > -> *Git repository:* > [https://git-wip-us.apache.org/repos/asf/predictionio.git] > There is no git repo with the link. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-185) Non-tracked Link in Apache Project page
[
https://issues.apache.org/jira/browse/PIO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655760#comment-16655760
]
ASF GitHub Bot commented on PIO-185:
dszeto closed pull request #485: [PIO-185] develop Gitbox link Update
URL: https://github.com/apache/predictionio/pull/485
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.sbt b/build.sbt
index 2a6204215..94739ff25 100644
--- a/build.sbt
+++ b/build.sbt
@@ -277,7 +277,7 @@ pomExtra := {
scm:git:github.com/apache/predictionio
-
scm:git:https://git-wip-us.apache.org/repos/asf/predictionio.git
+
scm:git:https://gitbox.apache.org/repos/asf/predictionio.git
github.com/apache/predictionio
diff --git a/doap.rdf b/doap.rdf
index 26f430fc1..05519782f 100644
--- a/doap.rdf
+++ b/doap.rdf
@@ -35,8 +35,8 @@
http://projects.apache.org/category/big-data"; />
-https://git-wip-us.apache.org/repos/asf/predictionio.git"/>
-https://git-wip-us.apache.org/repos/asf/predictionio.git"/>
+https://gitbox.apache.org/repos/asf/predictionio.git"/>
+https://gitbox.apache.org/repos/asf/predictionio.git"/>
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Non-tracked Link in Apache Project page
> ---
>
> Key: PIO-185
> URL: https://issues.apache.org/jira/browse/PIO-185
> Project: PredictionIO
> Issue Type: Bug
> Components: Documentation
>Reporter: Wei Chen
>Assignee: Wei Chen
>Priority: Minor
>
> On page: [https://projects.apache.org/project.html?predictionio]
> at line 15:
> -> *Git repository:*
> [https://git-wip-us.apache.org/repos/asf/predictionio.git]
> There is no git repo with the link.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-185) Non-tracked Link in Apache Project page
[ https://issues.apache.org/jira/browse/PIO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655758#comment-16655758 ] ASF GitHub Bot commented on PIO-185: dszeto commented on issue #484: [PIO-185] livedoc Gitbox Link Update URL: https://github.com/apache/predictionio/pull/484#issuecomment-431125139 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Non-tracked Link in Apache Project page > --- > > Key: PIO-185 > URL: https://issues.apache.org/jira/browse/PIO-185 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Minor > > On page: [https://projects.apache.org/project.html?predictionio] > at line 15: > -> *Git repository:* > [https://git-wip-us.apache.org/repos/asf/predictionio.git] > There is no git repo with the link. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-185) Non-tracked Link in Apache Project page
[ https://issues.apache.org/jira/browse/PIO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655779#comment-16655779 ] ASF GitHub Bot commented on PIO-185: Wei-1 commented on issue #485: [PIO-185] develop Gitbox link Update URL: https://github.com/apache/predictionio/pull/485#issuecomment-431131529 In this case, I will need to modify these 2 files in livedoc, because the PR for livedoc only change the Markdown files. I will file another PR in livedoc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Non-tracked Link in Apache Project page > --- > > Key: PIO-185 > URL: https://issues.apache.org/jira/browse/PIO-185 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Minor > > On page: [https://projects.apache.org/project.html?predictionio] > at line 15: > -> *Git repository:* > [https://git-wip-us.apache.org/repos/asf/predictionio.git] > There is no git repo with the link. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-185) Non-tracked Link in Apache Project page
[ https://issues.apache.org/jira/browse/PIO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655782#comment-16655782 ] ASF GitHub Bot commented on PIO-185: Wei-1 edited a comment on issue #485: [PIO-185] develop Gitbox link Update URL: https://github.com/apache/predictionio/pull/485#issuecomment-431131529 The PR for livedoc only change the **Markdown files**, so we will need to change the `doap.rdf` and `build.sbt` still. Should I submit another PR to livedoc that change these 2 files? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Non-tracked Link in Apache Project page > --- > > Key: PIO-185 > URL: https://issues.apache.org/jira/browse/PIO-185 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Minor > > On page: [https://projects.apache.org/project.html?predictionio] > at line 15: > -> *Git repository:* > [https://git-wip-us.apache.org/repos/asf/predictionio.git] > There is no git repo with the link. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-185) Non-tracked Link in Apache Project page
[ https://issues.apache.org/jira/browse/PIO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655876#comment-16655876 ] ASF GitHub Bot commented on PIO-185: Wei-1 opened a new pull request #485: [PIO-185] develop Gitbox link Update URL: https://github.com/apache/predictionio/pull/485 For files, build.sbt & doap.rdf: Update link from `https://git-wip-us.apache.org/repos/asf/predictionio.git` to `https://gitbox.apache.org/repos/asf/predictionio.git` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Non-tracked Link in Apache Project page > --- > > Key: PIO-185 > URL: https://issues.apache.org/jira/browse/PIO-185 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Minor > > On page: [https://projects.apache.org/project.html?predictionio] > at line 15: > -> *Git repository:* > [https://git-wip-us.apache.org/repos/asf/predictionio.git] > There is no git repo with the link. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-185) Non-tracked Link in Apache Project page
[ https://issues.apache.org/jira/browse/PIO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655877#comment-16655877 ] ASF GitHub Bot commented on PIO-185: dszeto commented on issue #485: [PIO-185] develop Gitbox link Update URL: https://github.com/apache/predictionio/pull/485#issuecomment-431165839 I reopened the PR so you can keep using it. You are right that those couple files need to be changed. Sorry for closing it too soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Non-tracked Link in Apache Project page > --- > > Key: PIO-185 > URL: https://issues.apache.org/jira/browse/PIO-185 > Project: PredictionIO > Issue Type: Bug > Components: Documentation >Reporter: Wei Chen >Assignee: Wei Chen >Priority: Minor > > On page: [https://projects.apache.org/project.html?predictionio] > at line 15: > -> *Git repository:* > [https://git-wip-us.apache.org/repos/asf/predictionio.git] > There is no git repo with the link. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIO-182) Add asynchronous (non-blocking) methods to LEventStore
[
https://issues.apache.org/jira/browse/PIO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656329#comment-16656329
]
ASF GitHub Bot commented on PIO-182:
Wei-1 commented on a change in pull request #482: [PIO-182] Add async methods
to LEventStore
URL: https://github.com/apache/predictionio/pull/482#discussion_r226542882
##
File path:
data/src/main/scala/org/apache/predictionio/data/store/LEventStore.scala
##
@@ -72,9 +84,61 @@ object LEventStore {
latest: Boolean = true,
timeout: Duration = defaultTimeout): Iterator[Event] = {
+import scala.concurrent.ExecutionContext.Implicits.global
Review comment:
Sorry to ask, but I will like to clarify.
The reason why we import this line in the object instead of putting it on
top is because of:
[importing global will introduce a lazy ExecutionContext
class](https://github.com/scala/scala/blob/ba9701059216c629410f4f23a2175d20ad62484b/src/library/scala/concurrent/ExecutionContext.scala#L153)
Since it will only be created when it is called, we import it in each thread
separately so we won't be using one single ExecutionContext.
Is my interpretation correct?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add asynchronous (non-blocking) methods to LEventStore
> --
>
> Key: PIO-182
> URL: https://issues.apache.org/jira/browse/PIO-182
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Naoki Takezoe
>Assignee: Naoki Takezoe
>Priority: Major
>
> The current implementation of {{LEventStore}} has only synchronous (blocking)
> methods. Since they use {{ExecutionContext.Implicit.global}}, its parallelism
> is limited up to the number of processors. This means engine server's
> parallelism is also limited if we use these methods in prediction logic.
> To solve this problem, {{Future}} version of these methods should be added to
> {{LEventStore}} and also current blocking methods should be modified to take
> {{ExecutionContext}} (as an implicit parameter).
> See also:
> https://lists.apache.org/thread.html/f14e4f8f29410e4585b3d8e9f646b88293a605f4716d3c4d60771854@%3Cuser.predictionio.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-182) Add asynchronous (non-blocking) methods to LEventStore
[
https://issues.apache.org/jira/browse/PIO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656337#comment-16656337
]
ASF GitHub Bot commented on PIO-182:
takezoe commented on a change in pull request #482: [PIO-182] Add async methods
to LEventStore
URL: https://github.com/apache/predictionio/pull/482#discussion_r226545697
##
File path:
data/src/main/scala/org/apache/predictionio/data/store/LEventStore.scala
##
@@ -72,9 +84,61 @@ object LEventStore {
latest: Boolean = true,
timeout: Duration = defaultTimeout): Iterator[Event] = {
+import scala.concurrent.ExecutionContext.Implicits.global
Review comment:
Since using `ExecutionContext.Implicits.global` is bad habit in Scala
basically, I wanted to make sure to use it only in these methods.
And your interpretation is correct. Even if we call it twice, it returns a
same instance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add asynchronous (non-blocking) methods to LEventStore
> --
>
> Key: PIO-182
> URL: https://issues.apache.org/jira/browse/PIO-182
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Naoki Takezoe
>Assignee: Naoki Takezoe
>Priority: Major
>
> The current implementation of {{LEventStore}} has only synchronous (blocking)
> methods. Since they use {{ExecutionContext.Implicit.global}}, its parallelism
> is limited up to the number of processors. This means engine server's
> parallelism is also limited if we use these methods in prediction logic.
> To solve this problem, {{Future}} version of these methods should be added to
> {{LEventStore}} and also current blocking methods should be modified to take
> {{ExecutionContext}} (as an implicit parameter).
> See also:
> https://lists.apache.org/thread.html/f14e4f8f29410e4585b3d8e9f646b88293a605f4716d3c4d60771854@%3Cuser.predictionio.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
