[GitHub] predictionio issue #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 support

2018-09-27 Thread dszeto
Github user dszeto commented on the issue:

https://github.com/apache/predictionio/pull/471
  
Merging. Thank you!


---


[GitHub] predictionio issue #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 support

2018-09-27 Thread takezoe
Github user takezoe commented on the issue:

https://github.com/apache/predictionio/pull/471
  
@dszeto Nice catch! I removed the file.


---


[GitHub] predictionio issue #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 support

2018-09-27 Thread dszeto
Github user dszeto commented on the issue:

https://github.com/apache/predictionio/pull/471
  
We should also update `bin/pio-class` to require Spark 2.0.0+. It is 
currently set to 1.6.3.


---


[GitHub] predictionio issue #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 support

2018-09-27 Thread takezoe
Github user takezoe commented on the issue:

https://github.com/apache/predictionio/pull/471
  
I added Spark 2.0.2 / Hadoop 2.6.5 test patterns and updated Spark version 
in `bin/pio-class.sh` and 
`tools/src/main/scala/org/apache/predictionio/tools/commands/Management.scala`.


---


[GitHub] predictionio issue #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 support

2018-09-27 Thread dszeto
Github user dszeto commented on the issue:

https://github.com/apache/predictionio/pull/471
  
@takezoe Looks great. I have no further comments. Thank you!


---


[GitHub] predictionio issue #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 support

2018-09-27 Thread dszeto
Github user dszeto commented on the issue:

https://github.com/apache/predictionio/pull/471
  
Just stumbled upon 
https://github.com/apache/predictionio/blob/develop/data/src/main/spark-1/org/apache/predictionio/data/SparkVersionDependent.scala.
 We probably should clean this up as well.


---