Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-07-12 Thread Lari Hotari
Ubuntu 20.04 isn't EoL yet. There isn't really a need from that perspective to 
switch away from Ubuntu 20.04 .

For Ubuntu 20.04, end of free standard support is April 2025. (Paid support EoL 
is April 2030).
(source: https://wiki.ubuntu.com/Releases)

-Lari

On 2023/06/26 09:46:53 Enrico Olivelli wrote:
> My understanding is that Ubuntu 20 is EOL.
> 
> I agree that we should cherry-pick that change (without upgrading the
> Python client) to 2.10, 2.11 and also to 3.0
> 
> Enrico
> 
> Il giorno lun 26 giu 2023 alle ore 11:10 guo jiwei
>  ha scritto:
> >
> > Hello community:
> >For this patch Use Ubuntu 22.04 for Pulsar images
> > , we need some ideas about
> > cherry-picking to other branches.
> >
> >
> > Regards
> > Jiwei Guo (Tboy)
> 


Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-07-10 Thread asn
Updating ubuntu 22.04 can fix some CVE issues. Since python client has been
removed, we don't need to build python client in pulsar docker
building stage. Instead, we can install python-client from pypi directly. I
created this PR to fix this issue.
https://github.com/apache/pulsar/pull/20770

Dave Fisher  于2023年6月30日周五 13:23写道:

> We’ve been seeing this too.
>
> The issue is that the docker build gets it mirror list from Ubuntu, some
> of the mirrors are bad, and output reveals that the patching of the
> original ubuntu image requires every patch and these eventually stall. We
> are working on improvements to mirror selection.
>
> I think a better approach is to make a base image on a schedule or on
> demand. Each docker image needed can start from that saved “ready” image,
> install the JDK, and then the Pulsar components.
>
> Best,
> Dave
>
> Sent from my iPhone
>
> > On Jun 29, 2023, at 9:41 PM, asn  wrote:
> >
> > Hi, everyone
> >
> > Since this PR cherry-picked to branch-2.11, the Docker image build
> failed.
> > The reason is this script `
> >
> https://github.com/apache/pulsar/blob/branch-2.10/docker/pulsar/scripts/install-pulsar-client.sh`
> 
> ,
> > ubuntu 20.04 python version is 3.8, but 22.04 python version is 3.10.
> >
> > Furthermore, branch-3.0 can build success because it removes cpp and
> python
> > build in this branch and master. Currently, python and cpp clients are
> > removed from pulsar, so why not cherry-pick this PR (
> > https://github.com/apache/pulsar/pull/17881) to 2.10 and 2.11 branch?
> >
> > Zixuan Liu  于2023年6月28日周三 19:02写道:
> >
> >> +1, but we need to remove the pulsar client changes.
> >>
> >> Thanks,
> >> Zixuan
> >>
> >> Zike Yang  于2023年6月28日周三 16:24写道:
> >>>
> >>> +1 for cherry-picking the PR.
> >>>
> >>> Thanks,
> >>> Zike Yang
> >>>
> >>> On Wed, Jun 28, 2023 at 4:22 PM  wrote:
> 
>  Agree with cherry-pick PR.
> 
>  Best
>  Mattison
>  On 26 Jun 2023 at 17:10 +0800, guo jiwei ,
> >> wrote:
> > Hello community:
> > For this patch Use Ubuntu 22.04 for Pulsar images
> > , we need some ideas
> >> about
> > cherry-picking to other branches.
> >
> >
> > Regards
> > Jiwei Guo (Tboy)
> >>
> >
> >
> > --
> > yaalsn
>
>

-- 
yaalsn


Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-06-29 Thread Dave Fisher
We’ve been seeing this too.

The issue is that the docker build gets it mirror list from Ubuntu, some of the 
mirrors are bad, and output reveals that the patching of the original ubuntu 
image requires every patch and these eventually stall. We are working on 
improvements to mirror selection.

I think a better approach is to make a base image on a schedule or on demand. 
Each docker image needed can start from that saved “ready” image, install the 
JDK, and then the Pulsar components.

Best,
Dave

Sent from my iPhone

> On Jun 29, 2023, at 9:41 PM, asn  wrote:
> 
> Hi, everyone
> 
> Since this PR cherry-picked to branch-2.11, the Docker image build failed.
> The reason is this script `
> https://github.com/apache/pulsar/blob/branch-2.10/docker/pulsar/scripts/install-pulsar-client.sh`,
> ubuntu 20.04 python version is 3.8, but 22.04 python version is 3.10.
> 
> Furthermore, branch-3.0 can build success because it removes cpp and python
> build in this branch and master. Currently, python and cpp clients are
> removed from pulsar, so why not cherry-pick this PR (
> https://github.com/apache/pulsar/pull/17881) to 2.10 and 2.11 branch?
> 
> Zixuan Liu  于2023年6月28日周三 19:02写道:
> 
>> +1, but we need to remove the pulsar client changes.
>> 
>> Thanks,
>> Zixuan
>> 
>> Zike Yang  于2023年6月28日周三 16:24写道:
>>> 
>>> +1 for cherry-picking the PR.
>>> 
>>> Thanks,
>>> Zike Yang
>>> 
>>> On Wed, Jun 28, 2023 at 4:22 PM  wrote:
 
 Agree with cherry-pick PR.
 
 Best
 Mattison
 On 26 Jun 2023 at 17:10 +0800, guo jiwei ,
>> wrote:
> Hello community:
> For this patch Use Ubuntu 22.04 for Pulsar images
> , we need some ideas
>> about
> cherry-picking to other branches.
> 
> 
> Regards
> Jiwei Guo (Tboy)
>> 
> 
> 
> -- 
> yaalsn



Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-06-29 Thread asn
Hi, everyone

Since this PR cherry-picked to branch-2.11, the Docker image build failed.
The reason is this script `
https://github.com/apache/pulsar/blob/branch-2.10/docker/pulsar/scripts/install-pulsar-client.sh`,
ubuntu 20.04 python version is 3.8, but 22.04 python version is 3.10.

Furthermore, branch-3.0 can build success because it removes cpp and python
build in this branch and master. Currently, python and cpp clients are
removed from pulsar, so why not cherry-pick this PR (
https://github.com/apache/pulsar/pull/17881) to 2.10 and 2.11 branch?

Zixuan Liu  于2023年6月28日周三 19:02写道:

> +1, but we need to remove the pulsar client changes.
>
> Thanks,
> Zixuan
>
> Zike Yang  于2023年6月28日周三 16:24写道:
> >
> > +1 for cherry-picking the PR.
> >
> > Thanks,
> > Zike Yang
> >
> > On Wed, Jun 28, 2023 at 4:22 PM  wrote:
> > >
> > > Agree with cherry-pick PR.
> > >
> > > Best
> > > Mattison
> > > On 26 Jun 2023 at 17:10 +0800, guo jiwei ,
> wrote:
> > > > Hello community:
> > > > For this patch Use Ubuntu 22.04 for Pulsar images
> > > > , we need some ideas
> about
> > > > cherry-picking to other branches.
> > > >
> > > >
> > > > Regards
> > > > Jiwei Guo (Tboy)
>


-- 
yaalsn


Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-06-28 Thread Zixuan Liu
+1, but we need to remove the pulsar client changes.

Thanks,
Zixuan

Zike Yang  于2023年6月28日周三 16:24写道:
>
> +1 for cherry-picking the PR.
>
> Thanks,
> Zike Yang
>
> On Wed, Jun 28, 2023 at 4:22 PM  wrote:
> >
> > Agree with cherry-pick PR.
> >
> > Best
> > Mattison
> > On 26 Jun 2023 at 17:10 +0800, guo jiwei , wrote:
> > > Hello community:
> > > For this patch Use Ubuntu 22.04 for Pulsar images
> > > , we need some ideas about
> > > cherry-picking to other branches.
> > >
> > >
> > > Regards
> > > Jiwei Guo (Tboy)


Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-06-28 Thread Zike Yang
+1 for cherry-picking the PR.

Thanks,
Zike Yang

On Wed, Jun 28, 2023 at 4:22 PM  wrote:
>
> Agree with cherry-pick PR.
>
> Best
> Mattison
> On 26 Jun 2023 at 17:10 +0800, guo jiwei , wrote:
> > Hello community:
> > For this patch Use Ubuntu 22.04 for Pulsar images
> > , we need some ideas about
> > cherry-picking to other branches.
> >
> >
> > Regards
> > Jiwei Guo (Tboy)


Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-06-28 Thread mattisonchao
Agree with cherry-pick PR.

Best
Mattison
On 26 Jun 2023 at 17:10 +0800, guo jiwei , wrote:
> Hello community:
> For this patch Use Ubuntu 22.04 for Pulsar images
> , we need some ideas about
> cherry-picking to other branches.
>
>
> Regards
> Jiwei Guo (Tboy)


Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-06-26 Thread Enrico Olivelli
My understanding is that Ubuntu 20 is EOL.

I agree that we should cherry-pick that change (without upgrading the
Python client) to 2.10, 2.11 and also to 3.0

Enrico

Il giorno lun 26 giu 2023 alle ore 11:10 guo jiwei
 ha scritto:
>
> Hello community:
>For this patch Use Ubuntu 22.04 for Pulsar images
> , we need some ideas about
> cherry-picking to other branches.
>
>
> Regards
> Jiwei Guo (Tboy)


[DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-06-26 Thread guo jiwei
Hello community:
   For this patch Use Ubuntu 22.04 for Pulsar images
, we need some ideas about
cherry-picking to other branches.


Regards
Jiwei Guo (Tboy)