Re: [VOTE] Pulsar Node.js Client Release 1.9.0 Candidate 1

2023-07-10 Thread Baodi Shi
Close the vote with 3(+1 binding) 1(+1 non-binding) 0(-1)

binding:

   - Masahiro
   - Yunze
   - Penghui


non-binding

   - Hideaki



Thanks,
Baodi Shi


On Jul 10, 2023 at 09:34:21, PengHui Li  wrote:

> +1(binding)
>
> - Install from npm
> - Run the produce and consume example [1]
>
> Regards,
> Penghui
>
> [1]
>
> https://github.com/apache/pulsar-client-node/tree/v1.9.0-rc.1#getting-started
>
> On Fri, Jul 7, 2023 at 7:32 PM Yunze Xu  wrote:
>
> +1 (binding)
>
>
> - Verified checksum and signature
>
> - Build from source on macOS m1 with Node.js v20.4.0
>
> - Run basic e2e examples
>
>
> Two additional notes:
>
> 1. You should use https://downloads.apache.org/pulsar/KEYS instead of
>
> https://dist.apache.org/repos/dist/dev/pulsar/KEYS
>
> 2. When building from the TAR source, you need to modify
>
> `pkg/mac/common.sh`. Change `ROOT_DIR=$(git rev-parse
>
> --show-toplevel)` to `ROOT_DIR=$PWD`.
>
>
> Thanks,
>
> Yunze
>
>
> On Fri, Jul 7, 2023 at 10:28 AM Masahiro Sakamoto
>
>  wrote:
>
> >
>
> > +1 (binding)
>
> >
>
> > - verified checksum and signature
>
> > - confirmed that the build was successful
>
> > - ran produce/consume
>
> >
>
> > Regards,
>
> >
>
> > Masahiro Sakamoto
>
> > Yahoo Japan Corp.
>
> > E-mail: massa...@yahoo-corp.jp
>
>
>


Re: [VOTE] Pulsar Node.js Client Release 1.9.0 Candidate 1

2023-07-09 Thread PengHui Li
+1(binding)

- Install from npm
- Run the produce and consume example [1]

Regards,
Penghui

[1]
https://github.com/apache/pulsar-client-node/tree/v1.9.0-rc.1#getting-started

On Fri, Jul 7, 2023 at 7:32 PM Yunze Xu  wrote:

> +1 (binding)
>
> - Verified checksum and signature
> - Build from source on macOS m1 with Node.js v20.4.0
> - Run basic e2e examples
>
> Two additional notes:
> 1. You should use https://downloads.apache.org/pulsar/KEYS instead of
> https://dist.apache.org/repos/dist/dev/pulsar/KEYS
> 2. When building from the TAR source, you need to modify
> `pkg/mac/common.sh`. Change `ROOT_DIR=$(git rev-parse
> --show-toplevel)` to `ROOT_DIR=$PWD`.
>
> Thanks,
> Yunze
>
> On Fri, Jul 7, 2023 at 10:28 AM Masahiro Sakamoto
>  wrote:
> >
> > +1 (binding)
> >
> > - verified checksum and signature
> > - confirmed that the build was successful
> > - ran produce/consume
> >
> > Regards,
> >
> > Masahiro Sakamoto
> > Yahoo Japan Corp.
> > E-mail: massa...@yahoo-corp.jp
>


Re: [VOTE] Pulsar Node.js Client Release 1.9.0 Candidate 1

2023-07-07 Thread Yunze Xu
+1 (binding)

- Verified checksum and signature
- Build from source on macOS m1 with Node.js v20.4.0
- Run basic e2e examples

Two additional notes:
1. You should use https://downloads.apache.org/pulsar/KEYS instead of
https://dist.apache.org/repos/dist/dev/pulsar/KEYS
2. When building from the TAR source, you need to modify
`pkg/mac/common.sh`. Change `ROOT_DIR=$(git rev-parse
--show-toplevel)` to `ROOT_DIR=$PWD`.

Thanks,
Yunze

On Fri, Jul 7, 2023 at 10:28 AM Masahiro Sakamoto
 wrote:
>
> +1 (binding)
>
> - verified checksum and signature
> - confirmed that the build was successful
> - ran produce/consume
>
> Regards,
>
> Masahiro Sakamoto
> Yahoo Japan Corp.
> E-mail: massa...@yahoo-corp.jp


RE: [VOTE] Pulsar Node.js Client Release 1.9.0 Candidate 1

2023-07-06 Thread Masahiro Sakamoto
+1 (binding)

- verified checksum and signature
- confirmed that the build was successful
- ran produce/consume

Regards,

Masahiro Sakamoto
Yahoo Japan Corp.
E-mail: massa...@yahoo-corp.jp


Re: [VOTE] Pulsar Node.js Client Release 1.9.0 Candidate 1

2023-07-06 Thread Oguni Hideaki
+1 (non-binding)

- Verified checksum and signature
- Build from source codes
- Verified pub/sub

Hideaki Oguni
Yahoo Japan Corp.



[VOTE] Pulsar Node.js Client Release 1.9.0 Candidate 1

2023-07-03 Thread Baodi Shi
Hi everyone,

This is the first release candidate for the Apache Pulsar Node.js client,
version 1.9.0.

It fixes the following issues:
https://github.com/apache/pulsar-client-node/milestone/14?closed=1

Please download the source files and review this release candidate:
- Download the source package, verify shasum and asc
- Follow the README.md  to build and run the Pulsar
Node.js client.

The release candidate package has been published to the npm registry:

https://www.npmjs.com/package/pulsar-client/v/1.9.0-rc.1


You can install it by `npm i pulsar-client@1.9.0-rc.1
--pulsar_binary_host_mirror=
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/` and
verify the package.


The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Source files:
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/pulsar-client-node-1.9.0-rc.1/


Pulsar's KEYS file containing the PGP keys we use to sign the release:
https://dist.apache.org/repos/dist/dev/pulsar/KEYS

SHA-512 checksum:

0cdf1d003061721565f27db19056843001d1153b79e4d7d907fff1eee53d8124e73a4174ed4d27466f59f52ae2ecbf1b9d6a3abe1b0465afeabc0022ee81b306
 ./apache-pulsar-client-node-1.9.0.tar.gz

The tag to be voted upon:
v1.9.0-rc.1(affba83)
https://github.com/apache/pulsar-client-node/releases/tag/v1.9.0-rc.1


Please review and vote on the release candidate #1 for the version 1.9.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)



Thanks,
Baodi Shi