Re: Publick Stable class SchemaInfoImpl breaks

2023-05-06 Thread Neng Lu
+1

The SchemaInfo class is claimed to be public and stable, but it's actually
changed even between patch releases.
This is really concerning.

On Fri, May 5, 2023 at 11:51 PM tison  wrote:

> PR-16380 adds a new field timestamp. With Lombok config auto-generate, it
> causes the constructor signature to change [2].
>
> Fortunately, we generate a builder class also, and that way remain in
> compatible.
>
> But I'd like to raise this issue that lombok annotation can break
> interfaces silently, so it requires extra attention to review Publick
> Stable class field change, even if bare addition.
>
> Best,
> tison.
>
> [1] https://github.com/apache/pulsar/pull/16380
> [2]
>
> https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537065990
>


Publick Stable class SchemaInfoImpl breaks

2023-05-06 Thread tison
PR-16380 adds a new field timestamp. With Lombok config auto-generate, it
causes the constructor signature to change [2].

Fortunately, we generate a builder class also, and that way remain in
compatible.

But I'd like to raise this issue that lombok annotation can break
interfaces silently, so it requires extra attention to review Publick
Stable class field change, even if bare addition.

Best,
tison.

[1] https://github.com/apache/pulsar/pull/16380
[2]
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537065990