Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2
Adding the Netty deps licenses, but I don't think we need to report the ASL license in our NOTICE. The license for Netty is anyway reported in our LICENSE file. On Tue, May 8, 2018 at 10:24 AM Ivan Kelly wrote: > > Created PR at https://github.com/apache/incubator-pulsar/pull/1748 > > I'll take a look, but it may be tomorrow before I get the time. > > > In some cases, the feedback for the NOTICE file has been to avoid > inclusion > > on what was not strictly required, in particular, regarding non ASL > > licensed projects. Another example was around Netty NOTICE file which was > > originally bubbled up and then we removed it after feedback. > > Netty is a strange case, because they put far too much in their notice > file. However, if there is something in the netty notice file which > refers to ASLv2 code which has been included in the netty source, and > a binary object based on that code is shipped with pulsar, then that > should be bubbled up from the netty code. As far as I can tell (and > assuming the case is the same as for bookkeeper), the part of the > netty notice which should be bubbled up to pulsar notice is: > > > The Netty Project > = > > Please visit the Netty web site for more information: > > * http://netty.io/ > > Copyright 2014 The Netty Project > > The Netty Project licenses this file to you under the Apache License, > version 2.0 (the "License"); you may not use this file except in compliance > with the License. You may obtain a copy of the License at: > > http://www.apache.org/licenses/LICENSE-2.0 > > Unless required by applicable law or agreed to in writing, software > distributed under the License is distributed on an "AS IS" BASIS, WITHOUT > WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the > License for the specific language governing permissions and limitations > under the License. > > > There is other code, which netty integrates into its code, but which > is MIT/BSD license. These should be notes in the LICENSE. > See > https://github.com/apache/bookkeeper/blob/master/bookkeeper-dist/src/main/resources/LICENSE-all.bin.txt#L368-L416 > > -Ivan > -- Matteo Merli
Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2
> Created PR at https://github.com/apache/incubator-pulsar/pull/1748 I'll take a look, but it may be tomorrow before I get the time. > In some cases, the feedback for the NOTICE file has been to avoid inclusion > on what was not strictly required, in particular, regarding non ASL > licensed projects. Another example was around Netty NOTICE file which was > originally bubbled up and then we removed it after feedback. Netty is a strange case, because they put far too much in their notice file. However, if there is something in the netty notice file which refers to ASLv2 code which has been included in the netty source, and a binary object based on that code is shipped with pulsar, then that should be bubbled up from the netty code. As far as I can tell (and assuming the case is the same as for bookkeeper), the part of the netty notice which should be bubbled up to pulsar notice is: The Netty Project = Please visit the Netty web site for more information: * http://netty.io/ Copyright 2014 The Netty Project The Netty Project licenses this file to you under the Apache License, version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at: http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. There is other code, which netty integrates into its code, but which is MIT/BSD license. These should be notes in the LICENSE. See https://github.com/apache/bookkeeper/blob/master/bookkeeper-dist/src/main/resources/LICENSE-all.bin.txt#L368-L416 -Ivan
Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2
Thanks for checking thouroughly. Created PR at https://github.com/apache/incubator-pulsar/pull/1748 In some cases, the feedback for the NOTICE file has been to avoid inclusion on what was not strictly required, in particular, regarding non ASL licensed projects. Another example was around Netty NOTICE file which was originally bubbled up and then we removed it after feedback. Matteo On Tue, May 8, 2018 at 8:08 AM Ivan Kelly wrote: > -1 > > There's quite a few issues with LICENSE and NOTICE > > > https://gist.githubusercontent.com/ivankelly/a93f06d2a3075575c43a0dd44165bac1/raw/83551daf958432f532ee53cccaa6397f0c1af7bf/pulsar-libs.org > > Some stuff is missing completely. Others are incomplete. > > Note that this only applies to the binary distribution. The source is > fine in this regard. > -- Matteo Merli
Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2
-1 There's quite a few issues with LICENSE and NOTICE https://gist.githubusercontent.com/ivankelly/a93f06d2a3075575c43a0dd44165bac1/raw/83551daf958432f532ee53cccaa6397f0c1af7bf/pulsar-libs.org Some stuff is missing completely. Others are incomplete. Note that this only applies to the binary distribution. The source is fine in this regard. -Ivan On Tue, May 8, 2018 at 12:17 PM, Masahiro Sakamoto wrote: > +1 (binding) > > Environment: CentOS 7.3 > > * checked sha1, sha512, asc > * ran standalone > * producer/consumer worked normally > * compiling and unit tests succeeded > * rat check > > Masahiro > > -- > Masahiro Sakamoto > Yahoo Japan Corp. > E-mail: massa...@yahoo-corp.jp > -- > >> -Original Message- >> From: Nozomi Kurihara [mailto:nkuri...@yahoo-corp.jp] >> Sent: Monday, May 07, 2018 7:06 PM >> To: dev@pulsar.incubator.apache.org >> Subject: RE: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2 >> >> +1 (binding) >> >> Environment: MacOS 10.13.4 >> >> * check sha1, sha512, asc >> * Bin distribution >> - start standalone >> - producer/consumer worked >> - pulsar-functions worked >> * Src distribution >> - compile and unit tests >> - RAT check >> - start standalone >> - producer/consumer worked >> - pulsar-functions worked >> >> >> Regards, >> >> Nozomi >> >> >> 差出人: Matteo Merli >> 送信日時: 2018年5月4日 8:24:04 >> 宛先: dev@pulsar.incubator.apache.org >> 件名: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2 >> >> This is the second release candidate for Apache Pulsar, version >> 2.0.0-rc1-incubating. >> >> It fixes the following issues: >> https://github.com/apache/incubator-pulsar/milestone/12?closed=1 >> >> *** Please download, test and vote on this release. This vote will stay >> open >> for at least 72 hours *** >> >> Note that we are voting upon the source (tag), binaries are provided for >> convenience. >> >> Source and binary files: >> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.0.0-r >> c1-incubating-candidate-2/ >> >> SHA-1 checksums: >> ea3e2fbbc4abbb2b785a8ff49542d26fb5225323 >> apache-pulsar-2.0.0-rc1-incubating-bin.tar.gz >> fe22b1f143f9cb347ecfabc06df440d5585eb90b >> apache-pulsar-2.0.0-rc1-incubating-src.tar.gz >> >> Maven staging repo: >> https://repository.apache.org/content/repositories/orgapachepulsar-101 >> 2/ >> >> The tag to be voted upon: >> v2.0.0-rc1-incubating-candidate-2 >> (ea1230aef81d68ac98edeee188439b350d4cadc0) >> https://github.com/apache/incubator-pulsar/releases/tag/v2.0.0-rc1-inc >> ubating-candidate-2 >> >> Pulsar's KEYS file containing PGP keys we use to sign the release: >> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS >> >> Please download the the source package, and follow the README to build >> and run the Pulsar standalone service. >> -- >> Matteo Merli >>
RE: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2
+1 (binding) Environment: CentOS 7.3 * checked sha1, sha512, asc * ran standalone * producer/consumer worked normally * compiling and unit tests succeeded * rat check Masahiro -- Masahiro Sakamoto Yahoo Japan Corp. E-mail: massa...@yahoo-corp.jp -- > -Original Message- > From: Nozomi Kurihara [mailto:nkuri...@yahoo-corp.jp] > Sent: Monday, May 07, 2018 7:06 PM > To: dev@pulsar.incubator.apache.org > Subject: RE: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2 > > +1 (binding) > > Environment: MacOS 10.13.4 > > * check sha1, sha512, asc > * Bin distribution > - start standalone > - producer/consumer worked > - pulsar-functions worked > * Src distribution > - compile and unit tests > - RAT check > - start standalone > - producer/consumer worked > - pulsar-functions worked > > > Regards, > > Nozomi > > > 差出人: Matteo Merli > 送信日時: 2018年5月4日 8:24:04 > 宛先: dev@pulsar.incubator.apache.org > 件名: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2 > > This is the second release candidate for Apache Pulsar, version > 2.0.0-rc1-incubating. > > It fixes the following issues: > https://github.com/apache/incubator-pulsar/milestone/12?closed=1 > > *** Please download, test and vote on this release. This vote will stay > open > for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.0.0-r > c1-incubating-candidate-2/ > > SHA-1 checksums: > ea3e2fbbc4abbb2b785a8ff49542d26fb5225323 > apache-pulsar-2.0.0-rc1-incubating-bin.tar.gz > fe22b1f143f9cb347ecfabc06df440d5585eb90b > apache-pulsar-2.0.0-rc1-incubating-src.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-101 > 2/ > > The tag to be voted upon: > v2.0.0-rc1-incubating-candidate-2 > (ea1230aef81d68ac98edeee188439b350d4cadc0) > https://github.com/apache/incubator-pulsar/releases/tag/v2.0.0-rc1-inc > ubating-candidate-2 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS > > Please download the the source package, and follow the README to build > and run the Pulsar standalone service. > -- > Matteo Merli >
RE: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2
+1 (binding) Environment: MacOS 10.13.4 * check sha1, sha512, asc * Bin distribution - start standalone - producer/consumer worked - pulsar-functions worked * Src distribution - compile and unit tests - RAT check - start standalone - producer/consumer worked - pulsar-functions worked Regards, Nozomi 差出人: Matteo Merli 送信日時: 2018年5月4日 8:24:04 宛先: dev@pulsar.incubator.apache.org 件名: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2 This is the second release candidate for Apache Pulsar, version 2.0.0-rc1-incubating. It fixes the following issues: https://github.com/apache/incubator-pulsar/milestone/12?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we are voting upon the source (tag), binaries are provided for convenience. Source and binary files: https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.0.0-rc1-incubating-candidate-2/ SHA-1 checksums: ea3e2fbbc4abbb2b785a8ff49542d26fb5225323 apache-pulsar-2.0.0-rc1-incubating-bin.tar.gz fe22b1f143f9cb347ecfabc06df440d5585eb90b apache-pulsar-2.0.0-rc1-incubating-src.tar.gz Maven staging repo: https://repository.apache.org/content/repositories/orgapachepulsar-1012/ The tag to be voted upon: v2.0.0-rc1-incubating-candidate-2 (ea1230aef81d68ac98edeee188439b350d4cadc0) https://github.com/apache/incubator-pulsar/releases/tag/v2.0.0-rc1-incubating-candidate-2 Pulsar's KEYS file containing PGP keys we use to sign the release: https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS Please download the the source package, and follow the README to build and run the Pulsar standalone service. -- Matteo Merli
