[jira] Created: (QPID-1994) auto-refresh mechanism can generate NPE during application shutdown
auto-refresh mechanism can generate NPE during application shutdown --- Key: QPID-1994 URL: https://issues.apache.org/jira/browse/QPID-1994 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Priority: Minor Fix For: 0.6 The automated refreshing mechanism can generate a NullPointerException if the application shutdown is timed such that a refresh is attempted during the shutdown process. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [GSoC] JMX MC progress update
Hi Robbie, I had a look at the screenshots and they look good, in some cases much better than the previous versions in terms of guessability (what the heck does this do) and such :-) Thanks for your work on this to date. When I get some time I'll try it out on Windows too, as the (mainly) solo voice of windows dev (a little) on the Java side ! Take Care, Marnie On Wed, Jul 15, 2009 at 2:41 PM, Robbie Gemmell robbie.gemm...@gmail.comwrote: Hi everyone, I have moved all my work so far on the JMX management console onto trunk now. All major new sections of the UI for existing functionality are in place now and largely complete, and i have just added an auto-refresh feature and operation status reporting, so its ready for a bit of playing with. The layout is pretty complete, although there will be some small changes: eg when additional functionality is added to the Queue mbean (copy and delete arbitrary messages, and specifying an interval for the message list after it is expanded to cope with Long values), and information from the imminent new 'system information' mbean is exposed. Another change will be expanding more of the tables/operations to allow multiple selection. There were some dialog positioning issues on Windows that i still need to look into. You can build it for a look using the instructions below, or if you are not so inclined you can find some screenshots I made earlier for Aidan here: http://people.apache.org/~robbie/qpid/gsoc/screenshots_15july2009/ Robbie === You can use the console on Windows, Linux (32 or 64bit), and Mac OS X (not tested as yet). You can get the package by using the ant 'release-bin' target from qpid/java/ which will build the console releases in qpid/java/management/eclipse-plugin/release/ NOTE: SSL is enabled by default on the broker JMX connection, using a self-signed cert in its keystore. As a result you have to supply the matching SSL truststore to the console for it to connect. Alternatively, you can just disable the SSL before launching the broker by using the option in management ssl in qpid/java/build/etc/config.xml to toggle it off. If you do want to use the SSL, you can supply the necessary details in the qpidmc.ini configuration file in the root of the console release (or buried somewhere within the .app package for OS X), which has a pre-configured example. Uncomment and change the example to the values below to match the test keystore in the repository: -Djavax.net.ssl.trustStore=your.checkout.location/qpid/java/test-profiles/test_resources/ssl/certstore.jks -Djavax.net.ssl.trustStorePassword=password - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-1995) Notification tabs all start a thread on creation, and never halt them
Notification tabs all start a thread on creation, and never halt them - Key: QPID-1995 URL: https://issues.apache.org/jira/browse/QPID-1995 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Priority: Critical Fix For: 0.6 The Notification areas/tabs start an update thread upon creation and have it loop forever, continually sleeping if the view is not visible. This thread isnt destroyed even after the view is disposed of, and so viewing each individual MBean results in an additional background thread. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-1996) n
n - Key: QPID-1996 URL: https://issues.apache.org/jira/browse/QPID-1996 Project: Qpid Issue Type: Bug Reporter: Robbie Gemmell -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1996) Notifications view clears the table and forces deselection at every refresh
[ https://issues.apache.org/jira/browse/QPID-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-1996: - Component/s: Java Management : JMX Console Description: Notifications view clears the table and forces deselection at every refresh Affects Version/s: 0.6 Fix Version/s: 0.6 Assignee: Robbie Gemmell Summary: Notifications view clears the table and forces deselection at every refresh (was: n) Hit Enter by mistake when I dropped something on the keyboard :) Notifications view clears the table and forces deselection at every refresh --- Key: QPID-1996 URL: https://issues.apache.org/jira/browse/QPID-1996 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.6 Notifications view clears the table and forces deselection at every refresh -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1995) Notification tabs all start a thread on creation, and never halt them
[ https://issues.apache.org/jira/browse/QPID-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-1995: - Status: Ready To Review (was: In Progress) Notification tabs all start a thread on creation, and never halt them - Key: QPID-1995 URL: https://issues.apache.org/jira/browse/QPID-1995 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Priority: Critical Fix For: 0.6 The Notification areas/tabs start an update thread upon creation and have it loop forever, continually sleeping if the view is not visible. This thread isnt destroyed even after the view is disposed of, and so viewing each individual MBean results in an additional background thread. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1969) per-virtualhost notification areas show all notifications sent by the server
[ https://issues.apache.org/jira/browse/QPID-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-1969: - Status: Ready To Review (was: In Progress) per-virtualhost notification areas show all notifications sent by the server Key: QPID-1969 URL: https://issues.apache.org/jira/browse/QPID-1969 Project: Qpid Issue Type: Sub-task Components: Java Management : JMX Console Affects Versions: 0.5 Reporter: Robbie Gemmell Assignee: Robbie Gemmell The console offers per-virtualhost notification areas, however these show all notifications sent by the server instead of just those related to the virtual host being examined -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1996) Notifications view clears the table and forces deselection at every refresh
[ https://issues.apache.org/jira/browse/QPID-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-1996: - Status: Ready To Review (was: In Progress) Notifications view clears the table and forces deselection at every refresh --- Key: QPID-1996 URL: https://issues.apache.org/jira/browse/QPID-1996 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.6 Notifications view clears the table and forces deselection at every refresh -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-1995) Notification tabs all start a thread on creation, and never halt them
[ https://issues.apache.org/jira/browse/QPID-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-1995: Assignee: Aidan Skinner (was: Robbie Gemmell) Hi Aidan, can you review this change please, thanks. Notification tabs all start a thread on creation, and never halt them - Key: QPID-1995 URL: https://issues.apache.org/jira/browse/QPID-1995 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Aidan Skinner Priority: Critical Fix For: 0.6 The Notification areas/tabs start an update thread upon creation and have it loop forever, continually sleeping if the view is not visible. This thread isnt destroyed even after the view is disposed of, and so viewing each individual MBean results in an additional background thread. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-1996) Notifications view clears the table and forces deselection at every refresh
[ https://issues.apache.org/jira/browse/QPID-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-1996: Assignee: Aidan Skinner (was: Robbie Gemmell) Hi Aidan, can you review this change please, thanks. Notifications view clears the table and forces deselection at every refresh --- Key: QPID-1996 URL: https://issues.apache.org/jira/browse/QPID-1996 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Aidan Skinner Fix For: 0.6 Notifications view clears the table and forces deselection at every refresh -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-1969) per-virtualhost notification areas show all notifications sent by the server
[ https://issues.apache.org/jira/browse/QPID-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-1969: Assignee: Aidan Skinner (was: Robbie Gemmell) Hi Aidan, can you review this change please, thanks. per-virtualhost notification areas show all notifications sent by the server Key: QPID-1969 URL: https://issues.apache.org/jira/browse/QPID-1969 Project: Qpid Issue Type: Sub-task Components: Java Management : JMX Console Affects Versions: M2.1, M3, M4, 0.5 Reporter: Robbie Gemmell Assignee: Aidan Skinner Fix For: 0.6 The console offers per-virtualhost notification areas, however these show all notifications sent by the server instead of just those related to the virtual host being examined -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1969) per-virtualhost notification areas show all notifications sent by the server
[ https://issues.apache.org/jira/browse/QPID-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-1969: - Affects Version/s: M2.1 M3 M4 Fix Version/s: 0.6 per-virtualhost notification areas show all notifications sent by the server Key: QPID-1969 URL: https://issues.apache.org/jira/browse/QPID-1969 Project: Qpid Issue Type: Sub-task Components: Java Management : JMX Console Affects Versions: M2.1, M3, M4, 0.5 Reporter: Robbie Gemmell Assignee: Aidan Skinner Fix For: 0.6 The console offers per-virtualhost notification areas, however these show all notifications sent by the server instead of just those related to the virtual host being examined -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1981) Expose message copying ability through JMX
[ https://issues.apache.org/jira/browse/QPID-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-1981: - Status: Ready To Review (was: In Progress) Expose message copying ability through JMX -- Key: QPID-1981 URL: https://issues.apache.org/jira/browse/QPID-1981 Project: Qpid Issue Type: New Feature Components: Java Broker, Java Management : JMX Console Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.6 The Queue implementations support the ability of copying messages to another queue, but this is not exposed through the relevant JMX MBean. This should be exposed as JMX operation and supported in the new management console UI. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1994) auto-refresh mechanism can generate NPE during application shutdown
[ https://issues.apache.org/jira/browse/QPID-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-1994: - Status: Ready To Review (was: In Progress) auto-refresh mechanism can generate NPE during application shutdown --- Key: QPID-1994 URL: https://issues.apache.org/jira/browse/QPID-1994 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Priority: Minor Fix For: 0.6 The automated refreshing mechanism can generate a NullPointerException if the application shutdown is timed such that a refresh is attempted during the shutdown process. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-1981) Expose message copying ability through JMX
[ https://issues.apache.org/jira/browse/QPID-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-1981: Assignee: Aidan Skinner (was: Robbie Gemmell) Hi Aidan, can you review this change please, thanks. Expose message copying ability through JMX -- Key: QPID-1981 URL: https://issues.apache.org/jira/browse/QPID-1981 Project: Qpid Issue Type: New Feature Components: Java Broker, Java Management : JMX Console Reporter: Robbie Gemmell Assignee: Aidan Skinner Fix For: 0.6 The Queue implementations support the ability of copying messages to another queue, but this is not exposed through the relevant JMX MBean. This should be exposed as JMX operation and supported in the new management console UI. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-1994) auto-refresh mechanism can generate NPE during application shutdown
[ https://issues.apache.org/jira/browse/QPID-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-1994: Assignee: Aidan Skinner (was: Robbie Gemmell) Hi Aidan, can you review this change please, thanks. auto-refresh mechanism can generate NPE during application shutdown --- Key: QPID-1994 URL: https://issues.apache.org/jira/browse/QPID-1994 Project: Qpid Issue Type: Bug Components: Java Management : JMX Console Affects Versions: 0.6 Reporter: Robbie Gemmell Assignee: Aidan Skinner Priority: Minor Fix For: 0.6 The automated refreshing mechanism can generate a NullPointerException if the application shutdown is timed such that a refresh is attempted during the shutdown process. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [GSoC] JMX MC progress update
Thanks Marnie, Just as a further update, ive made the mentioned updates to the queue mbean and updated the console accordingly, which can be seen in the screenshot below. When connected to a supporting broker the console will now offer delete and copy methods as well as the previous move. Additionally, for supporting brokers the position of the message on the queue will now be shown (previously it was impossible to tell the position of a message on the queue from the information given in the result). I also removed the irrelevant Type folders for the Configuration, Logging, and User Management mbeans to make the navigation tree look a little cleaner. http://people.apache.org/~robbie/qpid/gsoc/screenshots_21july2009/queue.png Robbie 2009/7/21 Marnie McCormack marnie.mccorm...@googlemail.com: Hi Robbie, I had a look at the screenshots and they look good, in some cases much better than the previous versions in terms of guessability (what the heck does this do) and such :-) Thanks for your work on this to date. When I get some time I'll try it out on Windows too, as the (mainly) solo voice of windows dev (a little) on the Java side ! Take Care, Marnie On Wed, Jul 15, 2009 at 2:41 PM, Robbie Gemmell robbie.gemm...@gmail.comwrote: Hi everyone, I have moved all my work so far on the JMX management console onto trunk now. All major new sections of the UI for existing functionality are in place now and largely complete, and i have just added an auto-refresh feature and operation status reporting, so its ready for a bit of playing with. The layout is pretty complete, although there will be some small changes: eg when additional functionality is added to the Queue mbean (copy and delete arbitrary messages, and specifying an interval for the message list after it is expanded to cope with Long values), and information from the imminent new 'system information' mbean is exposed. Another change will be expanding more of the tables/operations to allow multiple selection. There were some dialog positioning issues on Windows that i still need to look into. You can build it for a look using the instructions below, or if you are not so inclined you can find some screenshots I made earlier for Aidan here: http://people.apache.org/~robbie/qpid/gsoc/screenshots_15july2009/ Robbie === You can use the console on Windows, Linux (32 or 64bit), and Mac OS X (not tested as yet). You can get the package by using the ant 'release-bin' target from qpid/java/ which will build the console releases in qpid/java/management/eclipse-plugin/release/ NOTE: SSL is enabled by default on the broker JMX connection, using a self-signed cert in its keystore. As a result you have to supply the matching SSL truststore to the console for it to connect. Alternatively, you can just disable the SSL before launching the broker by using the option in management ssl in qpid/java/build/etc/config.xml to toggle it off. If you do want to use the SSL, you can supply the necessary details in the qpidmc.ini configuration file in the root of the console release (or buried somewhere within the .app package for OS X), which has a pre-configured example. Uncomment and change the example to the values below to match the test keystore in the repository: -Djavax.net.ssl.trustStore=your.checkout.location/qpid/java/test-profiles/test_resources/ssl/certstore.jks -Djavax.net.ssl.trustStorePassword=password - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [GSoC] Queue MBean viewMessages + viewMessageContent operations
Returning to this... :) I have widened the viewMessages(int from, int to) method to viewMessages(long from, long to), so it now supports viewing all messages on queues with 2^31 messages on it. The queues themselves however only partially support having that many messages. The underlying SimpleQueueEntryList is obviosuly ok, but the message count is store in an AtomicInteger and will wrap, and many of the ancillary methods which are part of the queue implementation use List's in their return types, which use ints for index and size and so again are limited. These things could of course be changed(but will divert quite a bit from the actual console in the coding run-in...), but the stickier point is the Integer getMessageCount() method which is exposed through the queue mbeans as an attribute of the mbean. Changing this to a Long will break compatibility with the existing JMX CLI, as it expects Integer return types and uses the method in quite a number of places in its implementation, and will throw a wobbly if presented with a Long. The RCP management console wouldnt care, as it currently only exposes the method through Attributes tabs using introspection (though i had considered doing something just the other day which would have involved me calling it). I just wrote a little test that stuffed null Object's into various types of List. On a 4GB machine with 2GB of swap, I hit between 100 and 200 million entries before OOM, depending on the List type used. Broker + actual messages would obviously reduce that considerably, meaning it isnt likely to be an immediate problem unless someone builds a really nice machine with intent of operating entirely out of one queue. As a a result, I think it would be best to leave this attribute the way it is for now and save such a change for future, timing it with another general break in management compatibility. Thoughts? Robbie 2009/6/24 Aidan Skinner aidan.skin...@gmail.com: On Wed, Jun 24, 2009 at 11:24 AM, Robbie Gemmellrobbie.gemm...@gmail.com wrote: requiring JConsole etc users make that class available to use the results, viewMessages(from, to) would still need be limited to viewing at most 2^31 at a time...just any 2^31 instead of the first 2^31 as at present. Cool, that's much better - they can get to the end of the queue if they need too. - Aidan -- Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org A witty saying proves nothing - Voltaire - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-1997) Connection failure does not provide debug info
Connection failure does not provide debug info -- Key: QPID-1997 URL: https://issues.apache.org/jira/browse/QPID-1997 Project: Qpid Issue Type: Bug Components: Ruby Client Environment: F11 Ruby, built off of 790661 revision on trunk Reporter: Arjun Roy Priority: Minor A failed connection doesn't provide info in the resulting stack trace that describes why it failed. In my case I had to enable full logging on qpidd the figure out the error. /usr/lib/ruby/site_ruby/1.8/qpid/connection.rb:144:in `start': Qpid::ConnectionFailed from /usr/lib/ruby/site_ruby/1.8/qpid/qmf.rb:1641:in `try_to_connect' from /usr/lib/ruby/site_ruby/1.8/qpid/qmf.rb:1406:in `start' from /usr/lib/ruby/site_ruby/1.8/qpid/qmf.rb:1402:in `initialize' from /usr/lib/ruby/site_ruby/1.8/qpid/qmf.rb:1402:in `new' from /usr/lib/ruby/site_ruby/1.8/qpid/qmf.rb:1402:in `start' from /usr/lib/ruby/site_ruby/1.8/qpid/qmf.rb:1485:in `initialize' from /usr/lib/ruby/site_ruby/1.8/qpid/qmf.rb:210:in `new' from /usr/lib/ruby/site_ruby/1.8/qpid/qmf.rb:210:in `add_broker' ConnectionFailed does not say why it failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-1998) Possible 0-pointer crash in SystemInfo::getProcessName()
Possible 0-pointer crash in SystemInfo::getProcessName() Key: QPID-1998 URL: https://issues.apache.org/jira/browse/QPID-1998 Project: Qpid Issue Type: Bug Components: C++ Client Affects Versions: 0.5 Environment: Windows Reporter: Steve Huston Assignee: Steve Huston Fix For: 0.6 As reported on us...@qpid.apache.org by Alan Conway: Nithesh Shetty wrote: [snip] Now the problem is it give exception if u check the call stack then it show ptr = 0x line 664 qpid::sys::SystemInfo::getProcessName() qpid::client::ConnectionHandler::ConnectionHandle() qpid::client::ConnectionImpl::ConnectionImp() qpid::client:Connection::open() ( open connection is from read thread) tested the above code on windows There's a bug in the windows code for getProcessName which might be the cause of your woes. std::string SystemInfo::getProcessName() { // Only want info for the current process, so ask for something specific. // The module info won't be used here but it keeps the snapshot limited to // the current process so a search through all processes is not needed. HANDLE snap = CreateToolhelp32Snapshot(TH32CS_SNAPMODULE, 0); if (snap == INVALID_HANDLE_VALUE) return 0; This return statment is constructing a string from a 0 pointer which is going to lead to a null pointer crash. I don't know if its likely to be the cause of your crash since I don't know under what circumstances you'd get the INVALID_HANDLE_VALUE. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-1737) qpid C++ will not build with WinSDK 7
[ https://issues.apache.org/jira/browse/QPID-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733837#action_12733837 ] Steve Huston commented on QPID-1737: This appears to have been resolved, at least on the current trunk, by moving the rpc.h include from uuid.h to uuid.cpp. James, could you please verify that this build works when you have a chance? qpid C++ will not build with WinSDK 7 - Key: QPID-1737 URL: https://issues.apache.org/jira/browse/QPID-1737 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: M4 Environment: XP 32 bit with latest SDK from Microsoft (SDK 7 beta) Reporter: James Mansion Assignee: Steve Huston Attachments: SIP.patch I'm trying to build M4 of AMQP on XP with the Win7 SDK Beta, and I'm seeing that Manageable::STATUS_INVALID_PARAMETER is being expanded to: Manageable::((DWORD )0xC00DL); I think this is because src\qpid/sys/windows/uuid.h has included rpc.h and included a lot of the SDK as a result. STATUS_INVALID_PARAMETER is defined in ntstatus.h and winnt.h. The include structure is rather Byzantine - I see there's a JIRA to tidy things up, though that is focussed on client applications. I suspect that one way or another this will bite again even if sufficient 'undefs' are added in the code now. I know this is Microsoft's bad for namespace pollution, but the practical answer is to change the name of this constant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-1982) QMF ResilientConnection notifyFd feature portability
[ https://issues.apache.org/jira/browse/QPID-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733846#action_12733846 ] Steve Huston commented on QPID-1982: I have a sneaking suspicion this issue is related to QPID-1918 and its fix for PipeHandle (eventually the lights do come on). Is the QMF plug-in on the other end of the notify fd? If so, then a workable short-term fix. combined with the PipeHandle fixes in QPID-1918, would be to change ResilientConnection's write() to send(). How does that look? In any event, I think this is going to cause long-term issues, at least on Windows. Although selecting a socket fd is a very common way to do such a notify, it's probably going to be limiting in some use cases down the road. Caveat emptor. QMF ResilientConnection notifyFd feature portability Key: QPID-1982 URL: https://issues.apache.org/jira/browse/QPID-1982 Project: Qpid Issue Type: Improvement Components: Qpid Managment Framework Affects Versions: 0.5 Environment: Windows Reporter: Steve Huston The QMF's C++ qmfcommon ResilientConnection class has a setNotifyFd (int fd) method. The docs say this can receive a file descriptor that is written on when certain events take place, supposedly so the other end of the channel can listen, select, etc. and be notified of some event. This construct isn't portable, both because of the datatype of the fd (int is not necessarily a legit handle type everywhere) and because the code assumes a write() will work. The code can be abstracted out to get rid of the write() easily enough, but what is the usage for this facility? There are no calls to setNotifyFd() that I can find outside of the library containing the implementation. So I can't tell if this is something that can be replaced by qpid::sys::PollableCondition or not. What is the use case for this, and how can we make this portable? Different IPC type? Callback to some private hook? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in support
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733902#action_12733902 ] Steve Huston commented on QPID-1918: The PipeHandle.cpp changes (simplified to always use TCP, never _pipe) were integrated in trunk r796577. The ManagementAgentImpl.cpp change seems like it should maybe be handled more like the agent-not-initialized code in ManagementAgentImpl::ConnectionThread, but I didn't study this too closely... could you please check this out? The uuid situation seems to have changed wrt includes... could you please re-evaluate your situation against trunk? I'm a little uneasy about relying on Condor's autotools check for HAVE_... in IntegerTypes.h so I'm still thinking about this one. How does Condor get a size_t and pid_t type? Is it picking it up somewhere from Visual Studio, or defining them locally? Re VS project file updates... I'm not devoting any more time to maintaining them. As soon as I have a little free time, I'm going to remove them all, so it's best to get the cmake stuff going. CMake will generate Visual Studio projects from which you can build, debug, etc. so it's just getting over the CMake step that's a hassle at first. I have a README in progress that explains it further and will try to get it check in soon. Patches/files for Windows QMF plug-in support - Key: QPID-1918 URL: https://issues.apache.org/jira/browse/QPID-1918 Project: Qpid Issue Type: New Feature Components: Qpid Managment Framework Environment: Windows XP SP3, VC++ 9.0 Reporter: Pete MacKinnon Assignee: Steve Huston Attachments: qpid-1918.zip Various files for the Windows QMF plug-in support in cpp, based off revision: 785848 Need Static builds (release and debug) for correct runtime integration with Condor: src/broker.vcproj src/client.vcproj src/common.vcproj src/qmfagent.vcproj src/qmfconsole.vcproj src/qpid.sln src/qpidbroker.vcproj - Changed to provide compile flags required for header file integration of Posix types declared by both Qpid and Condor: src/qpid/sys/windows/IntegerTypes.h src/qpid/sys/windows/uuid.cpp src/qpid/sys/windows/uuid.h - Modified signature of PipeHandle ctor and fixed a Windows race condition in the processing loop: src/qpid/agent/ManagementAgentImpl.cpp - Refactored the pipe code so that Condor can get a true socket fd it can select on in daemon_core: src/qpid/sys/Pipehandle.h src/qpid/sys/posix/PipeHandle.cpp src/qpid/sys/windows/PipeHandle.cpp - Removed explicit dependency on Debug libs since we now have even more targets. Added Apache license: examples/qmf_agent.vcproj - Added Apache license: src/protocol_gen.mak examples/qmf-agent/example_gen.mak - Updated QMF Agent example README: examples/README -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org