Request for review/discussion of proposed SSL additions for C++ broker/client on Windows
I have just attached a new patch to QPID-1403 (https://issues.apache.org/jira/browse/QPID-1403) with additions for SSL support on Windows for the C++ broker and client. I would like to have a review of this before committing it to the repository. Andrew Stitcher has had a cursory look at an earlier version of the patch and suggested that he would like to have a more in-depth look and discussion post-0.6. We're looking at next week for this review. He suggested that Gordon Sim, as author of the Linux SSL support, may have particular insights to share as well. All other interested people are welcome and encouraged to join in. For some background info on Windows Schannel (the native SSL implementation on Windows) I wrote a blog overview of it recently - you may want to read that before the review meeting for this patch (http://stevehuston.wordpress.com/2009/12/29/how-to-use-schannel-for-ssl -sockets-on-windows/) For the mechanics of actually doing the review get-together, since people may be joining from various locations I can host the meeting with my Adobe web meeting account - this would give us whiteboard, VOIP audio, screen sharing. I believe I can record it and attach to the jira if others want to review it later. If there's no better idea for carrying this out, I'll set it up and post a URL here. Also, what about a day/time? I can do it Tuesday after 11:00 US East coast (UTC-0500), or Wednesday same time frame. Thanks, -Steve - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1403) Add SSL support for C++ Windows broker/client
[ https://issues.apache.org/jira/browse/QPID-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Huston updated QPID-1403: --- Attachment: ssl-windows.patch Revised patch. At this point, the changes applied to the current trunk yield: - Windows <-> Windows, ok - Windows client -> Linux server, ok - Linux client -> Windows server, fail negotiation - certificate chain not trusted I assume the failure is more of a setup issue than a code correctness issue. I'd like to get interested people together for a review of the attached code. > Add SSL support for C++ Windows broker/client > - > > Key: QPID-1403 > URL: https://issues.apache.org/jira/browse/QPID-1403 > Project: Qpid > Issue Type: New Feature > Components: C++ Broker, C++ Client >Affects Versions: M4 > Environment: Windows XP+ >Reporter: Steve Huston >Assignee: Steve Huston > Attachments: ssl-windows.patch > > > The recently added SSL support in the C++ side should be available to Windows > as well. Not yet sure how much architectural work this may be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1403) Add SSL support for C++ Windows broker/client
[ https://issues.apache.org/jira/browse/QPID-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Huston updated QPID-1403: --- Attachment: (was: ssl-windows.patch) > Add SSL support for C++ Windows broker/client > - > > Key: QPID-1403 > URL: https://issues.apache.org/jira/browse/QPID-1403 > Project: Qpid > Issue Type: New Feature > Components: C++ Broker, C++ Client >Affects Versions: M4 > Environment: Windows XP+ >Reporter: Steve Huston >Assignee: Steve Huston > > The recently added SSL support in the C++ side should be available to Windows > as well. Not yet sure how much architectural work this may be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-2335) Arguments for a binding to an XML exchange are not visible through management
Arguments for a binding to an XML exchange are not visible through management
-
Key: QPID-2335
URL: https://issues.apache.org/jira/browse/QPID-2335
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.6
Reporter: Ted Ross
Priority: Minor
If you create a binding to the XML exchange (using
python/examples/xml-exchange/declare_queues.py for example), then look at the
binding using qpid-tool, the arguments field is {} (an empty map).
Arguments for headers exchanges can be viewed correctly, this only affects the
xml exchange.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2327) Enhance qpid-config to deal with xml and headers brokers
[ https://issues.apache.org/jira/browse/QPID-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved QPID-2327. Resolution: Fixed > Enhance qpid-config to deal with xml and headers brokers > > > Key: QPID-2327 > URL: https://issues.apache.org/jira/browse/QPID-2327 > Project: Qpid > Issue Type: Improvement > Components: Python Test Suite, python tools >Affects Versions: 0.7 > Environment: Tested on linux (fedora), at least partially affects all > platforms >Reporter: john dunning >Assignee: Ted Ross > Fix For: 0.7 > > Attachments: bz-549443-take-two.patch, bz-549443.patch > > > qpid-config currently doesn't have a way to configure "xml" or "header" type > bindings. This patch adds the ability to do so, with extra arg parsing to > deal with the specialized args for those bind types. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2327) Enhance qpid-config to deal with xml and headers brokers
[ https://issues.apache.org/jira/browse/QPID-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] john dunning updated QPID-2327: --- Attachment: bz-549443-take-two.patch Revised patch, fixes non-local build problem > Enhance qpid-config to deal with xml and headers brokers > > > Key: QPID-2327 > URL: https://issues.apache.org/jira/browse/QPID-2327 > Project: Qpid > Issue Type: Improvement > Components: Python Test Suite, python tools >Affects Versions: 0.7 > Environment: Tested on linux (fedora), at least partially affects all > platforms >Reporter: john dunning >Assignee: Ted Ross > Fix For: 0.7 > > Attachments: bz-549443-take-two.patch, bz-549443.patch > > > qpid-config currently doesn't have a way to configure "xml" or "header" type > bindings. This patch adds the ability to do so, with extra arg parsing to > deal with the specialized args for those bind types. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Building user doc in SVN
I think user guide is probably a good name. I would assume as time goes on we may have one for developers who want to work on Qpid as well. Rajtih On Thu, Jan 7, 2010 at 11:14 AM, Alan Conway wrote: > Great to finally see some user documentation in the qpid SVN repo, good job > Jonathan. > > I'd like to add make/cmake files to automate the process of generating doc > in pdf/html so developers can validate and review the doc after making > changes. If you email me the steps to do it manually I'll add the make/cmake > files. > > Also perhaps we could rename "book" as "user guide" or somesuch? In the long > run we'll probably have multiple books here. > > - > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:dev-subscr...@qpid.apache.org > > -- Regards, Rajith Attapattu Red Hat http://rajith.2rlabs.com/ - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Building user doc in SVN
Great to finally see some user documentation in the qpid SVN repo, good job Jonathan. I'd like to add make/cmake files to automate the process of generating doc in pdf/html so developers can validate and review the doc after making changes. If you email me the steps to do it manually I'll add the make/cmake files. Also perhaps we could rename "book" as "user guide" or somesuch? In the long run we'll probably have multiple books here. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2327) Enhance qpid-config to deal with xml and headers brokers
[ https://issues.apache.org/jira/browse/QPID-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797661#action_12797661 ] john dunning commented on QPID-2327: D'oh! You're right. I'll work out a better way and post a revised patch. > Enhance qpid-config to deal with xml and headers brokers > > > Key: QPID-2327 > URL: https://issues.apache.org/jira/browse/QPID-2327 > Project: Qpid > Issue Type: Improvement > Components: Python Test Suite, python tools >Affects Versions: 0.7 > Environment: Tested on linux (fedora), at least partially affects all > platforms >Reporter: john dunning >Assignee: Ted Ross > Fix For: 0.7 > > Attachments: bz-549443.patch > > > qpid-config currently doesn't have a way to configure "xml" or "header" type > bindings. This patch adds the ability to do so, with extra arg parsing to > deal with the specialized args for those bind types. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-1831) Improve JMS Destination abstraction to better support AMQP and Qpid specific features
[ https://issues.apache.org/jira/browse/QPID-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-1831: --- Attachment: QPID-1831.patch The attached patch contains basic support for the common addressing syntax to be used by all clients. The patch is incomplete as it is not functionally complete due to lack of a parser. The patch also does not contain any tests as of yet. I want to investigate the possibility about reusing tests written for the python client and then supplement it with java based tests. I'd appreciate your comments about the direction taken in this patch. Suggestions and criticisms are most welcomed. Implementation Notes 1. The required fields and methods to support the new addressing mechanism is added to AMQDestination itself. This was to ensure there is as little code changes as possible to the existing setup. 2. The code requires a parser for the new addressing syntax. Once that is available code will be added to use that to populate the required fields. 3. The new addressing support is only added to the 0-10 codepath as I am not sure there is sufficient protocol level support to implement it meaningfully in 0-8. 4. For now I am ignoring the browse option (I believe this value could be used for the noconsume field in BasicMessageConsumer) 5. For now I am ignoring reliability option as I am not quite sure how to tie that into the existing ack modes (perhaps I misunderstood). 6. I have not bothered to factor in any abstraction required to support AMQP 1.0, as I feel it's best served if we look at the client as a whole rather than piece by piece when figuring out the right level of abstraction. 7. I have removed the final keyword from _exchangeName, _exchangeClass, _isDurable, _isExclusive, _isAutoDelete to get more flexibility within the constructor methods. None of the above had any setter methods (well I added ones for exchangeName and exchangeClass for good reason) and are only set in the constructor or constructor like methods. 8. The equals method for AMQDestination needs to be modified to handle the new addressing syntax. Ex. Consider a javax.jms.Destination dest1 with an address "foo" and another instance called dest2 with the same address. If the name resolves to an exchange, the queuenames contained within dest1 and dest2 would be different as a private temp queue is created for each if used by a consumer. If "foo" resolves to a queue then then the queuename would be the same for both instances. If an equals test is performed for dest1 and dest2 it should succeed for use cases, allthough the test criteria will be different. > Improve JMS Destination abstraction to better support AMQP and Qpid specific > features > - > > Key: QPID-1831 > URL: https://issues.apache.org/jira/browse/QPID-1831 > Project: Qpid > Issue Type: Improvement > Components: Java Client >Reporter: Rajith Attapattu >Assignee: Rajith Attapattu > Fix For: 0.7 > > Attachments: AMQXDest.patch, QPID-1831.patch > > > Qpid users have requested the following features in JIRAs/emails to the user > list. > 1. Ability to specify Qpid specific queue declare arguments like qpid.max-size > 2. Support for any exchange type ..eg Headers, XML exchange > 3. Ability to specify binding arguments (needed for headers, xml exchanges) > 4. Ability to support destination specific parameters like msg-credits, > byte-credits, sync-ack, sync-publish ..etc > 5. Ability bind a queue to multiple exchange/routingkey pairs > 6. Have the option of producer side declaring/binding the queue. > The following proposal outlines a solution to the above mentioned > requirements. > http://cwiki.apache.org/confluence/display/qpid/Proposal+for+a+new+JMS+Destination+configuration -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2327) Enhance qpid-config to deal with xml and headers brokers
[ https://issues.apache.org/jira/browse/QPID-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797644#action_12797644 ] Ted Ross commented on QPID-2327: There's one issue with this patch. It doesn't work in a vpath build since the test.xquery file is in a different directory tree in this case. > Enhance qpid-config to deal with xml and headers brokers > > > Key: QPID-2327 > URL: https://issues.apache.org/jira/browse/QPID-2327 > Project: Qpid > Issue Type: Improvement > Components: Python Test Suite, python tools >Affects Versions: 0.7 > Environment: Tested on linux (fedora), at least partially affects all > platforms >Reporter: john dunning >Assignee: Ted Ross > Fix For: 0.7 > > Attachments: bz-549443.patch > > > qpid-config currently doesn't have a way to configure "xml" or "header" type > bindings. This patch adds the ability to do so, with extra arg parsing to > deal with the specialized args for those bind types. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Subversion tags and branches (a little moan)
This sounds like something I should remember Can this be placed on the qpid wiki dev pages? Maybe on the release process page? I'd do it myself, but don't have commit privs yet. Thanks, -K - "Andrew Stitcher" wrote: > I've just noticed (after several hours of puzzling about what was > screwing up my git branch history) that there are a number of > branches > and tags that omit the top level, redundant "qpid" directory. > > Now I'm for getting rid of uselessness like this as much as the next > guy > (and I'm in fact responsible for at least one of these tags myself). > However it totally screws up git-svn's ability to figure out the > correct > branching structure of the project (and frankly git-svn is the best > tool > able to visualise this) so I'm a little unhappy it's broken into 2 > pieces. > > I don't think this can be fixed now in the existing tree, but can we > please, please, please remember when doing "svn cp" to do something > like: > > svn cp -r895736 https://svn.apache.org/repos/asf/qpid/trunk > https://svn.apache.org/repos/asf/qpid/branches/0.6-release > > > [The -r is useful to make sure you know exactly which revision you > are > branching or tagging] > > Andrew > > > > - > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2322) remove redundant "version" key property from the ObjectName of the JMX MBeans
[ https://issues.apache.org/jira/browse/QPID-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-2322: - Status: Ready To Review (was: In Progress) > remove redundant "version" key property from the ObjectName of the JMX MBeans > - > > Key: QPID-2322 > URL: https://issues.apache.org/jira/browse/QPID-2322 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Management : JMX Interface >Affects Versions: 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.7 > > > Brokers from 0.5 onward have an additional version=X key property in the > MBean ObjectName. This was added in 0.5 to enable version tracking for the > MBeans to accomodate compatibility checks where necessary after changes. In > 0.6.0.0 a new version tracking system was put in place, using the new > ServerInformation MBean. As such, the version key property in the ObjectName > is no longer required. > Motivation for removing the key property is that for certain JMX operations > that require knowing the exact ObjectName of the single remote MBean you wish > to operate on, you must know the value of the version key, which is different > on each type of MBean and also differs between releases. Whilst it is > possible to easily Query the server for this information, the ability to > first perform this query is not always available to the user (eg for > non-bespoke server health checks) and as such they need to know the exact > value in advance. Removing the now-unused version key from the ObjectName > will remove this need in future broker releases. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
