date:20110822

Re: [VOTE] Release 0.12

2011-08-22 Thread Robbie Gemmell

Bump. Any updates?

Robbie

On 16 August 2011 19:10, Justin Ross jr...@redhat.com wrote:
 Last call.  I'll check tomorrow and consider this vote closed if there's no
 new discussion.

 On Tue, 9 Aug 2011, Justin Ross wrote:

 Howdy, all.  The last-minute blocker, QPID-3394, has been fixed, and there
 are no open blocker jiras against 0.12.  The proposed final RC, from
 revision 1154981 of the 0.12 release branch, is available here:

  http://people.apache.org/~jross/qpid-0.12/

 If you favor releasing this distribution as Qpid 0.12, vote +1.  If you
 are aware of problems that ought to prevent this distribution from being
 released, vote -1.

 If the release proceeds, I'll take the final steps to publicize and
 distribute the release.  That should take one or two days.

 ---
 0.12 release page: https://cwiki.apache.org/qpid/012-release.html

 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org



 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Review Request: QPID-3415 CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-08-22 Thread Keith Wall

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1608/
---

Review request for qpid and rajith attapattu.

Summary
---

This patch changes the 0-10 code path to create the SASL callback handler using
the CallbackHandlerRegistry. This allows the 0-10 code path to support SASL
mechanisms requiring other callback handlers, such as CRAM-MD5-HASHED. Support
for the sasl_mechs client connection option has been retained and now applies
to the 0-8..0-9-1 code paths too.

If the user *specifies* a sasl_mechs client connection option the behaviour of
the code is unchanged from the previous version: it restricts the list of SASL
mechanisms in use.

If the user *does not specify* a sasl_mechs client connection option, the old
code used a hardcoded PLAIN default. This is no longer the case. Now the
client will use the first SASL mechanism from the list
CallbackHandlerRegistry.properties that is also available on the server.

Removed dead code and strengthen unit tests.

This addresses bug QPID-3415.
https://issues.apache.org/jira/browse/QPID-3415

Diffs
-

/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_0_10.java
1160136

/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionStartMethodHandler.java
1160136

/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/security/CallbackHandlerRegistry.java
1160136

/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/security/CallbackHandlerRegistry.properties
1160136

/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/ClientDelegate.java
1160136

/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java
1160136

/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/ConnectionSettings.java
1160136

/trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/ConnectionTest.java
1160136

/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/ConnectionTest.java
1160136

/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/message/UTF8Test.java
1160136

Diff: https://reviews.apache.org/r/1608/diff

Testing
---

Improved unit testing. Run java, cpp and cpp.ssl profiles. I am not able to
test GSSAPI locally.

Thanks,

Keith

Re: [JAVA] build breakage with older ant/java

2011-08-22 Thread Keith Wall

On 18 August 2011 16:14, Gordon Sim g...@redhat.com wrote:

 On 08/18/2011 04:09 PM, Robbie Gemmell wrote:

 The rationale for the change was to add an extension point to the
 build system to enable client modules, such as transports and
 authentication/authorisation add-ons. The easiest way of doing this
 was the property used which has happened to involve requiring a 3 year
 old version of Ant.

 Should it be a policy to support things that are over 6 years old at
 this point? RHEL4? I've been seeing RHEL5 based builds getting broken
 with increasing regularity recently...


 I'm not suggesting it should be policy. All I was asking was for
 clarification and context on the change in question to help inform any
 possible proposals on alternatives.

 While we shouldn't have to contort ourselves to workaround the lack of well
 established features, if there are simple alternatives that are less
 exclusive that is surely a reasonable thing to consider.


I commited a change under QPID-3365 to avoid the dependency on Ant 1.7.1.
The build should now be working under Ant 1.6.x once again.





 --**--**-
 Apache Qpid - AMQP Messaging Implementation
 Project:  http://qpid.apache.org
 Use/Interact: 
 mailto:dev-subscribe@qpid.**apache.orgdev-subscr...@qpid.apache.org

Re: [JAVA] build breakage with older ant/java

2011-08-22 Thread Gordon Sim


On 08/22/2011 11:16 AM, Keith Wall wrote:

On 18 August 2011 16:14, Gordon Simg...@redhat.com  wrote:


On 08/18/2011 04:09 PM, Robbie Gemmell wrote:


The rationale for the change was to add an extension point to the
build system to enable client modules, such as transports and
authentication/authorisation add-ons. The easiest way of doing this
was the property used which has happened to involve requiring a 3 year
old version of Ant.

Should it be a policy to support things that are over 6 years old at
this point? RHEL4? I've been seeing RHEL5 based builds getting broken
with increasing regularity recently...



I'm not suggesting it should be policy. All I was asking was for
clarification and context on the change in question to help inform any
possible proposals on alternatives.

While we shouldn't have to contort ourselves to workaround the lack of well
established features, if there are simple alternatives that are less
exclusive that is surely a reasonable thing to consider.



I commited a change under QPID-3365 to avoid the dependency on Ant 1.7.1.
The build should now be working under Ant 1.6.x once again.


Thanks!

(I'll stress again that I am not by any means suggesting there should be 
a policy to support older versions. However I very much appreciate the 
gesture here).


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Created] (QPID-3444) the Java broker does not reject 0-10 exchange (un)bind commands which use empty strings for the change name

2011-08-22 Thread Robbie Gemmell (JIRA)

the Java broker does not reject 0-10 exchange (un)bind commands which use empty 
strings for the change name
---

 Key: QPID-3444
 URL: https://issues.apache.org/jira/browse/QPID-3444
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: 0.10, 0.9, 0.8, 0.7, 0.6, 0.11, 0.12
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
 Fix For: 0.13


The Java broker verifies that the exchange (un)bind commands have an exchange 
value set, however it does not reject those which have an empty string defined, 
whcih is also interpreted as the default exchange. it shoudl issue an 
ILLEGAL_ARGUMENT exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Commented] (QPID-3415) CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-08-22 Thread Keith Wall (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088578#comment-13088578
 ] 

Keith Wall commented on QPID-3415:
--

Hi Rajith

Would you mind reviewing my patch for this Jira?  It is on review board:

https://reviews.apache.org/r/1608/

cheers Keith.

 CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL 
 mechanisms).
 --

 Key: QPID-3415
 URL: https://issues.apache.org/jira/browse/QPID-3415
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Affects Versions: 0.10
Reporter: Keith Wall
Assignee: Keith Wall
 Fix For: 0.13


 If the Java broker is configured to use the Base64MD5Password password 
 database the Java client is unable to connect even if they use the sasl_mechs 
 broker option in the connection URL (sasl_mechs='CRAM-MD5-HASHED').  
 Instead the user sees:
 {code}
 org.apache.qpid.AMQException: Cannot connect to broker: Callback handler with 
 support for AuthorizeCallback required
 {code}
 The user can work around the problem by passing the -Dqpid.amqp.version 
 system property to the client, and selecting a protocol  0-10.
 The problem is happening because on the 0-10 code path on the client, the 
 SASL CallbackHandler in use is hardcoded to UsernamePasswordCallbackhandler 
 (ClientDelegate), rather than using the facilities of CallbackHandlerRegistry 
 (as does the 0-8 and 0-9* code paths). CRAM-MD5-HASHED requires the use of a 
 different Callbackhandler.
 This also inhibits the use of custom SASL methods by the client.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Updated] (QPID-3440) the Destination cache in AMQMessageDelegate_0_10 does not work

2011-08-22 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-3440:
-

Attachment: QPID-3440_wip.patch

Attaching an initial patch, with test to verify the issue and addition of 
equals() and hashCode() methods to the generated file causing the problem.

Not yet applied becuase doing so breaks PropertyValueTest. This is due to 
failing a Destination equality test, despite the fact the toString of the 
destinations is actually the same (which it wasnt before), but the equals check 
fails because of a change in underlying object in use, due to the horrible 
number of different objects and ways to instantiate them in our wonderfully 
dispirate Destination handling.

 the Destination cache in AMQMessageDelegate_0_10 does not work
 --

 Key: QPID-3440
 URL: https://issues.apache.org/jira/browse/QPID-3440
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
 Fix For: 0.13

 Attachments: QPID-3440_wip.patch


 The Destination cache in AMQMessageDelegate_0_10 does not work, because it 
 indexes the cache by the underlying ReplyTo transport class, which has no 
 equals() implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Updated] (QPID-3437) qpid-config address option confusing in help

2011-08-22 Thread Pavel Moravec (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Moravec updated QPID-3437:


   Component/s: Documentation
Labels: patch  (was: )
   Description: 
qpid-config --help prints confusing / ambiguity information how to use address
option (-a user/password@broker). On first place it is specified without -a
option (wrong), second place is not descriptive about address syntax:

qpid-config --help
Usage:  qpid-config [OPTIONS]
..
ADDRESS syntax:

  [username/password@] hostname [:port]
  [username/password@] ip-address [:port]
..
  General Options:
..
-a address, --broker-addr=address
Address of qpidd broker

Proposed patch removes the ADDRESS syntax part and adds the address syntax to 
-a option (to follow structure of the help).


  was:
Different qpid-* tools use different command line options for authentication. 
E.g.:

qpid-perftest   --username guest --password passwd -b broker --mechanism MECH
qpid-config -a guest/passwd@broker --sasl-mechanism=MECH
qpid-stat   guest/passwd@broker -sasl-mechanism=MECH

Further to that, some tools (i.e. qpid-tool) don't have an option to set up 
SASL mechanism at all.

It makes sense to unify these options, plus add missing where desired.

See attached table with list of tools, their options and some further comments 
(some minor bugs found as well).

Remaining Estimate: 1h
 Original Estimate: 1h
   Summary: qpid-config address option confusing in help  (was: 
Unify credentials options in qpid tools)

 qpid-config address option confusing in help
 

 Key: QPID-3437
 URL: https://issues.apache.org/jira/browse/QPID-3437
 Project: Qpid
  Issue Type: Improvement
  Components: Documentation, Tools
Affects Versions: 0.10
Reporter: Pavel Moravec
Priority: Minor
  Labels: patch
 Attachments: qpid_tools_authentication.ods

   Original Estimate: 1h
  Remaining Estimate: 1h

 qpid-config --help prints confusing / ambiguity information how to use address
 option (-a user/password@broker). On first place it is specified without -a
 option (wrong), second place is not descriptive about address syntax:
 qpid-config --help
 Usage:  qpid-config [OPTIONS]
 ..
 ADDRESS syntax:
   [username/password@] hostname [:port]
   [username/password@] ip-address [:port]
 ..
   General Options:
 ..
 -a address, --broker-addr=address
 Address of qpidd broker
 Proposed patch removes the ADDRESS syntax part and adds the address syntax to 
 -a option (to follow structure of the help).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Created] (QPID-3441) Correct spelling error in C++ broker's QMF schema

2011-08-22 Thread Paul Colby (JIRA)

Correct spelling error in C++ broker's QMF schema
-

 Key: QPID-3441
 URL: https://issues.apache.org/jira/browse/QPID-3441
 Project: Qpid
  Issue Type: Task
  Components: C++ Broker
Affects Versions: 0.10
Reporter: Paul Colby
Priority: Trivial


The word Infrastructure has been misspelled as Infrastucture (missing an 
r) in cpp/src/qmf/org/apache/qpid/broker/Connection.cpp (line 150 for the 
0.10 release).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Created] (QPID-3440) the Destination cache in AMQMessageDelegate_0_10 does not work

2011-08-22 Thread Robbie Gemmell (JIRA)

the Destination cache in AMQMessageDelegate_0_10 does not work
--

 Key: QPID-3440
 URL: https://issues.apache.org/jira/browse/QPID-3440
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Affects Versions: 0.10, 0.9, 0.8, 0.7, 0.6, 0.11, 0.12
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
 Fix For: 0.13


The Destination cache in AMQMessageDelegate_0_10 does not work, because it 
indexes the cache by the underlying ReplyTo transport class, which has no 
equals() implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Updated] (QPID-3437) qpid-config address option confusing in help

2011-08-22 Thread Pavel Moravec (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Moravec updated QPID-3437:


Attachment: 0006-Bug-732369-Help-address-ambiguity-for-qpid-config.patch

patch proposal

 qpid-config address option confusing in help
 

 Key: QPID-3437
 URL: https://issues.apache.org/jira/browse/QPID-3437
 Project: Qpid
  Issue Type: Improvement
  Components: Documentation, Tools
Affects Versions: 0.10
Reporter: Pavel Moravec
Priority: Minor
  Labels: patch
 Attachments: 
 0006-Bug-732369-Help-address-ambiguity-for-qpid-config.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 qpid-config --help prints confusing / ambiguity information how to use address
 option (-a user/password@broker). On first place it is specified without -a
 option (wrong), second place is not descriptive about address syntax:
 qpid-config --help
 Usage:  qpid-config [OPTIONS]
 ..
 ADDRESS syntax:
   [username/password@] hostname [:port]
   [username/password@] ip-address [:port]
 ..
   General Options:
 ..
 -a address, --broker-addr=address
 Address of qpidd broker
 Proposed patch removes the ADDRESS syntax part and adds the address syntax to 
 -a option (to follow structure of the help).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Created] (QPID-3442) qpid-tool schema descriptions repeated / duplicated

2011-08-22 Thread Paul Colby (JIRA)

qpid-tool schema descriptions repeated / duplicated
---

 Key: QPID-3442
 URL: https://issues.apache.org/jira/browse/QPID-3442
 Project: Qpid
  Issue Type: Bug
  Components: Tools
Affects Versions: 0.10
 Environment: Linux version 2.6.18-194.32.1.el5 
(mockbu...@builder10.centos.org) (gcc version 4.1.2 20080704 (Red Hat 
4.1.2-48)) #1 SMP Wed Jan 5 17:52:25 EST 2011
Python 2.4.3


Linux version 2.6.32-5-amd64 (Debian 2.6.32-35) (da...@debian.org) (gcc version 
4.3.5 (Debian 4.3.5-4) ) #1 SMP Tue Jun 14 09:42:28 UTC 2011
Python 2.6.6
Reporter: Paul Colby
Priority: Minor


It seems that when qpid-tool displays a schema element with no description, it 
repeats the previous element's description (if any) instead.

For example:
{code}
qpid: schema connection
Object Class: Table Class: 
org.apache.qpid.broker:connection:_data(1cb21a64-b290-c47d-40bc-5ea42cffd7c7)
ElementType  Access  Unit  Notes  Description

=
vhostRef   reference ReadCreateindex
addressshort-string  ReadCreateindex
incoming   boolean   ReadCreate
SystemConnection   boolean   ReadCreate   
Infrastucture/ Inter-system connection (Cluster, Federation, ...)
federationLink boolean   ReadOnly Is this a 
federation link
authIdentity   short-string  ReadOnly authId of 
connection if authentication enabled
remoteProcessName  long-string   ReadOnly  optional   Name of 
executable running as remote client
remotePid  uint32ReadOnly  optional   Process ID of 
remote client
remoteParentPiduint32ReadOnly  optional   Parent 
Process ID of remote client
shadow boolean   ReadOnly True for 
shadow connections
closingbooleanTrue for 
shadow connections
framesFromClient   uint64 True for 
shadow connections
framesToClient uint64 True for 
shadow connections
bytesFromClientuint64 True for 
shadow connections
bytesToClient  uint64 True for 
shadow connections
msgsFromClient uint64 True for 
shadow connections
msgsToClient   uint64 True for 
shadow connections

  Method: close
qpid:
{code}

If this example, you can see that the {{shadow}} element's description ({{True 
for shadow connections}}) has been repeated for all elements after it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Created] (QPID-3445) Assertion, and unexpected exception in qpid::messaging::decode

2011-08-22 Thread Paul Colby (JIRA)

Assertion, and unexpected exception in qpid::messaging::decode
--

 Key: QPID-3445
 URL: https://issues.apache.org/jira/browse/QPID-3445
 Project: Qpid
  Issue Type: Bug
  Components: C++ Client
Affects Versions: 0.10, Future
Reporter: Paul Colby


Although this is technically two different bug reports, they are very closely 
related, and should probably be tested / fixed together, so I'm reporting them 
both here... hope that's okay ;)

Both {{qpid::messaging::decode}} functions can assert, or throw an unexpected 
{{qpid::framing::IllegalArgumentException}} on invalid input.

Consider the following code fragment:
{code}
const qpid::messaging::Message message(foo);
try {
qpid::types::Variant::Map map;
qpid::messaging::decode(message, map); // asserts in 
qpid::framing::Buffer::getLong
} catch (const qpid::messaging::EncodingException ex) {
std::cout  qpid::messaging::EncodingException   ex.what()  
std::endl;
}
std::cout  done  std::endl; // never reached.
{code}

In that example, the {{qpid::messaging::decode}} function will result in an 
assertion in {{qpid::framing::Buffer::getLong}} as that function assumes / 
requires the buffer to be at least 4 bytes.  Clearly in this case the decode 
should fail, but ideally it should fail in a catchable way, not an assertion.

I would think the right solution would be to add a minimum size check to the 
{{qpid::framing::FieldTable::decode}} function.  But it could also be solved by 
adding the size check to the {{qpid::messaging::decode}} and/or  
{{qpid::framing::Buffer::getLong}} functions.

As a temporary workaround, client code can add a size check before the 
{{decode}} call, like:

{code}
const qpid::messaging::Message message(foo);
try {
if (message.getContent().size()  4)
throw qpid::messaging::EncodingException(message too small);
qpid::types::Variant::Map map;
qpid::messaging::decode(message, map);
} catch (const qpid::messaging::EncodingException ex) {
std::cout  qpid::messaging::EncodingException   ex.what()  
std::endl;
}
std::cout  done  std::endl;
{code}

But now if we extend the message a little, so that it is at least 4 bytes long 
like so:
{code}
const qpid::messaging::Message message(\0\0\0\7foo, 7);
try {
if (message.getContent().size()  4)
throw qpid::messaging::EncodingException(message too small);
qpid::types::Variant::Map map;
qpid::messaging::decode(message, map);
} catch (const qpid::messaging::EncodingException ex) {
std::cout  qpid::messaging::EncodingException   ex.what()  
std::endl;
}
std::cout  done  std::endl; // never reached.
{code}

Then we run into a second problem.  In that case, the {{done}} line is still 
not reached, because a {{qpid::framing::IllegalArgumentException}} is thrown in 
{{qpid::framing::FieldTable::decode}} with message {{Not enough data for field 
table.}}.  However, this exception type is not listed in the documentation for 
the {{qpid::messaging::decode}} function - the documentation only mentions 
{{EncodingException}}, and the two share no common ancestry until right back at 
{{std::exception}}.

Although one solution might be just to add {{IllegalArgumentException}} to the 
documentation, I suspect a preferable solution would be to catch the 
{{IllegalArgumentException}} in {{qpid::messaging::decode}} and re-throw it as 
an {{EncodingException}} like:
{code}
 static void decode(const Message message, typename C::ObjectType object, 
const std::string encoding)
 {
 checkEncoding(message, encoding);
-C::decode(message.getContent(), object);
+try {
+C::decode(message.getContent(), object);
+} catch (const qpid::Exception ex) {
+throw EncodingException(ex.what());
+}
 }
{code}

A quick code review shows that {{qpid::framing::FieldTable::decode}} (and thus 
{{qpid::messaging::decode}}) can also throw the {{OutOfBounds}} exception, 
which, like {{IllegalArgumentException}}, descends from {{qpid::Exception}}.  
So a final solution might look something like:
{code}
Index: framing/FieldTable.cpp
===
--- framing/FieldTable.cpp  (revision 1160172)
+++ framing/FieldTable.cpp  (working copy)
@@ -198,10 +198,12 @@

 void FieldTable::decode(Buffer buffer){
 clear();
+if (buffer.available()  4)
+throw IllegalArgumentException(QPID_MSG(Not enough data for field 
table.));
 uint32_t len = buffer.getLong();
 if (len) {
 uint32_t available = buffer.available();
-if (available  len)
+if ((available  len) || (available  4))
 throw IllegalArgumentException(QPID_MSG(Not enough data for field 
table.));
 uint32_t count = buffer.getLong();
 uint32_t leftover = available - len;
Index: messaging/Message.cpp

[jira] [Created] (QPID-3443) the C++ broker uses the wrong exception type when clients try to modify the default exchange

2011-08-22 Thread Robbie Gemmell (JIRA)

the C++ broker uses the wrong exception type when clients try to modify the 
default exchange


 Key: QPID-3443
 URL: https://issues.apache.org/jira/browse/QPID-3443
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.13
Reporter: Robbie Gemmell
 Fix For: Future


Various test cases in AddressBasedDestinationTest are failing on the C++ test 
profiles, due to an exception being returned indicating the client tried to 
modify the default exchange. The exception is a NOT_ALLOWED, but the 0-10 spec 
says this should be met with an ILLEGAL_ARGUMENT exception.

Eg:


Testcase: testDestinationOnSend took 0.207 sec
Caused an ERROR
Error registering consumer: org.apache.qpid.AMQException: ch=0 id=0 
ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
commandCode=4, fieldI
ndex=0, description=not-allowed: Bind not allowed for default exchange 
(qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
javax.jms.JMSException: Error registering consumer: 
org.apache.qpid.AMQException: ch=0 id=0 
ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=
7, commandCode=4, fieldIndex=0, description=not-allowed: Bind not allowed for 
default exchange (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: n
ot allowed]
at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2057)
at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2000)
at 
org.apache.qpid.client.AMQConnectionDelegate_0_10.executeRetrySupport(AMQConnectionDelegate_0_10.java:325)
at 
org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:570)
at 
org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
at 
org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1998)
at org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:971)
at 
org.apache.qpid.test.client.destination.AddressBasedDestinationTest.testDestinationOnSend(AddressBasedDestinationTest.java:1119)
at 
org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:128)
Caused by: org.apache.qpid.AMQException: ch=0 id=0 
ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
commandCode=4, fieldIndex=0, descripti
on=not-allowed: Bind not allowed for default exchange 
(qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
at 
org.apache.qpid.client.AMQSession_0_10.setCurrentException(AMQSession_0_10.java:1058)
at 
org.apache.qpid.client.AMQSession_0_10.sync(AMQSession_0_10.java:1038)
at 
org.apache.qpid.client.AMQSession_0_10.sendQueueBind(AMQSession_0_10.java:377)
at org.apache.qpid.client.AMQSession$2.execute(AMQSession.java:678)
at 
org.apache.qpid.client.failover.FailoverNoopSupport.execute(FailoverNoopSupport.java:67)
at org.apache.qpid.client.AMQSession.bindQueue(AMQSession.java:674)
at 
org.apache.qpid.client.AMQSession.registerConsumer(AMQSession.java:2854)
at org.apache.qpid.client.AMQSession.access$500(AMQSession.java:120)
at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2034)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Updated] (QPID-3437) qpid-config address option confusing in help

2011-08-22 Thread Pavel Moravec (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Moravec updated QPID-3437:


Attachment: (was: qpid_tools_authentication.ods)

 qpid-config address option confusing in help
 

 Key: QPID-3437
 URL: https://issues.apache.org/jira/browse/QPID-3437
 Project: Qpid
  Issue Type: Improvement
  Components: Documentation, Tools
Affects Versions: 0.10
Reporter: Pavel Moravec
Priority: Minor
  Labels: patch
 Attachments: 
 0006-Bug-732369-Help-address-ambiguity-for-qpid-config.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 qpid-config --help prints confusing / ambiguity information how to use address
 option (-a user/password@broker). On first place it is specified without -a
 option (wrong), second place is not descriptive about address syntax:
 qpid-config --help
 Usage:  qpid-config [OPTIONS]
 ..
 ADDRESS syntax:
   [username/password@] hostname [:port]
   [username/password@] ip-address [:port]
 ..
   General Options:
 ..
 -a address, --broker-addr=address
 Address of qpidd broker
 Proposed patch removes the ADDRESS syntax part and adds the address syntax to 
 -a option (to follow structure of the help).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] [Commented] (QPID-3415) CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-08-22 Thread jirapos...@reviews.apache.org (JIRA)

[
https://issues.apache.org/jira/browse/QPID-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088624#comment-13088624
]

jirapos...@reviews.apache.org commented on QPID-3415:
-