[jira] [Resolved] (QPID-3596) Python tests fails as Java Broker does not validate for reserved exchange names on create/bind

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3596.
--

Resolution: Fixed

Looks ok to me.

> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> --
>
> Key: QPID-3596
> URL: https://issues.apache.org/jira/browse/QPID-3596
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> qpid_tests.broker_0_10.exchange.DeclareMethodExchangeFieldReservedRuleTests.*

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3596) Python tests fails as Java Broker does not validate for reserved exchange names on create/bind

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3596:
-

Assignee: Robbie Gemmell  (was: Rob Godfrey)

Robbie - can you review this one for me

> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> --
>
> Key: QPID-3596
> URL: https://issues.apache.org/jira/browse/QPID-3596
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> qpid_tests.broker_0_10.exchange.DeclareMethodExchangeFieldReservedRuleTests.*

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3596) Python tests fails as Java Broker does not validate for reserved exchange names on create/bind

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-3596:
--

Status: Ready To Review  (was: In Progress)

> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> --
>
> Key: QPID-3596
> URL: https://issues.apache.org/jira/browse/QPID-3596
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
> Fix For: 0.15
>
>
> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> qpid_tests.broker_0_10.exchange.DeclareMethodExchangeFieldReservedRuleTests.*

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3596) Python tests fails as Java Broker does not validate for reserved exchange names on create/bind

2012-02-20 Thread Rob Godfrey (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212277#comment-13212277
 ] 

Rob Godfrey commented on QPID-3596:
---

It seems reasonable to add this check to both the 0-[8/9/9-1] and 0-10 
codepaths and then uncomment this test

> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> --
>
> Key: QPID-3596
> URL: https://issues.apache.org/jira/browse/QPID-3596
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
> Fix For: 0.15
>
>
> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> qpid_tests.broker_0_10.exchange.DeclareMethodExchangeFieldReservedRuleTests.*

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3596) Python tests fails as Java Broker does not validate for reserved exchange names on create/bind

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3596:
-

Assignee: Rob Godfrey

> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> --
>
> Key: QPID-3596
> URL: https://issues.apache.org/jira/browse/QPID-3596
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
> Fix For: 0.15
>
>
> Python tests fails as Java Broker does not validate for reserved exchange 
> names on create/bind
> qpid_tests.broker_0_10.exchange.DeclareMethodExchangeFieldReservedRuleTests.*

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-924) Ruby test.rb use of '0.0.0.0' for localhost doesn't work under cygwin

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-924.
-

Resolution: Won't Fix

Given we deleted the old ruby tree and this is nearing 4 yers old im going to 
guess this was part of it and isnt an issue anymore. Resolving.

> Ruby test.rb use of '0.0.0.0' for localhost doesn't work under cygwin
> -
>
> Key: QPID-924
> URL: https://issues.apache.org/jira/browse/QPID-924
> Project: Qpid
>  Issue Type: Bug
>  Components: Ruby Test Suite
>Affects Versions: M2.1
>Reporter: Martin Ritchie
>
> Summary:
> The use of '0.0.0.0' in the test.rb file for localhost does not work under 
> cygwin and windows. 
> Suggest changing it to 'localhost'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3477.
--

   Resolution: Fixed
Fix Version/s: 0.15

Looks good.

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3861) [Java Broker] Run (some of the) Python tests for Message Grouping against the Java Broker

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3861.
--

Resolution: Fixed

Looks good to me.

> [Java Broker] Run (some of the) Python tests for Message Grouping against the 
> Java Broker
> -
>
> Key: QPID-3861
> URL: https://issues.apache.org/jira/browse/QPID-3861
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Python Test Suite
>Reporter: Rob Godfrey
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> There are a number of python tests for Message Grouping that should now be 
> runnable against the Java Broker.
> Unfortunately about half of them depend on a level QMF support which the Java 
> Broker does not seem to currently be able to provide. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-3477:
--

Status: Ready To Review  (was: In Progress)

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3477:
-

Assignee: Rob Godfrey  (was: Robbie Gemmell)

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3477:
-

Assignee: Robbie Gemmell  (was: Rob Godfrey)

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Rob Godfrey (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212267#comment-13212267
 ] 

Rob Godfrey commented on QPID-3477:
---

I've changed the test to use a valid code, updated the Subscription so that 
rejected messages which cannot be routed via an alternate exchange are 
discarded, and removed the exclusion from the ignore list.

Robbie - can you review?

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Priority: Minor
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3477:
-

Assignee: Robbie Gemmell

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3861) [Java Broker] Run (some of the) Python tests for Message Grouping against the Java Broker

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-3861:
--

Status: Ready To Review  (was: In Progress)

> [Java Broker] Run (some of the) Python tests for Message Grouping against the 
> Java Broker
> -
>
> Key: QPID-3861
> URL: https://issues.apache.org/jira/browse/QPID-3861
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Python Test Suite
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> There are a number of python tests for Message Grouping that should now be 
> runnable against the Java Broker.
> Unfortunately about half of them depend on a level QMF support which the Java 
> Broker does not seem to currently be able to provide. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3861) [Java Broker] Run (some of the) Python tests for Message Grouping against the Java Broker

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3861:
-

Assignee: Robbie Gemmell  (was: Rob Godfrey)

Robbie - can you review this one please?

> [Java Broker] Run (some of the) Python tests for Message Grouping against the 
> Java Broker
> -
>
> Key: QPID-3861
> URL: https://issues.apache.org/jira/browse/QPID-3861
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Python Test Suite
>Reporter: Rob Godfrey
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> There are a number of python tests for Message Grouping that should now be 
> runnable against the Java Broker.
> Unfortunately about half of them depend on a level QMF support which the Java 
> Broker does not seem to currently be able to provide. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Created] (QPID-3861) [Java Broker] Run (some of the) Python tests for Message Grouping against the Java Broker

2012-02-20 Thread Rob Godfrey (Created) (JIRA)
[Java Broker] Run (some of the) Python tests for Message Grouping against the 
Java Broker
-

 Key: QPID-3861
 URL: https://issues.apache.org/jira/browse/QPID-3861
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker, Python Test Suite
Reporter: Rob Godfrey
Assignee: Rob Godfrey
Priority: Minor
 Fix For: 0.15


There are a number of python tests for Message Grouping that should now be 
runnable against the Java Broker.

Unfortunately about half of them depend on a level QMF support which the Java 
Broker does not seem to currently be able to provide. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3437) qpid-config address option confusing in help

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3437.
--

   Resolution: Fixed
Fix Version/s: 0.13

Patch was applied ages ago, resolving.

> qpid-config address option confusing in help
> 
>
> Key: QPID-3437
> URL: https://issues.apache.org/jira/browse/QPID-3437
> Project: Qpid
>  Issue Type: Improvement
>  Components: Documentation, Tools
>Affects Versions: 0.10
>Reporter: Pavel Moravec
>Assignee: Nuno Santos
>Priority: Minor
>  Labels: patch
> Fix For: 0.13
>
> Attachments: 
> 0006-Bug-732369-Help-address-ambiguity-for-qpid-config.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> qpid-config --help prints confusing / ambiguity information how to use address
> option (-a user/password@broker). On first place it is specified without -a
> option (wrong), second place is not descriptive about address syntax:
> qpid-config --help
> Usage:  qpid-config [OPTIONS]
> ..
> ADDRESS syntax:
>   [username/password@] hostname [:]
>   [username/password@] ip-address [:]
> ..
>   General Options:
> ..
> -a , --broker-addr=
> Address of qpidd broker
> Proposed patch removes the ADDRESS syntax part and adds the address syntax to 
> -a option (to follow structure of the help).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-2750) remove erroneous asserts about LongString lengths in EncodingUtils

2012-02-20 Thread Rob Godfrey (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey resolved QPID-2750.
---

Resolution: Fixed

Loogs good to me

> remove erroneous asserts about LongString lengths in EncodingUtils
> --
>
> Key: QPID-2750
> URL: https://issues.apache.org/jira/browse/QPID-2750
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Client
>Affects Versions: 0.5, 0.6, 0.14
>Reporter: Martin Ritchie
>Assignee: Rob Godfrey
> Fix For: 0.15
>
>
> In particular,
> EncodingUtils has limitations put on Long String content which are wrong. 
> These should be removed.
> e.g. 
> L 261: assert (s == null) || (s.length() <= 0xFFFE);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-568) [Document] How to use Qpid with 3rd party tools

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-568:


Assignee: (was: Martin Ritchie)

> [Document] How to use Qpid with 3rd party tools
> ---
>
> Key: QPID-568
> URL: https://issues.apache.org/jira/browse/QPID-568
> Project: Qpid
>  Issue Type: Task
>  Components: Starter, Website
>Affects Versions: M2.1, M3
>Reporter: Martin Ritchie
>
> Document how to use qpid with 3rd party tools:
> Some potential tools where describing the configuration steps may help.
>  - JBoss
>  - Spring
>  - Mule 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-568) [Document] How to use Qpid with 3rd party tools

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-568:


Component/s: Starter

> [Document] How to use Qpid with 3rd party tools
> ---
>
> Key: QPID-568
> URL: https://issues.apache.org/jira/browse/QPID-568
> Project: Qpid
>  Issue Type: Task
>  Components: Starter, Website
>Affects Versions: M2.1, M3
>Reporter: Martin Ritchie
>Assignee: Martin Ritchie
>
> Document how to use qpid with 3rd party tools:
> Some potential tools where describing the configuration steps may help.
>  - JBoss
>  - Spring
>  - Mule 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-2699) Interop coordinator should not depend on qpid broker libraries.

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-2699.
--

Resolution: Won't Fix

These classes will be put on the chopping block soon enough so we wont be 
fixing this, resolving.

> Interop coordinator should not depend on qpid broker libraries.
> ---
>
> Key: QPID-2699
> URL: https://issues.apache.org/jira/browse/QPID-2699
> Project: Qpid
>  Issue Type: Improvement
>Affects Versions: 0.6, 0.7
>Reporter: Sorin Suciu
>Assignee: Sorin Suciu
>Priority: Minor
>
> The coordinator currently depends on QpidBrokerTestCase (needs the 
> getConnection() call). As the coordinator acts actually as a client, only the 
> client and common library should be a dependency. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-2164) Interop test cases should not be subclasses of QpidTestCase

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-2164.
--

Resolution: Won't Fix

These classes will be put on the chopping block soon enough so we wont be 
fixing this, resolving.

> Interop test cases should not be subclasses of QpidTestCase
> ---
>
> Key: QPID-2164
> URL: https://issues.apache.org/jira/browse/QPID-2164
> Project: Qpid
>  Issue Type: Test
>  Components: Interop Testing
>Affects Versions: 0.5
>Reporter: Robbie Gemmell
>Priority: Minor
>
> The Interop test cases extend FrameworkBaseCase, which extends QpidTestCase. 
> This causes problems with the Interop testing which results in the tests 
> failing to work due to ClassCastExceptions raised as a result of exception 
> handling by JUnit, unless the user knows which unrelated properties to set in 
> and what values to set them to in order to work around QpidTestCase 
> behaviour. As the Interop testing makes no use of QTC facilities, they should 
> be updated not to subclass QTC.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-2576) Standardise queue Ownership across protocols

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-2576.
--

Resolution: Fixed

This has been done.

> Standardise queue Ownership across protocols
> 
>
> Key: QPID-2576
> URL: https://issues.apache.org/jira/browse/QPID-2576
> Project: Qpid
>  Issue Type: Bug
>Reporter: Martin Ritchie
>Assignee: Martin Ritchie
>
> Currently the broker does not have a consistent view of who the queue Owner 
> is. The 0-8/0-9/0-91 code path uses client id.
> The 0-10 code path uses the authenticated user name.
> In a number of locations such as:
>  DerbyMessageStore uses the authenticated Principal name.
>  QueueDeclareHandler compares principal name against getOwner for exclusive 
> queue checks. 
>  (This will only work if a 0-10 client created the queue as it will set the 
> owner name to the principal name, see sub jira on this issue)
> From the JMS Spec 4.3.2
> The purpose of the client identifier is to associate a connection and its 
> objects
> with a state maintained on behalf of the client by a provider. By definition, 
> the
> client state identified by a client identifier can be `in use' by only one 
> client at
> a time. A JMS provider must prevent concurrently executing clients from using
> it.
> Which suggests that it could be used to perform exclusive queue detection 
> rather than the authenticated user that could log in more than once. This 
> will need more discussion on dev.
> First step is to ensure the code all uses getOwner even if the 0-10 version 
> currently sets that to the authenticated Principal.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-2912) Modify python-test.xml to use ant to run the python tests

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-2912.
--

Resolution: Fixed

We are using this file now in Jenkins via Ant, so this has been done.

> Modify python-test.xml to use ant to run the python tests
> -
>
> Key: QPID-2912
> URL: https://issues.apache.org/jira/browse/QPID-2912
> Project: Qpid
>  Issue Type: Improvement
>  Components: Python Test Suite
>Affects Versions: 0.7
>Reporter: Sorin Suciu
>Assignee: Sorin Suciu
>Priority: Minor
>
> Currently the python-test.xml script from qpid/java/broker assumes we are 
> building using maven. It would be useful to have the ability to run the 
> python scripts as an ant task, in the eventuality maven is chosen as a 
> builder it can easily accommodate the ant task.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-1757) Create Python example package

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-1757.
--

Resolution: Later

Nearing 3 years now, if it hasnt happened yet its probably not going to, 
closing.

> Create Python example package
> -
>
> Key: QPID-1757
> URL: https://issues.apache.org/jira/browse/QPID-1757
> Project: Qpid
>  Issue Type: Sub-task
>  Components: Build Tools
>Reporter: Martin Ritchie
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-1746) Release Package generation

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-1746.
--

Resolution: Fixed

Resolving along with the last sub task.

> Release Package generation
> --
>
> Key: QPID-1746
> URL: https://issues.apache.org/jira/browse/QPID-1746
> Project: Qpid
>  Issue Type: Task
>  Components: Build Tools
>Reporter: Martin Ritchie
>Assignee: Martin Ritchie
>
> Package list discussed on Qpid Dev.
> - Single Source package
> - C++ Source package
> - Binary Packages for
>  + Brokers
>   + C++
> - Windows only from Qpid, simply link to other downstream binary
> builds for other platforms
>   + Java
>  + Client and Example Package
>   + C++
> - Windows only from Qpid, simply link to other downstream binary
> builds for other platforms
>   + C# (0-8,0-10)
>   + Java
>   + Python
>   + Ruby
> + Management
>  - Eclipse JMX Console
>+ Win
>+ Linux
>+ OS X
>  - JMX Command Line Tool
>  - QMan / WsDmAdapter
>  - QMF Command line tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-283) Document Performance Tests

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-283.
-

Resolution: Won't Fix
  Assignee: (was: Martin Ritchie)

We are aiming to get rid of these old tests fairly soon, no point documenting 
them now.

> Document Performance Tests
> --
>
> Key: QPID-283
> URL: https://issues.apache.org/jira/browse/QPID-283
> Project: Qpid
>  Issue Type: Task
>  Components: Website
>Affects Versions: M3
>Reporter: Martin Ritchie
>
> Check and updated instructions for running Ping & ServiceRequest/Reply tests 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-2586) Give Client 0-10 close semantics not detach

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-2586.
--

Resolution: Fixed

Resolving this, I believe it now works as desired for both situations and 
nothing has been done with it in a approaching a couple years, we can open a 
new JIRA if something else happens.

> Give Client 0-10 close semantics not detach
> ---
>
> Key: QPID-2586
> URL: https://issues.apache.org/jira/browse/QPID-2586
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client
>Reporter: Martin Ritchie
>Assignee: Martin Ritchie
>
> Currently the way the 0-10 java client creates a session actually means that 
> on close the sessions should detach not close.
> Setting the timeout to 0 on creation will result in it performing a close. 
> The code currently actually performs a close rather than a detach as detach 
> has not been implemented. 
> The setting of the initial timeout to 0 will just mean the client's current 
> behaviour is reflected in correctly in the protocol frames it sends.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-2750) remove erroneous asserts about LongString lengths in EncodingUtils

2012-02-20 Thread Robbie Gemmell (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-2750:


Assignee: Robbie Gemmell

> remove erroneous asserts about LongString lengths in EncodingUtils
> --
>
> Key: QPID-2750
> URL: https://issues.apache.org/jira/browse/QPID-2750
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Client
>Affects Versions: 0.5, 0.6, 0.14
>Reporter: Martin Ritchie
>Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> In particular,
> EncodingUtils has limitations put on Long String content which are wrong. 
> These should be removed.
> e.g. 
> L 261: assert (s == null) || (s.length() <= 0xFFFE);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-2750) remove erroneous asserts about LongString lengths in EncodingUtils

2012-02-20 Thread Robbie Gemmell (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-2750:


Assignee: Rob Godfrey  (was: Robbie Gemmell)

Rob, can you review this change please?

Robbie

> remove erroneous asserts about LongString lengths in EncodingUtils
> --
>
> Key: QPID-2750
> URL: https://issues.apache.org/jira/browse/QPID-2750
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Client
>Affects Versions: 0.5, 0.6, 0.14
>Reporter: Martin Ritchie
>Assignee: Rob Godfrey
> Fix For: 0.15
>
>
> In particular,
> EncodingUtils has limitations put on Long String content which are wrong. 
> These should be removed.
> e.g. 
> L 261: assert (s == null) || (s.length() <= 0xFFFE);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-2750) remove erroneous asserts about LongString lengths in EncodingUtils

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2750:
-

Affects Version/s: 0.14
Fix Version/s: 0.15
  Summary: remove erroneous asserts about LongString lengths in 
EncodingUtils  (was: Remove erroneous Asserts in code base.)

> remove erroneous asserts about LongString lengths in EncodingUtils
> --
>
> Key: QPID-2750
> URL: https://issues.apache.org/jira/browse/QPID-2750
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Client
>Affects Versions: 0.5, 0.6, 0.14
>Reporter: Martin Ritchie
> Fix For: 0.15
>
>
> In particular,
> EncodingUtils has limitations put on Long String content which are wrong. 
> These should be removed.
> e.g. 
> L 261: assert (s == null) || (s.length() <= 0xFFFE);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-2750) remove erroneous asserts about LongString lengths in EncodingUtils

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2750:
-

Status: Ready To Review  (was: In Progress)

> remove erroneous asserts about LongString lengths in EncodingUtils
> --
>
> Key: QPID-2750
> URL: https://issues.apache.org/jira/browse/QPID-2750
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Client
>Affects Versions: 0.5, 0.6, 0.14
>Reporter: Martin Ritchie
>Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> In particular,
> EncodingUtils has limitations put on Long String content which are wrong. 
> These should be removed.
> e.g. 
> L 261: assert (s == null) || (s.length() <= 0xFFFE);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: svn commit: r1291436 - in /qpid/trunk/qpid/cpp: include/qpid/framing/ include/qpid/types/ managementgen/qmfgen/ managementgen/qmfgen/templates/ src/qmf/ src/qpid/broker/ src/qpid/ha/

2012-02-20 Thread Andrew Stitcher
On Mon, 2012-02-20 at 17:28 -0500, Alan Conway wrote:
> ...
> That is because there was no code outside of libqpidbroker calling the
> generated functions (except for cluster.so but that is never built on
> windows.) The ha plugin now also calls some QMF generated functions.
> 
> Perhaps a better solution is to move the QMF generated code for each
> plugin into the plugin library itself, rather than putting it all into
> libqpidbroker. If that's preferable I can do that.
> 

I'd say that would be the most preferable idea - any generated code
should only be included with the code that actually uses it. This is
particular irritation with the current cluster implementation IMO.

Andrew



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3661) Client OSGi bundle cannot deserialise messages

2012-02-20 Thread Andrew Kennedy (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212200#comment-13212200
 ] 

Andrew Kennedy commented on QPID-3661:
--

Cool. I can't remember why I didn't do this at the time, since it's the 
solution mentioned in the JIRA description ;) Thanks, anyway, Robbie!

> Client OSGi bundle cannot deserialise messages
> --
>
> Key: QPID-3661
> URL: https://issues.apache.org/jira/browse/QPID-3661
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
> Environment: OSGi container (Karaf 2.2.4)
>Reporter: Andrew Kennedy
>Assignee: Andrew Kennedy
> Fix For: 0.15
>
>
> When using the client OSGi bundle, Object messages cannot be delivered 
> because the Classes needed cannot be imported. The .bnd file needs to have a 
> wildcard DynamicImport-Package line added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3835) [Java broker] DurableSubscriptions without a selector on 0-10 connections will initially be unsubscribed at reconnect following upgrade of a legacy message store

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3835.
--

Resolution: Fixed

Given previous comments I am just resolving this :)

> [Java broker] DurableSubscriptions without a selector on 0-10 connections 
> will initially be unsubscribed at reconnect following upgrade of a legacy 
> message store
> -
>
> Key: QPID-3835
> URL: https://issues.apache.org/jira/browse/QPID-3835
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Broker BDB Store
>Affects Versions: 0.14
>Reporter: Robbie Gemmell
>Assignee: Keith Wall
>Priority: Critical
> Fix For: 0.15
>
>
> DurableSubscriptions without a selector on 0-10 connections will initially be 
> unsubscribed at reconnect following upgrade of a legacy message store. If an 
> older broker release is upgraded to the current format, the bindings for a 
> DurableSubscriptions backing queue must be modified if it previously had no 
> selector, to ensure the client can correctly reconnect to the 
> DurableSubscription without having the existing messages lost due to an 
> unsubscribe() bring performed.
> This is because the newer clients send the server-side selector argument with 
> an empty value to signfify the lack of a selector (to allow later querying if 
> the selector has changed in any way when using the 0-10 client) whereas old 
> clients used the complete lack of the argument to signal this. As a result, 
> when determining if the selector has changed following a store upgrade from a 
> legacy broker, the client would incorrectly believe it had and follow the JMS 
> spec behaviour of doing an unsubscribe() before continuing, which would have 
> the effect of deleting the backing queue. The bindings of such queues should 
> be manipulated during the upgrade process to add the selector argument if it 
> isnt already present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3786) When creating an destination from an incomming message, the legacy fields should also be populated.

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-3786:
-

Labels: possibly_complete  (was: )

> When creating an destination from an incomming message, the legacy fields 
> should also be populated.
> ---
>
> Key: QPID-3786
> URL: https://issues.apache.org/jira/browse/QPID-3786
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.14
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
>  Labels: possibly_complete
> Fix For: 0.15
>
>
> When a destination is created from an incoming message (and if the syntax is 
> Addr) we need to populate fields like queue-name, exchange & routingkey in 
> addition to creating the address string.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3466) The toString() method for JMSDestination and JMSReplyTo is not formatted properly according to the destination syntax.

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-3466:
-

Labels: possibly_complete  (was: )

> The toString() method for JMSDestination and JMSReplyTo is not formatted 
> properly according to the destination syntax.
> --
>
> Key: QPID-3466
> URL: https://issues.apache.org/jira/browse/QPID-3466
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.10, 0.12
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
>  Labels: possibly_complete
> Fix For: 0.15
>
>
> The value of toString() on the JMS Destination of a message being sent is 
> different from to the toString() value of JMS Destination of the same message 
> on the receiver side. This sometimes confuses users when trying to debug 
> applications.
> Ex for client using the ADDR syntax.
> Sender side
> JMS Destination: 'amq.direct'/'test'; None
> Receiver side
> JMS Destination: direct://amq.direct/test/test?routingkey='test'
> It would be nice if the string representation of JMSDestination and the 
> JMSReplyTo destination is formatted according to the chosen destination 
> syntax.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-2733) Temp queues created when receiving from an exchange are not deleted.

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2733:
-

Labels: possibly_complete  (was: )

> Temp queues created when receiving from an exchange are not deleted.  
> --
>
> Key: QPID-2733
> URL: https://issues.apache.org/jira/browse/QPID-2733
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
>  Labels: possibly_complete
> Fix For: Future
>
>
> In the new addressing scheme, when you subscribe to an exchange a temp queue 
> is created for the subscriber.
> The queue deletion depends on the reliability mode.
> If reliability mode is "unreliable" or "at-most-once" then the queue should 
> be created with auto-delete=true. 
> If reliability mode is "at-least-once" then the queue should set 
> auto-delete=false, and the queue will only be deleted if the client app 
> invokes consumer.close().
> If x-declare properties include auto-delete=true, then the reliability mode 
> is ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3783) When creating an Address using a toString() of another address object, "None" is used as the subject when it should be Null.

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-3783:
-

Labels: possibly_complete  (was: )

> When creating an Address using a toString() of another address object, "None" 
> is used as the subject when it should be Null.
> 
>
> Key: QPID-3783
> URL: https://issues.apache.org/jira/browse/QPID-3783
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.14
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
>  Labels: possibly_complete
> Fix For: 0.15
>
>
> When printing an address we use "None" to denote an empty subject.
> Therefore we If create an address object using the toString() method of 
> another address object, None is used as the subject.
> The following code snippet illustrates the issue
> {code}
> Address addr = Address.parse("MY_QUEUE; {create : always}");
> System.out.println("Addr1 : " + addr);
>   
> Address addr2 = Address.parse(addr.toString());
> System.out.println("Addr2 : " + addr2);
> {code}
> The solution is to set the subject field to null if the subject is "None".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3836) no-local does not work for Qpid 0-10 JMS client when using address strings

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-3836:
-

Labels: possibly_complete  (was: )

> no-local does not work for Qpid 0-10 JMS client when using address strings
> --
>
> Key: QPID-3836
> URL: https://issues.apache.org/jira/browse/QPID-3836
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.12
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>  Labels: possibly_complete
> Fix For: 0.15
>
>
> If no-local is set to true when create a consumer or a durable subscriber, 
> messages published by the same connection should not be seen by this consumer.
> Currently due to a bug no-local is not passed correctly when creating the 
> subscription queue.
> All though this works for Topics and Queues created when this information is 
> available, not sure how this should be handled when subscribing to an already 
> existing queue.
> AKAIK the no-local argument is passed on during queue-declare. Perhaps there 
> is also a way to pass this on when creating a subscription ?
> (I will update the description when I find the answer to the above question). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: svn commit: r1291436 - in /qpid/trunk/qpid/cpp: include/qpid/framing/ include/qpid/types/ managementgen/qmfgen/ managementgen/qmfgen/templates/ src/qmf/ src/qpid/broker/ src/qpid/ha/

2012-02-20 Thread Alan Conway
On Mon, 2012-02-20 at 16:23 -0500, Ted Ross wrote:
> The scope of this fix seems to be much greater than that of the commit 
> that broke Windows.

It looks that way because in the original commit you only see the new
code for the HA plugin being added. You don't see the set of functions
in libqpidbroker that are being called by that new code - which is what
you see in the fix commit.

> A couple of questions:
> 
> 1) Why add "BrokerImportExport.h" to cpp/src/qmf?  There's already a 
> cpp/include/qmf/ImportExport.h that serves the same purpose.

It doesn't. qmf/ImportExport.h defines EXTERNS for the qmf.so library.
The generated code doesn't go in that library, it goes in
libqpidbroker.so. Hence the awkward BrokerImportExport for the generated
code.

> 2) Why all the changes to the generated code?  The old generation 
> templates worked fine under Windows.

That is because there was no code outside of libqpidbroker calling the
generated functions (except for cluster.so but that is never built on
windows.) The ha plugin now also calls some QMF generated functions.

Perhaps a better solution is to move the QMF generated code for each
plugin into the plugin library itself, rather than putting it all into
libqpidbroker. If that's preferable I can do that.

> The main thing you need to be concerned with is that any classes and 
> class methods that need to be accessible from outside the 
> DLL/shared-object are prefixed with the proper EXTERN symbol *for the 
> library*.  Furthermore, there's a different EXTERN symbol for inline 
> methods.

Correct, and as things are currently linked the ha plugin needs to call
QMF generated symbols in libqpidbroker so they need EXTERNs. Why do we
need EXTERNs for inline code? From what I saw making the changes, we
don't currently have EXTERNS on many/most inline functions in
libqpidbroker.

I'll be happy to fix this up however we decide is best.

Cheers,
Alan.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-2343) Provide a consistent naming convention for JMS client properties

2012-02-20 Thread Robbie Gemmell (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212170#comment-13212170
 ] 

Robbie Gemmell commented on QPID-2343:
--

We are now doing this sort of thing implicitly as part of ongoing development, 
I think this JIRA can be closed. JIRAs really shouldnt span versions if it can 
be helped, and there havent been any commits to this issue explicitly in a long 
time.

> Provide a consistent naming convention for JMS client properties
> 
>
> Key: QPID-2343
> URL: https://issues.apache.org/jira/browse/QPID-2343
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client
>Affects Versions: 0.6
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>  Labels: possibly_complete
> Fix For: Future
>
> Attachments: QPID-2343.patch, QPID-2343_take2.patch
>
>
> It would be nice if all Qpid clients followed a similar convention for naming 
> configuration properties.
> The C++ client currently use the following convention. 
> "qpid" . 
> For starters the JMS client could follow the same strategy.  Some of its 
> properties are starting with "amqj" while other are using "qpid".
> The logical choice would be to use "qpid" with backwards compatibility 
> for old property name.
> The following thread captured the discussion happened on qpid-dev
> http://mail-archives.apache.org/mod_mbox/qpid-dev/201001.mbox/%3cf5f5e0731001081456g5390a9c3w95c42b6fd7a8a...@mail.gmail.com%3E
> The following location will be used to document all the client properties.
> http://cwiki.apache.org/confluence/display/qpid/Qpid+extensions+to+AMQP
> As Robert mentioned all properties should indicate how they are used and 
> whether they alter only client internal behaviour, or whether they are passed 
> down the wire to the broker which could alter broker behaviour
> Later on it will be added to the documentation being developed in the Qpid 
> svn.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-2343) Provide a consistent naming convention for JMS client properties

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2343:
-

Labels: possibly_complete  (was: )

> Provide a consistent naming convention for JMS client properties
> 
>
> Key: QPID-2343
> URL: https://issues.apache.org/jira/browse/QPID-2343
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client
>Affects Versions: 0.6
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>  Labels: possibly_complete
> Fix For: Future
>
> Attachments: QPID-2343.patch, QPID-2343_take2.patch
>
>
> It would be nice if all Qpid clients followed a similar convention for naming 
> configuration properties.
> The C++ client currently use the following convention. 
> "qpid" . 
> For starters the JMS client could follow the same strategy.  Some of its 
> properties are starting with "amqj" while other are using "qpid".
> The logical choice would be to use "qpid" with backwards compatibility 
> for old property name.
> The following thread captured the discussion happened on qpid-dev
> http://mail-archives.apache.org/mod_mbox/qpid-dev/201001.mbox/%3cf5f5e0731001081456g5390a9c3w95c42b6fd7a8a...@mail.gmail.com%3E
> The following location will be used to document all the client properties.
> http://cwiki.apache.org/confluence/display/qpid/Qpid+extensions+to+AMQP
> As Robert mentioned all properties should indicate how they are used and 
> whether they alter only client internal behaviour, or whether they are passed 
> down the wire to the broker which could alter broker behaviour
> Later on it will be added to the documentation being developed in the Qpid 
> svn.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-2559) When a subscription is created, message credits should only be set if the dispatcher is not null.

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2559:
-

Labels: possibly_complete  (was: )

> When a subscription is created, message credits should only be set if the 
> dispatcher is not null.
> -
>
> Key: QPID-2559
> URL: https://issues.apache.org/jira/browse/QPID-2559
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.6
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>  Labels: possibly_complete
> Attachments: QPID-2559.test
>
>
> When a subscription is created, message credits should only be set if the 
> dispatcher is not null.
> If the dispatcher is null, the session is suspended temporarily until a 
> dispatcher is created.
> And then when the session is unsuspended, message credits will be set again, 
> resulting in granting more credits than intended.
> Please note in order for this error condition to happen the dispatcher should 
> be null and the broker should have enough messages.
> If the connection is not started and the message consumer is the very first 
> to be created for that session, then the dispatcher thread for that session 
> is null.
> Steps To Reproduce
> 
> 1. create connection, but not start it
> 1. create a session with client ack
> 2. send 20 messages to a queue
> 3. create receiver with capacity (prefetch) as 10.
> 4. start connection.
> 5. receive 10 messages
> Look at the client and broker logs and observe that the broker sends more 
> messages than needed.
> Expected Result.
> 
> At any given time we should only receive n messages, where n == maxprefetch 
> (capacity as defined for the destination)
> Actual Result
> ---
> For the above conditions, we get double than what we want (provided the 
> broker has enough messages on the queue).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3688) AMQDestination and children should conform to the JavaBean pattern

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-3688:
-

Labels: possibly_complete  (was: )

> AMQDestination and children should conform to the JavaBean pattern
> --
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client
>Affects Versions: 0.12
> Environment: All platforms.
>Reporter: Weston M. Price
>Assignee: Rajith Attapattu
>  Labels: possibly_complete
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE 
> application servers, conformance to the JavaBean design pattern is preferred 
> as many appellation servers have their own management infrastructure for 
> supporting Administrative objects that require, at the very least, a default 
> constructor to create and bootstrap the destination into the server address 
> space. 
> The AMQDestination and children classes should support this to make JEE 
> integration easier and more consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3589) Python tests fails against Java broker due to difference in exception message text from CPP broker

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3589.
--

Resolution: Fixed

Looks good to me.

> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> --
>
> Key: QPID-3589
> URL: https://issues.apache.org/jira/browse/QPID-3589
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> qpid.tests.messaging.endpoints.AddressTests.testDeleteSpecial

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3662) The AMQConnectionURL class reports connection options twice

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3662.
--

Resolution: Fixed

Resolving

> The AMQConnectionURL class reports connection options twice
> ---
>
> Key: QPID-3662
> URL: https://issues.apache.org/jira/browse/QPID-3662
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Reporter: Andrew Kennedy
> Fix For: 0.15
>
>
> The AMQConnectionURL reports connection options twice. For example, if 
> setting maxprefetch, the URL would be printed as:
> amqp://guest:@ImCTj9We/localhost?maxprefetch='1'&brokerlist='tcp://localhost:1234?tcp_nodelay='true''&maxprefetch='1'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3589) Python tests fails against Java broker due to difference in exception message text from CPP broker

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-3589:
--

Status: Ready To Review  (was: In Progress)

> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> --
>
> Key: QPID-3589
> URL: https://issues.apache.org/jira/browse/QPID-3589
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> qpid.tests.messaging.endpoints.AddressTests.testDeleteSpecial

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3589) Python tests fails against Java broker due to difference in exception message text from CPP broker

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3589:
-

Assignee: Robbie Gemmell  (was: Rob Godfrey)

Robbie can you review this for me?

> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> --
>
> Key: QPID-3589
> URL: https://issues.apache.org/jira/browse/QPID-3589
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> qpid.tests.messaging.endpoints.AddressTests.testDeleteSpecial

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3604) If the connection is stopped the client should release all it's messages in the prefetch buffer

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-3604:
-

Labels: possibly_complete  (was: )

> If the connection is stopped the client should release all it's messages in 
> the prefetch buffer
> ---
>
> Key: QPID-3604
> URL: https://issues.apache.org/jira/browse/QPID-3604
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.14
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>  Labels: possibly_complete
> Fix For: 0.15
>
>
> When connection.stop() is called, the JMS client should release all it's 
> messages in the prefetch buffer.
> For all we know, the connection may never be started (depending on 
> application logic) and those messages will be stuck on the prefetch buffer. 
> Releasing it will allow another consumer to get them (in the case of a shared 
> queue case).
> Another less severe but nevertheless an undesirable side affect of this is 
> the client getting more messages than required by the capacity or prefetch 
> arguments. See QPID-3602
> This may not be a big issue if the client is prefetching a few messages, but 
> if prefetching something like 5000 messages, this could potentially cause a 
> lethal spike in the clients memory usage.
> Even in low capacity/prefetch values, if the messages are large (say in the 
> mega byte range) this could potentially put the client under memory pressure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3589) Python tests fails against Java broker due to difference in exception message text from CPP broker

2012-02-20 Thread Rob Godfrey (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212131#comment-13212131
 ] 

Rob Godfrey commented on QPID-3589:
---

Test should simply verify that the deletion attempt causes an error with code 
530 (not-allowed).  The text of the error message should not be relied upon.

> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> --
>
> Key: QPID-3589
> URL: https://issues.apache.org/jira/browse/QPID-3589
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> qpid.tests.messaging.endpoints.AddressTests.testDeleteSpecial

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3589) Python tests fails against Java broker due to difference in exception message text from CPP broker

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3589:
-

Assignee: Rob Godfrey

> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> --
>
> Key: QPID-3589
> URL: https://issues.apache.org/jira/browse/QPID-3589
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python tests fails against Java broker due to difference in exception message 
> text from CPP broker
> qpid.tests.messaging.endpoints.AddressTests.testDeleteSpecial

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3285) AMQShortString needs only be used in a transport layer for 0.8/0.9.x AMQP protocol implementations.

2012-02-20 Thread Robbie Gemmell (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-3285:


Assignee: (was: Robbie Gemmell)

> AMQShortString needs only be used in a transport layer for 0.8/0.9.x AMQP 
> protocol implementations.
> ---
>
> Key: QPID-3285
> URL: https://issues.apache.org/jira/browse/QPID-3285
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Broker Derby Store, Java Client, Java 
> Common
>Reporter: Alex Rudyy
>Priority: Minor
>
> Current implementation of AMQShortString does not deal properly with unicode 
> characters. Each character of the string is  converted into a single byte 
> using the following transformation
> (byte) (0xFF & data[i])
> In result of such transformation multi-byte characters can not be passed over 
> the wire with 0.8/0.9.x AMQP protocol implementations.
> AMQP 0.10 transport layer  does not have such issue because it does not use 
> string byte buffers from AMQShortString objects.
> AMQP 1.0 specification does not declare short string type. So, current 
> implementation of AMQShortString can not be used to implement AMQP 1.0 
> specification. For implementing of AMQP 1.0 specification java.lang.String 
> class can be used.
> Current broker and client implementations use AMQShortString classes 
> everywhere, including JMS layer, message store layer etc.
> Usages of AMQShortString beyond 0.8/0.9.x transport layers should be replaced 
> with  java.lang.String class. Only  0.8/0.9.x transport layers require 
> AMQShortString for keeping backward compatibility.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-2054) make the default Log4J configuration use a rolling file appender

2012-02-20 Thread Robbie Gemmell (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-2054:


Assignee: (was: Robbie Gemmell)

Given that our custom rolling file appender (that we shouldnt need to maintain, 
we arnet a logging project) has some issues and log4js own does too, I think I 
am probably leaning toward moving away from log4j and using somthing that does 
this for us before this change will occur.

> make the default Log4J configuration use a rolling file appender
> 
>
> Key: QPID-2054
> URL: https://issues.apache.org/jira/browse/QPID-2054
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: M2.1, M3, M4, 0.5, 0.6
>Reporter: Robbie Gemmell
>
> The current default Log4J configuration does not use a rolling file appender. 
> As a result, when the Log4J configuration is reloaded the existing file is 
> cleared as the new configuration takes effect. Thus, if the XML WatchDog is 
> active, or the management console s used to manually reload the Log4J 
> configuration the existing log file contents will be lost.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3590) Python test fails because Java broker does not support null value for routing key

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3590.
--

Resolution: Fixed

Looks good to me.

> Python test fails because Java broker does not support null value for routing 
> key
> -
>
> Key: QPID-3590
> URL: https://issues.apache.org/jira/browse/QPID-3590
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> Python test fails because Java broker does not support null value for routing 
> key
> qpid.tests.messaging.endpoints.SessionTests.testDoubleCommit

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3588) Python message echo test fails against Java broker because only expiration is passed to client, not TTL.

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3588.
--

Resolution: Fixed

Resolving.

> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> 
>
> Key: QPID-3588
> URL: https://issues.apache.org/jira/browse/QPID-3588
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> qpid.tests.messaging.message.MessageEchoTests.testProperties

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3590) Python test fails because Java broker does not support null value for routing key

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-3590:
--

Status: Ready To Review  (was: In Progress)

> Python test fails because Java broker does not support null value for routing 
> key
> -
>
> Key: QPID-3590
> URL: https://issues.apache.org/jira/browse/QPID-3590
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python test fails because Java broker does not support null value for routing 
> key
> qpid.tests.messaging.endpoints.SessionTests.testDoubleCommit

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3590) Python test fails because Java broker does not support null value for routing key

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3590:
-

Assignee: Robbie Gemmell  (was: Rob Godfrey)

Robbie - can you review ...

have updated the test to use a binding-key and removed from the excludes

> Python test fails because Java broker does not support null value for routing 
> key
> -
>
> Key: QPID-3590
> URL: https://issues.apache.org/jira/browse/QPID-3590
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> Python test fails because Java broker does not support null value for routing 
> key
> qpid.tests.messaging.endpoints.SessionTests.testDoubleCommit

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3590) Python test fails because Java broker does not support null value for routing key

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3590:
-

Assignee: Rob Godfrey

> Python test fails because Java broker does not support null value for routing 
> key
> -
>
> Key: QPID-3590
> URL: https://issues.apache.org/jira/browse/QPID-3590
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python test fails because Java broker does not support null value for routing 
> key
> qpid.tests.messaging.endpoints.SessionTests.testDoubleCommit

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-2779) following a failed move attempt, messages then deleted from the queue were observed to return after restart

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-2779.
--

Resolution: Not A Problem

Closing this out, one of the issues affecting the ~0.5 era code have been shown 
to affect later versions. We can raise new JIRAs if they ever are.

> following a failed move attempt, messages then deleted from the queue were 
> observed to return after restart 
> 
>
> Key: QPID-2779
> URL: https://issues.apache.org/jira/browse/QPID-2779
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.5
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>
> following a failed move attempt on a 0.5 broker (see QPID-2778), messages 
> which were not attempted to be moved but were then deleted from the queue 
> using the management console were observed to return after restarting the 
> broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3588) Python message echo test fails against Java broker because only expiration is passed to client, not TTL.

2012-02-20 Thread Rob Godfrey (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212101#comment-13212101
 ] 

Rob Godfrey commented on QPID-3588:
---

Doh - done :-)

> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> 
>
> Key: QPID-3588
> URL: https://issues.apache.org/jira/browse/QPID-3588
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> qpid.tests.messaging.message.MessageEchoTests.testProperties

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3728) some uses of QBTC.isExternalBroker() are incorrect during 'same-VM' testing following broker startup refactoring

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3728.
--

Resolution: Fixed

Removed 1 restriction from DurableSubscriptionTest. All the other restrictions 
are in BrokerLoggingTest, which we need to rework anyway and actually I'm quite 
ok with those sorts of tests only running on the external profiles so they can 
jsut stay the way they are.

> some uses of QBTC.isExternalBroker() are incorrect during 'same-VM' testing 
> following broker startup refactoring
> 
>
> Key: QPID-3728
> URL: https://issues.apache.org/jira/browse/QPID-3728
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Java Tests
>Affects Versions: 0.14
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> Prior to the removal of Mina, same-VM testing of the client and broker used 
> to rely on the Mina InVM transport and the 0-8 protocol. Support for the InVM 
> transport was removed when refactoring the broker to allow testing all 
> protocol versions 'sameVM' while using TCP, after which use of Mina was 
> eventually removed entirely. The previous differences between how the broker 
> was started for InVM and 'standalone' external testing meant some of its 
> behaviour was different and some tests required branches in behaviour to 
> compensate.
> Some tests which use the isExternalBroker() utility method will no longer 
> need to, as almost all of the broker startup is now common between the 
> 'sameVM' and 'external' brokers used in testing and their behaviour is 
> largely indistinguishable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3590) Python test fails because Java broker does not support null value for routing key

2012-02-20 Thread Rob Godfrey (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212094#comment-13212094
 ] 

Rob Godfrey commented on QPID-3590:
---

The binding key is required in ExchangeBind thus the test is wrong.  The test 
should be changed to use a binding/routing-key.

> Python test fails because Java broker does not support null value for routing 
> key
> -
>
> Key: QPID-3590
> URL: https://issues.apache.org/jira/browse/QPID-3590
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Priority: Minor
> Fix For: 0.15
>
>
> Python test fails because Java broker does not support null value for routing 
> key
> qpid.tests.messaging.endpoints.SessionTests.testDoubleCommit

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3588) Python message echo test fails against Java broker because only expiration is passed to client, not TTL.

2012-02-20 Thread Robbie Gemmell (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212085#comment-13212085
 ] 

Robbie Gemmell commented on QPID-3588:
--

Change looks good, should possibly unexclude the test against this JIRA too?

> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> 
>
> Key: QPID-3588
> URL: https://issues.apache.org/jira/browse/QPID-3588
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> qpid.tests.messaging.message.MessageEchoTests.testProperties

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3588) Python message echo test fails against Java broker because only expiration is passed to client, not TTL.

2012-02-20 Thread Robbie Gemmell (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-3588:


Assignee: Rob Godfrey  (was: Robbie Gemmell)

> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> 
>
> Key: QPID-3588
> URL: https://issues.apache.org/jira/browse/QPID-3588
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> qpid.tests.messaging.message.MessageEchoTests.testProperties

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3588) Python message echo test fails against Java broker because only expiration is passed to client, not TTL.

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3588:
-

Assignee: Robbie Gemmell  (was: Rob Godfrey)

Add the TTL to the delivery from broker to consumer if present.  Possibly we 
should be recalculating based on time spent in the broker, though I'm not sure 
that is worth the effort.

Robbie can you review?

> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> 
>
> Key: QPID-3588
> URL: https://issues.apache.org/jira/browse/QPID-3588
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> qpid.tests.messaging.message.MessageEchoTests.testProperties

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3588) Python message echo test fails against Java broker because only expiration is passed to client, not TTL.

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-3588:
--

Status: Ready To Review  (was: In Progress)

> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> 
>
> Key: QPID-3588
> URL: https://issues.apache.org/jira/browse/QPID-3588
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> qpid.tests.messaging.message.MessageEchoTests.testProperties

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: svn commit: r1291436 - in /qpid/trunk/qpid/cpp: include/qpid/framing/ include/qpid/types/ managementgen/qmfgen/ managementgen/qmfgen/templates/ src/qmf/ src/qpid/broker/ src/qpid/ha/

2012-02-20 Thread Ted Ross
The scope of this fix seems to be much greater than that of the commit 
that broke Windows.


A couple of questions:

1) Why add "BrokerImportExport.h" to cpp/src/qmf?  There's already a 
cpp/include/qmf/ImportExport.h that serves the same purpose.
2) Why all the changes to the generated code?  The old generation 
templates worked fine under Windows.


The main thing you need to be concerned with is that any classes and 
class methods that need to be accessible from outside the 
DLL/shared-object are prefixed with the proper EXTERN symbol *for the 
library*.  Furthermore, there's a different EXTERN symbol for inline 
methods.


-Ted


On 02/20/2012 03:45 PM, acon...@apache.org wrote:

Author: aconway
Date: Mon Feb 20 20:45:22 2012
New Revision: 1291436

URL: http://svn.apache.org/viewvc?rev=1291436&view=rev
Log:
NO-JIRA: Fix missing EXTERN declarations, broke windows build.

Added:
 qpid/trunk/qpid/cpp/src/qmf/BrokerImportExport.h   (with props)
Modified:
 qpid/trunk/qpid/cpp/include/qpid/framing/SequenceNumber.h
 qpid/trunk/qpid/cpp/include/qpid/framing/SequenceSet.h
 qpid/trunk/qpid/cpp/include/qpid/types/Variant.h
 qpid/trunk/qpid/cpp/managementgen/qmfgen/schema.py
 qpid/trunk/qpid/cpp/managementgen/qmfgen/templates/Class.h
 qpid/trunk/qpid/cpp/managementgen/qmfgen/templates/Event.h
 qpid/trunk/qpid/cpp/managementgen/qmfgen/templates/Package.h
 qpid/trunk/qpid/cpp/src/qpid/broker/Broker.h
 qpid/trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.h
 qpid/trunk/qpid/cpp/src/qpid/broker/Link.h
 qpid/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp
 qpid/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.h
 qpid/trunk/qpid/cpp/src/qpid/broker/Queue.h
 qpid/trunk/qpid/cpp/src/qpid/broker/SemanticState.h
 qpid/trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.h

[SNIP...]

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:commits-subscr...@qpid.apache.org




-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3588) Python message echo test fails against Java broker because only expiration is passed to client, not TTL.

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3588:
-

Assignee: Rob Godfrey

> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> 
>
> Key: QPID-3588
> URL: https://issues.apache.org/jira/browse/QPID-3588
> Project: Qpid
>  Issue Type: Test
>  Components: Java Broker, Python Test Suite
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> Python message echo test fails against Java broker because only expiration is 
> passed to client, not TTL.
> qpid.tests.messaging.message.MessageEchoTests.testProperties

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Rob Godfrey (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212077#comment-13212077
 ] 

Rob Godfrey commented on QPID-3477:
---

Agree - I'm assuming that the test is not supposed to be a test of invalid 
codes.  We should change the code to 0 "unspecified".

The Broker issue (that we should disconnect because of a protocol error should 
be separately JIRAd

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Priority: Minor
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Robbie Gemmell (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-3477:


Assignee: (was: Robbie Gemmell)

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Priority: Minor
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3477) Java Broker does not handle a rejection/acknowledgemnt with invalid code correctly

2012-02-20 Thread Robbie Gemmell (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212071#comment-13212071
 ] 

Robbie Gemmell commented on QPID-3477:
--

Patch was applied, was just a test excludes file.

Looking at it again I think we either close it as 'wont fix', change the test 
to use legal values (its not clear to me its deliberately using an illegal 
one?) and unexclude it, or make the broker react more forcefully by closing the 
connection (which I assume we werent?).

> Java Broker does not handle a rejection/acknowledgemnt with invalid code 
> correctly
> --
>
> Key: QPID-3477
> URL: https://issues.apache.org/jira/browse/QPID-3477
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.12
>Reporter: Andrew MacBean
>Assignee: Robbie Gemmell
>Priority: Minor
> Attachments: 
> QPID-3477-java-broker-not-handling-reject-code-correctly.txt
>
>
> When running the Python client 0-10 tests against the Java broker it was 
> noticed that the following test would cause test run to hang/time out:
> qpid.tests.messaging.endpoints.SessionTests.testReject
> It appears that this is because the Java broker does not handle the following 
> call correctly:
> self.ssn.acknowledge(echos[2], Disposition(REJECTED, code=3, 
> text="test-reject"))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3825) TransactionTimeoutTest.testProducerOpenCommit and others fails sporadically on slower boxes

2012-02-20 Thread Robbie Gemmell (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-3825:


Assignee: (was: Robbie Gemmell)

> TransactionTimeoutTest.testProducerOpenCommit and others fails sporadically 
> on slower boxes
> ---
>
> Key: QPID-3825
> URL: https://issues.apache.org/jira/browse/QPID-3825
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Tests
>Affects Versions: 0.15
>Reporter: Keith Wall
> Fix For: Future
>
>
> We see a sporadic failure on TransactionTimeoutTest test on some CI boxes:
> {code}
> junit.framework.AssertionFailedError: Exception not thrown
>   at 
> org.apache.qpid.test.unit.transacted.TransactionTimeoutTest.testProducerIdleCommitTwice(TransactionTimeoutTest.java:109)
>   at 
> org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> {code}
> and
> {code}
> org.apache.qpid.test.unit.transacted.TransactionTimeoutTest.testProducerOpenCommit
> Error Message
> Expected 10 but found 13 txn open messages
> Stacktrace
> junit.framework.AssertionFailedError: Expected 10 but found 13 txn open 
> messages
>   at 
> org.apache.qpid.test.unit.transacted.TransactionTimeoutTestCase.monitor(TransactionTimeoutTestCase.java:195)
>   at 
> org.apache.qpid.test.unit.transacted.TransactionTimeoutTest.testProducerOpenCommit(TransactionTimeoutTest.java:179)
>   at 
> org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-464) Fix Broker Exception Handling

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-464.
-

   Resolution: Fixed
Fix Version/s: 0.15

Looks good to me.

> Fix Broker Exception Handling
> -
>
> Key: QPID-464
> URL: https://issues.apache.org/jira/browse/QPID-464
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: M2.1
>Reporter: Rob Godfrey
>Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> Firstly need to define Exception handling policies and apply consistently, 
> then need to look at specific resolution for the two linked JIRAs too.
> The Java broker does not define or implement any form of consistent exception 
> handling.  In particular unrecoverable erros are at best handled by logging 
> and then attempting to carry on regardless.  
> I would argue that such errors should be followed by an immediate System.exit 
> ... however others may wish this to be configurable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-1196) Queue Entries should be in terms of id's not queue -names

2012-02-20 Thread Rob Godfrey (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212053#comment-13212053
 ] 

Rob Godfrey commented on QPID-1196:
---

We should implement this change... not for performance reasons (as the JIRA 
suggests) but because using ids allows for the renaming of queues

> Queue Entries should be in terms of id's not queue -names
> -
>
> Key: QPID-1196
> URL: https://issues.apache.org/jira/browse/QPID-1196
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Broker Derby Store
>Reporter: Martin Ritchie
>Priority: Minor
>
> Summary:
> By using IDs rather than names we can improve the lookup speed of finding the 
> queue.
> This change should be populated down in to the various MessageStores

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-1196) Queue Entries should be in terms of id's not queue -names

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-1196:
-

Assignee: (was: Martin Ritchie)

> Queue Entries should be in terms of id's not queue -names
> -
>
> Key: QPID-1196
> URL: https://issues.apache.org/jira/browse/QPID-1196
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Broker Derby Store
>Reporter: Martin Ritchie
>Priority: Minor
>
> Summary:
> By using IDs rather than names we can improve the lookup speed of finding the 
> queue.
> This change should be populated down in to the various MessageStores

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-464) Fix Broker Exception Handling

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-464:


Assignee: Robbie Gemmell  (was: Rob Godfrey)

Robbie can you review this please

> Fix Broker Exception Handling
> -
>
> Key: QPID-464
> URL: https://issues.apache.org/jira/browse/QPID-464
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: M2.1
>Reporter: Rob Godfrey
>Assignee: Robbie Gemmell
>
> Firstly need to define Exception handling policies and apply consistently, 
> then need to look at specific resolution for the two linked JIRAs too.
> The Java broker does not define or implement any form of consistent exception 
> handling.  In particular unrecoverable erros are at best handled by logging 
> and then attempting to carry on regardless.  
> I would argue that such errors should be followed by an immediate System.exit 
> ... however others may wish this to be configurable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-396) Broker OutOfMemory Error handling

2012-02-20 Thread Rob Godfrey (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey resolved QPID-396.
--

Resolution: Won't Fix

As stated in the comments once you get an OOM exception you really can't do 
anything.  We *should* institute measures so that the broker pro-actively 
monitors the amount of memory it is using and tries to prevent ever getting to 
the point where it can no longer allocate memory

> Broker OutOfMemory Error handling
> -
>
> Key: QPID-396
> URL: https://issues.apache.org/jira/browse/QPID-396
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: M1, M2
>Reporter: Martin Ritchie
>Assignee: Martin Ritchie
>
> When the broker runs out of memory the response to the client can be 
> unpredicatable. 
> If this is something that you believe may occur currently the best thing to 
> do is to ensure that you are not hammering the broker with data. A slight 
> pause between message sending should allow the broker time to throw the 
> OutOfMemory Error during the handling of one of the methods rather than at 
> the mina level when receiving the data. 
> This should allow the broker to write a ConnectionClose frame back to the 
> client. We could signal here that we are out of memory and stop listening for 
> new connectons that will cause further OoM Errors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Review Request: Develop asyncronous store interface for qpid

2012-02-20 Thread Kim van der Riet

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3976/
---

(Updated 2012-02-20 20:18:16.123366)


Review request for qpid, Andrew Stitcher, Alan Conway, Gordon Sim, Ted Ross, 
and Steve Huston.


Changes
---

Fixed some typos in the description


Summary (updated)
---

QPID-3858: Develop asyncronous store interface for qpid ( 
https://issues.apache.org/jira/browse/QPID-3858 )

The current store interface is synchronous, and makes the implementation of an 
asynchronous store awkward.

The attached code (recently checked in on branch asycnstore) is an initial 
design of an async store interface. It is not complete, but gives an idea of 
the direction being contemplated at present.

Still to do on this particular design:
* Find a way to remove boost::intrusive_ptr<> from the interface;
* Complete error handling and find a way to make it extensible to the store 
implementation;
* Find a way to extend the operations to include internal store ops that can be 
defined by the implentation.

Comments welcome!


Diffs
-

  branches/asyncstore/cpp/src/qpid/broker/AsyncStoreErrors.h PRE-CREATION 
  branches/asyncstore/cpp/src/qpid/broker/AsyncStoreToken.h PRE-CREATION 
  branches/asyncstore/cpp/src/qpid/broker/AsyncStore.cpp PRE-CREATION 
  branches/asyncstore/cpp/src/CMakeLists.txt 1291264 
  branches/asyncstore/cpp/src/Makefile.am 1291264 
  branches/asyncstore/cpp/src/qpid/broker/AsyncStore.h PRE-CREATION 

Diff: https://reviews.apache.org/r/3976/diff


Testing
---


Thanks,

Kim



[jira] [Commented] (QPID-3858) Develop asyncronous store interface for qpid

2012-02-20 Thread Kim van der Riet (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212046#comment-13212046
 ] 

Kim van der Riet commented on QPID-3858:


Review Board created for checkin r. 1291285 above at 
https://reviews.apache.org/r/3976/. (This may be getting the cart before the 
horse, so to speak, but it is easier to comment on the code from Review Board, 
and this interface is still in flux...)

> Develop asyncronous store interface for qpid
> 
>
> Key: QPID-3858
> URL: https://issues.apache.org/jira/browse/QPID-3858
> Project: Qpid
>  Issue Type: Task
>Reporter: Kim van der Riet
>
> The current store interface defined in qpid/MessageStore.h is synchronous and 
> does not allow for the call to return while the operation is still in 
> progress. This makes the implementation of an asynchronous store awkward.
> It is proposed that an asynchronous store interface be developed which will 
> allow for a fully asynchronous interaction between the broker and any store 
> which implements the interface.
> This JIRA is intended as a blanket placeholder for the development of this 
> interface. Ideas, comments and criticism of the work in progress may be 
> placed here or in ReviewBoard tasks linked to this JIRA.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Review Request: Develop asyncronous store interface for qpid

2012-02-20 Thread Kim van der Riet

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3976/
---

Review request for qpid, Andrew Stitcher, Alan Conway, Gordon Sim, Ted Ross, 
and Steve Huston.


Summary
---

QPID-3858: Develop asyncronous store interface for qpid 
(https://issues.apache.org/jira/browse/QPID-3858)

The current store interface is synchronous, and makes the implementation of an 
asynchronos store awkward.

The attached code (recently checked in on branch asycnstore) is an initial 
design of an async store interface. It is not complete, but gives an idea of 
the direction being contemplated at present.

Still to do on this particular design:
* Find a way to remove boost::intrusive_ptr<> from the interface;
* Complete error handling and find a way to make it extensible to the store 
implementation;
* Find a way to extend the operations to include internal store ops that can be 
defined by the implentation.

Comments welcome!


Diffs
-

  branches/asyncstore/cpp/src/qpid/broker/AsyncStoreErrors.h PRE-CREATION 
  branches/asyncstore/cpp/src/qpid/broker/AsyncStoreToken.h PRE-CREATION 
  branches/asyncstore/cpp/src/qpid/broker/AsyncStore.cpp PRE-CREATION 
  branches/asyncstore/cpp/src/CMakeLists.txt 1291264 
  branches/asyncstore/cpp/src/Makefile.am 1291264 
  branches/asyncstore/cpp/src/qpid/broker/AsyncStore.h PRE-CREATION 

Diff: https://reviews.apache.org/r/3976/diff


Testing
---


Thanks,

Kim



[jira] [Resolved] (QPID-3095) AMQBrokerDetails equals() and hashCode() methods do not adhere to contract

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3095.
--

Resolution: Fixed

Looks ok to me.

> AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
> --
>
> Key: QPID-3095
> URL: https://issues.apache.org/jira/browse/QPID-3095
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.9
>Reporter: Andrew Kennedy
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> The AMQBrokerDetails object has an equals and a hashCode implementation that 
> are not compatible. Equality uses case-insensitive comparisons and also 
> compares SSL status, whereas the hashCode is calculated using the provided 
> values and does not include SSL details. The contract for hashCode is given 
> here:
> http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Non-blocking I/O packaging...

2012-02-20 Thread Darryl L. Pierce
On Thu, Feb 09, 2012 at 01:38:39PM -0500, Darryl L. Pierce wrote:
> Based on feedback, I've successfully moved the non-blocking I/O
> extensions to Qpid out of the public APIs. The APIs now live in a shared
> library named libqpidnonblockio and are build below the bindings
> directory.
> 
> The question I have now is how ought we distribute this library? The
> library is only required for a languages whose runtime has a GIL.

Anybody have an opinion on this? The library itself isn't going to be a
part of the public APIs but still needs to be delivered for the Ruby
language bindings.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgprJ8jXCg3ZW.pgp
Description: PGP signature


[jira] [Created] (QPID-3860) Python client enters busy loop on heartbeat timeout

2012-02-20 Thread Radu Dan (Created) (JIRA)
Python client enters busy loop on heartbeat timeout
---

 Key: QPID-3860
 URL: https://issues.apache.org/jira/browse/QPID-3860
 Project: Qpid
  Issue Type: Bug
  Components: Python Client
Affects Versions: 0.14
 Environment: Client: Linux radudan.activesoft.ro 3.2.3-2.fc16.x86_64 
#1 SMP Fri Feb 3 20:08:08 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
Server: Linux ophelia.activesoft.ro 2.6.32-220.2.1.el6.x86_64 #1 SMP Fri Dec 23 
02:21:33 CST 2011 x86_64 x86_64 x86_64 GNU/Linux

Reporter: Radu Dan
Priority: Critical


Let's asume the following code, that's linked against and connected to qpid 
0.14:

#!/bin/env python
import sys, time, logging
from qpid.messaging import *
logging.basicConfig(level=logging.INFO)

connection = Connection(
host="ophelia.activesoft.ro",
port=5672,
heartbeat=1,
reconnect=True,
reconnect_interval_min=1,
reconnect_interval_max=1,
reconnect_limit=5,
reconnect_timeout=5
)

connection.open()
session = connection.session()
sender = session.sender("test; {create: always}")

id = 0
while True:
try:
sender.send({
"hello": "world"
})
logging.info("Sent %d" % id)
id += 1
except KeyboardInterrupt:
break
except:
logging.info("Error")
finally:
time.sleep(1)

The script will try to publish a message on the "test" queue to a broker, using 
a heartbeat value of 1s, and will reconnect at most 5 times with a timeout of 
1s before giving up and reporting the message as failed. This works as expected 
when gracefully shutting the broker down (service qpidd stop):

<>
INFO:root:Sent 0
INFO:root:Sent 1
INFO:root:Sent 2
INFO:root:Sent 3
INFO:root:Sent 4
<>
WARNING:qpid.messaging:recoverable error[attempt 0]: connection aborted
WARNING:qpid.messaging:trying: ophelia.activesoft.ro:5672
<>
WARNING:qpid.messaging:reconnect succeeded: ophelia.activesoft.ro:5672
WARNING:qpid.messaging:recoverable error[attempt 0]: [Errno 104] Connection 
reset by peer
WARNING:qpid.messaging:trying: ophelia.activesoft.ro:5672
WARNING:qpid.messaging:recoverable error[attempt 1]: [Errno 111] Connection 
refused
WARNING:qpid.messaging:sleeping 1 seconds
WARNING:qpid.messaging:trying: ophelia.activesoft.ro:5672
WARNING:qpid.messaging:recoverable error[attempt 2]: [Errno 111] Connection 
refused
WARNING:qpid.messaging:sleeping 1 seconds
WARNING:qpid.messaging:trying: ophelia.activesoft.ro:5672
WARNING:qpid.messaging:recoverable error[attempt 3]: [Errno 111] Connection 
refused
WARNING:qpid.messaging:sleeping 1 seconds
WARNING:qpid.messaging:trying: ophelia.activesoft.ro:5672
WARNING:qpid.messaging:recoverable error[attempt 4]: [Errno 111] Connection 
refused
WARNING:qpid.messaging:sleeping 1 seconds
WARNING:qpid.messaging:trying: ophelia.activesoft.ro:5672
WARNING:qpid.messaging:recoverable error[attempt 5]: [Errno 111] Connection 
refused
WARNING:qpid.messaging:sleeping 1 seconds
WARNING:qpid.messaging:trying: ophelia.activesoft.ro:5672
<>
INFO:root:Error
INFO:root:Error
INFO:root:Error
<>
INFO:root:Error
INFO:root:Error

I don't know how exactly it gets a reconnect succeeded right after the daemon 
is killed, but it seems to reconnect 5 times, afterwards it will fail with some 
exception. However, it makes no more attempts to establish a connection when 
this state is reached. Now I'm not entirely sure about the philosophy behind 
the API, but wouldn't it be more useful to try and reconnect if down whenever a 
new message is sent? Right now the default behaviour is to block until the 
connection is back up; Tweaking the reconnect parameters will yield a call that 
throws an exception after a while, but that invalidates the entire 
connection>session>sender chain

This behaviour can be duplicated by kill -9, because the kernel will shutdown 
and close the TCP sockets associated with any killed processes. However, an 
even greater problem arises when disconnecting the interface (I just pulled the 
ether cable out of my test box, but service network stop should probably do the 
same thing). This way, the socket never really closes because it's waiting for 
the other end to shutdown(), which may never come because the other end might 
have already given up on the connection (via a hard reset for example). Since 
most linux TCP stacks are EXTREMELY patient with regards to socket timeouts, 
it's up to the heartbeat mechanism to detect a connection failure and switch to 
the same state as a shutdown/close would.

However, what happens is something like this:

INFO:root:Sent 0
INFO:root:Sent 1
INFO:root:Sent 2
INFO:root:Sent 3
INFO:root:Sent 4
WARNING:qpid.messaging:recoverable error[attempt 0]: heartbeat timeout

At this point, the python process enters a busy loop of so

RE: C++: Windows EXTERN question

2012-02-20 Thread Steve Huston
You should not have to do this. Something is wrong with the CLASS version of 
the macro. Let me know if you get stuck.
-Steve

> -Original Message-
> From: Alan Conway [mailto:acon...@redhat.com]
> Sent: Monday, February 20, 2012 10:25 AM
> To: dev@qpid.apache.org
> Cc: Steve Huston
> Subject: Re: C++: Windows EXTERN question
>
> On Mon, 2012-02-20 at 10:07 -0500, Alan Conway wrote:
> > Question: in SequenceNumber.h we have:
> >
> > class QPID_COMMON_CLASS_EXTERN SequenceNumber : public ...
> > {
> >   ...
> > int32_t value;
> >
> > void decode(Buffer& buffer);
> >   ...
> > };
> >
> > But I'm getting
> >
> > 76>QueueReplicator.obj : error LNK2019: unresolved external symbol
> > "public: void __thiscall qpid::framing::SequenceNumber::decode(class
> > qpid::framing::Buffer
> > &)"
> (?decode@SequenceNumber@framing@qpid@@QAEXAAVBuffer@23@@Z
> )
> > referenced in function "class qpid::framing::SequenceNumber __cdecl
> > qpid::ha::`anonymous namespace'::decodeContent > qpid::framing::SequenceNumber>(class qpid::broker::Message &)"
> >
> (??$decodeContent@VSequenceNumber@framing@qpid@@@?A0x57ef80
> a8@ha@qpid@
> > @YA?AVSequenceNumber@framing@2@AAVMessage@broker@2@@Z)
> >
> > Does windows require individual EXTERN declarations on member
> > functions even if there's a CLASS_EXTERN on the class? Or is there
> > something else I'm missing?
> >
>
> I noticed that SequenceSet.h has both class and method EXTERNs so I
> followed that example in SequenceNumber.h
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3095) AMQBrokerDetails equals() and hashCode() methods do not adhere to contract

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-3095:
--

Fix Version/s: 0.15
 Assignee: Rob Godfrey

> AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
> --
>
> Key: QPID-3095
> URL: https://issues.apache.org/jira/browse/QPID-3095
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.9
>Reporter: Andrew Kennedy
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> The AMQBrokerDetails object has an equals and a hashCode implementation that 
> are not compatible. Equality uses case-insensitive comparisons and also 
> compares SSL status, whereas the hashCode is calculated using the provided 
> values and does not include SSL details. The contract for hashCode is given 
> here:
> http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3095) AMQBrokerDetails equals() and hashCode() methods do not adhere to contract

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-3095:
--

Status: Ready To Review  (was: In Progress)

> AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
> --
>
> Key: QPID-3095
> URL: https://issues.apache.org/jira/browse/QPID-3095
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.9
>Reporter: Andrew Kennedy
>Assignee: Rob Godfrey
>Priority: Minor
> Fix For: 0.15
>
>
> The AMQBrokerDetails object has an equals and a hashCode implementation that 
> are not compatible. Equality uses case-insensitive comparisons and also 
> compares SSL status, whereas the hashCode is calculated using the provided 
> values and does not include SSL details. The contract for hashCode is given 
> here:
> http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3095) AMQBrokerDetails equals() and hashCode() methods do not adhere to contract

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-3095:
-

Assignee: Robbie Gemmell  (was: Rob Godfrey)

Can you review this trivial change please Robbie?

> AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
> --
>
> Key: QPID-3095
> URL: https://issues.apache.org/jira/browse/QPID-3095
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.9
>Reporter: Andrew Kennedy
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> The AMQBrokerDetails object has an equals and a hashCode implementation that 
> are not compatible. Equality uses case-insensitive comparisons and also 
> compares SSL status, whereas the hashCode is calculated using the provided 
> values and does not include SSL details. The contract for hashCode is given 
> here:
> http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3857) Test ConnectionTest#testClientIDVerificationForSameUser fails occasionally

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3857.
--

Resolution: Fixed

I have applied the patch, then gone a little further and removed the 
now-redundant impl method it updated.

> Test ConnectionTest#testClientIDVerificationForSameUser fails occasionally
> --
>
> Key: QPID-3857
> URL: https://issues.apache.org/jira/browse/QPID-3857
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Tests
>Affects Versions: 0.14
>Reporter: Alex Rudyy
>Assignee: Robbie Gemmell
> Fix For: 0.15
>
> Attachments: 
> 0001-QPID-3857-Fix-racing-conditions-on-registering-sessi.patch
>
>
> Test ConnectionTest#testClientIDVerificationForSameUser fails occasionally 
> with the following error:
> The client should throw a ConnectionException stating the client ID is not 
> unique
> Stacktrace
> junit.framework.AssertionFailedError: The client should throw a 
> ConnectionException stating the client ID is not unique
>   at 
> org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerificationForSameUser(ConnectionTest.java:315)
>   at 
> org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> Test failed on profile java-mms-spawn.0-10 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3857) Test ConnectionTest#testClientIDVerificationForSameUser fails occasionally

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-3857:
-

Affects Version/s: (was: 0.15)
   0.14

> Test ConnectionTest#testClientIDVerificationForSameUser fails occasionally
> --
>
> Key: QPID-3857
> URL: https://issues.apache.org/jira/browse/QPID-3857
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Tests
>Affects Versions: 0.14
>Reporter: Alex Rudyy
>Assignee: Robbie Gemmell
> Fix For: 0.15
>
> Attachments: 
> 0001-QPID-3857-Fix-racing-conditions-on-registering-sessi.patch
>
>
> Test ConnectionTest#testClientIDVerificationForSameUser fails occasionally 
> with the following error:
> The client should throw a ConnectionException stating the client ID is not 
> unique
> Stacktrace
> junit.framework.AssertionFailedError: The client should throw a 
> ConnectionException stating the client ID is not unique
>   at 
> org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerificationForSameUser(ConnectionTest.java:315)
>   at 
> org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> Test failed on profile java-mms-spawn.0-10 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-1505) PlainSaslServer throws and immediately catches and wraps Sasl Exception

2012-02-20 Thread Robbie Gemmell (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-1505:
-

Affects Version/s: 0.14

> PlainSaslServer throws and immediately catches and wraps Sasl Exception
> ---
>
> Key: QPID-1505
> URL: https://issues.apache.org/jira/browse/QPID-1505
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Starter
>Affects Versions: M3, M4, 0.14
>Reporter: Martin Ritchie
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> Summary:
> in evaluateResponse Line 94 throws a SaslException saying Authentication 
> Failed but this is then immediately caught on line 97 as SaslException 
> extends IOException. Where by the SaslException is Wrapped in a new 
> SaslException and thrown.
> We probably don't want to do this, something simple like moving the 
> ifelse... out of the try...catch would suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-1505) PlainSaslServer throws and immediately catches and wraps Sasl Exception

2012-02-20 Thread Robbie Gemmell (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-1505.
--

   Resolution: Fixed
Fix Version/s: 0.15

Looks good to me.

> PlainSaslServer throws and immediately catches and wraps Sasl Exception
> ---
>
> Key: QPID-1505
> URL: https://issues.apache.org/jira/browse/QPID-1505
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Starter
>Affects Versions: M3, M4
>Reporter: Martin Ritchie
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 0.15
>
>
> Summary:
> in evaluateResponse Line 94 throws a SaslException saying Authentication 
> Failed but this is then immediately caught on line 97 as SaslException 
> extends IOException. Where by the SaslException is Wrapped in a new 
> SaslException and thrown.
> We probably don't want to do this, something simple like moving the 
> ifelse... out of the try...catch would suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-1505) PlainSaslServer throws and immediately catches and wraps Sasl Exception

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-1505:
-

Assignee: Robbie Gemmell  (was: Rob Godfrey)

Robbie - can you review this trivial change for me?

> PlainSaslServer throws and immediately catches and wraps Sasl Exception
> ---
>
> Key: QPID-1505
> URL: https://issues.apache.org/jira/browse/QPID-1505
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Starter
>Affects Versions: M3, M4
>Reporter: Martin Ritchie
>Assignee: Robbie Gemmell
>Priority: Minor
>
> Summary:
> in evaluateResponse Line 94 throws a SaslException saying Authentication 
> Failed but this is then immediately caught on line 97 as SaslException 
> extends IOException. Where by the SaslException is Wrapped in a new 
> SaslException and thrown.
> We probably don't want to do this, something simple like moving the 
> ifelse... out of the try...catch would suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-1505) PlainSaslServer throws and immediately catches and wraps Sasl Exception

2012-02-20 Thread Rob Godfrey (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-1505:
--

Status: Ready To Review  (was: In Progress)

> PlainSaslServer throws and immediately catches and wraps Sasl Exception
> ---
>
> Key: QPID-1505
> URL: https://issues.apache.org/jira/browse/QPID-1505
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Starter
>Affects Versions: M3, M4
>Reporter: Martin Ritchie
>Assignee: Rob Godfrey
>Priority: Minor
>
> Summary:
> in evaluateResponse Line 94 throws a SaslException saying Authentication 
> Failed but this is then immediately caught on line 97 as SaslException 
> extends IOException. Where by the SaslException is Wrapped in a new 
> SaslException and thrown.
> We probably don't want to do this, something simple like moving the 
> ifelse... out of the try...catch would suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Created] (QPID-3859) Provide non-blocking I/O functionality to the Ruby APIs

2012-02-20 Thread Darryl L. Pierce (Created) (JIRA)
Provide non-blocking I/O functionality to the Ruby APIs
---

 Key: QPID-3859
 URL: https://issues.apache.org/jira/browse/QPID-3859
 Project: Qpid
  Issue Type: Improvement
  Components: Ruby Client
Reporter: Darryl L. Pierce
Priority: Critical


Provide functionality that overcomes the limitation of the Ruby global 
interpreter. Prevent the Ruby VM from become become unresponsive when a 
blocking I/O call is made so that other Ruby threads can continue to execute 
while the I/O continues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3859) Provide non-blocking I/O functionality to the Ruby APIs

2012-02-20 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211937#comment-13211937
 ] 

jirapos...@reviews.apache.org commented on QPID-3859:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2828/
---

(Updated 2012-02-20 15:53:08.198316)


Review request for Andrew Stitcher, Alan Conway, Gordon Sim, Kenneth Giusti, 
and Rafael Schloming.


Summary
---

This first pass has full integration of the Tracker type with the Ruby bindings 
to provide a non-blocking means for responding to incoming messages.

After a Receiver is created, a call to Qpid::Messaging.receive will wait for 
the next message to become available on it. When one is received, a provided 
lambda function is invoked and the receiver passed to it. The message can then 
be retrieved, acknowledged, etc.


This addresses bug QPID-3859.
https://issues.apache.org/jira/browse/QPID-3859


Diffs
-

  trunk/qpid/cpp/bindings/qpid/CMakeLists.txt 1243858 
  trunk/qpid/cpp/bindings/qpid/nonblockio/CMakeLists.txt PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/Prong.h PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/Prong.cpp PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/TrackerAdaptor.h 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/TrackerAdaptor.cpp 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/TrackerAdaptorImpl.h 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/TrackerAdaptorImpl.cpp 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/TrackerEventHandler.h 
PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/TrackerEventHandler.cpp 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/Acknowledge.h 
PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/Acknowledge.cpp 
PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/AcknowledgeImpl.h
 PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/AcknowledgeImpl.cpp
 PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/BaseThreadedEventHandler.h
 PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/BaseThreadedEventHandler.cpp
 PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/BaseTrackerEventHandler.h
 PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/BaseTrackerEventHandler.cpp
 PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/NextReceiver.h 
PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/NextReceiver.cpp 
PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/NextReceiverImpl.h
 PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/NextReceiverImpl.cpp
 PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/Receive.h 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/Receive.cpp 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/ReceiveImpl.h 
PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/ReceiveImpl.cpp 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/Send.h 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/Send.cpp 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/SendImpl.h 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/SendImpl.cpp 
PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/SessionSync.h 
PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/SessionSync.cpp 
PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/SessionSyncImpl.h
 PRE-CREATION 
  
trunk/qpid/cpp/bindings/qpid/nonblockio/qpid/messaging/synchio/SessionSyncImpl.cpp
 PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/qpid.i 1243858 
  trunk/qpid/cpp/bindings/qpid/ruby/CMakeLists.txt 1243858 
  trunk/qpid/cpp/bindings/qpid/ruby/README.rdoc 1243858 
  trunk/qpid/cpp/bindings/qpid/ruby/Rakefile 1243858 
  trunk/qpid/cpp/bindings/qpid/ruby/examples/drain.rb 1243858 
  trunk/qpid/cpp/bindings/qpid/ruby/examples/map_receiver.rb 1243858 
  trunk/qpid/cpp/bindings/qpid/ruby/examples/spout.rb 1243858 
  trunk/qpid/cpp/bindings/qpid/ruby/ext/nonblockio/extconf.rb PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/ruby/ext/nonblockio/nonblockio.h PRE-CREATION 
  trunk/qpid/cpp/bindings/qpid/ruby/ext/nonblockio/nonblockio.c P

[jira] [Assigned] (QPID-1505) PlainSaslServer throws and immediately catches and wraps Sasl Exception

2012-02-20 Thread Rob Godfrey (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-1505:
-

Assignee: Rob Godfrey

> PlainSaslServer throws and immediately catches and wraps Sasl Exception
> ---
>
> Key: QPID-1505
> URL: https://issues.apache.org/jira/browse/QPID-1505
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Starter
>Affects Versions: M3, M4
>Reporter: Martin Ritchie
>Assignee: Rob Godfrey
>Priority: Minor
>
> Summary:
> in evaluateResponse Line 94 throws a SaslException saying Authentication 
> Failed but this is then immediately caught on line 97 as SaslException 
> extends IOException. Where by the SaslException is Wrapped in a new 
> SaslException and thrown.
> We probably don't want to do this, something simple like moving the 
> ifelse... out of the try...catch would suffice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



RE: Windows EXTERN question

2012-02-20 Thread Steve Huston
Hi Alan,

> Question: in SequenceNumber.h we have:
>
> class QPID_COMMON_CLASS_EXTERN SequenceNumber : public ...
> {
>   ...
> int32_t value;
>
> void decode(Buffer& buffer);
>   ...
> };
>
> But I'm getting
>
> 76>QueueReplicator.obj : error LNK2019: unresolved external symbol
> "public: void __thiscall qpid::framing::SequenceNumber::decode(class
> qpid::framing::Buffer
> &)"
> (?decode@SequenceNumber@framing@qpid@@QAEXAAVBuffer@23@@Z
> )
> referenced in function "class qpid::framing::SequenceNumber __cdecl
> qpid::ha::`anonymous namespace'::decodeContent qpid::framing::SequenceNumber>(class qpid::broker::Message &)"
> (??$decodeContent@VSequenceNumber@framing@qpid@@@?A0x57ef80
> a8@ha@qpid@@YA?AVSequenceNumber@framing@2@AAVMessage@bro
> ker@2@@Z)
>
> Does windows require individual EXTERN declarations on member functions
> even if there's a CLASS_EXTERN on the class? Or is there something else 
> I'm
> missing?

No, there's no need for member function EXTERNs if the CLASS_EXTERN is there 
and the right macros are set to turn the CLASS_EXTERN on. From the error, 
I'm guessing that either QPID_COMMON_CLASS_EXTERN is not defined correctly, 
or the macro to turn it on is not set up correctly.

-Steve


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: C++: Introducing EXTERN macros to generated QMF headers

2012-02-20 Thread Alan Conway
On Mon, 2012-02-20 at 10:15 -0500, Ken Giusti wrote:
> My $0.02: I'd have the QMF generator add the EXTERNs, so others won't hit 
> this problem again.  At least, it should be an option to the generator
> 
Thanks, I'll do that.

> 
> - Original Message -
> > I'm fixing my breakage of windows builds due to missing decl-specs.
> > One
> > area where this is a problem is with generated QMF code: I have code
> > in
> > the HA plugin trying to call management objects in the broker
> > library.
> > 
> > I see a couple of options
> > 
> > 1. Have the QMF generator generate EXTERN declarations.
> > 2. Move the HA QMF code to the HA plugin.
> > 3. both
> > 
> > Any thoughts on what is the right approach for plugins that introduce
> > management objects?
> > 
> > Thanks,
> > Alan.
> > 
> > 
> > -
> > Apache Qpid - AMQP Messaging Implementation
> > Project:  http://qpid.apache.org
> > Use/Interact: mailto:dev-subscr...@qpid.apache.org
> > 
> > 
> 
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
> 



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: C++: Windows EXTERN question

2012-02-20 Thread Alan Conway
On Mon, 2012-02-20 at 10:07 -0500, Alan Conway wrote:
> Question: in SequenceNumber.h we have:
> 
> class QPID_COMMON_CLASS_EXTERN SequenceNumber : public ...
> {
>   ...
> int32_t value;
> 
> void decode(Buffer& buffer);
>   ...
> };
> 
> But I'm getting 
> 
> 76>QueueReplicator.obj : error LNK2019: unresolved external symbol
> "public: void __thiscall qpid::framing::SequenceNumber::decode(class
> qpid::framing::Buffer
> &)" (?decode@SequenceNumber@framing@qpid@@QAEXAAVBuffer@23@@Z)
> referenced in function "class qpid::framing::SequenceNumber __cdecl
> qpid::ha::`anonymous namespace'::decodeContent qpid::framing::SequenceNumber>(class qpid::broker::Message
> &)" 
> (??$decodeContent@VSequenceNumber@framing@qpid@@@?A0x57ef80a8@ha@qpid@@YA?AVSequenceNumber@framing@2@AAVMessage@broker@2@@Z)
> 
> Does windows require individual EXTERN declarations on member functions
> even if there's a CLASS_EXTERN on the class? Or is there something else
> I'm missing?
> 

I noticed that SequenceSet.h has both class and method EXTERNs so I
followed that example in SequenceNumber.h


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



  1   2   >