Review Request: Fix for QPID-3575

2012-07-05 Thread rajith attapattu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5794/
---

Review request for qpid, Robbie Gemmell, Keith Wall, and Rob Godfrey.


Description
---

When a session exception is received, we notify the connection via the 
exceptionReceived method. The connection will close all sessions for this 
connection, but does not close the underlying Protocol connection.
Further calls (from application code) to close the connection, does not close 
the underlying protocol-connection as it skips this part, due to the connection 
already being marked as closed.
This results in leaked connections.

The proposed patch does the following.
1. When a session exception is received, it closes the Session (and the 
consumers/producers associated with it) to prevent further use of this session.
2. It also notifies the connection, however the exception being passed, is 
marked as a soft error, thereby preventing the connection from being marked as 
closed.
   It also prevents the rest of the sessions being closed.
3. The exception will however be notified via the exception listener. This is 
important in certain cases, as it might be the only case where an exception can 
be notified.

What is the impact to applications.

1. If an application closes the connection when it receives an exception, and 
then recreates the connection and it's associated objects 
(sessions/consumers/producers) then this change will have no impact.

2. If an application just recreates everything from scratch, without resorting 
to closing the connection (assuming that all exceptions received via the 
listener will automatically close the connection), there will be tcp connection 
leaks. 
However the objects associated with the connection will eventualy be garbage 
collected. We should probably close the underlying TCP connection in the 
finalizer for the Connection object as a safety measure.

With this change, the recommended approach would be, for application to check 
the connection status in deciding what it should do.
For example, 

if (conn.isClosed())
{
   // re-create connection.
}
else
{
  // session exception
  // this means the rest of the sessions and the connection is still open.
}


This addresses bug QPID-3575.
https://issues.apache.org/jira/browse/QPID-3575


Diffs
-

  
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
 1357981 
  
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java
 1357981 
  
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/AMQException.java
 1357981 

Diff: https://reviews.apache.org/r/5794/diff/


Testing
---

Tested with the default java profile and the cpp test profile.

SelectorTest#testRuntimeSelectorError is failing as it expects the connection 
to be closed.
I need to investigate further to determine if the test needs to be changed or 
not.


Thanks,

rajith attapattu

[jira] [Closed] (QPID-4108) HA does not replicate user - missing user property in management-schema

2012-07-05 Thread Alan Conway (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway closed QPID-4108.
-

Resolution: Invalid

The bug as stated does not make sense. Will open a new bug for HA with 
authentication

> HA does not replicate user - missing user property in management-schema
> ---
>
> Key: QPID-4108
> URL: https://issues.apache.org/jira/browse/QPID-4108
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Clustering
>Affects Versions: 0.17
>Reporter: Alan Conway
>Assignee: Alan Conway
>
> The management-schema does not have a "user" property for Queue and Exchange 
> objects. As a result, a HA primary cannot replicate this value to a backup. 
> Note the user argument is present in queue and exchange declare events. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: [Proton] ERROR amqp:connection:framing-error connection aborted

2012-07-05 Thread Rafael Schloming 
According to the log output you posted, the body of the loop is never
running. Can you log the value that pn_connection_state is returning and
verify that the test is working as expected? I don't recall offhand how
exactly bitwise operators work in Ruby.

--Rafael

On Thu, 2012-07-05 at 16:20 -0400, Darryl L. Pierce wrote:
> On Tue, Jul 03, 2012 at 05:13:17PM -0400, Rafael Schloming wrote:
> > Can you post the ruby code you're using? I took a look at the original
> > python example you're transcoding and based on the trace it's likely
> > something is messed up around this part:
> > 
> > # we're done, close and wait for the remote to close also
> > pn_connection_close(sender.conn)
> > while not (pn_connection_state(sender.conn) & PN_REMOTE_CLOSED):
> > sender.wait()
> 
> Sure, you can see all that I've done so far up in my Github repo:
> 
> https://github.com/mcpierce/proton/tree/Ruby-bindings
> 
> What I did in the Ruby was to line-by-line copy the above with:
> 
>   puts "Closing the connection."
>   Cproton::pn_connection_close sender.conn
>   while !(Cproton::pn_connection_state(sender.conn) & 
> Cproton::PN_REMOTE_CLOSED)
> log "Waiting for things to become closed..."
> sender.wait
>   end
> 



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4101) Fixes building the Ruby language bindings for Ruby 1.9

2012-07-05 Thread Andrew Stitcher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Stitcher resolved QPID-4101.
---

   Resolution: Fixed
Fix Version/s: 0.17

Fixed in r1357945

> Fixes building the Ruby language bindings for Ruby 1.9
> --
>
> Key: QPID-4101
> URL: https://issues.apache.org/jira/browse/QPID-4101
> Project: Qpid
>  Issue Type: Bug
>  Components: Ruby Client
>Affects Versions: 0.17
>Reporter: Darryl L. Pierce
>Assignee: Andrew Stitcher
> Fix For: 0.17
>
> Attachments: 
> 0001-Fixes-the-Cmake-build-process-for-the-Ruby-language-.patch
>
>
> Building the Ruby language bindings for Ruby 1.9 fail since the build 
> environment cannot find ruby/config.h

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4101) Fixes building the Ruby language bindings for Ruby 1.9

2012-07-05 Thread Darryl L. Pierce (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl L. Pierce updated QPID-4101:
---

Attachment: 0001-Fixes-the-Cmake-build-process-for-the-Ruby-language-.patch

> Fixes building the Ruby language bindings for Ruby 1.9
> --
>
> Key: QPID-4101
> URL: https://issues.apache.org/jira/browse/QPID-4101
> Project: Qpid
>  Issue Type: Bug
>  Components: Ruby Client
>Affects Versions: 0.17
>Reporter: Darryl L. Pierce
>Assignee: Andrew Stitcher
> Attachments: 
> 0001-Fixes-the-Cmake-build-process-for-the-Ruby-language-.patch
>
>
> Building the Ruby language bindings for Ruby 1.9 fail since the build 
> environment cannot find ruby/config.h

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4101) Fixes building the Ruby language bindings for Ruby 1.9

2012-07-05 Thread Darryl L. Pierce (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl L. Pierce updated QPID-4101:
---

Attachment: (was: 
0001-Fixes-the-Cmake-build-process-for-the-Ruby-language-.patch)

> Fixes building the Ruby language bindings for Ruby 1.9
> --
>
> Key: QPID-4101
> URL: https://issues.apache.org/jira/browse/QPID-4101
> Project: Qpid
>  Issue Type: Bug
>  Components: Ruby Client
>Affects Versions: 0.17
>Reporter: Darryl L. Pierce
>Assignee: Andrew Stitcher
> Attachments: 
> 0001-Fixes-the-Cmake-build-process-for-the-Ruby-language-.patch
>
>
> Building the Ruby language bindings for Ruby 1.9 fail since the build 
> environment cannot find ruby/config.h

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (QPID-4101) Fixes building the Ruby language bindings for Ruby 1.9

2012-07-05 Thread Andrew Stitcher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Stitcher reassigned QPID-4101:
-

Assignee: Andrew Stitcher

> Fixes building the Ruby language bindings for Ruby 1.9
> --
>
> Key: QPID-4101
> URL: https://issues.apache.org/jira/browse/QPID-4101
> Project: Qpid
>  Issue Type: Bug
>  Components: Ruby Client
>Affects Versions: 0.17
>Reporter: Darryl L. Pierce
>Assignee: Andrew Stitcher
> Attachments: 
> 0001-Fixes-the-Cmake-build-process-for-the-Ruby-language-.patch
>
>
> Building the Ruby language bindings for Ruby 1.9 fail since the build 
> environment cannot find ruby/config.h

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-2567) [c++] Timer - possible thread lock ordering violation

2012-07-05 Thread Andrew Stitcher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Stitcher resolved QPID-2567.
---

   Resolution: Fixed
Fix Version/s: 0.17

Probably fixed by r1357827

> [c++] Timer - possible thread lock ordering violation
> -
>
> Key: QPID-2567
> URL: https://issues.apache.org/jira/browse/QPID-2567
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.7
> Environment: RHEL-6 beta
>Reporter: Kim van der Riet
>Assignee: Andrew Stitcher
> Fix For: 0.17
>
>
> Starting the broker using valgrind and the helgrind thread check tool shows 
> several lock order violations centered around the qpid::sys::Timer class.
> valgrind --tool=helgrind .libs/lt-qpidd --auth no --log-enable info+
> results in the following message (and others that are similar):
> ==31280== Thread #2: lock order "0x597D548 before 0x59AE350" violated
> ==31280==at 0x4A0679C: pthread_mutex_lock (hg_intercepts.c:464)
> ==31280==by 0x4E8C27B: qpid::sys::Mutex::lock() (Mutex.h:116)
> ==31280==by 0x4E8CD82: 
> qpid::sys::ScopedLock::ScopedLock(qpid::sys::Mutex&) 
> (Mutex.h:33)
> ==31280==by 0x56346FF: 
> qpid::sys::Timer::add(boost::intrusive_ptr) 
> (Timer.cpp:162)
> ==31280==by 0x4EFDCD0: qpid::broker::LinkRegistry::Periodic::fire() 
> (LinkRegistry.cpp:73)
> ==31280==by 0x563344C: qpid::sys::TimerTask::fireTask() (Timer.cpp:57)
> ==31280==by 0x5634917: 
> qpid::sys::Timer::fire(boost::intrusive_ptr) 
> (Timer.cpp:190)
> ==31280==by 0x5633E84: qpid::sys::Timer::run() (Timer.cpp:119)
> ==31280==by 0x5525BEE: qpid::sys::(anonymous 
> namespace)::runRunnable(void*) (Thread.cpp:35)
> ==31280==by 0x4A0A1A5: mythread_wrapper (hg_intercepts.c:201)
> ==31280==by 0x31D6C07950: start_thread (pthread_create.c:301)
> ==31280==by 0x31D68E4D3C: clone (clone.S:115)
> ==31280==   Required order was established by acquisition of lock at 0x597D548
> ==31280==at 0x4A095F6: pthread_cond_wait_WRK (hg_intercepts.c:653)
> ==31280==by 0x4A096B8: pthread_cond_wait@* (hg_intercepts.c:675)
> ==31280==by 0x4EF587A: qpid::sys::Condition::wait(qpid::sys::Mutex&) 
> (Condition.h:63)
> ==31280==by 0x4EF5932: qpid::sys::Monitor::wait() (Monitor.h:41)
> ==31280==by 0x5633AA6: qpid::sys::Timer::run() (Timer.cpp:98)
> ==31280==by 0x5525BEE: qpid::sys::(anonymous 
> namespace)::runRunnable(void*) (Thread.cpp:35)
> ==31280==by 0x4A0A1A5: mythread_wrapper (hg_intercepts.c:201)
> ==31280==by 0x31D6C07950: start_thread (pthread_create.c:301)
> ==31280==by 0x31D68E4D3C: clone (clone.S:115)
> ==31280==   followed by a later acquisition of lock at 0x59AE350
> ==31280==at 0x4A0679C: pthread_mutex_lock (hg_intercepts.c:464)
> ==31280==by 0x4E8C27B: qpid::sys::Mutex::lock() (Mutex.h:116)
> ==31280==by 0x4E8CD82: 
> qpid::sys::ScopedLock::ScopedLock(qpid::sys::Mutex&) 
> (Mutex.h:33)
> ==31280==by 0x5633B97: qpid::sys::Timer::run() (Timer.cpp:108)
> ==31280==by 0x5525BEE: qpid::sys::(anonymous 
> namespace)::runRunnable(void*) (Thread.cpp:35)
> ==31280==by 0x4A0A1A5: mythread_wrapper (hg_intercepts.c:201)
> ==31280==by 0x31D6C07950: start_thread (pthread_create.c:301)
> ==31280==by 0x31D68E4D3C: clone (clone.S:115)
> Running perftest against this broker shows numerous read/write conflicts too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-2567) [c++] Timer - possible thread lock ordering violation

2012-07-05 Thread Andrew Stitcher (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407470#comment-13407470
 ] 

Andrew Stitcher commented on QPID-2567:
---

I think it is very likely this bug is fixed by the recent checkin r1357827 on 
trunk.

Certainly I can no longer reproduce this bug report on qpid trunk.

> [c++] Timer - possible thread lock ordering violation
> -
>
> Key: QPID-2567
> URL: https://issues.apache.org/jira/browse/QPID-2567
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.7
> Environment: RHEL-6 beta
>Reporter: Kim van der Riet
>Assignee: Andrew Stitcher
> Fix For: 0.17
>
>
> Starting the broker using valgrind and the helgrind thread check tool shows 
> several lock order violations centered around the qpid::sys::Timer class.
> valgrind --tool=helgrind .libs/lt-qpidd --auth no --log-enable info+
> results in the following message (and others that are similar):
> ==31280== Thread #2: lock order "0x597D548 before 0x59AE350" violated
> ==31280==at 0x4A0679C: pthread_mutex_lock (hg_intercepts.c:464)
> ==31280==by 0x4E8C27B: qpid::sys::Mutex::lock() (Mutex.h:116)
> ==31280==by 0x4E8CD82: 
> qpid::sys::ScopedLock::ScopedLock(qpid::sys::Mutex&) 
> (Mutex.h:33)
> ==31280==by 0x56346FF: 
> qpid::sys::Timer::add(boost::intrusive_ptr) 
> (Timer.cpp:162)
> ==31280==by 0x4EFDCD0: qpid::broker::LinkRegistry::Periodic::fire() 
> (LinkRegistry.cpp:73)
> ==31280==by 0x563344C: qpid::sys::TimerTask::fireTask() (Timer.cpp:57)
> ==31280==by 0x5634917: 
> qpid::sys::Timer::fire(boost::intrusive_ptr) 
> (Timer.cpp:190)
> ==31280==by 0x5633E84: qpid::sys::Timer::run() (Timer.cpp:119)
> ==31280==by 0x5525BEE: qpid::sys::(anonymous 
> namespace)::runRunnable(void*) (Thread.cpp:35)
> ==31280==by 0x4A0A1A5: mythread_wrapper (hg_intercepts.c:201)
> ==31280==by 0x31D6C07950: start_thread (pthread_create.c:301)
> ==31280==by 0x31D68E4D3C: clone (clone.S:115)
> ==31280==   Required order was established by acquisition of lock at 0x597D548
> ==31280==at 0x4A095F6: pthread_cond_wait_WRK (hg_intercepts.c:653)
> ==31280==by 0x4A096B8: pthread_cond_wait@* (hg_intercepts.c:675)
> ==31280==by 0x4EF587A: qpid::sys::Condition::wait(qpid::sys::Mutex&) 
> (Condition.h:63)
> ==31280==by 0x4EF5932: qpid::sys::Monitor::wait() (Monitor.h:41)
> ==31280==by 0x5633AA6: qpid::sys::Timer::run() (Timer.cpp:98)
> ==31280==by 0x5525BEE: qpid::sys::(anonymous 
> namespace)::runRunnable(void*) (Thread.cpp:35)
> ==31280==by 0x4A0A1A5: mythread_wrapper (hg_intercepts.c:201)
> ==31280==by 0x31D6C07950: start_thread (pthread_create.c:301)
> ==31280==by 0x31D68E4D3C: clone (clone.S:115)
> ==31280==   followed by a later acquisition of lock at 0x59AE350
> ==31280==at 0x4A0679C: pthread_mutex_lock (hg_intercepts.c:464)
> ==31280==by 0x4E8C27B: qpid::sys::Mutex::lock() (Mutex.h:116)
> ==31280==by 0x4E8CD82: 
> qpid::sys::ScopedLock::ScopedLock(qpid::sys::Mutex&) 
> (Mutex.h:33)
> ==31280==by 0x5633B97: qpid::sys::Timer::run() (Timer.cpp:108)
> ==31280==by 0x5525BEE: qpid::sys::(anonymous 
> namespace)::runRunnable(void*) (Thread.cpp:35)
> ==31280==by 0x4A0A1A5: mythread_wrapper (hg_intercepts.c:201)
> ==31280==by 0x31D6C07950: start_thread (pthread_create.c:301)
> ==31280==by 0x31D68E4D3C: clone (clone.S:115)
> Running perftest against this broker shows numerous read/write conflicts too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: [Proton] ERROR amqp:connection:framing-error connection aborted

2012-07-05 Thread Darryl L. Pierce 
On Tue, Jul 03, 2012 at 05:13:17PM -0400, Rafael Schloming wrote:
> Can you post the ruby code you're using? I took a look at the original
> python example you're transcoding and based on the trace it's likely
> something is messed up around this part:
> 
> # we're done, close and wait for the remote to close also
> pn_connection_close(sender.conn)
> while not (pn_connection_state(sender.conn) & PN_REMOTE_CLOSED):
> sender.wait()

Sure, you can see all that I've done so far up in my Github repo:

https://github.com/mcpierce/proton/tree/Ruby-bindings

What I did in the Ruby was to line-by-line copy the above with:

  puts "Closing the connection."
  Cproton::pn_connection_close sender.conn
  while !(Cproton::pn_connection_state(sender.conn) & Cproton::PN_REMOTE_CLOSED)
log "Waiting for things to become closed..."
sender.wait
  end

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpZdfxqD22od.pgp
Description: PGP signature

[jira] [Resolved] (QPID-4085) HA fails long running failover test

2012-07-05 Thread Alan Conway (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved QPID-4085.
---

Resolution: Fixed

Fixed by the following commits:
Committed r1357846
Committed r1357848
Committed r1357849
Committed r1357850
Committed r1357851
Committed r1357852


> HA fails long running failover test
> ---
>
> Key: QPID-4085
> URL: https://issues.apache.org/jira/browse/QPID-4085
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Clustering
>Affects Versions: 0.17
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.17
>
>
> Running the following loop for a long time (up to 1.5 hours) the test 
> eventually fails:
> {noformat}
> cd tests; source ./test_env.sh;
> ha_tests.py $*
> while ha_tests.py *LongTests* -DDURATION=3; do date; done; exit 1
> {noformat}
> 3 types of failure observed:
> - timeout waiting for the primary broker to become 'active'
> - timeout waiting for a backup broker to become 'ready'
> - missing messages

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-4111) 0.18 release tasks

2012-07-05 Thread Justin Ross (JIRA) 
Justin Ross created QPID-4111:
-

 Summary: 0.18 release tasks
 Key: QPID-4111
 URL: https://issues.apache.org/jira/browse/QPID-4111
 Project: Qpid
  Issue Type: Task
  Components: Packaging
Affects Versions: 0.17
Reporter: Justin Ross
Assignee: Justin Ross


A bug to track various release tasks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Gordon Sim 


> On July 3, 2012, 11:04 a.m., Gordon Sim wrote:
> > trunk/qpid/cpp/src/qpid/broker/Exchange.cpp, line 381
> > 
> >
> > I notice we are not recording connection id here...
> 
> Chug Rolke wrote:
> This is the constructor for Binding. Binding has exchangeRef, queueRef, 
> and key and no reference to connection.

My question is what is the rationale for logging the connection id against the 
queue and the exchange being created, but not the binding (and logging the 
session id against subscribe/unsubscribe)?


- Gordon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/#review8831
---


On July 2, 2012, 9:11 p.m., Chug Rolke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5616/
> ---
> 
> (Updated July 2, 2012, 9:11 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross.
> 
> 
> Description
> ---
> 
> This patch adds a new log category [Configuration] and publishes a bunch of 
> information at info level in the format:
> [Configuration]  , where  is one of Connection, 
> Session, Queue, Subscription, Exchange or Binding, and  is one of 
> created or closed with connection also getting a setUser.
> The bulk of the patch involves passing the necessary strings down to the 
> object creators so that they can emit the log.
> 
> 
> This addresses bug QPID-4079.
> https://issues.apache.org/jira/browse/QPID-4079
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/include/qpid/SessionId.h 1354515 
>   trunk/qpid/cpp/include/qpid/log/Statement.h 1354515 
>   trunk/qpid/cpp/include/qpid/management/ManagementObject.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/SessionId.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Link.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/log/Statement.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/management/ManagementObject.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/replication/ReplicatingEventListener.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchangePlugin.cpp 1354515 
>   trunk/qpid/cpp/src/tests/ExchangeTest.cpp 1354515 
> 
> Diff: https://reviews.apache.org/r/5616/diff/
> 
> 
> Testing
> ---
> 
> Passes cmake test and automake make check.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Chug Rolke 


> On July 3, 2012, 3:35 p.m., Alan Conway wrote:
> > trunk/qpid/cpp/src/qpid/acl/Acl.cpp, line 296
> > 
> >
> > Performance problem: mapEncodeValues is called even if the log 
> > statememnt is disabled.
> > 
> > Sugget adding op<<(const ManagementObject&)
> > or struct PrintableManagementObject { const ManagementObject& }; with 
> > op<<(PrintableManagementObject), do all the work in the message 
> > specification.
> > 
> > This is repeated in many other places.

This instance is in ~Acl(). I contend that this and the one in ~Broker() are 
not performance issues.
The only instance that is performance critical is in 
ManagementObject::resourceDestroy(). There the creation of a map and its 
population with stats is qualified with the QPID_LOG_TEST(logEnabled) macro.


> On July 3, 2012, 3:35 p.m., Alan Conway wrote:
> > trunk/qpid/cpp/src/qpid/broker/Exchange.cpp, line 222
> > 
> >
> > Suggest moving this logic to a struct and defining op<< for the struct. 
> > Then all can be in-line in a single message:
> > 
> > struct Foo {
> >  Foo(string n, string i) : name(n), id(i){}
> > };
> > op<<(const Foo&) { ... }
> > QPID_LOG_CAT(debug, model, "xxx:" << Foo(name,connectionId))

Great idea. Thank you.


- Chug


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/#review8833
---


On July 2, 2012, 9:11 p.m., Chug Rolke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5616/
> ---
> 
> (Updated July 2, 2012, 9:11 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross.
> 
> 
> Description
> ---
> 
> This patch adds a new log category [Configuration] and publishes a bunch of 
> information at info level in the format:
> [Configuration]  , where  is one of Connection, 
> Session, Queue, Subscription, Exchange or Binding, and  is one of 
> created or closed with connection also getting a setUser.
> The bulk of the patch involves passing the necessary strings down to the 
> object creators so that they can emit the log.
> 
> 
> This addresses bug QPID-4079.
> https://issues.apache.org/jira/browse/QPID-4079
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/include/qpid/SessionId.h 1354515 
>   trunk/qpid/cpp/include/qpid/log/Statement.h 1354515 
>   trunk/qpid/cpp/include/qpid/management/ManagementObject.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/SessionId.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Link.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/log/Statement.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/management/ManagementObject.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/replication/ReplicatingEventListener.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExch

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Chug Rolke 


> On July 3, 2012, 11:04 a.m., Gordon Sim wrote:
> > trunk/qpid/cpp/src/qpid/broker/Exchange.cpp, line 251
> > 
> >
> > Why does the name need to be passed in here? The management object was 
> > given the name when it was created.

This strategy needs to be backed out. A better approach is to move all the 
logging into the Management Event code where the proper data and context are 
present for a concise log generation. 


> On July 3, 2012, 11:04 a.m., Gordon Sim wrote:
> > trunk/qpid/cpp/src/qpid/broker/Exchange.cpp, line 381
> > 
> >
> > I notice we are not recording connection id here...

This is the constructor for Binding. Binding has exchangeRef, queueRef, and key 
and no reference to connection.


> On July 3, 2012, 11:04 a.m., Gordon Sim wrote:
> > trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp, line 379
> > 
> >
> > I don't understand this change; could you clarify?

true error


- Chug


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/#review8831
---


On July 2, 2012, 9:11 p.m., Chug Rolke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5616/
> ---
> 
> (Updated July 2, 2012, 9:11 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross.
> 
> 
> Description
> ---
> 
> This patch adds a new log category [Configuration] and publishes a bunch of 
> information at info level in the format:
> [Configuration]  , where  is one of Connection, 
> Session, Queue, Subscription, Exchange or Binding, and  is one of 
> created or closed with connection also getting a setUser.
> The bulk of the patch involves passing the necessary strings down to the 
> object creators so that they can emit the log.
> 
> 
> This addresses bug QPID-4079.
> https://issues.apache.org/jira/browse/QPID-4079
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/include/qpid/SessionId.h 1354515 
>   trunk/qpid/cpp/include/qpid/log/Statement.h 1354515 
>   trunk/qpid/cpp/include/qpid/management/ManagementObject.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/SessionId.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Link.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/log/Statement.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/management/ManagementObject.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/replication/ReplicatingEventListener.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchangePlugin.cpp 1354515 
>   trunk/qpid/cpp/src/tests/ExchangeTest.cpp 1354515 
> 
> Diff: https://reviews.apache.org/r/5616/diff/
> 
> 
> Testing
> ---
> 
> Passes cmake test and automake make check.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>

[jira] [Updated] (QPID-3999) [Java Broker] Implement Web based management tool for the Java Broker

2012-07-05 Thread Alex Rudyy (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-3999:
-

Attachment: 0001-QPID-3999-System-tests-for-Rest-API.patch

Attached patch with system tests for REST API

> [Java Broker] Implement Web based management tool for the Java Broker
> -
>
> Key: QPID-3999
> URL: https://issues.apache.org/jira/browse/QPID-3999
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Rob Godfrey
> Fix For: 0.17
>
> Attachments: 
> 0001-QPID-3999-Add-authorization-checks-for-message-copy-.patch, 
> 0001-QPID-3999-Add-default-constructors-to-servlets-make-.patch, 
> 0001-QPID-3999-Add-java-broker-web-module-to-package-brok.patch, 
> 0001-QPID-3999-Add-servlet-filter-to-set-request-credenti.patch, 
> 0001-QPID-3999-Allow-invocation-of-functionality-original.patch, 
> 0001-QPID-3999-System-tests-for-Rest-API.patch, 
> 0001-QPID-3999-Use-anonymous-subject-for-non-authenticate.patch
>
>
> Implement a web front end which uses the RESTful HTTP management API

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-3575) session exceptions do not properly close connections, causing connections leak

2012-07-05 Thread Rajith Attapattu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajith Attapattu updated QPID-3575:
---

Fix Version/s: 0.17

> session exceptions do not properly close connections, causing connections leak
> --
>
> Key: QPID-3575
> URL: https://issues.apache.org/jira/browse/QPID-3575
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.10, 0.12, 0.13
>Reporter: Pavel Moravec
>Priority: Critical
>  Labels: exception-handling
> Fix For: 0.17
>
> Attachments: QueueFull.java, TestQpidLeak.java, 
> jira-3575_workaround-patch.patch
>
>
> Description of problem:
> There is a connection leak as described below.
> A session level exception is designed to close the underlying connection 
> (along with the other sessions). However this is not true as there are at 
> least two scenarios leading in an orphaned connection that can't be further 
> used(*) (along with any session created on it) but it can't be deleted.
> (*) Once an exception is raised, the connection, a session created on it or a 
> producer/consumer created on such a session can't be effectivelly used - any 
> usage ends up in an exception like the connection would be closed.
> ---
> First scenario:
> If qpid.declare_queues is set to false and an attempt to subscribe to a 
> non-existing queue is made, an exception is raised and subsequent 
> connection.close() method does not close the TCP connection at all.
> Steps to Reproduce:
> 1. Start a fresh qpid broker with auth=no - make sure no
> "some.unreal.destination" queue is there
> 2. Run attached Java program TestQpidLeak.java
> 3. Do _not_ terminate it when a prompt appears in it
> 4. Run qpid-stat -c in parallel
> Actual results:
> qpid-stat shows 10 connections made by the client and despite 
> connection.close() has been called for each of them.
> Expected results:
> qpid-stat does not show the 10 connections.
> ---
> Second scenario:
> Try to send 500 messages into a queue with max-queue-count 10. Again, a 
> session exception is raised, connection is attempted to be closed but with no 
> impact.
> Steps to Reproduce:
> 1. Start a fresh qpid broker with auth=no
> 2. qpid-config add queue testQueue --max-queue-count 10
> 3. Run attached Java program QueueFull.java
> 3. Do _not_ terminate it when a prompt appears in it
> 4. Run qpid-stat -c in parallel
> Actual results:
> qpid-stat shows 1 connection made by the client and despite 
> connection.close() has been called.
> Sometimes (using a slightly different Java program that I can't revoke) the 
> invoking of connection.close() method in finally-block does not terminate.
> Expected results:
> qpid-stat does not show the connection from the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-3977) Add charting framework for new distributed tests framwork

2012-07-05 Thread Keith Wall (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407214#comment-13407214
 ] 

Keith Wall commented on QPID-3977:
--

Patches applied.

> Add charting framework for new distributed tests framwork
> -
>
> Key: QPID-3977
> URL: https://issues.apache.org/jira/browse/QPID-3977
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: 0.17
>
> Attachments: 
> 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch, 
> 0001-QPID-3977-fixed-in-previous-patch-where-we-tried-to-.patch, 
> 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch
>
>
> We need a flexible charting mechanism to allow the performance figures 
> produced by the new distributed test tool (QPID-3936) to be readily 
> understood.   This new Java module uses JFreeChart to produce charts from the 
> CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 
> compatible, the new module perftests/visualisation-jfc is optional and is not 
> part of the standard Java build nor does it form part of the distributables.  
> If the user wishes to use this module, they must download the JARs 
> themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform 
> the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true 
> -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Keith Wall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-4110.
--

   Resolution: Fixed
Fix Version/s: (was: Future)
   0.17

Reviewed, no comments. Patch applied.

> [Java Performance Tests] Add topic support to distributed test framework
> 
>
> Key: QPID-4110
> URL: https://issues.apache.org/jira/browse/QPID-4110
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Performance Tests
>Reporter: Philip Harvey
>Assignee: Keith Wall
>Priority: Minor
> Fix For: 0.17
>
> Attachments: 
> 0005-QPID-4110-added-topic-support-to-performance-tests.-.patch
>
>
> The test framework added in QPID-3936 does not yet provide full support for 
> topics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Keith Wall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-4110:
-

Status: Ready To Review  (was: In Progress)

> [Java Performance Tests] Add topic support to distributed test framework
> 
>
> Key: QPID-4110
> URL: https://issues.apache.org/jira/browse/QPID-4110
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Performance Tests
>Reporter: Philip Harvey
>Assignee: Keith Wall
>Priority: Minor
> Fix For: 0.17
>
> Attachments: 
> 0005-QPID-4110-added-topic-support-to-performance-tests.-.patch
>
>
> The test framework added in QPID-3936 does not yet provide full support for 
> topics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Gordon Sim 


> On July 3, 2012, 11:04 a.m., Gordon Sim wrote:
> > trunk/qpid/cpp/include/qpid/SessionId.h, line 45
> > 
> >
> > I think adding this here is wrong. A session id does not logically 
> > include the connection id. See suggestion in SessionState changes for 
> > simple alternative.
> 
> Chug Rolke wrote:
> From the XML:
>   
> ...
>  references="Connection" access="RO"/>
> 
> Session stats must be aggregated to the connection over which it was 
> created.

Right, that is a sesion though, which is different from a session id.


- Gordon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/#review8831
---


On July 2, 2012, 9:11 p.m., Chug Rolke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5616/
> ---
> 
> (Updated July 2, 2012, 9:11 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross.
> 
> 
> Description
> ---
> 
> This patch adds a new log category [Configuration] and publishes a bunch of 
> information at info level in the format:
> [Configuration]  , where  is one of Connection, 
> Session, Queue, Subscription, Exchange or Binding, and  is one of 
> created or closed with connection also getting a setUser.
> The bulk of the patch involves passing the necessary strings down to the 
> object creators so that they can emit the log.
> 
> 
> This addresses bug QPID-4079.
> https://issues.apache.org/jira/browse/QPID-4079
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/include/qpid/SessionId.h 1354515 
>   trunk/qpid/cpp/include/qpid/log/Statement.h 1354515 
>   trunk/qpid/cpp/include/qpid/management/ManagementObject.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/SessionId.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Link.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/log/Statement.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/management/ManagementObject.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/replication/ReplicatingEventListener.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchangePlugin.cpp 1354515 
>   trunk/qpid/cpp/src/tests/ExchangeTest.cpp 1354515 
> 
> Diff: https://reviews.apache.org/r/5616/diff/
> 
> 
> Testing
> ---
> 
> Passes cmake test and automake make check.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>

[jira] [Updated] (QPID-3977) Add charting framework for new distributed tests framwork

2012-07-05 Thread Philip Harvey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Harvey updated QPID-3977:


Attachment: 0001-QPID-3977-fixed-in-previous-patch-where-we-tried-to-.patch

attached patch to fix problems in previous one

> Add charting framework for new distributed tests framwork
> -
>
> Key: QPID-3977
> URL: https://issues.apache.org/jira/browse/QPID-3977
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: 0.17
>
> Attachments: 
> 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch, 
> 0001-QPID-3977-fixed-in-previous-patch-where-we-tried-to-.patch, 
> 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch
>
>
> We need a flexible charting mechanism to allow the performance figures 
> produced by the new distributed test tool (QPID-3936) to be readily 
> understood.   This new Java module uses JFreeChart to produce charts from the 
> CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 
> compatible, the new module perftests/visualisation-jfc is optional and is not 
> part of the standard Java build nor does it form part of the distributables.  
> If the user wishes to use this module, they must download the JARs 
> themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform 
> the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true 
> -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Chug Rolke 


> On July 3, 2012, 11:04 a.m., Gordon Sim wrote:
> > trunk/qpid/cpp/include/qpid/SessionId.h, line 45
> > 
> >
> > I think adding this here is wrong. A session id does not logically 
> > include the connection id. See suggestion in SessionState changes for 
> > simple alternative.

>From the XML:
  
...


Session stats must be aggregated to the connection over which it was created.


> On July 3, 2012, 11:04 a.m., Gordon Sim wrote:
> > trunk/qpid/cpp/src/qpid/acl/Acl.cpp, line 297
> > 
> >
> > Use getStatsAsMap()? (For consistency more than real performance 
> > concerns)

correct


> On July 3, 2012, 11:04 a.m., Gordon Sim wrote:
> > trunk/qpid/cpp/src/qpid/broker/Broker.cpp, line 436
> > 
> >
> > Use getStatsAsMap()?

correct


- Chug


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/#review8831
---


On July 2, 2012, 9:11 p.m., Chug Rolke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5616/
> ---
> 
> (Updated July 2, 2012, 9:11 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross.
> 
> 
> Description
> ---
> 
> This patch adds a new log category [Configuration] and publishes a bunch of 
> information at info level in the format:
> [Configuration]  , where  is one of Connection, 
> Session, Queue, Subscription, Exchange or Binding, and  is one of 
> created or closed with connection also getting a setUser.
> The bulk of the patch involves passing the necessary strings down to the 
> object creators so that they can emit the log.
> 
> 
> This addresses bug QPID-4079.
> https://issues.apache.org/jira/browse/QPID-4079
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/include/qpid/SessionId.h 1354515 
>   trunk/qpid/cpp/include/qpid/log/Statement.h 1354515 
>   trunk/qpid/cpp/include/qpid/management/ManagementObject.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.h 1354515 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/SessionId.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Link.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/log/Statement.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/management/ManagementObject.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/replication/ReplicatingEventListener.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.h 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1354515 
>   trunk/qpid/cpp/src/qpid/xml/XmlExchangePlugin.cpp 1354515 
>   trunk/qpid/cpp/src/tests/ExchangeTest.cpp 1354515 
> 
> Diff: https://reviews.apache.org/r/5616/diff/
> 
> 
> Testing
> ---
> 
> Passes cmake test and automake make check.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>

[jira] [Comment Edited] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Alex Rudyy (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407159#comment-13407159
 ] 

Alex Rudyy edited comment on QPID-4109 at 7/5/12 2:25 PM:
--

Hi Keith,
I reviewed your code.

The changes looks good for me. I have only some minor comments which I provided 
below:

1) I would change the name of class LoggingFacade into LoggingManagementFacade 
or LoggingConfigFacade. IMHO, LoggingFacade name is too generic

2)I would change LoggingFacade#getAvailableLoggerLevels and 
LoggingManagementMBean#getAvailableLoggerLevels. IMHO, creation of new instance 
of list on every invocation of getAvailableLoggerLevels is not not so 
effective,  as declaring a constant for available logger levels and returning 
the reference to that constant in getAvailableLoggerLevels.
 
3)LoggingManagementMBean#validateLevelNotAllowingInherited

It looks like the first condition in if statement is redundant.
I would change it to something like
{code}
if (level == null || 
!availableLoggerLevels.contains(level.toUpperCase()))
{
throw new IllegalArgumentException(level + " not known");
}
{code}

Keith,
What do you think about the above comments?

  was (Author: alex.rufous):
Hi Keith,
I reviewed your code.

The changes looks good for me. I have only some minor comments which I provided 
below:

1) I would change the name of the class LoggingFacade into 
LoggingManagementFacade or LoggingConfigFacade. IMHO, LoggingFacade name is to 
generic

2)I would change LoggingFacade#getAvailableLoggerLevels and 
LoggingManagementMBean#getAvailableLoggerLevels. IMHO, creation of new instance 
of list on every invocation of getAvailableLoggerLevels is not not so 
effective,  as declaring a constant for available logger levels and returning 
the reference to the constant in getAvailableLoggerLevels.
 
3)LoggingManagementMBean#validateLevelNotAllowingInherited

It looks like the first condition in if statement is redundant.
I would change it something like
{code}
if (level == null || 
!availableLoggerLevels.contains(level.toUpperCase()))
{
throw new IllegalArgumentException(level + " not known");
}
{code}

Keith,
What do you think about the above comments?
  
> Reenable LoggingManagement MBean
> 
>
> Key: QPID-4109
> URL: https://issues.apache.org/jira/browse/QPID-4109
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker, Java Management : JMX Console
>Affects Versions: 0.17
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: 0.17
>
>
> QPID-4093 temporarily removed the LoggingManagement MBean from the JMX 
> management interface.  This change is to re-add the bean.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Alex Rudyy (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407159#comment-13407159
 ] 

Alex Rudyy commented on QPID-4109:
--

Hi Keith,
I reviewed your code.

The changes looks good for me. I have only some minor comments which I provided 
below:

1) I would change the name of the class LoggingFacade into 
LoggingManagementFacade or LoggingConfigFacade. IMHO, LoggingFacade name is to 
generic

2)I would change LoggingFacade#getAvailableLoggerLevels and 
LoggingManagementMBean#getAvailableLoggerLevels. IMHO, creation of new instance 
of list on every invocation of getAvailableLoggerLevels is not not so 
effective,  as declaring a constant for available logger levels and returning 
the reference to the constant in getAvailableLoggerLevels.
 
3)LoggingManagementMBean#validateLevelNotAllowingInherited

It looks like the first condition in if statement is redundant.
I would change it something like
{code}
if (level == null || 
!availableLoggerLevels.contains(level.toUpperCase()))
{
throw new IllegalArgumentException(level + " not known");
}
{code}

Keith,
What do you think about the above comments?

> Reenable LoggingManagement MBean
> 
>
> Key: QPID-4109
> URL: https://issues.apache.org/jira/browse/QPID-4109
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker, Java Management : JMX Console
>Affects Versions: 0.17
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: 0.17
>
>
> QPID-4093 temporarily removed the LoggingManagement MBean from the JMX 
> management interface.  This change is to re-add the bean.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4108) HA does not replicate user - missing user property in management-schema

2012-07-05 Thread Alan Conway (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407076#comment-13407076
 ] 

Alan Conway commented on QPID-4108:
---

Perhaps the user shouldn't be replicated. Instead HA replication should use a 
configurable user-name so that it can be allowed access in ACLs.

> HA does not replicate user - missing user property in management-schema
> ---
>
> Key: QPID-4108
> URL: https://issues.apache.org/jira/browse/QPID-4108
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Clustering
>Affects Versions: 0.17
>Reporter: Alan Conway
>Assignee: Alan Conway
>
> The management-schema does not have a "user" property for Queue and Exchange 
> objects. As a result, a HA primary cannot replicate this value to a backup. 
> Note the user argument is present in queue and exchange declare events. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4103) [Java Performance Tests] Allow specifying of test configuration with Javascript

2012-07-05 Thread Philip Harvey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Harvey updated QPID-4103:


Summary: [Java Performance Tests] Allow specifying of test configuration 
with Javascript  (was: [Java Performance Tests] Allow specifying of test 
configuration with Java script)

> [Java Performance Tests] Allow specifying of test configuration with 
> Javascript
> ---
>
> Key: QPID-4103
> URL: https://issues.apache.org/jira/browse/QPID-4103
> Project: Qpid
>  Issue Type: Task
>  Components: Java Performance Tests
>Affects Versions: 0.17
>Reporter: Alex Rudyy
>Assignee: Keith Wall
> Fix For: 0.17
>
> Attachments: 
> 0001-QPID-4103-Java-Performance-Tests-Allow-specifying-of.patch, 
> 0001-QPID-4103-Java-Performance-Tests-Allow-specifying-of.patch
>
>
> Add support for JavaScript configuration into Performance Test Framework in 
> order to generate JSON test configuration from provided javascript file

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-3977) Add charting framework for new distributed tests framwork

2012-07-05 Thread Philip Harvey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Harvey updated QPID-3977:


Attachment: 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch

attached patch to tidy up some aspects of chart generation

> Add charting framework for new distributed tests framwork
> -
>
> Key: QPID-3977
> URL: https://issues.apache.org/jira/browse/QPID-3977
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: 0.17
>
> Attachments: 
> 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch, 
> 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch
>
>
> We need a flexible charting mechanism to allow the performance figures 
> produced by the new distributed test tool (QPID-3936) to be readily 
> understood.   This new Java module uses JFreeChart to produce charts from the 
> CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 
> compatible, the new module perftests/visualisation-jfc is optional and is not 
> part of the standard Java build nor does it form part of the distributables.  
> If the user wishes to use this module, they must download the JARs 
> themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform 
> the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true 
> -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Philip Harvey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Harvey reassigned QPID-4110:
---

Assignee: Keith Wall  (was: Philip Harvey)

Keith - please can you review and commit if you're happy. Thanks.

> [Java Performance Tests] Add topic support to distributed test framework
> 
>
> Key: QPID-4110
> URL: https://issues.apache.org/jira/browse/QPID-4110
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Performance Tests
>Reporter: Philip Harvey
>Assignee: Keith Wall
>Priority: Minor
> Fix For: Future
>
> Attachments: 
> 0005-QPID-4110-added-topic-support-to-performance-tests.-.patch
>
>
> The test framework added in QPID-3936 does not yet provide full support for 
> topics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Philip Harvey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Harvey updated QPID-4110:


Attachment: 0005-QPID-4110-added-topic-support-to-performance-tests.-.patch

attached patch

> [Java Performance Tests] Add topic support to distributed test framework
> 
>
> Key: QPID-4110
> URL: https://issues.apache.org/jira/browse/QPID-4110
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Performance Tests
>Reporter: Philip Harvey
>Assignee: Philip Harvey
>Priority: Minor
> Fix For: Future
>
> Attachments: 
> 0005-QPID-4110-added-topic-support-to-performance-tests.-.patch
>
>
> The test framework added in QPID-3936 does not yet provide full support for 
> topics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Philip Harvey (JIRA) 
Philip Harvey created QPID-4110:
---

 Summary: [Java Performance Tests] Add topic support to distributed 
test framework
 Key: QPID-4110
 URL: https://issues.apache.org/jira/browse/QPID-4110
 Project: Qpid
  Issue Type: Improvement
  Components: Java Performance Tests
Reporter: Philip Harvey
Assignee: Philip Harvey
Priority: Minor
 Fix For: Future


The test framework added in QPID-3936 does not yet provide full support for 
topics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Keith Wall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall reassigned QPID-4109:


Assignee: Alex Rudyy  (was: Keith Wall)

> Reenable LoggingManagement MBean
> 
>
> Key: QPID-4109
> URL: https://issues.apache.org/jira/browse/QPID-4109
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker, Java Management : JMX Console
>Affects Versions: 0.17
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: 0.17
>
>
> QPID-4093 temporarily removed the LoggingManagement MBean from the JMX 
> management interface.  This change is to re-add the bean.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Keith Wall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-4109:
-

Status: Ready To Review  (was: In Progress)

> Reenable LoggingManagement MBean
> 
>
> Key: QPID-4109
> URL: https://issues.apache.org/jira/browse/QPID-4109
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker, Java Management : JMX Console
>Affects Versions: 0.17
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: 0.17
>
>
> QPID-4093 temporarily removed the LoggingManagement MBean from the JMX 
> management interface.  This change is to re-add the bean.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Keith Wall (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406939#comment-13406939
 ] 

Keith Wall commented on QPID-4109:
--

Patch applied.

> Reenable LoggingManagement MBean
> 
>
> Key: QPID-4109
> URL: https://issues.apache.org/jira/browse/QPID-4109
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker, Java Management : JMX Console
>Affects Versions: 0.17
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: 0.17
>
>
> QPID-4093 temporarily removed the LoggingManagement MBean from the JMX 
> management interface.  This change is to re-add the bean.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4093) [Java Broker] extract the JMX management functionality into its own module

2012-07-05 Thread Keith Wall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-4093:
-

Component/s: Java Management : JMX Console

> [Java Broker] extract the JMX management functionality into its own module
> --
>
> Key: QPID-4093
> URL: https://issues.apache.org/jira/browse/QPID-4093
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Management : JMX Console
>Reporter: Robbie Gemmell
> Fix For: 0.17
>
>
> The JMX functionality offered by the broker is heavily intertwined into the 
> broker core. It should be separated into its own module, to aid subsequent 
> creation of a common management layer that can be leveraged for the 
> JMX/HTTP/QMF/etc management interfaces.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Keith Wall (JIRA) 
Keith Wall created QPID-4109:


 Summary: Reenable LoggingManagement MBean
 Key: QPID-4109
 URL: https://issues.apache.org/jira/browse/QPID-4109
 Project: Qpid
  Issue Type: Task
  Components: Java Broker, Java Management : JMX Console
Affects Versions: 0.17
Reporter: Keith Wall
Assignee: Keith Wall
 Fix For: 0.17


QPID-4093 temporarily removed the LoggingManagement MBean from the JMX 
management interface.  This change is to re-add the bean.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org