[jira] [Commented] (QPID-4701) Exception types lost in qpidmessaging when compiling with cmake and gcc 4.1.2 (e.g. RHEL5)
[ https://issues.apache.org/jira/browse/QPID-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622812#comment-13622812 ] Andrew Stitcher commented on QPID-4701: --- I'm confused by one thing though - it would seem that if the symbol visibility was the cause of the problem it would happen in all version of gcc not just 4.1.2. > Exception types lost in qpidmessaging when compiling with cmake and gcc > 4.1.2 (e.g. RHEL5) > --- > > Key: QPID-4701 > URL: https://issues.apache.org/jira/browse/QPID-4701 > Project: Qpid > Issue Type: Bug > Components: C++ Client >Affects Versions: 0.20, 0.22 >Reporter: Gordon Sim >Assignee: Gordon Sim > > Exceptions are thrown simply as std::exception rather than the specific types > defined. This appears to be a result of the visibility flag support in the > version of gcc (cmake turns that on, autotools does not). > (See also QPID-4484) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request: Turn off -fvisibility=hidden for gcc 4.1.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10283/#review18689 --- Ship it! Ship It! - Alan Conway On April 4, 2013, 1:13 p.m., Gordon Sim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10283/ > --- > > (Updated April 4, 2013, 1:13 p.m.) > > > Review request for qpid, Andrew Stitcher, Alan Conway, and Steve Huston. > > > Description > --- > > Reason being it causes the exception types in the qpidmessaging library to be > lost. > > > This addresses bug QPID-4701. > https://issues.apache.org/jira/browse/QPID-4701 > > > Diffs > - > > /trunk/qpid/cpp/src/CMakeLists.txt 1464148 > > Diff: https://reviews.apache.org/r/10283/diff/ > > > Testing > --- > > Passes previously failing make test on gcc 4.1.2; doesn't break anything on > later gcc. > > > Thanks, > > Gordon Sim > >
[jira] [Created] (QPID-4704) Legacy store is building as a shared library rather than a module
Darryl L. Pierce created QPID-4704: -- Summary: Legacy store is building as a shared library rather than a module Key: QPID-4704 URL: https://issues.apache.org/jira/browse/QPID-4704 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.20 Reporter: Darryl L. Pierce Assignee: Darryl L. Pierce Fix For: Future The store builds as a shared library rather than a module. A simple fix would be to change the library type in the Cmake build files to fix this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-4703) HA: Update README-HA to refer to 0.22 docs.
Alan Conway created QPID-4703: - Summary: HA: Update README-HA to refer to 0.22 docs. Key: QPID-4703 URL: https://issues.apache.org/jira/browse/QPID-4703 Project: Qpid Issue Type: Bug Components: Documentation Affects Versions: 0.20 Reporter: Alan Conway Assignee: Alan Conway Fix For: 0.22 The qpid/cpp/README-HA.txt file contains links to the trunk version of the C++ broker documentation on the qpid website. Before final release it should be updated to link to the 0.22 version of the documentation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Migration guide from old cluster to new ha.
I've stated a migration guide for users of the old cluster module to migrate to the new HA module. I'd appreciate any comments, esp. from folks who have worked with both. At the moment it's very brief. The doc is attached and also checked into qpid/qpid/cpp. Thanks in advance! Alan. Migrating to new HA === Up to version 0.20, Qpid provided the `cluster` module to support active-active clustering for Qpid C++ brokers. In version 0.20 the `ha` module was introduced supporting active-passive HA clustering. From version 0.22 the older `cluster` module is no longer available so users will have to migrate to the new `ha` module. This document summarizes the differences between the old and new HA modules and the steps to migrate to new HA. It assumes you have read the [HA chapter of the C++ Broker Book][chapter-ha] Client connections and fail-over The old cluster module was active-active: clients could connect to any broker in the cluster. The new ha module is active-passive. Exactly 1 broker acts as *primary* the other brokers act as *backup*. Only the primary accepts client connections. If a client attempts to connect to a *backup* broker, the connection will be aborted and the client will fail-over until it connects to the primary. See ["Client Connections and Failover"][ha-failover]. The new cluster module also supports a [virtual IP address][ha-virtual-ip]. Clients can be configured with a single IP address that is automatically routed to the primary broker. This is the recommended configuration. Migrating configuration options for the old cluster module -- `cluster-name`: Not needed. `cluster-size`: Not needed but see "Using a message store in a cluster" below `cluster-url`: Use `ha-public-url`, which is recommended to use a [virtual IP address][ha-virtual-ip] `cluster-cman`: Not needed `cluster-username, cluster-password, cluster-mechanism`: use `ha-username, ha-password, ha-mechanism` Configuration options for new HA module `ha-cluster`: set to `yes` to enable clustering. `ha-brokers-url`: set to a URL listing each node in the cluster. For example `amqp:node1.exaple.com,node2.exaple.com,node3.exaple.com`. The set of addresses for the cluster is fixed, you can't add new members with different addresses while the cluster is running. You can shut-down and re-start a broker on the same address. `ha-public-url`: URL used by clients to connect to the cluster. It is recommended to set this to the [Virtual IP address][ha-virtual-ip] of the cluster. `ha-replicate`: Set to `all` to replicate everything like the old cluster does. New HA provides more flexibility over what is replicated, see ["Controlling replication of queues and exchanges"][ha-replicate-values]. `ha-username, ha-password, ha-mechanism`: Same as old `cluster-username, cluster-password, cluster-mechanism` `ha-backup-timeout`: Maximum time that a recovering primary will wait for an expected backup to connect and become ready. `link-maintenance-interval`: Interval in seconds for the broker to check link health and re-connect links if need be. If you want brokers to fail over quickly you can set this to a fraction of a second, for example: 0.1. `link-heartbeat-interval` Heartbeat interval for replication links. The link will be assumed broken if there is no heartbeat for twice the interval. Configuring rgmanager - The new HA module requires an external cluster resource manager, `rgmanager` provided by the `cman` package. `rgmanager` is responsible for stopping and starting brokers and determining which broker is promoted to primary. It is also responsible for detecting primary failures and promoting a new primary. See ["Configuring rgmanager as resource manager"][ha-rm-config] Broker Administration Tools --- Normally, clients are not allowed to connect to a backup broker. However management tools are allowed to connect to a backup brokers. If you use these tools you must not add or remove messages from replicated queues, nor create or delete replicated queues or exchanges as this will disrupt the replication process and may cause message loss. qpid-ha allows you to view and change HA configuration settings. The tools qpid-config, qpid-route and qpid-stat will connect to a backup if you pass the flag ha-admin on the command line. Fail-over exchange -- The fail-over exchange is not supported in new HA, use a [virtual IP address][ha-virtual-ip] instead.[] Using a message store in a cluster -- If you use a persistent store for your messages then each broker in a cluster will have its own store. If the entire cluster fails, when restarting the *first* broker that becomes primary will recover from its store. All the other brokers will clear their stores and get an update from t
[jira] [Resolved] (QPID-4697) Minor fixes to make distcheck
[ https://issues.apache.org/jira/browse/QPID-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved QPID-4697. --- Resolution: Fixed Commits: trunk r1464018, 0.22 r1464646 > Minor fixes to make distcheck > - > > Key: QPID-4697 > URL: https://issues.apache.org/jira/browse/QPID-4697 > Project: Qpid > Issue Type: Bug > Components: Build Tools >Affects Versions: 0.20 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.22 > > > - add qmfengine.py to DIST. > - create directory qpid/bindings/perl if not already present. > - ssl_test: don't run python part of tests if python client not available. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4699) C++ INSTALL instructions might be clearer if the "Building from a Source Distribution" was moved to the top.
[ https://issues.apache.org/jira/browse/QPID-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-4699: -- Fix Version/s: 0.22 > C++ INSTALL instructions might be clearer if the "Building from a Source > Distribution" was moved to the top. > > > Key: QPID-4699 > URL: https://issues.apache.org/jira/browse/QPID-4699 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client > Environment: All >Reporter: Fraser Adams >Priority: Minor > Fix For: 0.22 > > > With the INSTALL instructions in /cpp the "Building from a Source > Distribution" instructions are fairly near the bottom. > I kind of see the logic of that since the earlier sections are describing > prerequisites, but I wonder if it's worth moving the main install bit closer > to the top with a line that says something like "If you have not installed > qpid previously see prerequisites below". > Similarly section "2.2.2. From Source" might be better in the prerequisites > section rather than the install section, I think that's particularly > worthwhile now because 2.2.2 is talking about an automake build for > the dependencies and the qpid install is now cmake. I know that I did a > double take when I skimmed through and assumed that the instructions hadn't > been updated for cmake until I read again. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4699) C++ INSTALL instructions might be clearer if the "Building from a Source Distribution" was moved to the top.
[ https://issues.apache.org/jira/browse/QPID-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622370#comment-13622370 ] Fraser Adams commented on QPID-4699: Just to be clear, I did an extra update following comments from Steve & Robbie so the latest commit of this is now at r1464493 and not r1464175 as stated in my original comment (though r1464493 is what I gave to Justin when I requested inclusion in 0.22). > C++ INSTALL instructions might be clearer if the "Building from a Source > Distribution" was moved to the top. > > > Key: QPID-4699 > URL: https://issues.apache.org/jira/browse/QPID-4699 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client > Environment: All >Reporter: Fraser Adams >Priority: Minor > > With the INSTALL instructions in /cpp the "Building from a Source > Distribution" instructions are fairly near the bottom. > I kind of see the logic of that since the earlier sections are describing > prerequisites, but I wonder if it's worth moving the main install bit closer > to the top with a line that says something like "If you have not installed > qpid previously see prerequisites below". > Similarly section "2.2.2. From Source" might be better in the prerequisites > section rather than the install section, I think that's particularly > worthwhile now because 2.2.2 is talking about an automake build for > the dependencies and the qpid install is now cmake. I know that I did a > double take when I skimmed through and assumed that the instructions hadn't > been updated for cmake until I read again. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4699) C++ INSTALL instructions might be clearer if the "Building from a Source Distribution" was moved to the top.
[ https://issues.apache.org/jira/browse/QPID-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622358#comment-13622358 ] Justin Ross commented on QPID-4699: --- Reviewed by Alan, Robbie, and Steve. Approved for 0.22. > C++ INSTALL instructions might be clearer if the "Building from a Source > Distribution" was moved to the top. > > > Key: QPID-4699 > URL: https://issues.apache.org/jira/browse/QPID-4699 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client > Environment: All >Reporter: Fraser Adams >Priority: Minor > > With the INSTALL instructions in /cpp the "Building from a Source > Distribution" instructions are fairly near the bottom. > I kind of see the logic of that since the earlier sections are describing > prerequisites, but I wonder if it's worth moving the main install bit closer > to the top with a line that says something like "If you have not installed > qpid previously see prerequisites below". > Similarly section "2.2.2. From Source" might be better in the prerequisites > section rather than the install section, I think that's particularly > worthwhile now because 2.2.2 is talking about an automake build for > the dependencies and the qpid install is now cmake. I know that I did a > double take when I skimmed through and assumed that the instructions hadn't > been updated for cmake until I read again. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request: Turn off -fvisibility=hidden for gcc 4.1.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10283/ --- (Updated April 4, 2013, 1:13 p.m.) Review request for qpid, Andrew Stitcher, Alan Conway, and Steve Huston. Summary (updated) - Turn off -fvisibility=hidden for gcc 4.1.2 Description --- Reason being it causes the exception types in the qpidmessaging library to be lost. This addresses bug QPID-4701. https://issues.apache.org/jira/browse/QPID-4701 Diffs - /trunk/qpid/cpp/src/CMakeLists.txt 1464148 Diff: https://reviews.apache.org/r/10283/diff/ Testing --- Passes previously failing make test on gcc 4.1.2; doesn't break anything on later gcc. Thanks, Gordon Sim
[jira] [Commented] (QPID-4701) Exception types lost in qpidmessaging when compiling with cmake and gcc 4.1.2 (e.g. RHEL5)
[ https://issues.apache.org/jira/browse/QPID-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622160#comment-13622160 ] Gordon Sim commented on QPID-4701: -- Suggested change is to disable the visibility setting on the affected version of gcc: https://reviews.apache.org/r/10283/ > Exception types lost in qpidmessaging when compiling with cmake and gcc > 4.1.2 (e.g. RHEL5) > --- > > Key: QPID-4701 > URL: https://issues.apache.org/jira/browse/QPID-4701 > Project: Qpid > Issue Type: Bug > Components: C++ Client >Affects Versions: 0.20, 0.22 >Reporter: Gordon Sim >Assignee: Gordon Sim > > Exceptions are thrown simply as std::exception rather than the specific types > defined. This appears to be a result of the visibility flag support in the > version of gcc (cmake turns that on, autotools does not). > (See also QPID-4484) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request: Turn off -fvisibility=hidden for gcc 4.1.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10283/#review18683 --- Ship it! Ship It! - Steve Huston On April 4, 2013, 1:13 p.m., Gordon Sim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10283/ > --- > > (Updated April 4, 2013, 1:13 p.m.) > > > Review request for qpid, Andrew Stitcher, Alan Conway, and Steve Huston. > > > Description > --- > > Reason being it causes the exception types in the qpidmessaging library to be > lost. > > > This addresses bug QPID-4701. > https://issues.apache.org/jira/browse/QPID-4701 > > > Diffs > - > > /trunk/qpid/cpp/src/CMakeLists.txt 1464148 > > Diff: https://reviews.apache.org/r/10283/diff/ > > > Testing > --- > > Passes previously failing make test on gcc 4.1.2; doesn't break anything on > later gcc. > > > Thanks, > > Gordon Sim > >
[jira] [Closed] (QPID-4692) ACL queue quotas are not updated when auto delete queues are deleted
[ https://issues.apache.org/jira/browse/QPID-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke closed QPID-4692. - r1463649 on trunk r1464535 on 0.22 branch > ACL queue quotas are not updated when auto delete queues are deleted > > > Key: QPID-4692 > URL: https://issues.apache.org/jira/browse/QPID-4692 > Project: Qpid > Issue Type: Bug > Components: C++ Broker >Reporter: Ernest Allen >Assignee: Chuck Rolke > Fix For: 0.22 > > Attachments: bz572567-2.patch > > > When auto delete queues are deleted, the acl quotas are not being > decremented. This can cause a user's quota to fill up. A broker restart is > required to clear the situation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Review Request: Turn of -fvisibility=hidden for gcc 4.1.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10283/ --- Review request for qpid, Andrew Stitcher, Alan Conway, and Steve Huston. Description --- Reason being it causes the exception types in the qpidmessaging library to be lost. This addresses bug QPID-4701. https://issues.apache.org/jira/browse/QPID-4701 Diffs - /trunk/qpid/cpp/src/CMakeLists.txt 1464148 Diff: https://reviews.apache.org/r/10283/diff/ Testing --- Passes previously failing make test on gcc 4.1.2; doesn't break anything on later gcc. Thanks, Gordon Sim
[jira] [Commented] (QPID-4702) cmake build of ssl support does not work on certain platforms
[
https://issues.apache.org/jira/browse/QPID-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622114#comment-13622114
]
Gordon Sim commented on QPID-4702:
--
The following patch has been confirmed to fix the problem where reported, and
does not break platforms on which the issue wasn't observed. It is not however
strictly correct as it involves the libraries being listed twice in the link
command, once before and once after the .o files.
{noformat}
Index: src/ssl.cmake
===
--- src/ssl.cmake (revision 1464148)
+++ src/ssl.cmake (working copy)
@@ -72,6 +72,9 @@
)
add_library (sslcommon SHARED ${sslcommon_SOURCES})
+foreach(f ${NSS_LIBRARIES})
+ target_link_libraries (sslcommon ${f})
+endforeach(f)
target_link_libraries (sslcommon qpidcommon)
set_target_properties (sslcommon PROPERTIES
VERSION ${sslcommon_version}
{noformat}
> cmake build of ssl support does not work on certain platforms
> -
>
> Key: QPID-4702
> URL: https://issues.apache.org/jira/browse/QPID-4702
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
>Affects Versions: 0.20, 0.22
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>
> This is a result of the order of libraries and object files passed to the
> linker. The libraries must follow the .o files that require them or they will
> be ignored (assumed not needed).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-4702) cmake build of ssl support does not work on certain platforms
Gordon Sim created QPID-4702: Summary: cmake build of ssl support does not work on certain platforms Key: QPID-4702 URL: https://issues.apache.org/jira/browse/QPID-4702 Project: Qpid Issue Type: Bug Components: C++ Broker, C++ Client Affects Versions: 0.20, 0.22 Reporter: Gordon Sim Assignee: Gordon Sim This is a result of the order of libraries and object files passed to the linker. The libraries must follow the .o files that require them or they will be ignored (assumed not needed). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-4701) Exception types lost in qpidmessaging when compiling with cmake and gcc 4.1.2 (e.g. RHEL5)
Gordon Sim created QPID-4701: Summary: Exception types lost in qpidmessaging when compiling with cmake and gcc 4.1.2 (e.g. RHEL5) Key: QPID-4701 URL: https://issues.apache.org/jira/browse/QPID-4701 Project: Qpid Issue Type: Bug Components: C++ Client Affects Versions: 0.20, 0.22 Reporter: Gordon Sim Assignee: Gordon Sim Exceptions are thrown simply as std::exception rather than the specific types defined. This appears to be a result of the visibility flag support in the version of gcc (cmake turns that on, autotools does not). (See also QPID-4484) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4696) [Java Broker] QPID-4461 review changes
[
https://issues.apache.org/jira/browse/QPID-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622098#comment-13622098
]
Alex Rudyy commented on QPID-4696:
--
The changes in revisions r1464115 and r1464362 were merged into 0.22 branch in
revision http://svn.apache.org/r1464498
> [Java Broker] QPID-4461 review changes
> --
>
> Key: QPID-4696
> URL: https://issues.apache.org/jira/browse/QPID-4696
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: 0.21
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.23
>
>
> JIRA to perfom review changes from QPID-4661. The initial changes are already
> on the 0.22 branch, whereas these are currently going to go on trunk/0.23.
> Creating new JRIA as a holder in case they remain in 0.23/0.24 only.
> # On the attribute editing screen, the attributes are scattered in a
> completely different order than the viewing screen. Should probably be
> grouped similarly to the viewing screen.
> # We should show the units of the setting (where appropriate) as part of its
> 'pretty printing' text.
> # I think we can now remove GroupPrincipalAccessor now that it is being
> created all the time and not up-front, it is just holding a collection and
> then being thrown away, i.e not doing anything useful.
> # We should be able to set the flow control attributes independently of each
> other, it is not required that you change both at the same time. The only
> restriction is that the flow control size can’t be less than the flow resume
> size.
> # DEFAULT_GROUP_PROFIDER_NAME typo
> # Dont these changes all occur on the config thread? If so we shouldn't need
> to comment on thread safety as there is only one thread involved.
> BrokerAdapter:"// the calls below are not thread safe but they should
> be fine in a management mode"
> SecurityManager:
> "// the code below is not thread safe, however, it should be fine in a
> management mode
> +// as there will be no user connected"
> # This isn't particularly safe since it removes the old stuff before putting
> the new stuff in place, leaving a gap.
> {code}
> +if (oldAttributeValue != null)
> +{
> +List pluginNames =
> _aclConfigurationToPluginNamesMapping.remove(oldAttributeValue);
> +if (pluginNames != null)
> +{
> +for (String name : pluginNames)
> +{
> +_hostPlugins.remove(name);
> +}
> +}
> +}
> +if (newAttributeValue != null)
> +{
> +configureACLPlugin((String)newAttributeValue);
> +}
> +_immediatePublishPropsCache.clear();
> +_publishPropsCache.clear();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4678) [Java Broker] add ACL to restrict new support for broker-level configuration through the management interface
[ https://issues.apache.org/jira/browse/QPID-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622094#comment-13622094 ] Alex Rudyy commented on QPID-4678: -- The changes in revision r1463934 were applied to 0.22 branch in revision http://svn.apache.org/r1464494 > [Java Broker] add ACL to restrict new support for broker-level configuration > through the management interface > - > > Key: QPID-4678 > URL: https://issues.apache.org/jira/browse/QPID-4678 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.21 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Blocker > Fix For: 0.22 > > > Recent changes have introduced functionality to configure the broker more > extensively through the REST interface. E.g configuring the broker attributes > for things like the ACL file, group file, ssl settings, and also > adding/removing/editing things like virtualhosts, ports ,authentication > providers, etc. > ACL options needs to be added to ensure this functionality can be locked down. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4695) [Java Broker] Add configured object name and id validation to prevent the submission of invalid names and changing of IDs
[ https://issues.apache.org/jira/browse/QPID-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622091#comment-13622091 ] Alex Rudyy commented on QPID-4695: -- Merged into 0.22 branch in revision http://svn.apache.org/r1464489 > [Java Broker] Add configured object name and id validation to prevent the > submission of invalid names and changing of IDs > - > > Key: QPID-4695 > URL: https://issues.apache.org/jira/browse/QPID-4695 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.20, 0.22, 0.23 >Reporter: Alex Rudyy >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.23 > > > Add configured broker name and id validation to prevent the submission of > invalid names and changing of IDs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
More requests for inclusion into 0.22 release
Hi Justin, Could you please approve the inclusion of the following into 0.22 release: JIRA:https://issues.apache.org/jira/browse/QPID-4699 Commit:http://svn.apache.org/r1464493 Description: With the INSTALL instructions in /cpp the "Building from a Source Distribution" instructions are fairly near the bottom. I kind of see the logic of that since the earlier sections are describing prerequisites, but I wonder if it's worth moving the main install bit closer to the top with a line that says something like "If you have not installed qpid previously see prerequisites below". Similarly section "2.2.2. From Source" might be better in the prerequisites section rather than the install section, I think that's particularly worthwhile now because 2.2.2 is talking about an automake build for the dependencies and the qpid install is now cmake. I know that I did a double take when I skimmed through and assumed that the instructions hadn't been updated for cmake until I read again. Reviewed by: Alan Conway, Robbie Gemmell, Steve Huston Best Regards, Frase - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4691) [Java Broker] update web UI handling of SSL attributes and make the broker validate port attributes more closely to avoid illegal configurations which prevent start-up
[ https://issues.apache.org/jira/browse/QPID-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622089#comment-13622089 ] Alex Rudyy commented on QPID-4691: -- Merged into 0.22 branch in revision http://svn.apache.org/r1464485 > [Java Broker] update web UI handling of SSL attributes and make the broker > validate port attributes more closely to avoid illegal configurations which > prevent start-up > --- > > Key: QPID-4691 > URL: https://issues.apache.org/jira/browse/QPID-4691 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.21, 0.22 >Reporter: Alex Rudyy >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.23 > > > On setting of broker attributes the keystore/trustore/peerstore attributes > only validated when path is changed. As result, when password or alias is > changed no validation happens and invalid values can be stored. > On setting of port attributes only attribute types are validated. As result > if SSL port is configured without keystore or need/wantClientAuthorisation. > attributes are set without truststore the following broker start fails as > broker cannot bind to SSL port without keystore/truststore accordingly. > The web management port UI should allow the setting of > need/wantClientAuthorisation attributes only when SSL transport is selected. > Broker UI to edit keystore/trustore/perrstore password should not require the > setting of the password every time when path to keystore/trustore/perrstore > is changed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4668) [AMQP 1.0] delivery count not 0 on initial delivery
[ https://issues.apache.org/jira/browse/QPID-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-4668: - Description: (was: regardless of whether they have been previously redelivered or not.) > [AMQP 1.0] delivery count not 0 on initial delivery > - > > Key: QPID-4668 > URL: https://issues.apache.org/jira/browse/QPID-4668 > Project: Qpid > Issue Type: Bug > Components: C++ Broker, C++ Client >Affects Versions: 0.20, 0.22 >Reporter: Gordon Sim >Assignee: Gordon Sim > Fix For: 0.23 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4668) [AMQP 1.0] delivery count not 0 on initial delivery
[ https://issues.apache.org/jira/browse/QPID-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-4668: - Fix Version/s: (was: 0.21) 0.23 Affects Version/s: 0.22 > [AMQP 1.0] delivery count not 0 on initial delivery > - > > Key: QPID-4668 > URL: https://issues.apache.org/jira/browse/QPID-4668 > Project: Qpid > Issue Type: Bug > Components: C++ Broker, C++ Client >Affects Versions: 0.20, 0.22 >Reporter: Gordon Sim >Assignee: Gordon Sim > Fix For: 0.23 > > > regardless of whether they have been previously redelivered or not. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (QPID-4668) Message::getRedelivered() always returns true for messages received over AMQP 1.0
[ https://issues.apache.org/jira/browse/QPID-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reopened QPID-4668: -- The fix here was not correct. The real bug was on the broker not on the client. The broker should send the delivery count as 0 on the first delivery rather than 1. > Message::getRedelivered() always returns true for messages received over AMQP > 1.0 > - > > Key: QPID-4668 > URL: https://issues.apache.org/jira/browse/QPID-4668 > Project: Qpid > Issue Type: Bug > Components: C++ Client >Affects Versions: 0.20 >Reporter: Gordon Sim >Assignee: Gordon Sim > Fix For: 0.21 > > > regardless of whether they have been previously redelivered or not. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4668) [AMQP 1.0] delivery count not 0 on initial delivery
[ https://issues.apache.org/jira/browse/QPID-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-4668: - Component/s: C++ Broker Summary: [AMQP 1.0] delivery count not 0 on initial delivery(was: Message::getRedelivered() always returns true for messages received over AMQP 1.0) > [AMQP 1.0] delivery count not 0 on initial delivery > - > > Key: QPID-4668 > URL: https://issues.apache.org/jira/browse/QPID-4668 > Project: Qpid > Issue Type: Bug > Components: C++ Broker, C++ Client >Affects Versions: 0.20 >Reporter: Gordon Sim >Assignee: Gordon Sim > Fix For: 0.21 > > > regardless of whether they have been previously redelivered or not. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622060#comment-13622060 ] Robbie Gemmell commented on QPID-4676: -- Systest merged to 0.22 branch in: http://svn.apache.org/r1464456 > [Java Broker] SSL Client Authentication with username constructed in the same > way as on C++ broker > -- > > Key: QPID-4676 > URL: https://issues.apache.org/jira/browse/QPID-4676 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: JAkub Scholz >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.22 > > Attachments: QPID-4676.patch, QPID-4676-systest.patch > > > The current versions of both the Java broker and the C++ broker support > EXTERNAL authentication mechanism / SSL Client Authentication. Nevertheless > the implementations are not fully identical. One of the differences is the > way the usernames are constructed for the authenticated connections. > The C++ broker takes the CN of the certificate (+ eventually the domain > components / DCs) and creates a username as @... > In case there are no DCs, only the CN is used. On the other hand, the Java > broker takes the full distinguished name as the username. > Example 1: > DN: CN=person > C++ username: person > Java username: CN=person > Example 2: > DN: CN=person,DC=example,DC=com > C++ username: per...@example.com > Java username: CN=person,DC=example,DC=com > Example 3: > DN: CN=person,DC=example,DC=com,O=My Company Ltd,L=Newbury,ST=Berkshire,C=GB > C++ username: per...@example.com > Java username: CN=person,DC=example,DC=com,O=My Company > Ltd,L=Newbury,ST=Berkshire,C=GB > This difference between C++ and Java broker makes it more complicated to > migrate between the different brokers. Also, the particular implementation in > Java can make it a bit more complicated to use the SSL Client Authentication > in some cases. > Therefore I implemented an enhancement which adds a possibility to the Java > broker to construct the usernames in the same way the C++ broker does. I > added a new configuration attribute "useCNAsUsername" for the > ExternalAuthenticationProvider / Manager which allows switching between the > current DN based usernames and the CN based usernames. By default, the old > behaviour is used. The setting is passed from the > ExternalAuthenticationManager to the ExternalSaslServer, which (in case the > useCNAsUsername is switched ON) constructs the new username and returns it > using the UsernamePrinciple. I also added some unit tests to cover the new > functionality. > It would be great if someone can have a look at the attached patch and > eventually provide me with some review comments. One of the areas where I'm > not entirely sure about the patch is the way it handles the configuration > parameter from the JSON configuration. It is also no entirely clear to me > what is the strategy for naming the parameters - it seems to be kind of a > mixture of short names, long names, lower-case only, camel-case etc. > I didn't added any new systests to cover this feature - I have not really an > idea how to implement them. Especially how to get the authenticated username > once connected. If you point me in some direction, I can have a look at it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4694) [Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on eac
[ https://issues.apache.org/jira/browse/QPID-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622061#comment-13622061 ] Robbie Gemmell commented on QPID-4694: -- merged to 0.22 branch in: http://svn.apache.org/r1464463 > [Java Broker] the JSON config file is not saved after startup until promted > by additional change, which can result in unecessary generation of new IDs > for objects on each startup > -- > > Key: QPID-4694 > URL: https://issues.apache.org/jira/browse/QPID-4694 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Reporter: Robbie Gemmell >Assignee: Alex Rudyy > Fix For: 0.23 > > > The JSON config file is not saved after startup until promted by additional > change, which can result in unecessary generation of new IDs for objects on > each startup. > For example, upon the first startup the initia-config within the broker jar > is written out to disk and then loaded. This prompts generation of IDs for > the objects in the configuration, but does not cause the file to be saved. If > the broker is simply restarted the same generation of IDs occurs. > Similarly, if a user edited the config file and added a new object but did > not specify an ID, one would be generated at each restart until they edited > the config with the broker running and prompted it to save the current ID for > the object. > The config store file should be immediately saved if any Ids are generated > during startup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4695) [Java Broker] Add configured object name and id validation to prevent the submission of invalid names and changing of IDs
[ https://issues.apache.org/jira/browse/QPID-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622004#comment-13622004 ] Justin Ross commented on QPID-4695: --- Reviewed by Robbie. Approved for 0.22. > [Java Broker] Add configured object name and id validation to prevent the > submission of invalid names and changing of IDs > - > > Key: QPID-4695 > URL: https://issues.apache.org/jira/browse/QPID-4695 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.20, 0.22, 0.23 >Reporter: Alex Rudyy >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.23 > > > Add configured broker name and id validation to prevent the submission of > invalid names and changing of IDs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4696) [Java Broker] QPID-4461 review changes
[
https://issues.apache.org/jira/browse/QPID-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622003#comment-13622003
]
Justin Ross commented on QPID-4696:
---
Reviewed by Robbie. Approved for 0.22.
> [Java Broker] QPID-4461 review changes
> --
>
> Key: QPID-4696
> URL: https://issues.apache.org/jira/browse/QPID-4696
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: 0.21
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.23
>
>
> JIRA to perfom review changes from QPID-4661. The initial changes are already
> on the 0.22 branch, whereas these are currently going to go on trunk/0.23.
> Creating new JRIA as a holder in case they remain in 0.23/0.24 only.
> # On the attribute editing screen, the attributes are scattered in a
> completely different order than the viewing screen. Should probably be
> grouped similarly to the viewing screen.
> # We should show the units of the setting (where appropriate) as part of its
> 'pretty printing' text.
> # I think we can now remove GroupPrincipalAccessor now that it is being
> created all the time and not up-front, it is just holding a collection and
> then being thrown away, i.e not doing anything useful.
> # We should be able to set the flow control attributes independently of each
> other, it is not required that you change both at the same time. The only
> restriction is that the flow control size can’t be less than the flow resume
> size.
> # DEFAULT_GROUP_PROFIDER_NAME typo
> # Dont these changes all occur on the config thread? If so we shouldn't need
> to comment on thread safety as there is only one thread involved.
> BrokerAdapter:"// the calls below are not thread safe but they should
> be fine in a management mode"
> SecurityManager:
> "// the code below is not thread safe, however, it should be fine in a
> management mode
> +// as there will be no user connected"
> # This isn't particularly safe since it removes the old stuff before putting
> the new stuff in place, leaving a gap.
> {code}
> +if (oldAttributeValue != null)
> +{
> +List pluginNames =
> _aclConfigurationToPluginNamesMapping.remove(oldAttributeValue);
> +if (pluginNames != null)
> +{
> +for (String name : pluginNames)
> +{
> +_hostPlugins.remove(name);
> +}
> +}
> +}
> +if (newAttributeValue != null)
> +{
> +configureACLPlugin((String)newAttributeValue);
> +}
> +_immediatePublishPropsCache.clear();
> +_publishPropsCache.clear();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4691) [Java Broker] update web UI handling of SSL attributes and make the broker validate port attributes more closely to avoid illegal configurations which prevent start-up
[ https://issues.apache.org/jira/browse/QPID-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621999#comment-13621999 ] Justin Ross commented on QPID-4691: --- Reviewed by Robbie. Approved for 0.22. A note in passing: this issue bundles together a high priority bug fix (scenario where invalid values can be stored) with other improvements. That's not nice from a triage perspective. > [Java Broker] update web UI handling of SSL attributes and make the broker > validate port attributes more closely to avoid illegal configurations which > prevent start-up > --- > > Key: QPID-4691 > URL: https://issues.apache.org/jira/browse/QPID-4691 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.21, 0.22 >Reporter: Alex Rudyy >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.23 > > > On setting of broker attributes the keystore/trustore/peerstore attributes > only validated when path is changed. As result, when password or alias is > changed no validation happens and invalid values can be stored. > On setting of port attributes only attribute types are validated. As result > if SSL port is configured without keystore or need/wantClientAuthorisation. > attributes are set without truststore the following broker start fails as > broker cannot bind to SSL port without keystore/truststore accordingly. > The web management port UI should allow the setting of > need/wantClientAuthorisation attributes only when SSL transport is selected. > Broker UI to edit keystore/trustore/perrstore password should not require the > setting of the password every time when path to keystore/trustore/perrstore > is changed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621988#comment-13621988 ] Justin Ross commented on QPID-4676: --- System tests reviewed by Robbie and approved for 0.22. > [Java Broker] SSL Client Authentication with username constructed in the same > way as on C++ broker > -- > > Key: QPID-4676 > URL: https://issues.apache.org/jira/browse/QPID-4676 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: JAkub Scholz >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.22 > > Attachments: QPID-4676.patch, QPID-4676-systest.patch > > > The current versions of both the Java broker and the C++ broker support > EXTERNAL authentication mechanism / SSL Client Authentication. Nevertheless > the implementations are not fully identical. One of the differences is the > way the usernames are constructed for the authenticated connections. > The C++ broker takes the CN of the certificate (+ eventually the domain > components / DCs) and creates a username as @... > In case there are no DCs, only the CN is used. On the other hand, the Java > broker takes the full distinguished name as the username. > Example 1: > DN: CN=person > C++ username: person > Java username: CN=person > Example 2: > DN: CN=person,DC=example,DC=com > C++ username: per...@example.com > Java username: CN=person,DC=example,DC=com > Example 3: > DN: CN=person,DC=example,DC=com,O=My Company Ltd,L=Newbury,ST=Berkshire,C=GB > C++ username: per...@example.com > Java username: CN=person,DC=example,DC=com,O=My Company > Ltd,L=Newbury,ST=Berkshire,C=GB > This difference between C++ and Java broker makes it more complicated to > migrate between the different brokers. Also, the particular implementation in > Java can make it a bit more complicated to use the SSL Client Authentication > in some cases. > Therefore I implemented an enhancement which adds a possibility to the Java > broker to construct the usernames in the same way the C++ broker does. I > added a new configuration attribute "useCNAsUsername" for the > ExternalAuthenticationProvider / Manager which allows switching between the > current DN based usernames and the CN based usernames. By default, the old > behaviour is used. The setting is passed from the > ExternalAuthenticationManager to the ExternalSaslServer, which (in case the > useCNAsUsername is switched ON) constructs the new username and returns it > using the UsernamePrinciple. I also added some unit tests to cover the new > functionality. > It would be great if someone can have a look at the attached patch and > eventually provide me with some review comments. One of the areas where I'm > not entirely sure about the patch is the way it handles the configuration > parameter from the JSON configuration. It is also no entirely clear to me > what is the strategy for naming the parameters - it seems to be kind of a > mixture of short names, long names, lower-case only, camel-case etc. > I didn't added any new systests to cover this feature - I have not really an > idea how to implement them. Especially how to get the authenticated username > once connected. If you point me in some direction, I can have a look at it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4694) [Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on eac
[ https://issues.apache.org/jira/browse/QPID-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621980#comment-13621980 ] Justin Ross commented on QPID-4694: --- Reviewed by Alex. Approved for 0.22. > [Java Broker] the JSON config file is not saved after startup until promted > by additional change, which can result in unecessary generation of new IDs > for objects on each startup > -- > > Key: QPID-4694 > URL: https://issues.apache.org/jira/browse/QPID-4694 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Reporter: Robbie Gemmell >Assignee: Alex Rudyy > Fix For: 0.23 > > > The JSON config file is not saved after startup until promted by additional > change, which can result in unecessary generation of new IDs for objects on > each startup. > For example, upon the first startup the initia-config within the broker jar > is written out to disk and then loaded. This prompts generation of IDs for > the objects in the configuration, but does not cause the file to be saved. If > the broker is simply restarted the same generation of IDs occurs. > Similarly, if a user edited the config file and added a new object but did > not specify an ID, one would be generated at each restart until they edited > the config with the broker running and prompted it to save the current ID for > the object. > The config store file should be immediately saved if any Ids are generated > during startup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4678) [Java Broker] add ACL to restrict new support for broker-level configuration through the management interface
[ https://issues.apache.org/jira/browse/QPID-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621976#comment-13621976 ] Justin Ross commented on QPID-4678: --- Reviewed by Robbie. Approved for 0.22. > [Java Broker] add ACL to restrict new support for broker-level configuration > through the management interface > - > > Key: QPID-4678 > URL: https://issues.apache.org/jira/browse/QPID-4678 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.21 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Blocker > Fix For: 0.22 > > > Recent changes have introduced functionality to configure the broker more > extensively through the REST interface. E.g configuring the broker attributes > for things like the ACL file, group file, ssl settings, and also > adding/removing/editing things like virtualhosts, ports ,authentication > providers, etc. > ACL options needs to be added to ensure this functionality can be locked down. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4692) ACL queue quotas are not updated when auto delete queues are deleted
[ https://issues.apache.org/jira/browse/QPID-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621973#comment-13621973 ] Justin Ross commented on QPID-4692: --- Reviewed by Chuck. Approved for 0.22. > ACL queue quotas are not updated when auto delete queues are deleted > > > Key: QPID-4692 > URL: https://issues.apache.org/jira/browse/QPID-4692 > Project: Qpid > Issue Type: Bug > Components: C++ Broker >Reporter: Ernest Allen >Assignee: Chuck Rolke > Fix For: 0.22 > > Attachments: bz572567-2.patch > > > When auto delete queues are deleted, the acl quotas are not being > decremented. This can cause a user's quota to fill up. A broker restart is > required to clear the situation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-4700) [AMQP 1.0] 'to' field incorrectly mapped on to 'x-amqp-delivery-count' property
[ https://issues.apache.org/jira/browse/QPID-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-4700. -- Resolution: Fixed Fix Version/s: 0.22 > [AMQP 1.0] 'to' field incorrectly mapped on to 'x-amqp-delivery-count' > property > --- > > Key: QPID-4700 > URL: https://issues.apache.org/jira/browse/QPID-4700 > Project: Qpid > Issue Type: Bug > Components: C++ Client >Affects Versions: 0.20 >Reporter: Gordon Sim >Assignee: Gordon Sim > Fix For: 0.22 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4700) [AMQP 1.0] 'to' field incorrectly mapped on to 'x-amqp-delivery-count' property
[ https://issues.apache.org/jira/browse/QPID-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621936#comment-13621936 ] Gordon Sim commented on QPID-4700: -- Merged to 0.22: http://svn.apache.org/viewvc?view=revision&revision=1464358 > [AMQP 1.0] 'to' field incorrectly mapped on to 'x-amqp-delivery-count' > property > --- > > Key: QPID-4700 > URL: https://issues.apache.org/jira/browse/QPID-4700 > Project: Qpid > Issue Type: Bug > Components: C++ Client >Affects Versions: 0.20 >Reporter: Gordon Sim >Assignee: Gordon Sim > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
