[jira] [Commented] (QPID-5709) [Java Broker] Remove ExchangeFactory/ExchangeRegistry and use common replacement mechanism for recovery/construction of exchanges
[ https://issues.apache.org/jira/browse/QPID-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977556#comment-13977556 ] Keith Wall commented on QPID-5709: -- Hi Rob I have reviewed commit r1588126. A couple of comments. # New method DirectExchange.BindingSet#updateBinding has an unused argument. # TopicExchange#onBindingUpdated - debug message incorrect # TopicExchange# method level synchronised used inconsistently to guard _bindings. The _binding map check then get (line 95) could lead to unexpected results. Separately, I notice that: # DefaultQueueRegistry and interface QueueRegistry is now dead code > [Java Broker] Remove ExchangeFactory/ExchangeRegistry and use common > replacement mechanism for recovery/construction of exchanges > - > > Key: QPID-5709 > URL: https://issues.apache.org/jira/browse/QPID-5709 > Project: Qpid > Issue Type: Sub-task > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > > The virtualhost itself should act as the registry for its children. Exchange > factories should be replaced by the new mechanism which is common to all > configured objects -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5711) HA cannot promote primary if SASL security is enabled.
[ https://issues.apache.org/jira/browse/QPID-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977528#comment-13977528 ] Alan Conway commented on QPID-5711: --- Patch for review at https://reviews.apache.org/r/20579/ Request inclusion in 0.28 > HA cannot promote primary if SASL security is enabled. > -- > > Key: QPID-5711 > URL: https://issues.apache.org/jira/browse/QPID-5711 > Project: Qpid > Issue Type: Bug > Components: C++ Clustering >Affects Versions: 0.28 >Reporter: Alan Conway >Assignee: Alan Conway > > Reported on qpid-user list: > Yes, I have the cyrus packages installed on the nodes. > # rpm -qa | grep cyrus > cyrus-sasl-plain-2.1.23-13.el6_3.1.x86_64 > cyrus-sasl-lib-2.1.23-13.el6_3.1.x86_64 > cyrus-sasl-md5-2.1.23-13.el6_3.1.x86_64 > cyrus-sasl-gssapi-2.1.23-13.el6_3.1.x86_64 > cyrus-sasl-devel-2.1.23-13.el6_3.1.x86_64 > cyrus-sasl-2.1.23-13.el6_3.1.x86_64 > To narrow down, I've simplified the configuration without HA, see below > ===configuration=== > i) version 0.26 (built from source) > ii) /etc/qpid/qpidd.conf > acl-file=/etc/qpid/qpidd.acl > auth=yes > realm=QPID > no-data-dir=yes > sasl-config=/etc/sasl2/ > log-to-stderr=no > log-enable=debug+ > log-to-syslog=yes > # /etc/init.d/qpidd start > Starting Qpid AMQP daemon: [ OK ] > # qpid-config queues -a test/test@192.168.10.211:5672 --sasl-mechanism=PLAIN > Queue NameAttributes > = > 5b1b0c2e-bc6f-431b-b955-83ce5680d4ac:0.0 auto-del excl > and things work as expected. However when I enable HA and when the > brokers try to communicate among themselves > I get the following error. > ===error=== > Promoting qpid daemon to cluster primary: Error in sasl_client_start > (-4) SASL(-4): no mechanism available: No worthy mechs found > See also: https://bugzilla.redhat.com/show_bug.cgi?id=1089353 -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
RFI 0.28: QPID-5711: HA cannot promote primary if SASL security is enabled.
Patch for review at https://reviews.apache.org/r/20579/ - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Review Request 20579: QPID-5711: HA cannot promote primary if SASL security is enabled.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20579/ --- Review request for qpid, Gordon Sim and Justin Ross. Repository: qpid Description --- RFI 0.28: QPID-5711: HA cannot promote primary if SASL security is enabled. Updated the qpid-ha tool and qpidd init scripts to handle SASL authentication. The qpid-ha script as as called by the qpidd-primary init script now reads authentication settings from the qpidd.conf file and uses them to connect to the local broker. - qpidd-primary script respects prefix: use installed location for qpidd script, not "service" call - qpid-ha added --config option qpid-ha options to use qpidd.conf for local broker connection. - qpid-ha --all use user/pass for each broker. Diffs - /trunk/qpid/cpp/etc/CMakeLists.txt 1588468 /trunk/qpid/cpp/etc/qpidd-primary.in 1588468 /trunk/qpid/cpp/etc/qpidd.in 1588468 /trunk/qpid/tools/src/py/qpid-ha 1588468 /trunk/qpid/tools/src/py/qpidtoollibs/config.py PRE-CREATION Diff: https://reviews.apache.org/r/20579/diff/ Testing --- Tested on a security-enabled 3 node cluster. No automated tests added. Running full ctest. Thanks, Alan Conway
[jira] [Commented] (QPID-5663) [C++ Messaging] Windows AMQP 1.0 map_receiver fails freeing uninitialized string Variant
[
https://issues.apache.org/jira/browse/QPID-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977189#comment-13977189
]
ASF subversion and git services commented on QPID-5663:
---
Commit 1589249 from c...@apache.org in branch 'qpid/branches/0.28'
[ https://svn.apache.org/r1589249 ]
QPID-5663: [C++ Messaging] Windows AMQP 1.0 map_receiver fails - merge fix to
0.28 branch
> [C++ Messaging] Windows AMQP 1.0 map_receiver fails freeing uninitialized
> string Variant
>
>
> Key: QPID-5663
> URL: https://issues.apache.org/jira/browse/QPID-5663
> Project: Qpid
> Issue Type: Bug
> Components: C++ Client
>Affects Versions: 0.29
> Environment: Windows x86 build on x64 host. Visual Studio 2010
>Reporter: Chuck Rolke
> Attachments: qpid-5663-stack-00.txt
>
>
> Running map_receiver with AMQP 1.0 fails straight away with a free of as
> string at 0xfeeefeee.
> {noformat}
> map_sender localhost:5672 "message_queue; {create: always}"
> "{protocol:amqp1.0}"
> map_receiver localhost:5672 "message_queue; {create: always}"
> "{protocol:amqp1.0}"
> {noformat}
> These work indefinitely running amqp0-10. map_sender is fine running either
> protocol version.
> Stack trace is posted as separate file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5663) [C++ Messaging] Windows AMQP 1.0 map_receiver fails freeing uninitialized string Variant
[
https://issues.apache.org/jira/browse/QPID-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977148#comment-13977148
]
ASF subversion and git services commented on QPID-5663:
---
Commit 1589222 from c...@apache.org in branch 'qpid/trunk'
[ https://svn.apache.org/r1589222 ]
QPID-5663: [C++ Messaging] Windows AMQP 1.0 map_receiver fails
Updated patch from Gordon Sim.
> [C++ Messaging] Windows AMQP 1.0 map_receiver fails freeing uninitialized
> string Variant
>
>
> Key: QPID-5663
> URL: https://issues.apache.org/jira/browse/QPID-5663
> Project: Qpid
> Issue Type: Bug
> Components: C++ Client
>Affects Versions: 0.29
> Environment: Windows x86 build on x64 host. Visual Studio 2010
>Reporter: Chuck Rolke
> Attachments: qpid-5663-stack-00.txt
>
>
> Running map_receiver with AMQP 1.0 fails straight away with a free of as
> string at 0xfeeefeee.
> {noformat}
> map_sender localhost:5672 "message_queue; {create: always}"
> "{protocol:amqp1.0}"
> map_receiver localhost:5672 "message_queue; {create: always}"
> "{protocol:amqp1.0}"
> {noformat}
> These work indefinitely running amqp0-10. map_sender is fine running either
> protocol version.
> Stack trace is posted as separate file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5696) perl qpid client's qpid::messaging::Message() does not handle properly floats (non-quoted) in message properties
[
https://issues.apache.org/jira/browse/QPID-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977110#comment-13977110
]
Justin Ross commented on QPID-5696:
---
Reviewed by Alan. Approved for 0.28.
> perl qpid client's qpid::messaging::Message() does not handle properly floats
> (non-quoted) in message properties
>
>
> Key: QPID-5696
> URL: https://issues.apache.org/jira/browse/QPID-5696
> Project: Qpid
> Issue Type: Bug
> Components: Perl Client
>Affects Versions: 0.26
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: Future
>
>
> perl qpid client's qpid::messaging::Message() does not handle properly
> non-quoted floats in message properties.
> Let's have following snippet:
> # cat /tmp/a.pl
> use qpid;
> use Time::HiRes qw( time sleep );
> use Data::Dumper;
> # get_time()
> # get precise time since epoch as float [ ~ time.time()]
> sub get_time {
> return ( time() );
> }
> my $message = new qpid::messaging::Message();
> my $time = get_time();
> $message->set_property('ts-float', $time);
> $message->set_property('ts-int',4);
> $message->set_property('ts-nint', -4);
> $message->set_property('ts-str', "4.556");
> print $time;
> print "\n";
> print $message->get_properties();
> print "\n";
> print Dumper($message->get_properties());
> print "\n";
> print $message->get_properties()->{"ts-float"};
> print "\n";
> exit
> When executed you can see ts-float' hash value is not carried properly.
> # perl -W /tmp/a.pl
> 1397412379.47217
> HASH(0x1c03720)
> $VAR1 = {
> 'ts-int' => 4,
> 'ts-str' => '4.556',
> 'ts-nint' => -4,
> 'ts-float' => '1397412352'
> };
> 1397412352
> Float value is read back as int which is incorrect.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-16) update pom file to use the new qpid-parent
[ https://issues.apache.org/jira/browse/QPIDJMS-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976980#comment-13976980 ] ASF subversion and git services commented on QPIDJMS-16: Commit 1589192 from [~gemmellr] in branch 'jms/trunk' [ https://svn.apache.org/r1589192 ] QPIDJMS-16: update to use the current qpid-parent snapshot, which will need to be locally installed in the mean time > update pom file to use the new qpid-parent > -- > > Key: QPIDJMS-16 > URL: https://issues.apache.org/jira/browse/QPIDJMS-16 > Project: Qpid JMS > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > > We are in the process of introducing the qpid-parent pom, the build should be > updated to use it to ensure all is well prior to the initial release of > qpid-parent. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5048) [Java] Implement a Maven 3 build system
[ https://issues.apache.org/jira/browse/QPID-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976977#comment-13976977 ] ASF subversion and git services commented on QPID-5048: --- Commit 1589191 from [~gemmellr] in branch 'pom/trunk' [ https://svn.apache.org/r1589191 ] QPID-5048,QPIDJMS-16: add hamcrest-version property and a plugin-management entry for the findbugs plugin > [Java] Implement a Maven 3 build system > > > Key: QPID-5048 > URL: https://issues.apache.org/jira/browse/QPID-5048 > Project: Qpid > Issue Type: Task > Components: Build Tools >Reporter: Rob Godfrey >Assignee: Robbie Gemmell > Attachments: > 0001-NO-JIRA-fix-to-resolve-potential-parse-error-in-Abst.patch, > 0001-QPID-5048-Maven-POM-refactoring-names-descriptions-d.patch, > 0001-QPID-5048-Maven-enahancements-to-remove-child-versio.patch, > 0001-QPID-5048-Maven-enahancements-to-restructure-POM-hie.patch, > 0001-QPID-5048-Moved-slf4j-deps-to-test-utils-to-workarou.patch, > 0001-QPID-5048-added-basic-cpp-broker-test-profile.patch, > 0001-QPID-5048-changes-get-perf-tests-running-again.patch, > 0001-QPID-5048-dby-profiles-bdb-test-deps-and-config-for-.patch, > 0001-QPID-5048-maven-license-plugin-optimisation-enhanced.patch, > 0001-QPID-5048-modified-deployment-plugin-config-so-only-.patch, > 0001-QPID-5048-new-maven-enforcer-plugin-rule-for-checkin.patch, > 0001-QPID-5048-parent-pom-changes-for-release-license-and.patch, > 0001-QPID-5048-split-out-systests-from-perftests-and-add-.patch, > 0001-QPID-5048-surefire-site-coverage-and-jxr-config.patch, > 0001-QPID-5048-update-qpid-parent-pom-to-inherit-from-lat.patch, > 0001-QPID-5048-update-qpid-parent-pom-to-remove-dependenc.patch, > 0002-QPID-5048-Logging-dependency-and-configuration-tidy-.patch, > 0002-QPID-5048-added-dependency-license-reference-checkin.patch, > 0002-QPID-5048-re-instate-dependency-versions-after-qpid-.patch, > 0003-QPID-5048-logging-and-build-output-cleanup.patch, > QPID-5048-maven-qpid-parent-changes.diff > > > Implement a Maven build system which generates the same artefacts as the > current ant based build. > See: https://cwiki.apache.org/confluence/display/qpid/Java+Build+System > TO DO > - Fix what the systests/perftests do to copy the test-profiles dir to the > necessary location. > - Test deploying the modules to a local Nexus instance (by overriding the > repo properties locally). > - Ensure we dont deploy modules we aren't already doing so, it will make > changing them later less of a pain for everyone. > - Align the XML in the pom files consistently, fix whitepsace errors. > - improve the performance hit from using the license plugin > - check that perf-tests actually needs the unpacked broker for running non > spawn profiles and remove if not > - remove the child module version to let them inherit from java parent > - check the bcel bundle dependancy exclusions are still required > === Once the Ant build is removed === > - Move all the resources to be in the /src/foo/resources folders. > - Make qpidversion.properties in common be a filtered resource instead of > generated. > - Get rid of the antrun-plugin execution in common, directly invoke the > required java elements. > - Do the above in the generate-sources-common profile instead of current > default config. > - Get rid of the antrun-plugin execution in broker-core, directly invoke the > required java elements. > - Fix the tests not to be dependant on the working dir being the java dir. > - Fix the tests not to be dependant on the test config/output dirs being > children of qpid.home. > - Remove the QBTC output file mechanics, rely on Surefire to do it? > - JUnit test profiles instead of Exludes files? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-16) update pom file to use the new qpid-parent
[ https://issues.apache.org/jira/browse/QPIDJMS-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976978#comment-13976978 ] ASF subversion and git services commented on QPIDJMS-16: Commit 1589191 from [~gemmellr] in branch 'pom/trunk' [ https://svn.apache.org/r1589191 ] QPID-5048,QPIDJMS-16: add hamcrest-version property and a plugin-management entry for the findbugs plugin > update pom file to use the new qpid-parent > -- > > Key: QPIDJMS-16 > URL: https://issues.apache.org/jira/browse/QPIDJMS-16 > Project: Qpid JMS > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > > We are in the process of introducing the qpid-parent pom, the build should be > updated to use it to ensure all is well prior to the initial release of > qpid-parent. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-16) update pom file to use the new qpid-parent
Robbie Gemmell created QPIDJMS-16: - Summary: update pom file to use the new qpid-parent Key: QPIDJMS-16 URL: https://issues.apache.org/jira/browse/QPIDJMS-16 Project: Qpid JMS Issue Type: Task Reporter: Robbie Gemmell Assignee: Robbie Gemmell We are in the process of introducing the qpid-parent pom, the build should be updated to use it to ensure all is well prior to the initial release of qpid-parent. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5610) implement a Maven 3 build for the Java QMF tools and GUI
[ https://issues.apache.org/jira/browse/QPID-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976944#comment-13976944 ] ASF subversion and git services commented on QPID-5610: --- Commit 1589181 from [~gemmellr] in branch 'qpid/branches/QPID-5610-maven3-build-qmf-tools' [ https://svn.apache.org/r1589181 ] QPID-5610: update poms to account for recent qpid-parent changes > implement a Maven 3 build for the Java QMF tools and GUI > > > Key: QPID-5610 > URL: https://issues.apache.org/jira/browse/QPID-5610 > Project: Qpid > Issue Type: Improvement > Components: Tools >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.29 > > > The work being done in QPID-5048 will add an initial Maven 3 build for the > components in the current main java tree, subsequent to which we will look to > split the tree apart to become more component oriented. > As part of the overall process we will also look to implement a Maven 3 build > for the Java QMF tools, since these depend on e.g the Java client or the Java > broker and currently utilise the output of their existing Ant build. In > addition to adopting the new builds for the other components, this will > additionally allow deploying them to Maven Central and make it easier to keep > the QMF tools functioning. > This will be a more involved process for the QMF tools than those in > QPID-5048, requiring layout changes to adopt a suitable structure in the > repository around which to create the new build. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5702) upgrade JUnit version from 3.8.1 to 4.11
[ https://issues.apache.org/jira/browse/QPID-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-5702: - Description: Update the JUnit dependency version (in both ANT and Maven) from 3.8.1 to 4.11 and also resolve the obvious warnings for use of deprecated packages and APIs. Note this only updates the dependency and makes minimal changes to imports to avoid deprecation warnings, it does not move the existing test cases to the newer JUnit 4 style test process driven via annotations, that is a bigger change for a later time. was:Update the junit dependency version (in both ANT and Maven) from 3.8.1 to 4.11 and also resolve the obvious warnings for use of deprecated packages and APIs. > upgrade JUnit version from 3.8.1 to 4.11 > > > Key: QPID-5702 > URL: https://issues.apache.org/jira/browse/QPID-5702 > Project: Qpid > Issue Type: Improvement > Components: Build Tools >Affects Versions: 0.26 >Reporter: Andrew MacBean >Assignee: Robbie Gemmell > Fix For: Future > > Attachments: 0002-QPID-5702-Upgrade-Junit-version-from-3-to-4.patch, > QPID-5702.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Update the JUnit dependency version (in both ANT and Maven) from 3.8.1 to > 4.11 and also resolve the obvious warnings for use of deprecated packages and > APIs. > Note this only updates the dependency and makes minimal changes to imports to > avoid deprecation warnings, it does not move the existing test cases to the > newer JUnit 4 style test process driven via annotations, that is a bigger > change for a later time. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5702) upgrade JUnit version from 3.8.1 to 4.11
[ https://issues.apache.org/jira/browse/QPID-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-5702: - Description: Update the JUnit dependency version (in both ANT and Maven) from 3.8.1 to 4.11 and also resolve the obvious warnings for use of deprecated packages and APIs. *Note:* this only updates the dependency and makes minimal changes to imports to avoid deprecation warnings, it does not move the existing test cases to the newer JUnit 4 style test process driven via annotations, that is a bigger change for a later time. was: Update the JUnit dependency version (in both ANT and Maven) from 3.8.1 to 4.11 and also resolve the obvious warnings for use of deprecated packages and APIs. Note this only updates the dependency and makes minimal changes to imports to avoid deprecation warnings, it does not move the existing test cases to the newer JUnit 4 style test process driven via annotations, that is a bigger change for a later time. > upgrade JUnit version from 3.8.1 to 4.11 > > > Key: QPID-5702 > URL: https://issues.apache.org/jira/browse/QPID-5702 > Project: Qpid > Issue Type: Improvement > Components: Build Tools >Affects Versions: 0.26 >Reporter: Andrew MacBean >Assignee: Robbie Gemmell > Fix For: Future > > Attachments: 0002-QPID-5702-Upgrade-Junit-version-from-3-to-4.patch, > QPID-5702.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Update the JUnit dependency version (in both ANT and Maven) from 3.8.1 to > 4.11 and also resolve the obvious warnings for use of deprecated packages and > APIs. > *Note:* this only updates the dependency and makes minimal changes to imports > to avoid deprecation warnings, it does not move the existing test cases to > the newer JUnit 4 style test process driven via annotations, that is a bigger > change for a later time. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5702) upgrade JUnit version from 3.8.1 to 4.11
[ https://issues.apache.org/jira/browse/QPID-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976858#comment-13976858 ] ASF subversion and git services commented on QPID-5702: --- Commit 1589144 from [~gemmellr] in branch 'qpid/trunk' [ https://svn.apache.org/r1589144 ] QPID-5702: upgrade JUnit dependency from version 3.8.1 to 4.11, change imports etc to remove deprecation notices Patch Supplied by Andrew MacBean . > upgrade JUnit version from 3.8.1 to 4.11 > > > Key: QPID-5702 > URL: https://issues.apache.org/jira/browse/QPID-5702 > Project: Qpid > Issue Type: Improvement > Components: Build Tools >Affects Versions: 0.26 >Reporter: Andrew MacBean >Assignee: Robbie Gemmell > Fix For: Future > > Attachments: 0002-QPID-5702-Upgrade-Junit-version-from-3-to-4.patch, > QPID-5702.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Update the junit dependency version (in both ANT and Maven) from 3.8.1 to > 4.11 and also resolve the obvious warnings for use of deprecated packages and > APIs. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5696) perl qpid client's qpid::messaging::Message() does not handle properly floats (non-quoted) in message properties
[
https://issues.apache.org/jira/browse/QPID-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976862#comment-13976862
]
Alan Conway commented on QPID-5696:
---
Reviewed for 0.28, looks good to me.
> perl qpid client's qpid::messaging::Message() does not handle properly floats
> (non-quoted) in message properties
>
>
> Key: QPID-5696
> URL: https://issues.apache.org/jira/browse/QPID-5696
> Project: Qpid
> Issue Type: Bug
> Components: Perl Client
>Affects Versions: 0.26
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: Future
>
>
> perl qpid client's qpid::messaging::Message() does not handle properly
> non-quoted floats in message properties.
> Let's have following snippet:
> # cat /tmp/a.pl
> use qpid;
> use Time::HiRes qw( time sleep );
> use Data::Dumper;
> # get_time()
> # get precise time since epoch as float [ ~ time.time()]
> sub get_time {
> return ( time() );
> }
> my $message = new qpid::messaging::Message();
> my $time = get_time();
> $message->set_property('ts-float', $time);
> $message->set_property('ts-int',4);
> $message->set_property('ts-nint', -4);
> $message->set_property('ts-str', "4.556");
> print $time;
> print "\n";
> print $message->get_properties();
> print "\n";
> print Dumper($message->get_properties());
> print "\n";
> print $message->get_properties()->{"ts-float"};
> print "\n";
> exit
> When executed you can see ts-float' hash value is not carried properly.
> # perl -W /tmp/a.pl
> 1397412379.47217
> HASH(0x1c03720)
> $VAR1 = {
> 'ts-int' => 4,
> 'ts-str' => '4.556',
> 'ts-nint' => -4,
> 'ts-float' => '1397412352'
> };
> 1397412352
> Float value is read back as int which is incorrect.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5702) upgrade JUnit version from 3.8.1 to 4.11
[ https://issues.apache.org/jira/browse/QPID-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-5702: - Summary: upgrade JUnit version from 3.8.1 to 4.11 (was: Upgrade Junit version from 3 to 4) > upgrade JUnit version from 3.8.1 to 4.11 > > > Key: QPID-5702 > URL: https://issues.apache.org/jira/browse/QPID-5702 > Project: Qpid > Issue Type: Improvement > Components: Build Tools >Affects Versions: 0.26 >Reporter: Andrew MacBean >Assignee: Robbie Gemmell > Fix For: Future > > Attachments: 0002-QPID-5702-Upgrade-Junit-version-from-3-to-4.patch, > QPID-5702.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Update the junit dependency version (in both ANT and Maven) from 3.8.1 to > 4.11 and also resolve the obvious warnings for use of deprecated packages and > APIs. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5702) Upgrade Junit version from 3 to 4
[ https://issues.apache.org/jira/browse/QPID-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976854#comment-13976854 ] ASF subversion and git services commented on QPID-5702: --- Commit 1589143 from [~gemmellr] in branch 'qpid/trunk' [ https://svn.apache.org/r1589143 ] QPID-5702: remove override from pom to inherit parent property specifying junit 4.11 > Upgrade Junit version from 3 to 4 > - > > Key: QPID-5702 > URL: https://issues.apache.org/jira/browse/QPID-5702 > Project: Qpid > Issue Type: Improvement > Components: Build Tools >Affects Versions: 0.26 >Reporter: Andrew MacBean >Assignee: Robbie Gemmell > Fix For: Future > > Attachments: 0002-QPID-5702-Upgrade-Junit-version-from-3-to-4.patch, > QPID-5702.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Update the junit dependency version (in both ANT and Maven) from 3.8.1 to > 4.11 and also resolve the obvious warnings for use of deprecated packages and > APIs. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5715) [Java Broker] Introduce VirtualHostNode into model
[ https://issues.apache.org/jira/browse/QPID-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976693#comment-13976693 ] ASF subversion and git services commented on QPID-5715: --- Commit 1589112 from [~k-wall] in branch 'qpid/trunk' [ https://svn.apache.org/r1589112 ] QPID-5715: [Java Broker] Refactor VirtualHostStoreUpgraderAndRecoverer/BrokerStoreUpgrader to avoid duplicated code > [Java Broker] Introduce VirtualHostNode into model > -- > > Key: QPID-5715 > URL: https://issues.apache.org/jira/browse/QPID-5715 > Project: Qpid > Issue Type: Sub-task > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > > In order to support the HA use-case, a new object, VirtualHostNode will be > added into the Broker model. The Broker will support zero or more virtual > host nodes. Each virtual host node may have zero or one virtual hosts. > Virtualhostnode will be responsible for > * the lifecycle of the durable configuration store > * the recovery of its children (that is, the virtual host and its object > descendants (exchanges, queues etc) but not messages/message instances etc). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5663) [C++ Messaging] Windows AMQP 1.0 map_receiver fails freeing uninitialized string Variant
[
https://issues.apache.org/jira/browse/QPID-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976663#comment-13976663
]
Gordon Sim commented on QPID-5663:
--
Sorry, my approval above was too hasty! This change appears to break the
interlink tests on linux. I didn't read the change properly and missed an
important - and I believe incorrect - change to the use of 'new' for the
Variant::Map passed in. That returns a pointer to the map, which is then going
through some non-obvious conversion chain in the initialisation of the
DataBuilder constructors only arg. I suggest the following change:
{noformat}
Index: src/qpid/messaging/amqp/EncodedMessage.cpp
===
--- src/qpid/messaging/amqp/EncodedMessage.cpp (revision 1588966)
+++ src/qpid/messaging/amqp/EncodedMessage.cpp (working copy)
@@ -229,7 +229,8 @@
c = builder.getList();
raw.assign(body.data, body.size);
} else if (bodyType == qpid::amqp::typecodes::MAP_NAME) {
-qpid::amqp::DataBuilder builder(new
qpid::types::Variant::Map());
+qpid::types::Variant v = qpid::types::Variant::Map();
+qpid::amqp::DataBuilder builder(v);
qpid::amqp::Decoder decoder(body.data, body.size);
decoder.read(builder);
c = builder.getValue().asMap();
{noformat}
> [C++ Messaging] Windows AMQP 1.0 map_receiver fails freeing uninitialized
> string Variant
>
>
> Key: QPID-5663
> URL: https://issues.apache.org/jira/browse/QPID-5663
> Project: Qpid
> Issue Type: Bug
> Components: C++ Client
>Affects Versions: 0.29
> Environment: Windows x86 build on x64 host. Visual Studio 2010
>Reporter: Chuck Rolke
> Attachments: qpid-5663-stack-00.txt
>
>
> Running map_receiver with AMQP 1.0 fails straight away with a free of as
> string at 0xfeeefeee.
> {noformat}
> map_sender localhost:5672 "message_queue; {create: always}"
> "{protocol:amqp1.0}"
> map_receiver localhost:5672 "message_queue; {create: always}"
> "{protocol:amqp1.0}"
> {noformat}
> These work indefinitely running amqp0-10. map_sender is fine running either
> protocol version.
> Stack trace is posted as separate file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-5717) [Java] begin requiring Java 7 (end support for Java 6)
[ https://issues.apache.org/jira/browse/QPID-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-5717: Assignee: Rob Godfrey (was: Robbie Gemmell) Rob, can you review these changes please? Robbie > [Java] begin requiring Java 7 (end support for Java 6) > -- > > Key: QPID-5717 > URL: https://issues.apache.org/jira/browse/QPID-5717 > Project: Qpid > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Rob Godfrey > Fix For: 0.29 > > > Following up on the conversation Rob Godfrey started on the mailing lists ( > see > http://mail-archives.apache.org/mod_mbox/qpid-users/201404.mbox/%3CCACsaS94O8g3-%2B895GEKE-b0sP128mMM2hsg4mjNJHr28W%3DbpWQ%40mail.gmail.com%3E > ), this change will move us to the Java 7 class format as of the 0.30 > release, requiring Java7+ to build and run going forward. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5717) [Java] begin requiring Java 7 (end support for Java 6)
[ https://issues.apache.org/jira/browse/QPID-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-5717: - Status: Reviewable (was: In Progress) > [Java] begin requiring Java 7 (end support for Java 6) > -- > > Key: QPID-5717 > URL: https://issues.apache.org/jira/browse/QPID-5717 > Project: Qpid > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.29 > > > Following up on the conversation Rob Godfrey started on the mailing lists ( > see > http://mail-archives.apache.org/mod_mbox/qpid-users/201404.mbox/%3CCACsaS94O8g3-%2B895GEKE-b0sP128mMM2hsg4mjNJHr28W%3DbpWQ%40mail.gmail.com%3E > ), this change will move us to the Java 7 class format as of the 0.30 > release, requiring Java7+ to build and run going forward. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5717) [Java] begin requiring Java 7 (end support for Java 6)
[ https://issues.apache.org/jira/browse/QPID-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976631#comment-13976631 ] ASF subversion and git services commented on QPID-5717: --- Commit 1589085 from rob...@apache.org in branch 'qpid/trunk' [ https://svn.apache.org/r1589085 ] QPID-5717: update the ant build to configure javac to the 1.7 format > [Java] begin requiring Java 7 (end support for Java 6) > -- > > Key: QPID-5717 > URL: https://issues.apache.org/jira/browse/QPID-5717 > Project: Qpid > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.29 > > > Following up on the conversation Rob Godfrey started on the mailing lists ( > see > http://mail-archives.apache.org/mod_mbox/qpid-users/201404.mbox/%3CCACsaS94O8g3-%2B895GEKE-b0sP128mMM2hsg4mjNJHr28W%3DbpWQ%40mail.gmail.com%3E > ), this change will move us to the Java 7 class format as of the 0.30 > release, requiring Java7+ to build and run going forward. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5717) [Java] begin requiring Java 7 (end support for Java 6)
[ https://issues.apache.org/jira/browse/QPID-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976621#comment-13976621 ] Robbie Gemmell commented on QPID-5717: -- The above commits move the maven build to Java 7 on trunk, while retaining Java 6 compatibility for the preview maven build that will be released with the 0.28 branch. Ant build changes on trunk still to do. > [Java] begin requiring Java 7 (end support for Java 6) > -- > > Key: QPID-5717 > URL: https://issues.apache.org/jira/browse/QPID-5717 > Project: Qpid > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.29 > > > Following up on the conversation Rob Godfrey started on the mailing lists ( > see > http://mail-archives.apache.org/mod_mbox/qpid-users/201404.mbox/%3CCACsaS94O8g3-%2B895GEKE-b0sP128mMM2hsg4mjNJHr28W%3DbpWQ%40mail.gmail.com%3E > ), this change will move us to the Java 7 class format as of the 0.30 > release, requiring Java7+ to build and run going forward. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5717) [Java] begin requiring Java 7 (end support for Java 6)
[ https://issues.apache.org/jira/browse/QPID-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976620#comment-13976620 ] ASF subversion and git services commented on QPID-5717: --- Commit 1589078 from rob...@apache.org in branch 'qpid/branches/0.28' [ https://svn.apache.org/r1589078 ] QPID-5717: override qpid-parent and specify a 1.6.0 minimum JVM enforcement to match the existing 1.6 class format override > [Java] begin requiring Java 7 (end support for Java 6) > -- > > Key: QPID-5717 > URL: https://issues.apache.org/jira/browse/QPID-5717 > Project: Qpid > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.29 > > > Following up on the conversation Rob Godfrey started on the mailing lists ( > see > http://mail-archives.apache.org/mod_mbox/qpid-users/201404.mbox/%3CCACsaS94O8g3-%2B895GEKE-b0sP128mMM2hsg4mjNJHr28W%3DbpWQ%40mail.gmail.com%3E > ), this change will move us to the Java 7 class format as of the 0.30 > release, requiring Java7+ to build and run going forward. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5717) [Java] begin requiring Java 7 (end support for Java 6)
[ https://issues.apache.org/jira/browse/QPID-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976617#comment-13976617 ] ASF subversion and git services commented on QPID-5717: --- Commit 1589076 from rob...@apache.org in branch 'qpid/trunk' [ https://svn.apache.org/r1589076 ] QPID-5717: remove compiler configuration override and inherit parent values > [Java] begin requiring Java 7 (end support for Java 6) > -- > > Key: QPID-5717 > URL: https://issues.apache.org/jira/browse/QPID-5717 > Project: Qpid > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.29 > > > Following up on the conversation Rob Godfrey started on the mailing lists ( > see > http://mail-archives.apache.org/mod_mbox/qpid-users/201404.mbox/%3CCACsaS94O8g3-%2B895GEKE-b0sP128mMM2hsg4mjNJHr28W%3DbpWQ%40mail.gmail.com%3E > ), this change will move us to the Java 7 class format as of the 0.30 > release, requiring Java7+ to build and run going forward. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5717) [Java] begin requiring Java 7 (end support for Java 6)
[ https://issues.apache.org/jira/browse/QPID-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976615#comment-13976615 ] ASF subversion and git services commented on QPID-5717: --- Commit 1589074 from rob...@apache.org in branch 'pom/trunk' [ https://svn.apache.org/r1589074 ] QPID-5717: update qpid-parent to default to configuring the 1.7 class format for the compiler plugin and a 1.7.0 minimum JVM for enforcer plugin > [Java] begin requiring Java 7 (end support for Java 6) > -- > > Key: QPID-5717 > URL: https://issues.apache.org/jira/browse/QPID-5717 > Project: Qpid > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.29 > > > Following up on the conversation Rob Godfrey started on the mailing lists ( > see > http://mail-archives.apache.org/mod_mbox/qpid-users/201404.mbox/%3CCACsaS94O8g3-%2B895GEKE-b0sP128mMM2hsg4mjNJHr28W%3DbpWQ%40mail.gmail.com%3E > ), this change will move us to the Java 7 class format as of the 0.30 > release, requiring Java7+ to build and run going forward. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-5717) [Java] begin requiring Java 7 (end support for Java 6)
Robbie Gemmell created QPID-5717: Summary: [Java] begin requiring Java 7 (end support for Java 6) Key: QPID-5717 URL: https://issues.apache.org/jira/browse/QPID-5717 Project: Qpid Issue Type: Task Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.29 Following up on the conversation Rob Godfrey started on the mailing lists ( see http://mail-archives.apache.org/mod_mbox/qpid-users/201404.mbox/%3CCACsaS94O8g3-%2B895GEKE-b0sP128mMM2hsg4mjNJHr28W%3DbpWQ%40mail.gmail.com%3E ), this change will move us to the Java 7 class format as of the 0.30 release, requiring Java7+ to build and run going forward. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-5714) Skip python tests if test code is missing
[ https://issues.apache.org/jira/browse/QPID-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross resolved QPID-5714. --- Resolution: Fixed > Skip python tests if test code is missing > - > > Key: QPID-5714 > URL: https://issues.apache.org/jira/browse/QPID-5714 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.28 > > > Particularly with release distributions, it is possible to have > qpid-python-test but not have the target test code, for the tests > python_tests and swig_python_tests. Since the test code is currently outside > the cpp tree, these tests need to be skipped when the test code is not there. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5048) [Java] Implement a Maven 3 build system
[ https://issues.apache.org/jira/browse/QPID-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976608#comment-13976608 ] ASF subversion and git services commented on QPID-5048: --- Commit 1589069 from rob...@apache.org in branch 'pom/trunk' [ https://svn.apache.org/r1589069 ] QPID-5048: some qpid-parent pom tidyup > [Java] Implement a Maven 3 build system > > > Key: QPID-5048 > URL: https://issues.apache.org/jira/browse/QPID-5048 > Project: Qpid > Issue Type: Task > Components: Build Tools >Reporter: Rob Godfrey >Assignee: Robbie Gemmell > Attachments: > 0001-NO-JIRA-fix-to-resolve-potential-parse-error-in-Abst.patch, > 0001-QPID-5048-Maven-POM-refactoring-names-descriptions-d.patch, > 0001-QPID-5048-Maven-enahancements-to-remove-child-versio.patch, > 0001-QPID-5048-Maven-enahancements-to-restructure-POM-hie.patch, > 0001-QPID-5048-Moved-slf4j-deps-to-test-utils-to-workarou.patch, > 0001-QPID-5048-added-basic-cpp-broker-test-profile.patch, > 0001-QPID-5048-changes-get-perf-tests-running-again.patch, > 0001-QPID-5048-dby-profiles-bdb-test-deps-and-config-for-.patch, > 0001-QPID-5048-maven-license-plugin-optimisation-enhanced.patch, > 0001-QPID-5048-modified-deployment-plugin-config-so-only-.patch, > 0001-QPID-5048-new-maven-enforcer-plugin-rule-for-checkin.patch, > 0001-QPID-5048-parent-pom-changes-for-release-license-and.patch, > 0001-QPID-5048-split-out-systests-from-perftests-and-add-.patch, > 0001-QPID-5048-surefire-site-coverage-and-jxr-config.patch, > 0001-QPID-5048-update-qpid-parent-pom-to-inherit-from-lat.patch, > 0001-QPID-5048-update-qpid-parent-pom-to-remove-dependenc.patch, > 0002-QPID-5048-Logging-dependency-and-configuration-tidy-.patch, > 0002-QPID-5048-added-dependency-license-reference-checkin.patch, > 0002-QPID-5048-re-instate-dependency-versions-after-qpid-.patch, > 0003-QPID-5048-logging-and-build-output-cleanup.patch, > QPID-5048-maven-qpid-parent-changes.diff > > > Implement a Maven build system which generates the same artefacts as the > current ant based build. > See: https://cwiki.apache.org/confluence/display/qpid/Java+Build+System > TO DO > - Fix what the systests/perftests do to copy the test-profiles dir to the > necessary location. > - Test deploying the modules to a local Nexus instance (by overriding the > repo properties locally). > - Ensure we dont deploy modules we aren't already doing so, it will make > changing them later less of a pain for everyone. > - Align the XML in the pom files consistently, fix whitepsace errors. > - improve the performance hit from using the license plugin > - check that perf-tests actually needs the unpacked broker for running non > spawn profiles and remove if not > - remove the child module version to let them inherit from java parent > - check the bcel bundle dependancy exclusions are still required > === Once the Ant build is removed === > - Move all the resources to be in the /src/foo/resources folders. > - Make qpidversion.properties in common be a filtered resource instead of > generated. > - Get rid of the antrun-plugin execution in common, directly invoke the > required java elements. > - Do the above in the generate-sources-common profile instead of current > default config. > - Get rid of the antrun-plugin execution in broker-core, directly invoke the > required java elements. > - Fix the tests not to be dependant on the working dir being the java dir. > - Fix the tests not to be dependant on the test config/output dirs being > children of qpid.home. > - Remove the QBTC output file mechanics, rely on Surefire to do it? > - JUnit test profiles instead of Exludes files? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5714) Skip python tests if test code is missing
[ https://issues.apache.org/jira/browse/QPID-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-5714: -- Fix Version/s: (was: 0.29) 0.28 > Skip python tests if test code is missing > - > > Key: QPID-5714 > URL: https://issues.apache.org/jira/browse/QPID-5714 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.28 > > > Particularly with release distributions, it is possible to have > qpid-python-test but not have the target test code, for the tests > python_tests and swig_python_tests. Since the test code is currently outside > the cpp tree, these tests need to be skipped when the test code is not there. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5714) Skip python tests if test code is missing
[ https://issues.apache.org/jira/browse/QPID-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976607#comment-13976607 ] ASF subversion and git services commented on QPID-5714: --- Commit 1589068 from jr...@apache.org in branch 'qpid/branches/0.28' [ https://svn.apache.org/r1589068 ] QPID-5714: Skip python tests if test code is missing > Skip python tests if test code is missing > - > > Key: QPID-5714 > URL: https://issues.apache.org/jira/browse/QPID-5714 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.29 > > > Particularly with release distributions, it is possible to have > qpid-python-test but not have the target test code, for the tests > python_tests and swig_python_tests. Since the test code is currently outside > the cpp tree, these tests need to be skipped when the test code is not there. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5714) Skip python tests if test code is missing
[ https://issues.apache.org/jira/browse/QPID-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976594#comment-13976594 ] Justin Ross commented on QPID-5714: --- Reviewed by Gordon. Approved for 0.28. > Skip python tests if test code is missing > - > > Key: QPID-5714 > URL: https://issues.apache.org/jira/browse/QPID-5714 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.29 > > > Particularly with release distributions, it is possible to have > qpid-python-test but not have the target test code, for the tests > python_tests and swig_python_tests. Since the test code is currently outside > the cpp tree, these tests need to be skipped when the test code is not there. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5048) [Java] Implement a Maven 3 build system
[ https://issues.apache.org/jira/browse/QPID-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976587#comment-13976587 ] ASF subversion and git services commented on QPID-5048: --- Commit 1589053 from rob...@apache.org in branch 'qpid/branches/0.28' [ https://svn.apache.org/r1589053 ] QPID-5048: 0.28 specific update to compensate for changes in qpid-parent pom in r1589051 > [Java] Implement a Maven 3 build system > > > Key: QPID-5048 > URL: https://issues.apache.org/jira/browse/QPID-5048 > Project: Qpid > Issue Type: Task > Components: Build Tools >Reporter: Rob Godfrey >Assignee: Robbie Gemmell > Attachments: > 0001-NO-JIRA-fix-to-resolve-potential-parse-error-in-Abst.patch, > 0001-QPID-5048-Maven-POM-refactoring-names-descriptions-d.patch, > 0001-QPID-5048-Maven-enahancements-to-remove-child-versio.patch, > 0001-QPID-5048-Maven-enahancements-to-restructure-POM-hie.patch, > 0001-QPID-5048-Moved-slf4j-deps-to-test-utils-to-workarou.patch, > 0001-QPID-5048-added-basic-cpp-broker-test-profile.patch, > 0001-QPID-5048-changes-get-perf-tests-running-again.patch, > 0001-QPID-5048-dby-profiles-bdb-test-deps-and-config-for-.patch, > 0001-QPID-5048-maven-license-plugin-optimisation-enhanced.patch, > 0001-QPID-5048-modified-deployment-plugin-config-so-only-.patch, > 0001-QPID-5048-new-maven-enforcer-plugin-rule-for-checkin.patch, > 0001-QPID-5048-parent-pom-changes-for-release-license-and.patch, > 0001-QPID-5048-split-out-systests-from-perftests-and-add-.patch, > 0001-QPID-5048-surefire-site-coverage-and-jxr-config.patch, > 0001-QPID-5048-update-qpid-parent-pom-to-inherit-from-lat.patch, > 0001-QPID-5048-update-qpid-parent-pom-to-remove-dependenc.patch, > 0002-QPID-5048-Logging-dependency-and-configuration-tidy-.patch, > 0002-QPID-5048-added-dependency-license-reference-checkin.patch, > 0002-QPID-5048-re-instate-dependency-versions-after-qpid-.patch, > 0003-QPID-5048-logging-and-build-output-cleanup.patch, > QPID-5048-maven-qpid-parent-changes.diff > > > Implement a Maven build system which generates the same artefacts as the > current ant based build. > See: https://cwiki.apache.org/confluence/display/qpid/Java+Build+System > TO DO > - Fix what the systests/perftests do to copy the test-profiles dir to the > necessary location. > - Test deploying the modules to a local Nexus instance (by overriding the > repo properties locally). > - Ensure we dont deploy modules we aren't already doing so, it will make > changing them later less of a pain for everyone. > - Align the XML in the pom files consistently, fix whitepsace errors. > - improve the performance hit from using the license plugin > - check that perf-tests actually needs the unpacked broker for running non > spawn profiles and remove if not > - remove the child module version to let them inherit from java parent > - check the bcel bundle dependancy exclusions are still required > === Once the Ant build is removed === > - Move all the resources to be in the /src/foo/resources folders. > - Make qpidversion.properties in common be a filtered resource instead of > generated. > - Get rid of the antrun-plugin execution in common, directly invoke the > required java elements. > - Do the above in the generate-sources-common profile instead of current > default config. > - Get rid of the antrun-plugin execution in broker-core, directly invoke the > required java elements. > - Fix the tests not to be dependant on the working dir being the java dir. > - Fix the tests not to be dependant on the test config/output dirs being > children of qpid.home. > - Remove the QBTC output file mechanics, rely on Surefire to do it? > - JUnit test profiles instead of Exludes files? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5048) [Java] Implement a Maven 3 build system
[ https://issues.apache.org/jira/browse/QPID-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976584#comment-13976584 ] ASF subversion and git services commented on QPID-5048: --- Commit 1589051 from rob...@apache.org in branch 'pom/trunk' [ https://svn.apache.org/r1589051 ] QPID-5048: delete dependency version properties we no longer use on trunk > [Java] Implement a Maven 3 build system > > > Key: QPID-5048 > URL: https://issues.apache.org/jira/browse/QPID-5048 > Project: Qpid > Issue Type: Task > Components: Build Tools >Reporter: Rob Godfrey >Assignee: Robbie Gemmell > Attachments: > 0001-NO-JIRA-fix-to-resolve-potential-parse-error-in-Abst.patch, > 0001-QPID-5048-Maven-POM-refactoring-names-descriptions-d.patch, > 0001-QPID-5048-Maven-enahancements-to-remove-child-versio.patch, > 0001-QPID-5048-Maven-enahancements-to-restructure-POM-hie.patch, > 0001-QPID-5048-Moved-slf4j-deps-to-test-utils-to-workarou.patch, > 0001-QPID-5048-added-basic-cpp-broker-test-profile.patch, > 0001-QPID-5048-changes-get-perf-tests-running-again.patch, > 0001-QPID-5048-dby-profiles-bdb-test-deps-and-config-for-.patch, > 0001-QPID-5048-maven-license-plugin-optimisation-enhanced.patch, > 0001-QPID-5048-modified-deployment-plugin-config-so-only-.patch, > 0001-QPID-5048-new-maven-enforcer-plugin-rule-for-checkin.patch, > 0001-QPID-5048-parent-pom-changes-for-release-license-and.patch, > 0001-QPID-5048-split-out-systests-from-perftests-and-add-.patch, > 0001-QPID-5048-surefire-site-coverage-and-jxr-config.patch, > 0001-QPID-5048-update-qpid-parent-pom-to-inherit-from-lat.patch, > 0001-QPID-5048-update-qpid-parent-pom-to-remove-dependenc.patch, > 0002-QPID-5048-Logging-dependency-and-configuration-tidy-.patch, > 0002-QPID-5048-added-dependency-license-reference-checkin.patch, > 0002-QPID-5048-re-instate-dependency-versions-after-qpid-.patch, > 0003-QPID-5048-logging-and-build-output-cleanup.patch, > QPID-5048-maven-qpid-parent-changes.diff > > > Implement a Maven build system which generates the same artefacts as the > current ant based build. > See: https://cwiki.apache.org/confluence/display/qpid/Java+Build+System > TO DO > - Fix what the systests/perftests do to copy the test-profiles dir to the > necessary location. > - Test deploying the modules to a local Nexus instance (by overriding the > repo properties locally). > - Ensure we dont deploy modules we aren't already doing so, it will make > changing them later less of a pain for everyone. > - Align the XML in the pom files consistently, fix whitepsace errors. > - improve the performance hit from using the license plugin > - check that perf-tests actually needs the unpacked broker for running non > spawn profiles and remove if not > - remove the child module version to let them inherit from java parent > - check the bcel bundle dependancy exclusions are still required > === Once the Ant build is removed === > - Move all the resources to be in the /src/foo/resources folders. > - Make qpidversion.properties in common be a filtered resource instead of > generated. > - Get rid of the antrun-plugin execution in common, directly invoke the > required java elements. > - Do the above in the generate-sources-common profile instead of current > default config. > - Get rid of the antrun-plugin execution in broker-core, directly invoke the > required java elements. > - Fix the tests not to be dependant on the working dir being the java dir. > - Fix the tests not to be dependant on the test config/output dirs being > children of qpid.home. > - Remove the QBTC output file mechanics, rely on Surefire to do it? > - JUnit test profiles instead of Exludes files? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5714) Skip python tests if test code is missing
[ https://issues.apache.org/jira/browse/QPID-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976534#comment-13976534 ] Gordon Sim commented on QPID-5714: -- Thanks Justin! Looks good to me, no risk if backported to 0.28 and would result in less noise for some/many. > Skip python tests if test code is missing > - > > Key: QPID-5714 > URL: https://issues.apache.org/jira/browse/QPID-5714 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker, C++ Client >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.29 > > > Particularly with release distributions, it is possible to have > qpid-python-test but not have the target test code, for the tests > python_tests and swig_python_tests. Since the test code is currently outside > the cpp tree, these tests need to be skipped when the test code is not there. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
