[jira] [Updated] (QPID-5803) Add ability for the virtualhostnode to create a virtualhost using a blueprint supplied by context variable
[ https://issues.apache.org/jira/browse/QPID-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5803: - Attachment: 0001-QPID-5803-Java-Broker-Add-a-utilised-flag-to-the-VHN.patch > Add ability for the virtualhostnode to create a virtualhost using a blueprint > supplied by context variable > -- > > Key: QPID-5803 > URL: https://issues.apache.org/jira/browse/QPID-5803 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: 0.29 > > Attachments: > 0001-QPID-5803-Java-Broker-Add-a-utilised-flag-to-the-VHN.patch > > > As a user, I want to be able to unpack the Broker from its distribution, > start it and immediately start messaging using the default virtualhost > without performing initial configuration. > In order to support this use case, add the ability to the virtualhostnode to > automatically create a virtualhost if none is present, iff a context variable > providing a 'virtualhost blueprint' is set. > The broker will be shipped with a default virtiualhostnode configured in its > initial store. The object will have the virtualhost blueprint context > variable set, allowing the virtualhost to be created if none is already > present. > If the virtualhost already exists, the blueprint variable is always ignored. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5819) Starting a Broker with a virtualhostnode in stopped state causes exception
[
https://issues.apache.org/jira/browse/QPID-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037931#comment-14037931
]
Keith Wall commented on QPID-5819:
--
Alex, can you review this commit, please?
> Starting a Broker with a virtualhostnode in stopped state causes exception
> --
>
> Key: QPID-5819
> URL: https://issues.apache.org/jira/browse/QPID-5819
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: 0.29
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Critical
> Fix For: 0.29
>
>
> If I start a Broker that has a virtualhostnode in the STOPPED state, the
> following exception is observed and the Broker fails to start.
> {noformat}
> FATAL [main] (server.Broker) - Exception during startup
> java.lang.NullPointerException
> at
> org.apache.qpid.server.store.JsonFileConfigStore.releaseFileLock(JsonFileConfigStore.java:593)
> at
> org.apache.qpid.server.store.JsonFileConfigStore.closeConfigurationStore(JsonFileConfigStore.java:565)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.closeConfigurationStore(AbstractVirtualHostNode.java:245)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doStop(AbstractVirtualHostNode.java:209)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5819) Starting a Broker with a virtualhostnode in stopped state causes exception
[
https://issues.apache.org/jira/browse/QPID-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-5819:
-
Status: Reviewable (was: In Progress)
> Starting a Broker with a virtualhostnode in stopped state causes exception
> --
>
> Key: QPID-5819
> URL: https://issues.apache.org/jira/browse/QPID-5819
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: 0.29
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Critical
> Fix For: 0.29
>
>
> If I start a Broker that has a virtualhostnode in the STOPPED state, the
> following exception is observed and the Broker fails to start.
> {noformat}
> FATAL [main] (server.Broker) - Exception during startup
> java.lang.NullPointerException
> at
> org.apache.qpid.server.store.JsonFileConfigStore.releaseFileLock(JsonFileConfigStore.java:593)
> at
> org.apache.qpid.server.store.JsonFileConfigStore.closeConfigurationStore(JsonFileConfigStore.java:565)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.closeConfigurationStore(AbstractVirtualHostNode.java:245)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doStop(AbstractVirtualHostNode.java:209)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5819) Starting a Broker with a virtualhostnode in stopped state causes exception
[
https://issues.apache.org/jira/browse/QPID-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-5819:
-
Affects Version/s: 0.29
> Starting a Broker with a virtualhostnode in stopped state causes exception
> --
>
> Key: QPID-5819
> URL: https://issues.apache.org/jira/browse/QPID-5819
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: 0.29
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Critical
> Fix For: 0.29
>
>
> If I start a Broker that has a virtualhostnode in the STOPPED state, the
> following exception is observed and the Broker fails to start.
> {noformat}
> FATAL [main] (server.Broker) - Exception during startup
> java.lang.NullPointerException
> at
> org.apache.qpid.server.store.JsonFileConfigStore.releaseFileLock(JsonFileConfigStore.java:593)
> at
> org.apache.qpid.server.store.JsonFileConfigStore.closeConfigurationStore(JsonFileConfigStore.java:565)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.closeConfigurationStore(AbstractVirtualHostNode.java:245)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doStop(AbstractVirtualHostNode.java:209)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5819) Starting a Broker with a virtualhostnode in stopped state causes exception
[
https://issues.apache.org/jira/browse/QPID-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-5819:
-
Assignee: Alex Rudyy (was: Keith Wall)
> Starting a Broker with a virtualhostnode in stopped state causes exception
> --
>
> Key: QPID-5819
> URL: https://issues.apache.org/jira/browse/QPID-5819
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: 0.29
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Critical
> Fix For: 0.29
>
>
> If I start a Broker that has a virtualhostnode in the STOPPED state, the
> following exception is observed and the Broker fails to start.
> {noformat}
> FATAL [main] (server.Broker) - Exception during startup
> java.lang.NullPointerException
> at
> org.apache.qpid.server.store.JsonFileConfigStore.releaseFileLock(JsonFileConfigStore.java:593)
> at
> org.apache.qpid.server.store.JsonFileConfigStore.closeConfigurationStore(JsonFileConfigStore.java:565)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.closeConfigurationStore(AbstractVirtualHostNode.java:245)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doStop(AbstractVirtualHostNode.java:209)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5800) Refactoring: Introduce MessageStoreProvider interface to improve message/configuration store implementations
[
https://issues.apache.org/jira/browse/QPID-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037924#comment-14037924
]
ASF subversion and git services commented on QPID-5800:
---
Commit 1604037 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1604037 ]
QPID-5800: [Java Broker] Defect - prevent JDBC upgrader on throwing exception
due to open transaction causing exception to log
> Refactoring: Introduce MessageStoreProvider interface to improve
> message/configuration store implementations
>
>
> Key: QPID-5800
> URL: https://issues.apache.org/jira/browse/QPID-5800
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: 0.29
>
>
> A configuration store implementation that wishes to additionally provide a
> message store must currently implements the {{MessageStore}} interface. This
> design has led to rather monolithic implementations.
> This refactoring will introduce a {{MesageStoreProvider}} interface.
> Configuration stores implementations that wish to also expose a MessageStore
> will implement this interface. They can then provide the MessageStore store
> implementation as they see fit, hopefully leading to better, more cohesive,
> code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-5819) Starting a Broker with a virtualhostnode in stopped state causes exception
[
https://issues.apache.org/jira/browse/QPID-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall reassigned QPID-5819:
Assignee: Keith Wall
> Starting a Broker with a virtualhostnode in stopped state causes exception
> --
>
> Key: QPID-5819
> URL: https://issues.apache.org/jira/browse/QPID-5819
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Critical
> Fix For: 0.29
>
>
> If I start a Broker that has a virtualhostnode in the STOPPED state, the
> following exception is observed and the Broker fails to start.
> {noformat}
> FATAL [main] (server.Broker) - Exception during startup
> java.lang.NullPointerException
> at
> org.apache.qpid.server.store.JsonFileConfigStore.releaseFileLock(JsonFileConfigStore.java:593)
> at
> org.apache.qpid.server.store.JsonFileConfigStore.closeConfigurationStore(JsonFileConfigStore.java:565)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.closeConfigurationStore(AbstractVirtualHostNode.java:245)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doStop(AbstractVirtualHostNode.java:209)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5819) Starting a Broker with a virtualhostnode in stopped state causes exception
[
https://issues.apache.org/jira/browse/QPID-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037923#comment-14037923
]
ASF subversion and git services commented on QPID-5819:
---
Commit 1604036 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1604036 ]
QPID-5819: Make JsonFileConfigStore#close idempotent, like other DCS
implementations
> Starting a Broker with a virtualhostnode in stopped state causes exception
> --
>
> Key: QPID-5819
> URL: https://issues.apache.org/jira/browse/QPID-5819
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Reporter: Keith Wall
>Priority: Critical
> Fix For: 0.29
>
>
> If I start a Broker that has a virtualhostnode in the STOPPED state, the
> following exception is observed and the Broker fails to start.
> {noformat}
> FATAL [main] (server.Broker) - Exception during startup
> java.lang.NullPointerException
> at
> org.apache.qpid.server.store.JsonFileConfigStore.releaseFileLock(JsonFileConfigStore.java:593)
> at
> org.apache.qpid.server.store.JsonFileConfigStore.closeConfigurationStore(JsonFileConfigStore.java:565)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.closeConfigurationStore(AbstractVirtualHostNode.java:245)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doStop(AbstractVirtualHostNode.java:209)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-5599) C++ Broker silently ignores --max-connections option when no ACL file is loaded
[ https://issues.apache.org/jira/browse/QPID-5599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke resolved QPID-5599. --- Resolution: Fixed Fix Version/s: 0.28 > C++ Broker silently ignores --max-connections option when no ACL file is > loaded > --- > > Key: QPID-5599 > URL: https://issues.apache.org/jira/browse/QPID-5599 > Project: Qpid > Issue Type: Bug > Components: C++ Broker >Affects Versions: 0.26 >Reporter: Chuck Rolke >Assignee: Chuck Rolke > Fix For: 0.28 > > > ACL was converted from being a loadable module to being a built in but it > still uses the loadable module interface. In that process if no ACL file is > specified on the command line then no ACL object is created. The command line > processing for --max-connections is in the ACL constructor and with no ACL > object the CLI option is ignored. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5833) Message's userId check in C++ broker prevents sending messages between different users
[
https://issues.apache.org/jira/browse/QPID-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wesley Holevinski updated QPID-5833:
Attachment: qpid_5833_steps.tgz
> Message's userId check in C++ broker prevents sending messages between
> different users
> --
>
> Key: QPID-5833
> URL: https://issues.apache.org/jira/browse/QPID-5833
> Project: Qpid
> Issue Type: Bug
>Affects Versions: 0.28
>Reporter: Wesley Holevinski
> Attachments: qpid_5833_steps.tgz
>
>
> The lines in question are :
> {noformat}
> df36b35e qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
> 2012-08-10 12:04:27 + 490) std::string id = msg.getUserId();
> ae0f6726 qpid/cpp/src/qpid/broker/SemanticState.cpp (Alan Conway
> 2011-12-06 15:56:40 + 491) if (authMsg && !id.empty() &&
> !session.getConnection().isAuthenticatedUser(id))
> 63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
> 2008-09-25 18:40:32 + 492) {
> d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
> 2008-10-10 16:54:54 + 493) QPID_LOG(debug, "authorised user id :
> " << userID << " but user id in message declared as " << id);
> d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
> 2008-10-10 16:54:54 + 494) throw
> UnauthorizedAccessException(QPID_MSG("authorised user id : " << userID << "
> but user id in messag
> 63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
> 2008-09-25 18:40:32 + 495) }
> {noformat}
> ---
> Up until this point, we haven't been using a JMS client; we've found that the
> JMS client will insert the userId into the message:
> {noformat}
> d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 117) //
> On the receiving side, this will be read in to the JMSXUserID as well.
> dd2ed172 (Rajith Muditha Attapattu 2008-10-01 19:27:19 + 118)
> messageProps.setUserId(userIDBytes);
> d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 119)
>
> 21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 120) if
> (messageId != null)
> 21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 121) {
> 21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 122)
> messageProps.setMessageId(messageId);
> 21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 123) }
> {noformat}
> ---
> Our scenario:
> 1. Send message to a broker using the JMS client; authenticate as user:
> 'tester'
> 2. Consume message from destination queue as user 'mgmt'
> {noformat}
> Result: "unauthorized-access: authorised user id : mgmt@QPID but user id in
> message declared as tester
> (/builddir/build/BUILD/qpid-0.28-rc2/cpp/src/qpid/broker/SemanticState.cpp:497"
> {noformat}
> ---
> I'll work on providing a full end to end simple example for this.
> ---
> Per Gordon in the mailing list:
> That error occurs in the broker when a message is sent by a client. SO I
> suspect what may be happening is that your c++ client is receiving the
> message from JMS, then sending the same message back (including the
> userid of the JMS client that originally sent it).
> If I'm right, all you need to do is clear the message in the c++ client,
> before resending it (using Message::setUserId()).
> ---
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5833) Message's userId check in C++ broker prevents sending messages between different users
[
https://issues.apache.org/jira/browse/QPID-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wesley Holevinski updated QPID-5833:
Description:
The lines in question are :
{noformat}
df36b35e qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2012-08-10 12:04:27 + 490) std::string id = msg.getUserId();
ae0f6726 qpid/cpp/src/qpid/broker/SemanticState.cpp (Alan Conway
2011-12-06 15:56:40 + 491) if (authMsg && !id.empty() &&
!session.getConnection().isAuthenticatedUser(id))
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 492) {
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 493) QPID_LOG(debug, "authorised user id : "
<< userID << " but user id in message declared as " << id);
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 494) throw
UnauthorizedAccessException(QPID_MSG("authorised user id : " << userID << " but
user id in messag
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 495) }
{noformat}
---
Up until this point, we haven't been using a JMS client; we've found that the
JMS client will insert the userId into the message:
{noformat}
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 117) // On
the receiving side, this will be read in to the JMSXUserID as well.
dd2ed172 (Rajith Muditha Attapattu 2008-10-01 19:27:19 + 118)
messageProps.setUserId(userIDBytes);
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 119)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 120) if
(messageId != null)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 121) {
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 122)
messageProps.setMessageId(messageId);
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 123) }
{noformat}
---
Our scenario:
1. Send message to a broker using the JMS client; authenticate as user: 'tester'
2. Consume message from destination queue as user 'mgmt'
{noformat}
Result: "unauthorized-access: authorised user id : mgmt@QPID but user id in
message declared as tester
(/builddir/build/BUILD/qpid-0.28-rc2/cpp/src/qpid/broker/SemanticState.cpp:497"
{noformat}
---
I'll work on providing a full end to end simple example for this.
---
Per Gordon in the mailing list:
That error occurs in the broker when a message is sent by a client. SO I
suspect what may be happening is that your c++ client is receiving the
message from JMS, then sending the same message back (including the
userid of the JMS client that originally sent it).
If I'm right, all you need to do is clear the message in the c++ client,
before resending it (using Message::setUserId()).
---
See attached tgz for quick and dirty reproduction steps, c++ client, and jms
client. Setup in README
was:
The lines in question are :
{noformat}
df36b35e qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2012-08-10 12:04:27 + 490) std::string id = msg.getUserId();
ae0f6726 qpid/cpp/src/qpid/broker/SemanticState.cpp (Alan Conway
2011-12-06 15:56:40 + 491) if (authMsg && !id.empty() &&
!session.getConnection().isAuthenticatedUser(id))
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 492) {
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 493) QPID_LOG(debug, "authorised user id : "
<< userID << " but user id in message declared as " << id);
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 494) throw
UnauthorizedAccessException(QPID_MSG("authorised user id : " << userID << " but
user id in messag
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 495) }
{noformat}
---
Up until this point, we haven't been using a JMS client; we've found that the
JMS client will insert the userId into the message:
{noformat}
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 117) // On
the receiving side, this will be read in to the JMSXUserID as well.
dd2ed172 (Rajith Muditha Attapattu 2008-10-01 19:27:19 + 118)
messageProps.setUserId(userIDBytes);
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 119)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 120) if
(messageId != null)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 121) {
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 122)
messageProps.setMessageId(messageI
[jira] [Updated] (QPID-5833) Message's userId check in C++ broker prevents sending messages between different users
[
https://issues.apache.org/jira/browse/QPID-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wesley Holevinski updated QPID-5833:
Description:
The lines in question are :
{noformat}
df36b35e qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2012-08-10 12:04:27 + 490) std::string id = msg.getUserId();
ae0f6726 qpid/cpp/src/qpid/broker/SemanticState.cpp (Alan Conway
2011-12-06 15:56:40 + 491) if (authMsg && !id.empty() &&
!session.getConnection().isAuthenticatedUser(id))
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 492) {
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 493) QPID_LOG(debug, "authorised user id : "
<< userID << " but user id in message declared as " << id);
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 494) throw
UnauthorizedAccessException(QPID_MSG("authorised user id : " << userID << " but
user id in messag
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 495) }
{noformat}
---
Up until this point, we haven't been using a JMS client; we've found that the
JMS client will insert the userId into the message:
{noformat}
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 117) // On
the receiving side, this will be read in to the JMSXUserID as well.
dd2ed172 (Rajith Muditha Attapattu 2008-10-01 19:27:19 + 118)
messageProps.setUserId(userIDBytes);
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 119)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 120) if
(messageId != null)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 121) {
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 122)
messageProps.setMessageId(messageId);
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 123) }
{noformat}
---
Our scenario:
1. Send message to a broker using the JMS client; authenticate as user: 'tester'
2. Consume message from destination queue as user 'mgmt'
{noformat}
Result: "unauthorized-access: authorised user id : mgmt@QPID but user id in
message declared as tester
(/builddir/build/BUILD/qpid-0.28-rc2/cpp/src/qpid/broker/SemanticState.cpp:497"
{noformat}
---
I'll work on providing a full end to end simple example for this.
---
Per Gordon in the mailing list:
That error occurs in the broker when a message is sent by a client. SO I
suspect what may be happening is that your c++ client is receiving the
message from JMS, then sending the same message back (including the
userid of the JMS client that originally sent it).
If I'm right, all you need to do is clear the message in the c++ client,
before resending it (using Message::setUserId()).
---
was:
The lines in question are :
{noformat}
df36b35e qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2012-08-10 12:04:27 + 490) std::string id = msg.getUserId();
ae0f6726 qpid/cpp/src/qpid/broker/SemanticState.cpp (Alan Conway
2011-12-06 15:56:40 + 491) if (authMsg && !id.empty() &&
!session.getConnection().isAuthenticatedUser(id))
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 492) {
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 493) QPID_LOG(debug, "authorised user id : "
<< userID << " but user id in message declared as " << id);
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 494) throw
UnauthorizedAccessException(QPID_MSG("authorised user id : " << userID << " but
user id in messag
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 495) }
{noformat}
---
Up until this point, we haven't been using a JMS client; we've found that the
JMS client will insert the userId into the message:
{noformat}
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 117) // On
the receiving side, this will be read in to the JMSXUserID as well.
dd2ed172 (Rajith Muditha Attapattu 2008-10-01 19:27:19 + 118)
messageProps.setUserId(userIDBytes);
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 119)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 120) if
(messageId != null)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 121) {
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 122)
messageProps.setMessageId(messageId);
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 123) }
{noformat}
---
Our sc
[jira] [Commented] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037398#comment-14037398 ] ASF subversion and git services commented on QPID-5825: --- Commit 1603914 from [~macbean] in branch 'qpid/trunk' [ https://svn.apache.org/r1603914 ] QPID-5825: Changes to address some review comments for initial commit > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.juni
[jira] [Assigned] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean reassigned QPID-5825: Assignee: Keith Wall (was: Andrew MacBean) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.su
[jira] [Updated] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean updated QPID-5825: - Status: Reviewable (was: In Progress) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.
[jira] [Commented] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037397#comment-14037397 ] Andrew MacBean commented on QPID-5825: -- Thanks Keith for your comments. 1. Apologies, complete oversight on my part and will address asap. 2. Acknowledged and corrected, 3. Agreed, have now modified the test and removed constructor. 4. I did consider this but decided to create my own wrapper as the comparator needs to use the reverse order to that given in the enum and I wanted to make this independant from the enum declaration order in any case. I have also added a system test to check a connection has the expected protocol version in the future. > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > o
[jira] [Created] (QPID-5833) Message's userId check in C++ broker prevents sending messages between different users
Wesley Holevinski created QPID-5833:
---
Summary: Message's userId check in C++ broker prevents sending
messages between different users
Key: QPID-5833
URL: https://issues.apache.org/jira/browse/QPID-5833
Project: Qpid
Issue Type: Bug
Affects Versions: 0.28
Reporter: Wesley Holevinski
The lines in question are :
{noformat}
df36b35e qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2012-08-10 12:04:27 + 490) std::string id = msg.getUserId();
ae0f6726 qpid/cpp/src/qpid/broker/SemanticState.cpp (Alan Conway
2011-12-06 15:56:40 + 491) if (authMsg && !id.empty() &&
!session.getConnection().isAuthenticatedUser(id))
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 492) {
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 493) QPID_LOG(debug, "authorised user id : "
<< userID << " but user id in message declared as " << id);
d7c67754 qpid/cpp/src/qpid/broker/SemanticState.cpp (Gordon Sim
2008-10-10 16:54:54 + 494) throw
UnauthorizedAccessException(QPID_MSG("authorised user id : " << userID << " but
user id in messag
63f48b2f qpid/cpp/src/qpid/broker/SemanticState.cpp (Rajith Muditha Attapattu
2008-09-25 18:40:32 + 495) }
{noformat}
---
Up until this point, we haven't been using a JMS client; we've found that the
JMS client will insert the userId into the message:
{noformat}
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 117) // On
the receiving side, this will be read in to the JMSXUserID as well.
dd2ed172 (Rajith Muditha Attapattu 2008-10-01 19:27:19 + 118)
messageProps.setUserId(userIDBytes);
d4d85f06 (Rajith Muditha Attapattu 2008-09-25 18:35:11 + 119)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 120) if
(messageId != null)
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 121) {
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 122)
messageProps.setMessageId(messageId);
21c61b77 (Rafael H. Schloming 2008-07-09 13:26:54 + 123) }
{noformat}
---
Our scenario:
1. Send message to a broker using the JMS client; authenticate as user: 'tester'
2. Consume message from destination queue as user 'mgmt'
{noformat}
Result: "unauthorized-access: authorised user id : mgmt@QPID but user id in
message declared as tester
(/builddir/build/BUILD/qpid-0.28-rc2/cpp/src/qpid/broker/SemanticState.cpp:497"
{noformat}
---
I'll work on providing a full end to end simple example for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5800) Refactoring: Introduce MessageStoreProvider interface to improve message/configuration store implementations
[
https://issues.apache.org/jira/browse/QPID-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037282#comment-14037282
]
ASF subversion and git services commented on QPID-5800:
---
Commit 1603849 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1603849 ]
QPID-5800: [Java Broker] Refactor BDB message store implementation to separate
message and config store implementations.
* Message store implementations can now be used in isolation, which is useful
when the user is using a JSON VirtualHostNode with
a BDB virtual host.
> Refactoring: Introduce MessageStoreProvider interface to improve
> message/configuration store implementations
>
>
> Key: QPID-5800
> URL: https://issues.apache.org/jira/browse/QPID-5800
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: 0.29
>
>
> A configuration store implementation that wishes to additionally provide a
> message store must currently implements the {{MessageStore}} interface. This
> design has led to rather monolithic implementations.
> This refactoring will introduce a {{MesageStoreProvider}} interface.
> Configuration stores implementations that wish to also expose a MessageStore
> will implement this interface. They can then provide the MessageStore store
> implementation as they see fit, hopefully leading to better, more cohesive,
> code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-5831) Unexpected internal exception when closing JE Replicated environment
[ https://issues.apache.org/jira/browse/QPID-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-5831. -- Resolution: Fixed Fix Version/s: 0.29 > Unexpected internal exception when closing JE Replicated environment > > > Key: QPID-5831 > URL: https://issues.apache.org/jira/browse/QPID-5831 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.29 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > Intermittant test failure stating: "Problem closing handle testNodeName(1) > UNEXPECTED_EXCEPTION: Unexpected internal Exception, may have side effects. > Environment is invalid and must be closed" during test runs of > ReplicatedEnvironmentFacadeTest on both Jenkins and dev box. > Log Output: > Tests run: 26, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 73.315 sec > <<< FAILURE! - in > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest > testReplicationGroupListenerHearsAboutExistingRemoteReplicationNodes(org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest) > Time elapsed: 3.176 sec <<< ERROR! > com.sleepycat.je.EnvironmentFailureException: (JE 5.0.97) > testNodeName(1):/tmp/bdb-1402928024476/testNodeName Problem closing handle > testNodeName(1) UNEXPECTED_EXCEPTION: Unexpected internal Exception, may have > side effects. Environment is invalid and must be closed. > at com.sleepycat.je.Environment.close(Environment.java:390) > at > com.sleepycat.je.rep.ReplicatedEnvironment.close(ReplicatedEnvironment.java:702) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.closeEnvironment(ReplicatedEnvironmentFacade.java:786) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.close(ReplicatedEnvironmentFacade.java:257) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.tearDown(ReplicatedEnvironmentFacadeTest.java:87) > Issue happens due to race condition between > ReplicatedEnvironmentFacade.close() and DatabasePinger.pingDb(...) methods. > This means that potentially while the environment is closing, the > DatabasePinger trys to open a DB but despite this failing it causes underying > JE environment to think there is a database open and subsequently causes the > close to fail. > Race seems unavoidable and probably the best course of action is make the > close smarter to swallow the associated JE EnvironmentFailureException. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5825: - Status: Open (was: Reviewable) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter
[jira] [Updated] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5825: - Assignee: Andrew MacBean (was: Keith Wall) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.boo
[jira] [Commented] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037277#comment-14037277 ] Keith Wall commented on QPID-5825: -- Hi Andrew A couple of comments: # Missing licences from all the new files # code style - members must have leading underscore # AMQPProtocolVersionWrapper - constructor used only by test # I think you can implement the protocol version comparison much more simple by relying on the Protocol's ordinal value (which is naturally ordered already) and/or Enum.html#compareTo(E) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JU
[jira] [Updated] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean updated QPID-5825: - Status: Reviewable (was: In Progress) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.
[jira] [Assigned] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean reassigned QPID-5825: Assignee: Keith Wall (was: Andrew MacBean) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.su
[jira] [Assigned] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean reassigned QPID-5825: Assignee: Andrew MacBean (was: Keith Wall) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.mave
[jira] [Reopened] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean reopened QPID-5825: -- > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(Forked
[jira] [Resolved] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean resolved QPID-5825. -- Resolution: Fixed > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter.run
[jira] [Resolved] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean resolved QPID-5825. -- Resolution: Fixed > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter.run
[jira] [Reopened] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean reopened QPID-5825: -- > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(Forked
[jira] [Resolved] (QPID-5822) Replace low-level JDBC/BDB attributes with context variables
[ https://issues.apache.org/jira/browse/QPID-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean resolved QPID-5822. -- Resolution: Fixed > Replace low-level JDBC/BDB attributes with context variables > > > Key: QPID-5822 > URL: https://issues.apache.org/jira/browse/QPID-5822 > Project: Qpid > Issue Type: Task > Components: Java Broker >Reporter: Keith Wall >Assignee: Andrew MacBean > Fix For: 0.29 > > Attachments: > 0001-QPID-5822-Java-Broker-Eliminate-low-level-BDB-JDBC-a.patch > > > We have identified some VH attributes that are deemed too low level to > warrant attribute status and are to be demoted to context variable. > * JDBC types > * JE envConfig > * JE repConfig > For the JE configs, Rob suggested we iterate the supported JE config names > (EnvironmentParams#SUPPORTED_PARAMS) check the context for each one and set > as necessary. > This task should include any upgrader work. > Include writing a system test that uses Derby as an external database. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-5831) Unexpected internal exception when closing JE Replicated environment
[ https://issues.apache.org/jira/browse/QPID-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean reassigned QPID-5831: Assignee: Keith Wall (was: Andrew MacBean) > Unexpected internal exception when closing JE Replicated environment > > > Key: QPID-5831 > URL: https://issues.apache.org/jira/browse/QPID-5831 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.29 >Reporter: Andrew MacBean >Assignee: Keith Wall > Original Estimate: 8h > Remaining Estimate: 8h > > Intermittant test failure stating: "Problem closing handle testNodeName(1) > UNEXPECTED_EXCEPTION: Unexpected internal Exception, may have side effects. > Environment is invalid and must be closed" during test runs of > ReplicatedEnvironmentFacadeTest on both Jenkins and dev box. > Log Output: > Tests run: 26, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 73.315 sec > <<< FAILURE! - in > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest > testReplicationGroupListenerHearsAboutExistingRemoteReplicationNodes(org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest) > Time elapsed: 3.176 sec <<< ERROR! > com.sleepycat.je.EnvironmentFailureException: (JE 5.0.97) > testNodeName(1):/tmp/bdb-1402928024476/testNodeName Problem closing handle > testNodeName(1) UNEXPECTED_EXCEPTION: Unexpected internal Exception, may have > side effects. Environment is invalid and must be closed. > at com.sleepycat.je.Environment.close(Environment.java:390) > at > com.sleepycat.je.rep.ReplicatedEnvironment.close(ReplicatedEnvironment.java:702) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.closeEnvironment(ReplicatedEnvironmentFacade.java:786) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.close(ReplicatedEnvironmentFacade.java:257) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.tearDown(ReplicatedEnvironmentFacadeTest.java:87) > Issue happens due to race condition between > ReplicatedEnvironmentFacade.close() and DatabasePinger.pingDb(...) methods. > This means that potentially while the environment is closing, the > DatabasePinger trys to open a DB but despite this failing it causes underying > JE environment to think there is a database open and subsequently causes the > close to fail. > Race seems unavoidable and probably the best course of action is make the > close smarter to swallow the associated JE EnvironmentFailureException. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean updated QPID-5825: - Status: Reviewable (was: In Progress) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.
[jira] [Updated] (QPID-5831) Unexpected internal exception when closing JE Replicated environment
[ https://issues.apache.org/jira/browse/QPID-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean updated QPID-5831: - Status: Reviewable (was: In Progress) > Unexpected internal exception when closing JE Replicated environment > > > Key: QPID-5831 > URL: https://issues.apache.org/jira/browse/QPID-5831 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.29 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Original Estimate: 8h > Remaining Estimate: 8h > > Intermittant test failure stating: "Problem closing handle testNodeName(1) > UNEXPECTED_EXCEPTION: Unexpected internal Exception, may have side effects. > Environment is invalid and must be closed" during test runs of > ReplicatedEnvironmentFacadeTest on both Jenkins and dev box. > Log Output: > Tests run: 26, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 73.315 sec > <<< FAILURE! - in > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest > testReplicationGroupListenerHearsAboutExistingRemoteReplicationNodes(org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest) > Time elapsed: 3.176 sec <<< ERROR! > com.sleepycat.je.EnvironmentFailureException: (JE 5.0.97) > testNodeName(1):/tmp/bdb-1402928024476/testNodeName Problem closing handle > testNodeName(1) UNEXPECTED_EXCEPTION: Unexpected internal Exception, may have > side effects. Environment is invalid and must be closed. > at com.sleepycat.je.Environment.close(Environment.java:390) > at > com.sleepycat.je.rep.ReplicatedEnvironment.close(ReplicatedEnvironment.java:702) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.closeEnvironment(ReplicatedEnvironmentFacade.java:786) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.close(ReplicatedEnvironmentFacade.java:257) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.tearDown(ReplicatedEnvironmentFacadeTest.java:87) > Issue happens due to race condition between > ReplicatedEnvironmentFacade.close() and DatabasePinger.pingDb(...) methods. > This means that potentially while the environment is closing, the > DatabasePinger trys to open a DB but despite this failing it causes underying > JE environment to think there is a database open and subsequently causes the > close to fail. > Race seems unavoidable and probably the best course of action is make the > close smarter to swallow the associated JE EnvironmentFailureException. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew MacBean reassigned QPID-5825: Assignee: Keith Wall (was: Andrew MacBean) > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Keith Wall > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.su
[jira] [Commented] (QPID-5831) Unexpected internal exception when closing JE Replicated environment
[ https://issues.apache.org/jira/browse/QPID-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037177#comment-14037177 ] ASF subversion and git services commented on QPID-5831: --- Commit 1603791 from [~macbean] in branch 'qpid/trunk' [ https://svn.apache.org/r1603791 ] QPID-5831: Unexpected internal exception when closing JE Replicated environment > Unexpected internal exception when closing JE Replicated environment > > > Key: QPID-5831 > URL: https://issues.apache.org/jira/browse/QPID-5831 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.29 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Original Estimate: 8h > Remaining Estimate: 8h > > Intermittant test failure stating: "Problem closing handle testNodeName(1) > UNEXPECTED_EXCEPTION: Unexpected internal Exception, may have side effects. > Environment is invalid and must be closed" during test runs of > ReplicatedEnvironmentFacadeTest on both Jenkins and dev box. > Log Output: > Tests run: 26, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 73.315 sec > <<< FAILURE! - in > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest > testReplicationGroupListenerHearsAboutExistingRemoteReplicationNodes(org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest) > Time elapsed: 3.176 sec <<< ERROR! > com.sleepycat.je.EnvironmentFailureException: (JE 5.0.97) > testNodeName(1):/tmp/bdb-1402928024476/testNodeName Problem closing handle > testNodeName(1) UNEXPECTED_EXCEPTION: Unexpected internal Exception, may have > side effects. Environment is invalid and must be closed. > at com.sleepycat.je.Environment.close(Environment.java:390) > at > com.sleepycat.je.rep.ReplicatedEnvironment.close(ReplicatedEnvironment.java:702) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.closeEnvironment(ReplicatedEnvironmentFacade.java:786) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.close(ReplicatedEnvironmentFacade.java:257) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.tearDown(ReplicatedEnvironmentFacadeTest.java:87) > Issue happens due to race condition between > ReplicatedEnvironmentFacade.close() and DatabasePinger.pingDb(...) methods. > This means that potentially while the environment is closing, the > DatabasePinger trys to open a DB but despite this failing it causes underying > JE environment to think there is a database open and subsequently causes the > close to fail. > Race seems unavoidable and probably the best course of action is make the > close smarter to swallow the associated JE EnvironmentFailureException. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5825) Java broker tries to downgrade to the wrong amqp protocol version
[ https://issues.apache.org/jira/browse/QPID-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037171#comment-14037171 ] ASF subversion and git services commented on QPID-5825: --- Commit 1603786 from [~macbean] in branch 'qpid/trunk' [ https://svn.apache.org/r1603786 ] QPID-5825: Broker tries to downgrade to the wrong amqp protocol version > Java broker tries to downgrade to the wrong amqp protocol version > - > > Key: QPID-5825 > URL: https://issues.apache.org/jira/browse/QPID-5825 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.28 >Reporter: Andrew MacBean >Assignee: Andrew MacBean > Fix For: 0.29 > > Original Estimate: 8h > Remaining Estimate: 8h > > The following test failure was observed using a 0-9-1 test profile: > Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.002 sec > <<< FAILURE! - in > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest > testIteratingFeature(org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest) > Time elapsed: 1.092 sec <<< ERROR! > javax.jms.JMSException: Error creating connection: connect() aborted > at org.apache.qpid.transport.Connection.connect(Connection.java:282) > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:221) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > The logs show that the connection was aborted while trying to determine AMQP > protocol but this also highlighted that the protocol that was tried after > 0-10 was 0-8 and not 0-9-1 as expected given the protocol downgrade assumed > ordering. > main 2014-06-11 03:30:00,976 DEBUG [apache.qpid.transport.Connection] SEND: > [conn:667876c7] AMQP.1 0-10 > IoReceiver - /127.0.0.1:33024 2014-06-11 03:30:00,977 DEBUG > [qpid.server.protocol.MultiVersionProtocolEngine] Unsupported protocol > version requested, replying with: AMQP_0_8 > IoReceiver - localhost/127.0.0.1:15672 2014-06-11 03:30:00,979 DEBUG > [apache.qpid.transport.Connection] connection closed: conn:667876c7 > main 2014-06-11 03:30:00,979 INFO [apache.qpid.client.AMQConnection] Unable > to connect to broker at tcp://localhost:15672 > org.apache.qpid.AMQException: Cannot connect to broker: connect() aborted > [error code 200: reply success] > at > org.apache.qpid.client.AMQConnectionDelegate_0_10.makeBrokerConnection(AMQConnectionDelegate_0_10.java:241) > at > org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:620) > at org.apache.qpid.client.AMQConnection.(AMQConnection.java:399) > at > org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:121) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.getConnection(DistributedTestSystemTestBase.java:68) > at > org.apache.qpid.systest.disttest.DistributedTestSystemTestBase.setUp(DistributedTestSystemTestBase.java:47) > at > org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.setUp(ControllerAndClientTest.java:62) > at junit.framework.TestCase.runBare(TestCase.java:139) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:311) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:147) > at junit.framework.TestSuite.runTest(TestSuite.java:255) > at junit.framework.TestSuite.run(TestSuite.java:250) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.ju
