[jira] [Commented] (QPID-6114) Migrate the State member variable to AbstractConfiguredObject class
[
https://issues.apache.org/jira/browse/QPID-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147591#comment-14147591
]
Alex Rudyy commented on QPID-6114:
--
Keith,
Thanks for good comments.
I believe that we need to address all your comments
{quote}
I think this change makes the overridden #getAttribute methods in ACO
subclasses redundant. Perhaps ACO#getAttribute should be made final too?
{quote}
Yes, it seems we missed that. We should remove overridden getAttribute from our
CO tree and modify ACO to call getState() for STATE attribute. That will also
fix a bug on AbstractQueue where ACTIVE is always returned as a state which is
incorrect. We missed that.
{quote}
Why is _state no longer protected by a memory barrier?
{quote}
The state is changed from Configuration thread, so, it is to some extent not
critical but I agree that we should strengthen that change _state var to be
volatile or atomic.
{quote}
Not directly related to this commit, but I wonder if
BDBHAReplicaVirtualHost should implement validateChange to reject all attempted
mutations?
{quote}
Yes it can be done. Looks like a good suggestion. Also, we might need to do
something with ManagedAttributeFields. It does not look that we can manage the
fields from the replica host at all.
Migrate the State member variable to AbstractConfiguredObject class
---
Key: QPID-6114
URL: https://issues.apache.org/jira/browse/QPID-6114
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Reporter: Andrew MacBean
Assignee: Alex Rudyy
Fix For: 0.31
As all ACOs should have State, this is the most sensible place for this and
its getter and setter to live just now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-6114) Migrate the State member variable to AbstractConfiguredObject class
[ https://issues.apache.org/jira/browse/QPID-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147660#comment-14147660 ] ASF subversion and git services commented on QPID-6114: --- Commit 1627524 from oru...@apache.org in branch 'qpid/trunk' [ https://svn.apache.org/r1627524 ] QPID-6114: Remove redundant overridden getAttribute(String) method from CO and make _state field volatile Migrate the State member variable to AbstractConfiguredObject class --- Key: QPID-6114 URL: https://issues.apache.org/jira/browse/QPID-6114 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Andrew MacBean Assignee: Alex Rudyy Fix For: 0.31 As all ACOs should have State, this is the most sensible place for this and its getter and setter to live just now. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-6117) [08..091] Race condition during close causes sporadic test failure
Keith Wall created QPID-6117:
Summary: [08..091] Race condition during close causes sporadic
test failure
Key: QPID-6117
URL: https://issues.apache.org/jira/browse/QPID-6117
Project: Qpid
Issue Type: Bug
Components: Python Client
Environment: Python 2.7.5 (default, Mar 9 2014, 22:15:05)
Mac OS X Darwin 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun 3 21:27:35 PDT
2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64
Reporter: Keith Wall
Running the Python suit (08..091) on a Mac shows a sporadic test failure with
the following stack trace:
{noformat]
Error during teardown: Traceback (most recent call last):
File ./qpid-python-test, line 340, in run
phase()
File /Users/keith/src/qpid/qpid/python/qpid/testlib.py, line 77, in
tearDown
self.client.close()
File /Users/keith/src/qpid/qpid/python/qpid/client.py, line 129, in close
self.socket.close()
File /Users/keith/src/qpid/qpid/python/qpid/connection08.py, line 63, in
close
self.sock.shutdown(SHUT_RDWR)
File
/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py,
line 224, in meth
return getattr(self._sock,name)(*args)
error: [Errno 57] Socket is not connected
{noformat}
The issue is a race between the client and server side. The unlucky timing
(causing the stack trace) is where the server side closes the socket first,
meaning the client's attempt to shutdown down the socket throws error 57.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote:
The tests are now running again, but a couple of the URL tests still seem
to be failing on the CI job:
https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/
They are all failing with:
Not a valid port number or service name: 'amqps'
Could this be a configuration problem on the CI machine, i.e. missing an
'amqps' entry in /etc/services? Can I get access to the CI machine to
poke around and see what's up?
The URL code uses socket.getservbyname() to look up service names. Is
there a more portable way to do it?
Cheers,
Alan.
As mentioned in my other post about a timeline for dropping Java6 support,
they seem to work on Java8 (havent tried Java7).
Robbie
On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote:
My bad, didn't run the java tests. Will fix ASAP and then give myself a
flogging.
On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote:
This seems to have broken the Java test runs:
https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/
On 19 September 2014 22:00, acon...@apache.org wrote:
Author: aconway
Date: Fri Sep 19 21:00:50 2014
New Revision: 1626329
URL: http://svn.apache.org/r1626329
Log:
PROTON-693: Python Url class to wrap C function pni_parse_url
It was pointed out that pni_parse_url is an internal function and the
interface
is not suitable for public API.
Rewrote the URL parser as a proper swigable C API pn_url_*. This gets
rid
of the
need for previous swig insanity and is cleaner all round.
Internally still uses the pni_parse_url parser, we can clean that up
later.
Added:
qpid/proton/trunk/proton-c/include/proton/url.h
qpid/proton/trunk/proton-c/src/url.c
Modified:
qpid/proton/trunk/proton-c/CMakeLists.txt
qpid/proton/trunk/proton-c/bindings/perl/perl.i
qpid/proton/trunk/proton-c/bindings/php/php.i
qpid/proton/trunk/proton-c/bindings/python/cproton.i
qpid/proton/trunk/proton-c/bindings/python/proton.py
qpid/proton/trunk/proton-c/bindings/ruby/ruby.i
qpid/proton/trunk/proton-c/include/proton/cproton.i
qpid/proton/trunk/tests/python/proton_tests/url.py
Modified: qpid/proton/trunk/proton-c/CMakeLists.txt
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/CMakeLists.txt (original)
+++ qpid/proton/trunk/proton-c/CMakeLists.txt Fri Sep 19 21:00:50 2014
@@ -270,6 +270,7 @@ set (qpid-proton-core
src/object/iterator.c
src/util.c
+ src/url.c
src/error.c
src/buffer.c
src/parser.c
Modified: qpid/proton/trunk/proton-c/bindings/perl/perl.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/perl/perl.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/perl/perl.i (original)
+++ qpid/proton/trunk/proton-c/bindings/perl/perl.i Fri Sep 19 21:00:50
2014
@@ -8,6 +8,7 @@
#include proton/messenger.h
#include proton/ssl.h
#include proton/driver_extras.h
+#include proton/url.h
%}
%include cstring.i
Modified: qpid/proton/trunk/proton-c/bindings/php/php.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/php/php.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/php/php.i (original)
+++ qpid/proton/trunk/proton-c/bindings/php/php.i Fri Sep 19 21:00:50
2014
@@ -29,6 +29,7 @@
%header %{
/* Include the headers needed by the code in this wrapper file */
#include proton/types.h
+#include proton/url.h
#include proton/message.h
#include proton/driver.h
#include proton/driver_extras.h
Modified: qpid/proton/trunk/proton-c/bindings/python/cproton.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/python/cproton.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/python/cproton.i (original)
+++ qpid/proton/trunk/proton-c/bindings/python/cproton.i Fri Sep 19
21:00:50 2014
@@ -23,6 +23,7 @@
#include winsock2.h
#endif
#include proton/engine.h
+#include proton/url.h
#include proton/message.h
#include proton/sasl.h
#include proton/driver.h
@@ -280,41 +281,4 @@ int pn_ssl_get_peer_hostname(pn_ssl_t *s
}
[jira] [Created] (QPID-6118) Add qmf shutdown command to the broker
Alan Conway created QPID-6118: - Summary: Add qmf shutdown command to the broker Key: QPID-6118 URL: https://issues.apache.org/jira/browse/QPID-6118 Project: Qpid Issue Type: Improvement Components: C++ Broker Affects Versions: 0.28 Reporter: Alan Conway Assignee: Alan Conway Add a QMF shutdown command to the broker. On receiving this command the broker would shut down in the same way as if it received a kill -TERM. The shutdown command must be restriced by a new ACL rule for security purposes. Discussed on the qpid user list, all responses to the idea were positive: http://qpid.2158936.n2.nabble.com/QPID-C-Dynamically-Managing-Broker-td7613792.html#a7614175 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-6117) [08..091] Race condition during close causes sporadic test failure
[
https://issues.apache.org/jira/browse/QPID-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147807#comment-14147807
]
ASF subversion and git services commented on QPID-6117:
---
Commit 1627553 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1627553 ]
QPID-6117: [Python Client 0-8..0-9] Ignore socket.error ENOTCONN when trying to
shutdown a socket to prevent spurious exception when socket closed by peer
[08..091] Race condition during close causes sporadic test failure
--
Key: QPID-6117
URL: https://issues.apache.org/jira/browse/QPID-6117
Project: Qpid
Issue Type: Bug
Components: Python Client
Environment: Python 2.7.5 (default, Mar 9 2014, 22:15:05)
Mac OS X Darwin 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun 3 21:27:35 PDT
2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64
Reporter: Keith Wall
Running the Python suit (08..091) on a Mac shows a sporadic test failure with
the following stack trace:
{noformat}
Error during teardown: Traceback (most recent call last):
File ./qpid-python-test, line 340, in run
phase()
File /Users/keith/src/qpid/qpid/python/qpid/testlib.py, line 77, in
tearDown
self.client.close()
File /Users/keith/src/qpid/qpid/python/qpid/client.py, line 129, in
close
self.socket.close()
File /Users/keith/src/qpid/qpid/python/qpid/connection08.py, line 63,
in close
self.sock.shutdown(SHUT_RDWR)
File
/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py,
line 224, in meth
return getattr(self._sock,name)(*args)
error: [Errno 57] Socket is not connected
{noformat}
The issue is a race between the client and server side. The unlucky timing
(causing the stack trace) is where the server side closes the socket first,
meaning the client's attempt to shutdown down the socket throws error 57.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-6116) [Python Client 08..091] Add ability to negotiate SASL mechanism and add support for SCRAM, CRAM, PLAIN mechanisms
[
https://issues.apache.org/jira/browse/QPID-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147808#comment-14147808
]
ASF subversion and git services commented on QPID-6116:
---
Commit 1627554 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1627554 ]
QPID-6116: [Python Client 08..091] Add ability to negotiate SASL mechanism and
add pure python implementations for SCRAM/CRAM/PLAIN mechanisms
[Python Client 08..091] Add ability to negotiate SASL mechanism and add
support for SCRAM, CRAM, PLAIN mechanisms
-
Key: QPID-6116
URL: https://issues.apache.org/jira/browse/QPID-6116
Project: Qpid
Issue Type: New Feature
Components: Python Client
Reporter: Keith Wall
On the 08..091 code path, users of the Python API are responsible for forming
the SASL response themselves and passing this as an argument to the
Client#start method. This approach works only for SASL interactions that do
not require a 'secure' step.
{code}
client = Client(localhost, 5672)
client.start(response=\0guest\0guest, mechanism=PLAIN)
{code}
The API will be changed so that Client#start accept username/password
arguments, and that the client internally selects a suitable SASL mechanism
from those offered by the server. SASL mechanisms will be included for:
* SCRAM SHA1/25
* CRAM-MD5
* PLAIN
* EXTERNAL
* ANONYMOUS
* AMQPLAIN/CRAM-MD5-HEX (legacy - to aid interoperability)
The existing API will be maintain through the change. The 0-10 paths will
not be impacted by this change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote:
On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote:
The tests are now running again, but a couple of the URL tests still seem
to be failing on the CI job:
https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/
They are all failing with:
Not a valid port number or service name: 'amqps'
Could this be a configuration problem on the CI machine, i.e. missing an
'amqps' entry in /etc/services? Can I get access to the CI machine to
poke around and see what's up?
Almost certainly no, only the core maintainers are allowed shell access as
far as I've seen. You can ask on bui...@apache.org for those with access to
check things out and report back and see what happens.
I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For
giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the
tests, which failed, and it indeed has no amqp[s] entry in /etc/services
file so that could well be it.
The URL code uses socket.getservbyname() to look up service names. Is
there a more portable way to do it?
No idea I'm afraid.
Cheers,
Alan.
As mentioned in my other post about a timeline for dropping Java6
support,
they seem to work on Java8 (havent tried Java7).
Robbie
On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote:
My bad, didn't run the java tests. Will fix ASAP and then give myself a
flogging.
On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote:
This seems to have broken the Java test runs:
https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/
On 19 September 2014 22:00, acon...@apache.org wrote:
Author: aconway
Date: Fri Sep 19 21:00:50 2014
New Revision: 1626329
URL: http://svn.apache.org/r1626329
Log:
PROTON-693: Python Url class to wrap C function pni_parse_url
It was pointed out that pni_parse_url is an internal function and
the
interface
is not suitable for public API.
Rewrote the URL parser as a proper swigable C API pn_url_*. This
gets
rid
of the
need for previous swig insanity and is cleaner all round.
Internally still uses the pni_parse_url parser, we can clean that
up
later.
Added:
qpid/proton/trunk/proton-c/include/proton/url.h
qpid/proton/trunk/proton-c/src/url.c
Modified:
qpid/proton/trunk/proton-c/CMakeLists.txt
qpid/proton/trunk/proton-c/bindings/perl/perl.i
qpid/proton/trunk/proton-c/bindings/php/php.i
qpid/proton/trunk/proton-c/bindings/python/cproton.i
qpid/proton/trunk/proton-c/bindings/python/proton.py
qpid/proton/trunk/proton-c/bindings/ruby/ruby.i
qpid/proton/trunk/proton-c/include/proton/cproton.i
qpid/proton/trunk/tests/python/proton_tests/url.py
Modified: qpid/proton/trunk/proton-c/CMakeLists.txt
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/CMakeLists.txt (original)
+++ qpid/proton/trunk/proton-c/CMakeLists.txt Fri Sep 19 21:00:50
2014
@@ -270,6 +270,7 @@ set (qpid-proton-core
src/object/iterator.c
src/util.c
+ src/url.c
src/error.c
src/buffer.c
src/parser.c
Modified: qpid/proton/trunk/proton-c/bindings/perl/perl.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/perl/perl.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/perl/perl.i (original)
+++ qpid/proton/trunk/proton-c/bindings/perl/perl.i Fri Sep 19
21:00:50
2014
@@ -8,6 +8,7 @@
#include proton/messenger.h
#include proton/ssl.h
#include proton/driver_extras.h
+#include proton/url.h
%}
%include cstring.i
Modified: qpid/proton/trunk/proton-c/bindings/php/php.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/php/php.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/php/php.i (original)
+++ qpid/proton/trunk/proton-c/bindings/php/php.i Fri Sep 19
21:00:50
2014
@@ -29,6 +29,7 @@
%header %{
/* Include the headers needed by the code in this wrapper file */
#include proton/types.h
+#include proton/url.h
#include proton/message.h
#include proton/driver.h
#include proton/driver_extras.h
Modified:
[jira] [Created] (QPID-6119) [AMQP 1.0] - java.lang.NullPointerException on reconnect when link has been down between client and broker
Mathias Wiberg created QPID-6119: Summary: [AMQP 1.0] - java.lang.NullPointerException on reconnect when link has been down between client and broker Key: QPID-6119 URL: https://issues.apache.org/jira/browse/QPID-6119 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.28 Reporter: Mathias Wiberg Getting a NullPointerException upon reconnect when the link between the client and the broker has been down (for example, due to network issues). Caused by: java.lang.NullPointerException: null at org.apache.qpid.amqp_1_0.client.Connection.checkNotClosed(Connection.java:298) ~[qpid-amqp-1-0-client-0.28.jar:na] at org.apache.qpid.amqp_1_0.client.Connection.createSession(Connection.java:289) ~[qpid-amqp-1-0-client-0.28.jar:na] at org.apache.qpid.amqp_1_0.jms.impl.SessionImpl.init(SessionImpl.java:86) ~[qpid-amqp-1-0-client-jms-0.28.jar:na] at org.apache.qpid.amqp_1_0.jms.impl.ConnectionImpl.createSession(ConnectionImpl.java:231) ~[qpid-amqp-1-0-client-jms-0.28.jar:na] at org.apache.qpid.amqp_1_0.jms.impl.ConnectionImpl.createSession(ConnectionImpl.java:210) ~[qpid-amqp-1-0-client-jms-0.28.jar:na] at org.apache.qpid.amqp_1_0.jms.impl.ConnectionImpl.createSession(ConnectionImpl.java:40) ~[qpid-amqp-1-0-client-jms-0.28.jar:na] at sun.reflect.GeneratedMethodAccessor234.invoke(Unknown Source) ~[na:na] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) ~[na:1.6.0_33] at java.lang.reflect.Method.invoke(Method.java:597) ~[na:1.6.0_33] at org.springframework.jms.connection.SingleConnectionFactory$SharedConnectionInvocationHandler.invoke(SingleConnectionFactory.java:571) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at $Proxy75.createSession(Unknown Source) ~[na:na] at org.springframework.jms.support.JmsAccessor.createSession(JmsAccessor.java:197) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:482) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at org.springframework.jms.core.JmsTemplate.send(JmsTemplate.java:577) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at org.springframework.jms.core.JmsTemplate.convertAndSend(JmsTemplate.java:703) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at org.springframework.integration.jms.JmsSendingMessageHandler.send(JmsSendingMessageHandler.java:145) ~[spring-integration-jms-4.0.0.M3.jar:na] at org.springframework.integration.jms.JmsSendingMessageHandler.handleMessageInternal(JmsSendingMessageHandler.java:115) ~[spring-integration-jms-4.0.0.M3.jar:na] -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-6119) [AMQP 1.0] - java.lang.NullPointerException on reconnect when link has been down between client and broker
[ https://issues.apache.org/jira/browse/QPID-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147930#comment-14147930 ] Rob Godfrey commented on QPID-6119: --- Have you tested this with the 0.30 release candidate (https://dist.apache.org/repos/dist/dev/qpid/0.30-rc/)? It looks to me that the change made for QPID-5756 will fix this issue. The release candidate has passed the vote and should be released as 0.30 real soon now. [AMQP 1.0] - java.lang.NullPointerException on reconnect when link has been down between client and broker -- Key: QPID-6119 URL: https://issues.apache.org/jira/browse/QPID-6119 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.28 Reporter: Mathias Wiberg Getting a NullPointerException upon reconnect when the link between the client and the broker has been down (for example, due to network issues). Caused by: java.lang.NullPointerException: null at org.apache.qpid.amqp_1_0.client.Connection.checkNotClosed(Connection.java:298) ~[qpid-amqp-1-0-client-0.28.jar:na] at org.apache.qpid.amqp_1_0.client.Connection.createSession(Connection.java:289) ~[qpid-amqp-1-0-client-0.28.jar:na] at org.apache.qpid.amqp_1_0.jms.impl.SessionImpl.init(SessionImpl.java:86) ~[qpid-amqp-1-0-client-jms-0.28.jar:na] at org.apache.qpid.amqp_1_0.jms.impl.ConnectionImpl.createSession(ConnectionImpl.java:231) ~[qpid-amqp-1-0-client-jms-0.28.jar:na] at org.apache.qpid.amqp_1_0.jms.impl.ConnectionImpl.createSession(ConnectionImpl.java:210) ~[qpid-amqp-1-0-client-jms-0.28.jar:na] at org.apache.qpid.amqp_1_0.jms.impl.ConnectionImpl.createSession(ConnectionImpl.java:40) ~[qpid-amqp-1-0-client-jms-0.28.jar:na] at sun.reflect.GeneratedMethodAccessor234.invoke(Unknown Source) ~[na:na] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) ~[na:1.6.0_33] at java.lang.reflect.Method.invoke(Method.java:597) ~[na:1.6.0_33] at org.springframework.jms.connection.SingleConnectionFactory$SharedConnectionInvocationHandler.invoke(SingleConnectionFactory.java:571) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at $Proxy75.createSession(Unknown Source) ~[na:na] at org.springframework.jms.support.JmsAccessor.createSession(JmsAccessor.java:197) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:482) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at org.springframework.jms.core.JmsTemplate.send(JmsTemplate.java:577) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at org.springframework.jms.core.JmsTemplate.convertAndSend(JmsTemplate.java:703) ~[spring-jms-4.0.1.RELEASE.jar:4.0.1.RELEASE] at org.springframework.integration.jms.JmsSendingMessageHandler.send(JmsSendingMessageHandler.java:145) ~[spring-integration-jms-4.0.0.M3.jar:na] at org.springframework.integration.jms.JmsSendingMessageHandler.handleMessageInternal(JmsSendingMessageHandler.java:115) ~[spring-integration-jms-4.0.0.M3.jar:na] -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-56) Implement Create/Read/Update/Delete operations in the agent
[ https://issues.apache.org/jira/browse/DISPATCH-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148045#comment-14148045 ] ASF subversion and git services commented on DISPATCH-56: - Commit 1627576 from [~aconway] in branch 'dispatch/trunk' [ https://svn.apache.org/r1627576 ] DISPATCH-56: Remove dead configuration code. Replace router.configuration with management.agent configuration code. Implement Create/Read/Update/Delete operations in the agent --- Key: DISPATCH-56 URL: https://issues.apache.org/jira/browse/DISPATCH-56 Project: Qpid Dispatch Issue Type: Sub-task Components: Management Agent Reporter: Ted Ross Assignee: Alan Conway Fix For: 0.3 Implement the CRUD-style commands in the management agent and use them to access waypoints, address-prefixes, self, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. Added: qpid/proton/trunk/proton-c/include/proton/url.h qpid/proton/trunk/proton-c/src/url.c Modified: qpid/proton/trunk/proton-c/CMakeLists.txt qpid/proton/trunk/proton-c/bindings/perl/perl.i qpid/proton/trunk/proton-c/bindings/php/php.i qpid/proton/trunk/proton-c/bindings/python/cproton.i qpid/proton/trunk/proton-c/bindings/python/proton.py qpid/proton/trunk/proton-c/bindings/ruby/ruby.i qpid/proton/trunk/proton-c/include/proton/cproton.i qpid/proton/trunk/tests/python/proton_tests/url.py Modified: qpid/proton/trunk/proton-c/CMakeLists.txt URL: http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1626329r1=1626328r2=1626329view=diff == --- qpid/proton/trunk/proton-c/CMakeLists.txt (original) +++ qpid/proton/trunk/proton-c/CMakeLists.txt Fri Sep 19 21:00:50 2014 @@ -270,6 +270,7 @@ set (qpid-proton-core src/object/iterator.c src/util.c + src/url.c src/error.c src/buffer.c src/parser.c Modified: qpid/proton/trunk/proton-c/bindings/perl/perl.i URL: http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/perl/perl.i?rev=1626329r1=1626328r2=1626329view=diff == --- qpid/proton/trunk/proton-c/bindings/perl/perl.i (original) +++ qpid/proton/trunk/proton-c/bindings/perl/perl.i Fri Sep 19 21:00:50 2014 @@ -8,6 +8,7 @@ #include proton/messenger.h #include proton/ssl.h #include proton/driver_extras.h +#include proton/url.h %} %include cstring.i
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
Failing in a different way now, the overall run of the python tests bombs out. I see the same thing locally, where it was working when I made the commit immediately before yours :) https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/683/console Running org.apache.qpid.proton.JythonTest Sep 25, 2014 6:03:44 PM org.apache.qpid.proton.JythonTest test INFO: About to call Jython test script: '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test' with '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python' added to Jython path Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.714 sec FAILURE! test(org.apache.qpid.proton.JythonTest) Time elapsed: 7.675 sec FAILURE! java.lang.AssertionError: Caught PyException on invocation number 2: Traceback (most recent call last): File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 597, in module h.scan(m) File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 587, in scan if not (child in self.scanned or child in objects): TypeError: object of type 'object' has no len() with message: null at org.junit.Assert.fail(Assert.java:93) at org.apache.qpid.proton.JythonTest.runTestOnce(JythonTest.java:120) at org.apache.qpid.proton.JythonTest.test(JythonTest.java:95) On 25 September 2014 18:59, Alan Conway acon...@redhat.com wrote: On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. Added: qpid/proton/trunk/proton-c/include/proton/url.h qpid/proton/trunk/proton-c/src/url.c Modified: qpid/proton/trunk/proton-c/CMakeLists.txt qpid/proton/trunk/proton-c/bindings/perl/perl.i qpid/proton/trunk/proton-c/bindings/php/php.i
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
Hum, CI is still broken. https://builds.apache.org/job/Qpid-proton-j/org.apache.qpid $proton-tests/683/testReport/org.apache.qpid.proton/JythonTest/test/ Somehow my trivial re-org of the URL tests in python has caused the entire Jython test harness to explode in flight. It works fine on my box in python and Jython, and it works on CI in regular python - so maybe another Java 6 issue? Will I lose my mind if I try to install Java 6 on Fedora and get proton to use it? On Thu, 2014-09-25 at 13:59 -0400, Alan Conway wrote: On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. Added: qpid/proton/trunk/proton-c/include/proton/url.h qpid/proton/trunk/proton-c/src/url.c Modified: qpid/proton/trunk/proton-c/CMakeLists.txt qpid/proton/trunk/proton-c/bindings/perl/perl.i qpid/proton/trunk/proton-c/bindings/php/php.i qpid/proton/trunk/proton-c/bindings/python/cproton.i qpid/proton/trunk/proton-c/bindings/python/proton.py qpid/proton/trunk/proton-c/bindings/ruby/ruby.i qpid/proton/trunk/proton-c/include/proton/cproton.i qpid/proton/trunk/tests/python/proton_tests/url.py Modified: qpid/proton/trunk/proton-c/CMakeLists.txt URL: http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1626329r1=1626328r2=1626329view=diff == --- qpid/proton/trunk/proton-c/CMakeLists.txt (original) +++ qpid/proton/trunk/proton-c/CMakeLists.txt Fri Sep 19 21:00:50 2014 @@ -270,6 +270,7 @@ set (qpid-proton-core src/object/iterator.c src/util.c + src/url.c src/error.c src/buffer.c src/parser.c
Review Request 26050: PROTON-660: Fix openssl.c build on windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26050/ --- Review request for qpid and Rafael Schloming. Repository: qpid Description --- * all files: Reorder includes so they are always from public to private * platform.h: - replace strcasecmp with !pn_i_eq_nocase - replace strncasecmp with !pn_i_eq_n_nocase - include winsock.h on windows - undefine symbols 'ERROR' and 'small' that proton codebase uses. The openssl is actually fixed by makeing sure the winsock.h is included before openssl headers. Diffs - proton/trunk/proton-c/src/buffer.c 1627588 proton/trunk/proton-c/src/codec/codec.c 1627588 proton/trunk/proton-c/src/codec/decoder.c 1627588 proton/trunk/proton-c/src/codec/encoder.c 1627588 proton/trunk/proton-c/src/dispatcher/dispatcher.c 1627588 proton/trunk/proton-c/src/engine/engine.c 1627588 proton/trunk/proton-c/src/error.c 1627588 proton/trunk/proton-c/src/events/event.c 1627588 proton/trunk/proton-c/src/message/message.c 1627588 proton/trunk/proton-c/src/messenger/messenger.c 1627588 proton/trunk/proton-c/src/messenger/store.c 1627588 proton/trunk/proton-c/src/messenger/subscription.c 1627588 proton/trunk/proton-c/src/messenger/transform.c 1627588 proton/trunk/proton-c/src/object/iterator.c 1627588 proton/trunk/proton-c/src/object/list.c 1627588 proton/trunk/proton-c/src/object/map.c 1627588 proton/trunk/proton-c/src/object/object.c 1627588 proton/trunk/proton-c/src/object/string.c 1627588 proton/trunk/proton-c/src/parser.c 1627588 proton/trunk/proton-c/src/platform.h 1627588 proton/trunk/proton-c/src/sasl/sasl.c 1627588 proton/trunk/proton-c/src/scanner.c 1627588 proton/trunk/proton-c/src/selectable.c 1627588 proton/trunk/proton-c/src/ssl/openssl.c 1627588 proton/trunk/proton-c/src/transport/transport.c 1627588 proton/trunk/proton-c/src/types.c 1627588 proton/trunk/proton-c/src/url.c 1627588 proton/trunk/proton-c/src/util.h 1627588 proton/trunk/proton-c/src/util.c 1627588 proton/trunk/proton-c/src/windows/driver.c 1627588 proton/trunk/proton-c/src/windows/io.c 1627588 proton/trunk/proton-c/src/windows/iocp.c 1627588 proton/trunk/proton-c/src/windows/selector.c 1627588 proton/trunk/proton-c/src/windows/write_pipeline.c 1627588 Diff: https://reviews.apache.org/r/26050/diff/ Testing --- compiled on windows. I'll buildtest and test all components, for now just testing the patch process Thanks, bozzo bozzo
[jira] [Created] (QPID-6120) Qpid 0.28 python unit test failure: testSenderClose
Martin Vierula created QPID-6120: Summary: Qpid 0.28 python unit test failure: testSenderClose Key: QPID-6120 URL: https://issues.apache.org/jira/browse/QPID-6120 Project: Qpid Issue Type: Bug Components: Python Test Suite Affects Versions: 0.28 Environment: python 2.7.3-0ubuntu2.2; Ubuntu 12.04 Reporter: Martin Vierula Priority: Minor I recently downloaded Qpid 0.28 GA and at make test step in .../cpp/INSTALL I saw exactly one of the 30 tests fail ... specifically 1 of the 537 python tests. Within TimeoutTests, if testConnectionOpen runs in its alpha order then one of the tests that follows will fail (testSenderClose). However, if I rename testConnectionOpen so that it runs last (as it is actually ordered in the file), then there is no failure. Given my previous sentence, I fairly strongly suspect that this does not indicate any real problem with the actual application code, but I thought it worth inquiry about this. Note the actual failure in the error case is: File /home/MATTER/mvierula/Qpid_0_28/qpid-0.28/cpp/BLD/src/tests/python/qpid/messaging/endpoints.py, line 212, in check_error raise e ConnectionError: connection aborted Is this a known anomaly? Or is there some idiosyncrasy involved here? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-6120) Qpid 0.28 python unit test failure: testSenderClose
[ https://issues.apache.org/jira/browse/QPID-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Vierula updated QPID-6120: - Description: I recently downloaded Qpid 0.28 GA and at make test step in .../cpp/INSTALL I saw exactly one of the 30 tests fail ... specifically 1 of the 537 python tests. Within TimeoutTests, if testConnectionOpen runs in its alpha order then one of the tests that follows will fail (testSenderClose). However, if I rename testConnectionOpen so that it runs last (as it is actually ordered in the file), then there is no failure. Given my previous sentence, I fairly strongly suspect that this does not indicate any real problem with the actual application code, but I thought it worth inquiring about this. Note the actual failure in the error case is: File /home/MATTER/mvierula/Qpid_0_28/qpid-0.28/cpp/BLD/src/tests/python/qpid/messaging/endpoints.py, line 212, in check_error raise e ConnectionError: connection aborted Is this a known anomaly? Or is there some idiosyncrasy involved here? was: I recently downloaded Qpid 0.28 GA and at make test step in .../cpp/INSTALL I saw exactly one of the 30 tests fail ... specifically 1 of the 537 python tests. Within TimeoutTests, if testConnectionOpen runs in its alpha order then one of the tests that follows will fail (testSenderClose). However, if I rename testConnectionOpen so that it runs last (as it is actually ordered in the file), then there is no failure. Given my previous sentence, I fairly strongly suspect that this does not indicate any real problem with the actual application code, but I thought it worth inquiry about this. Note the actual failure in the error case is: File /home/MATTER/mvierula/Qpid_0_28/qpid-0.28/cpp/BLD/src/tests/python/qpid/messaging/endpoints.py, line 212, in check_error raise e ConnectionError: connection aborted Is this a known anomaly? Or is there some idiosyncrasy involved here? Qpid 0.28 python unit test failure: testSenderClose --- Key: QPID-6120 URL: https://issues.apache.org/jira/browse/QPID-6120 Project: Qpid Issue Type: Bug Components: Python Test Suite Affects Versions: 0.28 Environment: python 2.7.3-0ubuntu2.2; Ubuntu 12.04 Reporter: Martin Vierula Priority: Minor Labels: newbie I recently downloaded Qpid 0.28 GA and at make test step in .../cpp/INSTALL I saw exactly one of the 30 tests fail ... specifically 1 of the 537 python tests. Within TimeoutTests, if testConnectionOpen runs in its alpha order then one of the tests that follows will fail (testSenderClose). However, if I rename testConnectionOpen so that it runs last (as it is actually ordered in the file), then there is no failure. Given my previous sentence, I fairly strongly suspect that this does not indicate any real problem with the actual application code, but I thought it worth inquiring about this. Note the actual failure in the error case is: File /home/MATTER/mvierula/Qpid_0_28/qpid-0.28/cpp/BLD/src/tests/python/qpid/messaging/endpoints.py, line 212, in check_error raise e ConnectionError: connection aborted Is this a known anomaly? Or is there some idiosyncrasy involved here? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
On Thu, 2014-09-25 at 19:20 +0100, Robbie Gemmell wrote: Failing in a different way now, the overall run of the python tests bombs out. I see the same thing locally, where it was working when I made the commit immediately before yours :) r1627621 | aconway | 2014-09-25 15:40:22 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to not explode under jython. Turns out the proton test harness blows up when run under jython if you import socket in a test module. Works fine under real python. Go figure. https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/683/console Running org.apache.qpid.proton.JythonTest Sep 25, 2014 6:03:44 PM org.apache.qpid.proton.JythonTest test INFO: About to call Jython test script: '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test' with '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python' added to Jython path Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.714 sec FAILURE! test(org.apache.qpid.proton.JythonTest) Time elapsed: 7.675 sec FAILURE! java.lang.AssertionError: Caught PyException on invocation number 2: Traceback (most recent call last): File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 597, in module h.scan(m) File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 587, in scan if not (child in self.scanned or child in objects): TypeError: object of type 'object' has no len() with message: null at org.junit.Assert.fail(Assert.java:93) at org.apache.qpid.proton.JythonTest.runTestOnce(JythonTest.java:120) at org.apache.qpid.proton.JythonTest.test(JythonTest.java:95) On 25 September 2014 18:59, Alan Conway acon...@redhat.com wrote: On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API.
[jira] [Created] (QPID-6121) Create dynamic/wildcard mapping for static links and waypoints
Jack Gibson created QPID-6121: - Summary: Create dynamic/wildcard mapping for static links and waypoints Key: QPID-6121 URL: https://issues.apache.org/jira/browse/QPID-6121 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Jack Gibson For dynamic routing create a wildcard semantic such that local addresses map to multiple waypoints or such that waypoints can be a wildcard. This may be accomplished with a prefix for waypoints to ease configuration such that any address that matches a waypoint prefix would be routed over a series of connections waypoint: prefix: /foo/ connector: broker1 amqp://router_addr/foo/bar - would dispatch messages to broker1/bar amqp://router_addr/foo/baz - would dispatch messages to broker1/baz This could also be combined with local addressing to do balanced, multicast, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 26050: PROTON-660: Fix openssl.c build on windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26050/#review54599 --- proton/trunk/proton-c/src/buffer.c https://reviews.apache.org/r/26050/#comment94786 The qpid 'standard' for every c file that has a defining h file is to include that h file first. This ensures that the file (here proton/buffer.h) compiles standalone and that is tested every time buffer.c is compiled. The qpid cpp code base is probably more strict about using that pattern than the proton c code base. - Chug Rolke On Sept. 25, 2014, 7:10 p.m., bozzo bozzo wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26050/ --- (Updated Sept. 25, 2014, 7:10 p.m.) Review request for qpid and Rafael Schloming. Repository: qpid Description --- * all files: Reorder includes so they are always from public to private * platform.h: - replace strcasecmp with !pn_i_eq_nocase - replace strncasecmp with !pn_i_eq_n_nocase - include winsock.h on windows - undefine symbols 'ERROR' and 'small' that proton codebase uses. The openssl is actually fixed by makeing sure the winsock.h is included before openssl headers. Diffs - proton/trunk/proton-c/src/buffer.c 1627588 proton/trunk/proton-c/src/codec/codec.c 1627588 proton/trunk/proton-c/src/codec/decoder.c 1627588 proton/trunk/proton-c/src/codec/encoder.c 1627588 proton/trunk/proton-c/src/dispatcher/dispatcher.c 1627588 proton/trunk/proton-c/src/engine/engine.c 1627588 proton/trunk/proton-c/src/error.c 1627588 proton/trunk/proton-c/src/events/event.c 1627588 proton/trunk/proton-c/src/message/message.c 1627588 proton/trunk/proton-c/src/messenger/messenger.c 1627588 proton/trunk/proton-c/src/messenger/store.c 1627588 proton/trunk/proton-c/src/messenger/subscription.c 1627588 proton/trunk/proton-c/src/messenger/transform.c 1627588 proton/trunk/proton-c/src/object/iterator.c 1627588 proton/trunk/proton-c/src/object/list.c 1627588 proton/trunk/proton-c/src/object/map.c 1627588 proton/trunk/proton-c/src/object/object.c 1627588 proton/trunk/proton-c/src/object/string.c 1627588 proton/trunk/proton-c/src/parser.c 1627588 proton/trunk/proton-c/src/platform.h 1627588 proton/trunk/proton-c/src/sasl/sasl.c 1627588 proton/trunk/proton-c/src/scanner.c 1627588 proton/trunk/proton-c/src/selectable.c 1627588 proton/trunk/proton-c/src/ssl/openssl.c 1627588 proton/trunk/proton-c/src/transport/transport.c 1627588 proton/trunk/proton-c/src/types.c 1627588 proton/trunk/proton-c/src/url.c 1627588 proton/trunk/proton-c/src/util.h 1627588 proton/trunk/proton-c/src/util.c 1627588 proton/trunk/proton-c/src/windows/driver.c 1627588 proton/trunk/proton-c/src/windows/io.c 1627588 proton/trunk/proton-c/src/windows/iocp.c 1627588 proton/trunk/proton-c/src/windows/selector.c 1627588 proton/trunk/proton-c/src/windows/write_pipeline.c 1627588 Diff: https://reviews.apache.org/r/26050/diff/ Testing --- compiled on windows. I'll buildtest and test all components, for now just testing the patch process Thanks, bozzo bozzo
[jira] [Updated] (QPID-6108) Java Broker - Document changes made by 0.30
[ https://issues.apache.org/jira/browse/QPID-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-6108: - Attachment: (was: 0001-QPID-6108-Java-Broker-Documentation-Remove-reference.patch) Java Broker - Document changes made by 0.30 --- Key: QPID-6108 URL: https://issues.apache.org/jira/browse/QPID-6108 Project: Qpid Issue Type: Improvement Components: Documentation, Java Broker Reporter: Keith Wall Assignee: Keith Wall Attachments: 0001-QPID-6108-Java-Broker-Documentation-doc-updates.patch * support for virtualhost.xml removed * introduction of VHN into the model * REST API changes * Queue messageDurability/TTL controls * Parallel recovery * Flow to disk * Multi node HA support -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: svn commit: r1627444 - in /qpid/proton/trunk: proton-c/bindings/python/ proton-c/include/proton/ proton-c/src/engine/ proton-c/src/transport/ proton-j/src/main/java/org/apache/qpid/proton/engine/
This commit changes pn_transport_error() into pn_transport_condition() and that
breaks qpid messaging at
18..\..\src\qpid\messaging\amqp\ConnectionContext.cpp(811) : error C3861:
'pn_transport_error':
identifier not found
- Original Message -
From: r...@apache.org
To: comm...@qpid.apache.org
Sent: Wednesday, September 24, 2014 10:08:14 PM
Subject: svn commit: r1627444 - in /qpid/proton/trunk:
proton-c/bindings/python/ proton-c/include/proton/
proton-c/src/engine/ proton-c/src/transport/
proton-j/src/main/java/org/apache/qpid/proton/engine/
proton-j/src/main/java/org/apache/qpid/proton/engine/imp...
Author: rhs
Date: Thu Sep 25 02:08:13 2014
New Revision: 1627444
URL: http://svn.apache.org/r1627444
Log:
PROTON-689: added a condition to the transport along with bindings to expose
it
Modified:
qpid/proton/trunk/proton-c/bindings/python/proton.py
qpid/proton/trunk/proton-c/include/proton/transport.h
qpid/proton/trunk/proton-c/src/engine/engine-internal.h
qpid/proton/trunk/proton-c/src/transport/transport.c
qpid/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/Transport.java
qpid/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java
qpid/proton/trunk/proton-j/src/main/resources/cengine.py
qpid/proton/trunk/tests/python/proton_tests/engine.py
Modified: qpid/proton/trunk/proton-c/bindings/python/proton.py
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/python/proton.py?rev=1627444r1=1627443r2=1627444view=diff
==
--- qpid/proton/trunk/proton-c/bindings/python/proton.py (original)
+++ qpid/proton/trunk/proton-c/bindings/python/proton.py Thu Sep 25 02:08:13
2014
@@ -3136,6 +3136,10 @@ The idle timeout of the connection (floa
self._ssl = SSL(self, domain, session_details)
return self._ssl
+ @property
+ def condition(self):
+return cond2obj(pn_transport_condition(self._trans))
+
class SASLException(TransportException):
pass
Modified: qpid/proton/trunk/proton-c/include/proton/transport.h
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/include/proton/transport.h?rev=1627444r1=1627443r2=1627444view=diff
==
--- qpid/proton/trunk/proton-c/include/proton/transport.h (original)
+++ qpid/proton/trunk/proton-c/include/proton/transport.h Thu Sep 25 02:08:13
2014
@@ -24,6 +24,7 @@
#include proton/import_export.h
#include proton/type_compat.h
+#include proton/condition.h
#include stddef.h
#include sys/types.h
@@ -103,20 +104,18 @@ PN_EXTERN pn_transport_t *pn_transport(v
PN_EXTERN void pn_transport_free(pn_transport_t *transport);
/**
- * Get additional error information associated with the transport.
+ * Get additional information about the condition of the transport.
*
- * Whenever a transport operation fails (i.e. returns an error code),
- * additional error details can be obtained using this function. The
- * error object that is returned may also be used to clear the error
- * condition.
+ * When a PN_TRANSPORT_ERROR event occurs, this operation can be used
+ * to access the details of the error condtion.
*
* The pointer returned by this operation is valid until the
* transport object is freed.
*
* @param[in] transport the transport object
- * @return the transport's error object
+ * @return the transport's condition object
*/
-PN_EXTERN pn_error_t *pn_transport_error(pn_transport_t *transport);
+PN_EXTERN pn_condition_t *pn_transport_condition(pn_transport_t *transport);
/**
* Binds the transport to an AMQP connection.
Modified: qpid/proton/trunk/proton-c/src/engine/engine-internal.h
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/src/engine/engine-internal.h?rev=1627444r1=1627443r2=1627444view=diff
==
--- qpid/proton/trunk/proton-c/src/engine/engine-internal.h (original)
+++ qpid/proton/trunk/proton-c/src/engine/engine-internal.h Thu Sep 25
02:08:13 2014
@@ -127,6 +127,7 @@ struct pn_transport_t {
uint32_t local_max_frame;
uint32_t remote_max_frame;
pn_condition_t remote_condition;
+ pn_condition_t condition;
#define PN_IO_SSL 0
#define PN_IO_SASL 1
Modified: qpid/proton/trunk/proton-c/src/transport/transport.c
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/src/transport/transport.c?rev=1627444r1=1627443r2=1627444view=diff
==
--- qpid/proton/trunk/proton-c/src/transport/transport.c (original)
+++ qpid/proton/trunk/proton-c/src/transport/transport.c Thu Sep 25 02:08:13
2014
@@ -163,6 +163,7 @@ static void pn_transport_initialize(void
transport-remote_properties
[jira] [Commented] (QPID-6108) Java Broker - Document changes made by 0.30
[
https://issues.apache.org/jira/browse/QPID-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148446#comment-14148446
]
Rob Godfrey commented on QPID-6108:
---
Looking at your patch, although I think the changes are mostly just formatting,
the parts on the available types for the broker configuration store are now
incorrect, e.g.:
{code:xml}
para There are currently two implementations of the pluggable Broker
Configuration Store,
the default one which persists content to disk in a JSON file, and
another which
operates only in-memory and so does not retain changes across
broker restarts and always
relies on the current link
linkend=Java-Broker-Configuring-And-Managing-Configuration-Store-Initial-Config-Location
'Initial Configuration'/link to provide the configuration to
start the broker
with. /para
para The command line argument emphasis-st/emphasis (or
emphasis--store-type/emphasis) can be used to override the
default
emphasisjson/emphasis)configuration store type and allow
choosing an alterative,
such as emphasismemory/emphasis) /para
{code}
The store type can now be Derby or BDB or any other valid configuration store
type
Java Broker - Document changes made by 0.30
---
Key: QPID-6108
URL: https://issues.apache.org/jira/browse/QPID-6108
Project: Qpid
Issue Type: Improvement
Components: Documentation, Java Broker
Reporter: Keith Wall
Assignee: Keith Wall
Attachments:
0001-QPID-6108-Java-Broker-Documentation-doc-updates.patch
* support for virtualhost.xml removed
* introduction of VHN into the model
* REST API changes
* Queue messageDurability/TTL controls
* Parallel recovery
* Flow to disk
* Multi node HA support
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
