Review Request 45340: turn off async ANONYMOUS SASL negotiation by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45340/ --- Review request for qpid. Bugs: PROTON-1135 https://issues.apache.org/jira/browse/PROTON-1135 Repository: qpid-proton-git Description --- Add new sasl api methods: pn_sasl_set_async_negotiation pn_sasl_get_async_negotiation Turn async off by default Add python test. Diffs - proton-c/bindings/python/proton/__init__.py 5ffede8 proton-c/include/proton/sasl.h 354982f proton-c/src/sasl/sasl-internal.h b3f4c7f proton-c/src/sasl/sasl.c 29d377e tests/python/proton_tests/engine.py 0a6eb8d tests/python/proton_tests/sasl.py 6adb77d Diff: https://reviews.apache.org/r/45340/diff/ Testing --- linux ctest Thanks, Cliff Jansen
[jira] [Resolved] (QPID-7063) [Java Broker] SimpleLdap Authentication Provider should be able to override enabled cipher suites and TLS protocols from context variables for TLS connections to LDAP ser
[ https://issues.apache.org/jira/browse/QPID-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-7063. -- Resolution: Fixed Changes look reasonable to me > [Java Broker] SimpleLdap Authentication Provider should be able to override > enabled cipher suites and TLS protocols from context variables for TLS > connections to LDAP servers > -- > > Key: QPID-7063 > URL: https://issues.apache.org/jira/browse/QPID-7063 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.1 >Reporter: Alex Rudyy >Assignee: Alex Rudyy > Fix For: qpid-java-6.1 > > Attachments: > 0001-QPID-7063-Java-Broker-Allow-TLS-protocols-cipher-sui.patch > > > At the moment, required TLS protocols and cipher suites can not be set in > SSLConetextFactory created in SampleLdap Authentication Provider for TLS > connections. As result, Qpid users cannot override TLS protocols and cipher > suites to use in TLS connections to LDAP servers which might cause a > selection of weaker cipher suites during TLS negotiation or even can prevent > establishing of TLS connections in JVM implementations not supporting > downgrade of TLS protocol -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-6983) [Web Management Console] Add UI support for queries
[ https://issues.apache.org/jira/browse/QPID-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212174#comment-15212174 ] ASF subversion and git services commented on QPID-6983: --- Commit 1736626 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1736626 ] QPID-6983: Revert unintendent changes with work in progress committed by mistake > [Web Management Console] Add UI support for queries > --- > > Key: QPID-6983 > URL: https://issues.apache.org/jira/browse/QPID-6983 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Alex Rudyy > Attachments: query-ui-prototype.tar.gz > > > Add the ability to the Web Management Console to submit queries (using the > feature added by QPID-6969) and view the results. The results may need to be > paginated for display. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7063) [Java Broker] SimpleLdap Authentication Provider should be able to override enabled cipher suites and TLS protocols from context variables for TLS connections to LDAP se
[ https://issues.apache.org/jira/browse/QPID-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212168#comment-15212168 ] ASF subversion and git services commented on QPID-7063: --- Commit 1736623 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1736623 ] QPID-7063: Fix potential cause for NullPointerException > [Java Broker] SimpleLdap Authentication Provider should be able to override > enabled cipher suites and TLS protocols from context variables for TLS > connections to LDAP servers > -- > > Key: QPID-7063 > URL: https://issues.apache.org/jira/browse/QPID-7063 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Affects Versions: qpid-java-6.0, qpid-java-6.1 >Reporter: Alex Rudyy >Assignee: Alex Rudyy > Fix For: qpid-java-6.1 > > Attachments: > 0001-QPID-7063-Java-Broker-Allow-TLS-protocols-cipher-sui.patch > > > At the moment, required TLS protocols and cipher suites can not be set in > SSLConetextFactory created in SampleLdap Authentication Provider for TLS > connections. As result, Qpid users cannot override TLS protocols and cipher > suites to use in TLS connections to LDAP servers which might cause a > selection of weaker cipher suites during TLS negotiation or even can prevent > establishing of TLS connections in JVM implementations not supporting > downgrade of TLS protocol -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-6983) [Web Management Console] Add UI support for queries
[ https://issues.apache.org/jira/browse/QPID-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212167#comment-15212167 ] ASF subversion and git services commented on QPID-6983: --- Commit 1736622 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1736622 ] QPID-6983: WIP - Add query UI > [Web Management Console] Add UI support for queries > --- > > Key: QPID-6983 > URL: https://issues.apache.org/jira/browse/QPID-6983 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Alex Rudyy > Attachments: query-ui-prototype.tar.gz > > > Add the ability to the Web Management Console to submit queries (using the > feature added by QPID-6969) and view the results. The results may need to be > paginated for display. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (QPID-7112) Create UI for the CloudFoundry Group Provider
[ https://issues.apache.org/jira/browse/QPID-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reopened QPID-7112: -- I noticed that change made in method util.getFormWidgetValues of util.js under revision r1736195 has unexpected side effect causing all undefined widget values to be returned as string "undefined". As result, "undefined" values can be sent to broker as part of create/change rest requests, whilst before they have not been sent. Try to edit Broker tab (for example, setting max session numbers to 512) to see the results. Perhaps , sending of undefined as string is the right thing to do from http point of view. > Create UI for the CloudFoundry Group Provider > - > > Key: QPID-7112 > URL: https://issues.apache.org/jira/browse/QPID-7112 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Minor > Fix For: qpid-java-6.1 > > Attachments: > 0001-QPID-7112-Java-Broker-Add-UI-for-CloudFoundryDashboa.patch, > 0001-QPID-7112-Java-Broker-Add-UI-for-CloudFoundryDashboa.patch > > > Create UI for the CloudFoundry Group Provider -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7164) Python test qpid_tests.broker_0_10.new_api.GeneralTests.test_qpid_3481_acquired_to_alt_exchange fails against Java Broker
[
https://issues.apache.org/jira/browse/QPID-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212137#comment-15212137
]
ASF subversion and git services commented on QPID-7164:
---
Commit 1736620 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1736620 ]
QPID-7164: [Java Broker/Python Test Suite] Temporarily exclude
GeneralTests.test_qpid_3481_acquired_to_alt_exchange
> Python test
> qpid_tests.broker_0_10.new_api.GeneralTests.test_qpid_3481_acquired_to_alt_exchange
> fails against Java Broker
> -
>
> Key: QPID-7164
> URL: https://issues.apache.org/jira/browse/QPID-7164
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Python Test Suite
>Reporter: Keith Wall
>
> The following Python test is currently failing against the Java Broker.
> This is related to the routing of messages to the alternate exchanges.
> {noformat}
> Error during test: Traceback (most recent call last):
> File "qpid-python-test", line 340, in run
> phase()
> File
> "/home/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py",
> line 85, in test_qpid_3481_acquired_to_alt_exchange
> self.assertEqual(rx_alt.available(), 5, "All 5 messages should have
> been routed to the alt_exchange")
> File
> "/home/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py",
> line 39, in assertEqual
> assert None
> AssertionError
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7164) Python test qpid_tests.broker_0_10.new_api.GeneralTests.test_qpid_3481_acquired_to_alt_exchange fails against Java Broker
[
https://issues.apache.org/jira/browse/QPID-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212129#comment-15212129
]
Keith Wall commented on QPID-7164:
--
I have not yet done any investigation into this issue. It is also not clear
when the test began to fail.
> Python test
> qpid_tests.broker_0_10.new_api.GeneralTests.test_qpid_3481_acquired_to_alt_exchange
> fails against Java Broker
> -
>
> Key: QPID-7164
> URL: https://issues.apache.org/jira/browse/QPID-7164
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Python Test Suite
>Reporter: Keith Wall
>
> The following Python test is currently failing against the Java Broker.
> This is related to the routing of messages to the alternate exchanges.
> {noformat}
> Error during test: Traceback (most recent call last):
> File "qpid-python-test", line 340, in run
> phase()
> File
> "/home/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py",
> line 85, in test_qpid_3481_acquired_to_alt_exchange
> self.assertEqual(rx_alt.available(), 5, "All 5 messages should have
> been routed to the alt_exchange")
> File
> "/home/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py",
> line 39, in assertEqual
> assert None
> AssertionError
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7164) Python test qpid_tests.broker_0_10.new_api.GeneralTests.test_qpid_3481_acquired_to_alt_exchange fails against Java Broker
Keith Wall created QPID-7164:
Summary: Python test
qpid_tests.broker_0_10.new_api.GeneralTests.test_qpid_3481_acquired_to_alt_exchange
fails against Java Broker
Key: QPID-7164
URL: https://issues.apache.org/jira/browse/QPID-7164
Project: Qpid
Issue Type: Bug
Components: Java Broker, Python Test Suite
Reporter: Keith Wall
The following Python test is currently failing against the Java Broker.
This is related to the routing of messages to the alternate exchanges.
{noformat}
Error during test: Traceback (most recent call last):
File "qpid-python-test", line 340, in run
phase()
File
"/home/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py",
line 85, in test_qpid_3481_acquired_to_alt_exchange
self.assertEqual(rx_alt.available(), 5, "All 5 messages should have been
routed to the alt_exchange")
File
"/home/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/tests/src/py/qpid_tests/broker_0_10/new_api.py",
line 39, in assertEqual
assert None
AssertionError
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7163) [Python Client 0-8..0-91] No support for the return of unroutable messages
[ https://issues.apache.org/jira/browse/QPID-7163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212106#comment-15212106 ] ASF subversion and git services commented on QPID-7163: --- Commit 1736618 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1736618 ] QPID-7163: [Python Test Suite] Exclude BrokerTests.test_basic_delivery_immediate as return command is not supported by the client > [Python Client 0-8..0-91] No support for the return of unroutable messages > -- > > Key: QPID-7163 > URL: https://issues.apache.org/jira/browse/QPID-7163 > Project: Qpid > Issue Type: Bug > Components: Python Client >Reporter: Keith Wall >Priority: Minor > > The legacy python client does not understand the AMQP 0-8..0-91 basic_return > command. If it receives one, it fails in the following way: > qpid_tests.broker_0_8.broker.BrokerTests.test_basic_delivery_immediate .. > Traceback (most recent call last): > File > "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/testlib.py", > line 67, in tearDown > ch.queue_delete(queue=q) > File > "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", > line 417, in > method = lambda *args, **kwargs: self.invoke(type, args, kwargs) > File > "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", > line 312, in invoke > return self.invoker(frame, content) > File > "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", > line 357, in invoke_method > self.write(frame, content) > File > "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", > line 252, in write > raise Closed(self.reason) > Closed: Fatal error: > Traceback (most recent call last): > File > "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", > line 151, in worker > self.delegate(channel, Message(channel, frame, content)) > File > "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/delegate.py", > line 43, in __call__ > handler = getattr(self, name) > AttributeError: ClientDelegate instance has no attribute 'basic_return_' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7163) [Python Client 0-8..0-91] No support for the return of unroutable messages
Keith Wall created QPID-7163: Summary: [Python Client 0-8..0-91] No support for the return of unroutable messages Key: QPID-7163 URL: https://issues.apache.org/jira/browse/QPID-7163 Project: Qpid Issue Type: Bug Components: Python Client Reporter: Keith Wall Priority: Minor The legacy python client does not understand the AMQP 0-8..0-91 basic_return command. If it receives one, it fails in the following way: qpid_tests.broker_0_8.broker.BrokerTests.test_basic_delivery_immediate .. Traceback (most recent call last): File "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/testlib.py", line 67, in tearDown ch.queue_delete(queue=q) File "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", line 417, in method = lambda *args, **kwargs: self.invoke(type, args, kwargs) File "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", line 312, in invoke return self.invoker(frame, content) File "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", line 357, in invoke_method self.write(frame, content) File "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", line 252, in write raise Closed(self.reason) Closed: Fatal error: Traceback (most recent call last): File "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/peer.py", line 151, in worker self.delegate(channel, Message(channel, frame, content)) File "/x1/jenkins/jenkins-slave/workspace/Qpid-Python-Java-Test/trunk/qpid/python/qpid/delegate.py", line 43, in __call__ handler = getattr(self, name) AttributeError: ClientDelegate instance has no attribute 'basic_return_' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7095) [Java Broker] Add meta data for context variables describing their usage
[
https://issues.apache.org/jira/browse/QPID-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211972#comment-15211972
]
Lorenz Quack commented on QPID-7095:
Hi Rob,
I just reviewed your patch.
* I am not sure I understand the intended use of the
{{@ManagedContextDependency}} annotation which is currently unused. Is it that
we can annotate a class and declare the usage of context variables that are
define else where? For example the context variable
{{qpid.security.tls.protocolWhiteList}} is defined as a
{{ManagedContextDefault}} on the {{Broker}}. The {{Port}} interface would then
be annotated with
{{@ManagedContextDependency(value=\{"qpid.security.tls.protocolWhiteList"})}}
and this would cause the context variable to show up in the ApiDocs for both
the {{Broker}} as well as the {{Port}}. If that is the intended purpose then I
don't think it is currently working. The problem is that
{{ConfiguredObjectTypeRegistry#doWithAllParents}} considers the Java type
hierarchy and not the Qpid model hierarchy when traversing the parents. So a
context variable defined on the {{Broker}} will not be detected by the {{Port}}.
* While not being directly related to your patch I think I would like to see
the default values for {{ManagedAttributes}} and {{ManagedContextDefaults}} in
the ApiDocs and the MetaData.
> [Java Broker] Add meta data for context variables describing their usage
>
>
> Key: QPID-7095
> URL: https://issues.apache.org/jira/browse/QPID-7095
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Rob Godfrey
>
> Currently there is no way to discover which context variables are used by the
> broker, and the description of what they do. We should add meta data
> covering this and also provide this information through the dynamic API docs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7162) Simple refactoring AbstractAMQPConnection & sub-classes
[
https://issues.apache.org/jira/browse/QPID-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorenz Quack updated QPID-7162:
---
Status: Reviewable (was: In Progress)
> Simple refactoring AbstractAMQPConnection & sub-classes
> ---
>
> Key: QPID-7162
> URL: https://issues.apache.org/jira/browse/QPID-7162
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Lorenz Quack
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> There is an opportunity for a code clean up in {{AbstractAMQPConnection}} and
> its sub-classes.
> Some methods in the base classed can be pulled-up to the Abstract. Methods
> like getUnderlyingConnection are now dead,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-7162) Simple refactoring AbstractAMQPConnection & sub-classes
[
https://issues.apache.org/jira/browse/QPID-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorenz Quack reassigned QPID-7162:
--
Assignee: (was: Lorenz Quack)
> Simple refactoring AbstractAMQPConnection & sub-classes
> ---
>
> Key: QPID-7162
> URL: https://issues.apache.org/jira/browse/QPID-7162
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> There is an opportunity for a code clean up in {{AbstractAMQPConnection}} and
> its sub-classes.
> Some methods in the base classed can be pulled-up to the Abstract. Methods
> like getUnderlyingConnection are now dead,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-7162) Simple refactoring AbstractAMQPConnection & sub-classes
[
https://issues.apache.org/jira/browse/QPID-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorenz Quack reassigned QPID-7162:
--
Assignee: Lorenz Quack
> Simple refactoring AbstractAMQPConnection & sub-classes
> ---
>
> Key: QPID-7162
> URL: https://issues.apache.org/jira/browse/QPID-7162
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Lorenz Quack
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> There is an opportunity for a code clean up in {{AbstractAMQPConnection}} and
> its sub-classes.
> Some methods in the base classed can be pulled-up to the Abstract. Methods
> like getUnderlyingConnection are now dead,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7162) Simple refactoring AbstractAMQPConnection & sub-classes
[
https://issues.apache.org/jira/browse/QPID-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211937#comment-15211937
]
ASF subversion and git services commented on QPID-7162:
---
Commit 1736589 from [~lorenz.quack] in branch 'java/trunk'
[ https://svn.apache.org/r1736589 ]
QPID-7162: [Java Broker] Remove Connection#getUnderlyingConnection()
> Simple refactoring AbstractAMQPConnection & sub-classes
> ---
>
> Key: QPID-7162
> URL: https://issues.apache.org/jira/browse/QPID-7162
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> There is an opportunity for a code clean up in {{AbstractAMQPConnection}} and
> its sub-classes.
> Some methods in the base classed can be pulled-up to the Abstract. Methods
> like getUnderlyingConnection are now dead,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7162) Simple refactoring AbstractAMQPConnection & sub-classes
[
https://issues.apache.org/jira/browse/QPID-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211936#comment-15211936
]
ASF subversion and git services commented on QPID-7162:
---
Commit 1736588 from [~lorenz.quack] in branch 'java/trunk'
[ https://svn.apache.org/r1736588 ]
QPID-7162: [Java Broker] Refactor AbstractAMQPConnection and subclasses
> Simple refactoring AbstractAMQPConnection & sub-classes
> ---
>
> Key: QPID-7162
> URL: https://issues.apache.org/jira/browse/QPID-7162
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> There is an opportunity for a code clean up in {{AbstractAMQPConnection}} and
> its sub-classes.
> Some methods in the base classed can be pulled-up to the Abstract. Methods
> like getUnderlyingConnection are now dead,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-6983) [Web Management Console] Add UI support for queries
[ https://issues.apache.org/jira/browse/QPID-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-6983: - Attachment: (was: query-ui-prototype.tar.gz) > [Web Management Console] Add UI support for queries > --- > > Key: QPID-6983 > URL: https://issues.apache.org/jira/browse/QPID-6983 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Alex Rudyy > Attachments: query-ui-prototype.tar.gz > > > Add the ability to the Web Management Console to submit queries (using the > feature added by QPID-6969) and view the results. The results may need to be > paginated for display. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-6983) [Web Management Console] Add UI support for queries
[ https://issues.apache.org/jira/browse/QPID-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-6983: - Attachment: query-ui-prototype.tar.gz > [Web Management Console] Add UI support for queries > --- > > Key: QPID-6983 > URL: https://issues.apache.org/jira/browse/QPID-6983 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Alex Rudyy > Attachments: query-ui-prototype.tar.gz, query-ui-prototype.tar.gz > > > Add the ability to the Web Management Console to submit queries (using the > feature added by QPID-6969) and view the results. The results may need to be > paginated for display. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDIT-22) Add ability to run on Jenkins CI
[ https://issues.apache.org/jira/browse/QPIDIT-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211927#comment-15211927 ] ASF subversion and git services commented on QPIDIT-22: --- Commit 35536d60e615b6d7793a1eb7951eb54588038927 in qpid-interop-test's branch refs/heads/master from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-interop-test.git;h=35536d6 ] QPIDIT-22: Updates to QUICKSTART, reduced size of some test messages to avoid Qpid bug (will add large message tests later), fixed names of shims to be consistent across tests, removed old comments > Add ability to run on Jenkins CI > > > Key: QPIDIT-22 > URL: https://issues.apache.org/jira/browse/QPIDIT-22 > Project: Apache QPID IT > Issue Type: Improvement >Reporter: Kim van der Riet >Assignee: Kim van der Riet > > Run the tests on Jenkins continuous integration system. For this to be > realized, the location of dependent components needs to be parameterized, as > they can no longer be in the usual installed locations. This includes: > * qpid-proton > * qpid-jms -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-243) Requesting information about a remote router returns info about the connected router
[
https://issues.apache.org/jira/browse/DISPATCH-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211790#comment-15211790
]
Ganesh Murthy commented on DISPATCH-243:
Case 1 (using Ernie's reproducer)
On using the reproducer provided by Ernie (jsmanage2.html), the first inbound
attach frame has a target address of /$management like here -
{noformat}
[0x7ffbb4011230]:0 <- @attach(18) [name="ed3e3cb1-f719-4d97-91c3-4d00db5ce802",
handle=0, role=false, target=@target(41) [address="/$management"],
initial-delivery-count=0]
{noformat}
Notice above that the target address on the link is set to /$management. Also,
the address on the message "to" field is set to amqp:/_topo/0/QDR.B/$management
Case 2 (using qdmanage)
Now, when I used the qdmanage tool to do a QUERY operation, I am seeing that
the first inbound attach frame has a target address of
_topo/0/QDR.B/$management like here -
{noformat}
[0xaaa720]:0 <- @attach(18)
[name="38bb9314-055e-4485-927d-481250be534e-_topo/0/QDR.B/$management",
handle=0, role=false, snd-settle-mode=2, rcv-settle-mode=0, source=@source(40)
[durable=0, timeout=0, dynamic=false], target=@target(41)
[address="_topo/0/QDR.B/$management", durable=0, timeout=0, dynamic=false],
initial-delivery-count=0]
{noformat}
Note here that the target address on the link is set to
_topo/0/QDR.B/$management (and not to /$management like in Case 1)
According to Ted Ross -
Pre-merge, the router only looked at the link target address if there was no
address in the message. Post-merge, the link target address, if present,
always takes precedence over an address in the message. The post-merge
behavior is the correct behavior.
To fix this issue, the javascript needs to be modified to exactly do what
qdmanage is doing, namely create a link with a target address of
_topo/0/QDR.B/$management and send the QUERY request over the link.
> Requesting information about a remote router returns info about the connected
> router
>
>
> Key: DISPATCH-243
> URL: https://issues.apache.org/jira/browse/DISPATCH-243
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
> Attachments: jsmanage.html, jsmanage2.html
>
>
> When connected to Router A, and making a request for info about Router B, the
> info that is returned is for Router A.
> I'm using the proton javascript binding rhea.js and making a QUERY request.
> Here is Router B's log entry for the request.
> Thu Mar 24 03:40:06 2016 AGENT (debug) Agent request
> Message(address='amqp://0.0.0.0:5673/_topo/0/QDR.B/$management',
> properties={'operation': 'QUERY', 'entityType': 'router', 'type':
> 'org.amqp.management', 'name': 'self'}, body={'attributeNames': []},
> reply_to='amqp:/_topo/0/QDR.A/temp.43z0E5iKdp4hMed', correlation_id='60') on
> link 0
> (/home/eallen/workspace/qpid-dispatch/install/lib/qpid-dispatch/python/qpid_dispatch_internal/management/agent.py:736)
> Thu Mar 24 03:40:06 2016 AGENT (debug) Agent response:
> Message(address='amqp:/_topo/0/QDR.A/temp.43z0E5iKdp4hMed',
> properties={'statusDescription': 'OK', 'statusCode': 200}, body={'results':
> [[4, 'router/QDR.A', 1, '0', 3, 0, 60, 0, 'QDR.A', 30, 'interior',
> 'org.apache.qpid.dispatch.router', 0, 60, 'router/QDR.A']], 'attributeNames':
> [u'raIntervalFlux', u'name', u'helloInterval', u'area', u'helloMaxAge',
> u'linkCount', u'remoteLsMaxAge', u'addrCount', u'routerId', u'raInterval',
> u'mode', u'type', u'nodeCount', u'mobileAddrMaxAge', u'identity']},
> reply_to=None, correlation_id='60')
> Responding to:
> Message(address='amqp://0.0.0.0:5673/_topo/0/QDR.B/$management',
> properties={'operation': 'QUERY', 'entityType': 'router', 'type':
> 'org.amqp.management', 'name': 'self'}, body={'attributeNames': []},
> reply_to='amqp:/_topo/0/QDR.A/temp.43z0E5iKdp4hMed', correlation_id='60')
> (/home/eallen/workspace/qpid-dispatch/install/lib/qpid-dispatch/python/qpid_dispatch_internal/management/agent.py:715)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7156) Possible Java Broker crash if connection is formed whilst virtualhost is stopping
[
https://issues.apache.org/jira/browse/QPID-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211780#comment-15211780
]
ASF subversion and git services commented on QPID-7156:
---
Commit 1736566 from [~k-wall] in branch 'java/branches/6.0.x'
[ https://svn.apache.org/r1736566 ]
QPID-7156: [Java Broker] Stop new connections from being established while
virtual host is stopping.
Manually backported from trunk:
svn merge -c 1736478 ^/qpid/java/trunk
> Possible Java Broker crash if connection is formed whilst virtualhost is
> stopping
> -
>
> Key: QPID-7156
> URL: https://issues.apache.org/jira/browse/QPID-7156
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments:
> 0001-QPID-7156-Java-Broker-Stop-new-connections-from-bein.patch
>
>
> As reported here:
> http://qpid.2158936.n2.nabble.com/Java-broker-crashes-after-stopping-vhost-td7640284.html
> A race condition leads to the possibility of a NPE if the virtualhost is
> stopped as a new connection is formed. In the unlucky case, the task to
> associate the connection with the virtualhost gets executed after the virtual
> host's network connection scheduler is shutdown. This leads to a NPE. The
> Broker detects the NPE and shuts itself down.
> {noformat}
> 2016-03-18 06:41:06,748 ERROR [IO-/172.24.102.24:51029] (o.a.q.s.Main) -
> Uncaught exception, shutting down.
> java.lang.NullPointerException: null
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:142)
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:505)
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:338)
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:87)
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:463)
> ~[qpid-broker-core-6.0.1.jar:6.0.1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown
> Source) ~[na:1.8.0_51]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
> Source) ~[na:1.8.0_51]
> at java.lang.Thread.run(Unknown Source) ~[na:1.8.0_51]
> "
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7149) [HA] active HA broker memory leak when ring queue discards overflow messages
[
https://issues.apache.org/jira/browse/QPID-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211737#comment-15211737
]
Alan Conway commented on QPID-7149:
---
I just noticed your reproducer has --acl-file=/root/qpidd.acl. Is that
necessary? If so can you attach the contents of the ACL file.
> [HA] active HA broker memory leak when ring queue discards overflow messages
>
>
> Key: QPID-7149
> URL: https://issues.apache.org/jira/browse/QPID-7149
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Environment: RHEL6
> qpid trunk svn rev. 1735384
> - issue seen in very old releases (since active-passive HA cluster initial
> implementation, most probably)
> libstdc++-devel-4.4.7-4.el6.x86_64
> gcc-c++-4.4.7-4.el6.x86_64
> libgcc-4.4.7-4.el6.x86_64
> libstdc++-4.4.7-4.el6.x86_64
> gcc-4.4.7-4.el6.x86_64
>Reporter: Pavel Moravec
>Assignee: Alan Conway
>
> There is a memory leak on active HA broker, triggered most probably by
> purging overflow message from a ring queue. Basic scenario is to setup HA
> cluster, promote to primary and feed forever a ring queue with messages.
> Detailed scenario:
> 1) Start brokers and promote one to primary:
> {noformat}
> start_broker() {
> port=$1
> shift
> rm -rf _${port}
> mkdir _${port}
> nohup qpidd --load-module=ha.so --port=$port
> --log-to-file=qpidd.$port.log --data-dir=_${port} --auth=no
> --log-to-stderr=no --ha-cluster=yes
> --ha-brokers-url="$(hostname):5672,$(hostname):5673,$(hostname):5674"
> --ha-replicate=all --acl-file=/root/qpidd.acl "$@" > /dev/null 2>&1 &
> sleep 1
> }
> killall qpidd qpid-receive 2> /dev/null
> rm -f qpidd.*.log
> start_broker 5672
> sleep 1
> qpid-ha promote -b $(hostname):5672 --cluster-manager
> sleep 1
> start_broker 5673
> sleep 1
> start_broker 5674
> {noformat}
> 2) Create ring queues and send there messages (it is enough to have 1 queue,
> having more should show the leak faster):
> {noformat}
> for i in $(seq 0 9); do
> qpid-config add queue FromKeyServer_$i --max-queue-size=1
> --max-queue-count=10 --limit-policy=ring --argument=x-qpid-priorities=10
> done
> while true; do
> for j in $(seq 1 10); do
> for i in $(seq 1 10); do
> for k in $(seq 0 9); do
> qpid-send -a FromKeyServer_$k -m 100
> --send-rate=50 -- priority=$(($((RANDOM))%10)) &
> done
> done
> wait
> while [ $(qpid-stat -q | grep broker-replicator | sed "s/Y//g"
> | awk '{ print $2 }' | sort -n | tail -n1) != "0" ]; do
> sleep 1
> done
> done
> date
> ps aux | grep qpidd | grep "port=5672" | awk -F "--store-dir" '{ print
> $1 }'
> done
> {noformat}
> (the "while [ $(qpid-stat -q | .." cycle is there just to slow down the
> message enqueues to ensure replication federation queues dont have big
> backlog - that would interfere with memory consumpiton observation)
> 3) Run those scripts and monitor memory consumption.
> - without using priority queues and sending messages without priorities, leak
> is evident as well - sometimes smaller, sometimes the same
> - valgrind (on some older versions I tested before more thoroughly) detects
> nothing (neither leaked memory or reachable at shutdown)
> - same leak is evident even with --ha-replicate=none
> - number of backup brokers does not affect the memory leak
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[
https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211703#comment-15211703
]
ASF subversion and git services commented on QPID-7033:
---
Commit 1736560 from [~k-wall] in branch 'java/branches/6.0.x'
[ https://svn.apache.org/r1736560 ]
QPID-7033: [Java Broker] Busy IO thread pools may cause client connections to
be unfairly closed
Should have been part of previous commit.
Merged with command:
svn merge -c 1732452,1732461,1732812^/qpid/java/trunk
> [Java Broker] Busy IO thread pools may cause client connections to be
> unfairly closed
> -
>
> Key: QPID-7033
> URL: https://issues.apache.org/jira/browse/QPID-7033
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch
>
>
> The Broker installs connection tickers to guard against a new connection that
> sends no bytes or sends bytes too slowly. If the ticker expires, the
> connection is closed with a {{CON-1003 : Closed due to inactivity}} message.
> However, currently a side effect of the Selector Thread's algorithm will mean
> that a connection that whilst ready for read but cannot be scheduled on an IO
> Pool sufficiently quickly enough will also be closed. This is unfair.
> This problem will mean that establishing connections to a busy broker may be
> unreliable. Also a retry effect on the client may exacerbate the situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[
https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211677#comment-15211677
]
ASF subversion and git services commented on QPID-7033:
---
Commit 1736551 from [~k-wall] in branch 'java/branches/6.0.x'
[ https://svn.apache.org/r1736551 ]
QPID-7033: [Java Broker] Busy IO thread pools may cause client connections to
be unfairly closed
Merged with command:
svn merge -c 1732184,1732452,1732461,1732812^/qpid/java/trunk
> [Java Broker] Busy IO thread pools may cause client connections to be
> unfairly closed
> -
>
> Key: QPID-7033
> URL: https://issues.apache.org/jira/browse/QPID-7033
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch
>
>
> The Broker installs connection tickers to guard against a new connection that
> sends no bytes or sends bytes too slowly. If the ticker expires, the
> connection is closed with a {{CON-1003 : Closed due to inactivity}} message.
> However, currently a side effect of the Selector Thread's algorithm will mean
> that a connection that whilst ready for read but cannot be scheduled on an IO
> Pool sufficiently quickly enough will also be closed. This is unfair.
> This problem will mean that establishing connections to a busy broker may be
> unreliable. Also a retry effect on the client may exacerbate the situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-7033) [Java Broker] Busy IO thread pools may cause client connections to be unfairly closed
[
https://issues.apache.org/jira/browse/QPID-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall resolved QPID-7033.
--
Resolution: Fixed
> [Java Broker] Busy IO thread pools may cause client connections to be
> unfairly closed
> -
>
> Key: QPID-7033
> URL: https://issues.apache.org/jira/browse/QPID-7033
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: 0001-QPID-7033-WIP-fix-ticker-unfairness.patch
>
>
> The Broker installs connection tickers to guard against a new connection that
> sends no bytes or sends bytes too slowly. If the ticker expires, the
> connection is closed with a {{CON-1003 : Closed due to inactivity}} message.
> However, currently a side effect of the Selector Thread's algorithm will mean
> that a connection that whilst ready for read but cannot be scheduled on an IO
> Pool sufficiently quickly enough will also be closed. This is unfair.
> This problem will mean that establishing connections to a busy broker may be
> unreliable. Also a retry effect on the client may exacerbate the situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
