Re: Review Request 45389: WIP PROTON-1133 - Avoid using hostname as a transport address

[Kenneth Giusti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45389/
---

(Updated April 6, 2016, 1:02 a.m.)


Review request for qpid, Gordon Sim, Justin Ross, and Robbie Gemmell.


Bugs: PROTON-1133
https://issues.apache.org/jira/browse/PROTON-1133


Repository: qpid-proton-git


Description
---

This involves a change to the Reactor API.

This patch implements a new API for creating outgoing connections via the 
Reactor class: pn_reactor_connection_to_url().  It is meant to replace the 
existing practice of creating a connection via pn_reactor_connection() then 
setting the transport address in the connection's hostname field.

Not 100% convinced this is appropriate.  It introduces a URL parameter to the 
Proton Connection object, where it may make better sense to associate the URL 
with the Transport instead (pn_reactor_transport_to_url()???).

The URL parameter is used by the Proton iohandler to create the socket 
connection.  If an application does not use the Proton iohandler (by overriding 
the reactor's global handler), then it is the responsiblity of whatever handler 
is being provided to use the URL to set up the socket connection.  This was 
also the case for the old method that used the connection's hostname setting, 
so this is not a behavioral change.


Diffs (updated)
-

  
examples/java/reactor/src/main/java/org/apache/qpid/proton/example/reactor/Send.java
 22da720 
  examples/python/reactor/send.py c718780 
  examples/python/reactor/tornado-send.py 54b8618 
  proton-c/bindings/python/proton/__init__.py 5ffede8 
  proton-c/bindings/python/proton/reactor.py cda6248 
  proton-c/include/proton/connection.h f8a688c 
  proton-c/include/proton/reactor.h e91b169 
  proton-c/src/reactor/connection.c 4a57bfd 
  proton-c/src/tests/reactor.c 1e706e2 
  proton-j/src/main/java/org/apache/qpid/proton/engine/Connection.java feff80b 
  proton-j/src/main/java/org/apache/qpid/proton/reactor/Reactor.java 9d67d49 
  proton-j/src/main/java/org/apache/qpid/proton/reactor/impl/IOHandler.java 
40eddac 
  proton-j/src/main/java/org/apache/qpid/proton/reactor/impl/ReactorImpl.java 
0eb126a 
  proton-j/src/test/java/org/apache/qpid/proton/reactor/ReactorTest.java 
10c591a 
  tests/java/org/apache/qpid/proton/ProtonJInterop.java 31306ef 
  tests/java/shim/creactor.py 95fd020 

Diff: https://reviews.apache.org/r/45389/diff/


Testing
---

Updated unit tests and re-checked modified examples.


Thanks,

Kenneth Giusti

[jira] [Resolved] (QPIDJMS-168) Fix various issues reported by FindBugs

[Timothy Bish (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved QPIDJMS-168.
--
Resolution: Fixed

> Fix various issues reported by FindBugs
> ---
>
> Key: QPIDJMS-168
> URL: https://issues.apache.org/jira/browse/QPIDJMS-168
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> Findbugs reports a number of minor issues against the latest code, address 
> each as needed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPIDJMS-166) Revisit some of the TODOs in the code around error messages and exception types.

[Timothy Bish (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved QPIDJMS-166.
--
Resolution: Fixed

> Revisit some of the TODOs in the code around error messages and exception 
> types.  
> --
>
> Key: QPIDJMS-166
> URL: https://issues.apache.org/jira/browse/QPIDJMS-166
> Project: Qpid JMS
>  Issue Type: Improvement
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> We have a number of older TODO annotations in different places about the 
> error messages and the type of error exception thrown, we should revisit some 
> of these and try and produce more meaningful results.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-166) Revisit some of the TODOs in the code around error messages and exception types.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227250#comment-15227250
 ] 

ASF subversion and git services commented on QPIDJMS-166:
-

Commit 0c8f52ab7b59b3384bc0f51b8537e4e005c1180f in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=0c8f52a ]

QPIDJMS-168 / QPIDJMS-166

simplify the hasMoreElements logic



> Revisit some of the TODOs in the code around error messages and exception 
> types.  
> --
>
> Key: QPIDJMS-166
> URL: https://issues.apache.org/jira/browse/QPIDJMS-166
> Project: Qpid JMS
>  Issue Type: Improvement
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> We have a number of older TODO annotations in different places about the 
> error messages and the type of error exception thrown, we should revisit some 
> of these and try and produce more meaningful results.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-168) Fix various issues reported by FindBugs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227249#comment-15227249
 ] 

ASF subversion and git services commented on QPIDJMS-168:
-

Commit 0c8f52ab7b59b3384bc0f51b8537e4e005c1180f in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=0c8f52a ]

QPIDJMS-168 / QPIDJMS-166

simplify the hasMoreElements logic



> Fix various issues reported by FindBugs
> ---
>
> Key: QPIDJMS-168
> URL: https://issues.apache.org/jira/browse/QPIDJMS-168
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> Findbugs reports a number of minor issues against the latest code, address 
> each as needed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-257) Policy miscounts sender/receiver links; no link count tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227229#comment-15227229
 ] 

ASF subversion and git services commented on DISPATCH-257:
--

Commit 15de0870d5430b69f94205bae33c0fc6e7d4a14f in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=15de087 ]

DISPATCH-257: Fix policy link counting
* Add self test to verify sender/recevier link denial by count.
* Fix code to account for sender/receiver links properly.
  Router 'incoming links' are 'senders' for policy.
* Better log messages.


> Policy miscounts sender/receiver links; no link count tests
> ---
>
> Key: DISPATCH-257
> URL: https://issues.apache.org/jira/browse/DISPATCH-257
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Chuck Rolke
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-261) Bind error on one port causes bind error on other ports

[Chuck Rolke (JIRA)]

Chuck Rolke created DISPATCH-261:


 Summary: Bind error on one port causes bind error on other ports
 Key: DISPATCH-261
 URL: https://issues.apache.org/jira/browse/DISPATCH-261
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.6
Reporter: Chuck Rolke


Run a service, like an AMQP broker, on port 5672.

Start Dispatch Router with config
{noformat}
listener {
addr: 0.0.0.0
port: amqp
authenticatePeer: no
}

listener {
addr: 0.0.0.0
port: 20102
}
{noformat}

The router reports:
{noformat}
Tue Apr  5 17:55:04 2016 CONN_MGR (info) Configured Listener: 0.0.0.0:amqp 
proto=any role=normal
Tue Apr  5 17:55:04 2016 DRIVER (error) bind: Address already in use
Tue Apr  5 17:55:04 2016 CONN_MGR (info) Configured Listener: 0.0.0.0:20102 
proto=any role=normal
Tue Apr  5 17:55:04 2016 DRIVER (error) bind: Address already in use
{noformat}

The error on port 5672 is correct. The error on port 20102 is bogus. There is 
no conflict on that port.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7149) [HA] active HA broker memory leak when ring queue discards overflow messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227195#comment-15227195
 ] 

ASF subversion and git services commented on QPID-7149:
---

Commit 1737887 from [~aconway] in branch 'qpid/trunk'
[ https://svn.apache.org/r1737887 ]

QPID-7149: Fixed messaging client shutdown.

Fix previous commit that did not respect the plugin boundaries for
messaging::shutdown.

> [HA] active HA broker memory leak when ring queue discards overflow messages
> 
>
> Key: QPID-7149
> URL: https://issues.apache.org/jira/browse/QPID-7149
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
> Environment: RHEL6
> qpid trunk svn rev. 1735384
> - issue seen in very old releases (since active-passive HA cluster initial 
> implementation, most probably)
> libstdc++-devel-4.4.7-4.el6.x86_64
> gcc-c++-4.4.7-4.el6.x86_64
> libgcc-4.4.7-4.el6.x86_64
> libstdc++-4.4.7-4.el6.x86_64
> gcc-4.4.7-4.el6.x86_64
>Reporter: Pavel Moravec
>Assignee: Alan Conway
>
> There is a memory leak on active HA broker, triggered most probably by 
> purging overflow message from a ring queue. Basic scenario is to setup HA 
> cluster, promote to primary and feed forever a ring queue with messages.
> Detailed scenario:
> 1) Start brokers and promote one to primary:
> {noformat}
> start_broker() {
>   port=$1
>   shift
>   rm -rf _${port}
>   mkdir _${port}
>   nohup qpidd --load-module=ha.so --port=$port 
> --log-to-file=qpidd.$port.log --data-dir=_${port} --auth=no 
> --log-to-stderr=no --ha-cluster=yes 
> --ha-brokers-url="$(hostname):5672,$(hostname):5673,$(hostname):5674" 
> --ha-replicate=all --acl-file=/root/qpidd.acl "$@" > /dev/null 2>&1 &
>   sleep 1
> }
> killall qpidd qpid-receive 2> /dev/null
> rm -f qpidd.*.log
> start_broker 5672
> sleep 1
> qpid-ha promote -b $(hostname):5672 --cluster-manager
> sleep 1
> start_broker 5673
> sleep 1
> start_broker 5674
> {noformat}
> 2) Create ring queues and send there messages (it is enough to have 1 queue, 
> having more should show the leak faster):
> {noformat}
> for i in $(seq 0 9); do
>   qpid-config add queue FromKeyServer_$i --max-queue-size=1 
> --max-queue-count=10 --limit-policy=ring --argument=x-qpid-priorities=10
> done
> while true; do
>   for j in $(seq 1 10); do
>   for i in $(seq 1 10); do
>   for k in $(seq 0 9); do
>   qpid-send -a FromKeyServer_$k -m 100 
> --send-rate=50 -- priority=$(($((RANDOM))%10)) &
>   done
>   done
>   wait
>   while [ $(qpid-stat -q | grep broker-replicator | sed "s/Y//g" 
> | awk '{ print $2 }' | sort -n | tail -n1) != "0" ]; do
>   sleep 1
>   done
>   done
>   date
>   ps aux | grep qpidd | grep "port=5672" | awk -F "--store-dir" '{ print 
> $1 }'
> done
> {noformat}
> (the "while [ $(qpid-stat -q | .." cycle is there just to slow down the 
> message enqueues to ensure replication federation queues dont have big 
> backlog - that would interfere with memory consumpiton observation)
> 3) Run those scripts and monitor memory consumption.
> - without using priority queues and sending messages without priorities, leak 
> is evident as well - sometimes smaller, sometimes the same
> - valgrind (on some older versions I tested before more thoroughly) detects 
> nothing (neither leaked memory or reachable at shutdown)
> - same leak is evident even with --ha-replicate=none
> - number of backup brokers does not affect the memory leak



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-260) Blank user names should use 'anonymous' instead

[Chuck Rolke (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved DISPATCH-260.
--
Resolution: Fixed

> Blank user names should use 'anonymous' instead
> ---
>
> Key: DISPATCH-260
> URL: https://issues.apache.org/jira/browse/DISPATCH-260
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.6
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> A non-ssl, no-sasl connection delivers a null for the user_id. This should be 
> replaced with 'anonymous' so that the rest of router code never has to deal 
> with a null user_id.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-260) Blank user names should use 'anonymous' instead

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226965#comment-15226965
 ] 

ASF subversion and git services commented on DISPATCH-260:
--

Commit f46b3afa9ac4dcc217cc5dfd5a23163dcee79425 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=f46b3af ]

DISPATCH-260: set default user name to 'anonymous'


> Blank user names should use 'anonymous' instead
> ---
>
> Key: DISPATCH-260
> URL: https://issues.apache.org/jira/browse/DISPATCH-260
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.6
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> A non-ssl, no-sasl connection delivers a null for the user_id. This should be 
> replaced with 'anonymous' so that the rest of router code never has to deal 
> with a null user_id.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-260) Blank user names should use 'anonymous' instead

[Chuck Rolke (JIRA)]

Chuck Rolke created DISPATCH-260:


 Summary: Blank user names should use 'anonymous' instead
 Key: DISPATCH-260
 URL: https://issues.apache.org/jira/browse/DISPATCH-260
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.6
Reporter: Chuck Rolke
Assignee: Chuck Rolke


A non-ssl, no-sasl connection delivers a null for the user_id. This should be 
replaced with 'anonymous' so that the rest of router code never has to deal 
with a null user_id.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-169) SASL Plain Mechanism should be enforcing UTF-8 encoding

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226791#comment-15226791
 ] 

ASF subversion and git services commented on QPIDJMS-169:
-

Commit 98ba842408afad3275966b0eb8041501e54d86c5 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=98ba842 ]

QPIDJMS-169 Enforce user / pass encoded as UTF-0

> SASL Plain Mechanism should be enforcing UTF-8 encoding
> ---
>
> Key: QPIDJMS-169
> URL: https://issues.apache.org/jira/browse/QPIDJMS-169
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> When encoding the user / pass in the SASL plain mechanism we aren't enforcing 
> UTF-8 encoding which is the required encoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPIDJMS-169) SASL Plain Mechanism should be enforcing UTF-8 encoding

[Timothy Bish (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved QPIDJMS-169.
--
Resolution: Fixed

> SASL Plain Mechanism should be enforcing UTF-8 encoding
> ---
>
> Key: QPIDJMS-169
> URL: https://issues.apache.org/jira/browse/QPIDJMS-169
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> When encoding the user / pass in the SASL plain mechanism we aren't enforcing 
> UTF-8 encoding which is the required encoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPIDJMS-169) SASL Plain Mechanism should be enforcing UTF-8 encoding

[Timothy Bish (JIRA)]

Timothy Bish created QPIDJMS-169:


 Summary: SASL Plain Mechanism should be enforcing UTF-8 encoding
 Key: QPIDJMS-169
 URL: https://issues.apache.org/jira/browse/QPIDJMS-169
 Project: Qpid JMS
  Issue Type: Bug
  Components: qpid-jms-client
Affects Versions: 0.8.0
Reporter: Timothy Bish
Assignee: Timothy Bish
 Fix For: 0.9.0


When encoding the user / pass in the SASL plain mechanism we aren't enforcing 
UTF-8 encoding which is the required encoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-259) qdstat man-page doc is no good

[Ted Ross (JIRA)]

Ted Ross created DISPATCH-259:
-

 Summary: qdstat man-page doc is no good
 Key: DISPATCH-259
 URL: https://issues.apache.org/jira/browse/DISPATCH-259
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Documentation
Affects Versions: 0.6
Reporter: Ted Ross
 Fix For: 0.6


Generation of this page:
http://qpid.apache.org/releases/qpid-dispatch-master/man/qdstat.html
failed due to apparent PYTHONPATH issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-168) Fix various issues reported by FindBugs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226630#comment-15226630
 ] 

ASF subversion and git services commented on QPIDJMS-168:
-

Commit c99ea859d3d6a8015ead5fc99c19dd64c6f0a07c in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=c99ea85 ]

QPIDJMS-168 Fix type some declarations that could be final or static 

> Fix various issues reported by FindBugs
> ---
>
> Key: QPIDJMS-168
> URL: https://issues.apache.org/jira/browse/QPIDJMS-168
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> Findbugs reports a number of minor issues against the latest code, address 
> each as needed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-168) Fix various issues reported by FindBugs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226631#comment-15226631
 ] 

ASF subversion and git services commented on QPIDJMS-168:
-

Commit a02c533a6a7184c0243025f8eebc67edb68643a4 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=a02c533 ]

/QPIDJMS-168 fix potential NPE

> Fix various issues reported by FindBugs
> ---
>
> Key: QPIDJMS-168
> URL: https://issues.apache.org/jira/browse/QPIDJMS-168
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> Findbugs reports a number of minor issues against the latest code, address 
> each as needed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-168) Fix various issues reported by FindBugs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226632#comment-15226632
 ] 

ASF subversion and git services commented on QPIDJMS-168:
-

Commit e97a6f94b81b82b0afc4f5786cbda5c55c43150d in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=e97a6f9 ]

QPIDJMS-168 Ensure we throw a more meaningful exception if the remote
doesn't provide one when pending sends are awaiting a response.

> Fix various issues reported by FindBugs
> ---
>
> Key: QPIDJMS-168
> URL: https://issues.apache.org/jira/browse/QPIDJMS-168
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> Findbugs reports a number of minor issues against the latest code, address 
> each as needed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (QPID-7159) [Java Client] Disabling user ids in AMQP messages

[Alex Rudyy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-7159:


Assignee: Keith Wall  (was: Alex Rudyy)

Keith,
Please review committed changes

> [Java Client] Disabling user ids in AMQP messages
> -
>
> Key: QPID-7159
> URL: https://issues.apache.org/jira/browse/QPID-7159
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Client
>Reporter: Jakub Scholz
>Assignee: Keith Wall
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: QPID-7159-Add-system-test.diff, 
> QPID-7159-conn-option.patch, 
> QPID-7159-rename-parameter-into-populateJMSXUserID.diff, QPID-7159.patch
>
>
> The AMQP 0-10 JMS client seems to always attach the user-id message property 
> to the AMQP message. 
> In some cases, I don't think this is desired. For example when I send 
> messages to my customers, I do not really want them to know which other users 
> exist on the broker and are used to send messages.
> It would be great to have a possibility to disable the user-id when needed. 
> The attached patch disables the user id in the BasicMessageProducer based on 
> a system property qpid.attach_user_id (true/false). Does that look like a 
> reasonable solution? If yes, I can try to add some tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-7159) [Java Client] Disabling user ids in AMQP messages

[Alex Rudyy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7159:
-
Status: Reviewable  (was: In Progress)

> [Java Client] Disabling user ids in AMQP messages
> -
>
> Key: QPID-7159
> URL: https://issues.apache.org/jira/browse/QPID-7159
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Client
>Reporter: Jakub Scholz
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: QPID-7159-Add-system-test.diff, 
> QPID-7159-conn-option.patch, 
> QPID-7159-rename-parameter-into-populateJMSXUserID.diff, QPID-7159.patch
>
>
> The AMQP 0-10 JMS client seems to always attach the user-id message property 
> to the AMQP message. 
> In some cases, I don't think this is desired. For example when I send 
> messages to my customers, I do not really want them to know which other users 
> exist on the broker and are used to send messages.
> It would be great to have a possibility to disable the user-id when needed. 
> The attached patch disables the user id in the BasicMessageProducer based on 
> a system property qpid.attach_user_id (true/false). Does that look like a 
> reasonable solution? If yes, I can try to add some tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7159) [Java Client] Disabling user ids in AMQP messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226577#comment-15226577
 ] 

ASF subversion and git services commented on QPID-7159:
---

Commit 1737853 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1737853 ]

QPID-7159: Add connection parameter to control whether a MessageProducer will 
populate the JMSXUserID value for each sent message using the authenticated 
username from the connection

   Applied patch supplied by Jakub Scholz with some minor changes

> [Java Client] Disabling user ids in AMQP messages
> -
>
> Key: QPID-7159
> URL: https://issues.apache.org/jira/browse/QPID-7159
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Client
>Reporter: Jakub Scholz
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: QPID-7159-Add-system-test.diff, 
> QPID-7159-conn-option.patch, 
> QPID-7159-rename-parameter-into-populateJMSXUserID.diff, QPID-7159.patch
>
>
> The AMQP 0-10 JMS client seems to always attach the user-id message property 
> to the AMQP message. 
> In some cases, I don't think this is desired. For example when I send 
> messages to my customers, I do not really want them to know which other users 
> exist on the broker and are used to send messages.
> It would be great to have a possibility to disable the user-id when needed. 
> The attached patch disables the user id in the BasicMessageProducer based on 
> a system property qpid.attach_user_id (true/false). Does that look like a 
> reasonable solution? If yes, I can try to add some tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (QPID-7159) [Java Client] Disabling user ids in AMQP messages

[Alex Rudyy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-7159:


Assignee: Alex Rudyy

> [Java Client] Disabling user ids in AMQP messages
> -
>
> Key: QPID-7159
> URL: https://issues.apache.org/jira/browse/QPID-7159
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Client
>Reporter: Jakub Scholz
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: QPID-7159-Add-system-test.diff, 
> QPID-7159-conn-option.patch, 
> QPID-7159-rename-parameter-into-populateJMSXUserID.diff, QPID-7159.patch
>
>
> The AMQP 0-10 JMS client seems to always attach the user-id message property 
> to the AMQP message. 
> In some cases, I don't think this is desired. For example when I send 
> messages to my customers, I do not really want them to know which other users 
> exist on the broker and are used to send messages.
> It would be great to have a possibility to disable the user-id when needed. 
> The attached patch disables the user id in the BasicMessageProducer based on 
> a system property qpid.attach_user_id (true/false). Does that look like a 
> reasonable solution? If yes, I can try to add some tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-258) Policy compile error - possible use of uninitialized variable

[Chuck Rolke (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved DISPATCH-258.
--
Resolution: Fixed

> Policy compile error - possible use of uninitialized variable
> -
>
> Key: DISPATCH-258
> URL: https://issues.apache.org/jira/browse/DISPATCH-258
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> {noformat}
> /builddir/build/BUILD/qpid-dispatch-0.6.0/src/policy.c: In function 
> '_qd_policy_approve_link_name':
> /builddir/build/BUILD/qpid-dispatch-0.6.0/src/policy.c:560: error: 'toknext' 
> may be used uninitialized in this function
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-258) Policy compile error - possible use of uninitialized variable

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226568#comment-15226568
 ] 

ASF subversion and git services commented on DISPATCH-258:
--

Commit 4df749549bbebc9761ca5c718d3b9e7eed8daed5 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=4df7495 ]

DISPATCH-258: initialize variable before use


> Policy compile error - possible use of uninitialized variable
> -
>
> Key: DISPATCH-258
> URL: https://issues.apache.org/jira/browse/DISPATCH-258
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> {noformat}
> /builddir/build/BUILD/qpid-dispatch-0.6.0/src/policy.c: In function 
> '_qd_policy_approve_link_name':
> /builddir/build/BUILD/qpid-dispatch-0.6.0/src/policy.c:560: error: 'toknext' 
> may be used uninitialized in this function
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7149) [HA] active HA broker memory leak when ring queue discards overflow messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226551#comment-15226551
 ] 

ASF subversion and git services commented on QPID-7149:
---

Commit 1737852 from [~aconway] in branch 'qpid/trunk'
[ https://svn.apache.org/r1737852 ]

QPID-7149: Active HA broker memory leak

The leak was caused by the sys::Poller. When two pollers run in the same process
and one is idles, PollerHandles accumulate on the idle poller threads and are
never released. The HA broker uses the qpid::messaging API to get initial 
status from
other brokers. The messaging API creates a separate Poller from the broker.

The fix is to shut down the qpid::messaging poller as soon as initial status
checks are complete so it does not interfere with the broker's Poller.

> [HA] active HA broker memory leak when ring queue discards overflow messages
> 
>
> Key: QPID-7149
> URL: https://issues.apache.org/jira/browse/QPID-7149
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
> Environment: RHEL6
> qpid trunk svn rev. 1735384
> - issue seen in very old releases (since active-passive HA cluster initial 
> implementation, most probably)
> libstdc++-devel-4.4.7-4.el6.x86_64
> gcc-c++-4.4.7-4.el6.x86_64
> libgcc-4.4.7-4.el6.x86_64
> libstdc++-4.4.7-4.el6.x86_64
> gcc-4.4.7-4.el6.x86_64
>Reporter: Pavel Moravec
>Assignee: Alan Conway
>
> There is a memory leak on active HA broker, triggered most probably by 
> purging overflow message from a ring queue. Basic scenario is to setup HA 
> cluster, promote to primary and feed forever a ring queue with messages.
> Detailed scenario:
> 1) Start brokers and promote one to primary:
> {noformat}
> start_broker() {
>   port=$1
>   shift
>   rm -rf _${port}
>   mkdir _${port}
>   nohup qpidd --load-module=ha.so --port=$port 
> --log-to-file=qpidd.$port.log --data-dir=_${port} --auth=no 
> --log-to-stderr=no --ha-cluster=yes 
> --ha-brokers-url="$(hostname):5672,$(hostname):5673,$(hostname):5674" 
> --ha-replicate=all --acl-file=/root/qpidd.acl "$@" > /dev/null 2>&1 &
>   sleep 1
> }
> killall qpidd qpid-receive 2> /dev/null
> rm -f qpidd.*.log
> start_broker 5672
> sleep 1
> qpid-ha promote -b $(hostname):5672 --cluster-manager
> sleep 1
> start_broker 5673
> sleep 1
> start_broker 5674
> {noformat}
> 2) Create ring queues and send there messages (it is enough to have 1 queue, 
> having more should show the leak faster):
> {noformat}
> for i in $(seq 0 9); do
>   qpid-config add queue FromKeyServer_$i --max-queue-size=1 
> --max-queue-count=10 --limit-policy=ring --argument=x-qpid-priorities=10
> done
> while true; do
>   for j in $(seq 1 10); do
>   for i in $(seq 1 10); do
>   for k in $(seq 0 9); do
>   qpid-send -a FromKeyServer_$k -m 100 
> --send-rate=50 -- priority=$(($((RANDOM))%10)) &
>   done
>   done
>   wait
>   while [ $(qpid-stat -q | grep broker-replicator | sed "s/Y//g" 
> | awk '{ print $2 }' | sort -n | tail -n1) != "0" ]; do
>   sleep 1
>   done
>   done
>   date
>   ps aux | grep qpidd | grep "port=5672" | awk -F "--store-dir" '{ print 
> $1 }'
> done
> {noformat}
> (the "while [ $(qpid-stat -q | .." cycle is there just to slow down the 
> message enqueues to ensure replication federation queues dont have big 
> backlog - that would interfere with memory consumpiton observation)
> 3) Run those scripts and monitor memory consumption.
> - without using priority queues and sending messages without priorities, leak 
> is evident as well - sometimes smaller, sometimes the same
> - valgrind (on some older versions I tested before more thoroughly) detects 
> nothing (neither leaked memory or reachable at shutdown)
> - same leak is evident even with --ha-replicate=none
> - number of backup brokers does not affect the memory leak



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-168) Fix various issues reported by FindBugs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226553#comment-15226553
 ] 

ASF subversion and git services commented on QPIDJMS-168:
-

Commit 715540aea55148f55b766866a2df139a5bc6a8ef in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=715540a ]

QPIDJMS-168 fix some boxing and comparison issues 

> Fix various issues reported by FindBugs
> ---
>
> Key: QPIDJMS-168
> URL: https://issues.apache.org/jira/browse/QPIDJMS-168
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> Findbugs reports a number of minor issues against the latest code, address 
> each as needed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-258) Policy compile error - possible use of uninitialized variable

[Chuck Rolke (JIRA)]

Chuck Rolke created DISPATCH-258:


 Summary: Policy compile error - possible use of uninitialized 
variable
 Key: DISPATCH-258
 URL: https://issues.apache.org/jira/browse/DISPATCH-258
 Project: Qpid Dispatch
  Issue Type: Bug
Reporter: Chuck Rolke
Assignee: Chuck Rolke


{noformat}
/builddir/build/BUILD/qpid-dispatch-0.6.0/src/policy.c: In function 
'_qd_policy_approve_link_name':
/builddir/build/BUILD/qpid-dispatch-0.6.0/src/policy.c:560: error: 'toknext' 
may be used uninitialized in this function
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPIDJMS-168) Fix various issues reported by FindBugs

[Timothy Bish (JIRA)]

Timothy Bish created QPIDJMS-168:


 Summary: Fix various issues reported by FindBugs
 Key: QPIDJMS-168
 URL: https://issues.apache.org/jira/browse/QPIDJMS-168
 Project: Qpid JMS
  Issue Type: Improvement
  Components: qpid-jms-client
Affects Versions: 0.8.0
Reporter: Timothy Bish
Assignee: Timothy Bish
 Fix For: 0.9.0


Findbugs reports a number of minor issues against the latest code, address each 
as needed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-7097) [Java Broker, HA] Broker configuration thread is used to perform notifications about removal of BDB HA VirtualHost when VH is closed in response to environment state trans

[Alex Rudyy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7097:
-
Status: Reviewable  (was: In Progress)

> [Java Broker, HA] Broker configuration thread is used to perform 
> notifications about removal of BDB HA VirtualHost when VH is closed in 
> response to environment state transition events
> ---
>
> Key: QPID-7097
> URL: https://issues.apache.org/jira/browse/QPID-7097
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> Broker configuration thread is used to perform notifications about removal of 
> BDB HA VirtualHost when VH is closed in response to environment state 
> transition events.VH is a child of  VHN and VHN configuration thread should 
> be used to close VH



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (QPID-7097) [Java Broker, HA] Broker configuration thread is used to perform notifications about removal of BDB HA VirtualHost when VH is closed in response to environment state tran

[Alex Rudyy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-7097:


Assignee: Keith Wall  (was: Alex Rudyy)

Keith,
Please review the change

> [Java Broker, HA] Broker configuration thread is used to perform 
> notifications about removal of BDB HA VirtualHost when VH is closed in 
> response to environment state transition events
> ---
>
> Key: QPID-7097
> URL: https://issues.apache.org/jira/browse/QPID-7097
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.1
>Reporter: Alex Rudyy
>Assignee: Keith Wall
> Fix For: qpid-java-6.1
>
>
> Broker configuration thread is used to perform notifications about removal of 
> BDB HA VirtualHost when VH is closed in response to environment state 
> transition events.VH is a child of  VHN and VHN configuration thread should 
> be used to close VH



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7097) [Java Broker, HA] Broker configuration thread is used to perform notifications about removal of BDB HA VirtualHost when VH is closed in response to environment state tra

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226526#comment-15226526
 ] 

ASF subversion and git services commented on QPID-7097:
---

Commit 1737850 from oru...@apache.org in branch 'java/branches/6.0.x'
[ https://svn.apache.org/r1737850 ]

QPID-7097: Use VHN child executor to notify listeners about BDB HA VH close

> [Java Broker, HA] Broker configuration thread is used to perform 
> notifications about removal of BDB HA VirtualHost when VH is closed in 
> response to environment state transition events
> ---
>
> Key: QPID-7097
> URL: https://issues.apache.org/jira/browse/QPID-7097
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> Broker configuration thread is used to perform notifications about removal of 
> BDB HA VirtualHost when VH is closed in response to environment state 
> transition events.VH is a child of  VHN and VHN configuration thread should 
> be used to close VH



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Reopened] (QPID-7097) [Java Broker, HA] Broker configuration thread is used to perform notifications about removal of BDB HA VirtualHost when VH is closed in response to environment state tran

[Alex Rudyy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reopened QPID-7097:
--

Reopening issue in order to do corresponding changes in 6.0.x branch

> [Java Broker, HA] Broker configuration thread is used to perform 
> notifications about removal of BDB HA VirtualHost when VH is closed in 
> response to environment state transition events
> ---
>
> Key: QPID-7097
> URL: https://issues.apache.org/jira/browse/QPID-7097
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> Broker configuration thread is used to perform notifications about removal of 
> BDB HA VirtualHost when VH is closed in response to environment state 
> transition events.VH is a child of  VHN and VHN configuration thread should 
> be used to close VH



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Python messaging test suite (qpid.tests.messaging) - running against the swigged CPP client

[Alan Conway]

On Tue, 2016-04-05 at 10:36 +0100, Keith W wrote:
> Hi all,
> 
> It is possible to run the Python messaging test suite
> (qpid.tests.messaging) against the swigged CPP client?

My guess is "yes but you'll probably have to fix a few snags". 

I got the HA tests running with both pure & swigged clients, check
out qpid/cpp/src/tests/ha_tests.py.  I think at the time I aspired to
push that back to more general tests (e.g. qpid.tests.messaging) and
never got to it. There are a couple of differences between the swig &
native client that affect HA in particular (search for "swig" in the HA
tests) where I had to force use of native client, but that's mostly
because I'm doing something unusual for the HA tests. The HA tests have
code for loading/detecting swig vs. native clients that can/should be
moved into a more general area of the test framework.

Good luck, shout if I can help with pointers.


> I have looked at the code, and I think the answer is currently no.  I
> see one test script (qpid/tests/messaging/message.py) that can use
> either the pure python implementation or swigged client
> (qpid_messaging) if QPID_USE_SWIG_CLIENT is set, but the remainder
> seem to have a direct dependency on qpid.messaging.* (i.e. the pure
> python impl).
> 
> I ask because I hope to interoperability test the Java Broker's AMQP
> 1.0 support with the Cpp client + Proton and the messaging tests
> seemed at first glance to be an attractive option.
> 
> Does the Python messaging test suite have this ability? If not, is
> there an alternative test suite?
> 
> btw. I am already building proton, cpp and am able to run the
> qpid_tests.broker_1_0.* tests against the Java Broker's AMQP 1.0
> implementation.

> 
> cheers Keith
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-166) Revisit some of the TODOs in the code around error messages and exception types.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226408#comment-15226408
 ] 

ASF subversion and git services commented on QPIDJMS-166:
-

Commit db4941afc3832aeae89efacaa5479ba4032a in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=db4941a ]

QPIDJMS-166 Remove workaround for interop with older proton releases,
change has been in proton since 0.10.0

> Revisit some of the TODOs in the code around error messages and exception 
> types.  
> --
>
> Key: QPIDJMS-166
> URL: https://issues.apache.org/jira/browse/QPIDJMS-166
> Project: Qpid JMS
>  Issue Type: Improvement
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> We have a number of older TODO annotations in different places about the 
> error messages and the type of error exception thrown, we should revisit some 
> of these and try and produce more meaningful results.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Issue Comment Deleted] (DISPATCH-254) Router crash after several management requests

[Ernest Allen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen updated DISPATCH-254:
--
Comment: was deleted

(was: Full backtrace of a similar crash.
#0  0x76ba7a98 in __GI_raise (sig=sig@entry=6)
at ../sysdeps/unix/sysv/linux/raise.c:55
#1  0x76ba969a in __GI_abort () at abort.c:89
#2  0x76ba0227 in __assert_fail_base (fmt=, 
assertion=assertion@entry=0x77bcbafc "item->desc == desc", 
file=file@entry=0x77bcb8a0 
"/home/eallen/workspace/qpid-dispatch/src/alloc_pool.c", line=line@entry=214, 
function=function@entry=0x77bcbce0 <__PRETTY_FUNCTION__.9429> 
"qd_dealloc") at assert.c:92
#3  0x76ba02d2 in __GI___assert_fail (
assertion=0x77bcbafc "item->desc == desc", 
file=0x77bcb8a0 
"/home/eallen/workspace/qpid-dispatch/src/alloc_pool.c", line=214, 
function=0x77bcbce0 <__PRETTY_FUNCTION__.9429> "qd_dealloc")
at assert.c:101
#4  0x77bc1d39 in qd_dealloc (
desc=0x77dd8a20 <__desc_qd_bitmask_t>, tpool=0x77fd0800, 
p=0x7fffdc02f450)
at /home/eallen/workspace/qpid-dispatch/src/alloc_pool.c:214
#5  0x77b8c30e in free_qd_bitmask_t (p=0x7fffdc02f450)
at /home/eallen/workspace/qpid-dispatch/src/bitmask.c:37
#6  0x77b8c38b in qd_bitmask_free (b=0x7fffdc02f450)
at /home/eallen/workspace/qpid-dispatch/src/bitmask.c:65
#7  0x77bb6c48 in qdr_delivery_free (delivery=0x7fffe406b9f0)
---Type  to continue, or q  to quit---
   allen/workspace/qpid-dispatch/src/router_core/transfer.c:206
#8  0x77bb6a14 in qdr_link_process_deliveries (core=0x8cb5a0, 
link=0x7fffe403c4c0, credit=6)
at /home/eallen/workspace/qpid-dispatch/src/router_core/transfer.c:147
#9  0x77bb93c9 in CORE_link_push (context=0x860f70, 
link=0x7fffe403c4c0)
at /home/eallen/workspace/qpid-dispatch/src/router_node.c:748
#10 0x77ba9f89 in qdr_connection_process (conn=0x8eea40)
at /home/eallen/workspace/qpid-dispatch/src/router_core/connections.c:171
#11 0x77bb7e90 in AMQP_writable_conn_handler (type_context=0x860f70, 
conn=0x7fffdc000a20, context=0x0)
at /home/eallen/workspace/qpid-dispatch/src/router_node.c:84
#12 0x77b91443 in writable_handler (container=0x876b80, 
conn=0x7fffdc004e10, qd_conn=0x7fffdc000a20)
at /home/eallen/workspace/qpid-dispatch/src/container.c:356
#13 0x77b91cb8 in handler (handler_context=0x876b80, 
conn_context=0x8ea560, event=QD_CONN_EVENT_WRITABLE, 
qd_conn=0x7fffdc000a20)
at /home/eallen/workspace/qpid-dispatch/src/container.c:587
#14 0x77bbcef7 in process_connector (qd_server=0x8737a0, 
cxtr=0x7fffdc006cd0)
at /home/eallen/workspace/qpid-dispatch/src/server.c:721
#15 0x77bbd7a7 in thread_run (arg=0x87b620)
at /home/eallen/workspace/qpid-dispatch/src/server.c:941
#16 0x77bbea65 in qd_server_run (qd=0x604030)
at /home/eallen/workspace/qpid-dispatch/src/server.c:1331
#17 0x00401aad in main_process (
config_path=0x7fffd762 
"/home/eallen/workspace/qpid-dispatch/tests/config-2/B.conf", 
python_pkgdir=0x4026e0 
"/home/eallen/workspace/qpid-dispatch/install/lib/qpid-dispatch/python", fd=2)
at /home/eallen/workspace/qpid-dispatch/router/src/main.c:135
#18 0x0040234b in main (argc=3, argv=0x7fffd368)
at /home/eallen/workspace/qpid-dispatch/router/src/main.c:335
)

> Router crash after several management requests
> --
>
> Key: DISPATCH-254
> URL: https://issues.apache.org/jira/browse/DISPATCH-254
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 0.6
>
> Attachments: core_backtrace, router.crash.tar.gz
>
>
> A router will spontaneously crash after being connected to the console for a 
> few minutes. During that time, the console is making management requests 
> every 2 seconds:
> GET-MGMT-NODES for the connected router and QUERY for entities router, 
> connection, container, router.node, listener, router.link for each router in 
> the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-254) Router crash after several management requests

[Ernest Allen (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226393#comment-15226393
 ] 

Ernest Allen commented on DISPATCH-254:
---

Full backtrace of a similar crash.
#0  0x76ba7a98 in __GI_raise (sig=sig@entry=6)
at ../sysdeps/unix/sysv/linux/raise.c:55
#1  0x76ba969a in __GI_abort () at abort.c:89
#2  0x76ba0227 in __assert_fail_base (fmt=, 
assertion=assertion@entry=0x77bcbafc "item->desc == desc", 
file=file@entry=0x77bcb8a0 
"/home/eallen/workspace/qpid-dispatch/src/alloc_pool.c", line=line@entry=214, 
function=function@entry=0x77bcbce0 <__PRETTY_FUNCTION__.9429> 
"qd_dealloc") at assert.c:92
#3  0x76ba02d2 in __GI___assert_fail (
assertion=0x77bcbafc "item->desc == desc", 
file=0x77bcb8a0 
"/home/eallen/workspace/qpid-dispatch/src/alloc_pool.c", line=214, 
function=0x77bcbce0 <__PRETTY_FUNCTION__.9429> "qd_dealloc")
at assert.c:101
#4  0x77bc1d39 in qd_dealloc (
desc=0x77dd8a20 <__desc_qd_bitmask_t>, tpool=0x77fd0800, 
p=0x7fffdc02f450)
at /home/eallen/workspace/qpid-dispatch/src/alloc_pool.c:214
#5  0x77b8c30e in free_qd_bitmask_t (p=0x7fffdc02f450)
at /home/eallen/workspace/qpid-dispatch/src/bitmask.c:37
#6  0x77b8c38b in qd_bitmask_free (b=0x7fffdc02f450)
at /home/eallen/workspace/qpid-dispatch/src/bitmask.c:65
#7  0x77bb6c48 in qdr_delivery_free (delivery=0x7fffe406b9f0)
---Type  to continue, or q  to quit---
   allen/workspace/qpid-dispatch/src/router_core/transfer.c:206
#8  0x77bb6a14 in qdr_link_process_deliveries (core=0x8cb5a0, 
link=0x7fffe403c4c0, credit=6)
at /home/eallen/workspace/qpid-dispatch/src/router_core/transfer.c:147
#9  0x77bb93c9 in CORE_link_push (context=0x860f70, 
link=0x7fffe403c4c0)
at /home/eallen/workspace/qpid-dispatch/src/router_node.c:748
#10 0x77ba9f89 in qdr_connection_process (conn=0x8eea40)
at /home/eallen/workspace/qpid-dispatch/src/router_core/connections.c:171
#11 0x77bb7e90 in AMQP_writable_conn_handler (type_context=0x860f70, 
conn=0x7fffdc000a20, context=0x0)
at /home/eallen/workspace/qpid-dispatch/src/router_node.c:84
#12 0x77b91443 in writable_handler (container=0x876b80, 
conn=0x7fffdc004e10, qd_conn=0x7fffdc000a20)
at /home/eallen/workspace/qpid-dispatch/src/container.c:356
#13 0x77b91cb8 in handler (handler_context=0x876b80, 
conn_context=0x8ea560, event=QD_CONN_EVENT_WRITABLE, 
qd_conn=0x7fffdc000a20)
at /home/eallen/workspace/qpid-dispatch/src/container.c:587
#14 0x77bbcef7 in process_connector (qd_server=0x8737a0, 
cxtr=0x7fffdc006cd0)
at /home/eallen/workspace/qpid-dispatch/src/server.c:721
#15 0x77bbd7a7 in thread_run (arg=0x87b620)
at /home/eallen/workspace/qpid-dispatch/src/server.c:941
#16 0x77bbea65 in qd_server_run (qd=0x604030)
at /home/eallen/workspace/qpid-dispatch/src/server.c:1331
#17 0x00401aad in main_process (
config_path=0x7fffd762 
"/home/eallen/workspace/qpid-dispatch/tests/config-2/B.conf", 
python_pkgdir=0x4026e0 
"/home/eallen/workspace/qpid-dispatch/install/lib/qpid-dispatch/python", fd=2)
at /home/eallen/workspace/qpid-dispatch/router/src/main.c:135
#18 0x0040234b in main (argc=3, argv=0x7fffd368)
at /home/eallen/workspace/qpid-dispatch/router/src/main.c:335


> Router crash after several management requests
> --
>
> Key: DISPATCH-254
> URL: https://issues.apache.org/jira/browse/DISPATCH-254
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 0.6
>
> Attachments: core_backtrace, router.crash.tar.gz
>
>
> A router will spontaneously crash after being connected to the console for a 
> few minutes. During that time, the console is making management requests 
> every 2 seconds:
> GET-MGMT-NODES for the connected router and QUERY for entities router, 
> connection, container, router.node, listener, router.link for each router in 
> the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPIDJMS-158) Update slf4j to latest release v1.7.21

[Timothy Bish (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved QPIDJMS-158.
--
Resolution: Fixed

> Update slf4j to latest release v1.7.21
> --
>
> Key: QPIDJMS-158
> URL: https://issues.apache.org/jira/browse/QPIDJMS-158
> Project: Qpid JMS
>  Issue Type: Task
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
>Priority: Minor
> Fix For: 0.9.0
>
>
> Update client to use the latest slf4j release (1.7.19 currently) which has 
> fixes for multi-threaded access and lost logs during initialization amongst 
> other things.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-158) Update slf4j to latest release v1.7.21

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226368#comment-15226368
 ] 

ASF subversion and git services commented on QPIDJMS-158:
-

Commit 536f966dd9ac16ce8b460509137031a60b552cc9 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=536f966 ]

QPIDJMS-158 Update to slf4j 1.7.21 to address memory leak in 1.7.19 and 1.7.20


> Update slf4j to latest release v1.7.21
> --
>
> Key: QPIDJMS-158
> URL: https://issues.apache.org/jira/browse/QPIDJMS-158
> Project: Qpid JMS
>  Issue Type: Task
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
>Priority: Minor
> Fix For: 0.9.0
>
>
> Update client to use the latest slf4j release (1.7.19 currently) which has 
> fixes for multi-threaded access and lost logs during initialization amongst 
> other things.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7182) [C++ broker] high CPU usage on backup brokers following QPID-7149 scenario

[Alan Conway (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226343#comment-15226343
 ] 

Alan Conway commented on QPID-7182:
---

Can you confirm if  you still see this after the following commit on trunk. It 
looks like the same thing (QueueReplicator receives the event e from 
ReplicatingSubscription, so fixing RS should also fix the problem at QR)

commit 006496cf708639db842f37941c40f7d452789509
Author: Alan Conway 
Commit: Alan Conway 

Bug 1318180 - HA memory leak in primary broker when overwriting messages in 
a ring queue

ReplicatingSubscription accumulates IDs of dequeued messages to send on
dispatch. It should clear the accumulated IDs once sent. Due to a merge 
error,
since:

014f0f3 QPID-4327: HA TX transactions: basic replication.

The ID set is not cleared, causing it to accumulate memory slowly.

This leak would be particularly noticeable on a busy ring-queue since a
ring-queue generates a dequeue event for every enqueue once it reaches its 
max
size.

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1735439 
13f79535-47bb-0310-9956-ffa450edef68


> [C++ broker] high CPU usage on backup brokers following QPID-7149 scenario
> --
>
> Key: QPID-7182
> URL: https://issues.apache.org/jira/browse/QPID-7182
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Clustering
>Affects Versions: qpid-cpp-next
>Reporter: Pavel Moravec
>Assignee: Alan Conway
>
> Following scenario from QPID-7149 with --ha-replicate=all, with whatever 
> patch fixing it applied or not, CPU usage of backup brokers grow over the 
> time.
> gdb shows one active thread always with backtrace:
> {noformat}
> #0  0x7f9295fc9c98 in find (this=0x7f9270055840, data= out>)
> at 
> /usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../include/c++/4.4.7/tr1_impl/hashtable:786
> #1  qpid::ha::QueueReplicator::dequeueEvent (this=0x7f9270055840, data= optimized out>)
> at /data_xfs/qpid/cpp/src/qpid/ha/QueueReplicator.cpp:306
> #2  0x7f9295fca82b in operator() (this=0x7f9270055840, deliverable= optimized out>)
> at /usr/include/boost/function/function_template.hpp:1013
> #3  qpid::ha::QueueReplicator::route (this=0x7f9270055840, deliverable= optimized out>)
> at /data_xfs/qpid/cpp/src/qpid/ha/QueueReplicator.cpp:329
> #4  0x7f9296b9b854 in qpid::broker::SemanticState::route 
> (this=0x7f927001d088, msg=..., strategy=...)
> at /data_xfs/qpid/cpp/src/qpid/broker/SemanticState.cpp:506
> #5  0x7f9296bb8ab7 in qpid::broker::SessionState::handleContent 
> (this=0x7f927001cec0, frame=)
> at /data_xfs/qpid/cpp/src/qpid/broker/SessionState.cpp:233
> #6  0x7f9296bb90a1 in qpid::broker::SessionState::handleIn 
> (this=0x7f927001cec0, frame=...)
> at /data_xfs/qpid/cpp/src/qpid/broker/SessionState.cpp:293
> #7  0x7f92965d4c31 in qpid::amqp_0_10::SessionHandler::handleIn 
> (this=0x7f927002fbb0, f=...)
> at /data_xfs/qpid/cpp/src/qpid/amqp_0_10/SessionHandler.cpp:93
> #8  0x7f9296b29a2b in operator() (this=0x7f9270002060, frame=...) at 
> /data_xfs/qpid/cpp/src/qpid/framing/Handler.h:39
> #9  qpid::broker::ConnectionHandler::handle (this=0x7f9270002060, frame=...)
> at /data_xfs/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp:93
> #10 0x7f9296b247e8 in qpid::broker::amqp_0_10::Connection::received 
> (this=0x7f9270001e80, frame=...)
> at /data_xfs/qpid/cpp/src/qpid/broker/amqp_0_10/Connection.cpp:198
> #11 0x7f9296ab2863 in qpid::amqp_0_10::Connection::decode 
> (this=0x7f92700018b0, buffer=, 
> size=) at 
> /data_xfs/qpid/cpp/src/qpid/amqp_0_10/Connection.cpp:59
> #12 0x7f92965fdca0 in qpid::sys::AsynchIOHandler::readbuff 
> (this=0x7f9279b0, buff=0x7f9270001880)
> at /data_xfs/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp:138
> #13 0x7f929657be89 in operator() (this=0x7f927a50, h=...) at 
> /usr/include/boost/function/function_template.hpp:1013
> #14 qpid::sys::posix::AsynchIO::readable (this=0x7f927a50, h=...) at 
> /data_xfs/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp:453
> #15 0x7f92966025b3 in boost::function1 qpid::sys::DispatchHandle&>::operator() (this=, 
> a0=) at 
> /usr/include/boost/function/function_template.hpp:1013
> #16 0x7f9296601246 in qpid::sys::DispatchHandle::processEvent 
> (this=0x7f927a58, type=qpid::sys::Poller::READABLE)
> at /data_xfs/qpid/cpp/src/qpid/sys/DispatchHandle.cpp:280
> #17 0x7f92965a1d1d in process (this=0x7961c0) at 
> /data_xfs/qpid/cpp/src/qpid/sys/Poller.h:131
> ..
> {noformat}
> or with:
> {noformat}
> #0  0x0032c4c0a7b0 in pthread_mutex_unlock () from /lib64/libpthread.so.0
> #1  0x7fb0958038fa in 

[jira] [Resolved] (DISPATCH-254) Router crash after several management requests

[Ganesh Murthy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-254.

Resolution: Fixed

Hello Ernie, the most recent commit must fix the problem you are seeing. Please 
try and let me know. thanks.

> Router crash after several management requests
> --
>
> Key: DISPATCH-254
> URL: https://issues.apache.org/jira/browse/DISPATCH-254
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 0.6
>
> Attachments: core_backtrace, router.crash.tar.gz
>
>
> A router will spontaneously crash after being connected to the console for a 
> few minutes. During that time, the console is making management requests 
> every 2 seconds:
> GET-MGMT-NODES for the connected router and QUERY for entities router, 
> connection, container, router.node, listener, router.link for each router in 
> the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-254) Router crash after several management requests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226335#comment-15226335
 ] 

ASF subversion and git services commented on DISPATCH-254:
--

Commit cdca96424da706bf43d4f405c940dcf7933e in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=cdca966 ]

DISPATCH-254 - Removed optimization that freed the qd_bitmask_t. The freeing of 
the delivery frees the bitmask as well


> Router crash after several management requests
> --
>
> Key: DISPATCH-254
> URL: https://issues.apache.org/jira/browse/DISPATCH-254
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 0.6
>
> Attachments: core_backtrace, router.crash.tar.gz
>
>
> A router will spontaneously crash after being connected to the console for a 
> few minutes. During that time, the console is making management requests 
> every 2 seconds:
> GET-MGMT-NODES for the connected router and QUERY for entities router, 
> connection, container, router.node, listener, router.link for each router in 
> the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPIDJMS-158) Update slf4j to latest release v1.7.21

[Timothy Bish (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish updated QPIDJMS-158:
-
Summary: Update slf4j to latest release v1.7.21  (was: Update slf4j to 
latest release v1.7.19)

> Update slf4j to latest release v1.7.21
> --
>
> Key: QPIDJMS-158
> URL: https://issues.apache.org/jira/browse/QPIDJMS-158
> Project: Qpid JMS
>  Issue Type: Task
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
>Priority: Minor
> Fix For: 0.9.0
>
>
> Update client to use the latest slf4j release (1.7.19 currently) which has 
> fixes for multi-threaded access and lost logs during initialization amongst 
> other things.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Reopened] (QPIDJMS-158) Update slf4j to latest release v1.7.19

[Timothy Bish (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish reopened QPIDJMS-158:
--

> Update slf4j to latest release v1.7.19
> --
>
> Key: QPIDJMS-158
> URL: https://issues.apache.org/jira/browse/QPIDJMS-158
> Project: Qpid JMS
>  Issue Type: Task
>  Components: qpid-jms-client
>Affects Versions: 0.8.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
>Priority: Minor
> Fix For: 0.9.0
>
>
> Update client to use the latest slf4j release (1.7.19 currently) which has 
> fixes for multi-threaded access and lost logs during initialization amongst 
> other things.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-254) Router crash after several management requests

[Ernest Allen (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226319#comment-15226319
 ] 

Ernest Allen commented on DISPATCH-254:
---

When run under gdb, I'm also seeing a qd_dealloc assertion:
qdrouterd: /home/eallen/workspace/qpid-dispatch/src/alloc_pool.c:233: 
qd_dealloc: Assertion `(item)->prev == 0' failed.

Program received signal SIGABRT, Aborted.


> Router crash after several management requests
> --
>
> Key: DISPATCH-254
> URL: https://issues.apache.org/jira/browse/DISPATCH-254
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 0.6
>
> Attachments: core_backtrace, router.crash.tar.gz
>
>
> A router will spontaneously crash after being connected to the console for a 
> few minutes. During that time, the console is making management requests 
> every 2 seconds:
> GET-MGMT-NODES for the connected router and QUERY for entities router, 
> connection, container, router.node, listener, router.link for each router in 
> the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7112) Create UI for the CloudFoundry Group Provider

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226288#comment-15226288
 ] 

ASF subversion and git services commented on QPID-7112:
---

Commit 1737839 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1737839 ]

QPID-7112: [Java Broker] Fix setting of permitted nodes in Web Management 
Console

> Create UI for the CloudFoundry Group Provider
> -
>
> Key: QPID-7112
> URL: https://issues.apache.org/jira/browse/QPID-7112
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7112-Java-Broker-Add-UI-for-CloudFoundryDashboa.patch, 
> 0001-QPID-7112-Java-Broker-Add-UI-for-CloudFoundryDashboa.patch
>
>
> Create UI for the CloudFoundry Group Provider



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPIDJMS-167) Provide event hooks in the JmsConnectionListener to receive notification of resources being remotely closed

[Timothy Bish (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved QPIDJMS-167.
--
Resolution: Fixed

> Provide event hooks in the JmsConnectionListener to receive notification of 
> resources being remotely closed
> ---
>
> Key: QPIDJMS-167
> URL: https://issues.apache.org/jira/browse/QPIDJMS-167
> Project: Qpid JMS
>  Issue Type: Sub-task
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> Add a set of events for remote close of Session, MessageProducer and 
> MessageConsumer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-167) Provide event hooks in the JmsConnectionListener to receive notification of resources being remotely closed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226276#comment-15226276
 ] 

ASF subversion and git services commented on QPIDJMS-167:
-

Commit c9439171d52a3d1246094df1324fd8bb6c08f086 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=c943917 ]

QPIDJMS-167 Add event point to get notified that the remote has closed a
session, producer or consumer.

> Provide event hooks in the JmsConnectionListener to receive notification of 
> resources being remotely closed
> ---
>
> Key: QPIDJMS-167
> URL: https://issues.apache.org/jira/browse/QPIDJMS-167
> Project: Qpid JMS
>  Issue Type: Sub-task
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> Add a set of events for remote close of Session, MessageProducer and 
> MessageConsumer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-254) Router crash after several management requests

[Ganesh Murthy (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226224#comment-15226224
 ] 

Ganesh Murthy commented on DISPATCH-254:


I see the following backtrace 

{noformat}
#0  0x7fac48d3fa98 in raise () from /lib64/libc.so.6
#1  0x7fac48d4169a in abort () from /lib64/libc.so.6
#2  0x7fac48d38227 in __assert_fail_base () from /lib64/libc.so.6
#3  0x7fac48d382d2 in __assert_fail () from /lib64/libc.so.6
#4  0x7fac49d5ad49 in qd_dealloc (desc=0x7fac49f71a20 
<__desc_qd_bitmask_t>, tpool=0x7fac3c606d80, p=0x7fac340287e0) at 
/home/gmurthy/opensource/dispatch/src/alloc_pool.c:214
#5  0x7fac49d2531e in free_qd_bitmask_t (p=0x7fac340287e0) at 
/home/gmurthy/opensource/dispatch/src/bitmask.c:37
#6  0x7fac49d2539b in qd_bitmask_free (b=0x7fac340287e0) at 
/home/gmurthy/opensource/dispatch/src/bitmask.c:65
#7  0x7fac49d502d2 in qdr_link_forward_CT (core=0x1efeac0, 
link=0x7fac3403c4b0, dlv=0x7fac300267b0, addr=0x7fac340245e0) at 
/home/gmurthy/opensource/dispatch/src/router_core/transfer.c:370
#8  0x7fac49d50575 in qdr_link_deliver_CT (core=0x1efeac0, 
action=0x7fac2c023d40, discard=false) at 
/home/gmurthy/opensource/dispatch/src/router_core/transfer.c:425
#9  0x7fac49d4b7a9 in router_core_thread (arg=0x1efeac0) at 
/home/gmurthy/opensource/dispatch/src/router_core/router_core_thread.c:71
#10 0x7fac498a860a in start_thread () from /lib64/libpthread.so.0
#11 0x7fac48e0da4d in clone () from /lib64/libc.so.6
{noformat}

> Router crash after several management requests
> --
>
> Key: DISPATCH-254
> URL: https://issues.apache.org/jira/browse/DISPATCH-254
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 0.6
>
> Attachments: core_backtrace, router.crash.tar.gz
>
>
> A router will spontaneously crash after being connected to the console for a 
> few minutes. During that time, the console is making management requests 
> every 2 seconds:
> GET-MGMT-NODES for the connected router and QUERY for entities router, 
> connection, container, router.node, listener, router.link for each router in 
> the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7023) BDB HA: JE Cleaner warnings written to qpid log during apparently normal operation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226210#comment-15226210
 ] 

ASF subversion and git services commented on QPID-7023:
---

Commit 1737835 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1737835 ]

QPID-7023: [Java Broker] Change severety of cleaner warning logs about not 
deleted protected files to DEBUG if number of protected files is less than 10

> BDB HA: JE Cleaner warnings written to qpid log during apparently normal 
> operation 
> ---
>
> Key: QPID-7023
> URL: https://issues.apache.org/jira/browse/QPID-7023
> Project: Qpid
>  Issue Type: Bug
>Affects Versions: 0.32, qpid-java-6.0
>Reporter: Keith Wall
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
>
> The Java Broker directs JE log log messages to the qpid.log bridging from JUL 
> to SLF4J.
> During operation of the group, with a relatively high transactional 
> publish/consume workload, messages like this are seen. These are written to 
> all nodes (master and replica) even when all nodes are on-line:
> {noformat}
> 2016-01-26 08:59:36,360 WARN  [Checkpointer] (BDB) - [mynode1] Cleaner has 3 
> files not deleted because they are protected by replication.
> 2016-01-26 08:59:38,966 WARN  [Checkpointer] (BDB) - [mynode1] Cleaner has 2 
> files not deleted because they are protected by DbBackup or replication.
> 2016-01-26 08:59:41,646 WARN  [Checkpointer] (BDB) - [mynode1] Cleaner has 2 
> files not deleted because they are protected by DbBackup or replication.
> 2016-01-26 08:59:43,987 WARN  [Checkpointer] (BDB) - [mynode1] Cleaner has 1 
> files not deleted because they are protected by DbBackup or replication.
> 2016-01-26 08:59:46,494 WARN  [Checkpointer] (BDB) - [mynode1] Cleaner has 2 
> files not deleted because they are protected by DbBackup or replication.
> 2016-01-26 08:59:52,588 WARN  [Checkpointer] (BDB) - [mynode1] Cleaner has 1 
> files not deleted because they are protected by DbBackup or replication.
> 2016-01-26 09:00:45,684 WARN  [Checkpointer] (BDB) - [mynode1] Cleaner has 2 
> files not deleted because they are protected by DbBackup or replication.
> {noformat}
> Additionally replicas see messages like this:
> {noformat}
> 2016-01-26 08:59:36,359 WARN  [Checkpointer] (BDB) - [mynode1] Replication 
> prevents deletion of 3 files by Cleaner. Start file=0x280 holds CBVLSN 
> 27,742,300, end file=0x287 holds end VLSN 28,040,638
> {noformat}
> The extent of the backlog never seems to get worse, and there is no 
> functional impact.
> The forum post https://community.oracle.com/thread/2541709 makes me suspect 
> that this warning might be normal if the backlogs remains 'small'.
> I have reproduced this problem on 0.32 and qpid-java-6.0.  It is possible it 
> occurs on 0.30 too, but there the JE log file was not redirected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-254) Router crash after several management requests

[Ernest Allen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen updated DISPATCH-254:
--
Attachment: core_backtrace

backtrace of latest crash 

> Router crash after several management requests
> --
>
> Key: DISPATCH-254
> URL: https://issues.apache.org/jira/browse/DISPATCH-254
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 0.6
>
> Attachments: core_backtrace, router.crash.tar.gz
>
>
> A router will spontaneously crash after being connected to the console for a 
> few minutes. During that time, the console is making management requests 
> every 2 seconds:
> GET-MGMT-NODES for the connected router and QUERY for entities router, 
> connection, container, router.node, listener, router.link for each router in 
> the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Reopened] (DISPATCH-254) Router crash after several management requests

[Ernest Allen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen reopened DISPATCH-254:
---

Still seeing a crash. 

> Router crash after several management requests
> --
>
> Key: DISPATCH-254
> URL: https://issues.apache.org/jira/browse/DISPATCH-254
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 0.6
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 0.6
>
> Attachments: router.crash.tar.gz
>
>
> A router will spontaneously crash after being connected to the console for a 
> few minutes. During that time, the console is making management requests 
> every 2 seconds:
> GET-MGMT-NODES for the connected router and QUERY for entities router, 
> connection, container, router.node, listener, router.link for each router in 
> the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[Alex Rudyy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-7185.
--
Resolution: Fixed

The change look reasonable to me

> ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved 
> fails sporadically on Apache CI
> 
>
> Key: QPID-7185
> URL: https://issues.apache.org/jira/browse/QPID-7185
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> The test {{testReplicationGroupListenerHearsNodeRemoved}} failed in the 
> following way on the Apache CI host:
> {noformat}
> org.apache.qpid.server.store.StoreException: Exception on node removal from 
> group
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
> {noformat}
> The underlying exception was as follows:
> {noformat}
> 2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
> Exception on node removal from group
> com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
> Transaction -20 cannot execute write operations because this node is no 
> longer a master UNEXPECTED_STATE: Unexpected internal state, may have side 
> effects.
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>  ~[classes/:na]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
>  [test-classes/:na]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[na:1.7.0_80]
>   at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
>   at junit.framework.TestCase.runTest(TestCase.java:176) 
> [junit-4.11.jar:na]
>   at 
> org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestCase.runBare(TestCase.java:141) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult$1.protect(TestResult.java:122) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.runProtected(TestResult.java:142) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.run(TestResult.java:125) 
> [junit-4.11.jar:na]
>   at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestSuite.runTest(TestSuite.java:255) 
> [junit-4.11.jar:na]
>   at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
> [junit-4.11.jar:na]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
>  

[jira] [Updated] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7185:
-
Assignee: Alex Rudyy  (was: Keith Wall)

> ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved 
> fails sporadically on Apache CI
> 
>
> Key: QPID-7185
> URL: https://issues.apache.org/jira/browse/QPID-7185
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> The test {{testReplicationGroupListenerHearsNodeRemoved}} failed in the 
> following way on the Apache CI host:
> {noformat}
> org.apache.qpid.server.store.StoreException: Exception on node removal from 
> group
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
> {noformat}
> The underlying exception was as follows:
> {noformat}
> 2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
> Exception on node removal from group
> com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
> Transaction -20 cannot execute write operations because this node is no 
> longer a master UNEXPECTED_STATE: Unexpected internal state, may have side 
> effects.
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>  ~[classes/:na]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
>  [test-classes/:na]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[na:1.7.0_80]
>   at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
>   at junit.framework.TestCase.runTest(TestCase.java:176) 
> [junit-4.11.jar:na]
>   at 
> org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestCase.runBare(TestCase.java:141) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult$1.protect(TestResult.java:122) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.runProtected(TestResult.java:142) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.run(TestResult.java:125) 
> [junit-4.11.jar:na]
>   at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestSuite.runTest(TestSuite.java:255) 
> [junit-4.11.jar:na]
>   at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
> [junit-4.11.jar:na]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
>  

[jira] [Updated] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7185:
-
Description: 
The test {{testReplicationGroupListenerHearsNodeRemoved}} failed in the 
following way on the Apache CI host:

{noformat}
org.apache.qpid.server.store.StoreException: Exception on node removal from 
group
at 
com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
at 
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
at 
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
{noformat}

The underlying exception was as follows:

{noformat}
2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
Exception on node removal from group
com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
Transaction -20 cannot execute write operations because this node is no longer 
a master UNEXPECTED_STATE: Unexpected internal state, may have side effects.
at 
com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
 ~[je-5.0.104.jar:5.0.104]
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
 ~[je-5.0.104.jar:5.0.104]
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
 ~[je-5.0.104.jar:5.0.104]
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
 ~[je-5.0.104.jar:5.0.104]
at 
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
 ~[classes/:na]
at 
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
 [test-classes/:na]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[na:1.7.0_80]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
~[na:1.7.0_80]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[na:1.7.0_80]
at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
at junit.framework.TestCase.runTest(TestCase.java:176) 
[junit-4.11.jar:na]
at 
org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
[qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
at junit.framework.TestCase.runBare(TestCase.java:141) 
[junit-4.11.jar:na]
at junit.framework.TestResult$1.protect(TestResult.java:122) 
[junit-4.11.jar:na]
at junit.framework.TestResult.runProtected(TestResult.java:142) 
[junit-4.11.jar:na]
at junit.framework.TestResult.run(TestResult.java:125) 
[junit-4.11.jar:na]
at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
[qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
at junit.framework.TestSuite.runTest(TestSuite.java:255) 
[junit-4.11.jar:na]
at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
[junit-4.11.jar:na]
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
 [surefire-junit4-2.17.jar:2.17]
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
 [surefire-junit4-2.17.jar:2.17]
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) 
[surefire-junit4-2.17.jar:2.17]
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
 [surefire-booter-2.17.jar:2.17]
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
 [surefire-booter-2.17.jar:2.17]
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) 
[surefire-booter-2.17.jar:2.17]
{noformat}

The node that was the target of the {{ReplicationGroupAdmin.removeMember}} call 
was at that moment being restarted as majority had been lost.  This seems to 
have provoked an unexpected exception from within JE.

The test is concerned with ensuring the listener fires 

[jira] [Updated] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7185:
-
Status: Reviewable  (was: In Progress)

> ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved 
> fails sporadically on Apache CI
> 
>
> Key: QPID-7185
> URL: https://issues.apache.org/jira/browse/QPID-7185
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> The test {{testReplicationGroupListenerHearsNodeRemoved}} failed in the 
> following way on the Apache CI host:
> {noformat}
> org.apache.qpid.server.store.StoreException: Exception on node removal from 
> group
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
> {noformat}
> The underlying exception was as follows:
> {noformat}
> 2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
> Exception on node removal from group
> com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
> Transaction -20 cannot execute write operations because this node is no 
> longer a master UNEXPECTED_STATE: Unexpected internal state, may have side 
> effects.
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>  ~[classes/:na]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
>  [test-classes/:na]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[na:1.7.0_80]
>   at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
>   at junit.framework.TestCase.runTest(TestCase.java:176) 
> [junit-4.11.jar:na]
>   at 
> org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestCase.runBare(TestCase.java:141) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult$1.protect(TestResult.java:122) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.runProtected(TestResult.java:142) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.run(TestResult.java:125) 
> [junit-4.11.jar:na]
>   at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestSuite.runTest(TestSuite.java:255) 
> [junit-4.11.jar:na]
>   at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
> [junit-4.11.jar:na]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
>  

[jira] [Updated] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7185:
-
Assignee: Alex Rudyy

> ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved 
> fails sporadically on Apache CI
> 
>
> Key: QPID-7185
> URL: https://issues.apache.org/jira/browse/QPID-7185
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> The test {{testReplicationGroupListenerHearsNodeRemoved }} failed in the 
> following way on the Apache CI host:
> {noformat}
> org.apache.qpid.server.store.StoreException: Exception on node removal from 
> group
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
> {noformat}
> The underlying exception was as follows:
> {noformat}
> 2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
> Exception on node removal from group
> com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
> Transaction -20 cannot execute write operations because this node is no 
> longer a master UNEXPECTED_STATE: Unexpected internal state, may have side 
> effects.
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>  ~[classes/:na]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
>  [test-classes/:na]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[na:1.7.0_80]
>   at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
>   at junit.framework.TestCase.runTest(TestCase.java:176) 
> [junit-4.11.jar:na]
>   at 
> org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestCase.runBare(TestCase.java:141) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult$1.protect(TestResult.java:122) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.runProtected(TestResult.java:142) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.run(TestResult.java:125) 
> [junit-4.11.jar:na]
>   at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestSuite.runTest(TestSuite.java:255) 
> [junit-4.11.jar:na]
>   at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
> [junit-4.11.jar:na]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
>  [surefire-junit4-2.17.jar:2.17]
>   

[jira] [Assigned] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall reassigned QPID-7185:


Assignee: Keith Wall  (was: Alex Rudyy)

> ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved 
> fails sporadically on Apache CI
> 
>
> Key: QPID-7185
> URL: https://issues.apache.org/jira/browse/QPID-7185
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> The test {{testReplicationGroupListenerHearsNodeRemoved }} failed in the 
> following way on the Apache CI host:
> {noformat}
> org.apache.qpid.server.store.StoreException: Exception on node removal from 
> group
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
> {noformat}
> The underlying exception was as follows:
> {noformat}
> 2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
> Exception on node removal from group
> com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
> Transaction -20 cannot execute write operations because this node is no 
> longer a master UNEXPECTED_STATE: Unexpected internal state, may have side 
> effects.
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>  ~[classes/:na]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
>  [test-classes/:na]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[na:1.7.0_80]
>   at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
>   at junit.framework.TestCase.runTest(TestCase.java:176) 
> [junit-4.11.jar:na]
>   at 
> org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestCase.runBare(TestCase.java:141) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult$1.protect(TestResult.java:122) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.runProtected(TestResult.java:142) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.run(TestResult.java:125) 
> [junit-4.11.jar:na]
>   at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestSuite.runTest(TestSuite.java:255) 
> [junit-4.11.jar:na]
>   at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
> [junit-4.11.jar:na]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
>  

[jira] [Commented] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226069#comment-15226069
 ] 

ASF subversion and git services commented on QPID-7185:
---

Commit 1737820 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1737820 ]

QPID-7185: [Java Tests] HA - Avoid possibility of a node restart during 
testReplicationGroupListenerHearsNodeRemoved

> ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved 
> fails sporadically on Apache CI
> 
>
> Key: QPID-7185
> URL: https://issues.apache.org/jira/browse/QPID-7185
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Tests
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> The test {{testReplicationGroupListenerHearsNodeRemoved }} failed in the 
> following way on the Apache CI host:
> {noformat}
> org.apache.qpid.server.store.StoreException: Exception on node removal from 
> group
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
> {noformat}
> The underlying exception was as follows:
> {noformat}
> 2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
> Exception on node removal from group
> com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
> Transaction -20 cannot execute write operations because this node is no 
> longer a master UNEXPECTED_STATE: Unexpected internal state, may have side 
> effects.
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>  ~[classes/:na]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
>  [test-classes/:na]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[na:1.7.0_80]
>   at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
>   at junit.framework.TestCase.runTest(TestCase.java:176) 
> [junit-4.11.jar:na]
>   at 
> org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestCase.runBare(TestCase.java:141) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult$1.protect(TestResult.java:122) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.runProtected(TestResult.java:142) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.run(TestResult.java:125) 
> [junit-4.11.jar:na]
>   at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestSuite.runTest(TestSuite.java:255) 
> [junit-4.11.jar:na]
>   at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
> [junit-4.11.jar:na]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> 

[jira] [Updated] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7185:
-
Priority: Minor  (was: Major)

> ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved 
> fails sporadically on Apache CI
> 
>
> Key: QPID-7185
> URL: https://issues.apache.org/jira/browse/QPID-7185
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Tests
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> The test {{testReplicationGroupListenerHearsNodeRemoved }} failed in the 
> following way on the Apache CI host:
> {noformat}
> org.apache.qpid.server.store.StoreException: Exception on node removal from 
> group
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
> {noformat}
> The underlying exception was as follows:
> {noformat}
> 2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
> Exception on node removal from group
> com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
> Transaction -20 cannot execute write operations because this node is no 
> longer a master UNEXPECTED_STATE: Unexpected internal state, may have side 
> effects.
>   at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
>  ~[je-5.0.104.jar:5.0.104]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
>  ~[classes/:na]
>   at 
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
>  [test-classes/:na]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
> ~[na:1.7.0_80]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[na:1.7.0_80]
>   at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
>   at junit.framework.TestCase.runTest(TestCase.java:176) 
> [junit-4.11.jar:na]
>   at 
> org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestCase.runBare(TestCase.java:141) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult$1.protect(TestResult.java:122) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.runProtected(TestResult.java:142) 
> [junit-4.11.jar:na]
>   at junit.framework.TestResult.run(TestResult.java:125) 
> [junit-4.11.jar:na]
>   at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
>   at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
> [qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
>   at junit.framework.TestSuite.runTest(TestSuite.java:255) 
> [junit-4.11.jar:na]
>   at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
> [junit-4.11.jar:na]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
>  [surefire-junit4-2.17.jar:2.17]
>   at 
> 

[jira] [Created] (QPID-7185) ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved fails sporadically on Apache CI

[Keith Wall (JIRA)]

Keith Wall created QPID-7185:


 Summary: 
ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved 
fails sporadically on Apache CI
 Key: QPID-7185
 URL: https://issues.apache.org/jira/browse/QPID-7185
 Project: Qpid
  Issue Type: Bug
  Components: Java Tests
Reporter: Keith Wall
 Fix For: qpid-java-6.1


The test {{testReplicationGroupListenerHearsNodeRemoved }} failed in the 
following way on the Apache CI host:

{noformat}
org.apache.qpid.server.store.StoreException: Exception on node removal from 
group
at 
com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
at 
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
at 
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
{noformat}

The underlying exception was as follows:

{noformat}
2016-04-03 23:19:00,667 ERROR [main] o.a.q.s.u.ServerScopedRuntimeException 
Exception on node removal from group
com.sleepycat.je.EnvironmentFailureException: (JE 5.0.104) (JE 5.0.104) 
Transaction -20 cannot execute write operations because this node is no longer 
a master UNEXPECTED_STATE: Unexpected internal state, may have side effects.
at 
com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:426)
 ~[je-5.0.104.jar:5.0.104]
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.getException(ReplicationGroupAdmin.java:504)
 ~[je-5.0.104.jar:5.0.104]
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:474)
 ~[je-5.0.104.jar:5.0.104]
at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:245)
 ~[je-5.0.104.jar:5.0.104]
at 
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.removeNodeFromGroup(ReplicatedEnvironmentFacade.java:1284)
 ~[classes/:na]
at 
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeTest.testReplicationGroupListenerHearsNodeRemoved(ReplicatedEnvironmentFacadeTest.java:377)
 [test-classes/:na]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[na:1.7.0_80]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
~[na:1.7.0_80]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[na:1.7.0_80]
at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_80]
at junit.framework.TestCase.runTest(TestCase.java:176) 
[junit-4.11.jar:na]
at 
org.apache.qpid.test.utils.QpidTestCase.runTest(QpidTestCase.java:171) 
[qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
at junit.framework.TestCase.runBare(TestCase.java:141) 
[junit-4.11.jar:na]
at junit.framework.TestResult$1.protect(TestResult.java:122) 
[junit-4.11.jar:na]
at junit.framework.TestResult.runProtected(TestResult.java:142) 
[junit-4.11.jar:na]
at junit.framework.TestResult.run(TestResult.java:125) 
[junit-4.11.jar:na]
at junit.framework.TestCase.run(TestCase.java:129) [junit-4.11.jar:na]
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:156) 
[qpid-test-utils-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
at junit.framework.TestSuite.runTest(TestSuite.java:255) 
[junit-4.11.jar:na]
at junit.framework.TestSuite.run(TestSuite.java:250) [junit-4.11.jar:na]
at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) 
[junit-4.11.jar:na]
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
 [surefire-junit4-2.17.jar:2.17]
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
 [surefire-junit4-2.17.jar:2.17]
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) 
[surefire-junit4-2.17.jar:2.17]
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
 [surefire-booter-2.17.jar:2.17]
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
 [surefire-booter-2.17.jar:2.17]
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) 
[surefire-booter-2.17.jar:2.17]
{noformat}

The node that was 

Re: Review Request 45389: WIP PROTON-1133 - Avoid using hostname as a transport address

[Robbie Gemmell]

> On April 4, 2016, 10:32 a.m., Robbie Gemmell wrote:
> > Updated review of rev3.
> > 
> > There are two 'setConnectionAddress' methods in the Java changes, but only 
> > one in the equivalent C changes. I dont think we need the simple no-port 
> > one, it doesnt seem unreasonable to force people to specify a port they 
> > want to connect to in this sort of code (the Java bits could do exactly 
> > what the C does with a null value...though, see also next point).
> > 
> > Using a String rather than an int for the port feels a bit odd, with other 
> > bits of the Java changes even having to convert an existing int to pass the 
> > value. That said, I can see it possibly aligns slightly better with the 
> > single-String 'get address' return value.
> > 
> > I would move the new 'url' arg handling from the Send constructor (in 
> > Send.java) to the main method alongside the other arg parsing, then passing 
> > the host and port values to the Send constructor. Keeps all the arg 
> > handling in once place at the start where its typically done.
> > 
> > There are various places in the new Java changes (such as the above bit) 
> > that use if/else statements without braces, please add the braces 
> > everywhere :)
> > 
> > With my earlier comments I was actually thinking that if the connection 
> > 'attachments' were used to store the details we could just define the 
> > key(s) used to store the host/port/combined-value, then the 
> > reactor.connection(handler, host, port) style method and IO handler (plus 
> > anything else wanting to update/inspect them, such as the python Connector) 
> > would use the connection attachments directly to set/get the value(s) 
> > rather than defining any new methods to do it. Though it may be more 
> > obvious to set/get the details on the connection object itself rather than 
> > via the reactor object, the methods are definitely nicer in some ways since 
> > using the attachments is rather verbose and folks wont need to know the 
> > keys this way (though could of course still do it that way given its all 
> > the methods do ultiamtely). I think I would have retained the 
> > reactor.connection(handler, host, port) style method even if adding 'set 
> > adddress' style method though, I think it was more intuitive.
> 
> Kenneth Giusti wrote:
> Hi Robbie,
> 
> Thanks for the feedback, couple of points:
> 
> First, I'd much rather use integer port types, but on the C side the 
> acceptor constructor uses a string-based port, so I kept the interface 
> consistent (consistently wrong one might say, but that's due to the 
> underlying call to getaddrinfo()).   I'll modify the Java bits to use an 
> integer to be consistent with its Acceptor implementation.
> 
> Yes, I'll fix the braces - one can never be too safe ;)
> 
> Hrmmm - personally I'd rather stay away from using the attachments 
> directly in this case.  Setting the host/port when using the reactor 
> connection is mandatory, so that deserves a simple API.  Handling failover is 
> likely to also see a lot of usage - we should make resetting the host/port as 
> easy as possible. And the C api for attachments is a bit verbose.
> 
> Lastly - I'm going to add back that connection constructor that takes the 
> host and port, and make the changes to the Send constructor you suggest.

I possibly wasnt clear about the attachments thing, I agree the methods are 
nicer and should be added (its just a shame they have to be on the reactor, but 
thats preferable to expanding the 'non-reactor' Connection API with more 
reactor-specific stuff). I simply originally didnt think we would need [public] 
methods if using the attachments, since I was only expecting the reactor 
internals to actually modify the details (alebit anything else could too if 
knowing the key). Given the additional context, it makes sense other things 
could want to update them too and so the methods make even more sense.

My main point in that paragraph was that I thought we should also keep the 
initial connection creation method as it seems more intuitive for the initial 
operation, and we can then deprecate the old method to better let folks know 
things have actually changed in some way. Seems like you agree :)


- Robbie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45389/#review126810
---


On April 3, 2016, 11:34 p.m., Kenneth Giusti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45389/
> ---
> 
> (Updated April 3, 2016, 11:34 p.m.)
> 
> 
> Review request for qpid, Gordon Sim, Justin Ross, and Robbie Gemmell.
> 
> 
> Bugs: PROTON-1133
> 

Python messaging test suite (qpid.tests.messaging) - running against the swigged CPP client

[Keith W]

Hi all,

It is possible to run the Python messaging test suite
(qpid.tests.messaging) against the swigged CPP client?

I have looked at the code, and I think the answer is currently no.  I
see one test script (qpid/tests/messaging/message.py) that can use
either the pure python implementation or swigged client
(qpid_messaging) if QPID_USE_SWIG_CLIENT is set, but the remainder
seem to have a direct dependency on qpid.messaging.* (i.e. the pure
python impl).

I ask because I hope to interoperability test the Java Broker's AMQP
1.0 support with the Cpp client + Proton and the messaging tests
seemed at first glance to be an attractive option.

Does the Python messaging test suite have this ability? If not, is
there an alternative test suite?

btw. I am already building proton, cpp and am able to run the
qpid_tests.broker_1_0.* tests against the Java Broker's AMQP 1.0
implementation.

cheers Keith

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7184) Protocol layers should retain an association between a delivered message and the consumer to which it is delivered.

[Keith Wall (JIRA)]

Keith Wall created QPID-7184:


 Summary: Protocol layers should retain an association between a 
delivered message and the consumer to which it is delivered.
 Key: QPID-7184
 URL: https://issues.apache.org/jira/browse/QPID-7184
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Keith Wall


The protocol layers should be refactored to retain an association between a 
delivered message and the consumer to which it is sent.  On receipt on an ack 
or reject, the protocol layer should ensure that the message (queue entry) is 
still associated with that consumer, before acting upon it.

This change would be a prerequisite for QPID-7183. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7183) Use timed acquisitions to improve message flow amongst competing consumers

[Keith Wall (JIRA)]

Keith Wall created QPID-7183:


 Summary: Use timed acquisitions to improve message flow amongst 
competing consumers
 Key: QPID-7183
 URL: https://issues.apache.org/jira/browse/QPID-7183
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Keith Wall



At the moment when a message is sent to a consumer, the consumer 'acquires' the 
message.  That acquisition persists until the consumer acknowledges or rejects 
the message.  If the consumer is slow or stuck, that message could go 
unprocessed even though there may be other consumers who could accept the 
message sitting idle.  Prefetching compounds the problem as those messages are 
acquired too.

Some Brokers have a timed acquisition feature, where by the consumer gets the 
message for a certain length of time.  After that time expires, the Broker may 
break the acquisition and send the message to another competing consumer.

This feature would improve the robustness of the messaging infrastructure and 
make the need the manual intervention less likely.

 







--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7154) Dead lettering of a message may timeout at store level, causing unexpected Broker shutdown

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225927#comment-15225927
 ] 

ASF subversion and git services commented on QPID-7154:
---

Commit 1737804 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1737804 ]

QPID-7154: [Java Broker] Ensure that dead letter paths always lock the queue 
entry acquisition

Also ensure that consumer path queue entry releases release only consumer 
acquisitions

> Dead lettering of a message may timeout at store level, causing unexpected 
> Broker shutdown
> --
>
> Key: QPID-7154
> URL: https://issues.apache.org/jira/browse/QPID-7154
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0.1
>Reporter: Keith Wall
> Fix For: qpid-java-6.0.2
>
>
> The following was reported by a user using a 0.32 derivative.
> The background was an operator was attempting to clear queue with very large 
> depth using JMX management {{QueueMBean#clearQueue}} as the same time as a 
> messaging client (consumer - connected to the same queue) was rejecting 
> messages which were being routed to another queue and then dequeued.
> The message client (consumer) store level transaction timed out. This caused 
> the Broker to fail (uncaught exception).
> {code}
> com.sleepycat.je.LockTimeoutException: (JE 5.0.104) Lock expired. Locker 
> 792611890 1557851806_IoReceiver - /xxx.xx.xx.xx:32962_Txn: waited for lock on 
> database=QUEUE_ENTRIES LockAddr:1959781711 LSN=0x74a70/0x94db8e type=WRITE 
> grant=WAIT_NEW timeoutMillis=500 startTime=1458223769602 endTime=1458223770102
> Owners: []
> Waiters: []
>  
> at 
> com.sleepycat.je.txn.LockManager.newLockTimeoutException(LockManager.java:665)
> at 
> com.sleepycat.je.txn.LockManager.makeTimeoutMsgInternal(LockManager.java:623)
> at 
> com.sleepycat.je.txn.SyncedLockManager.makeTimeoutMsg(SyncedLockManager.java:97)
> at 
> com.sleepycat.je.txn.LockManager.lockInternal(LockManager.java:390)
> at com.sleepycat.je.txn.LockManager.lock(LockManager.java:276)
> at com.sleepycat.je.txn.Txn.lockInternal(Txn.java:522)
> at com.sleepycat.je.txn.Locker.lock(Locker.java:443)
> at 
> com.sleepycat.je.dbi.CursorImpl.lockLN(CursorImpl.java:2642)
> at 
> com.sleepycat.je.dbi.CursorImpl.lockLN(CursorImpl.java:2443)
> at 
> com.sleepycat.je.dbi.CursorImpl.searchAndPosition(CursorImpl.java:2168)
> at com.sleepycat.je.Cursor.searchInternal(Cursor.java:2822)
> at 
> com.sleepycat.je.Cursor.searchAllowPhantoms(Cursor.java:2732)
> at com.sleepycat.je.Cursor.searchNoDups(Cursor.java:2586)
> at com.sleepycat.je.Cursor.search(Cursor.java:2553)
> at 
> com.sleepycat.je.Database.deleteInternal(Database.java:1151)
> at com.sleepycat.je.Database.delete(Database.java:1080)
> at 
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore.dequeueMessage(AbstractBDBMessageStore.java:819)
> at 
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore.access$1000(AbstractBDBMessageStore.java:71)
> at 
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore$BDBTransaction.dequeueMessage(AbstractBDBMessageStore.java:1496)
> at 
> org.apache.qpid.server.txn.LocalTransaction.dequeue(LocalTransaction.java:110)
> at 
> org.apache.qpid.server.queue.QueueEntryImpl.routeToAlternate(QueueEntryImpl.java:463)
> at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.deadLetter(AMQChannel.java:1795)
> at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveBasicReject(AMQChannel.java:2431)
> at 
> org.apache.qpid.framing.BasicRejectBody.process(BasicRejectBody.java:123)
> at 
> org.apache.qpid.codec.ServerDecoder.processMethod(ServerDecoder.java:188)
> at 
> org.apache.qpid.codec.AMQDecoder.processFrame(AMQDecoder.java:388)
> at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:113)
> at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.access$000(BrokerDecoder.java:36)
> at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:79)
> at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:75)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:415)
>