[jira] [Commented] (QPID-7546) [Java Broker] Allow the system tests to be run using the Qpid JMS client for AMQP 1.0 testing
[ https://issues.apache.org/jira/browse/QPID-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694341#comment-15694341 ] ASF subversion and git services commented on QPID-7546: --- Commit 1771237 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1771237 ] QPID-7546 : Make some more tests run under AMQP 1.0 > [Java Broker] Allow the system tests to be run using the Qpid JMS client for > AMQP 1.0 testing > - > > Key: QPID-7546 > URL: https://issues.apache.org/jira/browse/QPID-7546 > Project: Qpid > Issue Type: Test > Components: Java Tests >Reporter: Rob Godfrey > > Currently the system tests use the JMS client for AMQP 0-8/9/10 and so the > AMQP 1.0 protocol implementation does not get as thoroughly tested. > We should aim to move all the system tests such that they can be run with > either client -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7550) Metadata service does not set cache control headers
[ https://issues.apache.org/jira/browse/QPID-7550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694018#comment-15694018 ] ASF subversion and git services commented on QPID-7550: --- Commit 1771204 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1771204 ] QPID-7550: [Java Broker] [Web Management] Set cache control headers on metadata service > Metadata service does not set cache control headers > --- > > Key: QPID-7550 > URL: https://issues.apache.org/jira/browse/QPID-7550 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-6.2 > > > The metadata service does not set cache control headers, it should. > Especially in IE the WMC would frequently show me stale picklists. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7550) Metadata service does not set cache control headers
Keith Wall created QPID-7550: Summary: Metadata service does not set cache control headers Key: QPID-7550 URL: https://issues.apache.org/jira/browse/QPID-7550 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Keith Wall Priority: Minor Fix For: qpid-java-6.2 The metadata service does not set cache control headers, it should. Especially in IE the WMC would frequently show me stale picklists. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7546) [Java Broker] Allow the system tests to be run using the Qpid JMS client for AMQP 1.0 testing
[ https://issues.apache.org/jira/browse/QPID-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693979#comment-15693979 ] ASF subversion and git services commented on QPID-7546: --- Commit 1771202 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1771202 ] QPID-7546 : Make some more tests run under AMQP 1.0 > [Java Broker] Allow the system tests to be run using the Qpid JMS client for > AMQP 1.0 testing > - > > Key: QPID-7546 > URL: https://issues.apache.org/jira/browse/QPID-7546 > Project: Qpid > Issue Type: Test > Components: Java Tests >Reporter: Rob Godfrey > > Currently the system tests use the JMS client for AMQP 0-8/9/10 and so the > AMQP 1.0 protocol implementation does not get as thoroughly tested. > We should aim to move all the system tests such that they can be run with > either client -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7546) [Java Broker] Allow the system tests to be run using the Qpid JMS client for AMQP 1.0 testing
[ https://issues.apache.org/jira/browse/QPID-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693976#comment-15693976 ] ASF subversion and git services commented on QPID-7546: --- Commit 1771201 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1771201 ] QPID-7546 : Make some more tests run under AMQP 1.0 > [Java Broker] Allow the system tests to be run using the Qpid JMS client for > AMQP 1.0 testing > - > > Key: QPID-7546 > URL: https://issues.apache.org/jira/browse/QPID-7546 > Project: Qpid > Issue Type: Test > Components: Java Tests >Reporter: Rob Godfrey > > Currently the system tests use the JMS client for AMQP 0-8/9/10 and so the > AMQP 1.0 protocol implementation does not get as thoroughly tested. > We should aim to move all the system tests such that they can be run with > either client -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7546) [Java Broker] Allow the system tests to be run using the Qpid JMS client for AMQP 1.0 testing
[ https://issues.apache.org/jira/browse/QPID-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693865#comment-15693865 ] ASF subversion and git services commented on QPID-7546: --- Commit 1771195 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1771195 ] QPID-7546 : Make some more tests run under AMQP 1.0 > [Java Broker] Allow the system tests to be run using the Qpid JMS client for > AMQP 1.0 testing > - > > Key: QPID-7546 > URL: https://issues.apache.org/jira/browse/QPID-7546 > Project: Qpid > Issue Type: Test > Components: Java Tests >Reporter: Rob Godfrey > > Currently the system tests use the JMS client for AMQP 0-8/9/10 and so the > AMQP 1.0 protocol implementation does not get as thoroughly tested. > We should aim to move all the system tests such that they can be run with > either client -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7425) Management delete of a message may refund credit too early
[ https://issues.apache.org/jira/browse/QPID-7425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693736#comment-15693736 ] Keith Wall commented on QPID-7425: -- Since the elimination of queue runner, this change becomes required. We said that we need to delay the refund of credit on transactional sessions until the session commits. For non-transactional sessions the ack needs to restore the credit. The credit needs to be restored even if the message has been stolen from us and deleted. The following stack is currently possible on trunk: {noformat} 2016-11-23 10:28:50,235 ERROR [HttpManagement-http-290417] o.a.q.s.m.p.f.ExceptionHandlingFilter Unexpected exception in servlet '/api/latest/queue/test/test/LiveQueueOperationsTest-testClearQueueOperationWithActiveConsumerDlqAll/clearQueue': java.lang.IllegalStateException: Consumer credit accounting error. Restored more credit than we ever had: messageCredit=1001 messageCreditLimit=1000 at org.apache.qpid.server.protocol.v0_8.Pre0_10CreditManager.restoreCredit(Pre0_10CreditManager.java:73) ~[qpid-broker-plugins-amqp-0-8-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.restoreCredit(ConsumerTarget_0_8.java:392) ~[qpid-broker-plugins-amqp-0-8-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.removeUnacknowledgedMessage(ConsumerTarget_0_8.java:458) ~[qpid-broker-plugins-amqp-0-8-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.access$000(ConsumerTarget_0_8.java:47) ~[qpid-broker-plugins-amqp-0-8-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$1.stateChanged(ConsumerTarget_0_8.java:483) ~[qpid-broker-plugins-amqp-0-8-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$1.stateChanged(ConsumerTarget_0_8.java:477) ~[qpid-broker-plugins-amqp-0-8-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.queue.QueueEntryImpl.notifyStateChange(QueueEntryImpl.java:540) ~[qpid-broker-core-6.2.0-SNAPSHOT.jar:na] at org.apache.qpid.server.queue.QueueEntryImpl.removeAcquisitionFromConsumer(QueueEntryImpl.java:391) ~[qpid-broker-core-6.2.0-SNAPSHOT.jar:na] at org.apache.qpid.server.queue.QueueEntryImpl.acquireOrSteal(QueueEntryImpl.java:267) ~[qpid-broker-core-6.2.0-SNAPSHOT.jar:na] at org.apache.qpid.server.queue.AbstractQueue.clearQueue(AbstractQueue.java:1575) ~[qpid-broker-core-6.2.0-SNAPSHOT.jar:na] at org.apache.qpid.server.queue.StandardQueueImplWithAccessChecking.clearQueue(StandardQueueImplWithAccessChecking.java:101) ~[qpid-broker-core-6.2.0-SNAPSHOT.jar:na] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.7.0_67] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) ~[na:1.7.0_67] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.7.0_67] at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_67] at org.apache.qpid.server.model.ConfiguredObjectMethodOperation.perform(ConfiguredObjectMethodOperation.java:128) ~[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doOperation(RestServlet.java:665) ~[qpid-broker-plugins-management-http-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.performCreateOrUpdate(RestServlet.java:502) ~[qpid-broker-plugins-management-http-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doPostWithSubjectAndActor(RestServlet.java:1063) ~[qpid-broker-plugins-management-http-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet$2.run(AbstractServlet.java:121) ~[qpid-broker-plugins-management-http-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet$2.run(AbstractServlet.java:117) ~[qpid-broker-plugins-management-http-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at java.security.AccessController.doPrivileged(Native Method) ~[na:1.7.0_67] at javax.security.auth.Subject.doAs(Subject.java:415) ~[na:1.7.0_67] at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doWithSubjectAndActor(AbstractServlet.java:218) ~[qpid-broker-plugins-management-http-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT] at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doPost(AbstractServlet.java:115) ~[qpid-broker-plugins-management-http-6.2.0-SNAPSHOT.jar:6.2.0-S
[jira] [Updated] (QPID-7425) Management delete of a message may refund credit too early
[ https://issues.apache.org/jira/browse/QPID-7425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7425: - Fix Version/s: qpid-java-6.2 > Management delete of a message may refund credit too early > -- > > Key: QPID-7425 > URL: https://issues.apache.org/jira/browse/QPID-7425 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Reporter: Keith Wall > Fix For: qpid-java-6.2 > > > As an operator, I am able to delete messages via Management. Messages can be > deleted even though they have already been sent to a consumer.In this > case, the message is still delete and if the client later acks or rejects a > message, the ack/reject is ignored, as the message is already gone. > However, internally the Broker restores credit to the consumer at the point > in time the message is deleted. This may allow more messages to the flow to > the consumer, possibly exhausting the client's memory. This is most likely > to happen on queues with considerable depth. > In the case where a messages is delete that has already been sent a consumer, > restore of the credit should be delayed until the client acks/rejects the > message. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7546) [Java Broker] Allow the system tests to be run using the Qpid JMS client for AMQP 1.0 testing
[ https://issues.apache.org/jira/browse/QPID-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693682#comment-15693682 ] ASF subversion and git services commented on QPID-7546: --- Commit 1771180 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1771180 ] QPID-7546 : Make some more tests run under AMQP 1.0 > [Java Broker] Allow the system tests to be run using the Qpid JMS client for > AMQP 1.0 testing > - > > Key: QPID-7546 > URL: https://issues.apache.org/jira/browse/QPID-7546 > Project: Qpid > Issue Type: Test > Components: Java Tests >Reporter: Rob Godfrey > > Currently the system tests use the JMS client for AMQP 0-8/9/10 and so the > AMQP 1.0 protocol implementation does not get as thoroughly tested. > We should aim to move all the system tests such that they can be run with > either client -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7549) [Java Broker] Authentication using SimpleLDAP authentication provider fails with NPE when caching of authentication results is enabled(by default)
Alex Rudyy created QPID-7549: Summary: [Java Broker] Authentication using SimpleLDAP authentication provider fails with NPE when caching of authentication results is enabled(by default) Key: QPID-7549 URL: https://issues.apache.org/jira/browse/QPID-7549 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: qpid-java-6.1 Reporter: Alex Rudyy Fix For: qpid-java-6.1.1 Authentication with SimpleLDAP authentication provider fails due to the following exception: {noformat} 2016-11-24 12:59:12,878 WARN [HttpManagement-testHTTP-158] (o.e.j.s.ServletHandler) - /service/sasl java.lang.NullPointerException: null at org.apache.qpid.server.security.auth.manager.AuthenticationResultCacher.digestCredentials(AuthenticationResultCacher.java:116) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.security.auth.manager.AuthenticationResultCacher.getOrLoad(AuthenticationResultCacher.java:80) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.security.auth.manager.SimpleLDAPAuthenticationManagerImpl.getOrLoadAuthenticationResult(SimpleLDAPAuthenticationManagerImpl.java:410) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.security.auth.manager.SimpleLDAPAuthenticationManagerImpl.access$200(SimpleLDAPAuthenticationManagerImpl.java:83) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.security.auth.manager.SimpleLDAPAuthenticationManagerImpl$SimpleLDAPPlainCallbackHandler.handle(SimpleLDAPAuthenticationManagerImpl.java:669) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.security.auth.sasl.plain.PlainSaslServer.evaluateResponse(PlainSaslServer.java:87) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.security.auth.manager.SimpleLDAPAuthenticationManagerImpl.authenticate(SimpleLDAPAuthenticationManagerImpl.java:312) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.security.SubjectCreator.authenticate(SubjectCreator.java:115) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.management.plugin.servlet.rest.SaslServlet.evaluateSaslResponse(SaslServlet.java:213) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at org.apache.qpid.server.management.plugin.servlet.rest.SaslServlet.doPostWithSubjectAndActor(SaslServlet.java:135) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet$2.run(AbstractServlet.java:121) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet$2.run(AbstractServlet.java:117) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at java.security.AccessController.doPrivileged(Native Method) ~[na:1.8.0_74] at javax.security.auth.Subject.doAs(Subject.java:422) ~[na:1.8.0_74] at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doWithSubjectAndActor(AbstractServlet.java:218) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doPost(AbstractServlet.java:115) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at javax.servlet.http.HttpServlet.service(HttpServlet.java:595) ~[geronimo-servlet_3.0_spec-1.0.jar:1.0] at javax.servlet.http.HttpServlet.service(HttpServlet.java:668) ~[geronimo-servlet_3.0_spec-1.0.jar:1.0] at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684) ~[jetty-servlet-8.1.17.v20150415.jar:8.1.17.v20150415] at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496) ~[jetty-servlet-8.1.17.v20150415.jar:8.1.17.v20150415] at org.apache.qpid.server.management.plugin.filter.ForbiddingAuthorisationFilter.doFilter(ForbiddingAuthorisationFilter.java:94) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467) ~[jetty-servlet-8.1.17.v20150415.jar:8.1.17.v20150415] at org.apache.qpid.server.management.plugin.filter.ForbiddingTraceFilter.doFilter(ForbiddingTraceFilter.java:65) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467) ~[jetty-servlet-8.1.17.v20150415.jar:8.1.17.v20150415] at org.apache.qpid.server.management.plugin.filter.LoggingFilter.doFilter(LoggingFilter.java:65) ~[qpid-broker-plugins-management-http-6.1.0.jar:6.1.0] at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467) ~[jetty-servlet-8.1.17.v20150415.jar:8.1.17.v20150415] at org.eclipse.jetty.servlets.CrossOriginF
[jira] [Assigned] (PROTON-1359) heap-buffer-overflow in pn_decoder_readf32 when invoking pn_message_decode
[ https://issues.apache.org/jira/browse/PROTON-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1359: --- Assignee: Alan Conway > heap-buffer-overflow in pn_decoder_readf32 when invoking pn_message_decode > -- > > Key: PROTON-1359 > URL: https://issues.apache.org/jira/browse/PROTON-1359 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.16.0 >Reporter: Jiri Danek >Assignee: Alan Conway > Attachments: core.322, > crafted_from_minimized-from-ac1dd1edf2357b0e4782088fa2bf80fdde832a43, > minimized-from-ac1dd1edf2357b0e4782088fa2bf80fdde832a43 > > > {noformat} > $ nc -l 5672 < > crafted_from_minimized-from-ac1dd1edf2357b0e4782088fa2bf80fdde832a43 > $ ./libuv_receive -a 127.0.0.1:5672/jms.queue.example > Segmentation fault (core dumped) > (gdb) thread apply all bt > > #5209 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5210 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972817 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5211 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5212 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972897 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5213 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5214 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972917 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5215 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5216 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972997 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5217 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5218 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972a17 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5219 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5220 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972a97 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5221 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5222 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972b17 "\377\200\304\t\002") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5223 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5224 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972b97 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5225 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5226 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972c17 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5227 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5228 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972c97 "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5229 0x7f36d947a651 in pni_decoder_single (decoder=0x209c970, > data=0x209c480) at > /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:474 > #5230 0x7f36d947a786 in pni_decoder_decode_type (decoder=0x209c970, > data=0x209c480, code=0x7ffd99972e0d "") > at /home/jdanek/Bin/qpid-proton/proton-c/src/core/decoder.c:458 > #5231 0x7f36d947b2ac in pni_decoder_decode_value (decoder=0x209c970, > data=0x209c480, code=240 '\360') at >
[jira] [Assigned] (PROTON-1360) pn_strndup (util.c:150) Invalid write of size 1
[ https://issues.apache.org/jira/browse/PROTON-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1360: --- Assignee: Alan Conway > pn_strndup (util.c:150) Invalid write of size 1 > --- > > Key: PROTON-1360 > URL: https://issues.apache.org/jira/browse/PROTON-1360 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.15.0, 0.16.0 >Reporter: Jiri Danek >Assignee: Alan Conway > Attachments: crash-cacbe90ba41be2fb116697da7a90bfd716812c7b, > minimized-from-9a77cc2e90542c5aa1e55a86d2c9920febb0ad68 > > > {noformat} > nc -l 127.0.0.1 5672 < ./crash-cacbe90ba41be2fb116697da7a90bfd716812c7b > {noformat} > On 0.15.0, do > {noformat} > [qpid-proton-0.15.0/build/examples/c/messenger] $ valgrind ./recv > 127.0.0.1/jms.queue.example > ==5749== Memcheck, a memory error detector > ==5749== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al. > ==5749== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info > ==5749== Command: ./recv 127.0.0.1/jms.queue.example > ==5749== > ==5749== Invalid write of size 1 > ==5749==at 0x4C2D13C: __strncpy_sse2_unaligned (vg_replace_strmem.c:548) > ==5749==by 0x4E4AD80: pn_strndup (util.c:259) > ==5749==by 0x4E5A7BE: pn_bytes_strdup (transport.c:1153) > ==5749==by 0x4E5A7BE: pn_do_open (transport.c:1198) > ==5749==by 0x4E52B6A: pni_dispatch_action (dispatcher.c:74) > ==5749==by 0x4E52B6A: pni_dispatch_frame (dispatcher.c:116) > ==5749==by 0x4E52B6A: pn_dispatcher_input (dispatcher.c:135) > ==5749==by 0x4E5906B: pn_input_read_amqp (transport.c:2523) > ==5749==by 0x4E59129: transport_consume (transport.c:1799) > ==5749==by 0x4E5C971: pn_transport_process (transport.c:2908) > ==5749==by 0x4E646F3: pni_connection_readable (messenger.c:262) > ==5749==by 0x4E6482F: pn_messenger_process (messenger.c:1367) > ==5749==by 0x4E649E0: pn_messenger_tsync (messenger.c:1439) > ==5749==by 0x4E64F94: pn_messenger_recv (messenger.c:2212) > ==5749==by 0x4012A4: main (recv.c:131) > ==5749== Address 0x772d641 is 0 bytes after a block of size 1 alloc'd > ==5749==at 0x4C29BE3: malloc (vg_replace_malloc.c:299) > ==5749==by 0x4E4AD6A: pn_strndup (util.c:257) > ==5749==by 0x4E5A7BE: pn_bytes_strdup (transport.c:1153) > ==5749==by 0x4E5A7BE: pn_do_open (transport.c:1198) > ==5749==by 0x4E52B6A: pni_dispatch_action (dispatcher.c:74) > ==5749==by 0x4E52B6A: pni_dispatch_frame (dispatcher.c:116) > ==5749==by 0x4E52B6A: pn_dispatcher_input (dispatcher.c:135) > ==5749==by 0x4E5906B: pn_input_read_amqp (transport.c:2523) > ==5749==by 0x4E59129: transport_consume (transport.c:1799) > ==5749==by 0x4E5C971: pn_transport_process (transport.c:2908) > ==5749==by 0x4E646F3: pni_connection_readable (messenger.c:262) > ==5749==by 0x4E6482F: pn_messenger_process (messenger.c:1367) > ==5749==by 0x4E649E0: pn_messenger_tsync (messenger.c:1439) > ==5749==by 0x4E64F94: pn_messenger_recv (messenger.c:2212) > ==5749==by 0x4012A4: main (recv.c:131) > ==5749== > Address: jms.queue.example > Subject: (no subject) > Content: "test message: 26" > {noformat} > On 0.16.0 you can do > {noformat} > [proactor]$ valgrind ./libuv_receive -a 127.0.0.1:5672/jms.queue.example -m 2 > ==26215== Memcheck, a memory error detector > ==26215== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al. > ==26215== Using Valgrind-3.12.0 and LibVEX; rerun with -h for copyright info > ==26215== Command: ./libuv_receive -a 127.0.0.1:5672/jms.queue.example -m 2 > ==26215== > ==26215== Invalid write of size 1 > ==26215==at 0x4C2E284: __strncpy_sse2_unaligned (in > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) > ==26215==by 0x4E4CF71: pn_strndup (util.c:150) > ==26215==by 0x4E5B0EE: pn_bytes_strdup (transport.c:1154) > ==26215==by 0x4E5B0EE: pn_do_open (transport.c:1199) > ==26215==by 0x4E53270: pni_dispatch_action (dispatcher.c:74) > ==26215==by 0x4E53270: pni_dispatch_frame (dispatcher.c:116) > ==26215==by 0x4E53270: pn_dispatcher_input (dispatcher.c:135) > ==26215==by 0x4E599BB: pn_input_read_amqp (transport.c:2524) > ==26215==by 0x4E59A89: transport_consume (transport.c:1800) > ==26215==by 0x4E5D115: pn_transport_process (transport.c:2909) > ==26215==by 0x404EBB: on_read (libuv_proactor.c:511) > ==26215==by 0x509A2FC: ??? (in /usr/lib/libuv.so.1.0.0) > ==26215==by 0x509AC0B: ??? (in /usr/lib/libuv.so.1.0.0) > ==26215==by 0x509F937: uv__io_poll (in /usr/lib/libuv.so.1.0.0) > ==26215==by 0x50912B3: uv_run (in /usr/lib/libuv.so.1.0.0) > ==26215== Address 0x69c28d1 is 0 bytes after a block of size 1 alloc'd > ==26215==at 0x4C2AB8D: malloc (in > /usr/lib/valgrind/vgpreload_memch
[jira] [Commented] (QPID-7514) [Java Broker] Do all message delivery processing on the IO threads and remove the QueueRunner
[ https://issues.apache.org/jira/browse/QPID-7514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693476#comment-15693476 ] ASF subversion and git services commented on QPID-7514: --- Commit 1771161 from [~lorenz.quack] in branch 'java/trunk' [ https://svn.apache.org/r1771161 ] QPID-7514: [Java Broker] Fix resource leak when deleting Queues > [Java Broker] Do all message delivery processing on the IO threads and remove > the QueueRunner > - > > Key: QPID-7514 > URL: https://issues.apache.org/jira/browse/QPID-7514 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey > Fix For: qpid-java-6.2 > > Attachments: > 0001-QPID-7514-Java-Broker-remove-affirmation-logic-from-.patch > > > Currently message delivery processing is split between the assignment of the > message to a subscription (which happens on the incoming IO thread or in a > queue runner) and the actual delivery which happens on the IO thread of the > receiving client. > Instead we should move all processing onto the IO threads and remove the > complications inherent in having separate threads attempting delivery. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7547) [Java Broker] Refactor closing and deletion of AbstractConfiguredObjects
[ https://issues.apache.org/jira/browse/QPID-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693458#comment-15693458 ] Lorenz Quack commented on QPID-7547: A serious complication of this is that we cannot safely delete an object on the Config Thread from the IO Thread if that object also tries to do operations on the IO Thread (i.e., deadlock). This is a problem especially on the AMQP 0-10 path. > [Java Broker] Refactor closing and deletion of AbstractConfiguredObjects > > > Key: QPID-7547 > URL: https://issues.apache.org/jira/browse/QPID-7547 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Lorenz Quack > > Currently deletion and closing of objects are completely independent. > It seems reasonable that an object that is being deleted should be closed > before hand to ensure resources are being cleaned up and to reduce code > duplication. > In fact many implementations of ConfiguredObjects already do this. > This JIRA suggests to do this in a generic way in AbstractConfiguredObject. > The suggested order would be: > ACO.deleteAsync > * calls delete on all children > * closes itself > * deletes itself -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1361) [proton-j] mark Messenger as deprecated
[ https://issues.apache.org/jira/browse/PROTON-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-1361. Resolution: Fixed > [proton-j] mark Messenger as deprecated > --- > > Key: PROTON-1361 > URL: https://issues.apache.org/jira/browse/PROTON-1361 > Project: Qpid Proton > Issue Type: Task > Components: proton-j >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.16.0 > > > As discussed on the mailing lists the Messenger API will be removed in an > upcoming proton-j release. Messenger and related driver etc > interfaces/classes should be marked as deprecated for the 0.16.0 release, > ahead of their removal in a subsequent release. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1361) [proton-j] mark Messenger as deprecated
[ https://issues.apache.org/jira/browse/PROTON-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693212#comment-15693212 ] ASF subversion and git services commented on PROTON-1361: - Commit 451b3b4cf0b4834faefea8a58e6f890f65974af8 in qpid-proton's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=451b3b4 ] PROTON-1361: mark proton-j Messsenger and related driver as deprecated > [proton-j] mark Messenger as deprecated > --- > > Key: PROTON-1361 > URL: https://issues.apache.org/jira/browse/PROTON-1361 > Project: Qpid Proton > Issue Type: Task > Components: proton-j >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.16.0 > > > As discussed on the mailing lists the Messenger API will be removed in an > upcoming proton-j release. Messenger and related driver etc > interfaces/classes should be marked as deprecated for the 0.16.0 release, > ahead of their removal in a subsequent release. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1362) [proton-j] remove Messenger
Robbie Gemmell created PROTON-1362: -- Summary: [proton-j] remove Messenger Key: PROTON-1362 URL: https://issues.apache.org/jira/browse/PROTON-1362 Project: Qpid Proton Issue Type: Task Components: proton-j Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.17.0 As discussed on the mailing lists the Messenger API will be removed in upcoming proton-j releases. It was marked it as deprecated in 0.16.0 via PROTON-1361, this JIRA serves to track its subsequent removal. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1361) [proton-j] mark Messenger as deprecated
Robbie Gemmell created PROTON-1361: -- Summary: [proton-j] mark Messenger as deprecated Key: PROTON-1361 URL: https://issues.apache.org/jira/browse/PROTON-1361 Project: Qpid Proton Issue Type: Task Components: proton-j Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.16.0 As discussed on the mailing lists the Messenger API will be removed in an upcoming proton-j release. Messenger and related driver etc interfaces/classes should be marked as deprecated for the 0.16.0 release, ahead of their removal in a subsequent release. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7548) [Java Broker] Upgrade of configuration from model version 3 fails
[ https://issues.apache.org/jira/browse/QPID-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693167#comment-15693167 ] Alex Rudyy commented on QPID-7548: -- Upgrader from 3.0 to 6.0 (Upgrader_3_0_to_6_0) does not call next upgrader in chain ( for objects not needing upgrade). As result, Upgrader to v6.1 is not called and JMX ports are not removed. The fix is below {code} Index: broker-core/src/main/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecoverer.java === --- broker-core/src/main/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecoverer.java (revision 1770935) +++ broker-core/src/main/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecoverer.java (working copy) @@ -381,6 +381,10 @@ getNextUpgrader().configuredObject(record); } } +else +{ +getNextUpgrader().configuredObject(record); +} } private void addLogger(final ConfiguredObjectRecord record, String name, String type) {code} > [Java Broker] Upgrade of configuration from model version 3 fails > - > > Key: QPID-7548 > URL: https://issues.apache.org/jira/browse/QPID-7548 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.1 >Reporter: Alex Rudyy > Fix For: qpid-java-6.1.1 > > > Broker fails to upgrade configuration v3 as it cannot delete RMI and JMX > ports. The following exception is reported on startup > {noformat} > 12:08:29.756 [main] INFO o.a.q.s.store.GenericStoreUpgrader - Broker store > has model version 3.0. Number of record(s) 31 > 12:08:29.821 [main] ERROR org.apache.qpid.server.Broker - Exception during > startup > java.lang.IllegalArgumentException: Cannot convert '[RMI]' into a > java.util.Set for attribute protocols > (No enum constant org.apache.qpid.se > ver.model.Protocol.RMI) > at > org.apache.qpid.server.model.ConfiguredAutomatedAttribute.convert(ConfiguredAutomatedAttribute.java:252) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.model.port.PortFactory.getProtocolType(PortFactory.java:69) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.model.port.PortFactory.getPortFactory(PortFactory.java:142) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.model.port.PortFactory.recover(PortFactory.java:127) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.recover(ConfiguredObjectFactoryImpl.java:104) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.store.GenericRecoverer.resolveObjects(GenericRecoverer.java:183) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.store.GenericRecoverer.performRecover(GenericRecoverer.java:91) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.store.GenericRecoverer.access$000(GenericRecoverer.java:41) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:59) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:55) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:240) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:157) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl.run(TaskExecutorImpl.java:182) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.store.GenericRecoverer.recover(GenericRecoverer.java:54) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.store.BrokerStoreUpgraderAndRecoverer.upgradeAndRecover(BrokerStoreUpgraderAndRecoverer.java:919) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.store.BrokerStoreUpgraderAndRecoverer.upgradeAndRecover(BrokerStoreUpgraderAndRecoverer.java:48) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.model.AbstractSystemConfig.initateStoreAndRecovery(AbstractSystemConfig.java:304) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at > org.apache.qpid.server.model.AbstractSystemConfig.activate(AbstractSystemConfig.java:233) > ~[qpid-broker-core-6.1.0.jar:6.1.0] > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > ~[na:1.8.0_74] > at > sun.refl
[jira] [Created] (QPID-7548) [Java Broker] Upgrade of configuration from model version 3 fails
Alex Rudyy created QPID-7548: Summary: [Java Broker] Upgrade of configuration from model version 3 fails Key: QPID-7548 URL: https://issues.apache.org/jira/browse/QPID-7548 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: qpid-java-6.1 Reporter: Alex Rudyy Fix For: qpid-java-6.1.1 Broker fails to upgrade configuration v3 as it cannot delete RMI and JMX ports. The following exception is reported on startup {noformat} 12:08:29.756 [main] INFO o.a.q.s.store.GenericStoreUpgrader - Broker store has model version 3.0. Number of record(s) 31 12:08:29.821 [main] ERROR org.apache.qpid.server.Broker - Exception during startup java.lang.IllegalArgumentException: Cannot convert '[RMI]' into a java.util.Set for attribute protocols (No enum constant org.apache.qpid.se ver.model.Protocol.RMI) at org.apache.qpid.server.model.ConfiguredAutomatedAttribute.convert(ConfiguredAutomatedAttribute.java:252) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.port.PortFactory.getProtocolType(PortFactory.java:69) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.port.PortFactory.getPortFactory(PortFactory.java:142) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.port.PortFactory.recover(PortFactory.java:127) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.recover(ConfiguredObjectFactoryImpl.java:104) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.store.GenericRecoverer.resolveObjects(GenericRecoverer.java:183) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.store.GenericRecoverer.performRecover(GenericRecoverer.java:91) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.store.GenericRecoverer.access$000(GenericRecoverer.java:41) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:59) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:55) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:240) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:157) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.configuration.updater.TaskExecutorImpl.run(TaskExecutorImpl.java:182) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.store.GenericRecoverer.recover(GenericRecoverer.java:54) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.store.BrokerStoreUpgraderAndRecoverer.upgradeAndRecover(BrokerStoreUpgraderAndRecoverer.java:919) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.store.BrokerStoreUpgraderAndRecoverer.upgradeAndRecover(BrokerStoreUpgraderAndRecoverer.java:48) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.AbstractSystemConfig.initateStoreAndRecovery(AbstractSystemConfig.java:304) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.AbstractSystemConfig.activate(AbstractSystemConfig.java:233) ~[qpid-broker-core-6.1.0.jar:6.1.0] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_74] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_74] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_74] at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_74] at org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1482) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1461) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1035) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1029) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2609) ~[qpid-broker-core-6.1.0.jar:6.1.0] at org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2605) ~[qpid-broker-core-6.1.0.jar:6.1.0] at java.security.AccessController.doPrivileged(Native Method) ~[na:1.8.0_74] at javax.security.auth.Subject.doAs(Subject.java:360) ~[na:1.8.0_74]
[jira] [Commented] (PROTON-1253) PHP client using C API send no empty frames - ActiveMQ broker drops the connection due to Inactivity after 60 seconds
[ https://issues.apache.org/jira/browse/PROTON-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693042#comment-15693042 ] Dirk Craeynest commented on PROTON-1253: We're using the C API (in an Ada application), and would like to enable heartbeats as well, so are trying this patch. With it we succeeded in getting heartbeats between a broker and a test program that plays the role of a "receiver" (i.e. doing pn_messenger_recv in a loop to "consume" messages sent to the broker). Setting the environment variable PN_TRACE_FRM=true we see empty frames being exchanged in both directions. So far, so good. However, our application performs the "sender" role, i.e. it does a pn_messenger_send in a loop to send messages to the broker. And here we don't succeed in getting heartbeats sent. In a test setup, we have a broker running with the idle_timeout set to 2 seconds. We set the same value in our application as well, so expect empty frames to be exchanged every second when there's no other "traffic". However, this doesn't happen. Our test application code does the following calls (very simplified): pn_messenger to construct a Messenger pn_messenger_set_timeout to a value of 2 seconds pn_messenger_set_outgoing_window to a value of 20 pn_messenger_set_idle_timeout to a value of 2 seconds (= operation provided by patch) pn_messenger_start in a loop: if there's anything to send: multiple calls to pn_messenger_put to put all messages in Messenger pn_messenger_send with parameter n set to -1, i.e. block until all msgs sent or messenger timeout reached otherwise: delay for 5 seconds while accepting requests to stop if no request to stop continue loop after the loop: pn_messenger_stop We suspect the cause of the problem is that in between calls to pn_messenger_send, when there's nothing to send and no request to stop, our application is blocked in successive delays of 5 seconds. Presumably we need to make some Proton calls "in between" to allow the heartbeat frames to be sent? However, our searches through the QPID Proton tickets/forum/docs have not yet resulted in finding a solution. Things we've tried are (among others): - calling pn_messenger_process in between each of the 5 seconds delays (which doesn't work as that's longer than the idle_timeout); - calling pn_messenger_work with a timeout of 5 seconds *instead* of the explicit 5 second delay (which didn't trigger heartbeats either). We don't really understand how the Proton layer can send out these heartbeats "under the hood" unless when the application is blocked in a Proton operation (such as recv, see above) or by using a separate thread that manages all sending of messages. We suspect we're overlooking something trivial, and appreciate any help or hints... > PHP client using C API send no empty frames - ActiveMQ broker drops the > connection due to Inactivity after 60 seconds > - > > Key: PROTON-1253 > URL: https://issues.apache.org/jira/browse/PROTON-1253 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.12.0, 0.13.0 > Environment: Linux yuriy-Aspire-E5-573G 4.2.0-18-generic #22-Ubuntu > SMP Fri Nov 6 18:25:50 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Yuriy Yakubskiy > Labels: messenger, patch, php-proton > Attachments: > qpid-proton-0.13.0_messenger_set_idle_timeout_patch.tar.gz > > > Dear developers, > Could you please, clarify the following issue. > PHP client disconnected after no data message in the queue for 60 seconds. > Have client frame trace enabled (PN_TRACE_FRM=true) > No active frame sent by the client in order to prevent being disconnected by > ActiveMQ InactivityMonitor > Please advice, is there any way of setting heartbeats for the PHP client. > Please find, frames trace below. > Kind Regards, > Yuriy > 2016-07-11 14:05:46 > [0x2af58f0]: -> AMQP > [0x2af58f0]:0 -> @open(16) > [container-id="68426F2E-012E-4A64-BE2E-1E5355B4B022", hostname="0.0.0.0", > channel-max=32767] > [0x2af58f0]:0 -> @begin(17) [next-outgoing-id=0, incoming-window=2147483647, > outgoing-window=2147483647] > [0x2af58f0]:0 -> @attach(18) [name="first-test-queue", handle=0, role=true, > snd-settle-mode=0, rcv-settle-mode=0, source=@source(40) > [address="first-test-queue", durable=0, timeout=0, dynamic=false], > target=@target(41) [address="first-test-queue", durable=0, timeout=0, > dynamic=false], initial-delivery-count=0] > [0x2af58f0]:0 -> @flow(19) [incoming-window=2147483647, next-outgoing-id=0, > outgoing-window=2147483647, handle=0, delivery-count=0, link-credit=1024, > drain=false] > [0x2af58f0]: <- AMQP > [0x2
[jira] [Commented] (QPID-7545) [Java Broker] Make 0-10 CreditManagers work with Python client
[ https://issues.apache.org/jira/browse/QPID-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692982#comment-15692982 ] Lorenz Quack commented on QPID-7545: Sorry for the mix-up. My apologies. > [Java Broker] Make 0-10 CreditManagers work with Python client > -- > > Key: QPID-7545 > URL: https://issues.apache.org/jira/browse/QPID-7545 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.2 >Reporter: Lorenz Quack > Fix For: qpid-java-6.2 > > > The AMQP 0-10 specification states (Command: message.set-flow-mode; Rule: > mode-switching) > {quote}Mode switching may only occur if both the byte and message credit > balance are zero.{quote} > Commit r1769109 brought the Java Broker into compliance with the spec. > > However, it seems that the Python client (or the underlying C++ > implementation) tries to switch mode when *either* byte or message credit is > zero (i.e., the client does not have credit). > To not break compatibility, we should adopt that behaviour. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7547) [Java Broker] Refactor closing and deletion of AbstractConfiguredObjects
Lorenz Quack created QPID-7547: -- Summary: [Java Broker] Refactor closing and deletion of AbstractConfiguredObjects Key: QPID-7547 URL: https://issues.apache.org/jira/browse/QPID-7547 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Lorenz Quack Currently deletion and closing of objects are completely independent. It seems reasonable that an object that is being deleted should be closed before hand to ensure resources are being cleaned up and to reduce code duplication. In fact many implementations of ConfiguredObjects already do this. This JIRA suggests to do this in a generic way in AbstractConfiguredObject. The suggested order would be: ACO.deleteAsync * calls delete on all children * closes itself * deletes itself -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-7538) [Java Client] Improve handling of hanshake status codes in SSLSender
[ https://issues.apache.org/jira/browse/QPID-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-7538. -- Resolution: Fixed Seems reasonable to me. > [Java Client] Improve handling of hanshake status codes in SSLSender > > > Key: QPID-7538 > URL: https://issues.apache.org/jira/browse/QPID-7538 > Project: Qpid > Issue Type: Improvement > Components: Java Client >Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, > qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1 >Reporter: Alex Rudyy >Priority: Trivial > Fix For: qpid-java-6.2 > > > In SSLSender#doSend switch (handshakeStatus) should not fall through > NEED_WRAP and FINISHED cases -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7537) Improve implementations of equal methods in various classes to be able to account for sub-classes
[ https://issues.apache.org/jira/browse/QPID-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692938#comment-15692938 ] Keith Wall commented on QPID-7537: -- As discussed, I suggest we revert the AMQDestination change. For me, the risk of the change is higher the potential benefit. The code that creates destinations for consumed messages is especially fragile and I worry this change might expose other defects. At this stage in the client's life, I don't consider this to be worthy of attention. > Improve implementations of equal methods in various classes to be able to > account for sub-classes > - > > Key: QPID-7537 > URL: https://issues.apache.org/jira/browse/QPID-7537 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Client, Java Common, Java Performance > Tests >Reporter: Alex Rudyy >Assignee: Keith Wall > Fix For: qpid-java-6.2 > > > The equals method of the following classes break symmetry if the passed in > object is a subclass. Use this.getClass() instead of instanceof. > * BindingImpl > * QpidSslRMIServerSocketFactory > * HeadersBinding > * AMQPProtocolVersionWrapper > * UsernamePrincipal > * GroupPrincipal > * Action > * Rule > * InetNetwork > * AMQBrokerDetails > * AMQDestination > * AMQQueue > * AMQTopic > * XidImpl > * FieldTable > * ProtocolInitiation > * QpidRAConnectionRequestInfo > * QpidRAManagedConnectionFactory > * QpidRAMessage > * QpidResourceAdapter > * ListPropertyValue > * NumericGeneratedPropertySupport > * RangePropertyValue -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7546) [Java Broker] Allow the system tests to be run using the Qpid JMS client for AMQP 1.0 testing
[ https://issues.apache.org/jira/browse/QPID-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692717#comment-15692717 ] ASF subversion and git services commented on QPID-7546: --- Commit 1771095 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1771095 ] QPID-7546 : Add a java-mms.1-0 profile > [Java Broker] Allow the system tests to be run using the Qpid JMS client for > AMQP 1.0 testing > - > > Key: QPID-7546 > URL: https://issues.apache.org/jira/browse/QPID-7546 > Project: Qpid > Issue Type: Test > Components: Java Tests >Reporter: Rob Godfrey > > Currently the system tests use the JMS client for AMQP 0-8/9/10 and so the > AMQP 1.0 protocol implementation does not get as thoroughly tested. > We should aim to move all the system tests such that they can be run with > either client -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org