[jira] [Commented] (QPID-7546) [Java Broker] Allow the system tests to be run using the Qpid JMS client for AMQP 1.0 testing
[ https://issues.apache.org/jira/browse/QPID-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823544#comment-15823544 ] ASF subversion and git services commented on QPID-7546: --- Commit 1778970 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1778970 ] QPID-7546: Enable PublishMessageRestTest#testPublishMessageWithPropertiesAndHeaders for AMQP 1.0 > [Java Broker] Allow the system tests to be run using the Qpid JMS client for > AMQP 1.0 testing > - > > Key: QPID-7546 > URL: https://issues.apache.org/jira/browse/QPID-7546 > Project: Qpid > Issue Type: Test > Components: Java Tests >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Attachments: > 0001-QPID-7546-Allow-overriding-of-jms-spec-artifact-in-o.patch > > > Currently the system tests use the JMS client for AMQP 0-8/9/10 and so the > AMQP 1.0 protocol implementation does not get as thoroughly tested. > We should aim to move all the system tests such that they can be run with > either client -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7623) "SEVERE: RuntimeException while executing runnable" reported by Guava to stderr if a state transition method throws exception
[
https://issues.apache.org/jira/browse/QPID-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-7623:
-
Description:
As reported in QPID-7311, a state change that throws an exception, may cause a
warning like the following to be reported to stderr:
{noformat}
SEVERE: RuntimeException while executing runnable
com.google.common.util.concurrent.Futures$6@5b83d60e with executor
org.apache.qpid.server.configuration.updater.TaskExecutorImpl@2
c5a6012
org.apache.qpid.server.configuration.IllegalConfigurationException: Unable to
get certificate for 'test' from 'https://google.com'
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:339)
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:302)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.ConnectException: Connection timed out: connect
at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
at
java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:85)
at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:579)
at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:625)
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:316)
... 5 more
{noformat}
The problem is a general one rather than being specific to SSTS.
The create exception handler involved code at lines
AbstractConfiguredObject.java:1083 unconditionally re-raises the exception.
The exception then goes uncaught and is logged by Guava at line
ExecutionList.java:160. Guava's behaviour here is documented in
ListenableFuture.java:103.
Whilst ugly, this actually causes no functional harm. The child creation
error is still reported to the end user, and the child is still deregistered
from the parent. However, the appearance of the stack on stderr will cause
alarm to end-users.
The cause of the problem is AbstractConfiguredObject.java:1083. The
{{FutureCallback#onFailure}} impl should not be rethrowing the exception.
Setting returnValue's exception is sufficient.
was:
As reported in QPID-7311, a state change that throws an exception, may cause a
warning like the following to be reported to stderr:
{noformat}
SEVERE: RuntimeException while executing runnable
com.google.common.util.concurrent.Futures$6@5b83d60e with executor
org.apache.qpid.server.configuration.updater.TaskExecutorImpl@2
c5a6012
org.apache.qpid.server.configuration.IllegalConfigurationException: Unable to
get certificate for 'test' from 'https://google.com'
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:339)
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:302)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.ConnectException: Connection timed out: connect
at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
at
java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:85)
at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:579)
at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:625)
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:316)
... 5 more
{noformat}
The problem is a general one rather than being specific to SSTS.
The create exception handler involved code at lines
AbstractConfiguredObject
[jira] [Updated] (QPID-7623) "SEVERE: RuntimeException while executing runnable" reported by Guava to stderr if a state transition method throws exception
[
https://issues.apache.org/jira/browse/QPID-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-7623:
-
Status: Reviewable (was: In Progress)
> "SEVERE: RuntimeException while executing runnable" reported by Guava to
> stderr if a state transition method throws exception
> -
>
> Key: QPID-7623
> URL: https://issues.apache.org/jira/browse/QPID-7623
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-7.0
>
>
> As reported in QPID-7311, a state change that throws an exception, may cause
> a warning like the following to be reported to stderr:
> {noformat}
> SEVERE: RuntimeException while executing runnable
> com.google.common.util.concurrent.Futures$6@5b83d60e with executor
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl@2
> c5a6012
> org.apache.qpid.server.configuration.IllegalConfigurationException: Unable to
> get certificate for 'test' from 'https://google.com'
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:339)
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:302)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.net.ConnectException: Connection timed out: connect
> at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
> at
> java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:85)
> at
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
> at
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
> at
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
> at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:579)
> at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:625)
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:316)
> ... 5 more
> {noformat}
> The problem is a general one rather than being specific to SSTS.
> The create exception handler involved code at lines
> AbstractConfiguredObject.java:1083 unconditional re-raises the exception.
> The exception then goes uncaught and is logged by Guava at line
> ExecutionList.java:160. Guava's behaviour here is documented in
> ListenableFuture.java:103.
> Whilst ugly, this actually causes no functional harm. The child creation
> error is still reported to the end user, and the child is still deregistered
> from the parent. However, the appearance of the stack on stderr will cause
> alarm to end-users.
> The cause of the problem is AbstractConfiguredObject.java:1083. The
> {{FutureCallback#onFailure}} impl should not be rethrowing the exception.
> Setting returnValue's exception is sufficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7623) "SEVERE: RuntimeException while executing runnable" reported by Guava to stderr if a state transition method throws exception
[
https://issues.apache.org/jira/browse/QPID-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823091#comment-15823091
]
ASF subversion and git services commented on QPID-7623:
---
Commit 1778898 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1778898 ]
QPID-7623: [Java Broker] Prevent "SEVERE: RuntimeException while executing
runnable" being reported by Guava if aactivation state transition throws an
exception during create child
> "SEVERE: RuntimeException while executing runnable" reported by Guava to
> stderr if a state transition method throws exception
> -
>
> Key: QPID-7623
> URL: https://issues.apache.org/jira/browse/QPID-7623
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-7.0
>
>
> As reported in QPID-7311, a state change that throws an exception, may cause
> a warning like the following to be reported to stderr:
> {noformat}
> SEVERE: RuntimeException while executing runnable
> com.google.common.util.concurrent.Futures$6@5b83d60e with executor
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl@2
> c5a6012
> org.apache.qpid.server.configuration.IllegalConfigurationException: Unable to
> get certificate for 'test' from 'https://google.com'
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:339)
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:302)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.net.ConnectException: Connection timed out: connect
> at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
> at
> java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:85)
> at
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
> at
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
> at
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
> at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:579)
> at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:625)
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:316)
> ... 5 more
> {noformat}
> The problem is a general one rather than being specific to SSTS.
> The create exception handler involved code at lines
> AbstractConfiguredObject.java:1083 unconditional re-raises the exception.
> The exception then goes uncaught and is logged by Guava at line
> ExecutionList.java:160. Guava's behaviour here is documented in
> ListenableFuture.java:103.
> Whilst ugly, this actually causes no functional harm. The child creation
> error is still reported to the end user, and the child is still deregistered
> from the parent. However, the appearance of the stack on stderr will cause
> alarm to end-users.
> The cause of the problem is AbstractConfiguredObject.java:1083. The
> {{FutureCallback#onFailure}} impl should not be rethrowing the exception.
> Setting returnValue's exception is sufficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-7623) "SEVERE: RuntimeException while executing runnable" reported by Guava to stderr if a state transition method throws exception
[
https://issues.apache.org/jira/browse/QPID-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall reassigned QPID-7623:
Assignee: Keith Wall
> "SEVERE: RuntimeException while executing runnable" reported by Guava to
> stderr if a state transition method throws exception
> -
>
> Key: QPID-7623
> URL: https://issues.apache.org/jira/browse/QPID-7623
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-7.0
>
>
> As reported in QPID-7311, a state change that throws an exception, may cause
> a warning like the following to be reported to stderr:
> {noformat}
> SEVERE: RuntimeException while executing runnable
> com.google.common.util.concurrent.Futures$6@5b83d60e with executor
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl@2
> c5a6012
> org.apache.qpid.server.configuration.IllegalConfigurationException: Unable to
> get certificate for 'test' from 'https://google.com'
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:339)
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:302)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.net.ConnectException: Connection timed out: connect
> at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
> at
> java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:85)
> at
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
> at
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
> at
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
> at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:579)
> at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:625)
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:316)
> ... 5 more
> {noformat}
> The problem is a general one rather than being specific to SSTS.
> The create exception handler involved code at lines
> AbstractConfiguredObject.java:1083 unconditional re-raises the exception.
> The exception then goes uncaught and is logged by Guava at line
> ExecutionList.java:160. Guava's behaviour here is documented in
> ListenableFuture.java:103.
> Whilst ugly, this actually causes no functional harm. The child creation
> error is still reported to the end user, and the child is still deregistered
> from the parent. However, the appearance of the stack on stderr will cause
> alarm to end-users.
> The cause of the problem is AbstractConfiguredObject.java:1083. The
> {{FutureCallback#onFailure}} impl should not be rethrowing the exception.
> Setting returnValue's exception is sufficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7623) "SEVERE: RuntimeException while executing runnable" reported by Guava to stderr if a state transition method throws exception
[
https://issues.apache.org/jira/browse/QPID-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-7623:
-
Assignee: Alex Rudyy (was: Keith Wall)
> "SEVERE: RuntimeException while executing runnable" reported by Guava to
> stderr if a state transition method throws exception
> -
>
> Key: QPID-7623
> URL: https://issues.apache.org/jira/browse/QPID-7623
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-7.0
>
>
> As reported in QPID-7311, a state change that throws an exception, may cause
> a warning like the following to be reported to stderr:
> {noformat}
> SEVERE: RuntimeException while executing runnable
> com.google.common.util.concurrent.Futures$6@5b83d60e with executor
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl@2
> c5a6012
> org.apache.qpid.server.configuration.IllegalConfigurationException: Unable to
> get certificate for 'test' from 'https://google.com'
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:339)
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:302)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.net.ConnectException: Connection timed out: connect
> at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
> at
> java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:85)
> at
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
> at
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
> at
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
> at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:579)
> at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:625)
> at
> org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:316)
> ... 5 more
> {noformat}
> The problem is a general one rather than being specific to SSTS.
> The create exception handler involved code at lines
> AbstractConfiguredObject.java:1083 unconditional re-raises the exception.
> The exception then goes uncaught and is logged by Guava at line
> ExecutionList.java:160. Guava's behaviour here is documented in
> ListenableFuture.java:103.
> Whilst ugly, this actually causes no functional harm. The child creation
> error is still reported to the end user, and the child is still deregistered
> from the parent. However, the appearance of the stack on stderr will cause
> alarm to end-users.
> The cause of the problem is AbstractConfiguredObject.java:1083. The
> {{FutureCallback#onFailure}} impl should not be rethrowing the exception.
> Setting returnValue's exception is sufficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7311) [Java Broker] SiteSpecificTrustStore does not provide helpful error messages when protocol is missing
[
https://issues.apache.org/jira/browse/QPID-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823081#comment-15823081
]
Keith Wall commented on QPID-7311:
--
QPID-7623 captures the general problem you noticed.
On your other comments:
* The certificate downloading in a separate thread benefits the #doActivate
when a _x509Certificate is not already stored. Previously, the configuration
thread would be blocked whilst the certificate was being download. Now other
sibling objects can acquire their desired state whilst this on downloads.
* I did consider changing the semantics of #refreshCertificate so that is
merely requests the refresh, but in the end decided to stick with existing
behaviour.
* I think in the long term long running operations such as this one or, a
better example, Queue#clearQueue, should return a CancellableFutures. These
CancellableFutures should be exposed somehow to management so that operators
can see the long running operations that are in-flight and choose to cancel
them if they wish.
> [Java Broker] SiteSpecificTrustStore does not provide helpful error messages
> when protocol is missing
> -
>
> Key: QPID-7311
> URL: https://issues.apache.org/jira/browse/QPID-7311
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Lorenz Quack
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-7.0
>
>
> Currently, when creating a {{SiteSpecificTrustStore}} and the protocol is not
> specified in the URL the object will be created but put into ERRORED state.
> No indication as to what is wrong is given. Furthermore the URL is not
> editable rendering the newly created object utterly useless.
> On the Broker side a MalformedURLException is logged at INFO level giving the
> helpful information "no protocol".
> On the broker side we do not need a full stack trace.
> On the client side a error message would be preferable to creating an ERRORED
> object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7311) [Java Broker] SiteSpecificTrustStore does not provide helpful error messages when protocol is missing
[
https://issues.apache.org/jira/browse/QPID-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-7311:
-
Status: Reviewable (was: In Progress)
> [Java Broker] SiteSpecificTrustStore does not provide helpful error messages
> when protocol is missing
> -
>
> Key: QPID-7311
> URL: https://issues.apache.org/jira/browse/QPID-7311
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Lorenz Quack
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-7.0
>
>
> Currently, when creating a {{SiteSpecificTrustStore}} and the protocol is not
> specified in the URL the object will be created but put into ERRORED state.
> No indication as to what is wrong is given. Furthermore the URL is not
> editable rendering the newly created object utterly useless.
> On the Broker side a MalformedURLException is logged at INFO level giving the
> helpful information "no protocol".
> On the broker side we do not need a full stack trace.
> On the client side a error message would be preferable to creating an ERRORED
> object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7623) "SEVERE: RuntimeException while executing runnable" reported by Guava to stderr if a state transition method throws exception
Keith Wall created QPID-7623:
Summary: "SEVERE: RuntimeException while executing runnable"
reported by Guava to stderr if a state transition method throws exception
Key: QPID-7623
URL: https://issues.apache.org/jira/browse/QPID-7623
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: qpid-java-6.1, qpid-java-6.0
Reporter: Keith Wall
Priority: Minor
Fix For: qpid-java-7.0
As reported in QPID-7311, a state change that throws an exception, may cause a
warning like the following to be reported to stderr:
{noformat}
SEVERE: RuntimeException while executing runnable
com.google.common.util.concurrent.Futures$6@5b83d60e with executor
org.apache.qpid.server.configuration.updater.TaskExecutorImpl@2
c5a6012
org.apache.qpid.server.configuration.IllegalConfigurationException: Unable to
get certificate for 'test' from 'https://google.com'
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:339)
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:302)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.ConnectException: Connection timed out: connect
at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
at
java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:85)
at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:579)
at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:625)
at
org.apache.qpid.server.security.SiteSpecificTrustStoreImpl$2.call(SiteSpecificTrustStoreImpl.java:316)
... 5 more
{noformat}
The problem is a general one rather than being specific to SSTS.
The create exception handler involved code at lines
AbstractConfiguredObject.java:1083 unconditional re-raises the exception. The
exception then goes uncaught and is logged by Guava at line
ExecutionList.java:160. Guava's behaviour here is documented in
ListenableFuture.java:103.
Whilst ugly, this actually causes no functional harm. The child creation
error is still reported to the end user, and the child is still deregistered
from the parent. However, the appearance of the stack on stderr will cause
alarm to end-users.
The cause of the problem is AbstractConfiguredObject.java:1083. The
{{FutureCallback#onFailure}} impl should not be rethrowing the exception.
Setting returnValue's exception is sufficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
