date:20170915

[jira] [Commented] (DISPATCH-828) Discarded message processing does not close callback window

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168549#comment-16168549
 ] 

ASF subversion and git services commented on DISPATCH-828:
--

Commit b0fcd9a54a324e62a33e3117de3092139fe655ce in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=b0fcd9a ]

DISPATCH-828: Disassociate link from message to prevent callbacks


> Discarded message processing does not close callback window
> ---
>
> Key: DISPATCH-828
> URL: https://issues.apache.org/jira/browse/DISPATCH-828
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> In flight AMQP_rx_handler callbacks may call message_receive after the 
> receive is complete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-828) Discarded message processing does not close callback window

2017-09-15 Thread Chuck Rolke (JIRA)

Chuck Rolke created DISPATCH-828:


 Summary: Discarded message processing does not close callback 
window
 Key: DISPATCH-828
 URL: https://issues.apache.org/jira/browse/DISPATCH-828
 Project: Qpid Dispatch
  Issue Type: Improvement
Reporter: Chuck Rolke
Assignee: Chuck Rolke


In flight AMQP_rx_handler callbacks may call message_receive after the receive 
is complete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-827) Large message discard buffer too small

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168527#comment-16168527
 ] 

ASF subversion and git services commented on DISPATCH-827:
--

Commit d9f0f0849940e8f77a6de251800cc6ce0d9da1de in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=d9f0f08 ]

DISPATCH-827: Increase size of message discard buffer


> Large message discard buffer too small
> --
>
> Key: DISPATCH-827
> URL: https://issues.apache.org/jira/browse/DISPATCH-827
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Using BUFFER_SIZE (default 512) causes needless churn.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-827) Large message discard buffer too small

2017-09-15 Thread Chuck Rolke (JIRA)

Chuck Rolke created DISPATCH-827:


 Summary: Large message discard buffer too small
 Key: DISPATCH-827
 URL: https://issues.apache.org/jira/browse/DISPATCH-827
 Project: Qpid Dispatch
  Issue Type: Improvement
Reporter: Chuck Rolke
Assignee: Chuck Rolke


Using BUFFER_SIZE (default 512) causes needless churn.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread Chuck Rolke (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168498#comment-16168498
 ] 

Chuck Rolke commented on DISPATCH-807:
--

Running a qpid-dispatch router as the intermediary in a qpid-interop-test 
binary amqp_large_content_test produced good results. The test ran with two 
shims: proton-cpp and amqpnetlite under mono. Test message sizes were 1, 10, 
and 100 Mbytes.

|| qpid-dispatch commit || peak memory usage (Mb) || elapsed time (S) ||
|  e584a3eb before  |  376| 190.624   |
|  fd545d4b after   |  14 | 183.466   |


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
> Fix For: 1.0.0
>
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-818) Honor failoverList provided by connected brokers

2017-09-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168394#comment-16168394
 ] 

ASF GitHub Bot commented on DISPATCH-818:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/195#discussion_r139231310
  
--- Diff: src/connection_manager.c ---
@@ -633,7 +633,46 @@ qd_error_t qd_entity_refresh_listener(qd_entity_t* 
entity, void *impl)
 
 qd_error_t qd_entity_refresh_connector(qd_entity_t* entity, void *impl)
 {
-return QD_ERROR_NONE;
+qd_connector_t *ct = (qd_connector_t*) impl;
+
+if (DEQ_SIZE(ct->conn_info_list) > 1) {
+qd_failover_item_list_t   conn_info_list = ct->conn_info_list;
+
+qd_failover_item_t *item = DEQ_HEAD(conn_info_list);
+
+//
+// As you can see we are skipping the head of the list. The
+// first item in the list is always the original connection 
information
+// and we dont want to display that information as part of the 
failover list.
+//
+char failover_info[250];
--- End diff --

Having a fixed-length string and later using strcat (not strncat) causes 
this to be a buffer/stack overflow vulnerability.  Please ensure that the 
failover_info buffer cannot be overfilled.


> Honor failoverList provided by connected brokers
> 
>
> Key: DISPATCH-818
> URL: https://issues.apache.org/jira/browse/DISPATCH-818
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.8.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.0.0
>
>
> When a router makes a connection to a broker (using a configured connector), 
> the broker may provide alternate connection information for use in a failure 
> scenario. The router must honor this alternate connection data when the 
> primary connection is lost.
> For example, if the router opens a connection to the broker and the broker 
> responds with an open frame like the following - 
> {noformat}
> [0x7fc8b000a3e0]:0 <- @open(16) [container-id="Router.A", 
> max-frame-size=16384, channel-max=32767, idle-time-out=8000, 
> offered-capabilities=:"ANONYMOUS-RELAY", 
> properties={:product="qpid-dispatch-router", :version="1.0.0", 
> :"failover-server-list"=[{:"network-host"="second-host", :port="25000"}, 
> {:"network-host"="third-host", :port="5671", :scheme="amqps"}]}]
> {noformat}
> notice that the broker sends a failover-server-list of 
> {noformat}
> "failover-server-list"=[{:"network-host"="second-host", :port="25000"}, 
> {:"network-host"="third-host", :port="5671", :scheme="amqps"}]
> {noformat}
> The router should store this alternate connection information and retry these 
> hosts when the original connection goes down.
> The following should be the order of operations
>  - The original connection goes down, try connecting with the original 
> connection information one more time. If that failed, try connecting with the 
> alternate connection information. If the original and the alternate failed, 
> keep going round robin between alternate and original until you get a 
> successful hit.
> - If there is no alternate connection information, keep on trying to connect 
> using the original connection information (which is what is currently 
> happening).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #195: DISPATCH-818 - Added connection info list t...

2017-09-15 Thread ted-ross

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/195#discussion_r139231310
  
--- Diff: src/connection_manager.c ---
@@ -633,7 +633,46 @@ qd_error_t qd_entity_refresh_listener(qd_entity_t* 
entity, void *impl)
 
 qd_error_t qd_entity_refresh_connector(qd_entity_t* entity, void *impl)
 {
-return QD_ERROR_NONE;
+qd_connector_t *ct = (qd_connector_t*) impl;
+
+if (DEQ_SIZE(ct->conn_info_list) > 1) {
+qd_failover_item_list_t   conn_info_list = ct->conn_info_list;
+
+qd_failover_item_t *item = DEQ_HEAD(conn_info_list);
+
+//
+// As you can see we are skipping the head of the list. The
+// first item in the list is always the original connection 
information
+// and we dont want to display that information as part of the 
failover list.
+//
+char failover_info[250];
--- End diff --

Having a fixed-length string and later using strcat (not strncat) causes 
this to be a buffer/stack overflow vulnerability.  Please ensure that the 
failover_info buffer cannot be overfilled.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Closed] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread Chuck Rolke (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke closed DISPATCH-807.

   Resolution: Fixed
Fix Version/s: 1.0.0

Closed at Commit fd545d4

Proposal 1 was implemented. The queue limits are hard coded for Q2 and Q3.

> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
> Fix For: 1.0.0
>
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-824) Remove deprecated entities and attributes from the router schema.

2017-09-15 Thread Ganesh Murthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-824:
---
Description: 
As Dispatch is coming up on a major 1.0 release, the following deprecated 
entities/attributes must be removed from the schema

routerId, mobileAddrMaxAge attributes from the router entity
{noformat}
"routerId": {
"description":"(DEPRECATED) Router's unique identity. This 
attribute has been deprecated. Use id instead",
"type": "string",
"required": false,
"deprecated": true,
"create": true
},
"mobileAddrMaxAge": {
"type": "integer",
"default": 60,
"deprecated": true,
"description": "(DEPRECATED) This value is no longer used 
in the router.",
"create": true
},
{noformat}

addr, allowUnsecured, allowNoSasl, requirePeerAuth  attributes in listener 
entity
{noformat}
"addr": {
"description":"(DEPRECATED)IP address: ipv4 or ipv6 literal 
or a host name. This attribute has been deprecated. Use host instead",
"deprecated": true,
"type": "string",
"default": "",
"create": true
},
"allowNoSasl": {
"type": "boolean",
"create": true,
"deprecated": true,
"description": "(DEPRECATED) This attribute is now 
controlled by the authenticatePeer attribute."
},
"requirePeerAuth": {
"type": "boolean",
"create": true,
"deprecated": true,
"description": "(DEPRECATED) This attribute is now 
controlled by the authenticatePeer attribute."
},
"allowUnsecured": {
"type": "boolean",
"create": true,
"deprecated": true,
"description": "(DEPRECATED) This attribute is now 
controlled by the requireEncryption attribute."
},
{noformat}

addr  attribute in connector entity
{noformat}
"addr": {
"description":"(DEPRECATED)IP address: ipv4 or ipv6 literal 
or a host name. This attribute has been deprecated. Use host instead",
"deprecated": true,
"type": "string",
"default": "127.0.0.1",
"create": true
},
{noformat}

Remove the container entity
{noformat}
"container": {
"description":"(DEPRECATED)Attributes related to the AMQP 
container. This entity has been deprecated. Use the router entity instead.",
"extends": "configurationEntity",
"deprecated": true,
"singleton": true,
"attributes": {

"containerName": {
"type": "string",
"description": "The  name of the AMQP container.  If not 
specified, the container name will be set to a value of the container's 
choosing.  The automatically assigned container name is not guaranteed to be 
persistent across restarts of the container.",
"create": true

},
"workerThreads": {
"type": "integer",
"default": 4,
"description": "The number of threads that will be created 
to process message traffic and other application work (timers, non-amqp file 
descriptors, etc.) .",
"create": true

},
"debugDump": {
"type": "path",
"description": "A file to dump debugging information that 
can't be logged normally.",
"create": true

},
"saslConfigPath": {
"type": "path",
"description": "Absolute path to the SASL configuration 
file.",
"required": false,
"create": true
},
"saslConfigName": {
"type": "string",
"description": "Name of the SASL configuration.  This 
string + '.conf' is the name of the configuration file.",
"required": false,
"create": true
}
}
},
{noformat}

Remove waypoint, linkRoutePattern, fixedAddress entities.
{noformat}
"waypoint": {
"description":"(DEPRECATED) A remote node that messages for an 
address pass through. This entity has been deprecated. Use autoLink instead",
"deprecated": true,

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168378#comment-16168378
 ] 

ASF GitHub Bot commented on DISPATCH-807:
-

Github user ChugR commented on the issue:

https://github.com/apache/qpid-dispatch/pull/196
  
Merged through another branch


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-824) Remove deprecated entities and attributes from the router schema.

2017-09-15 Thread Ganesh Murthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-824:
---
Description: 
As Dispatch is coming up on a major 1.0 release, the following deprecated 
entities/attributes must be removed from the schema

routerId, mobileAddrMaxAge attributes from the router entity
{noformat}
"routerId": {
"description":"(DEPRECATED) Router's unique identity. This 
attribute has been deprecated. Use id instead",
"type": "string",
"required": false,
"deprecated": true,
"create": true
},
"mobileAddrMaxAge": {
"type": "integer",
"default": 60,
"deprecated": true,
"description": "(DEPRECATED) This value is no longer used 
in the router.",
"create": true
},
{noformat}

addr, allowUnsecured, allowNoSasl, requirePeerAuth  attributes in listener 
entity
{noformat}
"addr": {
"description":"(DEPRECATED)IP address: ipv4 or ipv6 literal 
or a host name. This attribute has been deprecated. Use host instead",
"deprecated": true,
"type": "string",
"default": "",
"create": true
},
"allowNoSasl": {
"type": "boolean",
"create": true,
"deprecated": true,
"description": "(DEPRECATED) This attribute is now 
controlled by the authenticatePeer attribute."
},
"requirePeerAuth": {
"type": "boolean",
"create": true,
"deprecated": true,
"description": "(DEPRECATED) This attribute is now 
controlled by the authenticatePeer attribute."
},
"allowUnsecured": {
"type": "boolean",
"create": true,
"deprecated": true,
"description": "(DEPRECATED) This attribute is now 
controlled by the requireEncryption attribute."
},
{noformat}

addr  attribute in connector entity
{noformat}
"addr": {
"description":"(DEPRECATED)IP address: ipv4 or ipv6 literal 
or a host name. This attribute has been deprecated. Use host instead",
"deprecated": true,
"type": "string",
"default": "127.0.0.1",
"create": true
},
{noformat}

Remove the container entity
{noformat}
"container": {
"description":"(DEPRECATED)Attributes related to the AMQP 
container. This entity has been deprecated. Use the router entity instead.",
"extends": "configurationEntity",
"deprecated": true,
"singleton": true,
"attributes": {

"containerName": {
"type": "string",
"description": "The  name of the AMQP container.  If not 
specified, the container name will be set to a value of the container's 
choosing.  The automatically assigned container name is not guaranteed to be 
persistent across restarts of the container.",
"create": true

},
"workerThreads": {
"type": "integer",
"default": 4,
"description": "The number of threads that will be created 
to process message traffic and other application work (timers, non-amqp file 
descriptors, etc.) .",
"create": true

},
"debugDump": {
"type": "path",
"description": "A file to dump debugging information that 
can't be logged normally.",
"create": true

},
"saslConfigPath": {
"type": "path",
"description": "Absolute path to the SASL configuration 
file.",
"required": false,
"create": true
},
"saslConfigName": {
"type": "string",
"description": "Name of the SASL configuration.  This 
string + '.conf' is the name of the configuration file.",
"required": false,
"create": true
}
}
},
{noformat}

Remove waypoint, linkRoutePattern, fixedAddress entities.
{noformat}
"waypoint": {
"description":"(DEPRECATED) A remote node that messages for an 
address pass through. This entity has been deprecated. Use autoLink instead",
"deprecated": true,

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168379#comment-16168379
 ] 

ASF GitHub Bot commented on DISPATCH-807:
-

Github user ChugR closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/196


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #196: DISPATCH-807: Message handling requires flow contr...

2017-09-15 Thread ChugR

Github user ChugR commented on the issue:

https://github.com/apache/qpid-dispatch/pull/196
  
Merged through another branch


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #196: DISPATCH-807: Message handling requires flo...

2017-09-15 Thread ChugR

Github user ChugR closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/196


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168365#comment-16168365
 ] 

ASF subversion and git services commented on DISPATCH-807:
--

Commit 71aaf446cfcb983e4c5cb7ddb433481dfc1cddcf in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=71aaf44 ]

DISPATCH-807: Define limits, state, and accessors for Q2 input holdoff


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168370#comment-16168370
 ] 

ASF subversion and git services commented on DISPATCH-807:
--

Commit e4038b8b412e98ea82b4eebc04e6a32eea4740ce in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=e4038b8 ]

DISPATCH-807: Implement Q3 limits based on send session outgoing bytes


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168343#comment-16168343
 ] 

ASF subversion and git services commented on DISPATCH-807:
--

Commit ff9d9ed8d2c500d9088553ba2622d70aa194e70b in qpid-dispatch's branch 
refs/heads/DISPATCH-807-1 from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=ff9d9ed ]

DISPATCH-807: remove asserts for items that disappear regularly


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168341#comment-16168341
 ] 

ASF subversion and git services commented on DISPATCH-807:
--

Commit c46cb0115f9f9a1028a3be38622273d4b7db7637 in qpid-dispatch's branch 
refs/heads/DISPATCH-807-1 from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=c46cb01 ]

DISPATCH-807: Implement Q2 throttling

* Add container accessor for link->node->context
* qd_message_send signals when enough room for q2 resume is available
* Add message accessor for receiving qd_link
* Promote server connection_wake to public
* Use macros to name LOCK, UNLOCK functions for legibility
* Sense and set q2 holdoff in message_receive
* Sense and clear q2 holdoff in message_send
* Add deferred callback for AMQP_rx_handler


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168340#comment-16168340
 ] 

ASF subversion and git services commented on DISPATCH-807:
--

Commit 1c639f101eb286ddde19ec7eeb6447c86a867de7 in qpid-dispatch's branch 
refs/heads/DISPATCH-807-1 from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=1c639f1 ]

DISPATCH-807: Remove delivery arg from delivery_handler interface

Container delivery handler has a qd_link arg and from that the
pn_link and the current pn_delivery may be derived.


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168338#comment-16168338
 ] 

ASF subversion and git services commented on DISPATCH-807:
--

Commit ece8bfea22fbe4333ed11e86741156913ed95b35 in qpid-dispatch's branch 
refs/heads/DISPATCH-807-1 from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=ece8bfe ]

DISPATCH-807: Define limits, state, and accessors for Q2 input holdoff


> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-809) Add options to enable Sanitizers to CMake build

2017-09-15 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross updated DISPATCH-809:
--
Fix Version/s: 1.0.0

> Add options to enable Sanitizers to CMake build
> ---
>
> Key: DISPATCH-809
> URL: https://issues.apache.org/jira/browse/DISPATCH-809
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Jiri Danek
>Assignee: Ted Ross
>Priority: Minor
> Fix For: 1.0.0
>
>
> The usage is to first enable sanitizers during compilation
> {noformat}
> cmake .. -DUSE_SANITIZERS=ON -DProton_DIR=... -DCMAKE_BUILD_TYPE=Release
> {noformat}
> or
> {noformat}
> cmake .. -DUSE_TSAN=ON -DProton_DIR=... -DCMAKE_BUILD_TYPE=Release
> {noformat}
> (TSan is incompatible with the other sanitizers.)
> Then, either run unit tests with the usual {{ctest -VV}}, or run 
> {{qdrouterd}}.
> Sanitizers can be given parameters in environment variable. For example, 
> {{TSAN_OPTIONS="color=always" ctest -VV}} to see colored error messages in 
> ctest output. Other options are described on the Sanitizers website, e.g. 
> https://github.com/google/sanitizers/wiki/ThreadSanitizerFlags
> For best results, also compile Proton with sanitizers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (DISPATCH-809) Add options to enable Sanitizers to CMake build

2017-09-15 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross reassigned DISPATCH-809:
-

Assignee: Ted Ross

> Add options to enable Sanitizers to CMake build
> ---
>
> Key: DISPATCH-809
> URL: https://issues.apache.org/jira/browse/DISPATCH-809
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Jiri Danek
>Assignee: Ted Ross
>Priority: Minor
> Fix For: 1.0.0
>
>
> The usage is to first enable sanitizers during compilation
> {noformat}
> cmake .. -DUSE_SANITIZERS=ON -DProton_DIR=... -DCMAKE_BUILD_TYPE=Release
> {noformat}
> or
> {noformat}
> cmake .. -DUSE_TSAN=ON -DProton_DIR=... -DCMAKE_BUILD_TYPE=Release
> {noformat}
> (TSan is incompatible with the other sanitizers.)
> Then, either run unit tests with the usual {{ctest -VV}}, or run 
> {{qdrouterd}}.
> Sanitizers can be given parameters in environment variable. For example, 
> {{TSAN_OPTIONS="color=always" ctest -VV}} to see colored error messages in 
> ctest output. Other options are described on the Sanitizers website, e.g. 
> https://github.com/google/sanitizers/wiki/ThreadSanitizerFlags
> For best results, also compile Proton with sanitizers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-466) Orderly Quiescence of Links

2017-09-15 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross updated DISPATCH-466:
--
Fix Version/s: (was: 1.0.0)
   1.1.0

> Orderly Quiescence of Links
> ---
>
> Key: DISPATCH-466
> URL: https://issues.apache.org/jira/browse/DISPATCH-466
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ted Ross
> Fix For: 1.1.0
>
>
> This features provides an "adminStatus" field for links which is "enabled" or 
> "disabled".  When a link is set to disabled, its operStatus transitions from 
> UP to IDLE in an orderly fashion, such that message deliveries are not 
> dropped if an idle link is closed.
> For incoming links, this means draining remaining credit and waiting for 
> unsettled deliveries to be settled.
> For outgoing links, stop routing new deliveries to the link and wait for 
> unsettled deliveries to be settled.
> Note that this feature is neither meaningful nor supported for routed links.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPIDJMS-322) handle edge cases when driving transport#tick(now) with nanoTime derived values

2017-09-15 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPIDJMS-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPIDJMS-322.

Resolution: Fixed

> handle edge cases when driving transport#tick(now) with nanoTime derived 
> values
> ---
>
> Key: QPIDJMS-322
> URL: https://issues.apache.org/jira/browse/QPIDJMS-322
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.24.0
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.25.0
>
>
> The client uses handle nanoTime derived values to drive protons 
> transport#tick(now) method for heartbeating, but does not fully handle the 
> return value, which can be negative in cases. It is also susceptible to 
> issues from PROTON-1583.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-821) recreating an address immediately after deleting it, results in error

2017-09-15 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-821.
---
Resolution: Fixed

> recreating an address immediately after deleting it, results in error
> -
>
> Key: DISPATCH-821
> URL: https://issues.apache.org/jira/browse/DISPATCH-821
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Gordon Sim
>Assignee: Ken Giusti
> Fix For: 1.0.0
>
> Attachments: dispatch_821.py
>
>
> If an address is deleted, then *after* the router confirms the deletion, it 
> is immediately recreated, the router responds with an error to the create - 
> {"statusDescription"="Address prefix conflicts with an existing entity", 
> "statusCode"=400}. Subsequent queries do not show the address but it can't be 
> created either.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPIDJMS-324) update to proton-j 0.22.0

2017-09-15 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPIDJMS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPIDJMS-324.

Resolution: Fixed

> update to proton-j 0.22.0
> -
>
> Key: QPIDJMS-324
> URL: https://issues.apache.org/jira/browse/QPIDJMS-324
> Project: Qpid JMS
>  Issue Type: Task
>  Components: qpid-jms-client
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.25.0
>
>
> Update to proton-j 0.22.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-324) update to proton-j 0.22.0

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168142#comment-16168142
 ] 

ASF subversion and git services commented on QPIDJMS-324:
-

Commit 2512846842ee4a40126d113ab459d90b1a4d7504 in qpid-jms's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=2512846 ]

QPIDJMS-324: update to proton-j 0.22.0


> update to proton-j 0.22.0
> -
>
> Key: QPIDJMS-324
> URL: https://issues.apache.org/jira/browse/QPIDJMS-324
> Project: Qpid JMS
>  Issue Type: Task
>  Components: qpid-jms-client
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.25.0
>
>
> Update to proton-j 0.22.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-322) handle edge cases when driving transport#tick(now) with nanoTime derived values

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168143#comment-16168143
 ] 

ASF subversion and git services commented on QPIDJMS-322:
-

Commit 9bd02a9155a2d089025139aeaebb8356747596a7 in qpid-jms's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=9bd02a9 ]

QPIDJMS-322: update tick deadline check to account for the fact it could be 
negative if the original was or it wrapped


> handle edge cases when driving transport#tick(now) with nanoTime derived 
> values
> ---
>
> Key: QPIDJMS-322
> URL: https://issues.apache.org/jira/browse/QPIDJMS-322
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.24.0
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.25.0
>
>
> The client uses handle nanoTime derived values to drive protons 
> transport#tick(now) method for heartbeating, but does not fully handle the 
> return value, which can be negative in cases. It is also susceptible to 
> issues from PROTON-1583.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-821) recreating an address immediately after deleting it, results in error

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168132#comment-16168132
 ] 

ASF subversion and git services commented on DISPATCH-821:
--

Commit 355942a8a0a4aa4c221d90272c1960542fe3b37d in qpid-dispatch's branch 
refs/heads/master from Kenneth Giusti
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=355942a ]

DISPATCH-821: actually delete the configured address


> recreating an address immediately after deleting it, results in error
> -
>
> Key: DISPATCH-821
> URL: https://issues.apache.org/jira/browse/DISPATCH-821
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Gordon Sim
>Assignee: Ken Giusti
> Fix For: 1.0.0
>
> Attachments: dispatch_821.py
>
>
> If an address is deleted, then *after* the router confirms the deletion, it 
> is immediately recreated, the router responds with an error to the create - 
> {"statusDescription"="Address prefix conflicts with an existing entity", 
> "statusCode"=400}. Subsequent queries do not show the address but it can't be 
> created either.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-821) recreating an address immediately after deleting it, results in error

2017-09-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168136#comment-16168136
 ] 

ASF GitHub Bot commented on DISPATCH-821:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/197


> recreating an address immediately after deleting it, results in error
> -
>
> Key: DISPATCH-821
> URL: https://issues.apache.org/jira/browse/DISPATCH-821
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Gordon Sim
>Assignee: Ken Giusti
> Fix For: 1.0.0
>
> Attachments: dispatch_821.py
>
>
> If an address is deleted, then *after* the router confirms the deletion, it 
> is immediately recreated, the router responds with an error to the create - 
> {"statusDescription"="Address prefix conflicts with an existing entity", 
> "statusCode"=400}. Subsequent queries do not show the address but it can't be 
> created either.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #197: DISPATCH-821: actually delete the configure...

2017-09-15 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/197


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7917) [Java Broker, WMC] Upgrade dgrid and dstore dependecies to latest versions

2017-09-15 Thread Alex Rudyy (JIRA)

Alex Rudyy created QPID-7917:


 Summary: [Java Broker, WMC] Upgrade dgrid and dstore dependecies 
to latest versions
 Key: QPID-7917
 URL: https://issues.apache.org/jira/browse/QPID-7917
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Reporter: Alex Rudyy


Upgrade dgrid to version 1.2.1
Upgrade dstore version to  1.1.2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7772) Add statistics panel to view tabs within the Web Management Console

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168109#comment-16168109
 ] 

ASF subversion and git services commented on QPID-7772:
---

Commit f8e43f2e5ff0a75a022067ecbdb8f1813be5e181 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=f8e43f2 ]

QPID-7772: [Java Broker, WMC] Improve UI for Virtual host and statistics

* Replace VH tab grids with dgrid
* Initialize StatisticsWidget field _allGrid in postCreate


> Add statistics panel to view tabs within the Web Management Console
> ---
>
> Key: QPID-7772
> URL: https://issues.apache.org/jira/browse/QPID-7772
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
>
> Configured Objects within the Broker's object model already carry many useful 
> statistics.  Only a fraction of these are currently presented on the WMC and 
> this means that most users are aware of their existence. 
>  Each view tab should have an expandable panel that provides the available 
> statistics. The contents of the statistics panel should be entirely driven 
> from the object's metadata.  If the statistics panel is opened, the 
> statistics should be updated automatically to the same refresh cycle of the 
> request of the UI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPIDJMS-324) update to proton-j 0.22.0

2017-09-15 Thread Robbie Gemmell (JIRA)

Robbie Gemmell created QPIDJMS-324:
--

 Summary: update to proton-j 0.22.0
 Key: QPIDJMS-324
 URL: https://issues.apache.org/jira/browse/QPIDJMS-324
 Project: Qpid JMS
  Issue Type: Task
  Components: qpid-jms-client
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
 Fix For: 0.25.0


Update to proton-j 0.22.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #197: DISPATCH-821: actually delete the configure...

2017-09-15 Thread kgiusti

GitHub user kgiusti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/197

DISPATCH-821: actually delete the configured address

Well. that was stupid.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kgiusti/dispatch DISPATCH-821

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #197


commit 355942a8a0a4aa4c221d90272c1960542fe3b37d
Author: Kenneth Giusti 
Date:   2017-09-15T16:00:20Z

DISPATCH-821: actually delete the configured address




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-807) Message handling requires flow control to limit memory consumption

2017-09-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167910#comment-16167910
 ] 

ASF GitHub Bot commented on DISPATCH-807:
-

GitHub user ChugR opened a pull request:

https://github.com/apache/qpid-dispatch/pull/196

DISPATCH-807: Message handling requires flow control to limit memory 
consumption



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChugR/qpid-dispatch DISPATCH-807

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #196


commit f682283c2d9543ae121ea7aae9b3b4b900dd387d
Author: Chuck Rolke 
Date:   2017-09-14T13:53:55Z

DISPATCH-807: Define limits, state, and accessors for Q2 input holdoff

commit 224e2154ce2c3756bf628d007e3b85806395cd69
Author: Chuck Rolke 
Date:   2017-09-14T14:15:05Z

DISPATCH-807: move q2 holdoff flag from message into content

Random senders free message content buffers. Each sender must be
able to sense the receiver's holdoff state to know when to
schedule a callback. Message content is common to the receiver
and to all the senders.

commit 14e1a13b33a2fecea0c8bc0f93c4c402094e8dc7
Author: Chuck Rolke 
Date:   2017-09-14T14:33:50Z

DISPATCH-807: Remove delivery arg from delivery_handler interface

Container delivery handler has a qd_link arg and from that the
pn_link and the current pn_delivery may be derived.

commit 131dfa49c56cc80a1cd20c3461defafd6b710caf
Author: Chuck Rolke 
Date:   2017-09-14T20:01:32Z

DISPATCH-807: Implement Q2 throttling

* Add container accessor for link->node->context
* qd_message_send signals when enough room for q2 resume is available
* Add message accessor for receiving qd_link
* Promote server connection_wake to public
* Use macros to name LOCK, UNLOCK functions for legibility
* Sense and set q2 holdoff in message_receive
* Sense and clear q2 holdoff in message_send
* Add deferred callback for AMQP_rx_handler

commit 62a7613fbae245c337b204ee86e5b1958afaa987
Author: Chuck Rolke 
Date:   2017-09-14T20:47:33Z

DISPATCH-807: remove asserts for items that disappear regularly

commit 998de77a8abb754f96f4f3d1c941f2562521537f
Author: Chuck Rolke 
Date:   2017-09-14T21:00:09Z

DISPATCH-807: Implement Q3 limits based on send session outgoing bytes

commit 63526470733f54746b93051e4aaae88815c2a20b
Author: Chuck Rolke 
Date:   2017-09-15T14:01:54Z

DISPATCH-807: Adjust sizes of q2 limits




> Message handling requires flow control to limit memory consumption
> --
>
> Key: DISPATCH-807
> URL: https://issues.apache.org/jira/browse/DISPATCH-807
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.8.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Large messages coming from fast senders and going to slow receivers may 
> consume large amounts of memory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #196: DISPATCH-807: Message handling requires flo...

2017-09-15 Thread ChugR

GitHub user ChugR opened a pull request:

https://github.com/apache/qpid-dispatch/pull/196

DISPATCH-807: Message handling requires flow control to limit memory 
consumption



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChugR/qpid-dispatch DISPATCH-807

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #196


commit f682283c2d9543ae121ea7aae9b3b4b900dd387d
Author: Chuck Rolke 
Date:   2017-09-14T13:53:55Z

DISPATCH-807: Define limits, state, and accessors for Q2 input holdoff

commit 224e2154ce2c3756bf628d007e3b85806395cd69
Author: Chuck Rolke 
Date:   2017-09-14T14:15:05Z

DISPATCH-807: move q2 holdoff flag from message into content

Random senders free message content buffers. Each sender must be
able to sense the receiver's holdoff state to know when to
schedule a callback. Message content is common to the receiver
and to all the senders.

commit 14e1a13b33a2fecea0c8bc0f93c4c402094e8dc7
Author: Chuck Rolke 
Date:   2017-09-14T14:33:50Z

DISPATCH-807: Remove delivery arg from delivery_handler interface

Container delivery handler has a qd_link arg and from that the
pn_link and the current pn_delivery may be derived.

commit 131dfa49c56cc80a1cd20c3461defafd6b710caf
Author: Chuck Rolke 
Date:   2017-09-14T20:01:32Z

DISPATCH-807: Implement Q2 throttling

* Add container accessor for link->node->context
* qd_message_send signals when enough room for q2 resume is available
* Add message accessor for receiving qd_link
* Promote server connection_wake to public
* Use macros to name LOCK, UNLOCK functions for legibility
* Sense and set q2 holdoff in message_receive
* Sense and clear q2 holdoff in message_send
* Add deferred callback for AMQP_rx_handler

commit 62a7613fbae245c337b204ee86e5b1958afaa987
Author: Chuck Rolke 
Date:   2017-09-14T20:47:33Z

DISPATCH-807: remove asserts for items that disappear regularly

commit 998de77a8abb754f96f4f3d1c941f2562521537f
Author: Chuck Rolke 
Date:   2017-09-14T21:00:09Z

DISPATCH-807: Implement Q3 limits based on send session outgoing bytes

commit 63526470733f54746b93051e4aaae88815c2a20b
Author: Chuck Rolke 
Date:   2017-09-15T14:01:54Z

DISPATCH-807: Adjust sizes of q2 limits




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-818) Honor failoverList provided by connected brokers

2017-09-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167900#comment-16167900
 ] 

ASF GitHub Bot commented on DISPATCH-818:
-

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/195

DISPATCH-818 - Added connection info list to the connector which stor…

…es the initial connection information and the backup connection information

1. If the primary connection goes down, the primary and the backup 
connections will be tried in quick succession
2. If the new backup connection does not provide failover-server-list, the 
list on the server is cleaned up to contain only the one pertinent connection 
info.
3. The connection info list always has at least one element in it which 
represents the initial successful connection information

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #195


commit 5e11d471feec3c4e51d8587b1dbb0e0bfe446848
Author: Ganesh Murthy 
Date:   2017-09-15T13:57:16Z

DISPATCH-818 - Added connection info list to the connector which stores the 
initial connection information and the backup connection information
1. If the primary connection goes down, the primary and the backup 
connections will be tried in quick succession
2. If the new backup connection does not provide failover-server-list, the 
list on the server is cleaned up to contain only the one pertinent connection 
info.
3. The connection info list always has at least one element in it which 
represents the initial successful connection information




> Honor failoverList provided by connected brokers
> 
>
> Key: DISPATCH-818
> URL: https://issues.apache.org/jira/browse/DISPATCH-818
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.8.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.0.0
>
>
> When a router makes a connection to a broker (using a configured connector), 
> the broker may provide alternate connection information for use in a failure 
> scenario. The router must honor this alternate connection data when the 
> primary connection is lost.
> For example, if the router opens a connection to the broker and the broker 
> responds with an open frame like the following - 
> {noformat}
> [0x7fc8b000a3e0]:0 <- @open(16) [container-id="Router.A", 
> max-frame-size=16384, channel-max=32767, idle-time-out=8000, 
> offered-capabilities=:"ANONYMOUS-RELAY", 
> properties={:product="qpid-dispatch-router", :version="1.0.0", 
> :"failover-server-list"=[{:"network-host"="second-host", :port="25000"}, 
> {:"network-host"="third-host", :port="5671", :scheme="amqps"}]}]
> {noformat}
> notice that the broker sends a failover-server-list of 
> {noformat}
> "failover-server-list"=[{:"network-host"="second-host", :port="25000"}, 
> {:"network-host"="third-host", :port="5671", :scheme="amqps"}]
> {noformat}
> The router should store this alternate connection information and retry these 
> hosts when the original connection goes down.
> The following should be the order of operations
>  - The original connection goes down, try connecting with the original 
> connection information one more time. If that failed, try connecting with the 
> alternate connection information. If the original and the alternate failed, 
> keep going round robin between alternate and original until you get a 
> successful hit.
> - If there is no alternate connection information, keep on trying to connect 
> using the original connection information (which is what is currently 
> happening).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #195: DISPATCH-818 - Added connection info list t...

2017-09-15 Thread ganeshmurthy

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/195

DISPATCH-818 - Added connection info list to the connector which storâ¦

â¦es the initial connection information and the backup connection 
information

1. If the primary connection goes down, the primary and the backup 
connections will be tried in quick succession
2. If the new backup connection does not provide failover-server-list, the 
list on the server is cleaned up to contain only the one pertinent connection 
info.
3. The connection info list always has at least one element in it which 
represents the initial successful connection information

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #195


commit 5e11d471feec3c4e51d8587b1dbb0e0bfe446848
Author: Ganesh Murthy 
Date:   2017-09-15T13:57:16Z

DISPATCH-818 - Added connection info list to the connector which stores the 
initial connection information and the backup connection information
1. If the primary connection goes down, the primary and the backup 
connections will be tried in quick succession
2. If the new backup connection does not provide failover-server-list, the 
list on the server is cleaned up to contain only the one pertinent connection 
info.
3. The connection info list always has at least one element in it which 
represents the initial successful connection information




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7916) Rename qpid broker for java to qpid-broker-j in maven descriptions, documentations, website etc

2017-09-15 Thread Keith Wall (JIRA)

Keith Wall created QPID-7916:


 Summary: Rename qpid broker for java to qpid-broker-j in maven 
descriptions, documentations, website etc
 Key: QPID-7916
 URL: https://issues.apache.org/jira/browse/QPID-7916
 Project: Qpid
  Issue Type: Task
  Components: Java Broker
Reporter: Keith Wall
Priority: Minor
 Fix For: qpid-java-broker-7.0.0


In this thread we agreed that the Java Broker would be known as "qpid-broker-j" 
(the consensus was that the "Qpid Broker for Java" was misleading).  The 
"qpid-broker-j" name was adopted for the name of the new Git repo (work of 
QPID-7622)

http://qpid.2158936.n2.nabble.com/DISCUSS-Migrate-Qpid-Broker-for-Java-and-Qpid-JMS-AMQP-0-x-Client-from-SVN-to-GIT-tt7661505.html#none

We need to reflect this name in Maven metadata (descriptions etc), docbook and 
website.
The maven artefactIds will not be changed.  





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7772) Add statistics panel to view tabs within the Web Management Console

2017-09-15 Thread Alex Rudyy (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167762#comment-16167762
 ] 

Alex Rudyy commented on QPID-7772:
--

Here are my review comments for the implemented changes:

* Scroll position jumps to statistics grid on page refresh after focusing of 
any of statistics grits (for example, due to sorting by Name) and scrolling 
down the tab. Explicit change of the focus into other non statistics widget 
does not helps. The focus changes back to the statistics grid.  This is an 
undesired effect. The current widget focus should not change on refreshes.
* Removal of statistics flattening 
** dots are displayed in grids for columns where statistics is displayed
*** VH tab:  queues, exchanges and loggers
*** Connection tab : sessions
* Statistics Widget
** Field allGrid is initalized to [] and field _nodes is initialized to {}. 
This kind of initialization ends up in sharing of the same objects  by all 
instances of StatisticsWidget.
** We have fields (category, type, management) which are required to pass into 
constructor and optional constructor field defaultStatistics. Additionally 
there are template and other fields, for example, "userPreferences" which 
initialized in postConstruct. I think that we can add a comment for fields 
without underscore about how they are set. For example, for category, type, 
management we can add comment that they are set from mandatory constructor 
arguments whilst fields like msgBytePairCumulativeStatisticsGridContainer are 
set from template. I think that  userPreferences should be renamed into  
_userPreferences as it is not set from template or constructor.
** StatisticsWidget#postCreate
*** constructor arguments for _msgBytePairCumulativeStatisticsGrid of type 
EnhancedGrid declares field 'class'. I think that class field should be quoted 
as class is reserved javascript world.
** Button caption "Show more statistics" looks too long to me. IMHO, 
substitution it with "More" should be sufficient to understand the button 
purpose, as it is inside of title pane with title 'Statistics', On toggle 
'Less' can be displayed.
* Tabs
** IMHO, Tab CO attributes which are displayed at the right should be aligned 
to the top. They are displayed in the middle
** Exchange tab layout is surprising (existing issue): attributes Type, State, 
Durable, Lifespan are grouped together in a separate div. I am not sure that it 
is intentional. The same applies to queue tab layout.
** VH tab contains 2 'alignLeft' groups. Is it intentional?

> Add statistics panel to view tabs within the Web Management Console
> ---
>
> Key: QPID-7772
> URL: https://issues.apache.org/jira/browse/QPID-7772
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
>
> Configured Objects within the Broker's object model already carry many useful 
> statistics.  Only a fraction of these are currently presented on the WMC and 
> this means that most users are aware of their existence. 
>  Each view tab should have an expandable panel that provides the available 
> statistics. The contents of the statistics panel should be entirely driven 
> from the object's metadata.  If the statistics panel is opened, the 
> statistics should be updated automatically to the same refresh cycle of the 
> request of the UI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7773) REST API queries that identify a single object by its full path should return a object rather than a list.

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167552#comment-16167552
 ] 

ASF subversion and git services commented on QPID-7773:
---

Commit 3da255dee11c24afae9d3b6d7db3fbb39330539f in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=3da255d ]

QPID-7773: [Java Broker] [Perf Tests] Use singletonModelObjectResponseAsList 
option in QpidRestAPIQueueCreator when querying broker to avoid compatibility 
problems with older version.


> REST API queries that identify a single object by its full path should return 
> a object rather than a list.
> --
>
> Key: QPID-7773
> URL: https://issues.apache.org/jira/browse/QPID-7773
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
>
> Currently if I GET for, say a queue, by the object's full path 
> {{/queue/vhn/vh/myqueue}}, I get a JSON list contain the queue object, rather 
> than an object directly.  This makes the REST API's abstraction inconsistent: 
> I PUT a queue as an object, but GET gives me a list.
> The REST API should be returning a list only in those situations where a 
> multiple object response could arise e.g. {{/queue/vhn/vh}}, wildcards or 
> filtering.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7773) REST API queries that identify a single object by its full path should return a object rather than a list.

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167551#comment-16167551
 ] 

ASF subversion and git services commented on QPID-7773:
---

Commit 6845fa67595ebdffa6793501e52f79d8e93d in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=6845fa6 ]

Revert "QPID-7773: [Java Broker, REST API] Fix REST API calls in 
QpidRestAPIQueueCreator"

This reverts commit 99365c079bb9571cd2fd9fe02a8dd134949ebca8.


> REST API queries that identify a single object by its full path should return 
> a object rather than a list.
> --
>
> Key: QPID-7773
> URL: https://issues.apache.org/jira/browse/QPID-7773
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
>
> Currently if I GET for, say a queue, by the object's full path 
> {{/queue/vhn/vh/myqueue}}, I get a JSON list contain the queue object, rather 
> than an object directly.  This makes the REST API's abstraction inconsistent: 
> I PUT a queue as an object, but GET gives me a list.
> The REST API should be returning a list only in those situations where a 
> multiple object response could arise e.g. {{/queue/vhn/vh}}, wildcards or 
> filtering.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1349) C "proactor" implementation on windows

2017-09-15 Thread Cliff Jansen (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cliff Jansen updated PROTON-1349:
-
Attachment: p1349_2.patch

Patch for compiling the C broker.  

> C "proactor" implementation on windows
> --
>
> Key: PROTON-1349
> URL: https://issues.apache.org/jira/browse/PROTON-1349
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
> Environment: Windows
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: proton-c-0.18.0
>
> Attachments: p1349_2.patch
>
>
> Provide the Windows counterpart to the work in 
>   https://issues.apache.org/jira/browse/PROTON-1344
> Including a thread safe inject.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1349) C "proactor" implementation on windows

2017-09-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167403#comment-16167403
 ] 

ASF subversion and git services commented on PROTON-1349:
-

Commit 6a57a8c986fbf86ad8ad109d673a89a5ae84c544 in qpid-proton's branch 
refs/heads/master from Clifford Jansen
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6a57a8c ]

PROTON-1349: completed and improved implementation, but still fails many tests


> C "proactor" implementation on windows
> --
>
> Key: PROTON-1349
> URL: https://issues.apache.org/jira/browse/PROTON-1349
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
> Environment: Windows
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: proton-c-0.18.0
>
>
> Provide the Windows counterpart to the work in 
>   https://issues.apache.org/jira/browse/PROTON-1344
> Including a thread safe inject.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

45 matches

Mail list logo