[jira] [Commented] (PROTON-1604) Windows C++ prefers std::endl to newlines
[ https://issues.apache.org/jira/browse/PROTON-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187241#comment-16187241 ] ASF subversion and git services commented on PROTON-1604: - Commit 0bed4109e73a0b664a65b09eced98f1ce8d00354 in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0bed410 ] PROTON-1604: replace C++ newlines with std::endl in output strings > Windows C++ prefers std::endl to newlines > - > > Key: PROTON-1604 > URL: https://issues.apache.org/jira/browse/PROTON-1604 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.18.0 > Environment: Visual Studio >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: proton-c-0.18.0 > > > Using C newline escaped char sequence can result in mysteriously missing > output. > Use std::endl instead of \\n. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1604) Windows C++ prefers std::endl to newlines
Cliff Jansen created PROTON-1604: Summary: Windows C++ prefers std::endl to newlines Key: PROTON-1604 URL: https://issues.apache.org/jira/browse/PROTON-1604 Project: Qpid Proton Issue Type: Bug Components: cpp-binding Affects Versions: proton-c-0.18.0 Environment: Visual Studio Reporter: Cliff Jansen Assignee: Cliff Jansen Fix For: proton-c-0.18.0 Using C newline escaped char sequence can result in mysteriously missing output. Use std::endl instead of \\n. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7937) [Java Broker] [AMQP1.0] Message grouping feature does not utilise group-id from the message properties
[
https://issues.apache.org/jira/browse/QPID-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187203#comment-16187203
]
ASF subversion and git services commented on QPID-7937:
---
Commit 3745dd952e998b59f27699ad208a80a7c9ffe90e in qpid-broker-j's branch
refs/heads/master from [~godfrer]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=3745dd9 ]
QPID-7937 : Define message grouping policy with an enum (default NONE), if
messageGroupKey is not supplied in Queue attributes, use the message property
"group-id"
> [Java Broker] [AMQP1.0] Message grouping feature does not utilise group-id
> from the message properties
> --
>
> Key: QPID-7937
> URL: https://issues.apache.org/jira/browse/QPID-7937
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
>
> The AMQP 1.0 specification provides a {{group-id}} field within the immutable
> message properties to pass the message grouping key. When enabled, the
> message grouping feature should be utilising this field the key for message
> grouping purposes. Currently the implementation looks for an application
> header (behaviour inherited from the older protocols).
> As discussed here:
> http://qpid.2158936.n2.nabble.com/Consumer-affinity-JMSXGroupID-AMQP-1-0-tc7667309.html
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7940) [Java Broker] JSON context substitution does not work with nested variables
[
https://issues.apache.org/jira/browse/QPID-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187204#comment-16187204
]
ASF subversion and git services commented on QPID-7940:
---
Commit 03c357718525711c2e3cb5ce6f68841beefe63b9 in qpid-broker-j's branch
refs/heads/master from [~godfrer]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=03c3577 ]
QPID-7940 : [Java Broker] JSON context substitution does not work with nested
variables
> [Java Broker] JSON context substitution does not work with nested variables
> ---
>
> Key: QPID-7940
> URL: https://issues.apache.org/jira/browse/QPID-7940
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> A context value of the form $\{json:FOO\} is intended to escape the value of
> FOO to be usable within a JSON string, however if the value of $\{FOO\}
> interpolates first into $\{BAR\} then the json substitution is not applied to
> the interpolated value of $\{BAR\}.
> Since $\{qpid.work_dir\} is now defined as defaulted to $\{QPID_WORK\} and
> the default for a JsonVirtualHostNode.getPreferenceStoreAttributes() contains
> "$\{json:qpid.work_dir\}", and a (Windows) directory is likely to contain
> characters needing escaping... The broker currently doesn't work on Windows
> with a JsonVirtualHostNode
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7942) [Java Broker] AppenderUtilsTest does not work on Windows
[ https://issues.apache.org/jira/browse/QPID-7942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187206#comment-16187206 ] ASF subversion and git services commented on QPID-7942: --- Commit b2cc03f227c8cd342b1b860eb84f387768e07104 in qpid-broker-j's branch refs/heads/master from [~godfrer] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=b2cc03f ] QPID-7942 : [Java Broker] AppenderUtilsTest does not work on Windows > [Java Broker] AppenderUtilsTest does not work on Windows > > > Key: QPID-7942 > URL: https://issues.apache.org/jira/browse/QPID-7942 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > > AppenderUtilsTest fails if it is unable to change the permissions on a newly > created temporary director so that it is not writable. It seems that it is > not possible to do so in Windows (10). The inability to do so does not > reflect any error in the Qpid code (perhaps the test could try a different > mechanism for creating a directory that cannot be written to?) and so the > test should not fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7941) [Java Broker] DerbyUtils MEMORY_STORE_LOCATION is incorrect
[ https://issues.apache.org/jira/browse/QPID-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187205#comment-16187205 ] ASF subversion and git services commented on QPID-7941: --- Commit 69baf06b410f37f730f6fde1ad4cc92d144da929 in qpid-broker-j's branch refs/heads/master from [~godfrer] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=69baf06 ] QPID-7941 : [Java Broker] DerbyUtils MEMORY_STORE_LOCATION is incorrect > [Java Broker] DerbyUtils MEMORY_STORE_LOCATION is incorrect > --- > > Key: QPID-7941 > URL: https://issues.apache.org/jira/browse/QPID-7941 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > > [Java Broker] DerbyUtils MEMORY_STORE_LOCATION is incorrect, making it > impossible to create an in-memory store on Windows (DerbyPreferenceStoreTest > fails, as the correct path for a memory store passed in in that test doesn't > match the value of the static value, so DerbyUtils attempts to create a > directory for the store, which fails as ":" is not a valid final character in > a windows directory). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7942) [Java Broker] AppenderUtilsTest does not work on Windows
Rob Godfrey created QPID-7942: - Summary: [Java Broker] AppenderUtilsTest does not work on Windows Key: QPID-7942 URL: https://issues.apache.org/jira/browse/QPID-7942 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey AppenderUtilsTest fails if it is unable to change the permissions on a newly created temporary director so that it is not writable. It seems that it is not possible to do so in Windows (10). The inability to do so does not reflect any error in the Qpid code (perhaps the test could try a different mechanism for creating a directory that cannot be written to?) and so the test should not fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7941) [Java Broker] DerbyUtils MEMORY_STORE_LOCATION is incorrect
Rob Godfrey created QPID-7941: - Summary: [Java Broker] DerbyUtils MEMORY_STORE_LOCATION is incorrect Key: QPID-7941 URL: https://issues.apache.org/jira/browse/QPID-7941 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey [Java Broker] DerbyUtils MEMORY_STORE_LOCATION is incorrect, making it impossible to create an in-memory store on Windows (DerbyPreferenceStoreTest fails, as the correct path for a memory store passed in in that test doesn't match the value of the static value, so DerbyUtils attempts to create a directory for the store, which fails as ":" is not a valid final character in a windows directory). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7940) [Java Broker] JSON context substitution does not work with nested variables
[
https://issues.apache.org/jira/browse/QPID-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rob Godfrey updated QPID-7940:
--
Description:
A context value of the form $\{json:FOO\} is intended to escape the value of
FOO to be usable within a JSON string, however if the value of $\{FOO\}
interpolates first into $\{BAR\} then the json substitution is not applied to
the interpolated value of $\{BAR\}.
Since $\{qpid.work_dir\} is now defined as defaulted to $\{QPID_WORK\} and the
default for a JsonVirtualHostNode.getPreferenceStoreAttributes() contains
"$\{json:qpid.work_dir\}", and a (Windows) directory is likely to contain
characters needing escaping... The broker currently doesn't work on Windows
with a JsonVirtualHostNode
was:
A context value of the form \$\{json:FOO\} is intended to escape the value of
FOO to be usable within a JSON string, however if the value of
{noformat}${FOO}{noformat} interpolates first into ${BAR} then the json
substitution is not applied to the interpolated value of ${BAR}.
Since ${qpid.work_dir} is now defined as defaulted to ${QPID_WORK} and the
default for a JsonVirtualHostNode.getPreferenceStoreAttributes() contains
"${json:qpid.work_dir}", and a (Windows) directory is likely to contain
characters needing escaping... The broker currently doesn't work on Windows
with a JsonVirtualHostNode
> [Java Broker] JSON context substitution does not work with nested variables
> ---
>
> Key: QPID-7940
> URL: https://issues.apache.org/jira/browse/QPID-7940
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> A context value of the form $\{json:FOO\} is intended to escape the value of
> FOO to be usable within a JSON string, however if the value of $\{FOO\}
> interpolates first into $\{BAR\} then the json substitution is not applied to
> the interpolated value of $\{BAR\}.
> Since $\{qpid.work_dir\} is now defined as defaulted to $\{QPID_WORK\} and
> the default for a JsonVirtualHostNode.getPreferenceStoreAttributes() contains
> "$\{json:qpid.work_dir\}", and a (Windows) directory is likely to contain
> characters needing escaping... The broker currently doesn't work on Windows
> with a JsonVirtualHostNode
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7940) [Java Broker] JSON context substitution does not work with nested variables
[
https://issues.apache.org/jira/browse/QPID-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rob Godfrey updated QPID-7940:
--
Description:
A context value of the form \$\{json:FOO\} is intended to escape the value of
FOO to be usable within a JSON string, however if the value of
{noformat}${FOO}{noformat} interpolates first into ${BAR} then the json
substitution is not applied to the interpolated value of ${BAR}.
Since ${qpid.work_dir} is now defined as defaulted to ${QPID_WORK} and the
default for a JsonVirtualHostNode.getPreferenceStoreAttributes() contains
"${json:qpid.work_dir}", and a (Windows) directory is likely to contain
characters needing escaping... The broker currently doesn't work on Windows
with a JsonVirtualHostNode
was:
A context value of the form ${json:FOO} is intended to escape the value of FOO
to be usable within a JSON string, however if the value of ${FOO} interpolates
first into ${BAR} then the json substitution is not applied to the interpolated
value of ${BAR}.
Since ${qpid.work_dir} is now defined as defaulted to ${QPID_WORK} and the
default for a JsonVirtualHostNode.getPreferenceStoreAttributes() contains
"${json:qpid.work_dir}", and a (Windows) directory is likely to contain
characters needing escaping... The broker currently doesn't work on Windows
with a JsonVirtualHostNode
> [Java Broker] JSON context substitution does not work with nested variables
> ---
>
> Key: QPID-7940
> URL: https://issues.apache.org/jira/browse/QPID-7940
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
>
> A context value of the form \$\{json:FOO\} is intended to escape the value of
> FOO to be usable within a JSON string, however if the value of
> {noformat}${FOO}{noformat} interpolates first into ${BAR} then the json
> substitution is not applied to the interpolated value of ${BAR}.
> Since ${qpid.work_dir} is now defined as defaulted to ${QPID_WORK} and the
> default for a JsonVirtualHostNode.getPreferenceStoreAttributes() contains
> "${json:qpid.work_dir}", and a (Windows) directory is likely to contain
> characters needing escaping... The broker currently doesn't work on Windows
> with a JsonVirtualHostNode
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7940) [Java Broker] JSON context substitution does not work with nested variables
Rob Godfrey created QPID-7940:
-
Summary: [Java Broker] JSON context substitution does not work
with nested variables
Key: QPID-7940
URL: https://issues.apache.org/jira/browse/QPID-7940
Project: Qpid
Issue Type: Bug
Components: Java Broker
Reporter: Rob Godfrey
Assignee: Rob Godfrey
A context value of the form ${json:FOO} is intended to escape the value of FOO
to be usable within a JSON string, however if the value of ${FOO} interpolates
first into ${BAR} then the json substitution is not applied to the interpolated
value of ${BAR}.
Since ${qpid.work_dir} is now defined as defaulted to ${QPID_WORK} and the
default for a JsonVirtualHostNode.getPreferenceStoreAttributes() contains
"${json:qpid.work_dir}", and a (Windows) directory is likely to contain
characters needing escaping... The broker currently doesn't work on Windows
with a JsonVirtualHostNode
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-7799) Broker should be able to write a periodic dump of statistics
[
https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187167#comment-16187167
]
Keith Wall edited comment on QPID-7799 at 9/30/17 6:12 PM:
---
Patch is now reviewable.
It gives the Broker and Virtualhost the responsibility for periodically writing
user-specified model statistics to the log. Statistic reporting can be
enabled dynamically without the need for a Broker or Virtualhost restart. The
statistics that are reported are also modifiable on the fly.
The user controls the reported statistics using context variables named in the
following form {{qpid..statisticsReportPattern}} which, as
normal, can come from the environment, the object itself or an ancestor. This
approach gives the flexibility for statistic reporting to be enabled category
class wide (e.g. all queues) or for a single object instance. The context
value is free text with placeholders to interpolate statistic values e.g.
{{messagesIn=$\{messagesIn\}}}. There's provision for
datetime/duration/byteunit formatting to help the readability of the report
{{bytessIn=$\{bytesIn:bytevalue\}}}. {{ancestor}} references can be used to
interpolate object names into the statistics lines to add object and parent
names.
There are some parts missing from the patch. I want to hear comments first:
# Currently when setting a context variable from the REST API, the user is
required to PUT an object's context map. This runs the risk that the user will
accidentally lose an unrelated context value whilst trying to apply a statistic
context variable. We should add ConfiuredObject managed operations to allow a
context variable to be put/got/removed.
# Broker#resetStatistics should either be refactored so all statistics are
reset and have an analogous method on Virtualhost, or we should kill the
feature. I'm in favour of the latter.
# I killed {{statisticsReportingResetEnabled}} already but haven't added a
upgrader to remove the attribute value.
# This patch makes {{StatisticsCounter}} unnecessary. It should be replaced
with a simple AtomicLongs.
# Docs
was (Author: k-wall):
Patch is now reviewable.
It gives the Broker and Virtualhost the responsibility for periodically writing
user-specified model statistics to the log. Statistic reporting can be
enabled dynamically without the need for a Broker or Virtualhost restart. The
statistics that are reported are also modifiable on the fly.
The user controls the reported statistics using a context variable named in the
following form {{qpid..statisticsReportPattern}} which, as
normal, can come from the environment, the object itself or an ancestor. This
approach gives the flexibility for statistic reporting to be enabled category
class wide (e.g. all queues) or for a single object instance. The context
value is free text with placeholders to interpolate statistic values e.g.
{{messagesIn=$\{messagesIn\}}}. There's provision for
datetime/duration/byteunit formatting to help the readability of the report
{{bytessIn=$\{bytesIn:bytevalue\}}}. {{ancestor}} references can be used to
interpolate object names into the statistics lines to add object and parent
names.
There are some parts missing from the patch. I want to hear comments first:
# Currently when setting a context variable from the REST API, the user is
required to PUT an object's context map. This runs the risk that the user will
accidentally lose an unrelated context value whilst trying to apply a statistic
context variable. We should add ConfiuredObject managed operations to allow a
context variable to be put/got/removed.
# Broker#resetStatistics should either be refactored so all statistics are
reset and have an analogous method on Virtualhost, or we should kill the
feature. I'm in favour of the latter.
# I killed {{statisticsReportingResetEnabled}} already but haven't added a
upgrader to remove the attribute value.
# This patch makes {{StatisticsCounter}} unnecessary. It should be replaced
with a simple AtomicLongs.
# Docs
> Broker should be able to write a periodic dump of statistics
>
>
> Key: QPID-7799
> URL: https://issues.apache.org/jira/browse/QPID-7799
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch
>
>
> To assist those running a service, the Broker should have the ability to
> write a periodic dump of ConiguredObject statistics to the log file. It
> should be possible to configure the statistics dumped at runtime and be
> configured on a per-category or per-object instance basis. Within a HA
>
[jira] [Comment Edited] (QPID-7799) Broker should be able to write a periodic dump of statistics
[
https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187167#comment-16187167
]
Keith Wall edited comment on QPID-7799 at 9/30/17 6:11 PM:
---
Patch is now reviewable.
It gives the Broker and Virtualhost the responsibility for periodically writing
user-specified model statistics to the log. Statistic reporting can be
enabled dynamically without the need for a Broker or Virtualhost restart. The
statistics that are reported are also modifiable on the fly.
The user controls the reported statistics using a context variable named in the
following form {{qpid..statisticsReportPattern}} which, as
normal, can come from the environment, the object itself or an ancestor. This
approach gives the flexibility for statistic reporting to be enabled category
class wide (e.g. all queues) or for a single object instance. The context
value is free text with placeholders to interpolate statistic values e.g.
{{messagesIn=$\{messagesIn\}}}. There's provision for
datetime/duration/byteunit formatting to help the readability of the report
{{bytessIn=$\{bytesIn:bytevalue\}}}. {{ancestor}} references can be used to
interpolate object names into the statistics lines to add object and parent
names.
There are some parts missing from the patch. I want to hear comments first:
# Currently when setting a context variable from the REST API, the user is
required to PUT an object's context map. This runs the risk that the user will
accidentally lose an unrelated context value whilst trying to apply a statistic
context variable. We should add ConfiuredObject managed operations to allow a
context variable to be put/got/removed.
# Broker#resetStatistics should either be refactored so all statistics are
reset and have an analogous method on Virtualhost, or we should kill the
feature. I'm in favour of the latter.
# I killed {{statisticsReportingResetEnabled}} already but haven't added a
upgrader to remove the attribute value.
# This patch makes {{StatisticsCounter}} unnecessary. It should be replaced
with a simple AtomicLongs.
# Docs
was (Author: k-wall):
Patch is now reviewable.
It gives the Broker and Virtualhost the responsibility for periodically writing
user-specific model statistics to the log. Statistic reporting can be enabled
dynamically without the need for a Broker or Virtualhost restart. The
statistics that are reported are also modifiable on the fly.
The user controls the reported statistics using a context variable named in the
following form {{qpid..statisticsReportPattern}} which, as
normal, can come from the environment, the object itself or an ancestor. This
approach gives the flexibility for statistic reporting to be enabled category
class wide (e.g. all queues) or for a single object instance. The context
value is free text with placeholders to interpolate statistic values e.g.
{{messagesIn=$\{messagesIn\}}}. There's provision for
datetime/duration/byteunit formatting to help the readability of the report
{{bytessIn=$\{bytesIn:bytevalue\}}}. {{ancestor}} references can be used to
interpolate object names into the statistics lines to add object and parent
names.
There are some parts missing from the patch. I want to hear comments first:
# Currently when setting a context variable from the REST API, the user is
required to PUT an object's context map. This runs the risk that the user will
accidentally lose an unrelated context value whilst trying to apply a statistic
context variable. We should add ConfiuredObject managed operations to allow a
context variable to be put/got/removed.
# Broker#resetStatistics should either be refactored so all statistics are
reset and have an analogous method on Virtualhost, or we should kill the
feature. I'm in favour of the latter.
# I killed {{statisticsReportingResetEnabled}} already but haven't added a
upgrader to remove the attribute value.
# This patch makes {{StatisticsCounter}} unnecessary. It should be replaced
with a simple AtomicLongs.
# Docs
> Broker should be able to write a periodic dump of statistics
>
>
> Key: QPID-7799
> URL: https://issues.apache.org/jira/browse/QPID-7799
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch
>
>
> To assist those running a service, the Broker should have the ability to
> write a periodic dump of ConiguredObject statistics to the log file. It
> should be possible to configure the statistics dumped at runtime and be
> configured on a per-category or per-object instance basis. Within a HA
>
[jira] [Assigned] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-7799: Assignee: Keith Wall > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[
https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187167#comment-16187167
]
Keith Wall commented on QPID-7799:
--
Patch is now reviewable.
It gives the Broker and Virtualhost the responsibility for periodically writing
user-specific model statistics to the log. Statistic reporting can be enabled
dynamically without the need for a Broker or Virtualhost restart. The
statistics that are reported are also modifiable on the fly.
The user controls the reported statistics using a context variable named in the
following form {{qpid..statisticsReportPattern}} which, as
normal, can come from the environment, the object itself or an ancestor. This
approach gives the flexibility for statistic reporting to be enabled category
class wide (e.g. all queues) or for a single object instance. The context
value is free text with placeholders to interpolate statistic values e.g.
{{messagesIn=$\{messagesIn\}}}. There's provision for
datetime/duration/byteunit formatting to help the readability of the report
{{bytessIn=$\{bytesIn:bytevalue\}}}. {{ancestor}} references can be used to
interpolate object names into the statistics lines to add object and parent
names.
There are some parts missing from the patch. I want to hear comments first:
# Currently when setting a context variable from the REST API, the user is
required to PUT an object's context map. This runs the risk that the user will
accidentally lose an unrelated context value whilst trying to apply a statistic
context variable. We should add ConfiuredObject managed operations to allow a
context variable to be put/got/removed.
# Broker#resetStatistics should either be refactored so all statistics are
reset and have an analogous method on Virtualhost, or we should kill the
feature. I'm in favour of the latter.
# I killed {{statisticsReportingResetEnabled}} already but haven't added a
upgrader to remove the attribute value.
# This patch makes {{StatisticsCounter}} unnecessary. It should be replaced
with a simple AtomicLongs.
# Docs
> Broker should be able to write a periodic dump of statistics
>
>
> Key: QPID-7799
> URL: https://issues.apache.org/jira/browse/QPID-7799
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch
>
>
> To assist those running a service, the Broker should have the ability to
> write a periodic dump of ConiguredObject statistics to the log file. It
> should be possible to configure the statistics dumped at runtime and be
> configured on a per-category or per-object instance basis. Within a HA
> group, the configuration applied to objects belonging to a virtualhost must
> survive a mastership change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7799: - Attachment: (was: 0001-QPID-7799-Java-Broker-Model-wide-statistics-reportin.patch) > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7799: - Attachment: 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7939) [Java Broker] update BDB JE dependency from 7.3.7 to 7.4.5
[ https://issues.apache.org/jira/browse/QPID-7939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187107#comment-16187107 ] ASF subversion and git services commented on QPID-7939: --- Commit 9d5a8254cbd26048f58740e1b59832a4bc91cd31 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=9d5a825 ] QPID-7939: [Java Broker] [BDB Store] Bump JE from 7.3.7 to 7.4.5 > [Java Broker] update BDB JE dependency from 7.3.7 to 7.4.5 > -- > > Key: QPID-7939 > URL: https://issues.apache.org/jira/browse/QPID-7939 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > > Synching with latest BDB JE release from Oracle. > http://docs.oracle.com/cd/E17277_02/html/changelog.html > No code or configuration changes. > Note that the Apache 2 License metadata is now included in the JE pom, so the > exclusions that were previously necessary can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
