[jira] [Created] (QPID-8045) [Broker-J] Refactor context variables

2017-11-21 Thread Lorenz Quack (JIRA)
Lorenz Quack created QPID-8045:
--

 Summary: [Broker-J] Refactor context variables
 Key: QPID-8045
 URL: https://issues.apache.org/jira/browse/QPID-8045
 Project: Qpid
  Issue Type: Improvement
  Components: Broker-J
Reporter: Lorenz Quack


Context variables are heavily used in Qpid Broker-J.
Over the years their implementation and use has grown organically.
Maybe it is time they are refactored.

Some reasons for considering a refactor:
 * boilerplate: Currently a context variable requires quite a lot of 
boilerplate code. A variable for the name and the {{\@ManagedContextDefault}} 
annotated default value, a {{\@DerivedAttribute}} annotated getter for the 
materialized value, a variable to hold the materialized value, the code to 
materialize the context variable.
 * inconsistency: Some context variables are materialized others aren't (i.e., 
change takes effect after restart vs immediately). The point of materialization 
is inconsistent (popular choices being {{onOpen}} and {{postResolve}}). Some 
expose the materialized value through a {{\@DerivedAttribute}} others do not. 
The names of the context variables are sometimes directly on the scattered 
around {{\@ManagedContextDefault}} sometimes on a separate variable.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8045) [Broker-J] Refactor context variables

2017-11-21 Thread Lorenz Quack (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lorenz Quack updated QPID-8045:
---
Attachment: QPID-8045_contextVars_WIP.tar.gz

This is an old attempt of mine at refactoring the context variables. The patch 
has not been updated in a while.

General approach I took:
* Declare a getter method on the interface and annotate it.
* The annotation carries the default value, the name, and a description.
* Annotation processing then auto-generates a subclass with a variable for the 
materialized value (the type can be deduced from the getter's return type), the 
implementation of the getter, and a postResolve to materialize the context 
variable.
* all code should be using the getter and not refer to the materialized value 
directly nor use {{getContextValue()}}. This is why I chose to annotate getter 
methods rather than the default value.

Some problems I encountered with the above approach and which have not been 
addressed yet in the patch:
* The developer written implementation (as opposed to the auto generated one) 
needs to have a stub for the method or be declare abstract.
* Since the materialization happens in the auto-generated subclasses the 
dev-written implementations are not fully functional. This is mainly a problem 
for testing. The tests would have to subclass the tests in question and mock 
the getters for the context variables.

> [Broker-J] Refactor context variables
> -
>
> Key: QPID-8045
> URL: https://issues.apache.org/jira/browse/QPID-8045
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Lorenz Quack
> Attachments: QPID-8045_contextVars_WIP.tar.gz
>
>
> Context variables are heavily used in Qpid Broker-J.
> Over the years their implementation and use has grown organically.
> Maybe it is time they are refactored.
> Some reasons for considering a refactor:
>  * boilerplate: Currently a context variable requires quite a lot of 
> boilerplate code. A variable for the name and the {{\@ManagedContextDefault}} 
> annotated default value, a {{\@DerivedAttribute}} annotated getter for the 
> materialized value, a variable to hold the materialized value, the code to 
> materialize the context variable.
>  * inconsistency: Some context variables are materialized others aren't 
> (i.e., change takes effect after restart vs immediately). The point of 
> materialization is inconsistent (popular choices being {{onOpen}} and 
> {{postResolve}}). Some expose the materialized value through a 
> {{\@DerivedAttribute}} others do not. The names of the context variables are 
> sometimes directly on the scattered around {{\@ManagedContextDefault}} 
> sometimes on a separate variable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8043) some broker SSL tests fail on Fedora 26

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260680#comment-16260680
 ] 

ASF subversion and git services commented on QPID-8043:
---

Commit b6371eaa694414f3fc37fe5a531b1a72b719cadb in qpid-cpp's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=b6371ea ]

QPID-8043: relax -e for availability checks, allows them to work and indicate 
whats happening.

Avoids spurious failure without indicated cause following changes in 
598ce6b3d06b8cc041013a6d3e86dcf8d9c432f2
if the tooling needed happens not to be available.


> some broker SSL tests fail on Fedora 26
> ---
>
> Key: QPID-8043
> URL: https://issues.apache.org/jira/browse/QPID-8043
> Project: Qpid
>  Issue Type: Test
>  Components: C++ Tests
>Affects Versions: qpid-cpp-1.36.0
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: qpid-cpp-1.37.0
>
>
> Some of the broker SSL tests fail on Fedora 26, because connection attempts 
> expected to succeed actually fail instead. The same tests pass on Fedora 25 
> as well as other OSes.
> This seems to be due to behaviour in newer 1.1.0 versions of OpenSSL, which 
> Python uses, and in turn this affects the clients used in the test. The 
> server uses NSS.
> After some sleuthing the issue was identified as OpenSSL saying the CA was 
> invalid, eventually narrowing down to it being due to 'unsupported 
> certificate purpose', and the CA not being marked as applicable for use as a 
> CA when printing out its purposes. The original cert generated in an NSS cert 
> db is marked for CA use, but this doesn't carry through to the exported PEM 
> based cert file. Comparing the CA cert used on the client side to some from 
> other components tests, the rest all have an extension indicating use for CA 
> purposes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8043) some broker SSL tests fail on Fedora 26

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260681#comment-16260681
 ] 

ASF subversion and git services commented on QPID-8043:
---

Commit 6370e1b232b9f62ce26505ebfaee7753f6e30d29 in qpid-cpp's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=6370e1b ]

QPID-8043: some tweaks made to the Travis config during debug, gets the ssl 
tests running


> some broker SSL tests fail on Fedora 26
> ---
>
> Key: QPID-8043
> URL: https://issues.apache.org/jira/browse/QPID-8043
> Project: Qpid
>  Issue Type: Test
>  Components: C++ Tests
>Affects Versions: qpid-cpp-1.36.0
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: qpid-cpp-1.37.0
>
>
> Some of the broker SSL tests fail on Fedora 26, because connection attempts 
> expected to succeed actually fail instead. The same tests pass on Fedora 25 
> as well as other OSes.
> This seems to be due to behaviour in newer 1.1.0 versions of OpenSSL, which 
> Python uses, and in turn this affects the clients used in the test. The 
> server uses NSS.
> After some sleuthing the issue was identified as OpenSSL saying the CA was 
> invalid, eventually narrowing down to it being due to 'unsupported 
> certificate purpose', and the CA not being marked as applicable for use as a 
> CA when printing out its purposes. The original cert generated in an NSS cert 
> db is marked for CA use, but this doesn't carry through to the exported PEM 
> based cert file. Comparing the CA cert used on the client side to some from 
> other components tests, the rest all have an extension indicating use for CA 
> purposes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8043) some broker SSL tests fail on Fedora 26

2017-11-21 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260689#comment-16260689
 ] 

Robbie Gemmell commented on QPID-8043:
--

Additional tweaks above were to handle issues found after changes related to 
this issue were made in 
http://git-wip-us.apache.org/repos/asf/qpid-cpp/commit/598ce6b3

> some broker SSL tests fail on Fedora 26
> ---
>
> Key: QPID-8043
> URL: https://issues.apache.org/jira/browse/QPID-8043
> Project: Qpid
>  Issue Type: Test
>  Components: C++ Tests
>Affects Versions: qpid-cpp-1.36.0
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: qpid-cpp-1.37.0
>
>
> Some of the broker SSL tests fail on Fedora 26, because connection attempts 
> expected to succeed actually fail instead. The same tests pass on Fedora 25 
> as well as other OSes.
> This seems to be due to behaviour in newer 1.1.0 versions of OpenSSL, which 
> Python uses, and in turn this affects the clients used in the test. The 
> server uses NSS.
> After some sleuthing the issue was identified as OpenSSL saying the CA was 
> invalid, eventually narrowing down to it being due to 'unsupported 
> certificate purpose', and the CA not being marked as applicable for use as a 
> CA when printing out its purposes. The original cert generated in an NSS cert 
> db is marked for CA use, but this doesn't carry through to the exported PEM 
> based cert file. Comparing the CA cert used on the client side to some from 
> other components tests, the rest all have an extension indicating use for CA 
> purposes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (DISPATCH-883) Router crashes when it processes management request for connections

2017-11-21 Thread Ganesh Murthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy reassigned DISPATCH-883:
--

Assignee: Ganesh Murthy

> Router crashes when it processes management request for connections
> ---
>
> Key: DISPATCH-883
> URL: https://issues.apache.org/jira/browse/DISPATCH-883
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
>
> Router crashes when attempting to service a management request. 
> When a python client sets its connections properties to a map, then as soon 
> as the router receives a management request for the connection info, the 
> router will crash.
> If the client sets its connections properties to a string, then there is no 
> crash.
> To reproduce:
> - start the router using tests/config-1/A.conf
> - modify the proton example server.py to set a properties map on line 37:
>   self.conn = event.container.connect(self.url, 
> properties={'client_identifier': 'policy_server'})
> - start the modified proton example: ./server.py -a 0.0.0.0:2/example
> - all is well until you do a  qdstat -b 0.0.0.0:2 -c
> backtrace:
> Thread 2 "qdrouterd" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffec03b700 (LWP 26782)]
> 0x76739766 in strlen () from /lib64/libc.so.6
> Missing separate debuginfos, use: dnf debuginfo-install 
> libffi-3.1-12.fc26.x86_64 libwebsockets-2.2.1-1.fc26.x86_64 
> openssl-libs-1.1.0f-7.fc26.x86_64 python2-libs-2.7.14-2.fc26.x86_64 
> zlib-1.2.11-2.fc26.x86_64
> (gdb) bt
> #0  0x76739766 in strlen () from /lib64/libc.so.6
> #1  0x77b6f805 in qd_compose_insert_string (field=0x7fffe005cb60, 
> value=0x0) at /home/eallen/workspace/qpid-dispatch/src/compose.c:444
> #2  0x77b90225 in qdr_connection_insert_column_CT (
> conn=0x7fffd400b620, col=12, body=0x7fffe005cb60, as_map=false)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:215
> #3  0x77b90300 in qdr_agent_write_connection_CT 
> (query=0x7fffe0077da0, 
> conn=0x7fffd400b620)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:242
> #4  0x77b90449 in qdra_connection_get_first_CT (core=0x92c090, 
> query=0x7fffe0077da0, offset=0)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:284
> #5  0x77b8c850 in qdrh_query_get_first_CT (core=0x92c090, 
> action=0x7fffe000dfa0, discard=false)
> at /home/eallen/workspace/qpid-dispatch/src/router_core/agent.c:455
> #6  0x77b9f86a in router_core_thread (arg=0x92c090)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/router_core_thread.c:83
> #7  0x774f836d in start_thread () from /lib64/libpthread.so.0
> #8  0x767b5e1f in clone () from /lib64/libc.so.6



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-884) Add schema property to allow configurable TLS protocol versions

2017-11-21 Thread Ganesh Murthy (JIRA)
Ganesh Murthy created DISPATCH-884:
--

 Summary: Add schema property to allow configurable TLS protocol 
versions
 Key: DISPATCH-884
 URL: https://issues.apache.org/jira/browse/DISPATCH-884
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Container
Affects Versions: 1.1.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
 Fix For: 1.1.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-8046) [Broker-J] Allow SASL mechanism PLAIN to not require initial response

2017-11-21 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-8046:


 Summary: [Broker-J] Allow SASL mechanism PLAIN to not require 
initial response
 Key: QPID-8046
 URL: https://issues.apache.org/jira/browse/QPID-8046
 Project: Qpid
  Issue Type: Bug
  Components: Broker-J
Affects Versions: qpid-java-broker-7.0.0
Reporter: Alex Rudyy
 Fix For: qpid-java-broker-7.0.1


The current implementation of SASL mechanism PLAIN requires from client to 
provide an initial response. PLAIN sasl mechanism implementation should request 
challenge if initial response is not provided. See RFC4616.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8046) [Broker-J] Allow SASL mechanisms PLAIN and XOAUTH2 to not require initial response

2017-11-21 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8046:
-
Summary: [Broker-J] Allow SASL mechanisms PLAIN and XOAUTH2 to not require 
initial response  (was: [Broker-J] Allow SASL mechanism PLAIN and OAUTH2 to not 
require initial response)

> [Broker-J] Allow SASL mechanisms PLAIN and XOAUTH2 to not require initial 
> response
> --
>
> Key: QPID-8046
> URL: https://issues.apache.org/jira/browse/QPID-8046
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
> Fix For: qpid-java-broker-7.0.1
>
>
> The current implementation of SASL mechanism PLAIN requires from client to 
> provide an initial response. PLAIN sasl mechanism implementation should 
> request challenge if initial response is not provided. See RFC4616.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8046) [Broker-J] Allow SASL mechanism PLAIN and OAUTH2 to not require initial response

2017-11-21 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8046:
-
Summary: [Broker-J] Allow SASL mechanism PLAIN and OAUTH2 to not require 
initial response  (was: [Broker-J] Allow SASL mechanism PLAIN to not require 
initial response)

> [Broker-J] Allow SASL mechanism PLAIN and OAUTH2 to not require initial 
> response
> 
>
> Key: QPID-8046
> URL: https://issues.apache.org/jira/browse/QPID-8046
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
> Fix For: qpid-java-broker-7.0.1
>
>
> The current implementation of SASL mechanism PLAIN requires from client to 
> provide an initial response. PLAIN sasl mechanism implementation should 
> request challenge if initial response is not provided. See RFC4616.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8046) [Broker-J] Allow SASL mechanisms PLAIN and XOAUTH2 to not require initial response

2017-11-21 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8046:
-
Description: The current implementation of SASL mechanisms PLAIN and 
XOAUTH2 require from client to provide an initial response. PLAIN and XOAUTH2 
sasl mechanism implementations should send challenge (empty bytes) if initial 
response is not provided. See RFC4616.  (was: The current implementation of 
SASL mechanism PLAIN requires from client to provide an initial response. PLAIN 
sasl mechanism implementation should request challenge if initial response is 
not provided. See RFC4616.)

> [Broker-J] Allow SASL mechanisms PLAIN and XOAUTH2 to not require initial 
> response
> --
>
> Key: QPID-8046
> URL: https://issues.apache.org/jira/browse/QPID-8046
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
> Fix For: qpid-java-broker-7.0.1
>
>
> The current implementation of SASL mechanisms PLAIN and XOAUTH2 require from 
> client to provide an initial response. PLAIN and XOAUTH2 sasl mechanism 
> implementations should send challenge (empty bytes) if initial response is 
> not provided. See RFC4616.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-8047) [Broker-J][AMQP 0-10] NPE on receiving session.detach for unknown session

2017-11-21 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-8047:


 Summary: [Broker-J][AMQP 0-10] NPE on receiving session.detach for 
unknown session
 Key: QPID-8047
 URL: https://issues.apache.org/jira/browse/QPID-8047
 Project: Qpid
  Issue Type: Bug
  Components: Broker-J
Affects Versions: qpid-java-broker-7.0.0
Reporter: Alex Rudyy


The following NPE is reported on receiving of detach for unknown session
{noformat}
java.lang.NullPointerException
at 
org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate.stopAllSubscriptions(ServerConnectionDelegate.java:377)
at 
org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate.sessionDetach(ServerConnectionDelegate.java:366)
at 
org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate.sessionDetach(ServerConnectionDelegate.java:52)
at 
org.apache.qpid.server.protocol.v0_10.transport.SessionDetach.dispatch(SessionDetach.java:90)
at 
org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate.control(ServerConnectionDelegate.java:97)
at 
org.apache.qpid.server.protocol.v0_10.ServerConnectionDelegate.control(ServerConnectionDelegate.java:52)
at 
org.apache.qpid.server.protocol.v0_10.transport.Method.delegate(Method.java:157)
at 
org.apache.qpid.server.protocol.v0_10.ServerConnection.received(ServerConnection.java:279)
at 
org.apache.qpid.server.protocol.v0_10.ServerAssembler.emit(ServerAssembler.java:178)
at 
org.apache.qpid.server.protocol.v0_10.ServerAssembler.assemble(ServerAssembler.java:256)
at 
org.apache.qpid.server.protocol.v0_10.ServerAssembler.frame(ServerAssembler.java:205)
at 
org.apache.qpid.server.protocol.v0_10.ServerAssembler.received(ServerAssembler.java:135)
at 
org.apache.qpid.server.protocol.v0_10.ServerAssembler.received(ServerAssembler.java:109)
at 
org.apache.qpid.server.protocol.v0_10.ServerInputHandler.received(ServerInputHandler.java:184)
at 
org.apache.qpid.server.protocol.v0_10.AMQPConnection_0_10Impl.lambda$received$1(AMQPConnection_0_10Impl.java:146)
at java.security.AccessController.doPrivileged(Native Method)
at 
org.apache.qpid.server.protocol.v0_10.AMQPConnection_0_10Impl.received(AMQPConnection_0_10Impl.java:141)
at 
org.apache.qpid.server.transport.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:134)
at 
org.apache.qpid.server.transport.NonBlockingConnection.processAmqpData(NonBlockingConnection.java:610)
at 
org.apache.qpid.server.transport.NonBlockingConnectionPlainDelegate.processData(NonBlockingConnectionPlainDelegate.java:58)
at 
org.apache.qpid.server.transport.NonBlockingConnection.doRead(NonBlockingConnection.java:496)
at 
org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:270)
at 
org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
at 
org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:570)
at 
org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:361)
at 
org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
at 
org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:528)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
at java.lang.Thread.run(Thread.java:745)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8041) [Messaging] Allow virtualhost to be specified when form an AMQP 0-10 connection

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-8041:
-
Fix Version/s: qpid-cpp-1.37.0

> [Messaging] Allow virtualhost to be specified when form an AMQP 0-10 
> connection
> ---
>
> Key: QPID-8041
> URL: https://issues.apache.org/jira/browse/QPID-8041
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Client
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-cpp-1.37.0
>
>
> When connecting to a peer that supports multiple virtual hosts (such as 
> Broker-J), the ability to specify the {{virtual-host}} field in the 
> {{connection.open}} control is required when establishing a connection to a 
> virtualhost that is not marked as the default.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-8041) [Messaging] Allow virtualhost to be specified when form an AMQP 0-10 connection

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-8041.
--
Resolution: Fixed

Gordon said he looked at and tried this previously, resolving.

> [Messaging] Allow virtualhost to be specified when form an AMQP 0-10 
> connection
> ---
>
> Key: QPID-8041
> URL: https://issues.apache.org/jira/browse/QPID-8041
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Client
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-cpp-1.37.0
>
>
> When connecting to a peer that supports multiple virtual hosts (such as 
> Broker-J), the ability to specify the {{virtual-host}} field in the 
> {{connection.open}} control is required when establishing a connection to a 
> virtualhost that is not marked as the default.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-7871) Batch file for Windows is missing from source distribution (qpid-tools 1.36.0)

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-7871:


Assignee: Robbie Gemmell  (was: Justin Ross)

> Batch file for Windows is missing from source distribution (qpid-tools 1.36.0)
> --
>
> Key: QPID-7871
> URL: https://issues.apache.org/jira/browse/QPID-7871
> Project: Qpid
>  Issue Type: Bug
>  Components: Python Client
>Affects Versions: qpid-cpp-1.36.0
>Reporter: Irina Boverman
>Assignee: Robbie Gemmell
>  Labels: patch
> Fix For: qpid-cpp-1.37.0
>
> Attachments: QPID-7871-Added-.bat-files.patch
>
>
> Reported here:
> http://qpid.2158936.n2.nabble.com/qpid-tools-on-PyPi-tc7665012.html#none



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7871) Batch file for Windows is missing from source distribution (qpid-tools 1.36.0)

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-7871.
--
Resolution: Fixed

Patch applied.

> Batch file for Windows is missing from source distribution (qpid-tools 1.36.0)
> --
>
> Key: QPID-7871
> URL: https://issues.apache.org/jira/browse/QPID-7871
> Project: Qpid
>  Issue Type: Bug
>  Components: Python Client
>Affects Versions: qpid-cpp-1.36.0
>Reporter: Irina Boverman
>Assignee: Robbie Gemmell
>  Labels: patch
> Fix For: qpid-cpp-1.37.0
>
> Attachments: QPID-7871-Added-.bat-files.patch
>
>
> Reported here:
> http://qpid.2158936.n2.nabble.com/qpid-tools-on-PyPi-tc7665012.html#none



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7871) Batch file for Windows is missing from source distribution (qpid-tools 1.36.0)

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260981#comment-16260981
 ] 

ASF subversion and git services commented on QPID-7871:
---

Commit 4bc94bbbaf1714d4c836e756ccb07fe3ff999ec4 in qpid-cpp's branch 
refs/heads/master from [~iboverma]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=4bc94bb ]

QPID-7871: always include .bat files in setup package


> Batch file for Windows is missing from source distribution (qpid-tools 1.36.0)
> --
>
> Key: QPID-7871
> URL: https://issues.apache.org/jira/browse/QPID-7871
> Project: Qpid
>  Issue Type: Bug
>  Components: Python Client
>Affects Versions: qpid-cpp-1.36.0
>Reporter: Irina Boverman
>Assignee: Justin Ross
>  Labels: patch
> Fix For: qpid-cpp-1.37.0
>
> Attachments: QPID-7871-Added-.bat-files.patch
>
>
> Reported here:
> http://qpid.2158936.n2.nabble.com/qpid-tools-on-PyPi-tc7665012.html#none



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7871) Batch file for Windows is missing from qpid-tools setup package

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-7871:
-
Summary: Batch file for Windows is missing from qpid-tools setup package  
(was: Batch file for Windows is missing from source distribution (qpid-tools 
1.36.0))

> Batch file for Windows is missing from qpid-tools setup package
> ---
>
> Key: QPID-7871
> URL: https://issues.apache.org/jira/browse/QPID-7871
> Project: Qpid
>  Issue Type: Bug
>  Components: Python Client
>Affects Versions: qpid-cpp-1.36.0
>Reporter: Irina Boverman
>Assignee: Robbie Gemmell
>  Labels: patch
> Fix For: qpid-cpp-1.37.0
>
> Attachments: QPID-7871-Added-.bat-files.patch
>
>
> Reported here:
> http://qpid.2158936.n2.nabble.com/qpid-tools-on-PyPi-tc7665012.html#none



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7999) Relocate distro-specific etc files

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-7999:
-
Fix Version/s: (was: qpid-cpp-1.37.0)
   qpid-cpp-1.38.0

> Relocate distro-specific etc files
> --
>
> Key: QPID-7999
> URL: https://issues.apache.org/jira/browse/QPID-7999
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Broker, C++ Client
>Reporter: Justin Ross
>Assignee: Justin Ross
> Fix For: qpid-cpp-1.38.0
>
>
> qpidd.in and qpidd-primary.in are Fedora-specific and ought to go in the 
> etc/fedora dir.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7051) Crash after reconnect with transactional session (with patch)

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-7051:
-
Fix Version/s: (was: qpid-cpp-1.37.0)
   qpid-cpp-1.38.0

> Crash after reconnect with transactional session (with patch)
> -
>
> Key: QPID-7051
> URL: https://issues.apache.org/jira/browse/QPID-7051
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: qpid-cpp-0.34, qpid-cpp-1.36.0
> Environment: Red Hat Enterprise Linux Server release 6.7 (Santiago)
> The broker is ActiveMQ 5.13.0.
> The protocol used in AMQP 1.0.
>Reporter: Håkan Johansson
>Assignee: Justin Ross
>  Labels: crash, patch
> Fix For: qpid-cpp-1.38.0
>
> Attachments: consumer.cc, producer.cc, qpid-7051.patch, qpid-cpp.patch
>
>
> I have a test program (see the "consumer.cc" attachment) that creates a 
> connection with "reconnect" enabled.
> It then creates a transactional session and a receiver to some queue from 
> that session.
> It then reads all messages from the queue and prints out their content.
> A sleep is used between each read to make the test possible.
> While the broker is down the program will try to reconnect to it.
> As soon as it succeeds with that the fetch call throws an exception because 
> the transaction has become invalid.
> The exception is caught and the read loop is broken out of.
> The test function then exits, causing the _Receiver_, _Session_, and 
> _Connection_ objects to be destructed.
> The crash happens while destructing the _Connection_ object.
> It took some digging, but I managed to find the reason for the crash.
> When the _Connection_ object is destructed it automatically destructs its 
> _ConnectionHandle_ object, which in turn destructs its _ConnectionContext_ 
> object. Nothing strange here.
> The _ConnectionContext_ destructor makes a call to its own _close_ method, 
> which tries to shut down all its sessions.
> The problem is that the session has been made invalid by the disconnect, 
> which causes the call to _syncLH_ to throw an exception,
> which is not caught anywhere, indirectly causing the _ConnectionContext_ 
> destructor to throw an exception. This is a big no-no in C++.
> A side effect of this is that the transport object is not closed before it is 
> destructed,
> which means that it is still listening for events. The crash happens when the 
> next pending event tries to use
> the destructed transport object.
> The solution, in my humble opinion, is to catch the exception throws by the 
> _syncLH_ call in the _ConnectionContext::close_ method.
> This way we can try to close all sessions even if one or more of them are 
> invalidated for some reason.
> The rest of the cleanup process will also be done properly.
> How to run the test program:
> * Compile both "producer.cc" and "consumer.cc". They both need to be linked 
> to the "qpidmessaging" library.
> * Run "producer" once. This will add ten messages to the "apa.bepa" queue on 
> the broker.
> * Start "consumer".
> * When the consumer starts to print out the messages, shut down and restart 
> the broker.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7863) qpidd-1.36 init script fails with "source: not found" on ubuntu

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-7863:
-
Fix Version/s: (was: qpid-cpp-1.37.0)
   qpid-cpp-1.38.0

> qpidd-1.36 init script fails with "source: not found" on ubuntu
> ---
>
> Key: QPID-7863
> URL: https://issues.apache.org/jira/browse/QPID-7863
> Project: Qpid
>  Issue Type: Bug
>  Components: Packaging
>Affects Versions: qpid-cpp-1.36.0
> Environment: Travis (Ubuntu Trusty)
>Reporter: Chris Richardson
>Assignee: Justin Ross
> Fix For: qpid-cpp-1.38.0
>
>
> While trying to install qpidd on Travis (Ubuntu Trusty) from the qpid/testing 
> ppa I'm getting the error
> /etc/init.d/qpidd: 52: /etc/init.d/qpidd: source: not found
> see https://travis-ci.org/fourceu/fourc-qpid-manager/jobs/254889450 line 660.
> I think this is because the init script is not compatible with Ubuntu (even 
> if the offending line were changed to use "." instead of "source", the 
> requested functions script would not exist).
> Could we please have an updated deb package with an Ubuntu init script? :)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8048) Qpid C++ 1.38.0 release tasks

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-8048:
-
Fix Version/s: (was: qpid-cpp-1.37.0)
   qpid-cpp-1.38.0

> Qpid C++ 1.38.0 release tasks
> -
>
> Key: QPID-8048
> URL: https://issues.apache.org/jira/browse/QPID-8048
> Project: Qpid
>  Issue Type: Task
>  Components: C++ Broker, C++ Client
>Reporter: Justin Ross
>Assignee: Robbie Gemmell
> Fix For: qpid-cpp-1.38.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-8048) Qpid C++ 1.38.0 release tasks

2017-11-21 Thread Robbie Gemmell (JIRA)
Robbie Gemmell created QPID-8048:


 Summary: Qpid C++ 1.38.0 release tasks
 Key: QPID-8048
 URL: https://issues.apache.org/jira/browse/QPID-8048
 Project: Qpid
  Issue Type: Task
  Components: C++ Broker, C++ Client
Reporter: Justin Ross
Assignee: Robbie Gemmell
 Fix For: qpid-cpp-1.37.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7920) Qpid C++ 1.37.0 release tasks

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261032#comment-16261032
 ] 

ASF subversion and git services commented on QPID-7920:
---

Commit 851e5b198f0f232a104046f593d157cb0256a969 in qpid-cpp's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=851e5b1 ]

QPID-7920: update notes and helper script for releases


> Qpid C++ 1.37.0 release tasks
> -
>
> Key: QPID-7920
> URL: https://issues.apache.org/jira/browse/QPID-7920
> Project: Qpid
>  Issue Type: Task
>  Components: C++ Broker, C++ Client
>Reporter: Justin Ross
>Assignee: Robbie Gemmell
> Fix For: qpid-cpp-1.37.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8038) [Broker-J][System Tests] Add protocol system test suites for AMQP 0-x

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261086#comment-16261086
 ] 

ASF subversion and git services commented on QPID-8038:
---

Commit c3a3f3a931df8969b2fec19f42dccc68eae9 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c3a3f3a ]

QPID-8038: [Broker-J][AMQP 1.0] Improve 0-8 protocol tests


> [Broker-J][System Tests] Add protocol system test suites for AMQP 0-x
> -
>
> Key: QPID-8038
> URL: https://issues.apache.org/jira/browse/QPID-8038
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J, Java Tests
>Reporter: Alex Rudyy
>
> We need a test frameworks which would allow creation of tests which would be 
> sending the AMQP 0-x performatives over TCP and receiving and asserting 
> broker responses.
> The framework should satisfy the following requirements:
> * It should allow running tests against other AMQP brokers
> * The framework should encapsulate starting/stopping of broker and queue 
> creation/deletion under special interface(s) which can be implemented by the 
> Broker developers in order to run tests against different Broker 
> implementations
> * Tests should be able to start and stop broker if required or configured
> * Tests should be able to generate AMQP performatives and assert received 
> peer's AMQP performatives
> * The framework should allow using other transport than TCP if required
> * The framework should be based on AMQP 0-x  implementations of Broker-J



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8046) [Broker-J] Allow SASL mechanisms PLAIN and XOAUTH2 to not require initial response

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261088#comment-16261088
 ] 

ASF subversion and git services commented on QPID-8046:
---

Commit 4eb2ea6dfdea353b115efa5389a0a060c052d777 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=4eb2ea6 ]

QPID-8046: [Broker-J] Allow SASL mechanisms PLAIN and XOAUTH2 to not require 
initial response


> [Broker-J] Allow SASL mechanisms PLAIN and XOAUTH2 to not require initial 
> response
> --
>
> Key: QPID-8046
> URL: https://issues.apache.org/jira/browse/QPID-8046
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
> Fix For: qpid-java-broker-7.0.1
>
>
> The current implementation of SASL mechanisms PLAIN and XOAUTH2 require from 
> client to provide an initial response. PLAIN and XOAUTH2 sasl mechanism 
> implementations should send challenge (empty bytes) if initial response is 
> not provided. See RFC4616.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1689) [cpp] exception thrown in handler can result in garbage exception from run()

2017-11-21 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1689.
-
Resolution: Fixed

> [cpp] exception thrown in handler can result in garbage exception from run()
> 
>
> Key: PROTON-1689
> URL: https://issues.apache.org/jira/browse/PROTON-1689
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: proton-c-0.18.1
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: proton-c-0.19.0
>
>
> Container is using a pointer to an out-of-scope exception message to 
> construct a new exception, resulting in garbage message or possible core dump.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8048) Qpid C++ 1.38.0 release tasks

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261117#comment-16261117
 ] 

ASF subversion and git services commented on QPID-8048:
---

Commit c191859fc2192903e6154207826945539c9d2adf in qpid-cpp's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=c191859 ]

QPID-8048, QPID-7920: update versions for 1.38.0-SNAPSHOT


> Qpid C++ 1.38.0 release tasks
> -
>
> Key: QPID-8048
> URL: https://issues.apache.org/jira/browse/QPID-8048
> Project: Qpid
>  Issue Type: Task
>  Components: C++ Broker, C++ Client
>Reporter: Justin Ross
>Assignee: Robbie Gemmell
> Fix For: qpid-cpp-1.38.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7920) Qpid C++ 1.37.0 release tasks

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261116#comment-16261116
 ] 

ASF subversion and git services commented on QPID-7920:
---

Commit 725ccbd954c14b92b577fb5c4250ef8fa709c7e1 in qpid-cpp's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=725ccbd ]

QPID-7920: update versions for 1.37.0-rc1


> Qpid C++ 1.37.0 release tasks
> -
>
> Key: QPID-7920
> URL: https://issues.apache.org/jira/browse/QPID-7920
> Project: Qpid
>  Issue Type: Task
>  Components: C++ Broker, C++ Client
>Reporter: Justin Ross
>Assignee: Robbie Gemmell
> Fix For: qpid-cpp-1.37.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7920) Qpid C++ 1.37.0 release tasks

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261118#comment-16261118
 ] 

ASF subversion and git services commented on QPID-7920:
---

Commit c191859fc2192903e6154207826945539c9d2adf in qpid-cpp's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=c191859 ]

QPID-8048, QPID-7920: update versions for 1.38.0-SNAPSHOT


> Qpid C++ 1.37.0 release tasks
> -
>
> Key: QPID-7920
> URL: https://issues.apache.org/jira/browse/QPID-7920
> Project: Qpid
>  Issue Type: Task
>  Components: C++ Broker, C++ Client
>Reporter: Justin Ross
>Assignee: Robbie Gemmell
> Fix For: qpid-cpp-1.37.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7821) Missing man pages

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-7821:
-
Fix Version/s: qpid-cpp-1.38.0

> Missing man pages
> -
>
> Key: QPID-7821
> URL: https://issues.apache.org/jira/browse/QPID-7821
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Documentation
>Affects Versions: qpid-cpp-1.36.0
>Reporter: Irina Boverman
>Priority: Minor
> Fix For: qpid-cpp-1.38.0
>
> Attachments: 0001-Added-man-pages.patch
>
>
> Debian distribution requires all binaries to have man pages. These do not:
> ../build.log:W: qpid-receive: binary-without-manpage usr/bin/qpid-receive
> ../build.log:W: qpid-send: binary-without-manpage usr/bin/qpid-send
> ../build.log:W: qmf-gen: binary-without-manpage usr/bin/qmf-gen
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-config
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-ha
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-printevents
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-queue-stats
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-route
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-stat
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-tool



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1636) Fairly Consistent (but intermittent) hangs in ruby-example-test/ruby-test-container using Travis CI

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261155#comment-16261155
 ] 

ASF subversion and git services commented on PROTON-1636:
-

Commit 235f0a8aa6238431cd90d5d03d9cbfcb94074b20 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=235f0a8 ]

PROTON-1636: Fix Container shut-down races

- Fixed races in Container shut-down via #stop or #auto_stop=true
- Refactor ConnectionDriver; decouple from MessagingHandler
- Fixes to example issues that showed up during the work


> Fairly Consistent (but intermittent) hangs in 
> ruby-example-test/ruby-test-container using Travis CI
> ---
>
> Key: PROTON-1636
> URL: https://issues.apache.org/jira/browse/PROTON-1636
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: Travis CI:
> Ubuntu 1404 with lots of changes
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
> Fix For: proton-c-0.19.0
>
>
> This is pretty annoying as it makes the build fail about 50% of the time for 
> me and so it looks like the change just made failed the build.
> {noformat}
>   Start 14: ruby-example-test
> 14: Test command: /home/travis/.rvm/rubies/ruby-2.4.1/bin/ruby 
> "example_test.rb" "-v"
> 14: Test timeout computed to be: 1500
> 14: Run options: -v --seed 7224
> 14: 
> 14: # Running:
> 14: 
> 14: ExampleTest#test_client_server = 0.30 s = .
> No output has been received in the last 10m0s, this potentially indicates a 
> stalled build or something wrong with the build itself.
> Check the details on how to adjust your build configuration on: 
> https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
> The build has been terminated
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1636) Fairly Consistent (but intermittent) hangs in ruby-example-test/ruby-test-container using Travis CI

2017-11-21 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1636.
-
Resolution: Fixed

> Fairly Consistent (but intermittent) hangs in 
> ruby-example-test/ruby-test-container using Travis CI
> ---
>
> Key: PROTON-1636
> URL: https://issues.apache.org/jira/browse/PROTON-1636
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: Travis CI:
> Ubuntu 1404 with lots of changes
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
> Fix For: proton-c-0.19.0
>
>
> This is pretty annoying as it makes the build fail about 50% of the time for 
> me and so it looks like the change just made failed the build.
> {noformat}
>   Start 14: ruby-example-test
> 14: Test command: /home/travis/.rvm/rubies/ruby-2.4.1/bin/ruby 
> "example_test.rb" "-v"
> 14: Test timeout computed to be: 1500
> 14: Run options: -v --seed 7224
> 14: 
> 14: # Running:
> 14: 
> 14: ExampleTest#test_client_server = 0.30 s = .
> No output has been received in the last 10m0s, this potentially indicates a 
> stalled build or something wrong with the build itself.
> Check the details on how to adjust your build configuration on: 
> https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
> The build has been terminated
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-883) Router crashes when it processes management request for connections

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261174#comment-16261174
 ] 

ASF subversion and git services commented on DISPATCH-883:
--

Commit b46e5de3def3b26ebe3cbb45d8c03cbe2e163598 in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=b46e5de ]

DISPATCH-883 - Prevent the router from crashing when the connection properties 
is not PN_STRING or PN_SYMBOL or PN_INTEGER. Also added a few system tests


> Router crashes when it processes management request for connections
> ---
>
> Key: DISPATCH-883
> URL: https://issues.apache.org/jira/browse/DISPATCH-883
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
>
> Router crashes when attempting to service a management request. 
> When a python client sets its connections properties to a map, then as soon 
> as the router receives a management request for the connection info, the 
> router will crash.
> If the client sets its connections properties to a string, then there is no 
> crash.
> To reproduce:
> - start the router using tests/config-1/A.conf
> - modify the proton example server.py to set a properties map on line 37:
>   self.conn = event.container.connect(self.url, 
> properties={'client_identifier': 'policy_server'})
> - start the modified proton example: ./server.py -a 0.0.0.0:2/example
> - all is well until you do a  qdstat -b 0.0.0.0:2 -c
> backtrace:
> Thread 2 "qdrouterd" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffec03b700 (LWP 26782)]
> 0x76739766 in strlen () from /lib64/libc.so.6
> Missing separate debuginfos, use: dnf debuginfo-install 
> libffi-3.1-12.fc26.x86_64 libwebsockets-2.2.1-1.fc26.x86_64 
> openssl-libs-1.1.0f-7.fc26.x86_64 python2-libs-2.7.14-2.fc26.x86_64 
> zlib-1.2.11-2.fc26.x86_64
> (gdb) bt
> #0  0x76739766 in strlen () from /lib64/libc.so.6
> #1  0x77b6f805 in qd_compose_insert_string (field=0x7fffe005cb60, 
> value=0x0) at /home/eallen/workspace/qpid-dispatch/src/compose.c:444
> #2  0x77b90225 in qdr_connection_insert_column_CT (
> conn=0x7fffd400b620, col=12, body=0x7fffe005cb60, as_map=false)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:215
> #3  0x77b90300 in qdr_agent_write_connection_CT 
> (query=0x7fffe0077da0, 
> conn=0x7fffd400b620)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:242
> #4  0x77b90449 in qdra_connection_get_first_CT (core=0x92c090, 
> query=0x7fffe0077da0, offset=0)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:284
> #5  0x77b8c850 in qdrh_query_get_first_CT (core=0x92c090, 
> action=0x7fffe000dfa0, discard=false)
> at /home/eallen/workspace/qpid-dispatch/src/router_core/agent.c:455
> #6  0x77b9f86a in router_core_thread (arg=0x92c090)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/router_core_thread.c:83
> #7  0x774f836d in start_thread () from /lib64/libpthread.so.0
> #8  0x767b5e1f in clone () from /lib64/libc.so.6



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7821) Missing man pages

2017-11-21 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-7821:
-
Affects Version/s: qpid-cpp-1.37.0

> Missing man pages
> -
>
> Key: QPID-7821
> URL: https://issues.apache.org/jira/browse/QPID-7821
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Documentation
>Affects Versions: qpid-cpp-1.36.0, qpid-cpp-1.37.0
>Reporter: Irina Boverman
>Priority: Minor
> Fix For: qpid-cpp-1.38.0
>
> Attachments: 0001-Added-man-pages.patch
>
>
> Debian distribution requires all binaries to have man pages. These do not:
> ../build.log:W: qpid-receive: binary-without-manpage usr/bin/qpid-receive
> ../build.log:W: qpid-send: binary-without-manpage usr/bin/qpid-send
> ../build.log:W: qmf-gen: binary-without-manpage usr/bin/qmf-gen
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-config
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-ha
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-printevents
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-queue-stats
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-route
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-stat
> ../build.log:W: qpid-tools: binary-without-manpage usr/bin/qpid-tool



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-883) Router crashes when it processes management request for connections

2017-11-21 Thread Ganesh Murthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-883.

   Resolution: Fixed
Fix Version/s: 1.1.0

The router recognizes only three data types in the connection properties

1. PN_SYMBOL
2. PN_STRING
3. PN_INTEGER

When a connection is created like this - 
{noformat}
self.conn = event.container.connect(self.url, properties= {'client_identifier': 
'policy_server'} 
{noformat}
the router sees a datatype of PN_BINARY which it does not service.

I added code so that the router does not crash when unsupported data types are 
passed in as connection properties.
Ernie, you will have to make the following change to have your code work

{noformat}
self.conn = event.container.connect(self.url, properties= 
{u'client_identifier': u'policy_server'} 
{noformat}
(notice the 'u' (unicode) in front of the client_identifier and policy_server


> Router crashes when it processes management request for connections
> ---
>
> Key: DISPATCH-883
> URL: https://issues.apache.org/jira/browse/DISPATCH-883
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> Router crashes when attempting to service a management request. 
> When a python client sets its connections properties to a map, then as soon 
> as the router receives a management request for the connection info, the 
> router will crash.
> If the client sets its connections properties to a string, then there is no 
> crash.
> To reproduce:
> - start the router using tests/config-1/A.conf
> - modify the proton example server.py to set a properties map on line 37:
>   self.conn = event.container.connect(self.url, 
> properties={'client_identifier': 'policy_server'})
> - start the modified proton example: ./server.py -a 0.0.0.0:2/example
> - all is well until you do a  qdstat -b 0.0.0.0:2 -c
> backtrace:
> Thread 2 "qdrouterd" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffec03b700 (LWP 26782)]
> 0x76739766 in strlen () from /lib64/libc.so.6
> Missing separate debuginfos, use: dnf debuginfo-install 
> libffi-3.1-12.fc26.x86_64 libwebsockets-2.2.1-1.fc26.x86_64 
> openssl-libs-1.1.0f-7.fc26.x86_64 python2-libs-2.7.14-2.fc26.x86_64 
> zlib-1.2.11-2.fc26.x86_64
> (gdb) bt
> #0  0x76739766 in strlen () from /lib64/libc.so.6
> #1  0x77b6f805 in qd_compose_insert_string (field=0x7fffe005cb60, 
> value=0x0) at /home/eallen/workspace/qpid-dispatch/src/compose.c:444
> #2  0x77b90225 in qdr_connection_insert_column_CT (
> conn=0x7fffd400b620, col=12, body=0x7fffe005cb60, as_map=false)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:215
> #3  0x77b90300 in qdr_agent_write_connection_CT 
> (query=0x7fffe0077da0, 
> conn=0x7fffd400b620)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:242
> #4  0x77b90449 in qdra_connection_get_first_CT (core=0x92c090, 
> query=0x7fffe0077da0, offset=0)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/agent_connection.c:284
> #5  0x77b8c850 in qdrh_query_get_first_CT (core=0x92c090, 
> action=0x7fffe000dfa0, discard=false)
> at /home/eallen/workspace/qpid-dispatch/src/router_core/agent.c:455
> #6  0x77b9f86a in router_core_thread (arg=0x92c090)
> at 
> /home/eallen/workspace/qpid-dispatch/src/router_core/router_core_thread.c:83
> #7  0x774f836d in start_thread () from /lib64/libpthread.so.0
> #8  0x767b5e1f in clone () from /lib64/libc.so.6



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPIDJMS-348) Be able to configure delay between retries in JmsRedeliveryPolicy

2017-11-21 Thread Riv (JIRA)
Riv created QPIDJMS-348:
---

 Summary: Be able to configure delay between retries in 
JmsRedeliveryPolicy
 Key: QPIDJMS-348
 URL: https://issues.apache.org/jira/browse/QPIDJMS-348
 Project: Qpid JMS
  Issue Type: Improvement
  Components: qpid-jms-client
Affects Versions: 0.27.0
Reporter: Riv


I am wondering if it would possible to get a redelivery delay between 
redelivery attempts. Similar to initialRedeliveryDelay in the redelivery policy 
in the ActiveMQ client: 
http://activemq.apache.org/message-redelivery-and-dlq-handling.html.

I've found that in practice the redeliveries all happen immediately before the 
system may be ready to handle it properly (a few seconds later).

Thanks :)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-348) Be able to configure delay between retries in JmsRedeliveryPolicy

2017-11-21 Thread Timothy Bish (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261317#comment-16261317
 ] 

Timothy Bish commented on QPIDJMS-348:
--

Redelivery for the AMQP JMS client is actually done on the broker side, the 
client does not control how fast the broker will redispatch those messages, in 
the case of ActiveMQ I think you would be able to control the rate via the 
broker redelivery plugin.

> Be able to configure delay between retries in JmsRedeliveryPolicy
> -
>
> Key: QPIDJMS-348
> URL: https://issues.apache.org/jira/browse/QPIDJMS-348
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.27.0
>Reporter: Riv
>
> I am wondering if it would possible to get a redelivery delay between 
> redelivery attempts. Similar to initialRedeliveryDelay in the redelivery 
> policy in the ActiveMQ client: 
> http://activemq.apache.org/message-redelivery-and-dlq-handling.html.
> I've found that in practice the redeliveries all happen immediately before 
> the system may be ready to handle it properly (a few seconds later).
> Thanks :)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (QPIDJMS-348) Be able to configure delay between retries in JmsRedeliveryPolicy

2017-11-21 Thread Timothy Bish (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish closed QPIDJMS-348.

Resolution: Not A Problem

> Be able to configure delay between retries in JmsRedeliveryPolicy
> -
>
> Key: QPIDJMS-348
> URL: https://issues.apache.org/jira/browse/QPIDJMS-348
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.27.0
>Reporter: Riv
>
> I am wondering if it would possible to get a redelivery delay between 
> redelivery attempts. Similar to initialRedeliveryDelay in the redelivery 
> policy in the ActiveMQ client: 
> http://activemq.apache.org/message-redelivery-and-dlq-handling.html.
> I've found that in practice the redeliveries all happen immediately before 
> the system may be ready to handle it properly (a few seconds later).
> Thanks :)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-885) Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, symbol, binary] for null input

2017-11-21 Thread Ganesh Murthy (JIRA)
Ganesh Murthy created DISPATCH-885:
--

 Summary: Modify qd_compose_insert_[string,symbol,binary] to add 
zero-length [string, symbol, binary] for null input
 Key: DISPATCH-885
 URL: https://issues.apache.org/jira/browse/DISPATCH-885
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Container
Affects Versions: 1.0.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
Priority: Minor
 Fix For: 1.1.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #223: DISPATCH-885 - Modified qd_compose_insert_[...

2017-11-21 Thread ganeshmurthy
GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/223

DISPATCH-885 - Modified qd_compose_insert_[string,symbol,binary] to a…

…dd zero-length [string, symbol, binary] for null input. This code also 
gets rid of the crashes when zero length strings are passed in

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-885

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #223


commit 342adebc6bde36330557a9f5f2cd94ef34c2b2f5
Author: Ganesh Murthy 
Date:   2017-11-21T21:39:35Z

DISPATCH-885 - Modified qd_compose_insert_[string,symbol,binary] to add 
zero-length [string, symbol, binary] for null input. This code also gets rid of 
the crashes when zero length strings are passed in




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-885) Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, symbol, binary] for null input

2017-11-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261526#comment-16261526
 ] 

ASF GitHub Bot commented on DISPATCH-885:
-

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/223

DISPATCH-885 - Modified qd_compose_insert_[string,symbol,binary] to a…

…dd zero-length [string, symbol, binary] for null input. This code also 
gets rid of the crashes when zero length strings are passed in

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-885

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #223


commit 342adebc6bde36330557a9f5f2cd94ef34c2b2f5
Author: Ganesh Murthy 
Date:   2017-11-21T21:39:35Z

DISPATCH-885 - Modified qd_compose_insert_[string,symbol,binary] to add 
zero-length [string, symbol, binary] for null input. This code also gets rid of 
the crashes when zero length strings are passed in




> Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, 
> symbol, binary] for null input
> --
>
> Key: DISPATCH-885
> URL: https://issues.apache.org/jira/browse/DISPATCH-885
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Minor
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1432) [go] Support marshaling and unmarshaling to/from the char AMQP type in message body

2017-11-21 Thread JIRA

[ 
https://issues.apache.org/jira/browse/PROTON-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261544#comment-16261544
 ] 

Jiri Daněk commented on PROTON-1432:


There is one small problem with the feature, that I can see. The following test 
fails

{code}
func TestFmtingOfAmqpChar(t *testing.T) {
r := rune(0x16b5)
ar := amqp.Char(r)

for _, ea := range [][]string {
{fmt.Sprintf("%c", r), fmt.Sprintf("%c", ar)},
{fmt.Sprintf("%x", r), fmt.Sprintf("%x", ar)}} {
if ea[0] != ea[1] {
t.Errorf("Expected `%s`, actual `%s`.", ea[0], 
ea[1])
}
}
}
{code}

{noformat}
--- FAIL: TestAmqpChar (0.00s)
shim_test.go:136: Expected `16b5`, actual `e19ab5`.
FAIL
FAILcommand-line-arguments  0.011s
{noformat}

This is caused by the {{String}} implementation in

{code}
func (c Char) String() string {
   return fmt.Sprintf("%c", c)
}
{code}

Formatting amqp.Char as %x does not format the rune, but the utf-8 encoded 
string containing the rune. The results of these two are different.

To fix this test, either removing the String method (not sure if that would 
break something else) or implementing custom 
https://golang.org/pkg/fmt/#Formatter should work.

> [go] Support marshaling and unmarshaling to/from the char AMQP type in 
> message body
> ---
>
> Key: PROTON-1432
> URL: https://issues.apache.org/jira/browse/PROTON-1432
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: go-binding
>Affects Versions: proton-c-0.18.0
>Reporter: Jiri Daněk
>Assignee: Alan Conway
>Priority: Minor
> Fix For: proton-c-0.19.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-8049) Non-free ICC profiles

2017-11-21 Thread Christopher Hoskin (JIRA)
Christopher Hoskin created QPID-8049:


 Summary: Non-free ICC profiles
 Key: QPID-8049
 URL: https://issues.apache.org/jira/browse/QPID-8049
 Project: Qpid
  Issue Type: Bug
  Components: Broker-J
Affects Versions: qpid-java-broker-7.0.0
Reporter: Christopher Hoskin
Priority: Minor


A number of images in ./doc/java-broker/src/docbkx/images/ have ICC profiles 
which are copyright Apple Inc. 2013-15 and are probably not Free Software (see 
the discussion at [1]).

find . -regextype posix-extended -iregex '.*\.(jpg|png|ico|tif)' -exec sh -c 
'identify -verbose "$0" | grep -i copyright && echo "$0"' {} \;
icc:copyright: Copyright Apple, Inc., 2013
./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
icc:copyright: Copyright Apple Inc., 2015
./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
icc:copyright: Copyright Apple Inc., 2014
./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png
icc:copyright: Copyright Apple Inc., 2014
./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png
icc:copyright: Copyright Apple Inc., 2015
./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png
icc:copyright: Copyright Apple, Inc., 2013
./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png
icc:copyright: Copyright Apple Inc., 2014
./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png
icc:copyright: Copyright Apple Inc., 2015
./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png

These non-Free ICC profiles can be removed with the commands:

convert -verbose -strip 
./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png +profile "icc" 
./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
convert -verbose -strip 
./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png 
+profile "icc" 
./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
convert -verbose -strip 
./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png +profile 
"icc" ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png 
convert -verbose -strip 
./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png +profile 
"icc" ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png 
convert -verbose -strip 
./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
+profile "icc" 
./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
convert -verbose -strip 
./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
+profile "icc" 
./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
convert -verbose -strip 
./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png +profile 
"icc" ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png 
convert -verbose -strip 
./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png +profile "icc" 
./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png 

[1] https://lists.debian.org/debian-devel/2014/05/msg00312.html

Thanks

Christopher Hoskin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-8050) CMake reports CMP0022

2017-11-21 Thread Chris Richardson (JIRA)
Chris Richardson created QPID-8050:
--

 Summary: CMake reports CMP0022
 Key: QPID-8050
 URL: https://issues.apache.org/jira/browse/QPID-8050
 Project: Qpid
  Issue Type: Improvement
Affects Versions: qpid-cpp-1.37.0
 Environment: Ubuntu 17, cmake version 3.9.1
Reporter: Chris Richardson
 Fix For: qpid-cpp-1.38.0


CMake output: 
{quote} CMake Deprecation Warning at CMakeLists.txt:138 (cmake_policy):
   The OLD behavior for policy CMP0022 will be removed from a future version
   of CMake.

   The cmake-policies(7) manual explains that the OLD behaviors of all
   policies are deprecated and that a policy should be set to OLD only under
   specific short-term circumstances.  Projects should be ported to the NEW
   behavior and not rely on setting a policy to OLD.{quote}

Cmake docs on the subject: https://cmake.org/cmake/help/v3.0/policy/CMP0022.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8049) Non-free ICC profiles

2017-11-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261625#comment-16261625
 ] 

ASF subversion and git services commented on QPID-8049:
---

Commit 612c2cb6c0857f3ca4344bbb47005d10dad156d8 in qpid-broker-j's branch 
refs/heads/master from [~godfrer]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=612c2cb ]

QPID-8049 : Strip ICC profiles with copyright from PNG images


> Non-free ICC profiles
> -
>
> Key: QPID-8049
> URL: https://issues.apache.org/jira/browse/QPID-8049
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Christopher Hoskin
>Priority: Minor
>
> A number of images in ./doc/java-broker/src/docbkx/images/ have ICC profiles 
> which are copyright Apple Inc. 2013-15 and are probably not Free Software 
> (see the discussion at [1]).
> find . -regextype posix-extended -iregex '.*\.(jpg|png|ico|tif)' -exec sh -c 
> 'identify -verbose "$0" | grep -i copyright && echo "$0"' {} \;
> icc:copyright: Copyright Apple, Inc., 2013
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png
> icc:copyright: Copyright Apple, Inc., 2013
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png
> These non-Free ICC profiles can be removed with the commands:
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png +profile "icc" 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png +profile "icc" 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png 
> [1] https://lists.debian.org/debian-devel/2014/05/msg00312.html
> Thanks
> Christopher Hoskin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8049) Non-free ICC profiles

2017-11-21 Thread Rob Godfrey (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261630#comment-16261630
 ] 

Rob Godfrey commented on QPID-8049:
---

Interesting - I admit (like most people I guess) I was completely unaware of 
these (copyrighted) profiles being injected into image files by the tools (in 
this case I assume screen capture) used to create images.  

Thanks for pointing this out, I have modified the files in accordance with the 
helpful instructions you gave above.

> Non-free ICC profiles
> -
>
> Key: QPID-8049
> URL: https://issues.apache.org/jira/browse/QPID-8049
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Christopher Hoskin
>Priority: Minor
>
> A number of images in ./doc/java-broker/src/docbkx/images/ have ICC profiles 
> which are copyright Apple Inc. 2013-15 and are probably not Free Software 
> (see the discussion at [1]).
> find . -regextype posix-extended -iregex '.*\.(jpg|png|ico|tif)' -exec sh -c 
> 'identify -verbose "$0" | grep -i copyright && echo "$0"' {} \;
> icc:copyright: Copyright Apple, Inc., 2013
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png
> icc:copyright: Copyright Apple, Inc., 2013
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png
> These non-Free ICC profiles can be removed with the commands:
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png +profile "icc" 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png +profile "icc" 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png 
> [1] https://lists.debian.org/debian-devel/2014/05/msg00312.html
> Thanks
> Christopher Hoskin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-8049) Non-free ICC profiles

2017-11-21 Thread Rob Godfrey (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey reassigned QPID-8049:
-

Assignee: Rob Godfrey

> Non-free ICC profiles
> -
>
> Key: QPID-8049
> URL: https://issues.apache.org/jira/browse/QPID-8049
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Christopher Hoskin
>Assignee: Rob Godfrey
>Priority: Minor
>
> A number of images in ./doc/java-broker/src/docbkx/images/ have ICC profiles 
> which are copyright Apple Inc. 2013-15 and are probably not Free Software 
> (see the discussion at [1]).
> find . -regextype posix-extended -iregex '.*\.(jpg|png|ico|tif)' -exec sh -c 
> 'identify -verbose "$0" | grep -i copyright && echo "$0"' {} \;
> icc:copyright: Copyright Apple, Inc., 2013
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png
> icc:copyright: Copyright Apple, Inc., 2013
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png
> These non-Free ICC profiles can be removed with the commands:
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png +profile "icc" 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png +profile "icc" 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png 
> [1] https://lists.debian.org/debian-devel/2014/05/msg00312.html
> Thanks
> Christopher Hoskin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8049) Non-free ICC profiles

2017-11-21 Thread Rob Godfrey (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-8049:
--
Status: Reviewable  (was: In Progress)

> Non-free ICC profiles
> -
>
> Key: QPID-8049
> URL: https://issues.apache.org/jira/browse/QPID-8049
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Christopher Hoskin
>Assignee: Rob Godfrey
>Priority: Minor
>
> A number of images in ./doc/java-broker/src/docbkx/images/ have ICC profiles 
> which are copyright Apple Inc. 2013-15 and are probably not Free Software 
> (see the discussion at [1]).
> find . -regextype posix-extended -iregex '.*\.(jpg|png|ico|tif)' -exec sh -c 
> 'identify -verbose "$0" | grep -i copyright && echo "$0"' {} \;
> icc:copyright: Copyright Apple, Inc., 2013
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png
> icc:copyright: Copyright Apple, Inc., 2013
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png
> icc:copyright: Copyright Apple Inc., 2014
> ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png
> icc:copyright: Copyright Apple Inc., 2015
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png
> These non-Free ICC profiles can be removed with the commands:
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png +profile "icc" 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-MBeans.png
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-InclusionRule.png
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-Add-Dialogue.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-Edit-Dialogue.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-MemoryLogger.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
> +profile "icc" 
> ./doc/java-broker/src/docbkx/images/Management-Web-Logging-FileLogger.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png +profile 
> "icc" ./doc/java-broker/src/docbkx/images/Management-Web-ContextVar.png 
> convert -verbose -strip 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png +profile "icc" 
> ./doc/java-broker/src/docbkx/images/JMX-Connect-Remote.png 
> [1] https://lists.debian.org/debian-devel/2014/05/msg00312.html
> Thanks
> Christopher Hoskin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1691) Memory leak when creating endpoint objects with a handler

2017-11-21 Thread Xin Chen (JIRA)
Xin Chen created PROTON-1691:


 Summary: Memory leak when creating endpoint objects with a handler
 Key: PROTON-1691
 URL: https://issues.apache.org/jira/browse/PROTON-1691
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: proton-c-0.18.1
 Environment: Reproduced on Windows but the code is not platform 
specific.
Reporter: Xin Chen


Using the Python binding, one can provide a handler when creating an Endpoint 
object (Connection/Session/Link). This handler object is set in the record 
context. In pn_###_finalize methods, the context is not cleared by calling 
pn_record_clear. This results in a _cadapter object leaking in Python process 
without any references. The fix is simply to call pn_record_clear before 
freeing the context. For example, in pn_link_finalize (line 1121 in engine.c),

+  pn_record_clear(link->context);
  pn_free(link->context);

With this fix the memory does not grow anymore with repeated link 
creation/closing. I only use a handler in link endpoint but I think this is 
needed for connection and session as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1692) External selectable does not work on Windows

2017-11-21 Thread Xin Chen (JIRA)
Xin Chen created PROTON-1692:


 Summary: External selectable does not work on Windows
 Key: PROTON-1692
 URL: https://issues.apache.org/jira/browse/PROTON-1692
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: proton-c-0.18.1
 Environment: Windows
Reporter: Xin Chen
 Attachments: proton-c.patch

In Python binding the built-in EventInjector does not work on Windows.
https://issues.apache.org/jira/browse/PROTON-1071

So I needed to implement one using a socket pair. I can set one socket as 
selectable on reactor. The on_selectable_init and on_selectable_readable events 
are filed once correctly when I trigger an event by sending a byte to the 
selectable socket. The problem is that the on_selectable_readable event is 
fired again without any triggering bytes. When i do a recv call on the socket, 
reactor hangs because there is no data available to read.

The problem happens because how selectables are implemented on Windows. The 
selectable handles are bound to the iocp and readable events are generated when 
the zero-byte read completes. This works for internal handles because 
pni_iocp_recv is called to get data and a new begin_zero_byte_read is issued 
after the recv call. For external selectable the recv call is made outside of 
protoc-c engine so no more read call is issued. in selector.c the 
triggered_list_head is not cleared and the event loop will fire the same event 
again. I didn't find a good way to fix this, and end up with a workaround by 
using pn_selector_update to generate a read loop on the socket. See the 
attached patch for the workaround.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org