[jira] [Created] (QPID-8073) Various documentation fixes

[Justin Ross (JIRA)]

Justin Ross created QPID-8073:
-

 Summary: Various documentation fixes
 Key: QPID-8073
 URL: https://issues.apache.org/jira/browse/QPID-8073
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Documentation
Reporter: Justin Ross
Assignee: Justin Ross
 Fix For: qpid-cpp-1.38.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8072) Remove the obsolete Ruby management API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319400#comment-16319400
 ] 

ASF subversion and git services commented on QPID-8072:
---

Commit 02b828af66b7fae052e29c30ac20bfd930a0ccfc in qpid-cpp's branch 
refs/heads/master from [~jr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=02b828a ]

QPID-8072: Remove the obsolete Ruby management API


> Remove the obsolete Ruby management API
> ---
>
> Key: QPID-8072
> URL: https://issues.apache.org/jira/browse/QPID-8072
> Project: Qpid
>  Issue Type: Task
>  Components: C++ Broker
>Reporter: Justin Ross
>Assignee: Justin Ross
> Fix For: qpid-cpp-1.38.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-8072) Remove the obsolete Ruby management API

[Justin Ross (JIRA)]

Justin Ross created QPID-8072:
-

 Summary: Remove the obsolete Ruby management API
 Key: QPID-8072
 URL: https://issues.apache.org/jira/browse/QPID-8072
 Project: Qpid
  Issue Type: Task
  Components: C++ Broker
Reporter: Justin Ross
Assignee: Justin Ross
 Fix For: qpid-cpp-1.38.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request 64645: authorization support for sasl delegation plugin

[Gordon Sim]

> On Dec. 15, 2017, 9:41 p.m., Chug Rolke wrote:
> > This seems like a decent approach for starters.
> > 
> > It may have an issue when multiple vhosts come in to the router on the same 
> > port. All of the connections then are sent to the same authServicePlugin 
> > authService port for authentication and authz. In the current policy scheme 
> > the policy is decided later when the AMQP Open frame's hostname field is 
> > used as the name of the vhost policy. Then the user name is looked up in 
> > that vhost policy section.
> 
> Gordon Sim wrote:
> The vhost name can be sent in the sasl-init frame which allows the actual 
> auth service to determine which 'realm' to authenticate against. At present 
> in the plugin this is always taken from configuration, however it could be 
> taken from what the client sends.
> 
> Chug Rolke wrote:
> It could. Adding the sasl-init hostname sounds like a worthy addition 
> precisely for the realm spec and the authentication.
> 
> Qpid and AMQP.Net Lite clients have gone through some effort to pass the 
> TLS Server Name Indication (SNI) through to the AMQP Open hostname. The 
> clients would need to add support to ensure that the SNI hostname makes it 
> into sasl-init properly. Having three sources of 'hostname' (external-ssl, 
> sasl-init, AMQP Open) is not ideal but is manageable.

At present proton doesn't actually read the hostname from sasl-init, so that 
needs to be exposed before we can pass it through (where a specific value is 
not set though config).


- Gordon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64645/#review193976
---


On Dec. 20, 2017, 5:40 p.m., Gordon Sim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64645/
> ---
> 
> (Updated Dec. 20, 2017, 5:40 p.m.)
> 
> 
> Review request for qpid, Chug Rolke, Ganesh Murthy, and Ted Ross.
> 
> 
> Bugs: DISPATCH-901
> https://issues.apache.org/jira/browse/DISPATCH-901
> 
> 
> Repository: qpid-dispatch
> 
> 
> Description
> ---
> 
> If the client specifies its desire for the ADDRESS-AUTHZ capacbility, the 
> authorization service, if it supports this, will return a set of permissions 
> in the properties of the open frame. The properties will have an 
> address-authz key, whose value is a map of address (or wildcard pattern) to 
> an array of permissions. The only permissions recognised at present by this 
> patch are 'send' and 'recv'.
> 
> 
> Diffs
> -
> 
>   src/policy.c 22cc79f 
>   src/remote_sasl.c e3c969b 
>   tests/CMakeLists.txt 0c6454c 
>   tests/authservice.py PRE-CREATION 
>   tests/system_tests_authz_service_plugin.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64645/diff/4/
> 
> 
> Testing
> ---
> 
> Added new systems tests using proton python based dummy auth service.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>

[jira] [Commented] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

[Alan Conway (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319072#comment-16319072
 ] 

Alan Conway commented on PROTON-1738:
-

Attached patch partially fixes the 2.0.0 issues, but there are still 
problems.It has not been fully tested. I'm leaving on vacation so can't finish 
this now, will finish on return unless somebody else wants to.

> [ruby-binding] incompatible with ruby 2.0.0
> ---
>
> Key: PROTON-1738
> URL: https://issues.apache.org/jira/browse/PROTON-1738
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.19.0
> Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 
> (upstream/master)
> Author: Alan Conway 
> Date:   Thu Jan 4 12:47:25 2018 -0500
> PROTON-1706: fix compiler warnings in windows c examples
>Reporter: Jiri Daněk
>Assignee: Alan Conway
> Fix For: proton-c-0.20.0
>
> Attachments: 0001-WIP-Fix-for-issues-on-ruby-2.0.0.patch
>
>
> {noformat}
> $ ctest -VV -R ruby-example-test
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Test project /home/jdanek/Work/repos/qpid-proton/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 13
> Start 13: ruby-example-test
> 13: Test command: 
> /nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
> "/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
> 

[jira] [Updated] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway updated PROTON-1738:

Attachment: 0001-WIP-Fix-for-issues-on-ruby-2.0.0.patch

> [ruby-binding] incompatible with ruby 2.0.0
> ---
>
> Key: PROTON-1738
> URL: https://issues.apache.org/jira/browse/PROTON-1738
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.19.0
> Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 
> (upstream/master)
> Author: Alan Conway 
> Date:   Thu Jan 4 12:47:25 2018 -0500
> PROTON-1706: fix compiler warnings in windows c examples
>Reporter: Jiri Daněk
>Assignee: Alan Conway
> Fix For: proton-c-0.20.0
>
> Attachments: 0001-WIP-Fix-for-issues-on-ruby-2.0.0.patch
>
>
> {noformat}
> $ ctest -VV -R ruby-example-test
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Test project /home/jdanek/Work/repos/qpid-proton/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 13
> Start 13: ruby-example-test
> 13: Test command: 
> /nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
> "/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
> "PATH=/nix/store/pgwzcwz3v13dm193iys78xajrxf7m9yq-include-what-you-use-0.8/bin:/nix/store/x9p1z5z22z59x88h7ap09s0f79w50nj0-krb5-1.15.2-dev/bin:/nix/store/0gpszn41jk1fdw98q1jdm7n4z271m303-krb5-1.15.2/bin:/nix/store/xmbal41hbh2z82jz7pgjgxkba9malcvf-gss-1.0.3/bin:/nix/store/qs68njxs4awvjaqf2yw89x8bnb2jwl2a-pkg-config-0.29.2/bin:/nix/store/bd1qnp2y4mni2jsr7yqfy45q5wj9q4wz-util-linux-2.31-bin/bin:/nix/store/s03sh263lrxnz8dp9d81is9xwrs67ay9-openssl-1.0.2n-bin/bin:/nix/store/0frzwaf62yrbs0ni6043sllk8ac7db1l-cmake-3.9.6/bin:/nix/store/q03ccdnb7i7za2q66gx8b3mii293i6cg-ninja-1.8.2/bin:/nix/store/2sb5s8wj4s6awvfd4rn82297g2fhr18d-gcc-wrapper-7.2.0/bin:/nix/store/gkasrgaqw2riqc8ck8hh3a9k06cqaqrd-gcc-7.2.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/m5s6hd02nlfywi9n3yrgrx3fa8kgp9jd-binutils-wrapper-2.28.1/bin:/nix/store/kcdiibhpjrbpash3r1bvj2ncv4rwr3sm-binutils-2.28.1/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/h5m0g1agfcyc2d5lql0n8z6fls261rnn-go-1.9.2/bin:/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin:/nix/store/10lvqls7vl68blvvv42g36bh5rjbwkmk-gdb-8.0.1/bin:/nix/store/11wq1ncfb8za0mnnficcizd53p1md2y7-swig-3.0.12/bin:/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin:/nix/store/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin:/nix/store/n7l459d0f28lmdirr1wlzkdi7151jhqk-patchelf-0.9/bin:/nix/store/q7p8jaiymb1k4n44l31xdm753j79h7l5-paxctl-0.9/bin:/nix/store/4cqv0dm94h2sm0xpcqi6h8z6bnxqqlna-gcc-wrapper-6.4.0/bin:/nix/store/d88s1v28v11j2jxshqdvqms6h0pvp8aw-gcc-6.4.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/n2p15qg4lxgq0xkfrgqqfgpwkmd3295d-findutils-4.6.0/bin:/nix/store/ajiwrzg6nz9xpifr91wp14cy8al7s4df-diffutils-3.6/bin:/nix/store/n5rsq2cxj7lp4gynkvqrp0xkf78f1ni6-gnused-4.4/bin:/nix/store/nwpv4sxayci7jkjq7fid8hwz6ig5xjzi-gnugrep-3.1/bin:/nix/store/w1cddj0qc3ximvpwrn28rig7wq99ajd7-gawk-4.2.0/bin:/nix/store/7iw6c6nx7spzsp92pqq5qnd7d8jvbdl8-gnutar-1.30/bin:/nix/store/qk11lqm8fz9hpk1682gyf3x51wwasj3z-gzip-1.8/bin:/nix/store/mi9vmy5nwc4ma33jz6ihrdhh1r6izzv6-bzip2-1.0.6.0.1-bin/bin:/nix/store/92cdms75qnqh3hf39wbxra60bxdah9mq-gnumake-4.2.1/bin:/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin:/nix/store/irwrb341fpqd2lj22j13ffsxcjhayv1m-patch-2.7.5/bin:/nix/store/8fy4c90a0cj1mw2xibvv5k6b0rxx6b09-xz-5.2.3-bin/bin:/home/jdanek/bin:/run/wrappers/bin:/etc/per-user-pkgs/jdanek/bin:/home/jdanek/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin:/home/jdanek/Work/repos/qpid-proton/build/proton-c/bindings/ruby:/home/jdanek/Work/repos/qpid-proton/build/proton-c"
>  
> 

[jira] [Closed] (PROTON-1718) (Proton-J) Custom Sasl

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell closed PROTON-1718.
--
Resolution: Done

> (Proton-J) Custom Sasl
> --
>
> Key: PROTON-1718
> URL: https://issues.apache.org/jira/browse/PROTON-1718
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: proton-j-0.24.0
>Reporter: Tim Taylor
>  Labels: features
>
> I would like to be able to provide a custom SASL implementation for Proton-j 
> to use instead of being forced to use the default SaslImpl.java 
> implementation.
> Ideally, code like below would be possible
> private class CustomSasl implements org.apache.qpid.proton.engine.Sasl
> {
> ...
> }
> ...
> ...
> //transport.sasl(...) saves the provided sasl implementation and uses it 
> internally
> Sasl sasl = transport.sasl(new CustomSasl());
> Do you currently have a workaround that would allow me to use Proton-J this 
> way?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Issue Comment Deleted] (PROTON-1736) add a SASL listener to allow relevant processing as frames arrive

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated PROTON-1736:
---
Comment: was deleted

(was: Github user gemmellr commented on the issue:

https://github.com/apache/qpid-proton-j/pull/13
  
For completeness, a different change was made via 
https://issues.apache.org/jira/browse/PROTON-1736 in commit 
17cef9ace9a7c75901d517f951ae1d4610819436. 
)

> add a SASL listener to allow relevant processing as frames arrive
> -
>
> Key: PROTON-1736
> URL: https://issues.apache.org/jira/browse/PROTON-1736
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: proton-j-0.24.0
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: proton-j-0.25.0
>
>
> The engine Sasl API in proton-j requires you be able to inspect its state to 
> decide what SASL handling to undertake and when while you are processing the 
> Transport. It would be helpful to be able to register a listener such that as 
> frames of interest arrive the relevant processing can be performed more 
> easily. This could simplify the Sasl object usage in general, but in 
> particular allow its use it with the 'reactor' where the IO handling being 
> generally hidden largely precludes using the API as intended.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1718) (Proton-J) Custom Sasl

[Tim Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318874#comment-16318874
 ] 

Tim Taylor commented on PROTON-1718:


Great! Thanks again for your help with this!

> (Proton-J) Custom Sasl
> --
>
> Key: PROTON-1718
> URL: https://issues.apache.org/jira/browse/PROTON-1718
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: proton-j-0.24.0
>Reporter: Tim Taylor
>  Labels: features
>
> I would like to be able to provide a custom SASL implementation for Proton-j 
> to use instead of being forced to use the default SaslImpl.java 
> implementation.
> Ideally, code like below would be possible
> private class CustomSasl implements org.apache.qpid.proton.engine.Sasl
> {
> ...
> }
> ...
> ...
> //transport.sasl(...) saves the provided sasl implementation and uses it 
> internally
> Sasl sasl = transport.sasl(new CustomSasl());
> Do you currently have a workaround that would allow me to use Proton-J this 
> way?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1736) add a SASL listener to allow relevant processing as frames arrive

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318869#comment-16318869
 ] 

ASF GitHub Bot commented on PROTON-1736:


Github user gemmellr commented on the issue:

https://github.com/apache/qpid-proton-j/pull/13
  
For completeness, a different change was made via 
https://issues.apache.org/jira/browse/PROTON-1736 in commit 
17cef9ace9a7c75901d517f951ae1d4610819436. 


> add a SASL listener to allow relevant processing as frames arrive
> -
>
> Key: PROTON-1736
> URL: https://issues.apache.org/jira/browse/PROTON-1736
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: proton-j-0.24.0
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: proton-j-0.25.0
>
>
> The engine Sasl API in proton-j requires you be able to inspect its state to 
> decide what SASL handling to undertake and when while you are processing the 
> Transport. It would be helpful to be able to register a listener such that as 
> frames of interest arrive the relevant processing can be performed more 
> easily. This could simplify the Sasl object usage in general, but in 
> particular allow its use it with the 'reactor' where the IO handling being 
> generally hidden largely precludes using the API as intended.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton-j issue #13: Added API to Transport interface to allow custom sa...

[gemmellr]

Github user gemmellr commented on the issue:

https://github.com/apache/qpid-proton-j/pull/13
  
For completeness, a different change was made via 
https://issues.apache.org/jira/browse/PROTON-1736 in commit 
17cef9ace9a7c75901d517f951ae1d4610819436. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1718) (Proton-J) Custom Sasl

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318865#comment-16318865
 ] 

Robbie Gemmell commented on PROTON-1718:


Glad to hear it works for you. I'll close this out now.

In terms of release, there is a request/issue from one of your colleagues that 
I want to look at first and then I'll aim to put a release out, which would 
make it by the start of next week (release votes need a few days) most likely. 
You can follow the progress via the users list, see 
http://qpid.apache.org/discussion.html. 

> (Proton-J) Custom Sasl
> --
>
> Key: PROTON-1718
> URL: https://issues.apache.org/jira/browse/PROTON-1718
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: proton-j-0.24.0
>Reporter: Tim Taylor
>  Labels: features
>
> I would like to be able to provide a custom SASL implementation for Proton-j 
> to use instead of being forced to use the default SaslImpl.java 
> implementation.
> Ideally, code like below would be possible
> private class CustomSasl implements org.apache.qpid.proton.engine.Sasl
> {
> ...
> }
> ...
> ...
> //transport.sasl(...) saves the provided sasl implementation and uses it 
> internally
> Sasl sasl = transport.sasl(new CustomSasl());
> Do you currently have a workaround that would allow me to use Proton-J this 
> way?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1737) Expose set/get for maxFrameSize in the Connection.Open performative

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318858#comment-16318858
 ] 

Robbie Gemmell commented on PROTON-1737:


The frame size details are already configurable/accessible on the Transport. 
However, I don't believe its possible to use the setter within the 'reactor' 
due to how it uses the transport before it becomes visible to user code. Adding 
an option setter/getter to the ReactorOptions is probably the nicest way to 
enable the functionality for that case, I'll give it a look tomorrow.

> Expose set/get for maxFrameSize in the Connection.Open performative
> ---
>
> Key: PROTON-1737
> URL: https://issues.apache.org/jira/browse/PROTON-1737
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: proton-j-0.24.0
>Reporter: Sreeram Garlapati
>Priority: Minor
> Fix For: proton-j-future
>
>
> For Microsoft Azure EventHubs service - we need the below properties to 
> enable some of our scenarios:
> Connection.setMaxFrameSize() & 
> Connection.getMaxFrameSize() 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-907) cannot set address phase via qdmanage tool

[Ken Giusti (JIRA)]

Ken Giusti created DISPATCH-907:
---

 Summary: cannot set address phase via qdmanage tool
 Key: DISPATCH-907
 URL: https://issues.apache.org/jira/browse/DISPATCH-907
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Tools
Affects Versions: 1.0.0
Reporter: Ken Giusti
 Fix For: 1.1.0


Attempting to configure a router address via qdmanage fails to set the value of 
the phase attributes:

$ qdmanage create --type "org.apache.qpid.dispatch.router.config.address" 
pattern="a.b.#" ingressPhase=5 egressPhase=6

{
  "name": null, 
  "pattern": "a.b.#", 
  "prefix": null, 
  "ingressPhase": 0,   <--- should be 5
  "waypoint": false, 
  "distribution": "balanced", 
  "type": "org.apache.qpid.dispatch.router.config.address", 
  "identity": "35", 
  "egressPhase": 0  <--- should be 6

This is due to qdmanage sending all attribute values as *string* types even in 
the case where the schema defines them as integer types.  This means qdmanage 
cannot be used to manage any integer type attribute.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPIDIT-97) Release qpid-interop-test 0.1.0

[Kim van der Riet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPIDIT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kim van der Riet resolved QPIDIT-97.

Resolution: Fixed

> Release qpid-interop-test 0.1.0
> ---
>
> Key: QPIDIT-97
> URL: https://issues.apache.org/jira/browse/QPIDIT-97
> Project: Apache QPID Interoperability Test Suite
>  Issue Type: Task
>Reporter: Kim van der Riet
>Assignee: Kim van der Riet
> Fix For: 0.1.0
>
>
> Release qpid-interop-test version 0.1.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (QPID-8064) [Broker-J] FileKeyStore should validate java keystore content to make sure that private key is present

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318655#comment-16318655
 ] 

Keith Wall edited comment on QPID-8064 at 1/9/18 4:19 PM:
--

I am not sure if this should be a responsibility of the keystore or a 
responsibility of the port.  Maybe the port should validate that it has the 
necessary key material for it to function.  It would also need to keep in the 
mind the work of QPID-7567.  Also see QPID-7879.


was (Author: k-wall):
I am not sure if this should be a responsibility of the keystore or a 
responsibility of the port.  Maybe the port should validate that it has the 
necessary key material for it to function.  It would also need to keep in the 
mind the work of QPID-7567.

> [Broker-J] FileKeyStore should validate java keystore content to make sure 
> that private key is present
> --
>
> Key: QPID-8064
> URL: https://issues.apache.org/jira/browse/QPID-8064
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: Future
>
>
> Currently Broker-J does not issue any error or warning when private key is 
> missed in java keystore (i.e., truststore is provided instead of keystore). 
> We should add a validation for the private key and deny keystore creation (or 
> recovery) if private key is not present. 
> When keystore without private key is configured, an attempt to make TLS 
> fails, but the root cause of the failure is difficult to debug. Even when 
> java debug logging is enabled (-Djavax.net.debug=all) the logs for the 
> handshake failure are confusing: "fatal error: 40: no cipher suites in 
> common", for example
> {noformat}
> HttpManagement-HTTP-392, READ: TLSv1 Handshake, length = 224
> *** ClientHello, TLSv1.2
> RandomCookie:  GMT: -1512757423 bytes = { 141, 10, 192, 6, 218, 230, 103, 
> 203, 46, 231, 80, 160, 40, 21, 47, 125, 0, 149, 138, 74, 65, 251, 5, 165, 
> 194, 45, 196, 236 }
> Session ID:  {}
> Cipher Suites: [Unknown 0xaa:0xaa, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, 
> TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_DHE_RSA_WITH_AES_128_GCM_SHA256, 
> TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, 
> TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, Unknown 0xcc:0xa9, Unknown 0xcc:0xa8, 
> Unknown 0xcc:0x14, Unknown 0xcc:0x13, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, 
> TLS_DHE_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, 
> TLS_DHE_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_128_GCM_SHA256, 
> TLS_RSA_WITH_AES_256_GCM_SHA384, TLS_RSA_WITH_AES_128_CBC_SHA, 
> TLS_RSA_WITH_AES_256_CBC_SHA, SSL_RSA_WITH_3DES_EDE_CBC_SHA]
> Compression Methods:  { 0 }
> Unsupported extension type_10794, data:
> Extension renegotiation_info, renegotiated_connection: 
> Extension server_name, server_name: [type=host_name (0), 
> value=abcd24p9390.abc.ef.g1234567.net]
> Unsupported extension type_23, data:
> Unsupported extension type_35, data:
> Extension signature_algorithms, signature_algorithms: SHA256withECDSA, 
> Unknown (hash:0x8, signature:0x4), SHA256withRSA, SHA384withECDSA, Unknown 
> (hash:0x8, signature:0x5), SHA384withRSA, Unknown (hash:0x8, signature:0x6), 
> SHA512withRSA, SHA1withRSA
> Unsupported extension status_request, data: 01:00:00:00:00
> Unsupported extension type_18, data:
> Unsupported extension type_16, data: 00:0c:02:68:32:08:68:74:74:70:2f:31:2e:31
> Unsupported extension type_30032, data:
> Extension ec_point_formats, formats: [uncompressed]
> Extension elliptic_curves, curve names: {unknown curve 56026, unknown curve 
> 29, secp256r1, secp384r1}
> Unsupported extension type_23130, data: 00
> ***
> [read] MD5 and SHA1 hashes:  len = 224
> : 01 00 00 DC 03 03 A6 D5   27 51 8D 0A C0 06 DA E6  'Q..
> 0010: 67 CB 2E E7 50 A0 28 15   2F 7D 00 95 8A 4A 41 FB  g...P.(./JA.
> 0020: 05 A5 C2 2D C4 EC 00 00   26 AA AA C0 2B C0 2F 00  ...-&...+./.
> 0030: 9E C0 2C C0 30 CC A9 CC   A8 CC 14 CC 13 C0 13 00  ..,.0...
> 0040: 33 C0 14 00 39 00 9C 00   9D 00 2F 00 35 00 0A 01  3...9./.5...
> 0050: 00 00 8D 2A 2A 00 00 FF   01 00 01 00 00 00 00 24  ...**..$
> 0060: 00 22 00 00 1F 76 73 69   6E 32 34 70 39 33 39 30  ."...abcd24p9390
> 0070: 2E 73 76 72 2E 75 73 2E   6A 70 6D 63 68 61 73 65  .abc.ef.g1234567
> 0080: 2E 6E 65 74 00 17 00 00   00 23 00 00 00 0D 00 14  .net.#..
> 0090: 00 12 04 03 08 04 04 01   05 03 08 05 05 01 08 06  
> 00A0: 06 01 02 01 00 05 00 05   01 00 00 00 00 00 12 00  
> 00B0: 00 00 10 00 0E 00 0C 02   68 32 08 68 74 74 70 2F  h2.http/
> 00C0: 31 2E 31 75 50 00 00 00   0B 00 02 01 00 00 0A 00  1.1uP...
> 00D0: 0A 00 08 

[jira] [Updated] (QPID-8044) [JMS AMQP 0-x] Address minor packaging issues raised during 6.3.0 vote

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8044:
-
Status: Reviewable  (was: In Progress)

> [JMS AMQP 0-x] Address minor packaging issues raised during 6.3.0 vote
> --
>
> Key: QPID-8044
> URL: https://issues.apache.org/jira/browse/QPID-8044
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-client-0-x-6.3.1
>
>
> Robbie raised the following during the 6.3.0 vote:
> > Comments:
> > -The NOTICE file in the source release archive says Apache Qpid Java
> > and should be updated going forward.
> > -The slf4j-api details in the binary archive NOTICE can be removed
> > going forward as its covered by the details in the LICENCE file
> > already.
> > -The directories in all the archives dont match their file names (sans
> > extension), which seems like it was the intended name, e.g
> > apache-qpid-jms-0-x-6.3.0-src isn't aligned with
> > apache-qpid-jms-amqp-0-x-6.3.0-src.tar.gz



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-8064) [Broker-J] FileKeyStore should validate java keystore content to make sure that private key is present

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8064:
-
Affects Version/s: qpid-java-6.0.8
   qpid-java-broker-7.0.0
   qpid-java-6.1.5

> [Broker-J] FileKeyStore should validate java keystore content to make sure 
> that private key is present
> --
>
> Key: QPID-8064
> URL: https://issues.apache.org/jira/browse/QPID-8064
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: Future
>
>
> Currently Broker-J does not issue any error or warning when private key is 
> missed in java keystore (i.e., truststore is provided instead of keystore). 
> We should add a validation for the private key and deny keystore creation (or 
> recovery) if private key is not present. 
> When keystore without private key is configured, an attempt to make TLS 
> fails, but the root cause of the failure is difficult to debug. Even when 
> java debug logging is enabled (-Djavax.net.debug=all) the logs for the 
> handshake failure are confusing: "fatal error: 40: no cipher suites in 
> common", for example
> {noformat}
> HttpManagement-HTTP-392, READ: TLSv1 Handshake, length = 224
> *** ClientHello, TLSv1.2
> RandomCookie:  GMT: -1512757423 bytes = { 141, 10, 192, 6, 218, 230, 103, 
> 203, 46, 231, 80, 160, 40, 21, 47, 125, 0, 149, 138, 74, 65, 251, 5, 165, 
> 194, 45, 196, 236 }
> Session ID:  {}
> Cipher Suites: [Unknown 0xaa:0xaa, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, 
> TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_DHE_RSA_WITH_AES_128_GCM_SHA256, 
> TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, 
> TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, Unknown 0xcc:0xa9, Unknown 0xcc:0xa8, 
> Unknown 0xcc:0x14, Unknown 0xcc:0x13, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, 
> TLS_DHE_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, 
> TLS_DHE_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_128_GCM_SHA256, 
> TLS_RSA_WITH_AES_256_GCM_SHA384, TLS_RSA_WITH_AES_128_CBC_SHA, 
> TLS_RSA_WITH_AES_256_CBC_SHA, SSL_RSA_WITH_3DES_EDE_CBC_SHA]
> Compression Methods:  { 0 }
> Unsupported extension type_10794, data:
> Extension renegotiation_info, renegotiated_connection: 
> Extension server_name, server_name: [type=host_name (0), 
> value=abcd24p9390.abc.ef.g1234567.net]
> Unsupported extension type_23, data:
> Unsupported extension type_35, data:
> Extension signature_algorithms, signature_algorithms: SHA256withECDSA, 
> Unknown (hash:0x8, signature:0x4), SHA256withRSA, SHA384withECDSA, Unknown 
> (hash:0x8, signature:0x5), SHA384withRSA, Unknown (hash:0x8, signature:0x6), 
> SHA512withRSA, SHA1withRSA
> Unsupported extension status_request, data: 01:00:00:00:00
> Unsupported extension type_18, data:
> Unsupported extension type_16, data: 00:0c:02:68:32:08:68:74:74:70:2f:31:2e:31
> Unsupported extension type_30032, data:
> Extension ec_point_formats, formats: [uncompressed]
> Extension elliptic_curves, curve names: {unknown curve 56026, unknown curve 
> 29, secp256r1, secp384r1}
> Unsupported extension type_23130, data: 00
> ***
> [read] MD5 and SHA1 hashes:  len = 224
> : 01 00 00 DC 03 03 A6 D5   27 51 8D 0A C0 06 DA E6  'Q..
> 0010: 67 CB 2E E7 50 A0 28 15   2F 7D 00 95 8A 4A 41 FB  g...P.(./JA.
> 0020: 05 A5 C2 2D C4 EC 00 00   26 AA AA C0 2B C0 2F 00  ...-&...+./.
> 0030: 9E C0 2C C0 30 CC A9 CC   A8 CC 14 CC 13 C0 13 00  ..,.0...
> 0040: 33 C0 14 00 39 00 9C 00   9D 00 2F 00 35 00 0A 01  3...9./.5...
> 0050: 00 00 8D 2A 2A 00 00 FF   01 00 01 00 00 00 00 24  ...**..$
> 0060: 00 22 00 00 1F 76 73 69   6E 32 34 70 39 33 39 30  ."...abcd24p9390
> 0070: 2E 73 76 72 2E 75 73 2E   6A 70 6D 63 68 61 73 65  .abc.ef.g1234567
> 0080: 2E 6E 65 74 00 17 00 00   00 23 00 00 00 0D 00 14  .net.#..
> 0090: 00 12 04 03 08 04 04 01   05 03 08 05 05 01 08 06  
> 00A0: 06 01 02 01 00 05 00 05   01 00 00 00 00 00 12 00  
> 00B0: 00 00 10 00 0E 00 0C 02   68 32 08 68 74 74 70 2F  h2.http/
> 00C0: 31 2E 31 75 50 00 00 00   0B 00 02 01 00 00 0A 00  1.1uP...
> 00D0: 0A 00 08 DA DA 00 1D 00   17 00 18 5A 5A 00 01 00  ...ZZ...
> %% Initialized:  [Session-37, SSL_NULL_WITH_NULL_NULL]
> HttpManagement-HTTP-392, fatal error: 40: no cipher suites in common
> javax.net.ssl.SSLHandshakeException: no cipher suites in common
> %% Invalidated:  [Session-37, SSL_NULL_WITH_NULL_NULL]
> HttpManagement-HTTP-392, SEND TLSv1.2 ALERT:  fatal, description = 
> handshake_failure
> HttpManagement-HTTP-392, WRITE: TLSv1.2 Alert, length = 2
> HttpManagement-HTTP-392, fatal: engine already closed.  

[jira] [Updated] (QPID-8064) [Broker-J] FileKeyStore should validate java keystore content to make sure that private key is present

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8064:
-
Fix Version/s: (was: qpid-java-6.1.5)
   (was: qpid-java-6.0.8)
   (was: qpid-java-broker-7.0.0)
   Future

> [Broker-J] FileKeyStore should validate java keystore content to make sure 
> that private key is present
> --
>
> Key: QPID-8064
> URL: https://issues.apache.org/jira/browse/QPID-8064
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: Future
>
>
> Currently Broker-J does not issue any error or warning when private key is 
> missed in java keystore (i.e., truststore is provided instead of keystore). 
> We should add a validation for the private key and deny keystore creation (or 
> recovery) if private key is not present. 
> When keystore without private key is configured, an attempt to make TLS 
> fails, but the root cause of the failure is difficult to debug. Even when 
> java debug logging is enabled (-Djavax.net.debug=all) the logs for the 
> handshake failure are confusing: "fatal error: 40: no cipher suites in 
> common", for example
> {noformat}
> HttpManagement-HTTP-392, READ: TLSv1 Handshake, length = 224
> *** ClientHello, TLSv1.2
> RandomCookie:  GMT: -1512757423 bytes = { 141, 10, 192, 6, 218, 230, 103, 
> 203, 46, 231, 80, 160, 40, 21, 47, 125, 0, 149, 138, 74, 65, 251, 5, 165, 
> 194, 45, 196, 236 }
> Session ID:  {}
> Cipher Suites: [Unknown 0xaa:0xaa, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, 
> TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_DHE_RSA_WITH_AES_128_GCM_SHA256, 
> TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, 
> TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, Unknown 0xcc:0xa9, Unknown 0xcc:0xa8, 
> Unknown 0xcc:0x14, Unknown 0xcc:0x13, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, 
> TLS_DHE_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, 
> TLS_DHE_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_128_GCM_SHA256, 
> TLS_RSA_WITH_AES_256_GCM_SHA384, TLS_RSA_WITH_AES_128_CBC_SHA, 
> TLS_RSA_WITH_AES_256_CBC_SHA, SSL_RSA_WITH_3DES_EDE_CBC_SHA]
> Compression Methods:  { 0 }
> Unsupported extension type_10794, data:
> Extension renegotiation_info, renegotiated_connection: 
> Extension server_name, server_name: [type=host_name (0), 
> value=abcd24p9390.abc.ef.g1234567.net]
> Unsupported extension type_23, data:
> Unsupported extension type_35, data:
> Extension signature_algorithms, signature_algorithms: SHA256withECDSA, 
> Unknown (hash:0x8, signature:0x4), SHA256withRSA, SHA384withECDSA, Unknown 
> (hash:0x8, signature:0x5), SHA384withRSA, Unknown (hash:0x8, signature:0x6), 
> SHA512withRSA, SHA1withRSA
> Unsupported extension status_request, data: 01:00:00:00:00
> Unsupported extension type_18, data:
> Unsupported extension type_16, data: 00:0c:02:68:32:08:68:74:74:70:2f:31:2e:31
> Unsupported extension type_30032, data:
> Extension ec_point_formats, formats: [uncompressed]
> Extension elliptic_curves, curve names: {unknown curve 56026, unknown curve 
> 29, secp256r1, secp384r1}
> Unsupported extension type_23130, data: 00
> ***
> [read] MD5 and SHA1 hashes:  len = 224
> : 01 00 00 DC 03 03 A6 D5   27 51 8D 0A C0 06 DA E6  'Q..
> 0010: 67 CB 2E E7 50 A0 28 15   2F 7D 00 95 8A 4A 41 FB  g...P.(./JA.
> 0020: 05 A5 C2 2D C4 EC 00 00   26 AA AA C0 2B C0 2F 00  ...-&...+./.
> 0030: 9E C0 2C C0 30 CC A9 CC   A8 CC 14 CC 13 C0 13 00  ..,.0...
> 0040: 33 C0 14 00 39 00 9C 00   9D 00 2F 00 35 00 0A 01  3...9./.5...
> 0050: 00 00 8D 2A 2A 00 00 FF   01 00 01 00 00 00 00 24  ...**..$
> 0060: 00 22 00 00 1F 76 73 69   6E 32 34 70 39 33 39 30  ."...abcd24p9390
> 0070: 2E 73 76 72 2E 75 73 2E   6A 70 6D 63 68 61 73 65  .abc.ef.g1234567
> 0080: 2E 6E 65 74 00 17 00 00   00 23 00 00 00 0D 00 14  .net.#..
> 0090: 00 12 04 03 08 04 04 01   05 03 08 05 05 01 08 06  
> 00A0: 06 01 02 01 00 05 00 05   01 00 00 00 00 00 12 00  
> 00B0: 00 00 10 00 0E 00 0C 02   68 32 08 68 74 74 70 2F  h2.http/
> 00C0: 31 2E 31 75 50 00 00 00   0B 00 02 01 00 00 0A 00  1.1uP...
> 00D0: 0A 00 08 DA DA 00 1D 00   17 00 18 5A 5A 00 01 00  ...ZZ...
> %% Initialized:  [Session-37, SSL_NULL_WITH_NULL_NULL]
> HttpManagement-HTTP-392, fatal error: 40: no cipher suites in common
> javax.net.ssl.SSLHandshakeException: no cipher suites in common
> %% Invalidated:  [Session-37, SSL_NULL_WITH_NULL_NULL]
> HttpManagement-HTTP-392, SEND TLSv1.2 ALERT:  fatal, description = 
> handshake_failure
> HttpManagement-HTTP-392, WRITE: TLSv1.2 Alert, length = 2
> 

[jira] [Commented] (QPID-8064) [Broker-J] FileKeyStore should validate java keystore content to make sure that private key is present

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318655#comment-16318655
 ] 

Keith Wall commented on QPID-8064:
--

I am not sure if this should be a responsibility of the keystore or a 
responsibility of the port.  Maybe the port should validate that it has the 
necessary key material for it to function.  It would also need to keep in the 
mind the work of QPID-7567.

> [Broker-J] FileKeyStore should validate java keystore content to make sure 
> that private key is present
> --
>
> Key: QPID-8064
> URL: https://issues.apache.org/jira/browse/QPID-8064
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>
>
> Currently Broker-J does not issue any error or warning when private key is 
> missed in java keystore (i.e., truststore is provided instead of keystore). 
> We should add a validation for the private key and deny keystore creation (or 
> recovery) if private key is not present. 
> When keystore without private key is configured, an attempt to make TLS 
> fails, but the root cause of the failure is difficult to debug. Even when 
> java debug logging is enabled (-Djavax.net.debug=all) the logs for the 
> handshake failure are confusing: "fatal error: 40: no cipher suites in 
> common", for example
> {noformat}
> HttpManagement-HTTP-392, READ: TLSv1 Handshake, length = 224
> *** ClientHello, TLSv1.2
> RandomCookie:  GMT: -1512757423 bytes = { 141, 10, 192, 6, 218, 230, 103, 
> 203, 46, 231, 80, 160, 40, 21, 47, 125, 0, 149, 138, 74, 65, 251, 5, 165, 
> 194, 45, 196, 236 }
> Session ID:  {}
> Cipher Suites: [Unknown 0xaa:0xaa, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, 
> TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_DHE_RSA_WITH_AES_128_GCM_SHA256, 
> TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, 
> TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, Unknown 0xcc:0xa9, Unknown 0xcc:0xa8, 
> Unknown 0xcc:0x14, Unknown 0xcc:0x13, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, 
> TLS_DHE_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, 
> TLS_DHE_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_128_GCM_SHA256, 
> TLS_RSA_WITH_AES_256_GCM_SHA384, TLS_RSA_WITH_AES_128_CBC_SHA, 
> TLS_RSA_WITH_AES_256_CBC_SHA, SSL_RSA_WITH_3DES_EDE_CBC_SHA]
> Compression Methods:  { 0 }
> Unsupported extension type_10794, data:
> Extension renegotiation_info, renegotiated_connection: 
> Extension server_name, server_name: [type=host_name (0), 
> value=abcd24p9390.abc.ef.g1234567.net]
> Unsupported extension type_23, data:
> Unsupported extension type_35, data:
> Extension signature_algorithms, signature_algorithms: SHA256withECDSA, 
> Unknown (hash:0x8, signature:0x4), SHA256withRSA, SHA384withECDSA, Unknown 
> (hash:0x8, signature:0x5), SHA384withRSA, Unknown (hash:0x8, signature:0x6), 
> SHA512withRSA, SHA1withRSA
> Unsupported extension status_request, data: 01:00:00:00:00
> Unsupported extension type_18, data:
> Unsupported extension type_16, data: 00:0c:02:68:32:08:68:74:74:70:2f:31:2e:31
> Unsupported extension type_30032, data:
> Extension ec_point_formats, formats: [uncompressed]
> Extension elliptic_curves, curve names: {unknown curve 56026, unknown curve 
> 29, secp256r1, secp384r1}
> Unsupported extension type_23130, data: 00
> ***
> [read] MD5 and SHA1 hashes:  len = 224
> : 01 00 00 DC 03 03 A6 D5   27 51 8D 0A C0 06 DA E6  'Q..
> 0010: 67 CB 2E E7 50 A0 28 15   2F 7D 00 95 8A 4A 41 FB  g...P.(./JA.
> 0020: 05 A5 C2 2D C4 EC 00 00   26 AA AA C0 2B C0 2F 00  ...-&...+./.
> 0030: 9E C0 2C C0 30 CC A9 CC   A8 CC 14 CC 13 C0 13 00  ..,.0...
> 0040: 33 C0 14 00 39 00 9C 00   9D 00 2F 00 35 00 0A 01  3...9./.5...
> 0050: 00 00 8D 2A 2A 00 00 FF   01 00 01 00 00 00 00 24  ...**..$
> 0060: 00 22 00 00 1F 76 73 69   6E 32 34 70 39 33 39 30  ."...abcd24p9390
> 0070: 2E 73 76 72 2E 75 73 2E   6A 70 6D 63 68 61 73 65  .abc.ef.g1234567
> 0080: 2E 6E 65 74 00 17 00 00   00 23 00 00 00 0D 00 14  .net.#..
> 0090: 00 12 04 03 08 04 04 01   05 03 08 05 05 01 08 06  
> 00A0: 06 01 02 01 00 05 00 05   01 00 00 00 00 00 12 00  
> 00B0: 00 00 10 00 0E 00 0C 02   68 32 08 68 74 74 70 2F  h2.http/
> 00C0: 31 2E 31 75 50 00 00 00   0B 00 02 01 00 00 0A 00  1.1uP...
> 00D0: 0A 00 08 DA DA 00 1D 00   17 00 18 5A 5A 00 01 00  ...ZZ...
> %% Initialized:  [Session-37, SSL_NULL_WITH_NULL_NULL]
> HttpManagement-HTTP-392, fatal error: 40: no cipher suites in common
> javax.net.ssl.SSLHandshakeException: no cipher suites in common
> %% Invalidated:  [Session-37, SSL_NULL_WITH_NULL_NULL]
> HttpManagement-HTTP-392, SEND TLSv1.2 ALERT:  fatal, description 

[jira] [Commented] (QPID-8066) [Broker-J] Virtual host logger rules are left over in configuration store after deletion of virtual host logger on provided virtual host

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318648#comment-16318648
 ] 

Keith Wall commented on QPID-8066:
--

I'm guessing from the description that this wouldn't happen for a JSON 
configuration store, as that store is hierarchal in nature. Agree lets 
investigate with tentative fix for v7.0.1.

> [Broker-J] Virtual host logger rules are left over in configuration store 
> after deletion of virtual host logger on provided virtual host
> 
>
> Key: QPID-8066
> URL: https://issues.apache.org/jira/browse/QPID-8066
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7, 
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0, 
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
>
> Virtual host logger rules are left over in configuration store after deletion 
> of virtual host logger on provided virtual host. On restart of VHN or Broker, 
> virtual host recovery fails with IllegalArgumentException as the one below:
> {noformat}
> java.lang.IllegalArgumentException: Recovered configured object record 
> BDBConfiguredObjectRecord [id=8e9c5547-c41b-4443-9333-48dac61f3b40, 
> type=VirtualHostLogInclusionRule, name=test, parents={}] has no recorded 
> parents and is not a valid child type [[interface 
> org.apache.qpid.server.model.VirtualHost, interface 
> org.apache.qpid.server.model.RemoteReplicationNode]] for the root 
> BDBVirtualHostNodeImplWithAccessChecking 
> [id=591aa6d9-c2e0-474c-a0a9-86eb14bc3c6a, name=bdb, 
> storePath=/home/alex/.qpid-7.1.0-SNAPSHOT/bdb/config]
> at 
> org.apache.qpid.server.store.GenericRecoverer.resolveDiscontinuity(GenericRecoverer.java:119)
> at 
> org.apache.qpid.server.store.GenericRecoverer.performRecover(GenericRecoverer.java:90)
> at 
> org.apache.qpid.server.store.GenericRecoverer.access$000(GenericRecoverer.java:41)
> at 
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:59)
> at 
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:55)
> at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
> at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
> at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.run(TaskExecutorImpl.java:190)
> at 
> org.apache.qpid.server.store.GenericRecoverer.recover(GenericRecoverer.java:54)
> at 
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.recover(VirtualHostStoreUpgraderAndRecoverer.java:1085)
> at 
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.upgradeAndRecover(VirtualHostStoreUpgraderAndRecoverer.java:1058)
> at 
> org.apache.qpid.server.virtualhostnode.AbstractStandardVirtualHostNode.activate(AbstractStandardVirtualHostNode.java:91)
> at 
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2634)
> at 
> 

[jira] [Updated] (QPID-8066) [Broker-J] Virtual host logger rules are left over in configuration store after deletion of virtual host logger on provided virtual host

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8066:
-
Fix Version/s: qpid-java-broker-7.1.0
   qpid-java-broker-7.0.1

> [Broker-J] Virtual host logger rules are left over in configuration store 
> after deletion of virtual host logger on provided virtual host
> 
>
> Key: QPID-8066
> URL: https://issues.apache.org/jira/browse/QPID-8066
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7, 
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0, 
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
>
> Virtual host logger rules are left over in configuration store after deletion 
> of virtual host logger on provided virtual host. On restart of VHN or Broker, 
> virtual host recovery fails with IllegalArgumentException as the one below:
> {noformat}
> java.lang.IllegalArgumentException: Recovered configured object record 
> BDBConfiguredObjectRecord [id=8e9c5547-c41b-4443-9333-48dac61f3b40, 
> type=VirtualHostLogInclusionRule, name=test, parents={}] has no recorded 
> parents and is not a valid child type [[interface 
> org.apache.qpid.server.model.VirtualHost, interface 
> org.apache.qpid.server.model.RemoteReplicationNode]] for the root 
> BDBVirtualHostNodeImplWithAccessChecking 
> [id=591aa6d9-c2e0-474c-a0a9-86eb14bc3c6a, name=bdb, 
> storePath=/home/alex/.qpid-7.1.0-SNAPSHOT/bdb/config]
> at 
> org.apache.qpid.server.store.GenericRecoverer.resolveDiscontinuity(GenericRecoverer.java:119)
> at 
> org.apache.qpid.server.store.GenericRecoverer.performRecover(GenericRecoverer.java:90)
> at 
> org.apache.qpid.server.store.GenericRecoverer.access$000(GenericRecoverer.java:41)
> at 
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:59)
> at 
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:55)
> at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
> at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
> at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.run(TaskExecutorImpl.java:190)
> at 
> org.apache.qpid.server.store.GenericRecoverer.recover(GenericRecoverer.java:54)
> at 
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.recover(VirtualHostStoreUpgraderAndRecoverer.java:1085)
> at 
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.upgradeAndRecover(VirtualHostStoreUpgraderAndRecoverer.java:1058)
> at 
> org.apache.qpid.server.virtualhostnode.AbstractStandardVirtualHostNode.activate(AbstractStandardVirtualHostNode.java:91)
> at 
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at 
> org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2634)
> at 
> com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1237)
> at 
> 

[jira] [Closed] (QPID-8069) [Qpid JMS AMQP 0-x] An establishment of connection blocks for 30 seconds on TLS handshake failure

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall closed QPID-8069.

Resolution: Won't Fix

> [Qpid JMS AMQP 0-x] An establishment of connection blocks for 30 seconds on 
> TLS handshake failure
> -
>
> Key: QPID-8069
> URL: https://issues.apache.org/jira/browse/QPID-8069
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Alex Rudyy
>
> AMQTimeoutException is reported after waiting for "maximum state wait time", 
> when TLS hand shake fails.
> The stack traces like below are reported
> {noformat}
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection 
> Connection(27):amqp://guest:@clientid/?brokerlist='tcp://localhost:46879?trust_store='/tmp/test-profiles/test_resources/ssl/java_client_truststore.jks'_store_password=''='true''
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection AMQP version 0-9-1
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.p.AMQProtocolSession Using 
> ProtocolVersion for Session:0-91
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.h.ClientMethodDispatcherImpl New 
> Method Dispatcher:AMQProtocolSession[null]
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection Connecting with 
> ProtocolHandler Version:0-91
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnectionDelegate_8_0 
> Connecting to 
> broker:tcp://localhost:46879?trust_store='/tmp/test-profiles/test_resources/ssl/java_client_truststore.jks'_store_password=''='true'
> 2018-01-04 21:59:33,961 DEBUG [main] o.a.q.t.n.i.IoNetworkTransport Socket 
> options SO_RCVBUF : 65535, SO_SNDBUF : 65535, TCP_NODELAY : true
> 2018-01-04 21:59:33,961 DEBUG [main] o.a.q.t.n.i.IoNetworkTransport Socket 
> connection from /127.0.0.1:48680 to localhost/127.0.0.1:46879 established
> 2018-01-04 21:59:33,961 DEBUG 
> [IO-pool-Port-testClientCertificateMissingWhilstNeedingTlsPort-5] 
> o.a.q.s.t.NonBlockingConnection Identified transport encryption as TLS
> 2018-01-04 21:59:33,962 DEBUG [main] o.a.q.c.s.StateWaiter New StateWaiter 
> :CONNECTION_NOT_STARTED:[CONNECTION_OPEN, CONNECTION_CLOSED]
> 2018-01-04 21:59:33,964 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 172 byte(s)
> 2018-01-04 21:59:33,973 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Written 1825 bytes
> 2018-01-04 21:59:33,974 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 0 byte(s)
> 2018-01-04 21:59:33,982 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 173 byte(s)
> 2018-01-04 21:59:33,984 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Exception performing I/O for connection 
> '/127.0.0.1:48680'
> javax.net.ssl.SSLHandshakeException: null cert chain
> at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1478)
> at 
> sun.security.ssl.SSLEngineImpl.checkTaskThrown(SSLEngineImpl.java:535)
> at 
> sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:813)
> at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:781)
> at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:624)
> at 
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.decryptSSL(QpidByteBufferFactory.java:197)
> at 
> org.apache.qpid.server.bytebuffer.QpidByteBuffer.decryptSSL(QpidByteBuffer.java:68)
> at 
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.processData(NonBlockingConnectionTLSDelegate.java:125)
> at 
> org.apache.qpid.server.transport.NonBlockingConnection.doRead(NonBlockingConnection.java:496)
> at 
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:270)
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:580)
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:371)
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:538)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: javax.net.ssl.SSLHandshakeException: null cert chain
> at 

[jira] [Commented] (QPID-8069) [Qpid JMS AMQP 0-x] An establishment of connection blocks for 30 seconds on TLS handshake failure

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318633#comment-16318633
 ] 

Keith Wall commented on QPID-8069:
--

Agreed, this is a defect, but as this client is not receiving active 
development, marking won't fix.

> [Qpid JMS AMQP 0-x] An establishment of connection blocks for 30 seconds on 
> TLS handshake failure
> -
>
> Key: QPID-8069
> URL: https://issues.apache.org/jira/browse/QPID-8069
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Alex Rudyy
>
> AMQTimeoutException is reported after waiting for "maximum state wait time", 
> when TLS hand shake fails.
> The stack traces like below are reported
> {noformat}
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection 
> Connection(27):amqp://guest:@clientid/?brokerlist='tcp://localhost:46879?trust_store='/tmp/test-profiles/test_resources/ssl/java_client_truststore.jks'_store_password=''='true''
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection AMQP version 0-9-1
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.p.AMQProtocolSession Using 
> ProtocolVersion for Session:0-91
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.h.ClientMethodDispatcherImpl New 
> Method Dispatcher:AMQProtocolSession[null]
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection Connecting with 
> ProtocolHandler Version:0-91
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnectionDelegate_8_0 
> Connecting to 
> broker:tcp://localhost:46879?trust_store='/tmp/test-profiles/test_resources/ssl/java_client_truststore.jks'_store_password=''='true'
> 2018-01-04 21:59:33,961 DEBUG [main] o.a.q.t.n.i.IoNetworkTransport Socket 
> options SO_RCVBUF : 65535, SO_SNDBUF : 65535, TCP_NODELAY : true
> 2018-01-04 21:59:33,961 DEBUG [main] o.a.q.t.n.i.IoNetworkTransport Socket 
> connection from /127.0.0.1:48680 to localhost/127.0.0.1:46879 established
> 2018-01-04 21:59:33,961 DEBUG 
> [IO-pool-Port-testClientCertificateMissingWhilstNeedingTlsPort-5] 
> o.a.q.s.t.NonBlockingConnection Identified transport encryption as TLS
> 2018-01-04 21:59:33,962 DEBUG [main] o.a.q.c.s.StateWaiter New StateWaiter 
> :CONNECTION_NOT_STARTED:[CONNECTION_OPEN, CONNECTION_CLOSED]
> 2018-01-04 21:59:33,964 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 172 byte(s)
> 2018-01-04 21:59:33,973 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Written 1825 bytes
> 2018-01-04 21:59:33,974 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 0 byte(s)
> 2018-01-04 21:59:33,982 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 173 byte(s)
> 2018-01-04 21:59:33,984 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Exception performing I/O for connection 
> '/127.0.0.1:48680'
> javax.net.ssl.SSLHandshakeException: null cert chain
> at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1478)
> at 
> sun.security.ssl.SSLEngineImpl.checkTaskThrown(SSLEngineImpl.java:535)
> at 
> sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:813)
> at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:781)
> at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:624)
> at 
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.decryptSSL(QpidByteBufferFactory.java:197)
> at 
> org.apache.qpid.server.bytebuffer.QpidByteBuffer.decryptSSL(QpidByteBuffer.java:68)
> at 
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.processData(NonBlockingConnectionTLSDelegate.java:125)
> at 
> org.apache.qpid.server.transport.NonBlockingConnection.doRead(NonBlockingConnection.java:496)
> at 
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:270)
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:580)
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:371)
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:538)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at 

[jira] [Comment Edited] (QPID-8069) [Qpid JMS AMQP 0-x] An establishment of connection blocks for 30 seconds on TLS handshake failure

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318633#comment-16318633
 ] 

Keith Wall edited comment on QPID-8069 at 1/9/18 3:51 PM:
--

Agreed, this is a defect - I assume longstanding, but as this client is not 
receiving active development, marking won't fix.


was (Author: k-wall):
Agreed, this is a defect, but as this client is not receiving active 
development, marking won't fix.

> [Qpid JMS AMQP 0-x] An establishment of connection blocks for 30 seconds on 
> TLS handshake failure
> -
>
> Key: QPID-8069
> URL: https://issues.apache.org/jira/browse/QPID-8069
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Alex Rudyy
>
> AMQTimeoutException is reported after waiting for "maximum state wait time", 
> when TLS hand shake fails.
> The stack traces like below are reported
> {noformat}
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection 
> Connection(27):amqp://guest:@clientid/?brokerlist='tcp://localhost:46879?trust_store='/tmp/test-profiles/test_resources/ssl/java_client_truststore.jks'_store_password=''='true''
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection AMQP version 0-9-1
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.p.AMQProtocolSession Using 
> ProtocolVersion for Session:0-91
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.h.ClientMethodDispatcherImpl New 
> Method Dispatcher:AMQProtocolSession[null]
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnection Connecting with 
> ProtocolHandler Version:0-91
> 2018-01-04 21:59:33,960 DEBUG [main] o.a.q.c.AMQConnectionDelegate_8_0 
> Connecting to 
> broker:tcp://localhost:46879?trust_store='/tmp/test-profiles/test_resources/ssl/java_client_truststore.jks'_store_password=''='true'
> 2018-01-04 21:59:33,961 DEBUG [main] o.a.q.t.n.i.IoNetworkTransport Socket 
> options SO_RCVBUF : 65535, SO_SNDBUF : 65535, TCP_NODELAY : true
> 2018-01-04 21:59:33,961 DEBUG [main] o.a.q.t.n.i.IoNetworkTransport Socket 
> connection from /127.0.0.1:48680 to localhost/127.0.0.1:46879 established
> 2018-01-04 21:59:33,961 DEBUG 
> [IO-pool-Port-testClientCertificateMissingWhilstNeedingTlsPort-5] 
> o.a.q.s.t.NonBlockingConnection Identified transport encryption as TLS
> 2018-01-04 21:59:33,962 DEBUG [main] o.a.q.c.s.StateWaiter New StateWaiter 
> :CONNECTION_NOT_STARTED:[CONNECTION_OPEN, CONNECTION_CLOSED]
> 2018-01-04 21:59:33,964 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 172 byte(s)
> 2018-01-04 21:59:33,973 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Written 1825 bytes
> 2018-01-04 21:59:33,974 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 0 byte(s)
> 2018-01-04 21:59:33,982 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Read 173 byte(s)
> 2018-01-04 21:59:33,984 DEBUG [IO-/127.0.0.1:48680] 
> o.a.q.s.t.NonBlockingConnection Exception performing I/O for connection 
> '/127.0.0.1:48680'
> javax.net.ssl.SSLHandshakeException: null cert chain
> at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1478)
> at 
> sun.security.ssl.SSLEngineImpl.checkTaskThrown(SSLEngineImpl.java:535)
> at 
> sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:813)
> at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:781)
> at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:624)
> at 
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.decryptSSL(QpidByteBufferFactory.java:197)
> at 
> org.apache.qpid.server.bytebuffer.QpidByteBuffer.decryptSSL(QpidByteBuffer.java:68)
> at 
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.processData(NonBlockingConnectionTLSDelegate.java:125)
> at 
> org.apache.qpid.server.transport.NonBlockingConnection.doRead(NonBlockingConnection.java:496)
> at 
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:270)
> at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:580)
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:371)
> at 
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:538)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> 

[jira] [Updated] (QPID-8067) [Broker-J] Default queue filter for arrival time with non-zero replay period does not filter messages as documented

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8067:
-
Fix Version/s: qpid-java-broker-7.0.1

> [Broker-J] Default queue filter for arrival time with non-zero replay period 
> does not filter messages as documented
> ---
>
> Key: QPID-8067
> URL: https://issues.apache.org/jira/browse/QPID-8067
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>Reporter: Alex Rudyy
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
>
> As per Broker documentation the replay period in arrival filter determines a 
> time interval ( in seconds) for which the arriving messages enqueued into 
> queue within given interval before consumer attach have to be delivered to 
> the consumer. Thus, all message on the queue with arrival time greater than 
> ({{consumer attach time}} - {{replay period}}) should be delivered to the 
> consumer. If filter is specified on consumer attach, the delivery works as 
> expected. However, if arrival filter is specified as default queue filter, 
> the broker behaviour is not documentation compliant:
> * the broker delivers to consumer only messages with arrival time greater 
> than ({{consumer attach time}} + {{replay period}})
> * the {{replay period}} is treated as being set in milliseconds rather than 
> in seconds
> The issue only impacts use cases when arrival filter with non-zero  {{replay 
> period}} is set as queue default filter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8067) [Broker-J] Default queue filter for arrival time with non-zero replay period does not filter messages as documented

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318628#comment-16318628
 ] 

Keith Wall commented on QPID-8067:
--

Alex - I agree with your analysis.   I think this should be fixed on master and 
7.0.1.

> [Broker-J] Default queue filter for arrival time with non-zero replay period 
> does not filter messages as documented
> ---
>
> Key: QPID-8067
> URL: https://issues.apache.org/jira/browse/QPID-8067
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>Reporter: Alex Rudyy
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
>
> As per Broker documentation the replay period in arrival filter determines a 
> time interval ( in seconds) for which the arriving messages enqueued into 
> queue within given interval before consumer attach have to be delivered to 
> the consumer. Thus, all message on the queue with arrival time greater than 
> ({{consumer attach time}} - {{replay period}}) should be delivered to the 
> consumer. If filter is specified on consumer attach, the delivery works as 
> expected. However, if arrival filter is specified as default queue filter, 
> the broker behaviour is not documentation compliant:
> * the broker delivers to consumer only messages with arrival time greater 
> than ({{consumer attach time}} + {{replay period}})
> * the {{replay period}} is treated as being set in milliseconds rather than 
> in seconds
> The issue only impacts use cases when arrival filter with non-zero  {{replay 
> period}} is set as queue default filter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-8067) [Broker-J] Default queue filter for arrival time with non-zero replay period does not filter messages as documented

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8067:
-
Fix Version/s: qpid-java-broker-7.1.0

> [Broker-J] Default queue filter for arrival time with non-zero replay period 
> does not filter messages as documented
> ---
>
> Key: QPID-8067
> URL: https://issues.apache.org/jira/browse/QPID-8067
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>Reporter: Alex Rudyy
> Fix For: qpid-java-broker-7.1.0
>
>
> As per Broker documentation the replay period in arrival filter determines a 
> time interval ( in seconds) for which the arriving messages enqueued into 
> queue within given interval before consumer attach have to be delivered to 
> the consumer. Thus, all message on the queue with arrival time greater than 
> ({{consumer attach time}} - {{replay period}}) should be delivered to the 
> consumer. If filter is specified on consumer attach, the delivery works as 
> expected. However, if arrival filter is specified as default queue filter, 
> the broker behaviour is not documentation compliant:
> * the broker delivers to consumer only messages with arrival time greater 
> than ({{consumer attach time}} + {{replay period}})
> * the {{replay period}} is treated as being set in milliseconds rather than 
> in seconds
> The issue only impacts use cases when arrival filter with non-zero  {{replay 
> period}} is set as queue default filter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8061) [Broker-J] [AMQP 0-8..0-9-1] Declaring exchange with not existing alternate binding crashes the Broker

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318610#comment-16318610
 ] 

ASF subversion and git services commented on QPID-8061:
---

Commit 89259c2de1aa1df1f582e0012c881cbb8cf61e00 in qpid-broker-j's branch 
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=89259c2 ]

QPID-8061: [Broker-J] [AMQP 0-8..0-9-1] Handle unknown alternate exchange on 
exchange declaration

Cherry picked from master 38c04f8.


> [Broker-J] [AMQP 0-8..0-9-1] Declaring exchange with not existing alternate 
> binding crashes the Broker
> --
>
> Key: QPID-8061
> URL: https://issues.apache.org/jira/browse/QPID-8061
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.1
>
>
> Declaration of exchange with not existing alternate binding crashes the 
> Broker as below:
> {noformat}
> org.apache.qpid.server.configuration.IllegalConfigurationException: Cannot 
> create alternate binding for 'test' : Alternate binding destination 
> 'not_existing' cannot be found.
>   at 
> org.apache.qpid.server.exchange.AbstractExchange.validateOrCreateAlternateBinding(AbstractExchange.java:1057)
>   at 
> org.apache.qpid.server.exchange.AbstractExchange.onCreate(AbstractExchange.java:192)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doCreation(AbstractConfiguredObject.java:1273)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:893)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:866)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:153)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:629)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.createAsync(AbstractConfiguredObject.java:865)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObjectTypeFactory.createAsync(AbstractConfiguredObjectTypeFactory.java:75)
>   at 
> org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.createAsync(ConfiguredObjectFactoryImpl.java:145)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.addChildAsync(AbstractConfiguredObject.java:2143)
>   at 
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.addChildAsync(AbstractVirtualHost.java:857)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2100)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2095)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:320)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:360)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:313)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
>   at 
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
>   at 

[jira] [Commented] (QPID-8060) [Broker-J] [AMQP 0-8..0-9-1] Declaring queue that specifies an alternate binding that does not exist crashes the Broker

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318616#comment-16318616
 ] 

ASF subversion and git services commented on QPID-8060:
---

Commit 9a762859553d50d0cc52cf308e3da199c0953698 in qpid-broker-j's branch 
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=9a76285 ]

QPID-8060: [Broker-J][AMQP 0-8..0-10] Address review comments

Cherry picked from master efb7ec0


> [Broker-J] [AMQP 0-8..0-9-1] Declaring queue that specifies an alternate 
> binding that does not exist crashes the Broker
> ---
>
> Key: QPID-8060
> URL: https://issues.apache.org/jira/browse/QPID-8060
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.1
>
>
> Declaring queue with not existing alternate binding crashes the Broker with 
> the following stack trace:
> {noformat}
> org.apache.qpid.server.configuration.IllegalConfigurationException: Cannot 
> create alternate binding for 'test' : Alternate binding destination 
> 'not_existing' cannot be found.
>   at 
> org.apache.qpid.server.queue.AbstractQueue.validateOrCreateAlternateBinding(AbstractQueue.java:3537)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.onCreate(AbstractQueue.java:320)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doCreation(AbstractConfiguredObject.java:1273)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:893)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:866)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:153)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:629)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.createAsync(AbstractConfiguredObject.java:865)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObjectTypeFactory.createAsync(AbstractConfiguredObjectTypeFactory.java:75)
>   at 
> org.apache.qpid.server.queue.QueueFactory.createAsync(QueueFactory.java:58)
>   at 
> org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.createAsync(ConfiguredObjectFactoryImpl.java:145)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.addChildAsync(AbstractConfiguredObject.java:2143)
>   at 
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.addChildAsync(AbstractVirtualHost.java:857)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2100)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2095)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:320)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:360)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:313)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
>   at 
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> 

[jira] [Commented] (QPID-8060) [Broker-J] [AMQP 0-8..0-9-1] Declaring queue that specifies an alternate binding that does not exist crashes the Broker

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318615#comment-16318615
 ] 

ASF subversion and git services commented on QPID-8060:
---

Commit 4ebbd693624965dd24d3007c8b2a700badfc8121 in qpid-broker-j's branch 
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=4ebbd69 ]

QPID-8060: [Broker-J] [AMQP 0-8..0-9-1] Address review comments

Cherry picked from master 6e83977


> [Broker-J] [AMQP 0-8..0-9-1] Declaring queue that specifies an alternate 
> binding that does not exist crashes the Broker
> ---
>
> Key: QPID-8060
> URL: https://issues.apache.org/jira/browse/QPID-8060
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.1
>
>
> Declaring queue with not existing alternate binding crashes the Broker with 
> the following stack trace:
> {noformat}
> org.apache.qpid.server.configuration.IllegalConfigurationException: Cannot 
> create alternate binding for 'test' : Alternate binding destination 
> 'not_existing' cannot be found.
>   at 
> org.apache.qpid.server.queue.AbstractQueue.validateOrCreateAlternateBinding(AbstractQueue.java:3537)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.onCreate(AbstractQueue.java:320)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doCreation(AbstractConfiguredObject.java:1273)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:893)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:866)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:153)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:629)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.createAsync(AbstractConfiguredObject.java:865)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObjectTypeFactory.createAsync(AbstractConfiguredObjectTypeFactory.java:75)
>   at 
> org.apache.qpid.server.queue.QueueFactory.createAsync(QueueFactory.java:58)
>   at 
> org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.createAsync(ConfiguredObjectFactoryImpl.java:145)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.addChildAsync(AbstractConfiguredObject.java:2143)
>   at 
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.addChildAsync(AbstractVirtualHost.java:857)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2100)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2095)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:320)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:360)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:313)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
>   at 
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> 

[jira] [Commented] (QPID-8060) [Broker-J] [AMQP 0-8..0-9-1] Declaring queue that specifies an alternate binding that does not exist crashes the Broker

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318614#comment-16318614
 ] 

ASF subversion and git services commented on QPID-8060:
---

Commit e83e43e8d67c01065f1cecca3710b486d6c27d3a in qpid-broker-j's branch 
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e83e43e ]

QPID-8060: Fix failing test

Cherry picked from master 910f439


> [Broker-J] [AMQP 0-8..0-9-1] Declaring queue that specifies an alternate 
> binding that does not exist crashes the Broker
> ---
>
> Key: QPID-8060
> URL: https://issues.apache.org/jira/browse/QPID-8060
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.1
>
>
> Declaring queue with not existing alternate binding crashes the Broker with 
> the following stack trace:
> {noformat}
> org.apache.qpid.server.configuration.IllegalConfigurationException: Cannot 
> create alternate binding for 'test' : Alternate binding destination 
> 'not_existing' cannot be found.
>   at 
> org.apache.qpid.server.queue.AbstractQueue.validateOrCreateAlternateBinding(AbstractQueue.java:3537)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.onCreate(AbstractQueue.java:320)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doCreation(AbstractConfiguredObject.java:1273)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:893)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:866)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:153)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:629)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.createAsync(AbstractConfiguredObject.java:865)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObjectTypeFactory.createAsync(AbstractConfiguredObjectTypeFactory.java:75)
>   at 
> org.apache.qpid.server.queue.QueueFactory.createAsync(QueueFactory.java:58)
>   at 
> org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.createAsync(ConfiguredObjectFactoryImpl.java:145)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.addChildAsync(AbstractConfiguredObject.java:2143)
>   at 
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.addChildAsync(AbstractVirtualHost.java:857)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2100)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2095)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:320)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:360)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:313)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
>   at 
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> 

[jira] [Commented] (QPID-8060) [Broker-J] [AMQP 0-8..0-9-1] Declaring queue that specifies an alternate binding that does not exist crashes the Broker

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318612#comment-16318612
 ] 

ASF subversion and git services commented on QPID-8060:
---

Commit ce345a7bb08a2c257155583e11055d1935db1e3d in qpid-broker-j's branch 
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=ce345a7 ]

QPID-8060: [Broker-J] [AMQP 0-8..0-9-1] Handle unknown alternate exchange on 
queue declaration

Cherry picked from master 268f3fb


> [Broker-J] [AMQP 0-8..0-9-1] Declaring queue that specifies an alternate 
> binding that does not exist crashes the Broker
> ---
>
> Key: QPID-8060
> URL: https://issues.apache.org/jira/browse/QPID-8060
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.1
>
>
> Declaring queue with not existing alternate binding crashes the Broker with 
> the following stack trace:
> {noformat}
> org.apache.qpid.server.configuration.IllegalConfigurationException: Cannot 
> create alternate binding for 'test' : Alternate binding destination 
> 'not_existing' cannot be found.
>   at 
> org.apache.qpid.server.queue.AbstractQueue.validateOrCreateAlternateBinding(AbstractQueue.java:3537)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.onCreate(AbstractQueue.java:320)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doCreation(AbstractConfiguredObject.java:1273)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:893)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:866)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:153)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:629)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.createAsync(AbstractConfiguredObject.java:865)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObjectTypeFactory.createAsync(AbstractConfiguredObjectTypeFactory.java:75)
>   at 
> org.apache.qpid.server.queue.QueueFactory.createAsync(QueueFactory.java:58)
>   at 
> org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.createAsync(ConfiguredObjectFactoryImpl.java:145)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.addChildAsync(AbstractConfiguredObject.java:2143)
>   at 
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.addChildAsync(AbstractVirtualHost.java:857)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2100)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2095)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:320)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:360)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:313)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
>   at 
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> 

[jira] [Commented] (QPID-8061) [Broker-J] [AMQP 0-8..0-9-1] Declaring exchange with not existing alternate binding crashes the Broker

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318611#comment-16318611
 ] 

ASF subversion and git services commented on QPID-8061:
---

Commit 43edc06de778230e375d150c5bea2cc16325b734 in qpid-broker-j's branch 
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=43edc06 ]

QPID-8061: Fix failing test

Cherry picked from master b3f432a


> [Broker-J] [AMQP 0-8..0-9-1] Declaring exchange with not existing alternate 
> binding crashes the Broker
> --
>
> Key: QPID-8061
> URL: https://issues.apache.org/jira/browse/QPID-8061
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.1
>
>
> Declaration of exchange with not existing alternate binding crashes the 
> Broker as below:
> {noformat}
> org.apache.qpid.server.configuration.IllegalConfigurationException: Cannot 
> create alternate binding for 'test' : Alternate binding destination 
> 'not_existing' cannot be found.
>   at 
> org.apache.qpid.server.exchange.AbstractExchange.validateOrCreateAlternateBinding(AbstractExchange.java:1057)
>   at 
> org.apache.qpid.server.exchange.AbstractExchange.onCreate(AbstractExchange.java:192)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doCreation(AbstractConfiguredObject.java:1273)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:893)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:866)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:153)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:629)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.createAsync(AbstractConfiguredObject.java:865)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObjectTypeFactory.createAsync(AbstractConfiguredObjectTypeFactory.java:75)
>   at 
> org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.createAsync(ConfiguredObjectFactoryImpl.java:145)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject.addChildAsync(AbstractConfiguredObject.java:2143)
>   at 
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.addChildAsync(AbstractVirtualHost.java:857)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2100)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$17.execute(AbstractConfiguredObject.java:2095)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:637)
>   at 
> org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:630)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:320)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:360)
>   at 
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:313)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
>   at 
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Client code:
> {code}
> Session 

[jira] [Updated] (QPID-8067) [Broker-J] Default queue filter for arrival time with non-zero replay period does not filter messages as documented

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8067:
-
Description: 
As per Broker documentation the replay period in arrival filter determines a 
time interval ( in seconds) for which the arriving messages enqueued into queue 
within given interval before consumer attach have to be delivered to the 
consumer. Thus, all message on the queue with arrival time greater than 
({{consumer attach time}} - {{replay period}}) should be delivered to the 
consumer. If filter is specified on consumer attach, the delivery works as 
expected. However, if arrival filter is specified as default queue filter, the 
broker behaviour is not documentation compliant:
* the broker delivers to consumer only messages with arrival time greater than 
({{consumer attach time}} + {{replay period}})
* the {{replay period}} is treated as being set in milliseconds rather than in 
seconds

The issue only impacts use cases when arrival filter with non-zero  {{replay 
period}} is set as queue default filter.

  was:
As per Broker documentation the replay period in arrival filter determines a 
time interval ( in seconds) for which the arriving messages enqueued into queue 
within given interval before consumer attach have to be delivered to the 
consumer. Thus, all message on the queue with arrival time greater than 
({{consumer attach time}} - {{replay period}}) should be delivered to the 
consumer. If filter is specified on consumer attach, the delivery works as 
expected. However, if arrival filter is specified as default queue filter, the 
broker behaviour is not documentation complaint:
* the broker delivers to consumer only messages with arrival time greater than 
({{consumer attach time}} + {{replay period}})
* the {{replay period}} is treated as being set in milliseconds rather than in 
seconds

The issue only impacts use cases when arrival filter with non-zero  {{replay 
period}} is set as queue default filter.


> [Broker-J] Default queue filter for arrival time with non-zero replay period 
> does not filter messages as documented
> ---
>
> Key: QPID-8067
> URL: https://issues.apache.org/jira/browse/QPID-8067
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-broker-7.0.0, qpid-java-6.1.5
>Reporter: Alex Rudyy
>
> As per Broker documentation the replay period in arrival filter determines a 
> time interval ( in seconds) for which the arriving messages enqueued into 
> queue within given interval before consumer attach have to be delivered to 
> the consumer. Thus, all message on the queue with arrival time greater than 
> ({{consumer attach time}} - {{replay period}}) should be delivered to the 
> consumer. If filter is specified on consumer attach, the delivery works as 
> expected. However, if arrival filter is specified as default queue filter, 
> the broker behaviour is not documentation compliant:
> * the broker delivers to consumer only messages with arrival time greater 
> than ({{consumer attach time}} + {{replay period}})
> * the {{replay period}} is treated as being set in milliseconds rather than 
> in seconds
> The issue only impacts use cases when arrival filter with non-zero  {{replay 
> period}} is set as queue default filter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8068) [JMS AMQP 0-x] Change of noLocal on re-subscription of durable subscriber does not re-create the subscription

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318604#comment-16318604
 ] 

Keith Wall commented on QPID-8068:
--

Agreed, this is a defect, but as this client is not receiving active 
development, marking won't fix.

> [JMS AMQP 0-x] Change of noLocal on re-subscription of durable subscriber 
> does not re-create the subscription
> -
>
> Key: QPID-8068
> URL: https://issues.apache.org/jira/browse/QPID-8068
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-6.0.8, qpid-java-client-0-x-6.3.0, 
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>
> As per  JMS 1.1 specification section "6.11.1 Durable TopicSubscriber"
> {quote}
> A client can change an existing durable subscription by creating a durable
> TopicSubscriber with the same name and a new topic and/or message selector,
> or NoLocal attribute. Changing a durable subscription is equivalent to 
> deleting
> and recreating it.
> {quote}
> The existing client does not re-create the subscription on change of noLocal.
> The workaround for the issue would be to unsubscribe and subscribe again.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-8068) [JMS AMQP 0-x] Change of noLocal on re-subscription of durable subscriber does not re-create the subscription

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-8068.
--
Resolution: Won't Fix

> [JMS AMQP 0-x] Change of noLocal on re-subscription of durable subscriber 
> does not re-create the subscription
> -
>
> Key: QPID-8068
> URL: https://issues.apache.org/jira/browse/QPID-8068
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-6.0.8, qpid-java-client-0-x-6.3.0, 
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>
> As per  JMS 1.1 specification section "6.11.1 Durable TopicSubscriber"
> {quote}
> A client can change an existing durable subscription by creating a durable
> TopicSubscriber with the same name and a new topic and/or message selector,
> or NoLocal attribute. Changing a durable subscription is equivalent to 
> deleting
> and recreating it.
> {quote}
> The existing client does not re-create the subscription on change of noLocal.
> The workaround for the issue would be to unsubscribe and subscribe again.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-8070) Qpid java broker is unable to reconnect to database after kill -9 then restart

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8070:
-
Fix Version/s: qpid-java-6.1.5
   qpid-java-broker-7.0.1

> Qpid java broker is unable to reconnect to database after kill -9 then restart
> --
>
> Key: QPID-8070
> URL: https://issues.apache.org/jira/browse/QPID-8070
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.4
>Reporter: Rabih Mourad
> Fix For: qpid-java-6.1.5, qpid-java-broker-7.0.1
>
>
> Hello,
> We are using Qpid java broker version 6.1.4.
> Our test case:
> We have a JMS client sending messages continuously in autoAck mode to a 
> messaging cluster. The cluster is composed of 1 dispatch router and 2 java 
> brokers which are connected to an Oracle Db.
> At some point, the test kills a broker using kill -9 and then attempts to 
> restart it.
> Randomly, we have a NullPointerException while the broker is restarting and 
> connecting to the virtual host node (the full error stack is at the end of 
> the email).
> Do you have any idea why this is happening? is there a chance that a kill
> -9 on a broker leaves the Db in an unstable state?
> Best regards,
> Rabih
> 2018-01-03 17:16:45,930 INFO  [VirtualHostNode-default-Config]
> (q.m.t.recovery_start) - [Broker]
> [vh(/default)/ms(GenericJDBCMessageStore)] TXN-1004 : Recovery Start
> 2018-01-03 17:16:45,938 WARN  [VirtualHostNode-default-Config]
> (o.a.q.s.v.SynchronousMessageStoreRecoverer) - Message id 1 in log references 
> queue with id 0b2a06aa-6d46-49aa-885f-63f3cd73108d which is not in the 
> configuration, entry will be discarded
> 2018-01-03 17:16:45,946 ERROR [VirtualHostNode-default-Config]
> (o.a.q.s.m.AbstractConfiguredObject) - Failed to open object with name 
> 'default'.  Object will be put into ERROR state.
> java.lang.NullPointerException: null
> at
> org.apache.qpid.server.store.AbstractJDBCMessageStore.commitTranAsync(AbstractJDBCMessageStore.java:826)
> at
> org.apache.qpid.server.store.AbstractJDBCMessageStore.access$600(AbstractJDBCMessageStore.java:59)
> at
> org.apache.qpid.server.store.AbstractJDBCMessageStore$JDBCTransaction.commitTranAsync(AbstractJDBCMessageStore.java:1205)
> at
> org.apache.qpid.server.store.jdbc.GenericAbstractJDBCMessageStore$RecordedJDBCTransaction.commitTranAsync(GenericAbstractJDBCMessageStore.java:142)
> at
> org.apache.qpid.server.virtualhost.SynchronousMessageStoreRecoverer$MessageInstanceVisitor.handle(SynchronousMessageStoreRecoverer.java:219)
> at
> org.apache.qpid.server.store.AbstractJDBCMessageStore$JDBCMessageStoreReader.visitMessageInstances(AbstractJDBCMessageStore.java:1911)
> at
> org.apache.qpid.server.virtualhost.SynchronousMessageStoreRecoverer.recover(SynchronousMessageStoreRecoverer.java:82)
> at
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.postCreateDefaultExchangeTasks(AbstractVirtualHost.java:2581)
> at
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.onActivate(AbstractVirtualHost.java:2563)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1482)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1461)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1035)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1029)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2609)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2605)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2604)
> at
> com.google.common.util.concurrent.Futures$6.run(Futures.java:1319)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor.execute(TaskExecutorImpl.java:404)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.execute(TaskExecutorImpl.java:187)
> at
> 

[jira] [Updated] (QPID-8071) Java Qpid library does not report that session was closed

[Keith Wall (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8071:
-
Component/s: (was: Broker-J)
 JMS AMQP 0-x

> Java Qpid library does not report that session was closed
> -
>
> Key: QPID-8071
> URL: https://issues.apache.org/jira/browse/QPID-8071
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-6.1.5
> Environment: slow network towards Qpid broker
> for instance set this to the machine that is making connection towards qpid 
> broker
> sudo tc qdisc add dev enp0s8 root handle 1: tbf rate 16kbit latency 25ms 
> burst 2k
> reset the throttle with this
> sudo tc qdisc del dev enp0s8 root
> add those flags to shorten qpid.io_network_transport_timeout from 1min to 5 
> seconds
> -Dqpid.sync_op_timeout=509000 -Dqpid.io_network_transport_timeout=5000
> try to send 512kB long message. If qpid.io_network_transport_timeout is 
> raised to 3 minutes it should take about 300 seconds to send the message 
> (with 16kbit link) (the default 60s threshold is exceeded).
>Reporter: Alojzij Blatnik
>
> when qpid.io_network_transport_timeout is exceeded, qpid-java library does 
> not throw exception, but the exception is just logged, hence the code, that 
> is calling qpid-java library doesn't know that qpid message wasn't sent until 
> it becomes obvious that connection is closed.
> monkey patch:
> {{diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
> b/common/src/main/java/org/apache/qpid/transport/Session.java
> index 9568873..b1afd8d 100644
> --- a/common/src/main/java/org/apache/qpid/transport/Session.java
> +++ b/common/src/main/java/org/apache/qpid/transport/Session.java
> @@ -759,16 +759,7 @@ public class Session extends SessionInvoker
>  }
>  catch (SenderException e)
>  {
> -if (!closing)
> -{
> -// if we are not closing then this will happen
> -// again on resume
> -LOGGER.error("error sending command", e);
> -}
> -else
> -{
> -e.rethrow();
> -}
> +e.rethrow();
>  }
>  if (autoSync)
>  {
> }}
> Some logs:
> {{
> 12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender  - write 
> timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head 
> -2147216975, tail -2147348047
> 12586 [main] ERROR org.apache.qpid.transport.Session  - error sending command
> org.apache.qpid.transport.SenderException: write timed out for socket 
> /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail 
> -2147348047
>   at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172)
>   at 
> org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215)
>   at 
> org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149)
>   at 
> org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88)
>   at org.apache.qpid.transport.Connection.flush(Connection.java:428)
>   at org.apache.qpid.transport.Session.send(Session.java:592)
>   at org.apache.qpid.transport.Session.invoke(Session.java:758)
>   at org.apache.qpid.transport.Session.invoke(Session.java:613)
>   at 
> org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93)
>   at 
> org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371)
>   at 
> org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549)
>   at 
> org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333)
>   at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430)
>   at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391)
>   at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497)
>   at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483)
>   at tld.domain.OurLibrary.send(OurLibrary.java:373)
>   at tld.domain.Main.send(Main.java:476)
>   at tld.domain.MainAttict.tesSendMsg(MainAttict.java:285)
>   at tld.domain.MainAttict.main(MainAttict.java:368)
> 12589 [main] INFO tld.domain.MainAttict  - message sent
> 12590 [IoRcvr-/172.21.0.2:50618-qpid-broker/192.168.80.1:5671] ERROR 
> org.apache.qpid.client.AMQConnectionDelegate_0_10  - connection exception: 
> conn:70d0de44
> org.apache.qpid.transport.ConnectionException: connection aborted
>   at org.apache.qpid.transport.Connection.closed(Connection.java:574)
>   at 
> 

[jira] [Comment Edited] (QPID-8071) Java Qpid library does not report that session was closed

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318570#comment-16318570
 ] 

Keith Wall edited comment on QPID-8071 at 1/9/18 3:15 PM:
--

Hi Alojzij

>From the stack trace, I see you are reporting a problem with the Qpid JMS AMQP 
>0-x client rather than Broker-J.   That client library [1]  is not receiving 
>much active development anymore as attention has now switched to Qpid JMS 
>Client which uses AMQP 1.0.   Is there a reason you can't use the newer 
>client? What broker are you using?

Thanks Keith.

[1] https://qpid.apache.org/components/jms/amqp-0-x.html
[2] https://qpid.apache.org/components/jms/index.html


was (Author: k-wall):
Hi Alojzi

>From the stack trace, I see you are reporting a problem with the Qpid JMS AMQP 
>0-x client rather than Broker-J.   That client library [1]  is not receiving 
>much active development anymore as attention has now switched to Qpid JMS 
>Client which uses AMQP 1.0.   Is there a reason you can't use the newer 
>client? What broker are you using?

Thanks Keith.

[1] https://qpid.apache.org/components/jms/amqp-0-x.html
[2] https://qpid.apache.org/components/jms/index.html

> Java Qpid library does not report that session was closed
> -
>
> Key: QPID-8071
> URL: https://issues.apache.org/jira/browse/QPID-8071
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-6.1.5
> Environment: slow network towards Qpid broker
> for instance set this to the machine that is making connection towards qpid 
> broker
> sudo tc qdisc add dev enp0s8 root handle 1: tbf rate 16kbit latency 25ms 
> burst 2k
> reset the throttle with this
> sudo tc qdisc del dev enp0s8 root
> add those flags to shorten qpid.io_network_transport_timeout from 1min to 5 
> seconds
> -Dqpid.sync_op_timeout=509000 -Dqpid.io_network_transport_timeout=5000
> try to send 512kB long message. If qpid.io_network_transport_timeout is 
> raised to 3 minutes it should take about 300 seconds to send the message 
> (with 16kbit link) (the default 60s threshold is exceeded).
>Reporter: Alojzij Blatnik
>
> when qpid.io_network_transport_timeout is exceeded, qpid-java library does 
> not throw exception, but the exception is just logged, hence the code, that 
> is calling qpid-java library doesn't know that qpid message wasn't sent until 
> it becomes obvious that connection is closed.
> monkey patch:
> {{diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
> b/common/src/main/java/org/apache/qpid/transport/Session.java
> index 9568873..b1afd8d 100644
> --- a/common/src/main/java/org/apache/qpid/transport/Session.java
> +++ b/common/src/main/java/org/apache/qpid/transport/Session.java
> @@ -759,16 +759,7 @@ public class Session extends SessionInvoker
>  }
>  catch (SenderException e)
>  {
> -if (!closing)
> -{
> -// if we are not closing then this will happen
> -// again on resume
> -LOGGER.error("error sending command", e);
> -}
> -else
> -{
> -e.rethrow();
> -}
> +e.rethrow();
>  }
>  if (autoSync)
>  {
> }}
> Some logs:
> {{
> 12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender  - write 
> timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head 
> -2147216975, tail -2147348047
> 12586 [main] ERROR org.apache.qpid.transport.Session  - error sending command
> org.apache.qpid.transport.SenderException: write timed out for socket 
> /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail 
> -2147348047
>   at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172)
>   at 
> org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215)
>   at 
> org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149)
>   at 
> org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88)
>   at org.apache.qpid.transport.Connection.flush(Connection.java:428)
>   at org.apache.qpid.transport.Session.send(Session.java:592)
>   at org.apache.qpid.transport.Session.invoke(Session.java:758)
>   at org.apache.qpid.transport.Session.invoke(Session.java:613)
>   at 
> org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93)
>   at 
> org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371)
>   at 
> 

[jira] [Commented] (QPID-8071) Java Qpid library does not report that session was closed

[Keith Wall (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318570#comment-16318570
 ] 

Keith Wall commented on QPID-8071:
--

Hi Alojzi

>From the stack trace, I see you are reporting a problem with the Qpid JMS AMQP 
>0-x client rather than Broker-J.   That client library [1]  is not receiving 
>much active development anymore as attention has now switched to Qpid JMS 
>Client which uses AMQP 1.0.   Is there a reason you can't use the newer 
>client? What broker are you using?

Thanks Keith.

[1] https://qpid.apache.org/components/jms/amqp-0-x.html
[2] https://qpid.apache.org/components/jms/index.html

> Java Qpid library does not report that session was closed
> -
>
> Key: QPID-8071
> URL: https://issues.apache.org/jira/browse/QPID-8071
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.5
> Environment: slow network towards Qpid broker
> for instance set this to the machine that is making connection towards qpid 
> broker
> sudo tc qdisc add dev enp0s8 root handle 1: tbf rate 16kbit latency 25ms 
> burst 2k
> reset the throttle with this
> sudo tc qdisc del dev enp0s8 root
> add those flags to shorten qpid.io_network_transport_timeout from 1min to 5 
> seconds
> -Dqpid.sync_op_timeout=509000 -Dqpid.io_network_transport_timeout=5000
> try to send 512kB long message. If qpid.io_network_transport_timeout is 
> raised to 3 minutes it should take about 300 seconds to send the message 
> (with 16kbit link) (the default 60s threshold is exceeded).
>Reporter: Alojzij Blatnik
>
> when qpid.io_network_transport_timeout is exceeded, qpid-java library does 
> not throw exception, but the exception is just logged, hence the code, that 
> is calling qpid-java library doesn't know that qpid message wasn't sent until 
> it becomes obvious that connection is closed.
> monkey patch:
> {{diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
> b/common/src/main/java/org/apache/qpid/transport/Session.java
> index 9568873..b1afd8d 100644
> --- a/common/src/main/java/org/apache/qpid/transport/Session.java
> +++ b/common/src/main/java/org/apache/qpid/transport/Session.java
> @@ -759,16 +759,7 @@ public class Session extends SessionInvoker
>  }
>  catch (SenderException e)
>  {
> -if (!closing)
> -{
> -// if we are not closing then this will happen
> -// again on resume
> -LOGGER.error("error sending command", e);
> -}
> -else
> -{
> -e.rethrow();
> -}
> +e.rethrow();
>  }
>  if (autoSync)
>  {
> }}
> Some logs:
> {{
> 12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender  - write 
> timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head 
> -2147216975, tail -2147348047
> 12586 [main] ERROR org.apache.qpid.transport.Session  - error sending command
> org.apache.qpid.transport.SenderException: write timed out for socket 
> /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail 
> -2147348047
>   at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172)
>   at 
> org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215)
>   at 
> org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149)
>   at 
> org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88)
>   at org.apache.qpid.transport.Connection.flush(Connection.java:428)
>   at org.apache.qpid.transport.Session.send(Session.java:592)
>   at org.apache.qpid.transport.Session.invoke(Session.java:758)
>   at org.apache.qpid.transport.Session.invoke(Session.java:613)
>   at 
> org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93)
>   at 
> org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371)
>   at 
> org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549)
>   at 
> org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333)
>   at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430)
>   at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391)
>   at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497)
>   at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483)
>   at tld.domain.OurLibrary.send(OurLibrary.java:373)
>   at tld.domain.Main.send(Main.java:476)
>   at 

[jira] [Commented] (QPID-8044) [JMS AMQP 0-x] Address minor packaging issues raised during 6.3.0 vote

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318510#comment-16318510
 ] 

ASF subversion and git services commented on QPID-8044:
---

Commit ce2f7095cdb042eb6379d3c6f0e46d677284c502 in qpid-jms-amqp-0-x's branch 
refs/heads/6.3.x from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms-amqp-0-x.git;h=ce2f709 ]

QPID-8044:  Address review feedback from Alex Rudyy 

Cherry picked from master:

git cherry-pick a2c3f8be14e3800d7919aa5cb25c7ae996cef8f3


> [JMS AMQP 0-x] Address minor packaging issues raised during 6.3.0 vote
> --
>
> Key: QPID-8044
> URL: https://issues.apache.org/jira/browse/QPID-8044
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-client-0-x-6.3.1
>
>
> Robbie raised the following during the 6.3.0 vote:
> > Comments:
> > -The NOTICE file in the source release archive says Apache Qpid Java
> > and should be updated going forward.
> > -The slf4j-api details in the binary archive NOTICE can be removed
> > going forward as its covered by the details in the LICENCE file
> > already.
> > -The directories in all the archives dont match their file names (sans
> > extension), which seems like it was the intended name, e.g
> > apache-qpid-jms-0-x-6.3.0-src isn't aligned with
> > apache-qpid-jms-amqp-0-x-6.3.0-src.tar.gz



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8044) [JMS AMQP 0-x] Address minor packaging issues raised during 6.3.0 vote

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-8044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318504#comment-16318504
 ] 

ASF subversion and git services commented on QPID-8044:
---

Commit a2c3f8be14e3800d7919aa5cb25c7ae996cef8f3 in qpid-jms-amqp-0-x's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms-amqp-0-x.git;h=a2c3f8b ]

QPID-8044:  Address review feedback from Alex Rudyy 


> [JMS AMQP 0-x] Address minor packaging issues raised during 6.3.0 vote
> --
>
> Key: QPID-8044
> URL: https://issues.apache.org/jira/browse/QPID-8044
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-client-0-x-6.3.1
>
>
> Robbie raised the following during the 6.3.0 vote:
> > Comments:
> > -The NOTICE file in the source release archive says Apache Qpid Java
> > and should be updated going forward.
> > -The slf4j-api details in the binary archive NOTICE can be removed
> > going forward as its covered by the details in the LICENCE file
> > already.
> > -The directories in all the archives dont match their file names (sans
> > extension), which seems like it was the intended name, e.g
> > apache-qpid-jms-0-x-6.3.0-src isn't aligned with
> > apache-qpid-jms-amqp-0-x-6.3.0-src.tar.gz



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-8071) Java Qpid library does not report that session was closed

[Alojzij Blatnik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alojzij Blatnik updated QPID-8071:
--
Environment: 
slow network towards Qpid broker
for instance set this to the machine that is making connection towards qpid 
broker
sudo tc qdisc add dev enp0s8 root handle 1: tbf rate 16kbit latency 25ms burst 
2k
reset the throttle with this
sudo tc qdisc del dev enp0s8 root

add those flags to shorten qpid.io_network_transport_timeout from 1min to 5 
seconds
-Dqpid.sync_op_timeout=509000 -Dqpid.io_network_transport_timeout=5000

try to send 512kB long message. If qpid.io_network_transport_timeout is raised 
to 3 minutes it should take about 300 seconds to send the message (with 16kbit 
link) (the default 60s threshold is exceeded).

  was:slow network towards Qpid broker


> Java Qpid library does not report that session was closed
> -
>
> Key: QPID-8071
> URL: https://issues.apache.org/jira/browse/QPID-8071
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.5
> Environment: slow network towards Qpid broker
> for instance set this to the machine that is making connection towards qpid 
> broker
> sudo tc qdisc add dev enp0s8 root handle 1: tbf rate 16kbit latency 25ms 
> burst 2k
> reset the throttle with this
> sudo tc qdisc del dev enp0s8 root
> add those flags to shorten qpid.io_network_transport_timeout from 1min to 5 
> seconds
> -Dqpid.sync_op_timeout=509000 -Dqpid.io_network_transport_timeout=5000
> try to send 512kB long message. If qpid.io_network_transport_timeout is 
> raised to 3 minutes it should take about 300 seconds to send the message 
> (with 16kbit link) (the default 60s threshold is exceeded).
>Reporter: Alojzij Blatnik
>
> when qpid.io_network_transport_timeout is exceeded, qpid-java library does 
> not throw exception, but the exception is just logged, hence the code, that 
> is calling qpid-java library doesn't know that qpid message wasn't sent until 
> it becomes obvious that connection is closed.
> monkey patch:
> {{diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
> b/common/src/main/java/org/apache/qpid/transport/Session.java
> index 9568873..b1afd8d 100644
> --- a/common/src/main/java/org/apache/qpid/transport/Session.java
> +++ b/common/src/main/java/org/apache/qpid/transport/Session.java
> @@ -759,16 +759,7 @@ public class Session extends SessionInvoker
>  }
>  catch (SenderException e)
>  {
> -if (!closing)
> -{
> -// if we are not closing then this will happen
> -// again on resume
> -LOGGER.error("error sending command", e);
> -}
> -else
> -{
> -e.rethrow();
> -}
> +e.rethrow();
>  }
>  if (autoSync)
>  {
> }}
> Some logs:
> {{
> 12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender  - write 
> timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head 
> -2147216975, tail -2147348047
> 12586 [main] ERROR org.apache.qpid.transport.Session  - error sending command
> org.apache.qpid.transport.SenderException: write timed out for socket 
> /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail 
> -2147348047
>   at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172)
>   at 
> org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215)
>   at 
> org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149)
>   at 
> org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88)
>   at org.apache.qpid.transport.Connection.flush(Connection.java:428)
>   at org.apache.qpid.transport.Session.send(Session.java:592)
>   at org.apache.qpid.transport.Session.invoke(Session.java:758)
>   at org.apache.qpid.transport.Session.invoke(Session.java:613)
>   at 
> org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93)
>   at 
> org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371)
>   at 
> org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549)
>   at 
> org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333)
>   at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430)
>   at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391)
>   at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497)
>   at 

[jira] [Updated] (QPID-8071) Java Qpid library does not report that session was closed

[Alojzij Blatnik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alojzij Blatnik updated QPID-8071:
--
Description: 
when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
{{diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker
 }
 catch (SenderException e)
 {
-if (!closing)
-{
-// if we are not closing then this will happen
-// again on resume
-LOGGER.error("error sending command", e);
-}
-else
-{
-e.rethrow();
-}
+e.rethrow();
 }
 if (autoSync)
 {
}}

Some logs:
{{
12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender  - write timed 
out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head 
-2147216975, tail -2147348047
12586 [main] ERROR org.apache.qpid.transport.Session  - error sending command
org.apache.qpid.transport.SenderException: write timed out for socket 
/172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail 
-2147348047
at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172)
at 
org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215)
at 
org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149)
at 
org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88)
at org.apache.qpid.transport.Connection.flush(Connection.java:428)
at org.apache.qpid.transport.Session.send(Session.java:592)
at org.apache.qpid.transport.Session.invoke(Session.java:758)
at org.apache.qpid.transport.Session.invoke(Session.java:613)
at 
org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93)
at 
org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371)
at 
org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549)
at 
org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333)
at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430)
at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391)
at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497)
at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483)
at tld.domain.OurLibrary.send(OurLibrary.java:373)
at tld.domain.Main.send(Main.java:476)
at tld.domain.MainAttict.tesSendMsg(MainAttict.java:285)
at tld.domain.MainAttict.main(MainAttict.java:368)
12589 [main] INFO tld.domain.MainAttict  - message sent
12590 [IoRcvr-/172.21.0.2:50618-qpid-broker/192.168.80.1:5671] ERROR 
org.apache.qpid.client.AMQConnectionDelegate_0_10  - connection exception: 
conn:70d0de44
org.apache.qpid.transport.ConnectionException: connection aborted
at org.apache.qpid.transport.Connection.closed(Connection.java:574)
at 
org.apache.qpid.transport.network.Assembler.closed(Assembler.java:115)
at 
org.apache.qpid.transport.network.InputHandler.closed(InputHandler.java:221)
at 
org.apache.qpid.transport.network.security.ssl.SSLReceiver.closed(SSLReceiver.java:69)
at 
org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:225)
at java.lang.Thread.run(Thread.java:745)
12590 [main] INFO tld.domain.OurLibrary  - lock for qpid connection status is 
not defined, hence it won't be created. Status: connection lost
}}


  was:
when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
```
diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker
 

[jira] [Updated] (QPID-8071) Java Qpid library does not report that session was closed

[Alojzij Blatnik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alojzij Blatnik updated QPID-8071:
--
Description: 
when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
```
diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker
 }
 catch (SenderException e)
 {
-if (!closing)
-{
-// if we are not closing then this will happen
-// again on resume
-LOGGER.error("error sending command", e);
-}
-else
-{
-e.rethrow();
-}
+e.rethrow();
 }
 if (autoSync)
 {
```

Some logs:
```
12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender  - write timed 
out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head 
-2147216975, tail -2147348047
12586 [main] ERROR org.apache.qpid.transport.Session  - error sending command
org.apache.qpid.transport.SenderException: write timed out for socket 
/172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail 
-2147348047
at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172)
at 
org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215)
at 
org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149)
at 
org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88)
at org.apache.qpid.transport.Connection.flush(Connection.java:428)
at org.apache.qpid.transport.Session.send(Session.java:592)
at org.apache.qpid.transport.Session.invoke(Session.java:758)
at org.apache.qpid.transport.Session.invoke(Session.java:613)
at 
org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93)
at 
org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371)
at 
org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549)
at 
org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333)
at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430)
at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391)
at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497)
at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483)
at tld.domain.OurLibrary.send(OurLibrary.java:373)
at tld.domain.Main.send(Main.java:476)
at tld.domain.MainAttict.tesSendMsg(MainAttict.java:285)
at tld.domain.MainAttict.main(MainAttict.java:368)
12589 [main] INFO tld.domain.MainAttict  - message sent
12590 [IoRcvr-/172.21.0.2:50618-qpid-broker/192.168.80.1:5671] ERROR 
org.apache.qpid.client.AMQConnectionDelegate_0_10  - connection exception: 
conn:70d0de44
org.apache.qpid.transport.ConnectionException: connection aborted
at org.apache.qpid.transport.Connection.closed(Connection.java:574)
at 
org.apache.qpid.transport.network.Assembler.closed(Assembler.java:115)
at 
org.apache.qpid.transport.network.InputHandler.closed(InputHandler.java:221)
at 
org.apache.qpid.transport.network.security.ssl.SSLReceiver.closed(SSLReceiver.java:69)
at 
org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:225)
at java.lang.Thread.run(Thread.java:745)
12590 [main] INFO tld.domain.OurLibrary  - lock for qpid connection status is 
not defined, hence it won't be created. Status: connection lost
```


  was:
when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
{{{
diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker

[jira] [Updated] (QPID-8071) Java Qpid library does not report that session was closed

[Alojzij Blatnik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alojzij Blatnik updated QPID-8071:
--
Description: 
when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
{{{
diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker
 }
 catch (SenderException e)
 {
-if (!closing)
-{
-// if we are not closing then this will happen
-// again on resume
-LOGGER.error("error sending command", e);
-}
-else
-{
-e.rethrow();
-}
+e.rethrow();
 }
 if (autoSync)
 {
}}}

Some logs:
{{{
12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender  - write timed 
out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head 
-2147216975, tail -2147348047
12586 [main] ERROR org.apache.qpid.transport.Session  - error sending command
org.apache.qpid.transport.SenderException: write timed out for socket 
/172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail 
-2147348047
at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172)
at 
org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215)
at 
org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149)
at 
org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88)
at org.apache.qpid.transport.Connection.flush(Connection.java:428)
at org.apache.qpid.transport.Session.send(Session.java:592)
at org.apache.qpid.transport.Session.invoke(Session.java:758)
at org.apache.qpid.transport.Session.invoke(Session.java:613)
at 
org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93)
at 
org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371)
at 
org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549)
at 
org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333)
at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430)
at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391)
at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497)
at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483)
at tld.domain.OurLibrary.send(OurLibrary.java:373)
at tld.domain.Main.send(Main.java:476)
at tld.domain.MainAttict.tesSendMsg(MainAttict.java:285)
at tld.domain.MainAttict.main(MainAttict.java:368)
12589 [main] INFO tld.domain.MainAttict  - message sent
12590 [IoRcvr-/172.21.0.2:50618-qpid-broker/192.168.80.1:5671] ERROR 
org.apache.qpid.client.AMQConnectionDelegate_0_10  - connection exception: 
conn:70d0de44
org.apache.qpid.transport.ConnectionException: connection aborted
at org.apache.qpid.transport.Connection.closed(Connection.java:574)
at 
org.apache.qpid.transport.network.Assembler.closed(Assembler.java:115)
at 
org.apache.qpid.transport.network.InputHandler.closed(InputHandler.java:221)
at 
org.apache.qpid.transport.network.security.ssl.SSLReceiver.closed(SSLReceiver.java:69)
at 
org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:225)
at java.lang.Thread.run(Thread.java:745)
}}}


  was:
when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker
 }
 catch (SenderException e)
 {
-if (!closing)
-{
-   

[jira] [Updated] (QPID-8071) Java Qpid library does not report that session was closed

[Alojzij Blatnik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alojzij Blatnik updated QPID-8071:
--
Description: 
when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker
 }
 catch (SenderException e)
 {
-if (!closing)
-{
-// if we are not closing then this will happen
-// again on resume
-LOGGER.error("error sending command", e);
-}
-else
-{
-e.rethrow();
-}
+e.rethrow();
 }
 if (autoSync)
 {

Some logs:
12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender  - write timed 
out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head 
-2147216975, tail -2147348047
12586 [main] ERROR org.apache.qpid.transport.Session  - error sending command
org.apache.qpid.transport.SenderException: write timed out for socket 
/172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail 
-2147348047
at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172)
at 
org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215)
at 
org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149)
at 
org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88)
at org.apache.qpid.transport.Connection.flush(Connection.java:428)
at org.apache.qpid.transport.Session.send(Session.java:592)
at org.apache.qpid.transport.Session.invoke(Session.java:758)
at org.apache.qpid.transport.Session.invoke(Session.java:613)
at 
org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93)
at 
org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371)
at 
org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549)
at 
org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333)
at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430)
at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391)
at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497)
at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483)
at tld.domain.OurLibrary.send(OurLibrary.java:373)
at tld.domain.Main.send(Main.java:476)
at tld.domain.MainAttict.tesSendMsg(MainAttict.java:285)
at tld.domain.MainAttict.main(MainAttict.java:368)
12589 [main] INFO tld.domain.MainAttict  - message sent
12590 [IoRcvr-/172.21.0.2:50618-qpid-broker/192.168.80.1:5671] ERROR 
org.apache.qpid.client.AMQConnectionDelegate_0_10  - connection exception: 
conn:70d0de44
org.apache.qpid.transport.ConnectionException: connection aborted
at org.apache.qpid.transport.Connection.closed(Connection.java:574)
at 
org.apache.qpid.transport.network.Assembler.closed(Assembler.java:115)
at 
org.apache.qpid.transport.network.InputHandler.closed(InputHandler.java:221)
at 
org.apache.qpid.transport.network.security.ssl.SSLReceiver.closed(SSLReceiver.java:69)
at 
org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:225)
at java.lang.Thread.run(Thread.java:745)
12590 [main] INFO tld.domain.OurLibrary  - lock for qpid connection status is 
not defined, hence it won't be created. Status: connection lost



  was:
when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker
 }

[jira] [Created] (QPID-8071) Java Qpid library does not report that session was closed

[Alojzij Blatnik (JIRA)]

Alojzij Blatnik created QPID-8071:
-

 Summary: Java Qpid library does not report that session was closed
 Key: QPID-8071
 URL: https://issues.apache.org/jira/browse/QPID-8071
 Project: Qpid
  Issue Type: Bug
  Components: Broker-J
Affects Versions: qpid-java-6.1.5
 Environment: slow network towards Qpid broker
Reporter: Alojzij Blatnik


when qpid.io_network_transport_timeout is exceeded, qpid-java library does not 
throw exception, but the exception is just logged, hence the code, that is 
calling qpid-java library doesn't know that qpid message wasn't sent until it 
becomes obvious that connection is closed.

monkey patch:
diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java 
b/common/src/main/java/org/apache/qpid/transport/Session.java
index 9568873..b1afd8d 100644
--- a/common/src/main/java/org/apache/qpid/transport/Session.java
+++ b/common/src/main/java/org/apache/qpid/transport/Session.java
@@ -759,16 +759,7 @@ public class Session extends SessionInvoker
 }
 catch (SenderException e)
 {
-if (!closing)
-{
-// if we are not closing then this will happen
-// again on resume
-LOGGER.error("error sending command", e);
-}
-else
-{
-e.rethrow();
-}
+e.rethrow();
 }
 if (autoSync)
 {






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

[Justin Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated PROTON-1738:

Fix Version/s: proton-c-0.20.0

> [ruby-binding] incompatible with ruby 2.0.0
> ---
>
> Key: PROTON-1738
> URL: https://issues.apache.org/jira/browse/PROTON-1738
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.19.0
> Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 
> (upstream/master)
> Author: Alan Conway 
> Date:   Thu Jan 4 12:47:25 2018 -0500
> PROTON-1706: fix compiler warnings in windows c examples
>Reporter: Jiri Daněk
>Assignee: Alan Conway
> Fix For: proton-c-0.20.0
>
>
> {noformat}
> $ ctest -VV -R ruby-example-test
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Test project /home/jdanek/Work/repos/qpid-proton/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 13
> Start 13: ruby-example-test
> 13: Test command: 
> /nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
> "/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
> "PATH=/nix/store/pgwzcwz3v13dm193iys78xajrxf7m9yq-include-what-you-use-0.8/bin:/nix/store/x9p1z5z22z59x88h7ap09s0f79w50nj0-krb5-1.15.2-dev/bin:/nix/store/0gpszn41jk1fdw98q1jdm7n4z271m303-krb5-1.15.2/bin:/nix/store/xmbal41hbh2z82jz7pgjgxkba9malcvf-gss-1.0.3/bin:/nix/store/qs68njxs4awvjaqf2yw89x8bnb2jwl2a-pkg-config-0.29.2/bin:/nix/store/bd1qnp2y4mni2jsr7yqfy45q5wj9q4wz-util-linux-2.31-bin/bin:/nix/store/s03sh263lrxnz8dp9d81is9xwrs67ay9-openssl-1.0.2n-bin/bin:/nix/store/0frzwaf62yrbs0ni6043sllk8ac7db1l-cmake-3.9.6/bin:/nix/store/q03ccdnb7i7za2q66gx8b3mii293i6cg-ninja-1.8.2/bin:/nix/store/2sb5s8wj4s6awvfd4rn82297g2fhr18d-gcc-wrapper-7.2.0/bin:/nix/store/gkasrgaqw2riqc8ck8hh3a9k06cqaqrd-gcc-7.2.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/m5s6hd02nlfywi9n3yrgrx3fa8kgp9jd-binutils-wrapper-2.28.1/bin:/nix/store/kcdiibhpjrbpash3r1bvj2ncv4rwr3sm-binutils-2.28.1/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/h5m0g1agfcyc2d5lql0n8z6fls261rnn-go-1.9.2/bin:/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin:/nix/store/10lvqls7vl68blvvv42g36bh5rjbwkmk-gdb-8.0.1/bin:/nix/store/11wq1ncfb8za0mnnficcizd53p1md2y7-swig-3.0.12/bin:/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin:/nix/store/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin:/nix/store/n7l459d0f28lmdirr1wlzkdi7151jhqk-patchelf-0.9/bin:/nix/store/q7p8jaiymb1k4n44l31xdm753j79h7l5-paxctl-0.9/bin:/nix/store/4cqv0dm94h2sm0xpcqi6h8z6bnxqqlna-gcc-wrapper-6.4.0/bin:/nix/store/d88s1v28v11j2jxshqdvqms6h0pvp8aw-gcc-6.4.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/n2p15qg4lxgq0xkfrgqqfgpwkmd3295d-findutils-4.6.0/bin:/nix/store/ajiwrzg6nz9xpifr91wp14cy8al7s4df-diffutils-3.6/bin:/nix/store/n5rsq2cxj7lp4gynkvqrp0xkf78f1ni6-gnused-4.4/bin:/nix/store/nwpv4sxayci7jkjq7fid8hwz6ig5xjzi-gnugrep-3.1/bin:/nix/store/w1cddj0qc3ximvpwrn28rig7wq99ajd7-gawk-4.2.0/bin:/nix/store/7iw6c6nx7spzsp92pqq5qnd7d8jvbdl8-gnutar-1.30/bin:/nix/store/qk11lqm8fz9hpk1682gyf3x51wwasj3z-gzip-1.8/bin:/nix/store/mi9vmy5nwc4ma33jz6ihrdhh1r6izzv6-bzip2-1.0.6.0.1-bin/bin:/nix/store/92cdms75qnqh3hf39wbxra60bxdah9mq-gnumake-4.2.1/bin:/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin:/nix/store/irwrb341fpqd2lj22j13ffsxcjhayv1m-patch-2.7.5/bin:/nix/store/8fy4c90a0cj1mw2xibvv5k6b0rxx6b09-xz-5.2.3-bin/bin:/home/jdanek/bin:/run/wrappers/bin:/etc/per-user-pkgs/jdanek/bin:/home/jdanek/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin:/home/jdanek/Work/repos/qpid-proton/build/proton-c/bindings/ruby:/home/jdanek/Work/repos/qpid-proton/build/proton-c"
>  
> 

[jira] [Comment Edited] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

[JIRA]

[ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318322#comment-16318322
 ] 

Jiri Daněk edited comment on PROTON-1738 at 1/9/18 12:18 PM:
-

Having fixed the above (split the queue adds into two statements instead of 
one), I get

{noformat}
[nix-shell:~/Work/repos/qpid-proton/build]$ ctest -VV -R ruby-example-test
[...]/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin/saslpasswd2" 
"/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/ruby" 
"example_test.rb" "-v"
13: Test timeout computed to be: 1500
13: 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/generic.rb:214:in
 `initialize': the scheme amqp does not accept registry part: :34265 (or bad 
hostname?) (URI::InvalidURIError)
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `new'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `parse'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:747:in
 `parse'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/uri.rb:67:in
 `uri'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/container.rb:205:in
 `listen'
13: from broker.rb:95:in `on_container_start'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/adapter.rb:74:in
 `forward'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/messaging_adapter.rb:27:in
 `delegate'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/messaging_adapter.rb:38:in
 `on_container_start'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/container.rb:237:in
 `run'
13: from broker.rb:165:in `'
13: example_test.rb:97:in `readline': end of file reached (EOFError)
13: from example_test.rb:97:in `'
1/1 Test #13: ruby-example-test ***Failed0.25 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.26 sec

The following tests FAILED:
 13 - ruby-example-test (Failed)
Errors while running CTest
{noformat}

Apparently, the problem is that old_example_test.rb contains 

{noformat}
def make_url(port, path) "amqp://:#{port}/#{path}"; end
{noformat}

This is IMO the cause of the error above

Ruby 2.0.0 {{require 'uri'; u = URI("amqp://:40475")}}
{noformat}
URI::InvalidURIError: the scheme amqp does not accept registry part: :40475 (or 
bad hostname?)
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/generic.rb:214:in
 `initialize'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:218:in
 `new'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:218:in
 `parse'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:747:in
 `parse'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:996:in
 `URI'
from (irb):13
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/irb:12:in 
`'}}
{noformat}

Ruby 2.4.0 {{require 'uri'; u = URI("amqp://:40475")}}
{noformat}
=> #
{noformat}


was (Author: jdanek):
Having fixed the above (split the queue adds into two statements instead of 
one), I get

{noformat}
[nix-shell:~/Work/repos/qpid-proton/build]$ ctest -VV -R ruby-example-test
[...]/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin/saslpasswd2" 
"/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/ruby" 
"example_test.rb" "-v"
13: Test timeout computed to be: 1500
13: 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/generic.rb:214:in
 `initialize': the scheme amqp does not accept registry part: :34265 (or bad 
hostname?) (URI::InvalidURIError)
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `new'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `parse'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:747:in
 `parse'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/uri.rb:67:in
 `uri'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/container.rb:205:in
 `listen'
13: from broker.rb:95:in `on_container_start'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/adapter.rb:74:in
 `forward'
13: from 

[jira] [Comment Edited] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

[JIRA]

[ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318322#comment-16318322
 ] 

Jiri Daněk edited comment on PROTON-1738 at 1/9/18 12:17 PM:
-

Having fixed the above (split the queue adds into two statements instead of 
one), I get

{noformat}
[nix-shell:~/Work/repos/qpid-proton/build]$ ctest -VV -R ruby-example-test
[...]/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin/saslpasswd2" 
"/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/ruby" 
"example_test.rb" "-v"
13: Test timeout computed to be: 1500
13: 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/generic.rb:214:in
 `initialize': the scheme amqp does not accept registry part: :34265 (or bad 
hostname?) (URI::InvalidURIError)
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `new'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `parse'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:747:in
 `parse'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/uri.rb:67:in
 `uri'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/container.rb:205:in
 `listen'
13: from broker.rb:95:in `on_container_start'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/adapter.rb:74:in
 `forward'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/messaging_adapter.rb:27:in
 `delegate'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/messaging_adapter.rb:38:in
 `on_container_start'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/container.rb:237:in
 `run'
13: from broker.rb:165:in `'
13: example_test.rb:97:in `readline': end of file reached (EOFError)
13: from example_test.rb:97:in `'
1/1 Test #13: ruby-example-test ***Failed0.25 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.26 sec

The following tests FAILED:
 13 - ruby-example-test (Failed)
Errors while running CTest
{noformat}

Apparently, the problem is that old_example_test.rb contains {{def 
make_url(port, path) "amqp://:#{port}/#{path}"; end}}

This is IMO the cause of the error above

Ruby 2.0.0 {{require 'uri'; u = URI("amqp://:40475")}}
{noformat}
URI::InvalidURIError: the scheme amqp does not accept registry part: :40475 (or 
bad hostname?)
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/generic.rb:214:in
 `initialize'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:218:in
 `new'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:218:in
 `parse'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:747:in
 `parse'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:996:in
 `URI'
from (irb):13
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/irb:12:in 
`'}}
{noformat}

Ruby 2.4.0 {{require 'uri'; u = URI("amqp://:40475")}}
{noformat}
=> #
{noformat}


was (Author: jdanek):
Having fixed the above, I get

{noformat}
[nix-shell:~/Work/repos/qpid-proton/build]$ ctest -VV -R ruby-example-test
[...]/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin/saslpasswd2" 
"/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/ruby" 
"example_test.rb" "-v"
13: Test timeout computed to be: 1500
13: 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/generic.rb:214:in
 `initialize': the scheme amqp does not accept registry part: :34265 (or bad 
hostname?) (URI::InvalidURIError)
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `new'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `parse'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:747:in
 `parse'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/uri.rb:67:in
 `uri'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/container.rb:205:in
 `listen'
13: from broker.rb:95:in `on_container_start'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/adapter.rb:74:in
 `forward'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/messaging_adapter.rb:27:in
 `delegate'
13: from 

[jira] [Commented] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

[JIRA]

[ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318322#comment-16318322
 ] 

Jiri Daněk commented on PROTON-1738:


Having fixed the above, I get

{noformat}
[nix-shell:~/Work/repos/qpid-proton/build]$ ctest -VV -R ruby-example-test
[...]/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin/saslpasswd2" 
"/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/ruby" 
"example_test.rb" "-v"
13: Test timeout computed to be: 1500
13: 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/generic.rb:214:in
 `initialize': the scheme amqp does not accept registry part: :34265 (or bad 
hostname?) (URI::InvalidURIError)
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `new'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:214:in
 `parse'
13: from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:747:in
 `parse'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/uri.rb:67:in
 `uri'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/container.rb:205:in
 `listen'
13: from broker.rb:95:in `on_container_start'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/adapter.rb:74:in
 `forward'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/messaging_adapter.rb:27:in
 `delegate'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/handler/messaging_adapter.rb:38:in
 `on_container_start'
13: from 
/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib/core/container.rb:237:in
 `run'
13: from broker.rb:165:in `'
13: example_test.rb:97:in `readline': end of file reached (EOFError)
13: from example_test.rb:97:in `'
1/1 Test #13: ruby-example-test ***Failed0.25 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.26 sec

The following tests FAILED:
 13 - ruby-example-test (Failed)
Errors while running CTest
{noformat}

Apparently, the problem is that old_example_test.rb contains {{def 
make_url(port, path) "amqp://:#{port}/#{path}"; end}}

This is IMO the cause of the error above

Ruby 2.0.0 {{require 'uri'; u = URI("amqp://:40475")}}
{noformat}
URI::InvalidURIError: the scheme amqp does not accept registry part: :40475 (or 
bad hostname?)
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/generic.rb:214:in
 `initialize'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:218:in
 `new'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:218:in
 `parse'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:747:in
 `parse'
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/lib/ruby/2.0.0/uri/common.rb:996:in
 `URI'
from (irb):13
from 
/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/irb:12:in 
`'}}
{noformat}

Ruby 2.4.0 {{require 'uri'; u = URI("amqp://:40475")}}
{noformat}
=> #
{noformat}

> [ruby-binding] incompatible with ruby 2.0.0
> ---
>
> Key: PROTON-1738
> URL: https://issues.apache.org/jira/browse/PROTON-1738
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.19.0
> Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 
> (upstream/master)
> Author: Alan Conway 
> Date:   Thu Jan 4 12:47:25 2018 -0500
> PROTON-1706: fix compiler warnings in windows c examples
>Reporter: Jiri Daněk
>Assignee: Alan Conway
>
> {noformat}
> $ ctest -VV -R ruby-example-test
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Test project /home/jdanek/Work/repos/qpid-proton/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 13
> Start 13: ruby-example-test
> 13: Test command: 
> /nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
> "/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
> 

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318270#comment-16318270
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit adf475f1e9198ca32b17c80644bbe8319f47f071 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=adf475f ]

QPID-6933: [System Tests] Fix failing tests in TlsTest


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

[JIRA]

Jiri Daněk created PROTON-1738:
--

 Summary: [ruby-binding] incompatible with ruby 2.0.0
 Key: PROTON-1738
 URL: https://issues.apache.org/jira/browse/PROTON-1738
 Project: Qpid Proton
  Issue Type: Bug
  Components: ruby-binding
Affects Versions: proton-c-0.19.0
 Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 (upstream/master)
Author: Alan Conway 
Date:   Thu Jan 4 12:47:25 2018 -0500

PROTON-1706: fix compiler warnings in windows c examples
Reporter: Jiri Daněk
Assignee: Alan Conway


{noformat}
$ ctest -VV -R ruby-example-test
UpdateCTestConfiguration  from 
:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
Parse Config 
file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
UpdateCTestConfiguration  from 
:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
Parse Config 
file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
Test project /home/jdanek/Work/repos/qpid-proton/build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 13
Start 13: ruby-example-test

13: Test command: 
/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
"/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
"PATH=/nix/store/pgwzcwz3v13dm193iys78xajrxf7m9yq-include-what-you-use-0.8/bin:/nix/store/x9p1z5z22z59x88h7ap09s0f79w50nj0-krb5-1.15.2-dev/bin:/nix/store/0gpszn41jk1fdw98q1jdm7n4z271m303-krb5-1.15.2/bin:/nix/store/xmbal41hbh2z82jz7pgjgxkba9malcvf-gss-1.0.3/bin:/nix/store/qs68njxs4awvjaqf2yw89x8bnb2jwl2a-pkg-config-0.29.2/bin:/nix/store/bd1qnp2y4mni2jsr7yqfy45q5wj9q4wz-util-linux-2.31-bin/bin:/nix/store/s03sh263lrxnz8dp9d81is9xwrs67ay9-openssl-1.0.2n-bin/bin:/nix/store/0frzwaf62yrbs0ni6043sllk8ac7db1l-cmake-3.9.6/bin:/nix/store/q03ccdnb7i7za2q66gx8b3mii293i6cg-ninja-1.8.2/bin:/nix/store/2sb5s8wj4s6awvfd4rn82297g2fhr18d-gcc-wrapper-7.2.0/bin:/nix/store/gkasrgaqw2riqc8ck8hh3a9k06cqaqrd-gcc-7.2.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/m5s6hd02nlfywi9n3yrgrx3fa8kgp9jd-binutils-wrapper-2.28.1/bin:/nix/store/kcdiibhpjrbpash3r1bvj2ncv4rwr3sm-binutils-2.28.1/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/h5m0g1agfcyc2d5lql0n8z6fls261rnn-go-1.9.2/bin:/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin:/nix/store/10lvqls7vl68blvvv42g36bh5rjbwkmk-gdb-8.0.1/bin:/nix/store/11wq1ncfb8za0mnnficcizd53p1md2y7-swig-3.0.12/bin:/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin:/nix/store/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin:/nix/store/n7l459d0f28lmdirr1wlzkdi7151jhqk-patchelf-0.9/bin:/nix/store/q7p8jaiymb1k4n44l31xdm753j79h7l5-paxctl-0.9/bin:/nix/store/4cqv0dm94h2sm0xpcqi6h8z6bnxqqlna-gcc-wrapper-6.4.0/bin:/nix/store/d88s1v28v11j2jxshqdvqms6h0pvp8aw-gcc-6.4.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/n2p15qg4lxgq0xkfrgqqfgpwkmd3295d-findutils-4.6.0/bin:/nix/store/ajiwrzg6nz9xpifr91wp14cy8al7s4df-diffutils-3.6/bin:/nix/store/n5rsq2cxj7lp4gynkvqrp0xkf78f1ni6-gnused-4.4/bin:/nix/store/nwpv4sxayci7jkjq7fid8hwz6ig5xjzi-gnugrep-3.1/bin:/nix/store/w1cddj0qc3ximvpwrn28rig7wq99ajd7-gawk-4.2.0/bin:/nix/store/7iw6c6nx7spzsp92pqq5qnd7d8jvbdl8-gnutar-1.30/bin:/nix/store/qk11lqm8fz9hpk1682gyf3x51wwasj3z-gzip-1.8/bin:/nix/store/mi9vmy5nwc4ma33jz6ihrdhh1r6izzv6-bzip2-1.0.6.0.1-bin/bin:/nix/store/92cdms75qnqh3hf39wbxra60bxdah9mq-gnumake-4.2.1/bin:/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin:/nix/store/irwrb341fpqd2lj22j13ffsxcjhayv1m-patch-2.7.5/bin:/nix/store/8fy4c90a0cj1mw2xibvv5k6b0rxx6b09-xz-5.2.3-bin/bin:/home/jdanek/bin:/run/wrappers/bin:/etc/per-user-pkgs/jdanek/bin:/home/jdanek/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin:/home/jdanek/Work/repos/qpid-proton/build/proton-c/bindings/ruby:/home/jdanek/Work/repos/qpid-proton/build/proton-c"
 
"RUBYLIB=:/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/lib:/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/tests:/home/jdanek/Work/repos/qpid-proton/proton-c/bindings/ruby/spec:/home/jdanek/Work/repos/qpid-proton/build/proton-c/bindings/ruby:/home/jdanek/Work/repos/qpid-proton/build/proton-c"
 
"SASLPASSWD=/nix/store/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin/saslpasswd2"
 "/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin/ruby" 
"example_test.rb" "-v"
13: Test timeout computed to be: 1500
13: