[jira] [Commented] (QPID-8083) [REST] Refactor REST system test suite
[ https://issues.apache.org/jira/browse/QPID-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344164#comment-16344164 ] ASF subversion and git services commented on QPID-8083: --- Commit 06e577da412fcb0444116f1a436bdcd6e50ebc68 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=06e577d ] QPID-8083 [System Tests] [REST/HTTP] Add REST model create tests > [REST] Refactor REST system test suite > -- > > Key: QPID-8083 > URL: https://issues.apache.org/jira/browse/QPID-8083 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Major > > REST is an orthogonal concern within the Broker. It should be possible for > developers of the Broker to easily exclude REST tests from test runs whilst > developing other parts of the Broker. To allow for this, the REST test suite > should be separate. > Also many of the current tests are very repetitious in nature. Currently > each model object is subjected to its own REST test merely testing that model > attributes are available over REST, pointlessly retesting the same piece of > common mechanism code over and over again. Such tests should be eliminated. > Tests that remain should focus on REST concerns such as: > * CRUD model access > * Model operations > * SASL and Preemptive Authentication > * Compression/Decompression > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-922) Subsecond timestamps improperly formatted
[ https://issues.apache.org/jira/browse/DISPATCH-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344080#comment-16344080 ] ASF subversion and git services commented on DISPATCH-922: -- Commit b08d98165ef5f5fc9ef3d7922a2887f66059585d in qpid-dispatch's branch refs/heads/master from [~ganeshmurthy] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=b08d981 ] DISPATCH-922 - When timestamps are formatted with microseconds the leading zeros are left intact > Subsecond timestamps improperly formatted > - > > Key: DISPATCH-922 > URL: https://issues.apache.org/jira/browse/DISPATCH-922 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.0 >Reporter: Chuck Rolke >Assignee: Chuck Rolke >Priority: Major > > Timestamps appear to be out of order. > {noformat} > 2018-01-29 15:00:44.78657 -0500 AGENT (debug) Add entity: LogEntity() > 2018-01-29 15:00:44.78832 -0500 AGENT (debug) Add entity: LogEntity() > 2018-01-29 15:00:44.79022 -0500 AGENT (debug) Add entity: LogEntity() > 2018-01-29 15:00:44.406613 -0500 AGENT (debug) Add entity: RouterEntity() > 2018-01-29 15:00:44.407853 -0500 HTTP (debug) Initial logging level > 2018-01-29 15:00:44.407897 -0500 HTTP (debug) Libwebsockets version: > {noformat} > When timestamps are formatted with microseconds it looks like leading zeros > are missing from the uS value. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-920) Enabled policy blocks inter-router links
[ https://issues.apache.org/jira/browse/DISPATCH-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-920. --- Resolution: Fixed > Enabled policy blocks inter-router links > > > Key: DISPATCH-920 > URL: https://issues.apache.org/jira/browse/DISPATCH-920 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.0.0 >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Blocker > Fix For: 1.1.0 > > > The default policy blocks the creation of receiver links with no source > address. Because the inter-router links have no addresses in their sources > or targets, the policy blocks inter-router router coordination. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #251: DISPATCH-920: Selftest exposing the issue
Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/251 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-920) Enabled policy blocks inter-router links
[ https://issues.apache.org/jira/browse/DISPATCH-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344061#comment-16344061 ] ASF subversion and git services commented on DISPATCH-920: -- Commit ee044a15f48e046919bc5679f4b2bef7ae1f1f99 in qpid-dispatch's branch refs/heads/master from [~tr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=ee044a1 ] DISPATCH-920 - Block policy enforcement on inter-router connections > Enabled policy blocks inter-router links > > > Key: DISPATCH-920 > URL: https://issues.apache.org/jira/browse/DISPATCH-920 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.0.0 >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Blocker > Fix For: 1.1.0 > > > The default policy blocks the creation of receiver links with no source > address. Because the inter-router links have no addresses in their sources > or targets, the policy blocks inter-router router coordination. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-920) Enabled policy blocks inter-router links
[ https://issues.apache.org/jira/browse/DISPATCH-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344062#comment-16344062 ] ASF GitHub Bot commented on DISPATCH-920: - Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/251 > Enabled policy blocks inter-router links > > > Key: DISPATCH-920 > URL: https://issues.apache.org/jira/browse/DISPATCH-920 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.0.0 >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Blocker > Fix For: 1.1.0 > > > The default policy blocks the creation of receiver links with no source > address. Because the inter-router links have no addresses in their sources > or targets, the policy blocks inter-router router coordination. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-920) Enabled policy blocks inter-router links
[ https://issues.apache.org/jira/browse/DISPATCH-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344060#comment-16344060 ] ASF subversion and git services commented on DISPATCH-920: -- Commit 1f2e3d929af763300af9d901bbe14336ee72bcd5 in qpid-dispatch's branch refs/heads/master from [~chug] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=1f2e3d9 ] DISPATCH-920: self test to detect interrouter links being blocked > Enabled policy blocks inter-router links > > > Key: DISPATCH-920 > URL: https://issues.apache.org/jira/browse/DISPATCH-920 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.0.0 >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Blocker > Fix For: 1.1.0 > > > The default policy blocks the creation of receiver links with no source > address. Because the inter-router links have no addresses in their sources > or targets, the policy blocks inter-router router coordination. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-922) Subsecond timestamps improperly formatted
[ https://issues.apache.org/jira/browse/DISPATCH-922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke reassigned DISPATCH-922: Assignee: Chuck Rolke > Subsecond timestamps improperly formatted > - > > Key: DISPATCH-922 > URL: https://issues.apache.org/jira/browse/DISPATCH-922 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.0 >Reporter: Chuck Rolke >Assignee: Chuck Rolke >Priority: Major > > Timestamps appear to be out of order. > {noformat} > 2018-01-29 15:00:44.78657 -0500 AGENT (debug) Add entity: LogEntity() > 2018-01-29 15:00:44.78832 -0500 AGENT (debug) Add entity: LogEntity() > 2018-01-29 15:00:44.79022 -0500 AGENT (debug) Add entity: LogEntity() > 2018-01-29 15:00:44.406613 -0500 AGENT (debug) Add entity: RouterEntity() > 2018-01-29 15:00:44.407853 -0500 HTTP (debug) Initial logging level > 2018-01-29 15:00:44.407897 -0500 HTTP (debug) Libwebsockets version: > {noformat} > When timestamps are formatted with microseconds it looks like leading zeros > are missing from the uS value. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-920) Enabled policy blocks inter-router links
[ https://issues.apache.org/jira/browse/DISPATCH-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344034#comment-16344034 ] ASF GitHub Bot commented on DISPATCH-920: - GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/251 DISPATCH-920: Selftest exposing the issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChugR/qpid-dispatch crolke-DISPATCH-920 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/251.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #251 commit 1f2e3d929af763300af9d901bbe14336ee72bcd5 Author: Chuck Rolke Date: 2018-01-29T20:48:49Z DISPATCH-920: self test to detect interrouter links being blocked commit 6383909b7477bd5fefe64fbfa565f538b6d52f23 Author: Chuck Rolke Date: 2018-01-29T21:02:37Z tidy up > Enabled policy blocks inter-router links > > > Key: DISPATCH-920 > URL: https://issues.apache.org/jira/browse/DISPATCH-920 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.0.0 >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Blocker > Fix For: 1.1.0 > > > The default policy blocks the creation of receiver links with no source > address. Because the inter-router links have no addresses in their sources > or targets, the policy blocks inter-router router coordination. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #251: DISPATCH-920: Selftest exposing the issue
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/251 DISPATCH-920: Selftest exposing the issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChugR/qpid-dispatch crolke-DISPATCH-920 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/251.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #251 commit 1f2e3d929af763300af9d901bbe14336ee72bcd5 Author: Chuck Rolke Date: 2018-01-29T20:48:49Z DISPATCH-920: self test to detect interrouter links being blocked commit 6383909b7477bd5fefe64fbfa565f538b6d52f23 Author: Chuck Rolke Date: 2018-01-29T21:02:37Z tidy up --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [DISCUSS] Proposal to mark "Won't Fix" all open "JMS AMQP 0-x" JIRAs
On 29/01/18 14:15, Oleksandr Rudyy wrote: Keith, Your suggestion looks reasonable to me. +1 from me. Likewise. +1 - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1756) [Proton-J] Runnable created on every Transfer frame send
[ https://issues.apache.org/jira/browse/PROTON-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish resolved PROTON-1756. -- Resolution: Fixed > [Proton-J] Runnable created on every Transfer frame send > > > Key: PROTON-1756 > URL: https://issues.apache.org/jira/browse/PROTON-1756 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Affects Versions: proton-j-0.25.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Trivial > Fix For: proton-j-0.26.0 > > > On each outbound Transfer frame the TransportImpl creates a new Runnable to > handle overflow which sets the more value on the Transfer and rewrites the > frame body. We can use a single instance to handle this and reduce the > amount of garbage create on send. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1756) [Proton-J] Runnable created on every Transfer frame send
[ https://issues.apache.org/jira/browse/PROTON-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343969#comment-16343969 ] ASF subversion and git services commented on PROTON-1756: - Commit d1e6771994dbf2aba20adea008b43f4f3b81f26f in qpid-proton-j's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton-j.git;h=d1e6771 ] PROTON-1756 Reuse callback for send of Transfer frames Reduce GC pressure by not allocating new Runnables on each call to send a Transfer into the Frame writer. > [Proton-J] Runnable created on every Transfer frame send > > > Key: PROTON-1756 > URL: https://issues.apache.org/jira/browse/PROTON-1756 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Affects Versions: proton-j-0.25.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Trivial > Fix For: proton-j-0.26.0 > > > On each outbound Transfer frame the TransportImpl creates a new Runnable to > handle overflow which sets the more value on the Transfer and rewrites the > frame body. We can use a single instance to handle this and reduce the > amount of garbage create on send. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1756) [Proton-J] Runnable created on every Transfer frame send
Timothy Bish created PROTON-1756: Summary: [Proton-J] Runnable created on every Transfer frame send Key: PROTON-1756 URL: https://issues.apache.org/jira/browse/PROTON-1756 Project: Qpid Proton Issue Type: Improvement Components: proton-j Affects Versions: proton-j-0.25.0 Reporter: Timothy Bish Assignee: Timothy Bish Fix For: proton-j-0.26.0 On each outbound Transfer frame the TransportImpl creates a new Runnable to handle overflow which sets the more value on the Transfer and rewrites the frame body. We can use a single instance to handle this and reduce the amount of garbage create on send. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-922) Subsecond timestamps improperly formatted
Chuck Rolke created DISPATCH-922: Summary: Subsecond timestamps improperly formatted Key: DISPATCH-922 URL: https://issues.apache.org/jira/browse/DISPATCH-922 Project: Qpid Dispatch Issue Type: Bug Affects Versions: 1.0.0 Reporter: Chuck Rolke Timestamps appear to be out of order. {noformat} 2018-01-29 15:00:44.78657 -0500 AGENT (debug) Add entity: LogEntity() 2018-01-29 15:00:44.78832 -0500 AGENT (debug) Add entity: LogEntity() 2018-01-29 15:00:44.79022 -0500 AGENT (debug) Add entity: LogEntity() 2018-01-29 15:00:44.406613 -0500 AGENT (debug) Add entity: RouterEntity() 2018-01-29 15:00:44.407853 -0500 HTTP (debug) Initial logging level 2018-01-29 15:00:44.407897 -0500 HTTP (debug) Libwebsockets version: {noformat} When timestamps are formatted with microseconds it looks like leading zeros are missing from the uS value. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install
[ https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343938#comment-16343938 ] ASF GitHub Bot commented on DISPATCH-921: - Github user kgiusti commented on the issue: https://github.com/apache/qpid-dispatch/pull/249 Other than the version issue this patch appears to work for me! > Install console dependencies with npm during make install > - > > Key: DISPATCH-921 > URL: https://issues.apache.org/jira/browse/DISPATCH-921 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.0.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > During a make install, the stand-alone console's dependencies should be > installed using the command 'npm install' executed from the console's install > directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #249: DISPATCH-921 Run npm install after stand-alone con...
Github user kgiusti commented on the issue: https://github.com/apache/qpid-dispatch/pull/249 Other than the version issue this patch appears to work for me! --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install
[ https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343909#comment-16343909 ] ASF GitHub Bot commented on DISPATCH-921: - Github user kgiusti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/249#discussion_r164544618 --- Diff: console/CMakeLists.txt --- @@ -25,33 +25,46 @@ set(CONSOLE_BASE_SOURCE_DIR "${CMAKE_SOURCE_DIR}/console/stand-alone/") option(CONSOLE_INSTALL "Install stand-alone console" ON) if(CONSOLE_INSTALL) - # Static console files - install( - DIRECTORY ${CONSOLE_BASE_SOURCE_DIR} + # Static console files + install( +DIRECTORY ${CONSOLE_BASE_SOURCE_DIR} DESTINATION ${CONSOLE_STAND_ALONE_INSTALL_DIR} ) + # run npm install for console if npm is installed + find_program(PROG_NPM npm) + if (PROG_NPM STREQUAL "PROG_NPM-NOTFOUND") +message(WARNING "Program npm not found. You must manually install console dependencies.") --- End diff -- Hey - turns out the WARNING keyword is not supported with the minimum Cmake version we require. But I think this is the Right Way to do it, and since Proton's minimum Cmake is set to 2.8.12 we should update our cmake_minimum_version to the same. Can you update this patch and change the cmake_minimum_version in the topmost CMakeLists.txt fileto 2.8.12? > Install console dependencies with npm during make install > - > > Key: DISPATCH-921 > URL: https://issues.apache.org/jira/browse/DISPATCH-921 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.0.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > During a make install, the stand-alone console's dependencies should be > installed using the command 'npm install' executed from the console's install > directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #249: DISPATCH-921 Run npm install after stand-al...
Github user kgiusti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/249#discussion_r164544618 --- Diff: console/CMakeLists.txt --- @@ -25,33 +25,46 @@ set(CONSOLE_BASE_SOURCE_DIR "${CMAKE_SOURCE_DIR}/console/stand-alone/") option(CONSOLE_INSTALL "Install stand-alone console" ON) if(CONSOLE_INSTALL) - # Static console files - install( - DIRECTORY ${CONSOLE_BASE_SOURCE_DIR} + # Static console files + install( +DIRECTORY ${CONSOLE_BASE_SOURCE_DIR} DESTINATION ${CONSOLE_STAND_ALONE_INSTALL_DIR} ) + # run npm install for console if npm is installed + find_program(PROG_NPM npm) + if (PROG_NPM STREQUAL "PROG_NPM-NOTFOUND") +message(WARNING "Program npm not found. You must manually install console dependencies.") --- End diff -- Hey - turns out the WARNING keyword is not supported with the minimum Cmake version we require. But I think this is the Right Way to do it, and since Proton's minimum Cmake is set to 2.8.12 we should update our cmake_minimum_version to the same. Can you update this patch and change the cmake_minimum_version in the topmost CMakeLists.txt fileto 2.8.12? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-919) Display a warning when running Dispatch tests if python-unittest2 is not installed
[ https://issues.apache.org/jira/browse/DISPATCH-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343793#comment-16343793 ] ASF GitHub Bot commented on DISPATCH-919: - GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/250 DISPATCH-919: if python-unittest2 not installed issue warning and dis… …able tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-919 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/250.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #250 commit fdaabf2e12c43f0df55f2b5b15ff505ec32715b7 Author: ganeshmurthy Date: 2018-01-29T18:36:50Z DISPATCH-919: if python-unittest2 not installed issue warning and disable tests > Display a warning when running Dispatch tests if python-unittest2 is not > installed > -- > > Key: DISPATCH-919 > URL: https://issues.apache.org/jira/browse/DISPATCH-919 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.0.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Minor > > Because of changes made to DISPATCH-894 we now require python-unittest2 > package to be installed to be able to run the system tests. For anyone moving > from Dispatch 1.0.0 to 1.1.0, this information is not obvious. (we do have > this information in the readme) > Please display a visible warning (python-unittest2 needs to be installed in > order to run tests) when a unit test is run (or if the entire test suite is > run) without having python-unittest2 installed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #250: DISPATCH-919: if python-unittest2 not insta...
GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/250 DISPATCH-919: if python-unittest2 not installed issue warning and dis⦠â¦able tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-919 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/250.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #250 commit fdaabf2e12c43f0df55f2b5b15ff505ec32715b7 Author: ganeshmurthy Date: 2018-01-29T18:36:50Z DISPATCH-919: if python-unittest2 not installed issue warning and disable tests --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-919) Display a warning when running Dispatch tests if python-unittest2 is not installed
[ https://issues.apache.org/jira/browse/DISPATCH-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343771#comment-16343771 ] ASF GitHub Bot commented on DISPATCH-919: - Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/248 > Display a warning when running Dispatch tests if python-unittest2 is not > installed > -- > > Key: DISPATCH-919 > URL: https://issues.apache.org/jira/browse/DISPATCH-919 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.0.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Minor > > Because of changes made to DISPATCH-894 we now require python-unittest2 > package to be installed to be able to run the system tests. For anyone moving > from Dispatch 1.0.0 to 1.1.0, this information is not obvious. (we do have > this information in the readme) > Please display a visible warning (python-unittest2 needs to be installed in > order to run tests) when a unit test is run (or if the entire test suite is > run) without having python-unittest2 installed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #248: DISPATCH-919 - Modified CMakeLists.txt to w...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/248 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install
[ https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343627#comment-16343627 ] ASF GitHub Bot commented on DISPATCH-921: - GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/249 DISPATCH-921 Run npm install after stand-alone console install Checks to make sure npm is installed and runs npm install after console file have been copied. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-921 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 9a0626878ea3f35e3a082f9591616e8b31380e13 Author: Ernest Allen Date: 2018-01-29T16:53:49Z DISPATCH-921 Run npm install after stand-alone console install > Install console dependencies with npm during make install > - > > Key: DISPATCH-921 > URL: https://issues.apache.org/jira/browse/DISPATCH-921 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.0.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > During a make install, the stand-alone console's dependencies should be > installed using the command 'npm install' executed from the console's install > directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #249: DISPATCH-921 Run npm install after stand-al...
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/249 DISPATCH-921 Run npm install after stand-alone console install Checks to make sure npm is installed and runs npm install after console file have been copied. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-921 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 9a0626878ea3f35e3a082f9591616e8b31380e13 Author: Ernest Allen Date: 2018-01-29T16:53:49Z DISPATCH-921 Run npm install after stand-alone console install --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-911) Add link and address level counters at the global router level
[ https://issues.apache.org/jira/browse/DISPATCH-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343614#comment-16343614 ] ASF GitHub Bot commented on DISPATCH-911: - Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/247 @ErnieAllen you will have to query every router in the network and aggregate the stats. thx > Add link and address level counters at the global router level > -- > > Key: DISPATCH-911 > URL: https://issues.apache.org/jira/browse/DISPATCH-911 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Management Agent >Affects Versions: 1.0.0 >Reporter: Ernest Allen >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.1.0 > > > Link already has the following counters - > presettledCount > droppedPresettledCount > acceptedCount > rejectedCount > releasedCount > modifiedCount > Address already has the following counters > deliveriesIngress > deliveriesEgress > deliveriesTransit > 1. Add the above link and address counters to the global router level as well. > 2. Add routeContainerDeliveriesEgress and routeContainerDeliveriesIngress as > address and global counters > 3. Add router memory footprint as a global statistic -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #247: DISPATCH-911 - Added global delivery counts
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/247 @ErnieAllen you will have to query every router in the network and aggregate the stats. thx --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-921) Install console dependencies with npm during make install
Ernest Allen created DISPATCH-921: - Summary: Install console dependencies with npm during make install Key: DISPATCH-921 URL: https://issues.apache.org/jira/browse/DISPATCH-921 Project: Qpid Dispatch Issue Type: Improvement Components: Console Affects Versions: 1.0.0 Reporter: Ernest Allen Assignee: Ernest Allen During a make install, the stand-alone console's dependencies should be installed using the command 'npm install' executed from the console's install directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8087) [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to recover
[ https://issues.apache.org/jira/browse/QPID-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8087: - Status: Reviewable (was: In Progress) > [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to > recover > > > Key: QPID-8087 > URL: https://issues.apache.org/jira/browse/QPID-8087 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.1 > > > If the BDB HA VHN fails to complete the process of becoming a master (for > instance due to a recovery problem such as QPID-8066), the node fails to go > into an {{ERROR}} state. This makes it harder for the operator observing the > console to know there is a problem. This is different to non-HA where the > node goes into the ERROR state. > The BDB HA node should go into ERROR state. The node must continue to remain > a member of the HA group. If it did not do this, the condition would simply > spread through the group, needlessly shutting down each node as it went. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8087) [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to recover
[ https://issues.apache.org/jira/browse/QPID-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8087: - Fix Version/s: qpid-java-broker-7.0.1 > [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to > recover > > > Key: QPID-8087 > URL: https://issues.apache.org/jira/browse/QPID-8087 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.1 > > > If the BDB HA VHN fails to complete the process of becoming a master (for > instance due to a recovery problem such as QPID-8066), the node fails to go > into an {{ERROR}} state. This makes it harder for the operator observing the > console to know there is a problem. This is different to non-HA where the > node goes into the ERROR state. > The BDB HA node should go into ERROR state. The node must continue to remain > a member of the HA group. If it did not do this, the condition would simply > spread through the group, needlessly shutting down each node as it went. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8087) [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to recover
[ https://issues.apache.org/jira/browse/QPID-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-8087: Assignee: Keith Wall > [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to > recover > > > Key: QPID-8087 > URL: https://issues.apache.org/jira/browse/QPID-8087 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Minor > > If the BDB HA VHN fails to complete the process of becoming a master (for > instance due to a recovery problem such as QPID-8066), the node fails to go > into an {{ERROR}} state. This makes it harder for the operator observing the > console to know there is a problem. This is different to non-HA where the > node goes into the ERROR state. > The BDB HA node should go into ERROR state. The node must continue to remain > a member of the HA group. If it did not do this, the condition would simply > spread through the group, needlessly shutting down each node as it went. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8087) [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to recover
[ https://issues.apache.org/jira/browse/QPID-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343511#comment-16343511 ] ASF subversion and git services commented on QPID-8087: --- Commit 575d2762e1e776fd2106aec92d5c85dc2c1770ab in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=575d276 ] QPID-8087: [Broker-J] [BDB] [HA] Ensure that node goes into ERROR if recovery fails on master event from JE > [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to > recover > > > Key: QPID-8087 > URL: https://issues.apache.org/jira/browse/QPID-8087 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Keith Wall >Priority: Minor > > If the BDB HA VHN fails to complete the process of becoming a master (for > instance due to a recovery problem such as QPID-8066), the node fails to go > into an {{ERROR}} state. This makes it harder for the operator observing the > console to know there is a problem. This is different to non-HA where the > node goes into the ERROR state. > The BDB HA node should go into ERROR state. The node must continue to remain > a member of the HA group. If it did not do this, the condition would simply > spread through the group, needlessly shutting down each node as it went. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8083) [REST] Refactor REST system test suite
[ https://issues.apache.org/jira/browse/QPID-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343457#comment-16343457 ] ASF subversion and git services commented on QPID-8083: --- Commit cd20d0ae7a2b507ce0b13ff40ed460f866cea759 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=cd20d0a ] QPID-8083 [System Tests] [REST/HTTP] Move SaslRestTest into separate package > [REST] Refactor REST system test suite > -- > > Key: QPID-8083 > URL: https://issues.apache.org/jira/browse/QPID-8083 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Major > > REST is an orthogonal concern within the Broker. It should be possible for > developers of the Broker to easily exclude REST tests from test runs whilst > developing other parts of the Broker. To allow for this, the REST test suite > should be separate. > Also many of the current tests are very repetitious in nature. Currently > each model object is subjected to its own REST test merely testing that model > attributes are available over REST, pointlessly retesting the same piece of > common mechanism code over and over again. Such tests should be eliminated. > Tests that remain should focus on REST concerns such as: > * CRUD model access > * Model operations > * SASL and Preemptive Authentication > * Compression/Decompression > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8083) [REST] Refactor REST system test suite
[ https://issues.apache.org/jira/browse/QPID-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343453#comment-16343453 ] ASF subversion and git services commented on QPID-8083: --- Commit e30e86596053cd1efdabf11bde3058b7e48eb55f in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e30e865 ] QPID-8083 [System Tests] [REST/HTTP] Move CompressedResponsesRestTest into http management system tests > [REST] Refactor REST system test suite > -- > > Key: QPID-8083 > URL: https://issues.apache.org/jira/browse/QPID-8083 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Major > > REST is an orthogonal concern within the Broker. It should be possible for > developers of the Broker to easily exclude REST tests from test runs whilst > developing other parts of the Broker. To allow for this, the REST test suite > should be separate. > Also many of the current tests are very repetitious in nature. Currently > each model object is subjected to its own REST test merely testing that model > attributes are available over REST, pointlessly retesting the same piece of > common mechanism code over and over again. Such tests should be eliminated. > Tests that remain should focus on REST concerns such as: > * CRUD model access > * Model operations > * SASL and Preemptive Authentication > * Compression/Decompression > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8062) [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination cannot route received message
[ https://issues.apache.org/jira/browse/QPID-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8062. -- Resolution: Fixed Resolving JIRA after merging all changes into 7.0.x branch > [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination > cannot route received message > - > > Key: QPID-8062 > URL: https://issues.apache.org/jira/browse/QPID-8062 > Project: Qpid > Issue Type: Bug >Affects Versions: qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8062-Broker-J-AMQP-1.0-Move-responsibility-to-c.patch > > > As per section "2.2.2 Routing Errors" of "Using the Anonymous Terminus for > Message Routing Version 1.0": > {quote} > If the source of the link does not support the rejected outcome, or the > message has already been settled by the sender, then the routing node MUST > detach the link with an error. The error sent by the routing node MUST > contain the error which would have been communicated in the detach sent on > attempting to link directly to the address in the message’s to field. > Additionally the info field of error MUST contain an entry with symbolic key > delivery-tag and binary value of the delivery-tag of the message which caused > the failure. > {quote} > The Broker-J does not handle the case when message is sent pre-settled and is > rejected by the destination. We need to add the support for this behaviour. > Additionally, if a pre-settled message is published within a transaction and > cannot be routed by a queue/exchange/whatever then have the transactional > resource > logically mark the transaction as"rollback only" (i.e. failed) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8032) [AMQP1.0] AsyncAutoCommitTransaction optimisation
[ https://issues.apache.org/jira/browse/QPID-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8032. -- Resolution: Fixed Assignee: (was: Keith Wall) Resolving Jira after merging changes into 7.0.x branch > [AMQP1.0] AsyncAutoCommitTransaction optimisation > - > > Key: QPID-8032 > URL: https://issues.apache.org/jira/browse/QPID-8032 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8032-Broker-J-AMQP-1.0-Use-asynchronous-transac.patch > > > Some AMQP 1.0 messaging use-cases would benefit from the > {{AsyncAutoCommitTransactions}} optimisation that is already in use on the > older protocols. > For instance, for a publisher sending persistent settled messages, currently > each message is written to disk and sync before the next message is the > buffer is processed,. With this optimisation, the syncs would be allowed to > coalesce. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8032) [AMQP1.0] AsyncAutoCommitTransaction optimisation
[ https://issues.apache.org/jira/browse/QPID-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343416#comment-16343416 ] Alex Rudyy commented on QPID-8032: -- The JIRA message for a commit merging [bce2424df9c8fdef3d1714ff1f760f11859f298d|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=bce2424] is missed: {noformat} commit cf30e227b8e05787d6a95fcd138b879823fda455 Author: Alex Rudyy Date: Fri Jan 12 15:34:42 2018 + QPID-8032: [Broker-J][AMQP 1.0] Use asynchronous auto commit transaction for non-transactional transfers Currently each disposition returned singly. (cherry picked from commit bce2424df9c8fdef3d1714ff1f760f11859f298d) {noformat} > [AMQP1.0] AsyncAutoCommitTransaction optimisation > - > > Key: QPID-8032 > URL: https://issues.apache.org/jira/browse/QPID-8032 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8032-Broker-J-AMQP-1.0-Use-asynchronous-transac.patch > > > Some AMQP 1.0 messaging use-cases would benefit from the > {{AsyncAutoCommitTransactions}} optimisation that is already in use on the > older protocols. > For instance, for a publisher sending persistent settled messages, currently > each message is written to disk and sync before the next message is the > buffer is processed,. With this optimisation, the syncs would be allowed to > coalesce. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8032) [AMQP1.0] AsyncAutoCommitTransaction optimisation
[ https://issues.apache.org/jira/browse/QPID-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343395#comment-16343395 ] ASF subversion and git services commented on QPID-8032: --- Commit 16beefd0d408461e472aaa5ad8fc32f1491172fe in qpid-broker-j's branch refs/heads/7.0.x from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=16beefd ] QPID-8032: [Broker-J][AMQP 1.0] Coalesce the dispositions for non-transactional transfers (cherry picked from commit 3b92c3063ee213a9e4c4527acd139d40a4237d56) > [AMQP1.0] AsyncAutoCommitTransaction optimisation > - > > Key: QPID-8032 > URL: https://issues.apache.org/jira/browse/QPID-8032 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8032-Broker-J-AMQP-1.0-Use-asynchronous-transac.patch > > > Some AMQP 1.0 messaging use-cases would benefit from the > {{AsyncAutoCommitTransactions}} optimisation that is already in use on the > older protocols. > For instance, for a publisher sending persistent settled messages, currently > each message is written to disk and sync before the next message is the > buffer is processed,. With this optimisation, the syncs would be allowed to > coalesce. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8032) [AMQP1.0] AsyncAutoCommitTransaction optimisation
[ https://issues.apache.org/jira/browse/QPID-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343396#comment-16343396 ] ASF subversion and git services commented on QPID-8032: --- Commit ae36d9018e5062e351a1fa5fe47b8d7436d8641c in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=ae36d90 ] QPID-8032: [Broker-J][AMQP 1.0] Fix defect in coalescing loop (cherry picked from commit 562714536e68e06c01827a3e9217eb31ce0964ae) > [AMQP1.0] AsyncAutoCommitTransaction optimisation > - > > Key: QPID-8032 > URL: https://issues.apache.org/jira/browse/QPID-8032 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8032-Broker-J-AMQP-1.0-Use-asynchronous-transac.patch > > > Some AMQP 1.0 messaging use-cases would benefit from the > {{AsyncAutoCommitTransactions}} optimisation that is already in use on the > older protocols. > For instance, for a publisher sending persistent settled messages, currently > each message is written to disk and sync before the next message is the > buffer is processed,. With this optimisation, the syncs would be allowed to > coalesce. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8062) [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination cannot route received message
[ https://issues.apache.org/jira/browse/QPID-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343397#comment-16343397 ] ASF subversion and git services commented on QPID-8062: --- Commit b4e746a4b76d7baac75c4bc04fdd93198f9fad20 in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=b4e746a ] QPID-8062: [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination cannot route received message * close the link on receipt of unroutable message when the source of the link does not support the rejected outcome or non-transactional message has already been settled by the sender * mark the publishing transaction as "rollback only" on receipt of unroutable pre-settled message (cherry picked from commit 06b4213286305f6d05ce496ca278b73b566f24be) > [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination > cannot route received message > - > > Key: QPID-8062 > URL: https://issues.apache.org/jira/browse/QPID-8062 > Project: Qpid > Issue Type: Bug >Affects Versions: qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8062-Broker-J-AMQP-1.0-Move-responsibility-to-c.patch > > > As per section "2.2.2 Routing Errors" of "Using the Anonymous Terminus for > Message Routing Version 1.0": > {quote} > If the source of the link does not support the rejected outcome, or the > message has already been settled by the sender, then the routing node MUST > detach the link with an error. The error sent by the routing node MUST > contain the error which would have been communicated in the detach sent on > attempting to link directly to the address in the message’s to field. > Additionally the info field of error MUST contain an entry with symbolic key > delivery-tag and binary value of the delivery-tag of the message which caused > the failure. > {quote} > The Broker-J does not handle the case when message is sent pre-settled and is > rejected by the destination. We need to add the support for this behaviour. > Additionally, if a pre-settled message is published within a transaction and > cannot be routed by a queue/exchange/whatever then have the transactional > resource > logically mark the transaction as"rollback only" (i.e. failed) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8062) [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination cannot route received message
[ https://issues.apache.org/jira/browse/QPID-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343400#comment-16343400 ] ASF subversion and git services commented on QPID-8062: --- Commit 1d8d0bcba435405fde632ff1d869b30e2f0529a0 in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=1d8d0bc ] QPID-8062: [Broker-J][AMQP 1.0] Add more tests (cherry picked from commit 8cf9f1d31aef411f0fd20055e34d37de7c50098b) > [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination > cannot route received message > - > > Key: QPID-8062 > URL: https://issues.apache.org/jira/browse/QPID-8062 > Project: Qpid > Issue Type: Bug >Affects Versions: qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8062-Broker-J-AMQP-1.0-Move-responsibility-to-c.patch > > > As per section "2.2.2 Routing Errors" of "Using the Anonymous Terminus for > Message Routing Version 1.0": > {quote} > If the source of the link does not support the rejected outcome, or the > message has already been settled by the sender, then the routing node MUST > detach the link with an error. The error sent by the routing node MUST > contain the error which would have been communicated in the detach sent on > attempting to link directly to the address in the message’s to field. > Additionally the info field of error MUST contain an entry with symbolic key > delivery-tag and binary value of the delivery-tag of the message which caused > the failure. > {quote} > The Broker-J does not handle the case when message is sent pre-settled and is > rejected by the destination. We need to add the support for this behaviour. > Additionally, if a pre-settled message is published within a transaction and > cannot be routed by a queue/exchange/whatever then have the transactional > resource > logically mark the transaction as"rollback only" (i.e. failed) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8032) [AMQP1.0] AsyncAutoCommitTransaction optimisation
[ https://issues.apache.org/jira/browse/QPID-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343404#comment-16343404 ] ASF subversion and git services commented on QPID-8032: --- Commit 4e6c44d10d459b9dd0b55c2d4c0bb1347c014d5c in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=4e6c44d ] QPID-8032 : [Broker-J] Address review comments (cherry picked from commit c6cde241692c8840ad2c36e6ce4645be60d8adb7) > [AMQP1.0] AsyncAutoCommitTransaction optimisation > - > > Key: QPID-8032 > URL: https://issues.apache.org/jira/browse/QPID-8032 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8032-Broker-J-AMQP-1.0-Use-asynchronous-transac.patch > > > Some AMQP 1.0 messaging use-cases would benefit from the > {{AsyncAutoCommitTransactions}} optimisation that is already in use on the > older protocols. > For instance, for a publisher sending persistent settled messages, currently > each message is written to disk and sync before the next message is the > buffer is processed,. With this optimisation, the syncs would be allowed to > coalesce. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8079) [Broker-J] If the future associated with an AsyncCommand completes abnormally, the associated action is not rolled-back
[ https://issues.apache.org/jira/browse/QPID-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343401#comment-16343401 ] ASF subversion and git services commented on QPID-8079: --- Commit 02cf0ff16722cab8a6678f5af4472ee4b678f6bd in qpid-broker-j's branch refs/heads/7.0.x from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=02cf0ff ] QPID-8079: [Broker-J] Ensure that actions associated with AsyncCommand are rolled back if the underlying future completes unsucessfully (cherry picked from commit 5fa398cfc2141d6ec090df3464f5bcbf63d7b023) > [Broker-J] If the future associated with an AsyncCommand completes > abnormally, the associated action is not rolled-back > --- > > Key: QPID-8079 > URL: https://issues.apache.org/jira/browse/QPID-8079 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.1 > > > The protocol layers currently use AsyncCommands to organise for work to be > completed after an async auto-commit transaction competes. When > {{AsyncCommand#complete}} is invoked, it awaits completion of the future then > calls underlying action. The code currently fails to call \{{onRollback}} in > the failure case. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8032) [AMQP1.0] AsyncAutoCommitTransaction optimisation
[ https://issues.apache.org/jira/browse/QPID-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343402#comment-16343402 ] ASF subversion and git services commented on QPID-8032: --- Commit f608040edb5089a3813f3cb116f59803cef4d171 in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=f608040 ] QPID-8032 : [Broker-J][AMQP 1.0] Use asynchronous auto commit transaction for non-transactional message dequeuing (cherry picked from commit a1ed9978f756268fc86de8af02e5d7fad13a65a2) > [AMQP1.0] AsyncAutoCommitTransaction optimisation > - > > Key: QPID-8032 > URL: https://issues.apache.org/jira/browse/QPID-8032 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8032-Broker-J-AMQP-1.0-Use-asynchronous-transac.patch > > > Some AMQP 1.0 messaging use-cases would benefit from the > {{AsyncAutoCommitTransactions}} optimisation that is already in use on the > older protocols. > For instance, for a publisher sending persistent settled messages, currently > each message is written to disk and sync before the next message is the > buffer is processed,. With this optimisation, the syncs would be allowed to > coalesce. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8032) [AMQP1.0] AsyncAutoCommitTransaction optimisation
[ https://issues.apache.org/jira/browse/QPID-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343403#comment-16343403 ] ASF subversion and git services commented on QPID-8032: --- Commit c24f1b737d5735c9caeddcb114f6eda999afc28c in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c24f1b73 ] QPID-8032 : [Broker-J][AMQP 1.0] Add protocol tests for receiving of multiple messages (cherry picked from commit a627b2742a893c9873483dee7c4ad1cb7d8428cd) > [AMQP1.0] AsyncAutoCommitTransaction optimisation > - > > Key: QPID-8032 > URL: https://issues.apache.org/jira/browse/QPID-8032 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8032-Broker-J-AMQP-1.0-Use-asynchronous-transac.patch > > > Some AMQP 1.0 messaging use-cases would benefit from the > {{AsyncAutoCommitTransactions}} optimisation that is already in use on the > older protocols. > For instance, for a publisher sending persistent settled messages, currently > each message is written to disk and sync before the next message is the > buffer is processed,. With this optimisation, the syncs would be allowed to > coalesce. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8062) [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination cannot route received message
[ https://issues.apache.org/jira/browse/QPID-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343398#comment-16343398 ] ASF subversion and git services commented on QPID-8062: --- Commit 2495d194989110d383df7d2a44a92e90cb8c48bf in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=2495d19 ] QPID-8062: [Broker-J][AMQP 1.0] Move responsibility to create outcome for received message from ReceivingDestination into a caller of ReceivingDestination#send() (cherry picked from commit b5a0d32806ed5d07853adc287537d53cd3a7791f) > [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination > cannot route received message > - > > Key: QPID-8062 > URL: https://issues.apache.org/jira/browse/QPID-8062 > Project: Qpid > Issue Type: Bug >Affects Versions: qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8062-Broker-J-AMQP-1.0-Move-responsibility-to-c.patch > > > As per section "2.2.2 Routing Errors" of "Using the Anonymous Terminus for > Message Routing Version 1.0": > {quote} > If the source of the link does not support the rejected outcome, or the > message has already been settled by the sender, then the routing node MUST > detach the link with an error. The error sent by the routing node MUST > contain the error which would have been communicated in the detach sent on > attempting to link directly to the address in the message’s to field. > Additionally the info field of error MUST contain an entry with symbolic key > delivery-tag and binary value of the delivery-tag of the message which caused > the failure. > {quote} > The Broker-J does not handle the case when message is sent pre-settled and is > rejected by the destination. We need to add the support for this behaviour. > Additionally, if a pre-settled message is published within a transaction and > cannot be routed by a queue/exchange/whatever then have the transactional > resource > logically mark the transaction as"rollback only" (i.e. failed) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8079) [Broker-J] If the future associated with an AsyncCommand completes abnormally, the associated action is not rolled-back
[ https://issues.apache.org/jira/browse/QPID-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8079: - Fix Version/s: (was: qpid-java-broker-7.0.0) qpid-java-broker-7.0.1 > [Broker-J] If the future associated with an AsyncCommand completes > abnormally, the associated action is not rolled-back > --- > > Key: QPID-8079 > URL: https://issues.apache.org/jira/browse/QPID-8079 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.1 > > > The protocol layers currently use AsyncCommands to organise for work to be > completed after an async auto-commit transaction competes. When > {{AsyncCommand#complete}} is invoked, it awaits completion of the future then > calls underlying action. The code currently fails to call \{{onRollback}} in > the failure case. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8062) [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination cannot route received message
[ https://issues.apache.org/jira/browse/QPID-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343399#comment-16343399 ] ASF subversion and git services commented on QPID-8062: --- Commit 42807eff86c3389c263874576a92a31f73ab104c in qpid-broker-j's branch refs/heads/7.0.x from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=42807ef ] QPID-8062: [Broker-J][AMQP 1.0] Add additional tests > [Broker-J][AMQP 1.0] Fix handling of routing errors when target destination > cannot route received message > - > > Key: QPID-8062 > URL: https://issues.apache.org/jira/browse/QPID-8062 > Project: Qpid > Issue Type: Bug >Affects Versions: qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1 > > Attachments: > 0001-QPID-8062-Broker-J-AMQP-1.0-Move-responsibility-to-c.patch > > > As per section "2.2.2 Routing Errors" of "Using the Anonymous Terminus for > Message Routing Version 1.0": > {quote} > If the source of the link does not support the rejected outcome, or the > message has already been settled by the sender, then the routing node MUST > detach the link with an error. The error sent by the routing node MUST > contain the error which would have been communicated in the detach sent on > attempting to link directly to the address in the message’s to field. > Additionally the info field of error MUST contain an entry with symbolic key > delivery-tag and binary value of the delivery-tag of the message which caused > the failure. > {quote} > The Broker-J does not handle the case when message is sent pre-settled and is > rejected by the destination. We need to add the support for this behaviour. > Additionally, if a pre-settled message is published within a transaction and > cannot be routed by a queue/exchange/whatever then have the transactional > resource > logically mark the transaction as"rollback only" (i.e. failed) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [DISCUSS] Proposal to mark "Won't Fix" all open "JMS AMQP 0-x" JIRAs
Keith, Your suggestion looks reasonable to me. +1 from me. Kind Regards, Alex On 22 January 2018 at 22:27, Keith W wrote: > The JIRA component "JMS AMQP 0-x" corresponds to the old 0-8..0-10 > Qpid JMS Client. As development work on this component is ceased, I > proposing to mark all open JIRAs tagged for it as Won't Fix with a > short explanatory comment. > > "Won't Fix. Development work on this Qpid JMS AMQP 0-x client has > ceased. For a JMS client under active development, see the Qpid JMS > AMQP 1.0 client - https://qpid.apache.org/components/jms/index.html"; > > For a list of JIRAs: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20QPID%20AND%20component%20in%20(%22JMS%20AMQP%200-x%22)%20AND%20status%20not%20in%20(Resolved%2C%20Closed%2C%20%22In%20Progress%22)%20ORDER%20BY%20component%20ASC > > Some JIRAs are tagged with both "JMS AMQP 0-x" and other component(s) > - clients and/or brokers. They all seem to be old/inactive so I am > not intending to treat these differently. > > Comments welcome. > > Keith. > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8088) Pull-up bindingAdress attribute to Port
[ https://issues.apache.org/jira/browse/QPID-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343377#comment-16343377 ] ASF subversion and git services commented on QPID-8088: --- Commit e26dd33212dc34aad22aa66b97d7e8b388c857c8 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e26dd33 ] QPID-8088: [Broker-J] Pull-up bindingAddress to port > Pull-up bindingAdress attribute to Port > --- > > Key: QPID-8088 > URL: https://issues.apache.org/jira/browse/QPID-8088 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.1.0 > > > The port implementations, {{AmqpPort}} and {{HttpPort}} currently make their > own duplicate declaration of {{getBindingAddress}}. This is a hang-over from > the RMI times. This should be pulled up. The HostNameAlias implementation > should then be generalised to use Port rather than assume AmqpPort - which > would then permit its use on HTTP ports too. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1722) 0.20.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-1722. Resolution: Done > 0.20.0 release tasks > > > Key: PROTON-1722 > URL: https://issues.apache.org/jira/browse/PROTON-1722 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.20.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8086) [Broker-J] Create tool to permit recovery from QPID-8066
[ https://issues.apache.org/jira/browse/QPID-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343277#comment-16343277 ] Alex Rudyy commented on QPID-8086: -- The changes in commit [039f79b5388dd9bfd21a6b1e1bad8ac9c9065361|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=039f79b] look reasonable to me. Please, merge them into necessary branches > [Broker-J] Create tool to permit recovery from QPID-8066 > > > Key: QPID-8086 > URL: https://issues.apache.org/jira/browse/QPID-8086 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1, qpid-java-6.1.6 > > > Defect QPID-8066 has the potential to leave the Broker in a state where it > cannot be restarted. The recovery phase, on encountering the orphan records, > throws an exception and this puts the virtualhost into an {{ERROR}} state. > There is no facility in Broker-J to recover from this short of recreation of > the virtualhost. > If the configuration store is backed by JDBC, then a workaround is to connect > to the database and remove the offending rows. Unfortunately if the > virtualhost is backed by BDB (for configuration) or BDB HA, the user has no > convenient way to recover the situation. BDB JE has no command line > interface so a Java program would have to be written with knowledge of the > store's structure. The HA case is further complicated by the fact that > sufficient nodes would have to be available to provide quorum within the > group. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8089) [Broker-J][HTTP Management] Activate dynamically added HTTP ports on creation
Alex Rudyy created QPID-8089: Summary: [Broker-J][HTTP Management] Activate dynamically added HTTP ports on creation Key: QPID-8089 URL: https://issues.apache.org/jira/browse/QPID-8089 Project: Qpid Issue Type: Improvement Components: Broker-J Reporter: Alex Rudyy Fix For: qpid-java-broker-7.1.0 Currently the newly added http ports are put into {{QUIESCED}} state. The broker restart is required to allow handling of HTTP requests in the port. In order to avoid broker restart, the newly added HTTP ports should be activated immediately on creation. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8083) [REST] Refactor REST system test suite
[ https://issues.apache.org/jira/browse/QPID-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343251#comment-16343251 ] ASF subversion and git services commented on QPID-8083: --- Commit e4f5cc911251a1cd2f42bb980f0debb30985aa2c in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e4f5cc9 ] QPID-8083 [System Tests] [REST/HTTP] Move SaslRestTest into http management system tests > [REST] Refactor REST system test suite > -- > > Key: QPID-8083 > URL: https://issues.apache.org/jira/browse/QPID-8083 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Major > > REST is an orthogonal concern within the Broker. It should be possible for > developers of the Broker to easily exclude REST tests from test runs whilst > developing other parts of the Broker. To allow for this, the REST test suite > should be separate. > Also many of the current tests are very repetitious in nature. Currently > each model object is subjected to its own REST test merely testing that model > attributes are available over REST, pointlessly retesting the same piece of > common mechanism code over and over again. Such tests should be eliminated. > Tests that remain should focus on REST concerns such as: > * CRUD model access > * Model operations > * SASL and Preemptive Authentication > * Compression/Decompression > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8088) Pull-up bindingAdress attribute to Port
Keith Wall created QPID-8088: Summary: Pull-up bindingAdress attribute to Port Key: QPID-8088 URL: https://issues.apache.org/jira/browse/QPID-8088 Project: Qpid Issue Type: Improvement Components: Broker-J Reporter: Keith Wall Fix For: qpid-java-broker-7.1.0 The port implementations, {{AmqpPort}} and {{HttpPort}} currently make their own duplicate declaration of {{getBindingAddress}}. This is a hang-over from the RMI times. This should be pulled up. The HostNameAlias implementation should then be generalised to use Port rather than assume AmqpPort - which would then permit its use on HTTP ports too. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8086) [Broker-J] Create tool to permit recovery from QPID-8066
[ https://issues.apache.org/jira/browse/QPID-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343171#comment-16343171 ] ASF subversion and git services commented on QPID-8086: --- Commit 039f79b5388dd9bfd21a6b1e1bad8ac9c9065361 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=039f79b ] QPID-8086: [BDB HA] Standalone tool to delete orphan configuration - replaced the need for the targetUuid param with parentRootCategory > [Broker-J] Create tool to permit recovery from QPID-8066 > > > Key: QPID-8086 > URL: https://issues.apache.org/jira/browse/QPID-8086 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.0.1, qpid-java-6.1.6 > > > Defect QPID-8066 has the potential to leave the Broker in a state where it > cannot be restarted. The recovery phase, on encountering the orphan records, > throws an exception and this puts the virtualhost into an {{ERROR}} state. > There is no facility in Broker-J to recover from this short of recreation of > the virtualhost. > If the configuration store is backed by JDBC, then a workaround is to connect > to the database and remove the offending rows. Unfortunately if the > virtualhost is backed by BDB (for configuration) or BDB HA, the user has no > convenient way to recover the situation. BDB JE has no command line > interface so a Java program would have to be written with knowledge of the > store's structure. The HA case is further complicated by the fact that > sufficient nodes would have to be available to provide quorum within the > group. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8087) [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to recover
Keith Wall created QPID-8087: Summary: [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to recover Key: QPID-8087 URL: https://issues.apache.org/jira/browse/QPID-8087 Project: Qpid Issue Type: Bug Components: Broker-J Reporter: Keith Wall If the BDB HA VHN fails to complete the process of becoming a master (for instance due to a recovery problem such as QPID-8066), the node fails to go into an {{ERROR}} state. This makes it harder for the operator observing the console to know there is a problem. This is different to non-HA where the node goes into the ERROR state. The BDB HA node should go into ERROR state. The node must continue to remain a member of the HA group. If it did not do this, the condition would simply spread through the group, needlessly shutting down each node as it went. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org