[jira] [Commented] (PROTON-1734) [cpp] container.stop() doesn't work when called from non-proactor thread.
[
https://issues.apache.org/jira/browse/PROTON-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347964#comment-16347964
]
chao fan commented on PROTON-1734:
--
I also encountered this issue.
I use proton on Windows by VS2017. If not any receiver or sender is used which
is that none connection is opened, stopping container will not work and it
hangs in _GetQueuedCompletionStatus_.
I checked the function stop() and did not find any action to wakeup
_GetQueuedCompletionStatus_.
_void container::impl::stop(const proton::error_condition& err) {_
_GUARD(lock_);_
_auto_stop_ = true;_
_stopping_ = true;_
_pn_condition_t* error_condition = pn_condition();_
_set_error_condition(err, error_condition);_
_pn_proactor_disconnect(proactor_, error_condition);_
_pn_condition_free(error_condition);_
_}_
> [cpp] container.stop() doesn't work when called from non-proactor thread.
> -
>
> Key: PROTON-1734
> URL: https://issues.apache.org/jira/browse/PROTON-1734
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Affects Versions: proton-c-0.19.0
>Reporter: Alan Conway
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: proton-c-0.21.0
>
>
> Using the below code
> {code}
> #include
> #include
> #include
> int main( int, char** )
> {
> try
> {
> proton::container c;
> c.auto_stop( false );
> auto containerThread = std::thread([&]() { std::cout << "CONTAINER IS
> RUNNING" << std::endl;
>
> c.run(); std::cout << "CONTAINER IS DONE" << std::endl; });
> std::this_thread::sleep_for( std::chrono::seconds( 2 ));
> std::cout << "STOPPING CONTAINER" << std::endl;
> c.stop();
> std::cout << "WAITING FOR CONTAINER" << std::endl;
> containerThread.join();
> return 0;
> }
> catch( std::exception& e )
> {
> std::cerr << e.what() << std::endl;
> }
> return 1;
> }
> {code}
> via
> {code}
> [rkieley@i7t450s build]$ g++ -g -Wall -Wextra -Wpointer-arith -Wconversion
> -Wformat -Wformat-security -Wformat-y2k -Wsign-promo -Wcast-qual -g3 -ggdb3
> -Wunused-variable -fno-eliminate-unused-debug-types -O3 -DNDEBUG -fPIC
> -DPN_CPP_HAS_LAMBDAS=0 -std=gnu++11 ../attachments/test.cpp
> -lqpid-proton-cpp -lqpid-proton-core -lqpid-proton-proactor -lrt -lpthread -o
> test
> {code}
> With both PROACTOR epoll and libuv I see the following when run:
> {quote}
> [New Thread 0x73c95700 (LWP 20312)]
> CONTAINER IS RUNNING
> STOPPING CONTAINER
> WAITING FOR CONTAINER
> ^C
> Thread 1 "test" received signal SIGINT, Interrupt.
> {quote}
> When I use CTRL-C to stop waiting after running via gdb and waiting 2 minutes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1757) pn_netaddr_host_port() fails on FreeBSD
[ https://issues.apache.org/jira/browse/PROTON-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347926#comment-16347926 ] ASF subversion and git services commented on PROTON-1757: - Commit 61073481bd37db59cfe310b0a3f3555b34805211 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6107348 ] PROTON-1757: Fix pn_netaddr_socklen for FreeBSD > pn_netaddr_host_port() fails on FreeBSD > --- > > Key: PROTON-1757 > URL: https://issues.apache.org/jira/browse/PROTON-1757 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.20.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.21.0 > > > Many tests fail when building/testing on recent FreeBSD (10 and 11). > Ultimately this is due to the FreeBSD getnameinfo insisting that the passed > in socklen is the exact correct value for the sa_family. Whereas the > pn_netaddr_socklen code unconditionally says the length is the sizeof > sockaddr_storage - this is rejected by this implementation of getnameinfo. > It's not clear that this is the correct behaviour of getnameinfo, but it's > easy enough to allow for. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1757) pn_netaddr_host_port() fails on FreeBSD
Andrew Stitcher created PROTON-1757: --- Summary: pn_netaddr_host_port() fails on FreeBSD Key: PROTON-1757 URL: https://issues.apache.org/jira/browse/PROTON-1757 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: proton-c-0.20.0 Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: proton-c-0.21.0 Many tests fail when building/testing on recent FreeBSD (10 and 11). Ultimately this is due to the FreeBSD getnameinfo insisting that the passed in socklen is the exact correct value for the sa_family. Whereas the pn_netaddr_socklen code unconditionally says the length is the sizeof sockaddr_storage - this is rejected by this implementation of getnameinfo. It's not clear that this is the correct behaviour of getnameinfo, but it's easy enough to allow for. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-153) add support for application use of MessageAnnotations and DeliveryAnnotations
[ https://issues.apache.org/jira/browse/QPIDJMS-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347879#comment-16347879 ] Neeraj Makam commented on QPIDJMS-153: -- +1 for this feature. We need it for interop purposes between different languages. > add support for application use of MessageAnnotations and DeliveryAnnotations > - > > Key: QPIDJMS-153 > URL: https://issues.apache.org/jira/browse/QPIDJMS-153 > Project: Qpid JMS > Issue Type: New Feature > Components: qpid-jms-client >Reporter: Robbie Gemmell >Priority: Major > > Whilst the client makes use of MessageAnnotations internally for meta-data > relating to JMS semantics, it does not yet support applications making use of > them or DeliveryAnnotations either. > Some prior discussion and impl in the older JMS client may be relevant here, > e.g see QPID-6065 and QPID-6078 plus > http://qpid.2158936.n2.nabble.com/Setting-message-annotations-on-send-in-AMQP-1-0-td7612277.html. > There is an outstanding task to detail behaviour around this for the AMQP > JMS Mapping document also > https://issues.oasis-open.org/browse/AMQPBINDMAP-26. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1755) How do create sessions and links dynamically once the connection is open ?
[ https://issues.apache.org/jira/browse/PROTON-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347878#comment-16347878 ] Priyanka Mathur commented on PROTON-1755: - Any idea how the above mentioned scenario could work ? > How do create sessions and links dynamically once the connection is open ? > -- > > Key: PROTON-1755 > URL: https://issues.apache.org/jira/browse/PROTON-1755 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.25.0 >Reporter: Priyanka Mathur >Priority: Major > > Hi Proton-j folks, > We use proton-j library for establishing a connection and sending/receiving > messages over it.Until now we never had the need to *add* a new session or > new link to an existing and *opened* connection. Now that we have > multiplexing, we have the need to add a new session (and)/or add a new link > to already existing and opened connection. My question is how do I do that ? > Once we start the reactor, we receive several callbacks and callbacks of > importance here are > 1. onConnectionInit > 2. onConnectionBound -> we start a session > 3. onLinkInit -> we start a link > 4. onLinkRemoteOpen -> we check if link has opened > and the connection is now established. > Question is now that connection is opened, > how do I add a new session to the already opened connection ? > how do I add a new link to the already opened session ? > Is there any such support from proton-j ? As AMQP protocol clearly should > support it. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Get/Set Message annotations in QPID-JMS
Hi Qpid folks, I have an application need (interop between different language platforms) wherein I need to access the Delivery and Message annotations of the AMQP message. I see that there's a related conversation here: http://qpid.2158936.n2.nabble.com/Setting-message-annotations-on-send-in-AMQP-1-0-td7612277.html. Based on the discussion there, this issue was fixed in version 0.31 of QPID: https://issues.apache.org/jira/browse/QPID-6078. But this functionality is now missing in the latest version of the QPID-JMS. Could you help me with this? Thanks! Neeraj Makam
[jira] [Assigned] (QPID-8090) [Broker-J] Allow to specify all possible BoneCP configuration settings via context
[
https://issues.apache.org/jira/browse/QPID-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reassigned QPID-8090:
Assignee: Keith Wall (was: Alex Rudyy)
> [Broker-J] Allow to specify all possible BoneCP configuration settings via
> context
> --
>
> Key: QPID-8090
> URL: https://issues.apache.org/jira/browse/QPID-8090
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.0.1
>
>
> The current implementation of {{BoneCPConnectionProvider}} only allows to
> configure {{partitionCount}}, {{maxConnectionsPerPartition}} and
> {{minConnectionsPerPartition}}. In order to make
> {{BoneCPConnectionProvider}} more flexible to use, it should allow to set all
> possible configuration options allowed by {{com.jolbox.bonecp.BoneCPConfig}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8090) [Broker-J] Allow to specify all possible BoneCP configuration settings via context
[
https://issues.apache.org/jira/browse/QPID-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347371#comment-16347371
]
ASF subversion and git services commented on QPID-8090:
---
Commit 6adeac949a747b1527e603577310f39846265244 in qpid-broker-j's branch
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=6adeac9 ]
QPID-8090: [Broker-J] Support all available BoneCP configuration settings
> [Broker-J] Allow to specify all possible BoneCP configuration settings via
> context
> --
>
> Key: QPID-8090
> URL: https://issues.apache.org/jira/browse/QPID-8090
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.1
>
>
> The current implementation of {{BoneCPConnectionProvider}} only allows to
> configure {{partitionCount}}, {{maxConnectionsPerPartition}} and
> {{minConnectionsPerPartition}}. In order to make
> {{BoneCPConnectionProvider}} more flexible to use, it should allow to set all
> possible configuration options allowed by {{com.jolbox.bonecp.BoneCPConfig}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8090) [Broker-J] Allow to specify all possible BoneCP configuration settings via context
[
https://issues.apache.org/jira/browse/QPID-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reassigned QPID-8090:
Assignee: Alex Rudyy
> [Broker-J] Allow to specify all possible BoneCP configuration settings via
> context
> --
>
> Key: QPID-8090
> URL: https://issues.apache.org/jira/browse/QPID-8090
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.1
>
>
> The current implementation of {{BoneCPConnectionProvider}} only allows to
> configure {{partitionCount}}, {{maxConnectionsPerPartition}} and
> {{minConnectionsPerPartition}}. In order to make
> {{BoneCPConnectionProvider}} more flexible to use, it should allow to set all
> possible configuration options allowed by {{com.jolbox.bonecp.BoneCPConfig}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-7909) [Java Broker] CancelledKeyException can be thrown from a selector thread when accepting new connection on Broker shutdown
[
https://issues.apache.org/jira/browse/QPID-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reassigned QPID-7909:
Assignee: Alex Rudyy
> [Java Broker] CancelledKeyException can be thrown from a selector thread when
> accepting new connection on Broker shutdown
> -
>
> Key: QPID-7909
> URL: https://issues.apache.org/jira/browse/QPID-7909
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Attachments:
> TEST-org.apache.qpid.systest.management.amqp.AmqpManagementTest.testCreateQueueOnBrokerManagement.txt
>
>
> {{CancelledKeyException}} can be reported on broker shutdown when a new
> incoming connection is about to be accepted. The exception crashes the broker
> as it is not handled anywhere.
> The following thread stack trace is reported into broker logs
> {noformat}
> 2017-09-10 15:54:48,118 ERROR [Selector-Port-amqp]
> o.a.q.t.u.InternalBrokerHolder Uncaught exception from thread
> Selector-Port-amqp
> java.nio.channels.CancelledKeyException: null
> at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:73)
> at sun.nio.ch.SelectionKeyImpl.readyOps(SelectionKeyImpl.java:87)
> at java.nio.channels.SelectionKey.isAcceptable(SelectionKey.java:360)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.processSelectionKeys(SelectorThread.java:180)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:319)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> The broker log does not contain the logs for selector cancellation in
> {{SelectorThread#cancelAcceptingSocketAsync}} for amqp port. It does not look
> like selector was cancelled from Qpid code
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8090) [Broker-J] Allow to specify all possible BoneCP configuration settings via context
[
https://issues.apache.org/jira/browse/QPID-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8090:
-
Status: Reviewable (was: In Progress)
> [Broker-J] Allow to specify all possible BoneCP configuration settings via
> context
> --
>
> Key: QPID-8090
> URL: https://issues.apache.org/jira/browse/QPID-8090
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.1
>
>
> The current implementation of {{BoneCPConnectionProvider}} only allows to
> configure {{partitionCount}}, {{maxConnectionsPerPartition}} and
> {{minConnectionsPerPartition}}. In order to make
> {{BoneCPConnectionProvider}} more flexible to use, it should allow to set all
> possible configuration options allowed by {{com.jolbox.bonecp.BoneCPConfig}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-920) Enabled policy blocks inter-router links
[ https://issues.apache.org/jira/browse/DISPATCH-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347347#comment-16347347 ] ASF subversion and git services commented on DISPATCH-920: -- Commit 67747035a35537d52ba92247b067697079ade5ca in qpid-dispatch's branch refs/heads/master from [~chug] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=6774703 ] DISPATCH-920: Add Apache license > Enabled policy blocks inter-router links > > > Key: DISPATCH-920 > URL: https://issues.apache.org/jira/browse/DISPATCH-920 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.0.0 >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Blocker > Fix For: 1.1.0 > > > The default policy blocks the creation of receiver links with no source > address. Because the inter-router links have no addresses in their sources > or targets, the policy blocks inter-router router coordination. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7909) [Java Broker] CancelledKeyException can be thrown from a selector thread when accepting new connection on Broker shutdown
[
https://issues.apache.org/jira/browse/QPID-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-7909:
-
Fix Version/s: (was: Future)
> [Java Broker] CancelledKeyException can be thrown from a selector thread when
> accepting new connection on Broker shutdown
> -
>
> Key: QPID-7909
> URL: https://issues.apache.org/jira/browse/QPID-7909
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Priority: Minor
> Attachments:
> TEST-org.apache.qpid.systest.management.amqp.AmqpManagementTest.testCreateQueueOnBrokerManagement.txt
>
>
> {{CancelledKeyException}} can be reported on broker shutdown when a new
> incoming connection is about to be accepted. The exception crashes the broker
> as it is not handled anywhere.
> The following thread stack trace is reported into broker logs
> {noformat}
> 2017-09-10 15:54:48,118 ERROR [Selector-Port-amqp]
> o.a.q.t.u.InternalBrokerHolder Uncaught exception from thread
> Selector-Port-amqp
> java.nio.channels.CancelledKeyException: null
> at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:73)
> at sun.nio.ch.SelectionKeyImpl.readyOps(SelectionKeyImpl.java:87)
> at java.nio.channels.SelectionKey.isAcceptable(SelectionKey.java:360)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.processSelectionKeys(SelectorThread.java:180)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:319)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> The broker log does not contain the logs for selector cancellation in
> {{SelectorThread#cancelAcceptingSocketAsync}} for amqp port. It does not look
> like selector was cancelled from Qpid code
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-7909) [Java Broker] CancelledKeyException can be thrown from a selector thread when accepting new connection on Broker shutdown
[
https://issues.apache.org/jira/browse/QPID-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall resolved QPID-7909.
--
Resolution: Duplicate
> [Java Broker] CancelledKeyException can be thrown from a selector thread when
> accepting new connection on Broker shutdown
> -
>
> Key: QPID-7909
> URL: https://issues.apache.org/jira/browse/QPID-7909
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.0
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: Future
>
> Attachments:
> TEST-org.apache.qpid.systest.management.amqp.AmqpManagementTest.testCreateQueueOnBrokerManagement.txt
>
>
> {{CancelledKeyException}} can be reported on broker shutdown when a new
> incoming connection is about to be accepted. The exception crashes the broker
> as it is not handled anywhere.
> The following thread stack trace is reported into broker logs
> {noformat}
> 2017-09-10 15:54:48,118 ERROR [Selector-Port-amqp]
> o.a.q.t.u.InternalBrokerHolder Uncaught exception from thread
> Selector-Port-amqp
> java.nio.channels.CancelledKeyException: null
> at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:73)
> at sun.nio.ch.SelectionKeyImpl.readyOps(SelectionKeyImpl.java:87)
> at java.nio.channels.SelectionKey.isAcceptable(SelectionKey.java:360)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.processSelectionKeys(SelectorThread.java:180)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:319)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> The broker log does not contain the logs for selector cancellation in
> {{SelectorThread#cancelAcceptingSocketAsync}} for amqp port. It does not look
> like selector was cancelled from Qpid code
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #252: Tross dispatch 845 1
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/252#discussion_r165093678
--- Diff: tests/system_tests_dynamic_link_routes.py ---
@@ -0,0 +1,349 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+import unittest, os, json
+from subprocess import PIPE, STDOUT
+from proton import Message, PENDING, ACCEPTED, REJECTED, RELEASED,
SSLDomain, SSLUnavailable, Timeout, symbol
+from system_test import TestCase, Qdrouterd, main_module, DIR, Process
+from proton.handlers import MessagingHandler
+from proton.reactor import Container, DynamicNodeProperties
+
+# PROTON-828:
+try:
+from proton import MODIFIED
+except ImportError:
+from proton import PN_STATUS_MODIFIED as MODIFIED
+
+
+class RouterTest(TestCase):
+
+inter_router_port = None
+
+@classmethod
+def setUpClass(cls):
+"""Start a router"""
+super(RouterTest, cls).setUpClass()
+
+def router(name, connection):
+
+config = [
+('router', {'mode': 'interior', 'id': name}),
+('listener', {'port': cls.tester.get_port(),
'stripAnnotations': 'no'}),
+('listener', {'port': cls.tester.get_port(),
'stripAnnotations': 'no', 'multiTenant': 'yes'}),
+('listener', {'port': cls.tester.get_port(),
'stripAnnotations': 'no', 'role': 'route-container'}),
+('address', {'prefix': 'closest', 'distribution':
'closest'}),
+('address', {'prefix': 'spread', 'distribution':
'balanced'}),
+('address', {'prefix': 'multicast', 'distribution':
'multicast'}),
+connection
+]
+
+config = Qdrouterd.Config(config)
+
+cls.routers.append(cls.tester.qdrouterd(name, config,
wait=True))
+
+cls.routers = []
+
+inter_router_port = cls.tester.get_port()
+
+router('A', ('listener', {'role': 'inter-router', 'port':
inter_router_port}))
+router('B', ('connector', {'name': 'connectorToA', 'role':
'inter-router', 'port': inter_router_port, 'verifyHostName': 'no'}))
+
+cls.routers[0].wait_router_connected('B')
+cls.routers[1].wait_router_connected('A')
+
+
+def test_01_single_incoming_prefix(self):
+test = DynamicLinkRouteTest(self.routers[0].addresses[0],
+self.routers[0].addresses[0],
+self.routers[1].addresses[0],
+
{symbol('qd.link-route-patterns'):[u'linkRoute.prefix.#', symbol('in')]},
+[u'ClinkRoute.prefix'])
+test.run()
+self.assertEqual(None, test.error)
+
+
+def test_02_single_outgoing_prefix(self):
+test = DynamicLinkRouteTest(self.routers[0].addresses[0],
+self.routers[0].addresses[0],
+self.routers[1].addresses[0],
+
{symbol('qd.link-route-patterns'):[u'linkRoute.prefix.#', symbol('out')]},
+[u'DlinkRoute.prefix'])
+test.run()
+self.assertEqual(None, test.error)
+
+
+def test_03_single_inout_prefix(self):
+test = DynamicLinkRouteTest(self.routers[0].addresses[0],
+self.routers[0].addresses[0],
+self.routers[1].addresses[0],
+
{symbol('qd.link-route-patterns'):[u'linkRoute.prefix.#', symbol('inout')]},
+[u'ClinkRoute.prefix',
u'DlinkRoute.prefix'])
+test.run()
+self.assertEqual(None, test.error)
+
+
+def test_04_single_incoming_pattern(self):
+test = DynamicLinkRouteTest(self.routers[0]
[jira] [Created] (QPID-8090) [Broker-J] Allow to specify all possible BoneCP configuration settings via context
Alex Rudyy created QPID-8090:
Summary: [Broker-J] Allow to specify all possible BoneCP
configuration settings via context
Key: QPID-8090
URL: https://issues.apache.org/jira/browse/QPID-8090
Project: Qpid
Issue Type: Improvement
Components: Broker-J
Affects Versions: qpid-java-broker-7.0.0
Reporter: Alex Rudyy
Fix For: qpid-java-broker-7.0.1
The current implementation of {{BoneCPConnectionProvider}} only allows to
configure {{partitionCount}}, {{maxConnectionsPerPartition}} and
{{minConnectionsPerPartition}}. In order to make {{BoneCPConnectionProvider}}
more flexible to use, it should allow to set all possible configuration options
allowed by {{com.jolbox.bonecp.BoneCPConfig}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #252: Tross dispatch 845 1
Github user ted-ross commented on the issue: https://github.com/apache/qpid-dispatch/pull/252 Re: Questions from @gemmellr - This probably merits additional documentation. When there are multiple link-route destinations that match the same patterns, link attaches are balanced across the destinations. Multiple destinations with the same address share the link load. - It would be desirable to have policy hooks to allow/disallow this feature. More importantly, existing produce/consume rights should be enforced based on allowed addresses. The complexity is the wildcard patterns. We don't currently have a way to determine if a pattern is allowed. We can only do this with individual addresses. One solution is to enforce access at link-attach time when the specific address is known. Another is to implement some form of pattern validation. The former is not good because it might cause links to be dropped by one destination when they could have been accepted by another. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #252: Tross dispatch 845 1
Github user ganeshmurthy commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/252#discussion_r165080527 --- Diff: doc/book/link_routing.adoc --- @@ -164,3 +164,37 @@ link-routing. The above configuration allows Rb and Rp to reject attaches that should be routed to B2 with an error message that indicates that there is no route available to the destination. + +Automatic Link Routes +~ + +There is an alternative way to use link routes that doesn't involve any --- End diff -- If we decide that these link routes will not show up in the qdstat --linkRoute, should we add a comment here indicating that these link routes will not show up in the qdstat output? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #252: Tross dispatch 845 1
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/252#discussion_r165080053
--- Diff: src/router_core/route_control.c ---
@@ -266,6 +266,117 @@ static void qdr_auto_link_deactivate_CT(qdr_core_t
*core, qdr_auto_link_t *al, q
}
+static void qdr_router_add_link_route_pattern_CT(qdr_core_t *core,
qdr_connection_t *conn, const char *pattern, qd_direction_t dir)
+{
+if (*pattern == '\0')
+return;
+
+char *addr_hash = qdr_link_route_pattern_to_address(pattern,
dir);
+qd_iterator_t *iter = qd_iterator_string(addr_hash + 1,
ITER_VIEW_ADDRESS_HASH);
+qdr_address_t *addr = 0;
+
+qd_iterator_annotate_prefix(iter, addr_hash[0]);
+if (conn->tenant_space)
+qd_iterator_annotate_space(iter, conn->tenant_space,
conn->tenant_space_len);
+
+qd_hash_retrieve(core->addr_hash, iter, (void*) &addr);
+if (!addr) {
+addr = qdr_address_CT(core, QD_TREATMENT_LINK_BALANCED);
+DEQ_INSERT_TAIL(core->addrs, addr);
+qd_hash_insert(core->addr_hash, iter, addr, &addr->hash_handle);
+qdr_link_route_map_pattern_CT(core, iter, addr);
+}
+
+qdr_add_address_ref(&conn->addr_refs, addr);
+qdr_add_connection_ref(&addr->conns, conn);
+if (DEQ_SIZE(addr->conns) == 1) {
+char *hash_key = (char*) qd_iterator_copy(iter);
+qdr_post_mobile_added_CT(core, hash_key);
+free(hash_key);
+}
+
+free(addr_hash);
+}
+
+
+static void qdr_route_use_connection_properties_CT(qdr_core_t *core,
qdr_connection_t *conn)
+{
+pn_data_t *p = conn->connection_info->connection_properties;
+
+//
+// If there are no connection properties, we have nothing to do.
+//
+if (!p)
+return;
+
+pn_data_rewind(p);
+pn_data_next(p);
+
+//
+// If the connection properties are not a map, there's no point in
continuing.
+//
+if (pn_data_type(p) != PN_MAP)
+return;
+
+pn_data_enter(p);
+pn_data_next(p);
+
+//
+// Work across the map looking for keys that are relevant for route
modification.
+//
+while (pn_data_type(p) == PN_SYMBOL) {
--- End diff --
After a little bit thought, I do feel that these link routes must show up
when you do a qdstat --linkRoutes. Maybe these link routes can have a boolean
flag on them called "dynamic" which can be set to true for these link routes
which will distinguish them from the pre-configured link routes which will have
that flag set to false.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #252: Tross dispatch 845 1
Github user gemmellr commented on the issue: https://github.com/apache/qpid-dispatch/pull/252 Couple of questions. Probably a thing to consider even with the existing config method, but how are routes treated when more than one connection says it matches something? How does this integrate with the policy stuff, e.g. is it possible to control who can set up routes this way and which addresses they can do it for? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #252: Tross dispatch 845 1
Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/252#discussion_r165070145 --- Diff: doc/book/link_routing.adoc --- @@ -164,3 +164,37 @@ link-routing. The above configuration allows Rb and Rp to reject attaches that should be routed to B2 with an error message that indicates that there is no route available to the destination. + +Automatic Link Routes +~ + +There is an alternative way to use link routes that doesn't involve any +configuration. An endpoint connected to a router may declare, using +connection properties, its availability to accept routed links for a +specific set of addresses. This connection may be connected to the router +through a normal listener. There is no need to create a listener with the +'route-container' role. + +The connection property that controls this feature is +'qd.link-route-patterns'. + +To use the feature, a client provides a connection property when opening +the connection to the router. The property has the key +'qd.link-route-patterns'. The value is a list containing an even number of +elements, arranged in pairs. The first element in a pair is a string +containing the link route pattern. This uses the same syntax that would be +used in a linkRoutePattern configuration item. The second element in the --- End diff -- Good point. I meant the pattern attribute for linkRoute. This needs to be clarified. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #252: Tross dispatch 845 1
Github user ganeshmurthy commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/252#discussion_r165067747 --- Diff: doc/book/link_routing.adoc --- @@ -164,3 +164,37 @@ link-routing. The above configuration allows Rb and Rp to reject attaches that should be routed to B2 with an error message that indicates that there is no route available to the destination. + +Automatic Link Routes +~ + +There is an alternative way to use link routes that doesn't involve any +configuration. An endpoint connected to a router may declare, using +connection properties, its availability to accept routed links for a +specific set of addresses. This connection may be connected to the router +through a normal listener. There is no need to create a listener with the +'route-container' role. + +The connection property that controls this feature is +'qd.link-route-patterns'. + +To use the feature, a client provides a connection property when opening +the connection to the router. The property has the key +'qd.link-route-patterns'. The value is a list containing an even number of +elements, arranged in pairs. The first element in a pair is a string +containing the link route pattern. This uses the same syntax that would be +used in a linkRoutePattern configuration item. The second element in the --- End diff -- 'linkRoutePattern' config item has been deprecated and removed from schema. Currently 'linkRoute' is used. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (QPID-8087) [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to recover
[
https://issues.apache.org/jira/browse/QPID-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reopened QPID-8087:
--
Please merge them into 7.0.x branch
> [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to
> recover
>
>
> Key: QPID-8087
> URL: https://issues.apache.org/jira/browse/QPID-8087
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.0.1
>
>
> If the BDB HA VHN fails to complete the process of becoming a master (for
> instance due to a recovery problem such as QPID-8066), the node fails to go
> into an {{ERROR}} state. This makes it harder for the operator observing the
> console to know there is a problem. This is different to non-HA where the
> node goes into the ERROR state.
> The BDB HA node should go into ERROR state. The node must continue to remain
> a member of the HA group. If it did not do this, the condition would simply
> spread through the group, needlessly shutting down each node as it went.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8087) [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to recover
[
https://issues.apache.org/jira/browse/QPID-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy resolved QPID-8087.
--
Resolution: Fixed
The changes look reasonable to me
> [BDB] [HA] Virtualhostnode fails to go into ERROR state following failure to
> recover
>
>
> Key: QPID-8087
> URL: https://issues.apache.org/jira/browse/QPID-8087
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.0.1
>
>
> If the BDB HA VHN fails to complete the process of becoming a master (for
> instance due to a recovery problem such as QPID-8066), the node fails to go
> into an {{ERROR}} state. This makes it harder for the operator observing the
> console to know there is a problem. This is different to non-HA where the
> node goes into the ERROR state.
> The BDB HA node should go into ERROR state. The node must continue to remain
> a member of the HA group. If it did not do this, the condition would simply
> spread through the group, needlessly shutting down each node as it went.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-845) Allow connecting containers to declare their availability for link routes
[ https://issues.apache.org/jira/browse/DISPATCH-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346891#comment-16346891 ] ASF GitHub Bot commented on DISPATCH-845: - GitHub user ted-ross opened a pull request: https://github.com/apache/qpid-dispatch/pull/252 Tross dispatch 845 1 Add automatic link-routes via a connection property. See https://issues.apache.org/jira/browse/DISPATCH-845 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ted-ross/qpid-dispatch tross-DISPATCH-845-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/252.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #252 commit cdf2c99071811d42891d7a8b7e5d4acd21819ad8 Author: Ted Ross Date: 2017-10-03T18:22:58Z DISPATCH-845 - Added connection-scoped link-route destinations. commit 8a323bd614195b6098e1962dcd1845c0d4cee098 Author: Ted Ross Date: 2017-10-03T18:29:31Z DISPATCH-845 - Added test commit 193df0c7f3e1a21b951580b576b8da0de0c04aaa Author: Ted Ross Date: 2018-01-02T19:27:16Z DISPATCH-845 - Fixed bug in properties traversal. A symbol value caused an infinite parse loop. commit b7fc23bd328b6e6dcc2f20334a4f1bdcf0e18553 Author: Ted Ross Date: 2018-01-31T14:17:47Z DISPATCH-845 - Added documentation update > Allow connecting containers to declare their availability for link routes > - > > Key: DISPATCH-845 > URL: https://issues.apache.org/jira/browse/DISPATCH-845 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.1.0 > > > In the case where a container wishes to connect to a router network and > accept incoming routed link attaches (i.e. become a destination for link > routes), it is now quite complicated to do so. First, the connected router > must be configured with a listener in the route-container role. Second, > there must be linkRoute objects configured for each prefix or pattern for the > connected container. > A more efficient mechanism for dynamic/ephemeral link routes can be supported > as follows: > * A container opening a connection to the router may provide a connection > property that contains a list of prefixes and/or patterns for link routes. > * During the lifecycle of that connection, the router maintains active > link-route addresses targeting that container. > This feature allows for lightweight establishment of link-route destinations > without the need for connection roles and configured link-routes with > independently managed lifecycles (active, inactive, etc.). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #204: DISPATCH-845 - Added connection-scoped link...
Github user ted-ross closed the pull request at: https://github.com/apache/qpid-dispatch/pull/204 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-845) Allow connecting containers to declare their availability for link routes
[ https://issues.apache.org/jira/browse/DISPATCH-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346893#comment-16346893 ] ASF GitHub Bot commented on DISPATCH-845: - Github user ted-ross closed the pull request at: https://github.com/apache/qpid-dispatch/pull/204 > Allow connecting containers to declare their availability for link routes > - > > Key: DISPATCH-845 > URL: https://issues.apache.org/jira/browse/DISPATCH-845 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.1.0 > > > In the case where a container wishes to connect to a router network and > accept incoming routed link attaches (i.e. become a destination for link > routes), it is now quite complicated to do so. First, the connected router > must be configured with a listener in the route-container role. Second, > there must be linkRoute objects configured for each prefix or pattern for the > connected container. > A more efficient mechanism for dynamic/ephemeral link routes can be supported > as follows: > * A container opening a connection to the router may provide a connection > property that contains a list of prefixes and/or patterns for link routes. > * During the lifecycle of that connection, the router maintains active > link-route addresses targeting that container. > This feature allows for lightweight establishment of link-route destinations > without the need for connection roles and configured link-routes with > independently managed lifecycles (active, inactive, etc.). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #252: Tross dispatch 845 1
GitHub user ted-ross opened a pull request: https://github.com/apache/qpid-dispatch/pull/252 Tross dispatch 845 1 Add automatic link-routes via a connection property. See https://issues.apache.org/jira/browse/DISPATCH-845 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ted-ross/qpid-dispatch tross-DISPATCH-845-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/252.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #252 commit cdf2c99071811d42891d7a8b7e5d4acd21819ad8 Author: Ted Ross Date: 2017-10-03T18:22:58Z DISPATCH-845 - Added connection-scoped link-route destinations. commit 8a323bd614195b6098e1962dcd1845c0d4cee098 Author: Ted Ross Date: 2017-10-03T18:29:31Z DISPATCH-845 - Added test commit 193df0c7f3e1a21b951580b576b8da0de0c04aaa Author: Ted Ross Date: 2018-01-02T19:27:16Z DISPATCH-845 - Fixed bug in properties traversal. A symbol value caused an infinite parse loop. commit b7fc23bd328b6e6dcc2f20334a4f1bdcf0e18553 Author: Ted Ross Date: 2018-01-31T14:17:47Z DISPATCH-845 - Added documentation update --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-8066) [Broker-J] Virtual host logger rules are left over in configuration store after deletion of virtual host logger on provided virtual host causing virtualhost restart
[
https://issues.apache.org/jira/browse/QPID-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346871#comment-16346871
]
Alex Rudyy edited comment on QPID-8066 at 1/31/18 2:06 PM:
---
The implemented changes reviled a defect with jdbc store deletion on VHN/VH
removal: the current implementation throws {{IllegalStateException}} on attempt
to delete the JDBC configuration/message store on configured object removal:
{noformat}
java.lang.IllegalStateException: Message store is not open
at
org.apache.qpid.server.store.derby.AbstractDerbyMessageStore.checkMessageStoreOpen(AbstractDerbyMessageStore.java:118)
at
org.apache.qpid.server.store.derby.DerbyConfigurationStore$ProvidedMessageStore.getConnection(DerbyConfigurationStore.java:211)
at
org.apache.qpid.server.store.jdbc.AbstractJDBCMessageStore.newConnection(AbstractJDBCMessageStore.java:497)
at
org.apache.qpid.server.store.jdbc.AbstractJDBCMessageStore.newAutoCommitConnection(AbstractJDBCMessageStore.java:470)
at
org.apache.qpid.server.store.jdbc.AbstractJDBCMessageStore.onDelete(AbstractJDBCMessageStore.java:1825)
at
org.apache.qpid.server.virtualhostnode.AbstractStandardVirtualHostNode.lambda$onDelete$0(AbstractStandardVirtualHostNode.java:136)
at
org.apache.qpid.server.virtualhostnode.AbstractStandardVirtualHostNode$$Lambda$60.C4761E40.run(Unknown
Source)
at
org.apache.qpid.server.model.AbstractConfiguredObject$23.onSuccess(AbstractConfiguredObject.java:2691)
at
org.apache.qpid.server.model.AbstractConfiguredObject$24$1.run(AbstractConfiguredObject.java:2732)
at
org.apache.qpid.server.model.AbstractConfiguredObject$24$1.run(AbstractConfiguredObject.java:2728)
at
java.security.AccessController.doPrivileged(AccessController.java:664)
at javax.security.auth.Subject.doAs(Subject.java:488)
at
org.apache.qpid.server.model.AbstractConfiguredObject$24.onSuccess(AbstractConfiguredObject.java:2727)
at
com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1237)
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor$1$1.run(TaskExecutorImpl.java:415)
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor$1$1.run(TaskExecutorImpl.java:411)
at
java.security.AccessController.doPrivileged(AccessController.java:664)
at javax.security.auth.Subject.doAs(Subject.java:488)
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor$1.run(TaskExecutorImpl.java:410)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1160)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at
org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
at
org.apache.qpid.server.bytebuffer.QpidByteBufferFactory$$Lambda$16.51485EA0.run(Unknown
Source)
at java.lang.Thread.run(Thread.java:811)
{noformat}
was (Author: alex.rufous):
The implemented changes reviled the defect with jdbc store deletion on VHN/VH
removal
> [Broker-J] Virtual host logger rules are left over in configuration store
> after deletion of virtual host logger on provided virtual host causing
> virtualhost restart failure
>
>
> Key: QPID-8066
> URL: https://issues.apache.org/jira/browse/QPID-8066
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Critical
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
> Attachments:
> 0001-QPID-8066-Broker-J-Remove-all-children-records-recur.patch,
> QPID-8066.tar.bz2
>
>
> Virtual host logger rules are left over in configuration store after deletion
> of virtual host logger on provided virtual host. On restart of VHN or Broker,
> virtual host recovery fails with IllegalArgumentException as the one below:
> {noformat}
> java.lang.IllegalArgumentException: Recovered configured object record
> BDBConfiguredObjectRecord [id=8e9c5547-c41b-4443-9333-48dac61f3b40,
> type=VirtualHostLogInclusionRule, name=test, parents={}] has no recorded
> parents and is not a va
[jira] [Commented] (QPID-8066) [Broker-J] Virtual host logger rules are left over in configuration store after deletion of virtual host logger on provided virtual host causing virtualhost restart fail
[
https://issues.apache.org/jira/browse/QPID-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346880#comment-16346880
]
ASF subversion and git services commented on QPID-8066:
---
Commit bce93dfb642ef30a87227377d71c588b084d7d04 in qpid-broker-j's branch
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=bce93df ]
QPID-8066: [Broker-J] Fix jdbc store deletion on removal of Virtual Host Node
or/and Virtual Host
> [Broker-J] Virtual host logger rules are left over in configuration store
> after deletion of virtual host logger on provided virtual host causing
> virtualhost restart failure
>
>
> Key: QPID-8066
> URL: https://issues.apache.org/jira/browse/QPID-8066
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Critical
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
> Attachments:
> 0001-QPID-8066-Broker-J-Remove-all-children-records-recur.patch,
> QPID-8066.tar.bz2
>
>
> Virtual host logger rules are left over in configuration store after deletion
> of virtual host logger on provided virtual host. On restart of VHN or Broker,
> virtual host recovery fails with IllegalArgumentException as the one below:
> {noformat}
> java.lang.IllegalArgumentException: Recovered configured object record
> BDBConfiguredObjectRecord [id=8e9c5547-c41b-4443-9333-48dac61f3b40,
> type=VirtualHostLogInclusionRule, name=test, parents={}] has no recorded
> parents and is not a valid child type [[interface
> org.apache.qpid.server.model.VirtualHost, interface
> org.apache.qpid.server.model.RemoteReplicationNode]] for the root
> BDBVirtualHostNodeImplWithAccessChecking
> [id=591aa6d9-c2e0-474c-a0a9-86eb14bc3c6a, name=bdb,
> storePath=/home/alex/.qpid-7.1.0-SNAPSHOT/bdb/config]
> at
> org.apache.qpid.server.store.GenericRecoverer.resolveDiscontinuity(GenericRecoverer.java:119)
> at
> org.apache.qpid.server.store.GenericRecoverer.performRecover(GenericRecoverer.java:90)
> at
> org.apache.qpid.server.store.GenericRecoverer.access$000(GenericRecoverer.java:41)
> at
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:59)
> at
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:55)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.run(TaskExecutorImpl.java:190)
> at
> org.apache.qpid.server.store.GenericRecoverer.recover(GenericRecoverer.java:54)
> at
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.recover(VirtualHostStoreUpgraderAndRecoverer.java:1085)
> at
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.upgradeAndRecover(VirtualHostStoreUpgraderAndRecoverer.java:1058)
> at
> org.apache.qpid.server.virtualhostnode.AbstractStandardVirtualHostNode.activate(AbstractStandardVirtualHostNode.java:91)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at
> org.apache.qpid.server
[jira] [Commented] (QPID-8066) [Broker-J] Virtual host logger rules are left over in configuration store after deletion of virtual host logger on provided virtual host causing virtualhost restart fail
[
https://issues.apache.org/jira/browse/QPID-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346871#comment-16346871
]
Alex Rudyy commented on QPID-8066:
--
The implemented changes reviled the defect with jdbc store deletion on VHN/VH
removal
> [Broker-J] Virtual host logger rules are left over in configuration store
> after deletion of virtual host logger on provided virtual host causing
> virtualhost restart failure
>
>
> Key: QPID-8066
> URL: https://issues.apache.org/jira/browse/QPID-8066
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Critical
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
> Attachments:
> 0001-QPID-8066-Broker-J-Remove-all-children-records-recur.patch,
> QPID-8066.tar.bz2
>
>
> Virtual host logger rules are left over in configuration store after deletion
> of virtual host logger on provided virtual host. On restart of VHN or Broker,
> virtual host recovery fails with IllegalArgumentException as the one below:
> {noformat}
> java.lang.IllegalArgumentException: Recovered configured object record
> BDBConfiguredObjectRecord [id=8e9c5547-c41b-4443-9333-48dac61f3b40,
> type=VirtualHostLogInclusionRule, name=test, parents={}] has no recorded
> parents and is not a valid child type [[interface
> org.apache.qpid.server.model.VirtualHost, interface
> org.apache.qpid.server.model.RemoteReplicationNode]] for the root
> BDBVirtualHostNodeImplWithAccessChecking
> [id=591aa6d9-c2e0-474c-a0a9-86eb14bc3c6a, name=bdb,
> storePath=/home/alex/.qpid-7.1.0-SNAPSHOT/bdb/config]
> at
> org.apache.qpid.server.store.GenericRecoverer.resolveDiscontinuity(GenericRecoverer.java:119)
> at
> org.apache.qpid.server.store.GenericRecoverer.performRecover(GenericRecoverer.java:90)
> at
> org.apache.qpid.server.store.GenericRecoverer.access$000(GenericRecoverer.java:41)
> at
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:59)
> at
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:55)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.run(TaskExecutorImpl.java:190)
> at
> org.apache.qpid.server.store.GenericRecoverer.recover(GenericRecoverer.java:54)
> at
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.recover(VirtualHostStoreUpgraderAndRecoverer.java:1085)
> at
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.upgradeAndRecover(VirtualHostStoreUpgraderAndRecoverer.java:1058)
> at
> org.apache.qpid.server.virtualhostnode.AbstractStandardVirtualHostNode.activate(AbstractStandardVirtualHostNode.java:91)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at
> org.apache.qpi
[jira] [Reopened] (QPID-8066) [Broker-J] Virtual host logger rules are left over in configuration store after deletion of virtual host logger on provided virtual host causing virtualhost restart failu
[
https://issues.apache.org/jira/browse/QPID-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reopened QPID-8066:
--
> [Broker-J] Virtual host logger rules are left over in configuration store
> after deletion of virtual host logger on provided virtual host causing
> virtualhost restart failure
>
>
> Key: QPID-8066
> URL: https://issues.apache.org/jira/browse/QPID-8066
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Critical
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
> Attachments:
> 0001-QPID-8066-Broker-J-Remove-all-children-records-recur.patch,
> QPID-8066.tar.bz2
>
>
> Virtual host logger rules are left over in configuration store after deletion
> of virtual host logger on provided virtual host. On restart of VHN or Broker,
> virtual host recovery fails with IllegalArgumentException as the one below:
> {noformat}
> java.lang.IllegalArgumentException: Recovered configured object record
> BDBConfiguredObjectRecord [id=8e9c5547-c41b-4443-9333-48dac61f3b40,
> type=VirtualHostLogInclusionRule, name=test, parents={}] has no recorded
> parents and is not a valid child type [[interface
> org.apache.qpid.server.model.VirtualHost, interface
> org.apache.qpid.server.model.RemoteReplicationNode]] for the root
> BDBVirtualHostNodeImplWithAccessChecking
> [id=591aa6d9-c2e0-474c-a0a9-86eb14bc3c6a, name=bdb,
> storePath=/home/alex/.qpid-7.1.0-SNAPSHOT/bdb/config]
> at
> org.apache.qpid.server.store.GenericRecoverer.resolveDiscontinuity(GenericRecoverer.java:119)
> at
> org.apache.qpid.server.store.GenericRecoverer.performRecover(GenericRecoverer.java:90)
> at
> org.apache.qpid.server.store.GenericRecoverer.access$000(GenericRecoverer.java:41)
> at
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:59)
> at
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:55)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.run(TaskExecutorImpl.java:190)
> at
> org.apache.qpid.server.store.GenericRecoverer.recover(GenericRecoverer.java:54)
> at
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.recover(VirtualHostStoreUpgraderAndRecoverer.java:1085)
> at
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.upgradeAndRecover(VirtualHostStoreUpgraderAndRecoverer.java:1058)
> at
> org.apache.qpid.server.virtualhostnode.AbstractStandardVirtualHostNode.activate(AbstractStandardVirtualHostNode.java:91)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2634)
> at
> com.google.common.util.concurrent.Futu
[jira] [Updated] (QPID-8089) [Broker-J][HTTP Management] Activate dynamically added HTTP ports on creation
[
https://issues.apache.org/jira/browse/QPID-8089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8089:
-
Attachment: 0001-QPID-8089-WIP.patch
> [Broker-J][HTTP Management] Activate dynamically added HTTP ports on creation
> --
>
> Key: QPID-8089
> URL: https://issues.apache.org/jira/browse/QPID-8089
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments: 0001-QPID-8089-WIP.patch
>
>
> Currently the newly added http ports are put into {{QUIESCED}} state. The
> broker restart is required to allow handling of HTTP requests in the port. In
> order to avoid broker restart, the newly added HTTP ports should be activated
> immediately on creation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8085) [Broker-J][AMQP 1.0] Optimize the sending of flow performatives from broker sending link endpoint
[ https://issues.apache.org/jira/browse/QPID-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-8085. -- Resolution: Fixed Seems reasonable to me. > [Broker-J][AMQP 1.0] Optimize the sending of flow performatives from broker > sending link endpoint > - > > Key: QPID-8085 > URL: https://issues.apache.org/jira/browse/QPID-8085 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > The broker sending link endpoint sends flow performatives when more than > half of the credits issued by receiving link endpoint is used. Such behaviour > is spec compliant, though, it might effect the messaging throughput as the > unnecessary flows consume bandwidth and might impact the performance. > We can simply restrict the sending link endpoint to send flow only in reply > to incoming flows with echo= true or drain=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8085) [Broker-J][AMQP 1.0] Optimize the sending of flow performatives from broker sending link endpoint
[ https://issues.apache.org/jira/browse/QPID-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8085: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J][AMQP 1.0] Optimize the sending of flow performatives from broker > sending link endpoint > - > > Key: QPID-8085 > URL: https://issues.apache.org/jira/browse/QPID-8085 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > The broker sending link endpoint sends flow performatives when more than > half of the credits issued by receiving link endpoint is used. Such behaviour > is spec compliant, though, it might effect the messaging throughput as the > unnecessary flows consume bandwidth and might impact the performance. > We can simply restrict the sending link endpoint to send flow only in reply > to incoming flows with echo= true or drain=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8066) [Broker-J] Virtual host logger rules are left over in configuration store after deletion of virtual host logger on provided virtual host causing virtualhost restart failu
[
https://issues.apache.org/jira/browse/QPID-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall resolved QPID-8066.
--
Resolution: Fixed
Tactical change for 7.0.x and 6.1.x looks good.
> [Broker-J] Virtual host logger rules are left over in configuration store
> after deletion of virtual host logger on provided virtual host causing
> virtualhost restart failure
>
>
> Key: QPID-8066
> URL: https://issues.apache.org/jira/browse/QPID-8066
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Critical
> Fix For: qpid-java-broker-7.0.1, qpid-java-broker-7.1.0
>
> Attachments:
> 0001-QPID-8066-Broker-J-Remove-all-children-records-recur.patch,
> QPID-8066.tar.bz2
>
>
> Virtual host logger rules are left over in configuration store after deletion
> of virtual host logger on provided virtual host. On restart of VHN or Broker,
> virtual host recovery fails with IllegalArgumentException as the one below:
> {noformat}
> java.lang.IllegalArgumentException: Recovered configured object record
> BDBConfiguredObjectRecord [id=8e9c5547-c41b-4443-9333-48dac61f3b40,
> type=VirtualHostLogInclusionRule, name=test, parents={}] has no recorded
> parents and is not a valid child type [[interface
> org.apache.qpid.server.model.VirtualHost, interface
> org.apache.qpid.server.model.RemoteReplicationNode]] for the root
> BDBVirtualHostNodeImplWithAccessChecking
> [id=591aa6d9-c2e0-474c-a0a9-86eb14bc3c6a, name=bdb,
> storePath=/home/alex/.qpid-7.1.0-SNAPSHOT/bdb/config]
> at
> org.apache.qpid.server.store.GenericRecoverer.resolveDiscontinuity(GenericRecoverer.java:119)
> at
> org.apache.qpid.server.store.GenericRecoverer.performRecover(GenericRecoverer.java:90)
> at
> org.apache.qpid.server.store.GenericRecoverer.access$000(GenericRecoverer.java:41)
> at
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:59)
> at
> org.apache.qpid.server.store.GenericRecoverer$1.execute(GenericRecoverer.java:55)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:165)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.run(TaskExecutorImpl.java:190)
> at
> org.apache.qpid.server.store.GenericRecoverer.recover(GenericRecoverer.java:54)
> at
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.recover(VirtualHostStoreUpgraderAndRecoverer.java:1085)
> at
> org.apache.qpid.server.store.VirtualHostStoreUpgraderAndRecoverer.upgradeAndRecover(VirtualHostStoreUpgraderAndRecoverer.java:1058)
> at
> org.apache.qpid.server.virtualhostnode.AbstractStandardVirtualHostNode.activate(AbstractStandardVirtualHostNode.java:91)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredO
[jira] [Updated] (QPID-7632) [AMQP 0-10] NPE from QueueQuery when queue argument omitted
[
https://issues.apache.org/jira/browse/QPID-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-7632:
-
Fix Version/s: (was: qpid-java-broker-7.0.1)
Future
> [AMQP 0-10] NPE from QueueQuery when queue argument omitted
> ---
>
> Key: QPID-7632
> URL: https://issues.apache.org/jira/browse/QPID-7632
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Reporter: Keith Wall
>Priority: Minor
> Fix For: Future
>
>
> A client generated an illegal {{QueueQuery}} (null queue argument). This
> caused a NPE server side, and an {{INTERNAL_ERROR}} to be returned to the
> peer.
> An {{ILLEGAL_ARGUMENT}} or {{INVALID_ARGUMENT}} would have probably been more
> appropriate.
> This problem did not cause a server crash.
> {noformat}
> 017-01-19 17:01:40,459 DEBUG [IO-/127.0.0.1:56497] o.a.q.t.Connection
> RECV: [conn:3cd09483] ch=1 QueueQuery()
> 2017-01-19 17:01:40,460 DEBUG [IO-/127.0.0.1:56497] o.a.q.t.Session
> identify: ch=1, commandId=0
> 2017-01-19 17:01:40,471 ERROR [IO-/127.0.0.1:56497]
> o.a.q.s.p.v.ServerSessionDelegate Exception processing command
> java.lang.NullPointerException: null
> at
> java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
> ~[na:1.8.0_111]
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.getChildByName(AbstractConfiguredObject.java:2306)
> ~[classes/:na]
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.getAttainedChildByName(AbstractConfiguredObject.java:2324)
> ~[classes/:na]
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.awaitChildClassToAttainState(AbstractConfiguredObject.java:3081)
> ~[classes/:na]
> at
> org.apache.qpid.server.virtualhost.AbstractVirtualHost.getAttainedMessageSource(AbstractVirtualHost.java:1246)
> ~[classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerSessionDelegate.getMessageSource(ServerSessionDelegate.java:1458)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerSessionDelegate.queueQuery(ServerSessionDelegate.java:1667)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerSessionDelegate.queueQuery(ServerSessionDelegate.java:87)
> [classes/:na]
> at org.apache.qpid.transport.QueueQuery.dispatch(QueueQuery.java:87)
> [classes/:na]
> at
> org.apache.qpid.transport.SessionDelegate.command(SessionDelegate.java:57)
> ~[classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerSessionDelegate.command(ServerSessionDelegate.java:104)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerSessionDelegate.command(ServerSessionDelegate.java:87)
> [classes/:na]
> at org.apache.qpid.transport.Method.delegate(Method.java:153)
> [classes/:na]
> at org.apache.qpid.transport.Session.received(Session.java:582)
> [classes/:na]
> at org.apache.qpid.transport.Connection.dispatch(Connection.java:448)
> [classes/:na]
> at
> org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:65)
> [classes/:na]
> at
> org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:41)
> [classes/:na]
> at
> org.apache.qpid.transport.MethodDelegate.queueQuery(MethodDelegate.java:215)
> [classes/:na]
> at org.apache.qpid.transport.QueueQuery.dispatch(QueueQuery.java:87)
> [classes/:na]
> at
> org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:55)
> [classes/:na]
> at
> org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:41)
> [classes/:na]
> at org.apache.qpid.transport.Method.delegate(Method.java:153)
> [classes/:na]
> at org.apache.qpid.transport.Connection.received(Connection.java:401)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerConnection.access$001(ServerConnection.java:67)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerConnection$2.run(ServerConnection.java:263)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerConnection$2.run(ServerConnection.java:259)
> [classes/:na]
> at java.security.AccessController.doPrivileged(Native Method)
> [na:1.8.0_111]
> at
> org.apache.qpid.server.protocol.v0_10.ServerConnection.received(ServerConnection.java:258)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerAssembler.emit(ServerAssembler.java:115)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerAssembler.assemble(ServerAssembler.java:204)
> [classes/:na]
> at
> org.apache.qpid.server.protocol.v0_10.ServerAssembler.frame(ServerA
[jira] [Commented] (QPID-8083) [REST] Refactor REST system test suite
[ https://issues.apache.org/jira/browse/QPID-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346409#comment-16346409 ] ASF subversion and git services commented on QPID-8083: --- Commit e0e110af37a5fba00f4bd15e6d6511df40211639 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e0e110a ] QPID-8083 [System Tests] [REST/HTTP] Add REST model create tests > [REST] Refactor REST system test suite > -- > > Key: QPID-8083 > URL: https://issues.apache.org/jira/browse/QPID-8083 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Major > > REST is an orthogonal concern within the Broker. It should be possible for > developers of the Broker to easily exclude REST tests from test runs whilst > developing other parts of the Broker. To allow for this, the REST test suite > should be separate. > Also many of the current tests are very repetitious in nature. Currently > each model object is subjected to its own REST test merely testing that model > attributes are available over REST, pointlessly retesting the same piece of > common mechanism code over and over again. Such tests should be eliminated. > Tests that remain should focus on REST concerns such as: > * CRUD model access > * Model operations > * SASL and Preemptive Authentication > * Compression/Decompression > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8083) [REST] Refactor REST system test suite
[ https://issues.apache.org/jira/browse/QPID-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346408#comment-16346408 ] ASF subversion and git services commented on QPID-8083: --- Commit dd9c9e8cb6dff1a955281f7f48e5940f00189326 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=dd9c9e8 ] QPID-8083 [System Tests] [REST/HTTP] Move QueryRestTest to new module > [REST] Refactor REST system test suite > -- > > Key: QPID-8083 > URL: https://issues.apache.org/jira/browse/QPID-8083 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Major > > REST is an orthogonal concern within the Broker. It should be possible for > developers of the Broker to easily exclude REST tests from test runs whilst > developing other parts of the Broker. To allow for this, the REST test suite > should be separate. > Also many of the current tests are very repetitious in nature. Currently > each model object is subjected to its own REST test merely testing that model > attributes are available over REST, pointlessly retesting the same piece of > common mechanism code over and over again. Such tests should be eliminated. > Tests that remain should focus on REST concerns such as: > * CRUD model access > * Model operations > * SASL and Preemptive Authentication > * Compression/Decompression > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
