[jira] [Created] (QPID-8167) [Broker-J] Broker command line option '-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts

2018-04-16 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-8167:


 Summary: [Broker-J] Broker command line option 
'-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts
 Key: QPID-8167
 URL: https://issues.apache.org/jira/browse/QPID-8167
 Project: Qpid
  Issue Type: Bug
  Components: Broker-J
Affects Versions: qpid-java-6.0.8, 0.32, 0.28, 0.26, 
qpid-java-broker-7.0.3, qpid-java-6.1.6
Reporter: Alex Rudyy


When command line option '-mmqv/--management-mode-quiesce-virtualhosts' is set 
to true and management mode is requested to start the broker, the existing 
virtual hosts are not  started in QUIESCED state. Their state remain ACTIVE. 

It seems this issue exists since introduction of virtual host nodes. 
{{ManagementModeStoreHandler}} is looking for the entries of type {{VirtualHost 
}} but such types are not stored in the broker configuration store anymore.

Either we need to re-purpose this option to quiesce virtual host nodes, or, 
remove it completely.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-8133) Refresh Commons-CLI dependency (1.4)

2018-04-16 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-8133.
--
Resolution: Fixed

Changes look reasonable to me

> Refresh Commons-CLI dependency (1.4)
> 
>
> Key: QPID-8133
> URL: https://issues.apache.org/jira/browse/QPID-8133
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.1.0
>
>
> The Commons CLI dependency used by Broker-J is getting stale.  The latest 
> release is 1.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-8153) [JMS AMQP 0-x] JMS AMQP 0-x should be able to send SNI as part of TLS handshake

2018-04-16 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-8153.
--
Resolution: Fixed

Changes look reasonable to me

> [JMS AMQP 0-x] JMS AMQP 0-x should be able to send SNI as part of TLS 
> handshake
> ---
>
> Key: QPID-8153
> URL: https://issues.apache.org/jira/browse/QPID-8153
> Project: Qpid
>  Issue Type: Improvement
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Trivial
> Fix For: qpid-java-client-0-x-6.3.1
>
>
> Qpid JMS AMQP 0-x client does not provide SNI as part of TLS handshake. The a 
> client should be able to indicate which hostname it is attempting to connect 
> to by using SNI TLS extension.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8153) [JMS AMQP 0-x] JMS AMQP 0-x should be able to send SNI as part of TLS handshake

2018-04-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439444#comment-16439444
 ] 

ASF subversion and git services commented on QPID-8153:
---

Commit 2f6732941cc1c5f677cb4384f29e8e2880a6f3c0 in qpid-jms-amqp-0-x's branch 
refs/heads/6.3.x from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms-amqp-0-x.git;h=2f67329 ]

QPID-8153: [Qpid JMS AMQP 0-x] Pass host/port through to the SSLEngine so that 
SNI may function

(cherry picked from commit 78cf85c60fbedddfc08f978262aaa23061cae2b4)


> [JMS AMQP 0-x] JMS AMQP 0-x should be able to send SNI as part of TLS 
> handshake
> ---
>
> Key: QPID-8153
> URL: https://issues.apache.org/jira/browse/QPID-8153
> Project: Qpid
>  Issue Type: Improvement
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Trivial
> Fix For: qpid-java-client-0-x-6.3.1
>
>
> Qpid JMS AMQP 0-x client does not provide SNI as part of TLS handshake. The a 
> client should be able to indicate which hostname it is attempting to connect 
> to by using SNI TLS extension.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-934) Add a way to annotate configuration as experimental

2018-04-16 Thread Ganesh Murthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-934:
---
Fix Version/s: (was: 1.1.0)
   1.2.0

> Add a way to annotate configuration as experimental
> ---
>
> Key: DISPATCH-934
> URL: https://issues.apache.org/jira/browse/DISPATCH-934
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Management Agent
>Reporter: Ted Ross
>Assignee: Alan Conway
>Priority: Minor
> Fix For: 1.2.0
>
>
> Add a management-schema annotation for entities and attributes that labels 
> them as "experimental".  Any time an experimental item is used in 
> configuration (or via the management protocol) the router shall issue a log 
> warning stating that the configuration is experimental and may not be 
> supported in the future.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-968) Implement proper standard distributed TX

2018-04-16 Thread Michiel Lange (JIRA)
Michiel Lange created DISPATCH-968:
--

 Summary: Implement proper standard distributed TX
 Key: DISPATCH-968
 URL: https://issues.apache.org/jira/browse/DISPATCH-968
 Project: Qpid Dispatch
  Issue Type: Improvement
Reporter: Michiel Lange


In order to properly allow transacted connections over multiple brokers, proper 
TX should be implemented.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-963) Router crash during shutdown in system_tests_distribution

2018-04-16 Thread Chuck Rolke (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439506#comment-16439506
 ] 

Chuck Rolke commented on DISPATCH-963:
--

Using today's proton master (commit a80d54e6) the same tests crashes in other 
ways:
{quote}{{Core was generated by `qdrouterd -c B.conf -I 
/home/chug/git/qpid-dispatch/python'.}}
{{Program terminated with signal SIGSEGV, Segmentation fault.}}
{{[Current thread is 1 (Thread 0x7f0f57d11700 (LWP 20186))]}}
{{(gdb) p buf}}
{{$1 = (pn_buffer_t *) 0x7f0f0003}}
{{(gdb) p *buf}}
{{Cannot access memory at address 0x7f0f0003}}
{{(gdb) bt}}
{{#0  0x7f0f661d069e in pn_buffer_clear (buf=0x7f0f0003) at 
/home/chug/git/qpid-proton/c/src/core/buffer.c:257}}
{{#1  0x7f0f661d1e35 in pn_data_clear (data=0x7f0f38123ef0) at 
/home/chug/git/qpid-proton/c/src/core/codec.c:414}}
{{#2  0x7f0f661d659e in pn_data_copy (data=0x7f0f38123ef0, 
src=0x7f0f40172860) at /home/chug/git/qpid-proton/c/src/core/codec.c:1987}}
{{#3  0x7f0f664671f4 in qdr_terminus_copy (from=0x7f0f40093ca0, 
to=0x7f0f38117fd8) at 
/home/chug/git/qpid-dispatch/src/router_core/terminus.c:118}}
{{#4  0x7f0f6646e17c in CORE_link_second_attach (context=0x26089d0, 
link=0x7f0f380f0a20, source=0x7f0f40093ca0, target=0x7f0f40093ba0) at 
/home/chug/git/qpid-dispatch/src/router_node.c:1177}}
{{#5  0x7f0f66452cb3 in qdr_connection_process (conn=0x2789a60) at 
/home/chug/git/qpid-dispatch/src/router_core/connections.c:231}}
{{#6  0x7f0f6646b781 in AMQP_writable_conn_handler (type_context=0x26089d0, 
conn=0x276da60, context=0x0) at 
/home/chug/git/qpid-dispatch/src/router_node.c:167}}
{{#7  0x7f0f66431b6b in writable_handler (container=0x24810e0, 
conn=0x2763040, qd_conn=0x276da60) at 
/home/chug/git/qpid-dispatch/src/container.c:326}}
{{#8  0x7f0f66432577 in qd_container_handle_event (container=0x24810e0, 
event=0x7f0f38145710) at /home/chug/git/qpid-dispatch/src/container.c:548}}
{{#9  0x7f0f664730a2 in handle (qd_server=0x25eb820, e=0x7f0f38145710) at 
/home/chug/git/qpid-dispatch/src/server.c:940}}
{{#10 0x7f0f66473125 in thread_run (arg=0x25eb820) at 
/home/chug/git/qpid-dispatch/src/server.c:958}}
{{#11 0x7f0f65d9950b in start_thread (arg=0x7f0f57d11700) at 
pthread_create.c:465}}
{{#12 0x7f0f6505d16f in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:95}}{quote}
This seems to be very repeatable. It fails between tests 21 and 22:
{quote}{{30: test_21_linkroute_mesh_nonlocal 
(system_tests_distribution.DistributionTests) ... ok}}
{{30/46 Test #30: system_tests_distribution .***Timeout 
600.12 sec}}{quote}
 

 

 

> Router crash during shutdown in system_tests_distribution
> -
>
> Key: DISPATCH-963
> URL: https://issues.apache.org/jira/browse/DISPATCH-963
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.0.1
>Reporter: Ganesh Murthy
>Priority: Major
>
> The router crashes during shutdown in system_tests_distribution.py
> Here is the backtrace
>  
> {noformat}
> (gdb) bt
> #0  0x7f361ca5ae40 in pn_ep_decref (endpoint=0x7f35f01c2dd0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/engine.c:447
> #1  0x7f361ca5b58b in pn_ep_decref (endpoint=) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/engine.c:445
> #2  0x7f361ca5f588 in pni_transport_unbind_handles 
> (handles=0x7f35f00764a0, reset_state=reset_state@entry=true) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/transport.c:748
> #3  0x7f361ca5f666 in pni_transport_unbind_channels (channels=0x9d1ce0) 
> at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/transport.c:761
> #4  0x7f361ca5f777 in pn_transport_unbind (transport=0xa863d0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/transport.c:795
> #5  0x7f361ca5a63e in pn_connection_driver_release_connection 
> (d=d@entry=0xa86248) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/connection_driver.c:81
> #6  0x7f361ca5a679 in pn_connection_driver_destroy (d=d@entry=0xa86248) 
> at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/connection_driver.c:92
> #7  0x7f361c83a69c in pconnection_final_free (pc=0xa85ca0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/proactor/epoll.c:827
> #8  0x7f361c83b3ac in pconnection_cleanup (pc=) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/proactor/epoll.c:843
> #9  0x7f361c83db37 in pconnection_forced_shutdown (pc=0xa85ca0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/proactor/epoll.c:878
> #10 pn_proactor_free (p=0x916fd0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/pr

[jira] [Commented] (QPID-8160) [Broker-J] [AMQP 1.0] AccessControlException when creating sending link reported as amqp:internal-error rather than amqp:unauthorised-access

2018-04-16 Thread Alex Rudyy (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439589#comment-16439589
 ] 

Alex Rudyy commented on QPID-8160:
--

The change look reasonable to me. I would vote for inclusion of the change into 
7.0.

>  [Broker-J] [AMQP 1.0] AccessControlException when creating sending link 
> reported as  amqp:internal-error rather than amqp:unauthorised-access
> --
>
> Key: QPID-8160
> URL: https://issues.apache.org/jira/browse/QPID-8160
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.0, 
> qpid-java-broker-7.1
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.1.0
>
>
> If the Broker tries to create a sending link from a source but the user has 
> insufficient permissions for that source, I expect the {{detach}} to use 
> error {{amqp:unauthorised-access}}. This currently does not happen, the 
> Broker sends {{amqp:amqp:internal-error}} instead.
> {noformat}
> [511142734:1] <- Detach{handle=1, closed=true, 
> error=Error{condition=amqp:internal-error, description='Permission CREATE is 
> denied for : Consumer 
> '4|1|qpid-jms:receiver:ID:2a653090-1dbc-4433-955d-791b52540128:1:1:1:guestqueue'
>  on Queue 'guestqueue'', info=null}}{noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8135) [JMS AMQP 0-x] Connection URL options for end-to-end encryption keystore/trustore passwords can be logged when log level for 'org.apache.qpid' loggers is lower than 'war

2018-04-16 Thread Alex Rudyy (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439624#comment-16439624
 ] 

Alex Rudyy commented on QPID-8135:
--

Keith,
I believe that JIRA description is accurate. Since commit against QPID-6576, 
the truststore/kestore options can now be declared either on broker URL level 
or connection URL level. If corresponding broker option is not present, the 
connection options are checked and if option is there it is used.  See 
{{BrokerDetails}}. Though, this "feature" is undocumented.
{code}
 public String getProperty(String key)
{
String value = _options.get(key);
if(value == null && _connectionUrl != null)
{
value = _connectionUrl.getOption(key);
}
return value;
}
{code}

Taking that declaration of encryption keystore/trustore parameters or/and SSL 
trust store parameters or/and SSL client-auth parameters on connection URL is 
undocumented I am happy with the changes implemented in [ 
https://git-wip-us.apache.org/repos/asf?p=qpid-jms-amqp-0-x.git;h=97347f0 ].

> [JMS AMQP 0-x] Connection URL options for end-to-end encryption 
> keystore/trustore passwords can be logged when log level for 
> 'org.apache.qpid' loggers is lower than 'warn'
> ---
>
> Key: QPID-8135
> URL: https://issues.apache.org/jira/browse/QPID-8135
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Major
> Fix For: qpid-java-client-0-x-6.3.1
>
>
> The connection URL password options can be logged when log level for 
> 'org.apache.qpid' loggers is lower than 'warn'.
> The following cases are identified when password is logged
>  # when encryption keystore/trustore parameters are declared as part of 
> broker URL , 'org.apache.qpid' loggers log level is set to ''info' or lower 
> threshold and connectivity is not established, the 
> encryption_key_store_password or encryption_trust_store_password can be 
> logged with info log level as below
> {noformat}
> 2018-03-16 12:56:02,196 INFO  [main] o.a.q.c.AMQConnection Unable to connect 
> to broker at 
> tcp://localhost:5672?encryption_trust_store='/path/to/trustore.jks'&encryption_trust_store_password='password'
> org.apache.qpid.transport.TransportException: Error connecting to broker
>   at 
> org.apache.qpid.transport.network.io.IoNetworkTransport.connectTcp(IoNetworkTransport.java:151)
> ...
> 2018-03-16 12:56:02,196 INFO  [main] o.a.q.j.f.FailoverRoundRobinServers  
> Checking failoverAllowed() 
> 2018-03-16 12:56:02,197 INFO  [main] o.a.q.j.f.FailoverRoundRobinServers 
> Cycle Servers:
> Cycle Retries:20
> Current Cycle:20
> Server Retries:0
> Current Retry:0
> Current Broker:0
> >tcp://localhost:5672?encryption_trust_store='/path/to/trsutsore.jks'&encryption_trust_store_password='password'
> {noformat}
> # when encryption keystore/trustore parameters  or/and SSL trust store  
> parameters or/and SSL client-auth parameters are declared as part of 
> connection URL and 'org.apache.qpid' loggers log level is set to 'debug' or 
> lower threshold, the password options can be logged with DEBUG log level as 
> below:
> {noformat}
> 2018-03-16 13:03:20,879 DEBUG [main] o.a.q.c.AMQConnection 
> Connection(1):amqp://admin:@consumer/?encryption_trust_store='/path/to/keystore.jks'&trust_store='/path/to/trsustore.ts'&key_store_password='secret'&encryption_trust_store_password='password'&key_store='/path/to/keystore.ks'&trust_store_password='secret'&brokerlist='tcp://localhost:5672'&failover='roundrobin?cyclecount='20''
> {noformat}
> The work around for the issue would be to set debug log level to warn at 
> least for the following loggers:
> * org.apache.qpid.client.AMQConnection
> * org.apache.qpid.jms.failover.FailoverRoundRobinServers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8135) [JMS AMQP 0-x] Connection URL options for end-to-end encryption keystore/trustore passwords can be logged when log level for 'org.apache.qpid' loggers is lower than 'war

2018-04-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439650#comment-16439650
 ] 

ASF subversion and git services commented on QPID-8135:
---

Commit a9ff1856da994be8d4f83cc612e5ac1fd2bdddb6 in qpid-jms-amqp-0-x's branch 
refs/heads/6.3.x from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms-amqp-0-x.git;h=a9ff185 ]

QPID-8135: [Qpid JMS AMQP 0-x] Mask passwords associated with end to end 
encryption in the BrokerDetails#toString()

(cherry picked from commit 97347f0fb0e0782398bd16a7ba2d318bbb759bd1)


> [JMS AMQP 0-x] Connection URL options for end-to-end encryption 
> keystore/trustore passwords can be logged when log level for 
> 'org.apache.qpid' loggers is lower than 'warn'
> ---
>
> Key: QPID-8135
> URL: https://issues.apache.org/jira/browse/QPID-8135
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Major
> Fix For: qpid-java-client-0-x-6.3.1
>
>
> The connection URL password options can be logged when log level for 
> 'org.apache.qpid' loggers is lower than 'warn'.
> The following cases are identified when password is logged
>  # when encryption keystore/trustore parameters are declared as part of 
> broker URL , 'org.apache.qpid' loggers log level is set to ''info' or lower 
> threshold and connectivity is not established, the 
> encryption_key_store_password or encryption_trust_store_password can be 
> logged with info log level as below
> {noformat}
> 2018-03-16 12:56:02,196 INFO  [main] o.a.q.c.AMQConnection Unable to connect 
> to broker at 
> tcp://localhost:5672?encryption_trust_store='/path/to/trustore.jks'&encryption_trust_store_password='password'
> org.apache.qpid.transport.TransportException: Error connecting to broker
>   at 
> org.apache.qpid.transport.network.io.IoNetworkTransport.connectTcp(IoNetworkTransport.java:151)
> ...
> 2018-03-16 12:56:02,196 INFO  [main] o.a.q.j.f.FailoverRoundRobinServers  
> Checking failoverAllowed() 
> 2018-03-16 12:56:02,197 INFO  [main] o.a.q.j.f.FailoverRoundRobinServers 
> Cycle Servers:
> Cycle Retries:20
> Current Cycle:20
> Server Retries:0
> Current Retry:0
> Current Broker:0
> >tcp://localhost:5672?encryption_trust_store='/path/to/trsutsore.jks'&encryption_trust_store_password='password'
> {noformat}
> # when encryption keystore/trustore parameters  or/and SSL trust store  
> parameters or/and SSL client-auth parameters are declared as part of 
> connection URL and 'org.apache.qpid' loggers log level is set to 'debug' or 
> lower threshold, the password options can be logged with DEBUG log level as 
> below:
> {noformat}
> 2018-03-16 13:03:20,879 DEBUG [main] o.a.q.c.AMQConnection 
> Connection(1):amqp://admin:@consumer/?encryption_trust_store='/path/to/keystore.jks'&trust_store='/path/to/trsustore.ts'&key_store_password='secret'&encryption_trust_store_password='password'&key_store='/path/to/keystore.ks'&trust_store_password='secret'&brokerlist='tcp://localhost:5672'&failover='roundrobin?cyclecount='20''
> {noformat}
> The work around for the issue would be to set debug log level to warn at 
> least for the following loggers:
> * org.apache.qpid.client.AMQConnection
> * org.apache.qpid.jms.failover.FailoverRoundRobinServers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-8135) [JMS AMQP 0-x] Connection URL options for end-to-end encryption keystore/trustore passwords can be logged when log level for 'org.apache.qpid' loggers is lower than 'warn

2018-04-16 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-8135.
--
Resolution: Fixed

> [JMS AMQP 0-x] Connection URL options for end-to-end encryption 
> keystore/trustore passwords can be logged when log level for 
> 'org.apache.qpid' loggers is lower than 'warn'
> ---
>
> Key: QPID-8135
> URL: https://issues.apache.org/jira/browse/QPID-8135
> Project: Qpid
>  Issue Type: Bug
>  Components: JMS AMQP 0-x
>Affects Versions: qpid-java-client-0-x-6.3.0
>Reporter: Alex Rudyy
>Assignee: Keith Wall
>Priority: Major
> Fix For: qpid-java-client-0-x-6.3.1
>
>
> The connection URL password options can be logged when log level for 
> 'org.apache.qpid' loggers is lower than 'warn'.
> The following cases are identified when password is logged
>  # when encryption keystore/trustore parameters are declared as part of 
> broker URL , 'org.apache.qpid' loggers log level is set to ''info' or lower 
> threshold and connectivity is not established, the 
> encryption_key_store_password or encryption_trust_store_password can be 
> logged with info log level as below
> {noformat}
> 2018-03-16 12:56:02,196 INFO  [main] o.a.q.c.AMQConnection Unable to connect 
> to broker at 
> tcp://localhost:5672?encryption_trust_store='/path/to/trustore.jks'&encryption_trust_store_password='password'
> org.apache.qpid.transport.TransportException: Error connecting to broker
>   at 
> org.apache.qpid.transport.network.io.IoNetworkTransport.connectTcp(IoNetworkTransport.java:151)
> ...
> 2018-03-16 12:56:02,196 INFO  [main] o.a.q.j.f.FailoverRoundRobinServers  
> Checking failoverAllowed() 
> 2018-03-16 12:56:02,197 INFO  [main] o.a.q.j.f.FailoverRoundRobinServers 
> Cycle Servers:
> Cycle Retries:20
> Current Cycle:20
> Server Retries:0
> Current Retry:0
> Current Broker:0
> >tcp://localhost:5672?encryption_trust_store='/path/to/trsutsore.jks'&encryption_trust_store_password='password'
> {noformat}
> # when encryption keystore/trustore parameters  or/and SSL trust store  
> parameters or/and SSL client-auth parameters are declared as part of 
> connection URL and 'org.apache.qpid' loggers log level is set to 'debug' or 
> lower threshold, the password options can be logged with DEBUG log level as 
> below:
> {noformat}
> 2018-03-16 13:03:20,879 DEBUG [main] o.a.q.c.AMQConnection 
> Connection(1):amqp://admin:@consumer/?encryption_trust_store='/path/to/keystore.jks'&trust_store='/path/to/trsustore.ts'&key_store_password='secret'&encryption_trust_store_password='password'&key_store='/path/to/keystore.ks'&trust_store_password='secret'&brokerlist='tcp://localhost:5672'&failover='roundrobin?cyclecount='20''
> {noformat}
> The work around for the issue would be to set debug log level to warn at 
> least for the following loggers:
> * org.apache.qpid.client.AMQConnection
> * org.apache.qpid.jms.failover.FailoverRoundRobinServers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1771) [c-proactor] multi-thread race test for proactor

2018-04-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439749#comment-16439749
 ] 

ASF subversion and git services commented on PROTON-1771:
-

Commit fc1df0551947c357e9fa0bf9da4b836c5a97c11f in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=fc1df05 ]

Revert "PROTON-1771: [c] locking around epoll_extended_t"

This reverts commit 188ce28066df8f5e965fb63593f419f49c950760.
The fix caused hangs due to mutex deadlocks.


> [c-proactor] multi-thread race test for proactor
> 
>
> Key: PROTON-1771
> URL: https://issues.apache.org/jira/browse/PROTON-1771
> Project: Qpid Proton
>  Issue Type: Test
>  Components: proton-c
>Affects Versions: proton-c-0.20.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.23.0
>
>
> Crate a new test exe that runs for a (configurable, default short) period of
> time, with a single proactor acted on by multiple proactor and user threads. 
> Run
> with helgrind or tsan to detect races.
> Exercise potentially racy APIs concurrently:
> - making, accepting and closing (from both ends) a connection.
> - pn_connection_wake
> - pn_proactor_release_connection
> - re-use of released pn_connection_t on a new connection
> - timeout
> - concurrent with some normal use: sending/receiving messages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (DISPATCH-963) Router crash during shutdown in system_tests_distribution

2018-04-16 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway reassigned DISPATCH-963:


Assignee: Alan Conway

> Router crash during shutdown in system_tests_distribution
> -
>
> Key: DISPATCH-963
> URL: https://issues.apache.org/jira/browse/DISPATCH-963
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.0.1
>Reporter: Ganesh Murthy
>Assignee: Alan Conway
>Priority: Major
>
> The router crashes during shutdown in system_tests_distribution.py
> Here is the backtrace
>  
> {noformat}
> (gdb) bt
> #0  0x7f361ca5ae40 in pn_ep_decref (endpoint=0x7f35f01c2dd0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/engine.c:447
> #1  0x7f361ca5b58b in pn_ep_decref (endpoint=) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/engine.c:445
> #2  0x7f361ca5f588 in pni_transport_unbind_handles 
> (handles=0x7f35f00764a0, reset_state=reset_state@entry=true) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/transport.c:748
> #3  0x7f361ca5f666 in pni_transport_unbind_channels (channels=0x9d1ce0) 
> at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/transport.c:761
> #4  0x7f361ca5f777 in pn_transport_unbind (transport=0xa863d0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/transport.c:795
> #5  0x7f361ca5a63e in pn_connection_driver_release_connection 
> (d=d@entry=0xa86248) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/connection_driver.c:81
> #6  0x7f361ca5a679 in pn_connection_driver_destroy (d=d@entry=0xa86248) 
> at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/core/connection_driver.c:92
> #7  0x7f361c83a69c in pconnection_final_free (pc=0xa85ca0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/proactor/epoll.c:827
> #8  0x7f361c83b3ac in pconnection_cleanup (pc=) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/proactor/epoll.c:843
> #9  0x7f361c83db37 in pconnection_forced_shutdown (pc=0xa85ca0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/proactor/epoll.c:878
> #10 pn_proactor_free (p=0x916fd0) at 
> /home/gmurthy/opensource/qpid-proton-0.22.0/proton-c/src/proactor/epoll.c:1815
> #11 0x7f361cce7bb5 in qd_server_free (qd_server=0x919190) at 
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:1176
> #12 0x7f361cca878e in qd_dispatch_free (qd=0x6164b0) at 
> /home/gmurthy/opensource/qpid-dispatch/src/dispatch.c:318
> #13 0x00401864 in main_process (config_path=0x7ffcb36d88e2 "B.conf", 
> python_pkgdir=0x7ffcb36d88ec "/home/gmurthy/opensource/qpid-dispatch/python", 
> fd=2) at /home/gmurthy/opensource/qpid-dispatch/router/src/main.c:116
> #14 0x004022b0 in main (argc=5, argv=0x7ffcb36d8158) at 
> /home/gmurthy/opensource/qpid-dispatch/router/src/main.c:360
> (gdb){noformat}
>  
> Running the test under valgrind, it seems that the pn_proactor_free is trying 
> to free already freed link endpoint. Here are two outputs from valgrind
>  
> {noformat}
> Process 3493 error: exit code 42, expected 0
> qdrouterd -c B.conf -I /home/gmurthy/opensource/qpid-dispatch/python
> /home/gmurthy/opensource/qpid-dispatch/build/system_test.dir/system_tests_distribution/DistributionTests/setUpClass/B-2.cmd
> 
> ==3493== Invalid write of size 8
> ==3493==    at 0x50E82B0: pn_link_unbound (engine.c:1202)
> ==3493==    by 0x50EB5D0: pni_transport_unbind_handles (transport.c:746)
> ==3493==    by 0x50EB665: pni_transport_unbind_channels (transport.c:761)
> ==3493==    by 0x50EB776: pn_transport_unbind (transport.c:795)
> ==3493==    by 0x50E663D: pn_connection_driver_release_connection 
> (connection_driver.c:81)
> ==3493==    by 0x50E6678: pn_connection_driver_destroy 
> (connection_driver.c:92)
> ==3493==    by 0x530A69B: pconnection_final_free (epoll.c:827)
> ==3493==    by 0x530DB36: pconnection_forced_shutdown (epoll.c:878)
> ==3493==    by 0x530DB36: pn_proactor_free (epoll.c:1815)
> ==3493==    by 0x4EA5BB4: qd_server_free (server.c:1176)
> ==3493==    by 0x4E6678D: qd_dispatch_free (dispatch.c:318)
> ==3493==    by 0x401863: main_process (main.c:116)
> ==3493==    by 0x4022AF: main (main.c:360)
> ==3493==  Address 0x15c06188 is 376 bytes inside a block of size 488 free'd
> ==3493==    at 0x4C2DD18: free (vg_replace_malloc.c:530)
> ==3493==    by 0x50DD938: pn_class_decref (object.c:101)
> ==3493==    by 0x50EA03F: pn_event_finalize (event.c:226)
> ==3493==    by 0x50EA03F: pn_event_finalize_cast (event.c:271)
> ==3493==    by 0x50DD928: pn_class_decref (object.c:95)
> ==3493==    by 0x50EA361: pn_collector_next (event.c:197)
> ==3493==    by 0x50E6408: batch_next (connection_driv

[jira] [Commented] (QPID-8163) [Broker-J] [ACL] Owner ACL rules

2018-04-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440078#comment-16440078
 ] 

ASF subversion and git services commented on QPID-8163:
---

Commit 5f19120a82e119050c80172d756442eae1ec1897 in qpid-broker-j's branch 
refs/heads/7.0.x from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=5f19120 ]

QPID-8163: [Access Control Plugin] Support OWNER psuedo principal in ACL rules.

(cherry picked from commit 2443fe648347e5775a1f1c41c20eada49f62970b)


> [Broker-J] [ACL] Owner ACL rules
> 
>
> Key: QPID-8163
> URL: https://issues.apache.org/jira/browse/QPID-8163
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Keith Wall
>Priority: Minor
> Attachments: 0001-QPID-8163.patch
>
>
> [http://qpid.2158936.n2.nabble.com/Java-Broker-Temporary-queues-ACLs-for-multiple-users-td7674630.html]
> The Broker-J's access-control-plugin currently has no way to express rules 
> that apply to subject that owns an object.  For instance, it is impossible to 
> say that only a user can consume from any queue that he created.
> If the ACL system supported a pseudo subject {{OWNER}} (in additional to the 
> pseudo subject {{ALL}} it already supports), then it would be possible to 
> write such rules.
> {noformat}
> ACL ALLOW-LOG OWNER CONSUME QUEUE{noformat}
> It is noted that currently the model does not a have notion of object 
> ownership (QPID-8162).  It does have an immutable {{createdBy}} attribute.  
> The first version of this feature will use {{createdBy}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-8163) [Broker-J] [ACL] Owner ACL rules

2018-04-16 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-8163.
--
   Resolution: Fixed
Fix Version/s: qpid-java-broker-7.0.4
   qpid-java-broker-7.1.0

Changes look reasonable to me

> [Broker-J] [ACL] Owner ACL rules
> 
>
> Key: QPID-8163
> URL: https://issues.apache.org/jira/browse/QPID-8163
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4
>
> Attachments: 0001-QPID-8163.patch
>
>
> [http://qpid.2158936.n2.nabble.com/Java-Broker-Temporary-queues-ACLs-for-multiple-users-td7674630.html]
> The Broker-J's access-control-plugin currently has no way to express rules 
> that apply to subject that owns an object.  For instance, it is impossible to 
> say that only a user can consume from any queue that he created.
> If the ACL system supported a pseudo subject {{OWNER}} (in additional to the 
> pseudo subject {{ALL}} it already supports), then it would be possible to 
> write such rules.
> {noformat}
> ACL ALLOW-LOG OWNER CONSUME QUEUE{noformat}
> It is noted that currently the model does not a have notion of object 
> ownership (QPID-8162).  It does have an immutable {{createdBy}} attribute.  
> The first version of this feature will use {{createdBy}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org