[jira] [Resolved] (QPID-8198) [Broker-J][Documentation] Account headers in formula for estimation of heap size
[ https://issues.apache.org/jira/browse/QPID-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8198. -- Resolution: Fixed > [Broker-J][Documentation] Account headers in formula for estimation of heap > size > > > Key: QPID-8198 > URL: https://issues.apache.org/jira/browse/QPID-8198 > Project: Qpid > Issue Type: Bug > Components: Broker-J, Java Documentation >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 > > > The formula for estimation of required heap size should allow to specify > variables for message headers. Otherwise, the estimated value would be far > from required. For example, in Broker with 1G of heap it is possible to > publish 568920 AMQP 1-0 messages without application properties. However, it > is possible to publish around 208700 messages if each message contains 20 > application specific properties with average size of 20 bytes for name and > value. > The formula for estimation of required heap size should allow to specify the > following: > * average size of property name and value > * average number of application properties per message -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7830) [Broker-J] Heap dominated by duplicates of common routing values / header values etc
[ https://issues.apache.org/jira/browse/QPID-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492621#comment-16492621 ] ASF subversion and git services commented on QPID-7830: --- Commit a4ade5a371eefdee764a6e13341625a945d67d1b in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=a4ade5a ] QPID-7830: [Broker-J] Simplify string caching functionality (cherry picked from commit 57bda83de7fbe6291aea507b5c1098fda5cf130d) > [Broker-J] Heap dominated by duplicates of common routing values / header > values etc > > > Key: QPID-7830 > URL: https://issues.apache.org/jira/browse/QPID-7830 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Keith Wall >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 > > Attachments: > 0001-QPID-7830-Broker-J-Simplify-string-caching-functiona.patch > > > When used for store and forwarding, in some use cases the Broker's heap can > become dominated by duplicates of common values such as routing information > (e.g. {{amq.direct}} or an application's queue name) or common header values > (e.g a application/octet-stream or an application's user id). > On the 0-8..0-91 paths, every enqueued message gets its own > {{MessagePublishInfo}} referencing its own {{AMQShortString}} exchange and > routing keys. For some use-cases, these are drawn from a small set. On the > AMQP 1.0 path, {{Properties#to}} is an example. 0-10 is probably affected > too. > This unnecessarily increases the heap requirements of the Broker. > The Broker should adopt a sensible intern/caching policy with the same policy > applying regardless of whether messages follow the on-line enqueue or > recovery path. Note that in AMQP 1.0, values which are {{Symbols}} have > their underlying String automatically interned. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8139: - Status: Open (was: Reviewable) > [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or > JMSCorrelationID expressed using the AMQP type encoded form values fail to > select target message > --- > > Key: QPID-8139 > URL: https://issues.apache.org/jira/browse/QPID-8139 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8139-Broker-J-AMQP-1.0-Make-sure-that-selector-.patch > > > When using the Qpid JMS AMQP 1.0 Client with Broker-J, if the consumer > specifies a JMS message selectors including a {{JMSMessageID}} or > {{JMSCorrelationID}} predicate, the selector can fail to find the target > message in some circumstances. This occurs when the message producer is > configured to use one of the following {{jms.messageIDPolicy.messageIDType}} > modes: {{UUID}}. {{UUID_STRING}}, {{PREFIXED_UUID_STRING}}. In the default > mode, {{BUILTIN}} the problem does not manifest. > The issue is the Broker-J JMS selector implementation does not understand the > AMQP type encoded forms specified by 3.2.1.1 of the Advanced Message Queuing > Protocol (AMQP) JMS Mapping Version 1.0 [WD9]. > The problem also manifests when the Broker's message conversion feature is in > use. For instance, a message produced by a AMQP 0-10 producer cannot be > selected by an consumer using a Qpid JMS Client 1.0 using a {{JMSMessageID}} > or {{JMSCorrelationID}} predicate. This was originally highlighted by the > following user list post: > http://qpid.2158936.n2.nabble.com/JMSMessageID-differences-in-JMS-0-30-0-and-JMS-AMQP-0-x-6-3-0-clients-td7674019.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8158) [Broker-J] [System Tests] Refactor BDB HA system tests
[ https://issues.apache.org/jira/browse/QPID-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-8158: Assignee: Alex Rudyy > [Broker-J] [System Tests] Refactor BDB HA system tests > -- > > Key: QPID-8158 > URL: https://issues.apache.org/jira/browse/QPID-8158 > Project: Qpid > Issue Type: Improvement > Components: Broker-J, Java Tests >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > Currently BDB HA system tests are extended from {{QpidBrokerTestCase}}. They > need to be refactored to run with {{QpidTestRunner}} similar to other system > tests. > The BDB HA nodes should be started as spawn brokers using special > {{BrokerAdmin}} allowing to start broker in a separate JVM. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8158) [Broker-J] [System Tests] Refactor BDB HA system tests
[ https://issues.apache.org/jira/browse/QPID-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8158: - Fix Version/s: (was: qpid-java-broker-7.1) qpid-java-broker-7.1.0 > [Broker-J] [System Tests] Refactor BDB HA system tests > -- > > Key: QPID-8158 > URL: https://issues.apache.org/jira/browse/QPID-8158 > Project: Qpid > Issue Type: Improvement > Components: Broker-J, Java Tests >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > Currently BDB HA system tests are extended from {{QpidBrokerTestCase}}. They > need to be refactored to run with {{QpidTestRunner}} similar to other system > tests. > The BDB HA nodes should be started as spawn brokers using special > {{BrokerAdmin}} allowing to start broker in a separate JVM. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8171) [Broker-J] Failed to start broker under Windows when QPID_JAVA_GC is set
[ https://issues.apache.org/jira/browse/QPID-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8171: - Fix Version/s: (was: qpid-java-broker-7.1) qpid-java-broker-7.1.0 > [Broker-J] Failed to start broker under Windows when QPID_JAVA_GC is set > - > > Key: QPID-8171 > URL: https://issues.apache.org/jira/browse/QPID-8171 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.1.0 >Reporter: Alex Rudyy >Priority: Minor > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 > > > Failed to start broker under Windows when QPID_JAVA_GC is set > Forgotten 'r' cause broker failure on start (under Windows environment) > See pull request [Failed to start broker under Windows when QPID_JAVA_GC is > set #6|https://github.com/apache/qpid-broker-j/pull/6] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8166) [Broker-J] Remove use of ${QPID_HOME}/etc from default configuration
[ https://issues.apache.org/jira/browse/QPID-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8166: - Fix Version/s: (was: qpid-java-broker-7.1) qpid-java-broker-7.1.0 > [Broker-J] Remove use of ${QPID_HOME}/etc from default configuration > > > Key: QPID-8166 > URL: https://issues.apache.org/jira/browse/QPID-8166 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.1.0 > > > Currently, the Broker's default configuration relies on the contents of > external {{${QPID_HOME}/etc/passwd}} file. This makes the configuration > fragile. Errors occur if {{$\{QPID_HOME}}} is unset or files absent. The > default configuration should be switched to use a built-in password database > and the {{etc}} directory eliminated from the assembly. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8167) [Broker-J] Broker command line option '-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts
[ https://issues.apache.org/jira/browse/QPID-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8167: - Fix Version/s: (was: qpid-java-broker-7.1) qpid-java-broker-7.1.0 > [Broker-J] Broker command line option > '-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts > --- > > Key: QPID-8167 > URL: https://issues.apache.org/jira/browse/QPID-8167 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3, 0.26, 0.28, > 0.32, qpid-java-6.0.8 >Reporter: Alex Rudyy >Assignee: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.1.0 > > > When command line option '-mmqv/--management-mode-quiesce-virtualhosts' is > set to true and management mode is requested to start the broker, the > existing virtual hosts are not started in QUIESCED state. Their state remain > ACTIVE. > It seems this issue exists since introduction of virtual host nodes. > {{ManagementModeStoreHandler}} is looking for the entries of type > {{VirtualHost }} but such types are not stored in the broker configuration > store anymore. > Either we need to re-purpose this option to quiesce virtual host nodes, or, > remove it completely. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8164) [Broker-J] [AMQP 1.0] [BINDMAP] Dynamic nodes created with the temporary-queue capability do not enforce connection exclusivity
[ https://issues.apache.org/jira/browse/QPID-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8164: - Fix Version/s: (was: qpid-java-broker-7.1) qpid-java-broker-7.1.0 > [Broker-J] [AMQP 1.0] [BINDMAP] Dynamic nodes created with the > temporary-queue capability do not enforce connection exclusivity > --- > > Key: QPID-8164 > URL: https://issues.apache.org/jira/browse/QPID-8164 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.0, qpid-java-6.1, qpid-java-broker-7.0.0 >Reporter: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 > > > The JMS 2.0 specification, 6.2.2 Creating temporary destinations, says: > {quote}Temporary destinations (TemporaryQueue or TemporaryTopic objects) are > destinations that are system-generated uniquely for their connection. Only > their own connection is allowed to create consumer objects for them. > {quote} > Currently when the Qpid JMS Client is used with Broker-J, the last sentence > whilst being enforced by the client is not enforced by the *Broker*. This > means that if the temporary destination were to be passed to another party - > say as a JMSReplyTo, that client would be able to create a consumer, > violating the JMS specification. > I think Broker-J ought to be detecting the terminus capability > {{temporary-queue}} specified by amqp-bindmap-jms-v1.0-wd09 and then applying > the correct queue exclusivity policy. > I think the same problem may apply to the temporary-topics too (but not > confirmed) > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8199) [Broker-J] Fix description for bind/unbind operations
[ https://issues.apache.org/jira/browse/QPID-8199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8199: - Issue Type: Bug (was: Improvement) Summary: [Broker-J] Fix description for bind/unbind operations (was: [Broker-J] Improve description for bind/unbind operations) > [Broker-J] Fix description for bind/unbind operations > - > > Key: QPID-8199 > URL: https://issues.apache.org/jira/browse/QPID-8199 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, > qpid-java-broker-7.0.0, qpid-java-broker-7.0.1 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 > > > The description for unbind operation is misleading. It should be improved to > state that only one binding with given queue name and given binding key would > be deleted -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7830) [Broker-J] Heap dominated by duplicates of common routing values / header values etc
[ https://issues.apache.org/jira/browse/QPID-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-7830: - Summary: [Broker-J] Heap dominated by duplicates of common routing values / header values etc (was: Heap dominated by duplicates of common routing values / header values etc) > [Broker-J] Heap dominated by duplicates of common routing values / header > values etc > > > Key: QPID-7830 > URL: https://issues.apache.org/jira/browse/QPID-7830 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Keith Wall >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 > > Attachments: > 0001-QPID-7830-Broker-J-Simplify-string-caching-functiona.patch > > > When used for store and forwarding, in some use cases the Broker's heap can > become dominated by duplicates of common values such as routing information > (e.g. {{amq.direct}} or an application's queue name) or common header values > (e.g a application/octet-stream or an application's user id). > On the 0-8..0-91 paths, every enqueued message gets its own > {{MessagePublishInfo}} referencing its own {{AMQShortString}} exchange and > routing keys. For some use-cases, these are drawn from a small set. On the > AMQP 1.0 path, {{Properties#to}} is an example. 0-10 is probably affected > too. > This unnecessarily increases the heap requirements of the Broker. > The Broker should adopt a sensible intern/caching policy with the same policy > applying regardless of whether messages follow the on-line enqueue or > recovery path. Note that in AMQP 1.0, values which are {{Symbols}} have > their underlying String automatically interned. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492479#comment-16492479 ] ASF subversion and git services commented on QPID-8139: --- Commit 560d4a3b3a51deb4cb79303976cd87a16b8e0997 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=560d4a3 ] QPID-8139: Reverted as per review comments Revert "QPID-8139: [Broker-J][AMQP 1.0] Make sure that selector filter can handle JMSMessageID and JMSCorrelationID values with prefixes as defined in AMQP JMS mapping specification" This reverts commit f1ce8666b80aa1ddd30445a6b2ce47db6b6943e9. > [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or > JMSCorrelationID expressed using the AMQP type encoded form values fail to > select target message > --- > > Key: QPID-8139 > URL: https://issues.apache.org/jira/browse/QPID-8139 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8139-Broker-J-AMQP-1.0-Make-sure-that-selector-.patch > > > When using the Qpid JMS AMQP 1.0 Client with Broker-J, if the consumer > specifies a JMS message selectors including a {{JMSMessageID}} or > {{JMSCorrelationID}} predicate, the selector can fail to find the target > message in some circumstances. This occurs when the message producer is > configured to use one of the following {{jms.messageIDPolicy.messageIDType}} > modes: {{UUID}}. {{UUID_STRING}}, {{PREFIXED_UUID_STRING}}. In the default > mode, {{BUILTIN}} the problem does not manifest. > The issue is the Broker-J JMS selector implementation does not understand the > AMQP type encoded forms specified by 3.2.1.1 of the Advanced Message Queuing > Protocol (AMQP) JMS Mapping Version 1.0 [WD9]. > The problem also manifests when the Broker's message conversion feature is in > use. For instance, a message produced by a AMQP 0-10 producer cannot be > selected by an consumer using a Qpid JMS Client 1.0 using a {{JMSMessageID}} > or {{JMSCorrelationID}} predicate. This was originally highlighted by the > following user list post: > http://qpid.2158936.n2.nabble.com/JMSMessageID-differences-in-JMS-0-30-0-and-JMS-AMQP-0-x-6-3-0-clients-td7674019.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492478#comment-16492478 ] ASF subversion and git services commented on QPID-8139: --- Commit 560d4a3b3a51deb4cb79303976cd87a16b8e0997 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=560d4a3 ] QPID-8139: Reverted as per review comments Revert "QPID-8139: [Broker-J][AMQP 1.0] Make sure that selector filter can handle JMSMessageID and JMSCorrelationID values with prefixes as defined in AMQP JMS mapping specification" This reverts commit f1ce8666b80aa1ddd30445a6b2ce47db6b6943e9. > [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or > JMSCorrelationID expressed using the AMQP type encoded form values fail to > select target message > --- > > Key: QPID-8139 > URL: https://issues.apache.org/jira/browse/QPID-8139 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8139-Broker-J-AMQP-1.0-Make-sure-that-selector-.patch > > > When using the Qpid JMS AMQP 1.0 Client with Broker-J, if the consumer > specifies a JMS message selectors including a {{JMSMessageID}} or > {{JMSCorrelationID}} predicate, the selector can fail to find the target > message in some circumstances. This occurs when the message producer is > configured to use one of the following {{jms.messageIDPolicy.messageIDType}} > modes: {{UUID}}. {{UUID_STRING}}, {{PREFIXED_UUID_STRING}}. In the default > mode, {{BUILTIN}} the problem does not manifest. > The issue is the Broker-J JMS selector implementation does not understand the > AMQP type encoded forms specified by 3.2.1.1 of the Advanced Message Queuing > Protocol (AMQP) JMS Mapping Version 1.0 [WD9]. > The problem also manifests when the Broker's message conversion feature is in > use. For instance, a message produced by a AMQP 0-10 producer cannot be > selected by an consumer using a Qpid JMS Client 1.0 using a {{JMSMessageID}} > or {{JMSCorrelationID}} predicate. This was originally highlighted by the > following user list post: > http://qpid.2158936.n2.nabble.com/JMSMessageID-differences-in-JMS-0-30-0-and-JMS-AMQP-0-x-6-3-0-clients-td7674019.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492464#comment-16492464 ] Alex Rudyy commented on QPID-8139: -- Keith, Thanks for reviewing the changes in [f1ce866|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=]. I was reactant to change {{MessageTransferHeader}} to return {{Object}} from {{getMessageId}} and {{getCorrelationId}} as cross-protocol conversion requires more work in general. For example, 1.0 layer would need to know, that correlationId can be represented as array of bytes. To be fair, I think it should be a responsibility of conversion modules to do the conversion of messageId/correlationId between protocols. I will revert the change in f1ce866 and start over. > [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or > JMSCorrelationID expressed using the AMQP type encoded form values fail to > select target message > --- > > Key: QPID-8139 > URL: https://issues.apache.org/jira/browse/QPID-8139 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8139-Broker-J-AMQP-1.0-Make-sure-that-selector-.patch > > > When using the Qpid JMS AMQP 1.0 Client with Broker-J, if the consumer > specifies a JMS message selectors including a {{JMSMessageID}} or > {{JMSCorrelationID}} predicate, the selector can fail to find the target > message in some circumstances. This occurs when the message producer is > configured to use one of the following {{jms.messageIDPolicy.messageIDType}} > modes: {{UUID}}. {{UUID_STRING}}, {{PREFIXED_UUID_STRING}}. In the default > mode, {{BUILTIN}} the problem does not manifest. > The issue is the Broker-J JMS selector implementation does not understand the > AMQP type encoded forms specified by 3.2.1.1 of the Advanced Message Queuing > Protocol (AMQP) JMS Mapping Version 1.0 [WD9]. > The problem also manifests when the Broker's message conversion feature is in > use. For instance, a message produced by a AMQP 0-10 producer cannot be > selected by an consumer using a Qpid JMS Client 1.0 using a {{JMSMessageID}} > or {{JMSCorrelationID}} predicate. This was originally highlighted by the > following user list post: > http://qpid.2158936.n2.nabble.com/JMSMessageID-differences-in-JMS-0-30-0-and-JMS-AMQP-0-x-6-3-0-clients-td7674019.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org