[jira] [Commented] (DISPATCH-1001) Deprecate the tools under the console directory and move them to a separate npm repistory.

2018-05-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495883#comment-16495883
 ] 

ASF subversion and git services commented on DISPATCH-1001:
---

Commit 91def84726054a1680fb4a621c52a2ded77e in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=91def84 ]

DISPATCH-1001 Added README for removed console directories.


> Deprecate the tools under the console directory and move them to a separate 
> npm repistory.
> --
>
> Key: DISPATCH-1001
> URL: https://issues.apache.org/jira/browse/DISPATCH-1001
> Project: Qpid Dispatch
>  Issue Type: Task
>  Components: Console
>Affects Versions: 1.1.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.2.0
>
>
> Mark the console/config and console/dashboard directories as deprecated in 
> preperation to move them to their own repositories with the next release.
> These directories contain optional utilities. They are best stored in an npm 
> repository for easy installation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1001) Deprecate the tools under the console directory and move them to a separate npm repistory.

2018-05-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495882#comment-16495882
 ] 

ASF subversion and git services commented on DISPATCH-1001:
---

Commit a5e2307f6dae479f17308a3ff6db2af889196625 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=a5e2307 ]

DISPATCH-1001 Removed the deprecated directories


> Deprecate the tools under the console directory and move them to a separate 
> npm repistory.
> --
>
> Key: DISPATCH-1001
> URL: https://issues.apache.org/jira/browse/DISPATCH-1001
> Project: Qpid Dispatch
>  Issue Type: Task
>  Components: Console
>Affects Versions: 1.1.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.2.0
>
>
> Mark the console/config and console/dashboard directories as deprecated in 
> preperation to move them to their own repositories with the next release.
> These directories contain optional utilities. They are best stored in an npm 
> repository for easy installation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-982) Handle small form-factor screens

2018-05-30 Thread Ernest Allen (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen resolved DISPATCH-982.
---
   Resolution: Fixed
Fix Version/s: 1.2.0

> Handle small form-factor screens
> 
>
> Key: DISPATCH-982
> URL: https://issues.apache.org/jira/browse/DISPATCH-982
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.1.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.2.0
>
>
> When the width of the browser is decreased, adjust the console layout so that 
> the page is usable. This involves:
>  * Hiding horizontal page navigation tabs
>  * Hiding page menus
>  * Providing buttons to popup the navigation tabs and page menus
>  * Changing the UI to allow the page menus to be hidden and popped up
> Also, change the page menu color to be more consistent with patternfly.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1014) Visualize link congestion on topology page

2018-05-30 Thread Ernest Allen (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen resolved DISPATCH-1014.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Visualize link congestion on topology page
> --
>
> Key: DISPATCH-1014
> URL: https://issues.apache.org/jira/browse/DISPATCH-1014
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Console
>Affects Versions: 1.1.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.2.0
>
>
> Implement new visualization on topology page with the following features:
>  * controlled by radio button in legend. state should be saved
>  * change color of lines connecting routers and clients to indicate link 
> utilization
>  * colors should range from gray for idle, green for used, red for busy
>  * change arrow color on line to match the line's color
>  * mouseover line should popup info on links that contains address, 
> direction, undelivered, unsettled, rejected, released, modified
>  * popup should be dynamically updated while visible
>  * popup should be sorted by the sum of the link statistics and show up to 10 
> links
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1015) Improve visualization of connection and link info on console's topology page.

2018-05-30 Thread Ernest Allen (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen resolved DISPATCH-1015.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Improve visualization of connection and link info on console's topology page. 
> --
>
> Key: DISPATCH-1015
> URL: https://issues.apache.org/jira/browse/DISPATCH-1015
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.1.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.2.0
>
>
> Change the way connection and link info is presented on the topology page. 
> Changes should include:
>  * Remove the sliding panel on the left
>  * Remove connection cross-section that appeared when clicking on a line
>  * Remove grid of connections/links that appeared when clicking on a circle
>  * When page is narrow (mobile phone size)
>  ** hide legend
>  ** show page menu icon in banner
>  ** when page menu icon is clicked popup legend
>  * When mouseover a router, popup tooltip that shows
>  ** Full router name
>  ** list of listener ports
>  ** router version
>  * When mouseover a client/service/broker, popup tooltip that shows
>  ** type (sender/receiver/service/console/broker)
>  ** host
>  * When mouseover a line connecting circles, popup tooltip that shows
>  ** connection security, authentication, tenant
>  ** list of links
>  *** sorted descending by link statistics
>  *** up to 10 links
>  *** show link address, direction, statistics (undelivered, unsettled, 
> rejected, released, modified
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1015) Improve visualization of connection and link info on console's topology page.

2018-05-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495870#comment-16495870
 ] 

ASF subversion and git services commented on DISPATCH-1015:
---

Commit e149d5933eff11c87b467927bed3f0e56e653a81 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=e149d59 ]

DISPATCH-1015 Clean up popups on topology page.


> Improve visualization of connection and link info on console's topology page. 
> --
>
> Key: DISPATCH-1015
> URL: https://issues.apache.org/jira/browse/DISPATCH-1015
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.1.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
>
> Change the way connection and link info is presented on the topology page. 
> Changes should include:
>  * Remove the sliding panel on the left
>  * Remove connection cross-section that appeared when clicking on a line
>  * Remove grid of connections/links that appeared when clicking on a circle
>  * When page is narrow (mobile phone size)
>  ** hide legend
>  ** show page menu icon in banner
>  ** when page menu icon is clicked popup legend
>  * When mouseover a router, popup tooltip that shows
>  ** Full router name
>  ** list of listener ports
>  ** router version
>  * When mouseover a client/service/broker, popup tooltip that shows
>  ** type (sender/receiver/service/console/broker)
>  ** host
>  * When mouseover a line connecting circles, popup tooltip that shows
>  ** connection security, authentication, tenant
>  ** list of links
>  *** sorted descending by link statistics
>  *** up to 10 links
>  *** show link address, direction, statistics (undelivered, unsettled, 
> rejected, released, modified
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8200) [linearstore] Compile error when compiling on Fedora 28

2018-05-30 Thread Kim van der Riet (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495530#comment-16495530
 ] 

Kim van der Riet commented on QPID-8200:


Legacystore is not built by default, and I would be horrified if anyone is 
still using it... More than likely you are correct and a fix would be very 
similar to linearstore since the class in question is derived from the 
legacystore.

> [linearstore] Compile error when compiling on Fedora 28
> ---
>
> Key: QPID-8200
> URL: https://issues.apache.org/jira/browse/QPID-8200
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Reporter: Kim van der Riet
>Assignee: Kim van der Riet
>Priority: Major
>
> When compiling on Fedora 28, a compile warning {{-Werror=class-memaccess}} is 
> seen when compiling {{qpid::linearstore::journal::pmgr}} , and which was not 
> seen on Fedora 27:
> {noformat}
> qpid::linearstore::journal::pmgr::initialize(qpid::linearstore::journal::aio_callback*,
>  uint32_t, uint16_t)':
> /foo/cpp/src/qpid/linearstore/journal/pmgr.cpp:115:68: error: 'void* 
> memset(void*, int, size_t)' clearing an object of non-trivial type 'struct 
> qpid::linearstore::journal::pmgr::page_cb'; use assignment instead 
> [-Werror=class-memaccess]
>  std::memset(_page_cb_arr, 0, _cache_num_pages * sizeof(page_cb));
> ^
> In file included from /foo/cpp/src/qpid/linearstore/journal/pmgr.cpp:22:
> /foo/cpp/src/qpid/linearstore/journal/pmgr.h:63:12: note: 'struct 
> qpid::linearstore::journal::pmgr::page_cb' declared here
>  struct page_cb
> ^~~
> cc1plus: all warnings being treated as errors{noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1020) Detach expiring links with closed=true when peer connectivity lost

2018-05-30 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495442#comment-16495442
 ] 

Robbie Gemmell commented on DISPATCH-1020:
--

I believe Dispatch behaves this way due to prior discussions where it was noted 
the reverse behaviour was occurring (as it was sending closed=true all the 
time). It seems simpler to use closed=false all the time rather than have the 
codebase track the terminus settings and hope it gets it right everywhere.

> Detach expiring links with closed=true when peer connectivity lost
> --
>
> Key: DISPATCH-1020
> URL: https://issues.apache.org/jira/browse/DISPATCH-1020
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> Currently, Dispatch responds to the loss of an underlying connection to a 
> peer by detaching the links established over that connection in the following 
> way.
> {noformat}
> @detach(22) [handle=0, closed=false, error=@error(29) 
> [condition=:"qd:routed-link-lost", description="Connectivity to the peer 
> container was lost”]]
> {noformat}
> As is makes no sense for link defined to expire to attached again, it would 
> be an improvement to the dispatch's behaviour if those links were detached 
> with {{closed=true}}.  This would aid the timely clean-up of resources 
> elsewhere in the AMQP network.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1015) Improve visualization of connection and link info on console's topology page.

2018-05-30 Thread Ernest Allen (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen updated DISPATCH-1015:
---
Description: 
Change the way connection and link info is presented on the topology page. 
Changes should include:
 * Remove the sliding panel on the left
 * Remove connection cross-section that appeared when clicking on a line
 * Remove grid of connections/links that appeared when clicking on a circle
 * When page is narrow (mobile phone size)
 ** hide legend
 ** show page menu icon in banner
 ** when page menu icon is clicked popup legend
 * When mouseover a router, popup tooltip that shows
 ** Full router name
 ** list of listener ports
 ** router version
 * When mouseover a client/service/broker, popup tooltip that shows
 ** type (sender/receiver/service/console/broker)
 ** host
 * When mouseover a line connecting circles, popup tooltip that shows
 ** connection security, authentication, tenant
 ** list of links
 *** sorted descending by link statistics
 *** up to 10 links
 *** show link address, direction, statistics (undelivered, unsettled, 
rejected, released, modified

 

 

  was:
Change the way connection and link info is presented on the topology page. 
Changes should include:
 * Remove the sliding panel on the left
 * When page is narrow (mobile phone size)
 ** hide legend
 ** show page menu icon in banner
 ** when page menu icon is clicked popup legend
 * When mouseover a router, popup tooltip that shows
 ** Full router name
 ** list of listener ports
 ** router version
 * When mouseover a client/service/broker, popup tooltip that shows
 ** type (sender/receiver/service/console/broker)
 ** host
 ** connection properties if any
 ** security, authentication, tenant
 * When mouseover a line from routers to clients, popup tooltip that shows
 ** same info as mouseover the client circle
 ** list of links
 *** sorted descending by link statistics
 *** up to 10 links
 *** show link address, direction, statistics
 * When mouseover a line from router to router, popup tooltip that shows
 ** security, authentication, tenant
 ** same list of links as mouseover line to client (without address)
 * When click on line or router or client
 ** show modal dialog with same info as mouseover
 *** for list of links, show up to 20 links with ability to filter

 

 


> Improve visualization of connection and link info on console's topology page. 
> --
>
> Key: DISPATCH-1015
> URL: https://issues.apache.org/jira/browse/DISPATCH-1015
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.1.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
>
> Change the way connection and link info is presented on the topology page. 
> Changes should include:
>  * Remove the sliding panel on the left
>  * Remove connection cross-section that appeared when clicking on a line
>  * Remove grid of connections/links that appeared when clicking on a circle
>  * When page is narrow (mobile phone size)
>  ** hide legend
>  ** show page menu icon in banner
>  ** when page menu icon is clicked popup legend
>  * When mouseover a router, popup tooltip that shows
>  ** Full router name
>  ** list of listener ports
>  ** router version
>  * When mouseover a client/service/broker, popup tooltip that shows
>  ** type (sender/receiver/service/console/broker)
>  ** host
>  * When mouseover a line connecting circles, popup tooltip that shows
>  ** connection security, authentication, tenant
>  ** list of links
>  *** sorted descending by link statistics
>  *** up to 10 links
>  *** show link address, direction, statistics (undelivered, unsettled, 
> rejected, released, modified
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1018) CLONE - Install console dependencies with npm during make install

2018-05-30 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross updated DISPATCH-1018:
---
Fix Version/s: (was: 1.1.0)
   1.2.0

> CLONE - Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-1018
> URL: https://issues.apache.org/jira/browse/DISPATCH-1018
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Alan Conway
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.2.0
>
> Attachments: 
> 0001-NEED-JIRA-install-NPM-files-automatically-as-part-of.patch
>
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted

2018-05-30 Thread Alex Rudyy (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494923#comment-16494923
 ] 

Alex Rudyy edited comment on QPID-7541 at 5/30/18 9:24 AM:
---

As part of discussion on user mailing list [What is AMQP 1-0 spec complaint 
Broker behaviour for deletion of queue with consumers 
attached?|https://lists.apache.org/thread.html/3e64db4411925250b02e3f4648263a648c4406f1bbcb342369eeb06a@%3Cusers.qpid.apache.org%3E]
 the following consistent models for queue deletion were suggested:

*  when deleting a queue which has had messages "consumed" by an uncommitted 
transaction, the queue deletion treats those messages as if the transaction had
already rolled back (e.g. puts them on a DLQ or whatever), and then the 
transaction itself is marked as rollback only.  There is an implicit 
serialisation here that says that deleting the queue is an atomic operation and 
while it occurs you cannot process transaction commits/rollbacks which affect 
messages on the queue (nor can you allow new messages on to the queue nor allow 
acknowledgement of messages during the 'delete' operation).
* a queue cannot be deleted while there are associated sending or receiving 
links

I attached a patch implementing both approaches. The patch make changes to 
prevent the deletion of queue with any associated sending or receiving links by 
default. However, this default behaviour can be switched off by setting context 
variable {{qpid.queue.deleteUnusedOnly}} to {{false}} which would allow queue 
deletion as below:
* detaches all links with an error "amqp:resource-deleted"
* any in-progress producing/consuming transactions are marked as rollback-only
* the remaining messages on the deleted queue can be moved alternate binding if 
one is configured

Please note, that implemented changes do not add any locks for delete 
operation. Some more work is required to eliminate the races when the 
transaction discharge  starts before the queue deletion marks the transaction 
as rollback-only. The queue delete operation should wait for the discharging 
transactions to complete. 


was (Author: alex.rufous):
As part of discussion on user mailing list [What is AMQP 1-0 spec complaint 
Broker behaviour for deletion of queue with consumers 
attached?|https://lists.apache.org/thread.html/3e64db4411925250b02e3f4648263a648c4406f1bbcb342369eeb06a@%3Cusers.qpid.apache.org%3E]
 the following consistent models for queue deletion were suggested:

*  when deleting a queue which has had messages "consumed" by an uncommitted 
transaction, the queue deletion treats those messages as if the transaction had
already rolled back (e.g. puts them on a DLQ or whatever), and then the 
transaction itself is marked as rollback only.  There is an implicit 
serialisation here that says that deleting the queue is an atomic operation and 
while it occurs you cannot process transaction commits/rollbacks which affect 
messages on the queue (nor can you allow new
messages on to the queue nor allow acknowledgement of messages during the 
'delete' operation).
* a queue cannot be deleted while there are associated sending or receiving 
links

I attached a patch implementing both approaches. The patch make changes to 
prevent the deletion of queue with any associated sending or receiving links by 
default. However, this default behaviour can be switched off by setting context 
variable {{qpid.queue.deleteUnusedOnly}} to {{false}} which would allow queue 
deletion as below:
* detaches all links with an error "amqp:resource-deleted"
* any in-progress producing/consuming transactions are marked as rollback-only
* the remaining messages on the deleted queue can be moved alternate binding if 
one is configured

Please note, that implemented changes do not add any locks for delete 
operation. Some more work is required to eliminate the races when the 
transaction discharge  starts before the queue deletion marks the transaction 
as rollback-only. The queue delete operation should wait for the discharging 
transactions to complete. 

> [Java Broker] Close Consumers when a Queue is deleted
> -
>
> Key: QPID-7541
> URL: https://issues.apache.org/jira/browse/QPID-7541
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Reporter: Lorenz Quack
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments: 
> 0001-QPID-7541-Broker-J-Close-Consumers-when-a-Queue-is-d.patch, 
> proton-j_client.log, simultaneous_closing.log
>
>
> Currently when a Queue is deleted the associated Consumers are not closed. 
> This is essentially a resource leak.
> Note: In 6.1.x, for the AMQP 1.0 protocol, deleting a queue did detach the 
> sending links (without error).  Receiving links were not detached.   This 
> code 

[jira] [Commented] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted

2018-05-30 Thread Alex Rudyy (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494923#comment-16494923
 ] 

Alex Rudyy commented on QPID-7541:
--

As part of discussion on user mailing list [What is AMQP 1-0 spec complaint 
Broker behaviour for deletion of queue with consumers 
attached?|https://lists.apache.org/thread.html/3e64db4411925250b02e3f4648263a648c4406f1bbcb342369eeb06a@%3Cusers.qpid.apache.org%3E]
 the following consistent models for queue deletion were suggested:

*  when deleting a queue which has had messages "consumed" by an uncommitted 
transaction, the queue deletion treats those messages as if the transaction had
already rolled back (e.g. puts them on a DLQ or whatever), and then the 
transaction itself is marked as rollback only.  There is an implicit 
serialisation here that says that deleting the queue is an atomic operation and 
while it occurs you cannot process transaction commits/rollbacks which affect 
messages on the queue (nor can you allow new
messages on to the queue nor allow acknowledgement of messages during the 
'delete' operation).
* a queue cannot be deleted while there are associated sending or receiving 
links

I attached a patch implementing both approaches. The patch make changes to 
prevent the deletion of queue with any associated sending or receiving links by 
default. However, this default behaviour can be switched off by setting context 
variable {{qpid.queue.deleteUnusedOnly}} to {{false}} which would allow queue 
deletion as below:
* detaches all links with an error "amqp:resource-deleted"
* any in-progress producing/consuming transactions are marked as rollback-only
* the remaining messages on the deleted queue can be moved alternate binding if 
one is configured

Please note, that implemented changes do not add any locks for delete 
operation. Some more work is required to eliminate the races when the 
transaction discharge  starts before the queue deletion marks the transaction 
as rollback-only. The queue delete operation should wait for the discharging 
transactions to complete. 

> [Java Broker] Close Consumers when a Queue is deleted
> -
>
> Key: QPID-7541
> URL: https://issues.apache.org/jira/browse/QPID-7541
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Reporter: Lorenz Quack
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments: 
> 0001-QPID-7541-Broker-J-Close-Consumers-when-a-Queue-is-d.patch, 
> proton-j_client.log, simultaneous_closing.log
>
>
> Currently when a Queue is deleted the associated Consumers are not closed. 
> This is essentially a resource leak.
> Note: In 6.1.x, for the AMQP 1.0 protocol, deleting a queue did detach the 
> sending links (without error).  Receiving links were not detached.   This 
> code (org.apache.qpid.server.protocol.v1_0.ConsumerTarget_1_0#queueDeleted) 
> was removed in 7.0.x and this JIRA raised.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted

2018-05-30 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7541:
-
Attachment: 0001-QPID-7541-Broker-J-Close-Consumers-when-a-Queue-is-d.patch

> [Java Broker] Close Consumers when a Queue is deleted
> -
>
> Key: QPID-7541
> URL: https://issues.apache.org/jira/browse/QPID-7541
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Reporter: Lorenz Quack
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments: 
> 0001-QPID-7541-Broker-J-Close-Consumers-when-a-Queue-is-d.patch, 
> proton-j_client.log, simultaneous_closing.log
>
>
> Currently when a Queue is deleted the associated Consumers are not closed. 
> This is essentially a resource leak.
> Note: In 6.1.x, for the AMQP 1.0 protocol, deleting a queue did detach the 
> sending links (without error).  Receiving links were not detached.   This 
> code (org.apache.qpid.server.protocol.v1_0.ConsumerTarget_1_0#queueDeleted) 
> was removed in 7.0.x and this JIRA raised.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1020) Detach expiring links with closed=true when peer connectivity lost

2018-05-30 Thread Keith Wall (JIRA)
Keith Wall created DISPATCH-1020:


 Summary: Detach expiring links with closed=true when peer 
connectivity lost
 Key: DISPATCH-1020
 URL: https://issues.apache.org/jira/browse/DISPATCH-1020
 Project: Qpid Dispatch
  Issue Type: Improvement
Reporter: Keith Wall


Currently, Dispatch responds to the loss of an underlying connection to a peer 
by detaching the links established over that connection in the following way.

{noformat}
@detach(22) [handle=0, closed=false, error=@error(29) 
[condition=:"qd:routed-link-lost", description="Connectivity to the peer 
container was lost”]]
{noformat}

As is makes no sense for link defined to expire to attached again, it would be 
an improvement to the dispatch's behaviour if those links were detached with 
{{closed=true}}.  This would aid the timely clean-up of resources elsewhere in 
the AMQP network.





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org