[jira] [Updated] (DISPATCH-1085) When sender closes connection after sending a large streaming message, receiver gets aborted message
[ https://issues.apache.org/jira/browse/DISPATCH-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1085: Attachment: amqp_consumer.py amqp_producer.py > When sender closes connection after sending a large streaming message, > receiver gets aborted message > > > Key: DISPATCH-1085 > URL: https://issues.apache.org/jira/browse/DISPATCH-1085 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > Attachments: amqp_consumer.py, amqp_producer.py > > > Steps to reproduce > (Sender and receiver programs are attached) > Start a router > Start a receiver - ./amqp_consumer.py "0.0.0.0:5672" MYTEST 1 > Start a sender that sends a large message - ./amqp_producer.py "0.0.0.0:5672" > MYTEST 100 > > You will see that the receiver receives an aborted transfer > {noformat} > [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, > delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, > more=true] (130560) > "@\xc9\xf3\xe4k\x8e\xf5\x88:Bl\x97\xc5\x11\x17\xff\x1b\x0f\x13\xc85\x87\x9f7\x05\x9a\x1dI\xd76\xe2\xe7\x84\x92\xdf\xa3&\x07\xc0\x1eF\xb5\x96\xef\xb6\xbd\xe5\xe2\xb1\xe7\xb9\x7f\xe0\x0d\xe8]\xe0\x85\xecrE\xc4\x0e'\xbd\x8d\xa8\xe1x@,%\xa0\x90\xa4+.\xcf\x93T'}\x1f\xf3\xcc0d\x016\xe9\xa0\x7fT}\xf5n\xeb\xfc\xa9\x8d > > \xdc\xc3e?\x03\x04\xc3\xa0|\x85\x80\x08\x0a\x98\xbe8-\x00?\xa5`\xb1\xe7h0\x12\x90%\xa7\xc2S\xbe\x83\x05\x12\xe0\x98B\xe3Qp\xc9F\x90\x8f\xe8\xf9\x90\xba'\xb0\xdb$\x14<\xd9\xd1\x7fm"\x84\xda\x96X\xa1\xe3\xee\xb9\xf7\xdaToFb\xaa7\x13\x12\xfd\xdb\x9e\x80\x99{\x13q~Av8\xd0\x87\x9e\xf7\xfd\x9a\x1b\xb8|tNtw\xcf\xc0U\x9e\xf5F\xc3\xd2\xb0%\xff\xb1\xfd\xb8\\xa9\xfb\xb1G\xb2/\xc7\xe8\x91\x1e\xfd\xa2\x1c\xc5\x9f\xe6M?\xe3\xacOa\x0c\xa7/\x82\xfb$km\x1a\xfb`\xb0+zrO\x8a\x06}\xd5\x0a\x17m\xad\x91L\x89\xb2}\x92\x03\xe3\xd3F\xd8:Z\x80r\xa0b\xc7C\xd9\xdc\xe7\x08\xbf2s\xbf\xf8\x98\xf5OZ\xb7\x8a:\xeb\xe7\xfc,\xdd\xbb\xa6s+]\xa2On\x14@\xc8lGa\xf58\xd7N\x94J\xe0+\x92\xbd\xb4\xce\xb0\xacL\xf7\x00\x14\xb3J\xdd@I\x8f\xb4\x9d"... > (truncated) > [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, > delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, > more=true] (256512) > ".\xf7\x1b\xb0\x15\x17\x8b\xb6\xfe/\x00\xde\x95\xa2\xcc\xd5K\xbd\x92\x00\xc8\xd8e\xfc\xa5\xd8o2\x80?j\xea\xb7\xe3\xa1\x96x\x0bF\x02\xfa<~\x1c\xdd\xc4\xbeb8\x13\xdf\xa4\x15\x8c\x01\x08\xa0\xf9\x8d\xc4\xfe\x89\xfc\x8ek'\xc2\x0d\xec\x11'\x1c\xc6(j\x8a\xddir\x02\x09\xbc\xcb\xadS\x8c\x17D\x92\xbf\xe1\x9bg\xb5\xb2.\xe6`2D\x9eC@\xa6\xe5\xce\xa6\x16\xc2\x13\xa9\x0a\xbe\x0c\xa7\x88\xd6\xc0\xb6\xacSz\x11\xde\xf4\x8f4\xfb\x1c~D\xbd.\x8bk\\x9a\xc9\xbfm\x9d\xcbc\xc1\xf7\x89?\x91\xd04+\xfa\xd2i\x14\xdeg+5\x1bT\x97s8\xbb{\xecS:\x97Uy\x0bt\x93o\x8a\x91\xa2\x93\xa9\xd0M\x0bol\x89\xa1\xb4\x182\x84\xb4A^#\xa5\x7f\xde\xbfo\xfc\x96\xbc)\xa2^\xa9\xd97-\xac48`BbT9Gn\xd8\xe8\xed\xc9(\x8b\xb6\xf1\xb4\x1c\x82c\xfd\xbbO\xe9c\xb61\xd7\xcd\xe2\xd2\x86W\xe8:\x04\x8c\xd4\x1fU\xfa\xc3\xc9\xc4G\xbe\x07SFx\x8e\xd6-\xa0\xf9\xe3\x92d\x0d}vtkP\x149b\xeeU > > \xbd\x96\x93\x8f@\x1f\x9b\x81V\xfd\xe5\xb6\x159*\xc1xWA\xd3\xe7o\xaa\xf4a\x7fh\x834,\x0a\xa4\xbb\x15$\xd30%\xe9LGW'\x81\x06OE\x07\xd8\xd0o\x14\xba\x88M\x0dXWm\xf2q\xc3\xc6\xef\x98\x1f\x00\x1aQ"... > (truncated) > [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, > delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, > settled=true, aborted=true] > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1085) When sender closes connection after sending a large streaming message, receiver gets aborted message
[ https://issues.apache.org/jira/browse/DISPATCH-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553303#comment-16553303 ] ASF GitHub Bot commented on DISPATCH-1085: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/345 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=h1) Report > Merging [#345](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/53493714c631ebfdaa0687525a0da531b44f1ea9?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `85.71%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/345/graphs/tree.svg?width=650&height=150&token=rk2Cgd27pP&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #345 +/- ## == + Coverage 84.29% 84.31% +0.01% == Files 69 69 Lines 1567415684 +10 == + Hits1321313224 +11 + Misses 2461 2460 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.09% <100%> (+0.64%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.18% <81.81%> (-0.48%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.1% <0%> (-0.46%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.2% <0%> (-0.23%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `70.7% <0%> (+0.19%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `86.06% <0%> (+0.23%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `99.26% <0%> (+0.36%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=footer). Last update [5349371...3d19ec9](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > When sender closes connection after sending a large streaming message, > receiver gets aborted message > > > Key: DISPATCH-1085 > URL: https://issues.apache.org/jira/browse/DISPATCH-1085 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Steps to reproduce > (Sender and receiver programs are attached) > Start a router > Start a receiver - ./amqp_consumer.py "0.0.0.0:5672" MYTEST 1 > Start a sender that sends a large message - ./amqp_producer.py "0.0.0.0:5672" > MYTEST 100 > > You will see that the receiver receives an aborted transfer > {noformat} > [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, > delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, > more=true] (130560) > "@\xc9\xf3\xe4k\x8e\xf5\x88:Bl\x97\xc5\x11\x17\xff\x1b\x0f\x13\xc85\x87\x9f7\x05\x9a\x1dI\xd76\xe2\xe7\x84\x92\xdf\xa3&\x07\xc0\x1eF\xb5\x96\xef\xb6\xbd\xe5\xe2\xb1\xe7\xb9\x7f\xe0\x0d\xe8]\xe0\x85\xecrE\xc4\x0e'\xbd\x8d\xa8\xe1x@,%\xa0\x90\xa4+.\xcf\x93T'}\x1f\xf3\xcc0d\x
[GitHub] qpid-dispatch issue #345: DISPATCH-1085 - Modified AMQP_link_detach_handler ...
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/345 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=h1) Report > Merging [#345](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/53493714c631ebfdaa0687525a0da531b44f1ea9?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `85.71%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/345/graphs/tree.svg?width=650&height=150&token=rk2Cgd27pP&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #345 +/- ## == + Coverage 84.29% 84.31% +0.01% == Files 69 69 Lines 1567415684 +10 == + Hits1321313224 +11 + Misses 2461 2460 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=tree) | Coverage Π| | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.09% <100%> (+0.64%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.18% <81.81%> (-0.48%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.1% <0%> (-0.46%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.2% <0%> (-0.23%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `70.7% <0%> (+0.19%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `86.06% <0%> (+0.23%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `99.26% <0%> (+0.36%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=footer). Last update [5349371...3d19ec9](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1085) When sender closes connection after sending a large streaming message, receiver gets aborted message
[ https://issues.apache.org/jira/browse/DISPATCH-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553294#comment-16553294 ] ASF GitHub Bot commented on DISPATCH-1085: -- GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/345 DISPATCH-1085 - Modified AMQP_link_detach_handler to flush out the re… …maining bytes in the message buffers before responding to detaches You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1085 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #345 commit 3d19ec903881ec2b66b9b014f0f037a67ea40952 Author: Ganesh Murthy Date: 2018-07-23T19:21:44Z DISPATCH-1085 - Modified AMQP_link_detach_handler to flush out the remaining bytes in the message buffers before responding to detaches > When sender closes connection after sending a large streaming message, > receiver gets aborted message > > > Key: DISPATCH-1085 > URL: https://issues.apache.org/jira/browse/DISPATCH-1085 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Steps to reproduce > (Sender and receiver programs are attached) > Start a router > Start a receiver - ./amqp_consumer.py "0.0.0.0:5672" MYTEST 1 > Start a sender that sends a large message - ./amqp_producer.py "0.0.0.0:5672" > MYTEST 100 > > You will see that the receiver receives an aborted transfer > {noformat} > [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, > delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, > more=true] (130560) > "@\xc9\xf3\xe4k\x8e\xf5\x88:Bl\x97\xc5\x11\x17\xff\x1b\x0f\x13\xc85\x87\x9f7\x05\x9a\x1dI\xd76\xe2\xe7\x84\x92\xdf\xa3&\x07\xc0\x1eF\xb5\x96\xef\xb6\xbd\xe5\xe2\xb1\xe7\xb9\x7f\xe0\x0d\xe8]\xe0\x85\xecrE\xc4\x0e'\xbd\x8d\xa8\xe1x@,%\xa0\x90\xa4+.\xcf\x93T'}\x1f\xf3\xcc0d\x016\xe9\xa0\x7fT}\xf5n\xeb\xfc\xa9\x8d > > \xdc\xc3e?\x03\x04\xc3\xa0|\x85\x80\x08\x0a\x98\xbe8-\x00?\xa5`\xb1\xe7h0\x12\x90%\xa7\xc2S\xbe\x83\x05\x12\xe0\x98B\xe3Qp\xc9F\x90\x8f\xe8\xf9\x90\xba'\xb0\xdb$\x14<\xd9\xd1\x7fm"\x84\xda\x96X\xa1\xe3\xee\xb9\xf7\xdaToFb\xaa7\x13\x12\xfd\xdb\x9e\x80\x99{\x13q~Av8\xd0\x87\x9e\xf7\xfd\x9a\x1b\xb8|tNtw\xcf\xc0U\x9e\xf5F\xc3\xd2\xb0%\xff\xb1\xfd\xb8\\xa9\xfb\xb1G\xb2/\xc7\xe8\x91\x1e\xfd\xa2\x1c\xc5\x9f\xe6M?\xe3\xacOa\x0c\xa7/\x82\xfb$km\x1a\xfb`\xb0+zrO\x8a\x06}\xd5\x0a\x17m\xad\x91L\x89\xb2}\x92\x03\xe3\xd3F\xd8:Z\x80r\xa0b\xc7C\xd9\xdc\xe7\x08\xbf2s\xbf\xf8\x98\xf5OZ\xb7\x8a:\xeb\xe7\xfc,\xdd\xbb\xa6s+]\xa2On\x14@\xc8lGa\xf58\xd7N\x94J\xe0+\x92\xbd\xb4\xce\xb0\xacL\xf7\x00\x14\xb3J\xdd@I\x8f\xb4\x9d"... > (truncated) > [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, > delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, > more=true] (256512) > ".\xf7\x1b\xb0\x15\x17\x8b\xb6\xfe/\x00\xde\x95\xa2\xcc\xd5K\xbd\x92\x00\xc8\xd8e\xfc\xa5\xd8o2\x80?j\xea\xb7\xe3\xa1\x96x\x0bF\x02\xfa<~\x1c\xdd\xc4\xbeb8\x13\xdf\xa4\x15\x8c\x01\x08\xa0\xf9\x8d\xc4\xfe\x89\xfc\x8ek'\xc2\x0d\xec\x11'\x1c\xc6(j\x8a\xddir\x02\x09\xbc\xcb\xadS\x8c\x17D\x92\xbf\xe1\x9bg\xb5\xb2.\xe6`2D\x9eC@\xa6\xe5\xce\xa6\x16\xc2\x13\xa9\x0a\xbe\x0c\xa7\x88\xd6\xc0\xb6\xacSz\x11\xde\xf4\x8f4\xfb\x1c~D\xbd.\x8bk\\x9a\xc9\xbfm\x9d\xcbc\xc1\xf7\x89?\x91\xd04+\xfa\xd2i\x14\xdeg+5\x1bT\x97s8\xbb{\xecS:\x97Uy\x0bt\x93o\x8a\x91\xa2\x93\xa9\xd0M\x0bol\x89\xa1\xb4\x182\x84\xb4A^#\xa5\x7f\xde\xbfo\xfc\x96\xbc)\xa2^\xa9\xd97-\xac48`BbT9Gn\xd8\xe8\xed\xc9(\x8b\xb6\xf1\xb4\x1c\x82c\xfd\xbbO\xe9c\xb61\xd7\xcd\xe2\xd2\x86W\xe8:\x04\x8c\xd4\x1fU\xfa\xc3\xc9\xc4G\xbe\x07SFx\x8e\xd6-\xa0\xf9\xe3\x92d\x0d}vtkP\x149b\xeeU > > \xbd\x96\x93\x8f@\x1f\x9b\x81V\xfd\xe5\xb6\x159*\xc1xWA\xd3\xe7o\xaa\xf4a\x7fh\x834,\x0a\xa4\xbb\x15$\xd30%\xe9LGW'\x81\x06OE\x07\xd8\xd0o\x14\xba\x88M\x0dXWm\xf2q\xc3\xc6\xef\x98\x1f\x00\x1aQ"... > (truncated) > [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, > delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, > settled=true, aborted=true] > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #345: DISPATCH-1085 - Modified AMQP_link_detach_h...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/345 DISPATCH-1085 - Modified AMQP_link_detach_handler to flush out the re⦠â¦maining bytes in the message buffers before responding to detaches You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1085 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #345 commit 3d19ec903881ec2b66b9b014f0f037a67ea40952 Author: Ganesh Murthy Date: 2018-07-23T19:21:44Z DISPATCH-1085 - Modified AMQP_link_detach_handler to flush out the remaining bytes in the message buffers before responding to detaches --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1085) When sender closes connection after sending a large streaming message, receiver gets aborted message
Ganesh Murthy created DISPATCH-1085: --- Summary: When sender closes connection after sending a large streaming message, receiver gets aborted message Key: DISPATCH-1085 URL: https://issues.apache.org/jira/browse/DISPATCH-1085 Project: Qpid Dispatch Issue Type: Bug Components: Container Affects Versions: 1.2.0 Reporter: Ganesh Murthy Assignee: Ganesh Murthy Fix For: 1.3.0 Steps to reproduce (Sender and receiver programs are attached) Start a router Start a receiver - ./amqp_consumer.py "0.0.0.0:5672" MYTEST 1 Start a sender that sends a large message - ./amqp_producer.py "0.0.0.0:5672" MYTEST 100 You will see that the receiver receives an aborted transfer {noformat} [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, more=true] (130560) "@\xc9\xf3\xe4k\x8e\xf5\x88:Bl\x97\xc5\x11\x17\xff\x1b\x0f\x13\xc85\x87\x9f7\x05\x9a\x1dI\xd76\xe2\xe7\x84\x92\xdf\xa3&\x07\xc0\x1eF\xb5\x96\xef\xb6\xbd\xe5\xe2\xb1\xe7\xb9\x7f\xe0\x0d\xe8]\xe0\x85\xecrE\xc4\x0e'\xbd\x8d\xa8\xe1x@,%\xa0\x90\xa4+.\xcf\x93T'}\x1f\xf3\xcc0d\x016\xe9\xa0\x7fT}\xf5n\xeb\xfc\xa9\x8d \xdc\xc3e?\x03\x04\xc3\xa0|\x85\x80\x08\x0a\x98\xbe8-\x00?\xa5`\xb1\xe7h0\x12\x90%\xa7\xc2S\xbe\x83\x05\x12\xe0\x98B\xe3Qp\xc9F\x90\x8f\xe8\xf9\x90\xba'\xb0\xdb$\x14<\xd9\xd1\x7fm"\x84\xda\x96X\xa1\xe3\xee\xb9\xf7\xdaToFb\xaa7\x13\x12\xfd\xdb\x9e\x80\x99{\x13q~Av8\xd0\x87\x9e\xf7\xfd\x9a\x1b\xb8|tNtw\xcf\xc0U\x9e\xf5F\xc3\xd2\xb0%\xff\xb1\xfd\xb8\\xa9\xfb\xb1G\xb2/\xc7\xe8\x91\x1e\xfd\xa2\x1c\xc5\x9f\xe6M?\xe3\xacOa\x0c\xa7/\x82\xfb$km\x1a\xfb`\xb0+zrO\x8a\x06}\xd5\x0a\x17m\xad\x91L\x89\xb2}\x92\x03\xe3\xd3F\xd8:Z\x80r\xa0b\xc7C\xd9\xdc\xe7\x08\xbf2s\xbf\xf8\x98\xf5OZ\xb7\x8a:\xeb\xe7\xfc,\xdd\xbb\xa6s+]\xa2On\x14@\xc8lGa\xf58\xd7N\x94J\xe0+\x92\xbd\xb4\xce\xb0\xacL\xf7\x00\x14\xb3J\xdd@I\x8f\xb4\x9d"... (truncated) [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, more=true] (256512) ".\xf7\x1b\xb0\x15\x17\x8b\xb6\xfe/\x00\xde\x95\xa2\xcc\xd5K\xbd\x92\x00\xc8\xd8e\xfc\xa5\xd8o2\x80?j\xea\xb7\xe3\xa1\x96x\x0bF\x02\xfa<~\x1c\xdd\xc4\xbeb8\x13\xdf\xa4\x15\x8c\x01\x08\xa0\xf9\x8d\xc4\xfe\x89\xfc\x8ek'\xc2\x0d\xec\x11'\x1c\xc6(j\x8a\xddir\x02\x09\xbc\xcb\xadS\x8c\x17D\x92\xbf\xe1\x9bg\xb5\xb2.\xe6`2D\x9eC@\xa6\xe5\xce\xa6\x16\xc2\x13\xa9\x0a\xbe\x0c\xa7\x88\xd6\xc0\xb6\xacSz\x11\xde\xf4\x8f4\xfb\x1c~D\xbd.\x8bk\\x9a\xc9\xbfm\x9d\xcbc\xc1\xf7\x89?\x91\xd04+\xfa\xd2i\x14\xdeg+5\x1bT\x97s8\xbb{\xecS:\x97Uy\x0bt\x93o\x8a\x91\xa2\x93\xa9\xd0M\x0bol\x89\xa1\xb4\x182\x84\xb4A^#\xa5\x7f\xde\xbfo\xfc\x96\xbc)\xa2^\xa9\xd97-\xac48`BbT9Gn\xd8\xe8\xed\xc9(\x8b\xb6\xf1\xb4\x1c\x82c\xfd\xbbO\xe9c\xb61\xd7\xcd\xe2\xd2\x86W\xe8:\x04\x8c\xd4\x1fU\xfa\xc3\xc9\xc4G\xbe\x07SFx\x8e\xd6-\xa0\xf9\xe3\x92d\x0d}vtkP\x149b\xeeU \xbd\x96\x93\x8f@\x1f\x9b\x81V\xfd\xe5\xb6\x159*\xc1xWA\xd3\xe7o\xaa\xf4a\x7fh\x834,\x0a\xa4\xbb\x15$\xd30%\xe9LGW'\x81\x06OE\x07\xd8\xd0o\x14\xba\x88M\x0dXWm\xf2q\xc3\xc6\xef\x98\x1f\x00\x1aQ"... (truncated) [0x558d24f46210]:0 <- @transfer(20) [handle=0, delivery-id=0, delivery-tag=b"\x00\x00\x00\x00\x00\x00\x00\x00", message-format=0, settled=true, aborted=true] {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1084) The color for new addresses on topology visualizations is incorrect
[ https://issues.apache.org/jira/browse/DISPATCH-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553221#comment-16553221 ] ASF subversion and git services commented on DISPATCH-1084: --- Commit 53493714c631ebfdaa0687525a0da531b44f1ea9 in qpid-dispatch's branch refs/heads/master from [~eallen] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=5349371 ] DISPATCH-1084 Initialize d3 colors before use. > The color for new addresses on topology visualizations is incorrect > --- > > Key: DISPATCH-1084 > URL: https://issues.apache.org/jira/browse/DISPATCH-1084 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.2.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.3.0 > > > To reproduce: > # Start message flow from one router to another on an address > # View the 'Message path by address' visualization on the topology page. > # Start a second message flow on a different address > If the second address less than the first address (sorted alphabetically) > then the visualization for the second address will get the same color as the > first address. > Each address should have a unique color in the visualization that matches the > color in the legend. > Workaround is to switch to a different console page and then back to the > topology page. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1084) The color for new addresses on topology visualizations is incorrect
[ https://issues.apache.org/jira/browse/DISPATCH-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1084. Resolution: Fixed Fix Version/s: 1.3.0 > The color for new addresses on topology visualizations is incorrect > --- > > Key: DISPATCH-1084 > URL: https://issues.apache.org/jira/browse/DISPATCH-1084 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.2.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.3.0 > > > To reproduce: > # Start message flow from one router to another on an address > # View the 'Message path by address' visualization on the topology page. > # Start a second message flow on a different address > If the second address less than the first address (sorted alphabetically) > then the visualization for the second address will get the same color as the > first address. > Each address should have a unique color in the visualization that matches the > color in the legend. > Workaround is to switch to a different console page and then back to the > topology page. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1084) The color for new addresses on topology visualizations is incorrect
Ernest Allen created DISPATCH-1084: -- Summary: The color for new addresses on topology visualizations is incorrect Key: DISPATCH-1084 URL: https://issues.apache.org/jira/browse/DISPATCH-1084 Project: Qpid Dispatch Issue Type: Bug Components: Console Affects Versions: 1.2.0 Reporter: Ernest Allen Assignee: Ernest Allen To reproduce: # Start message flow from one router to another on an address # View the 'Message path by address' visualization on the topology page. # Start a second message flow on a different address If the second address less than the first address (sorted alphabetically) then the visualization for the second address will get the same color as the first address. Each address should have a unique color in the visualization that matches the color in the legend. Workaround is to switch to a different console page and then back to the topology page. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1077) Reported rate of message traffic is incorrect on console's 'message traffic' page
[ https://issues.apache.org/jira/browse/DISPATCH-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1077. Resolution: Fixed Fix Version/s: 1.3.0 > Reported rate of message traffic is incorrect on console's 'message traffic' > page > - > > Key: DISPATCH-1077 > URL: https://issues.apache.org/jira/browse/DISPATCH-1077 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.2.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.3.0 > > > The rate of message traffic shown when the mouse is moved over a chord on the > Message Traffic page is incorrect. It appears to be 1/2 of the actual rate. > The relative rates of the various chords is correct therefore the size of the > chords is correct. It is just the number displayed when the mouse is moved > over the chord that is incorrect. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1077) Reported rate of message traffic is incorrect on console's 'message traffic' page
[ https://issues.apache.org/jira/browse/DISPATCH-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552672#comment-16552672 ] ASF subversion and git services commented on DISPATCH-1077: --- Commit 69af7476e1631ccfd1a223daec943f9aaad18570 in qpid-dispatch's branch refs/heads/master from [~eallen] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=69af747 ] DISPATCH-1077 Fix rate calculation on Console's chord diagram. > Reported rate of message traffic is incorrect on console's 'message traffic' > page > - > > Key: DISPATCH-1077 > URL: https://issues.apache.org/jira/browse/DISPATCH-1077 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.2.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > The rate of message traffic shown when the mouse is moved over a chord on the > Message Traffic page is incorrect. It appears to be 1/2 of the actual rate. > The relative rates of the various chords is correct therefore the size of the > chords is correct. It is just the number displayed when the mouse is moved > over the chord that is incorrect. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org