[GitHub] qpid-proton pull request #:
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/commit/3dd3bd4913af915d1632fed57c350d76a5cd0ba2#commitcomment-30626748 In ruby/lib/core/connection.rb: In ruby/lib/core/connection.rb on line 117: Try indenting by 2 spaces when you continue the long line. YARD prefers continuations to be indented - it allows them to not be in some cases for backwards compat, but if you're having trouble try indenting. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #:
Github user ssorj commented on the pull request: https://github.com/apache/qpid-proton/commit/3dd3bd4913af915d1632fed57c350d76a5cd0ba2#commitcomment-30626644 In ruby/lib/core/connection.rb: In ruby/lib/core/connection.rb on line 117: I tried and failed to figure it out last time, so I resorted to the really long line ;). I'll try again. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[ https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626421#comment-16626421 ] ASF GitHub Bot commented on DISPATCH-1129: -- Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/382#discussion_r219978301 --- Diff: src/router_core/router_core_private.h --- @@ -440,6 +440,17 @@ struct qdr_link_ref_t { ALLOC_DECLARE(qdr_link_ref_t); DEQ_DECLARE(qdr_link_ref_t, qdr_link_ref_list_t); + +typedef struct qdr_forward_deliver_info_t { --- End diff -- This is only used in forwarder.c. Why not move all of this into that file? > Receiver crash due to data corruption on multicast streamed messages > > > Key: DISPATCH-1129 > URL: https://issues.apache.org/jira/browse/DISPATCH-1129 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.3.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.4.0 > > Attachments: blue.conf, collectd.conf, datafile.txt, green.conf, > simple_recv.py, simple_send_datafile.py > > > Create a 3 router network using the attached router config files. It forms a > linear network > > Router -> Router B -> Router C > Attach one receiver on Router B and another one on Router C. Send a 50k > streaming message using a sender connected to Router A. > > One of the receivers will crash with the following error > > {noformat} > Traceback (most recent call last): > File "simple_recv.py", line 55, in > Container(Recv(opts.address, opts.messages)).run() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 175, in run > while self.process(): pass > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 201, in process > self._check_errors() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 197, in _check_errors > _compat.raise_(exc, value, tb) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py", > line 133, in dispatch > ev.dispatch(self.handler) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 254, in dispatch > self.dispatch(h, type) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 251, in dispatch > result = dispatch(handler, type.method, self) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 113, in dispatch > return m(*args) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 178, in on_delivery > event.message = recv_msg(dlv) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 107, in recv_msg > msg.decode(delivery.link.recv(delivery.pending)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 398, in decode > self._check(pn_message_decode(self._msg, data)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 94, in _check > raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg > proton._exceptions.MessageException: [-6]: data error: (null) > [gmurthy@localhost examples]$ > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #382: DISPATCH-1129 - Moved call to forwarding mu...
Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/382#discussion_r219978301 --- Diff: src/router_core/router_core_private.h --- @@ -440,6 +440,17 @@ struct qdr_link_ref_t { ALLOC_DECLARE(qdr_link_ref_t); DEQ_DECLARE(qdr_link_ref_t, qdr_link_ref_list_t); + +typedef struct qdr_forward_deliver_info_t { --- End diff -- This is only used in forwarder.c. Why not move all of this into that file? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626403#comment-16626403 ] Alan Conway commented on PROTON-1940: - Proposed fix: https://github.com/apache/qpid-proton/pull/159 > [c] normalize encoding of multiple="true" fields > > > Key: PROTON-1940 > URL: https://issues.apache.org/jira/browse/PROTON-1940 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > The AMQP spec defines some frame fields as "multiple". > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation] > "The _multiple_ attribute of a field description controls whether multiple > element values are permitted in the representation. A single element of the > type specified in the field description is always permitted. Multiple values > are represented by the use of an array where the type of the elements in the > array is the type defined in the field definition. Note that a null value and > a zero-length array (with a correct type for its elements) both describe an > absence of a value and MUST be treated as semantically identical. " > Proton accepts all legal values. This issue is to normalize values written by > proton: > * empty array becomes null > * array of one element becomes a single value > This is the most efficient encoding, and some clients (.NET) have problems > with multiple fields that contain an empty array rather than a null. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626401#comment-16626401 ] ASF GitHub Bot commented on PROTON-1940: GitHub user alanconway opened a pull request: https://github.com/apache/qpid-proton/pull/159 PROTON-1940: [c] normalize encoding of multiple="true" fields AMQP spec allows several ways to encode a "multiple" field, we allow all in incoming data or pn_data_t values created in the user, but when writing to the wire we always encode: - empty array as null - single value array as a single value - multiple values - encoded as array This is the most compact encoding and seems to be best for interop, as some AMQP clients (.NET) have trouble with an empty array in a multiple value field. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alanconway/qpid-proton c-multiple-null Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/159.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #159 commit 51f4c581411a3295054323028faa59fdb56f4604 Author: Alan Conway Date: 2018-09-24T15:41:03Z PROTON-1940: [c] normalize encoding of multiple="true" fields AMQP spec allows several ways to encode a "multiple" field, we allow all in incoming data or pn_data_t values created in the user, but when writing to the wire we always encode: - empty array as null - single value array as a single value - multiple values - encoded as array This is the most compact encoding and seems to be best for interop, as some AMQP clients (.NET) have trouble with an empty array in a multiple value field. > [c] normalize encoding of multiple="true" fields > > > Key: PROTON-1940 > URL: https://issues.apache.org/jira/browse/PROTON-1940 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > The AMQP spec defines some frame fields as "multiple". > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation] > "The _multiple_ attribute of a field description controls whether multiple > element values are permitted in the representation. A single element of the > type specified in the field description is always permitted. Multiple values > are represented by the use of an array where the type of the elements in the > array is the type defined in the field definition. Note that a null value and > a zero-length array (with a correct type for its elements) both describe an > absence of a value and MUST be treated as semantically identical. " > Proton accepts all legal values. This issue is to normalize values written by > proton: > * empty array becomes null > * array of one element becomes a single value > This is the most efficient encoding, and some clients (.NET) have problems > with multiple fields that contain an empty array rather than a null. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1937) Json::Value conversion error at build time
[ https://issues.apache.org/jira/browse/PROTON-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626396#comment-16626396 ] ASF GitHub Bot commented on PROTON-1937: Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/158 > Json::Value conversion error at build time > -- > > Key: PROTON-1937 > URL: https://issues.apache.org/jira/browse/PROTON-1937 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.25.0 > Environment: Fedora 27, GNU C 7.3.1, JsonCpp 1.8.3 >Reporter: Chuck Rolke >Priority: Major > Attachments: proton-5595c-build.txt > > > {{connect_config.cpp:73:15: error:}} > {{could not convert ‘obj’ from ‘const Json::Value’ to ‘bool’}} > > Full build long attached -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-proton/pull/159 PROTON-1940: [c] normalize encoding of multiple="true" fields AMQP spec allows several ways to encode a "multiple" field, we allow all in incoming data or pn_data_t values created in the user, but when writing to the wire we always encode: - empty array as null - single value array as a single value - multiple values - encoded as array This is the most compact encoding and seems to be best for interop, as some AMQP clients (.NET) have trouble with an empty array in a multiple value field. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alanconway/qpid-proton c-multiple-null Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/159.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #159 commit 51f4c581411a3295054323028faa59fdb56f4604 Author: Alan Conway Date: 2018-09-24T15:41:03Z PROTON-1940: [c] normalize encoding of multiple="true" fields AMQP spec allows several ways to encode a "multiple" field, we allow all in incoming data or pn_data_t values created in the user, but when writing to the wire we always encode: - empty array as null - single value array as a single value - multiple values - encoded as array This is the most compact encoding and seems to be best for interop, as some AMQP clients (.NET) have trouble with an empty array in a multiple value field. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #158: PROTON-1937: Use value.type() to check for va...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/158 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1937) Json::Value conversion error at build time
[ https://issues.apache.org/jira/browse/PROTON-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626395#comment-16626395 ] ASF subversion and git services commented on PROTON-1937: - Commit 436275a37349b7c909dc397ae3aff704e49b7ba0 in qpid-proton's branch refs/heads/master from [~chug] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=436275a ] PROTON-1937: Use value.type() to check for value presence or absence This closes #158 > Json::Value conversion error at build time > -- > > Key: PROTON-1937 > URL: https://issues.apache.org/jira/browse/PROTON-1937 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.25.0 > Environment: Fedora 27, GNU C 7.3.1, JsonCpp 1.8.3 >Reporter: Chuck Rolke >Priority: Major > Attachments: proton-5595c-build.txt > > > {{connect_config.cpp:73:15: error:}} > {{could not convert ‘obj’ from ‘const Json::Value’ to ‘bool’}} > > Full build long attached -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (QPIDJMS-413) Incorrect array access code in ReadableBuffer implementation
[ https://issues.apache.org/jira/browse/QPIDJMS-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish closed QPIDJMS-413. Resolution: Fixed > Incorrect array access code in ReadableBuffer implementation > > > Key: QPIDJMS-413 > URL: https://issues.apache.org/jira/browse/QPIDJMS-413 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.36.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Trivial > Fix For: 0.37.0 > > > Code in the proton-j ReadableBuffer wrapper implementation incorrectly > computes the array offset of the backing Netty ByteBuf's array if present. > Not currently hit in client code but could be in future depending on usage. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-413) Incorrect array access code in ReadableBuffer implementation
[ https://issues.apache.org/jira/browse/QPIDJMS-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626334#comment-16626334 ] ASF subversion and git services commented on QPIDJMS-413: - Commit 1d7230e032abf355d9e92778f07eae2609541041 in qpid-jms's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=1d7230e ] QPIDJMS-413 Fix improper calculation in the ReadableBuffer Don't add reader index to the array offset for the underlying buffer. > Incorrect array access code in ReadableBuffer implementation > > > Key: QPIDJMS-413 > URL: https://issues.apache.org/jira/browse/QPIDJMS-413 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.36.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Trivial > Fix For: 0.37.0 > > > Code in the proton-j ReadableBuffer wrapper implementation incorrectly > computes the array offset of the backing Netty ByteBuf's array if present. > Not currently hit in client code but could be in future depending on usage. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-413) Incorrect array access code in ReadableBuffer implementation
Timothy Bish created QPIDJMS-413: Summary: Incorrect array access code in ReadableBuffer implementation Key: QPIDJMS-413 URL: https://issues.apache.org/jira/browse/QPIDJMS-413 Project: Qpid JMS Issue Type: Bug Components: qpid-jms-client Affects Versions: 0.36.0 Reporter: Timothy Bish Assignee: Timothy Bish Fix For: 0.37.0 Code in the proton-j ReadableBuffer wrapper implementation incorrectly computes the array offset of the backing Netty ByteBuf's array if present. Not currently hit in client code but could be in future depending on usage. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1940) [c] normalize encoding of multiple="true" fields
Alan Conway created PROTON-1940: --- Summary: [c] normalize encoding of multiple="true" fields Key: PROTON-1940 URL: https://issues.apache.org/jira/browse/PROTON-1940 Project: Qpid Proton Issue Type: Improvement Components: proton-c Affects Versions: proton-c-0.25.0 Reporter: Alan Conway Assignee: Alan Conway Fix For: proton-c-0.26.0 The AMQP spec defines some frame fields as "multiple". [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation] "The _multiple_ attribute of a field description controls whether multiple element values are permitted in the representation. A single element of the type specified in the field description is always permitted. Multiple values are represented by the use of an array where the type of the elements in the array is the type defined in the field definition. Note that a null value and a zero-length array (with a correct type for its elements) both describe an absence of a value and MUST be treated as semantically identical. " Proton accepts all legal values. This issue is to normalize values written by proton: * empty array becomes null * array of one element becomes a single value This is the most efficient encoding, and some clients (.NET) have problems with multiple fields that contain an empty array rather than a null. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[ https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626302#comment-16626302 ] ASF GitHub Bot commented on DISPATCH-1129: -- GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/382 DISPATCH-1129 - Moved call to forwarding multicast messages to end of… … forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch AARON-PROBLEM Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/382.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #382 commit 00edc49fec82aaabcf4d3bfc65e24ed0b73d1d62 Author: Ganesh Murthy Date: 2018-09-24T17:06:47Z DISPATCH-1129 - Moved call to forwarding multicast messages to end of forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed > Receiver crash due to data corruption on multicast streamed messages > > > Key: DISPATCH-1129 > URL: https://issues.apache.org/jira/browse/DISPATCH-1129 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.3.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.4.0 > > Attachments: blue.conf, collectd.conf, datafile.txt, green.conf, > simple_recv.py, simple_send_datafile.py > > > Create a 3 router network using the attached router config files. It forms a > linear network > > Router -> Router B -> Router C > Attach one receiver on Router B and another one on Router C. Send a 50k > streaming message using a sender connected to Router A. > > One of the receivers will crash with the following error > > {noformat} > Traceback (most recent call last): > File "simple_recv.py", line 55, in > Container(Recv(opts.address, opts.messages)).run() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 175, in run > while self.process(): pass > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 201, in process > self._check_errors() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 197, in _check_errors > _compat.raise_(exc, value, tb) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py", > line 133, in dispatch > ev.dispatch(self.handler) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 254, in dispatch > self.dispatch(h, type) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 251, in dispatch > result = dispatch(handler, type.method, self) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 113, in dispatch > return m(*args) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 178, in on_delivery > event.message = recv_msg(dlv) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 107, in recv_msg > msg.decode(delivery.link.recv(delivery.pending)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 398, in decode > self._check(pn_message_decode(self._msg, data)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 94, in _check > raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg > proton._exceptions.MessageException: [-6]: data error: (null) > [gmurthy@localhost examples]$ > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #382: DISPATCH-1129 - Moved call to forwarding mu...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/382 DISPATCH-1129 - Moved call to forwarding multicast messages to end of⦠⦠forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch AARON-PROBLEM Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/382.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #382 commit 00edc49fec82aaabcf4d3bfc65e24ed0b73d1d62 Author: Ganesh Murthy Date: 2018-09-24T17:06:47Z DISPATCH-1129 - Moved call to forwarding multicast messages to end of forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[ https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626291#comment-16626291 ] ASF subversion and git services commented on DISPATCH-1129: --- Commit 00edc49fec82aaabcf4d3bfc65e24ed0b73d1d62 in qpid-dispatch's branch refs/heads/AARON-PROBLEM from [~ganeshmurthy] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=00edc49 ] DISPATCH-1129 - Moved call to forwarding multicast messages to end of forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed > Receiver crash due to data corruption on multicast streamed messages > > > Key: DISPATCH-1129 > URL: https://issues.apache.org/jira/browse/DISPATCH-1129 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.3.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.4.0 > > Attachments: blue.conf, collectd.conf, datafile.txt, green.conf, > simple_recv.py, simple_send_datafile.py > > > Create a 3 router network using the attached router config files. It forms a > linear network > > Router -> Router B -> Router C > Attach one receiver on Router B and another one on Router C. Send a 50k > streaming message using a sender connected to Router A. > > One of the receivers will crash with the following error > > {noformat} > Traceback (most recent call last): > File "simple_recv.py", line 55, in > Container(Recv(opts.address, opts.messages)).run() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 175, in run > while self.process(): pass > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 201, in process > self._check_errors() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 197, in _check_errors > _compat.raise_(exc, value, tb) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py", > line 133, in dispatch > ev.dispatch(self.handler) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 254, in dispatch > self.dispatch(h, type) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 251, in dispatch > result = dispatch(handler, type.method, self) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 113, in dispatch > return m(*args) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 178, in on_delivery > event.message = recv_msg(dlv) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 107, in recv_msg > msg.decode(delivery.link.recv(delivery.pending)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 398, in decode > self._check(pn_message_decode(self._msg, data)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 94, in _check > raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg > proton._exceptions.MessageException: [-6]: data error: (null) > [gmurthy@localhost examples]$ > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1126) ERROR Attempt to attach too many inter-router links for priority sheaf.
[ https://issues.apache.org/jira/browse/DISPATCH-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] michael goulish reassigned DISPATCH-1126: - Assignee: michael goulish > ERROR Attempt to attach too many inter-router links for priority sheaf. > --- > > Key: DISPATCH-1126 > URL: https://issues.apache.org/jira/browse/DISPATCH-1126 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.3.0 > Environment: Fedora 28 > * Three router network in linear arrangement A - B - C. > * B has a listener; A and C connect to it > >Reporter: Chuck Rolke >Assignee: michael goulish >Priority: Major > Attachments: taj-GRN.log > > > Some state probably not cleaned up when router connections are lost. 10 > messages > (error) Attempt to attach too many inter-router links for priority sheaf. > appear when routers reconnect. > Start the network. Then kill routers A and C and restart them. Router B > prints the messages. > Log file attached -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[ https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1129: Attachment: simple_recv.py > Receiver crash due to data corruption on multicast streamed messages > > > Key: DISPATCH-1129 > URL: https://issues.apache.org/jira/browse/DISPATCH-1129 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.3.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.4.0 > > Attachments: blue.conf, collectd.conf, datafile.txt, green.conf, > simple_recv.py, simple_send_datafile.py > > > Create a 3 router network using the attached router config files. It forms a > linear network > > Router -> Router B -> Router C > Attach one receiver on Router B and another one on Router C. Send a 50k > streaming message using a sender connected to Router A. > > One of the receivers will crash with the following error > > {noformat} > Traceback (most recent call last): > File "simple_recv.py", line 55, in > Container(Recv(opts.address, opts.messages)).run() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 175, in run > while self.process(): pass > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 201, in process > self._check_errors() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 197, in _check_errors > _compat.raise_(exc, value, tb) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py", > line 133, in dispatch > ev.dispatch(self.handler) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 254, in dispatch > self.dispatch(h, type) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 251, in dispatch > result = dispatch(handler, type.method, self) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 113, in dispatch > return m(*args) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 178, in on_delivery > event.message = recv_msg(dlv) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 107, in recv_msg > msg.decode(delivery.link.recv(delivery.pending)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 398, in decode > self._check(pn_message_decode(self._msg, data)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 94, in _check > raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg > proton._exceptions.MessageException: [-6]: data error: (null) > [gmurthy@localhost examples]$ > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[ https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1129: Attachment: datafile.txt > Receiver crash due to data corruption on multicast streamed messages > > > Key: DISPATCH-1129 > URL: https://issues.apache.org/jira/browse/DISPATCH-1129 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.3.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.4.0 > > Attachments: blue.conf, collectd.conf, datafile.txt, green.conf, > simple_send_datafile.py > > > Create a 3 router network using the attached router config files. It forms a > linear network > > Router -> Router B -> Router C > Attach one receiver on Router B and another one on Router C. Send a 50k > streaming message using a sender connected to Router A. > > One of the receivers will crash with the following error > > {noformat} > Traceback (most recent call last): > File "simple_recv.py", line 55, in > Container(Recv(opts.address, opts.messages)).run() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 175, in run > while self.process(): pass > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 201, in process > self._check_errors() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 197, in _check_errors > _compat.raise_(exc, value, tb) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py", > line 133, in dispatch > ev.dispatch(self.handler) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 254, in dispatch > self.dispatch(h, type) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 251, in dispatch > result = dispatch(handler, type.method, self) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 113, in dispatch > return m(*args) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 178, in on_delivery > event.message = recv_msg(dlv) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 107, in recv_msg > msg.decode(delivery.link.recv(delivery.pending)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 398, in decode > self._check(pn_message_decode(self._msg, data)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 94, in _check > raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg > proton._exceptions.MessageException: [-6]: data error: (null) > [gmurthy@localhost examples]$ > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[ https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1129: Attachment: simple_send_datafile.py > Receiver crash due to data corruption on multicast streamed messages > > > Key: DISPATCH-1129 > URL: https://issues.apache.org/jira/browse/DISPATCH-1129 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.3.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.4.0 > > Attachments: blue.conf, collectd.conf, datafile.txt, green.conf, > simple_send_datafile.py > > > Create a 3 router network using the attached router config files. It forms a > linear network > > Router -> Router B -> Router C > Attach one receiver on Router B and another one on Router C. Send a 50k > streaming message using a sender connected to Router A. > > One of the receivers will crash with the following error > > {noformat} > Traceback (most recent call last): > File "simple_recv.py", line 55, in > Container(Recv(opts.address, opts.messages)).run() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 175, in run > while self.process(): pass > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 201, in process > self._check_errors() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 197, in _check_errors > _compat.raise_(exc, value, tb) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py", > line 133, in dispatch > ev.dispatch(self.handler) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 254, in dispatch > self.dispatch(h, type) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 251, in dispatch > result = dispatch(handler, type.method, self) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 113, in dispatch > return m(*args) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 178, in on_delivery > event.message = recv_msg(dlv) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 107, in recv_msg > msg.decode(delivery.link.recv(delivery.pending)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 398, in decode > self._check(pn_message_decode(self._msg, data)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 94, in _check > raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg > proton._exceptions.MessageException: [-6]: data error: (null) > [gmurthy@localhost examples]$ > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[ https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1129: Attachment: green.conf collectd.conf blue.conf > Receiver crash due to data corruption on multicast streamed messages > > > Key: DISPATCH-1129 > URL: https://issues.apache.org/jira/browse/DISPATCH-1129 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.3.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.4.0 > > Attachments: blue.conf, collectd.conf, green.conf > > > Create a 3 router network using the attached router config files. It forms a > linear network > > Router -> Router B -> Router C > Attach one receiver on Router B and another one on Router C. Send a 50k > streaming message using a sender connected to Router A. > > One of the receivers will crash with the following error > > {noformat} > Traceback (most recent call last): > File "simple_recv.py", line 55, in > Container(Recv(opts.address, opts.messages)).run() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 175, in run > while self.process(): pass > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 201, in process > self._check_errors() > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", > line 197, in _check_errors > _compat.raise_(exc, value, tb) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py", > line 133, in dispatch > ev.dispatch(self.handler) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 254, in dispatch > self.dispatch(h, type) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 251, in dispatch > result = dispatch(handler, type.method, self) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 113, in dispatch > return m(*args) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 178, in on_delivery > event.message = recv_msg(dlv) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", > line 107, in recv_msg > msg.decode(delivery.link.recv(delivery.pending)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 398, in decode > self._check(pn_message_decode(self._msg, data)) > File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", > line 94, in _check > raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg > proton._exceptions.MessageException: [-6]: data error: (null) > [gmurthy@localhost examples]$ > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
Ganesh Murthy created DISPATCH-1129: --- Summary: Receiver crash due to data corruption on multicast streamed messages Key: DISPATCH-1129 URL: https://issues.apache.org/jira/browse/DISPATCH-1129 Project: Qpid Dispatch Issue Type: Improvement Components: Container Affects Versions: 1.3.0 Reporter: Ganesh Murthy Assignee: Ganesh Murthy Fix For: 1.4.0 Create a 3 router network using the attached router config files. It forms a linear network Router -> Router B -> Router C Attach one receiver on Router B and another one on Router C. Send a 50k streaming message using a sender connected to Router A. One of the receivers will crash with the following error {noformat} Traceback (most recent call last): File "simple_recv.py", line 55, in Container(Recv(opts.address, opts.messages)).run() File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", line 175, in run while self.process(): pass File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", line 201, in process self._check_errors() File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py", line 197, in _check_errors _compat.raise_(exc, value, tb) File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py", line 133, in dispatch ev.dispatch(self.handler) File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", line 254, in dispatch self.dispatch(h, type) File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", line 251, in dispatch result = dispatch(handler, type.method, self) File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", line 113, in dispatch return m(*args) File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", line 178, in on_delivery event.message = recv_msg(dlv) File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py", line 107, in recv_msg msg.decode(delivery.link.recv(delivery.pending)) File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", line 398, in decode self._check(pn_message_decode(self._msg, data)) File "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py", line 94, in _check raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg proton._exceptions.MessageException: [-6]: data error: (null) [gmurthy@localhost examples]$ {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1127) Add idle timeout to console when router requires username/password
[ https://issues.apache.org/jira/browse/DISPATCH-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen reassigned DISPATCH-1127: -- Assignee: Ernest Allen > Add idle timeout to console when router requires username/password > --- > > Key: DISPATCH-1127 > URL: https://issues.apache.org/jira/browse/DISPATCH-1127 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.3.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > When the router is configured to require a username and password to login, > the console should detect long periods of no activity (idle) and > automatically log out and return to the connect page. > The idle timeout should be a setting in the config file's console section. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1128) Add delivery rate to connection mouseover on topology page
Ernest Allen created DISPATCH-1128: -- Summary: Add delivery rate to connection mouseover on topology page Key: DISPATCH-1128 URL: https://issues.apache.org/jira/browse/DISPATCH-1128 Project: Qpid Dispatch Issue Type: Improvement Components: Console Affects Versions: 1.3.0 Reporter: Ernest Allen Assignee: Ernest Allen On the console's topology page, if you mouseover a client connection (line between router and client) you get a popup with info about the connect and info about the links. Currently the popup contains per address aggregate attributes like undelivered, unsettled, rejected, etc. These are not as useful as the per address current rate of deliveries. For each address listed, add the rate of deliveries to the connection mouseover popup. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1127) Add idle timeout to console when router requires username/password
Ernest Allen created DISPATCH-1127: -- Summary: Add idle timeout to console when router requires username/password Key: DISPATCH-1127 URL: https://issues.apache.org/jira/browse/DISPATCH-1127 Project: Qpid Dispatch Issue Type: Improvement Components: Console Affects Versions: 1.3.0 Reporter: Ernest Allen When the router is configured to require a username and password to login, the console should detect long periods of no activity (idle) and automatically log out and return to the connect page. The idle timeout should be a setting in the config file's console section. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1109) use serving host and port as defaults for connect screen in console served by router
[ https://issues.apache.org/jira/browse/DISPATCH-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625819#comment-16625819 ] ASF subversion and git services commented on DISPATCH-1109: --- Commit e64d247a926c40befa1eddc64761a78e3bb0d23b in qpid-dispatch's branch refs/heads/master from [~eallen] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=e64d247 ] DISPATCH-1109 Set default port based on protocol > use serving host and port as defaults for connect screen in console served by > router > > > Key: DISPATCH-1109 > URL: https://issues.apache.org/jira/browse/DISPATCH-1109 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Gordon Sim >Assignee: Ted Ross >Priority: Major > Fix For: 1.4.0 > > > If you have a router serving up the console, and you have authentication > enabled, then when you go to the url to retrieve the console it loads up the > connect screen (because it can't connect without username and password). > However the connection defaults to localhost:5673. It would be much nicer if > it could default to the host/port from which the console was itself loaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1109) use serving host and port as defaults for connect screen in console served by router
[ https://issues.apache.org/jira/browse/DISPATCH-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625808#comment-16625808 ] ASF subversion and git services commented on DISPATCH-1109: --- Commit b9ffcc649bce80dfe8fb1b6e75c941ee2a0b7131 in qpid-dispatch's branch refs/heads/master from [~eallen] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=b9ffcc6 ] DISPATCH-1109 Handling case where port is not specified > use serving host and port as defaults for connect screen in console served by > router > > > Key: DISPATCH-1109 > URL: https://issues.apache.org/jira/browse/DISPATCH-1109 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Gordon Sim >Assignee: Ted Ross >Priority: Major > Fix For: 1.4.0 > > > If you have a router serving up the console, and you have authentication > enabled, then when you go to the url to retrieve the console it loads up the > connect screen (because it can't connect without username and password). > However the connection defaults to localhost:5673. It would be much nicer if > it could default to the host/port from which the console was itself loaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org