[jira] [Updated] (DISPATCH-1148) auth plugin should indicate version in open properties

2018-10-18 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated DISPATCH-1148:
-
Fix Version/s: 1.5.0

> auth plugin should indicate version in open properties
> --
>
> Key: DISPATCH-1148
> URL: https://issues.apache.org/jira/browse/DISPATCH-1148
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1149) authz plugin can no longer override conf file policy

2018-10-18 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated DISPATCH-1149:
-
Fix Version/s: 1.5.0

> authz plugin can no longer override conf file policy
> 
>
> Key: DISPATCH-1149
> URL: https://issues.apache.org/jira/browse/DISPATCH-1149
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
> Fix For: 1.5.0
>
>
> If enabled, the authz plugin should be allowed to defined the valid sources 
> and targets for a given connection and this should take precedence over 
> anything in the policy file (which may still be used for quotas).
> This was (I believe) an unintentional regression by 
> https://github.com/apache/qpid-dispatch/commit/dc981ecc6cf31d8c605e84703a589553281281c2#diff-adc0a0fef2880417cb24cb072363fc29
>  which reverted the necessary change made in 
> https://github.com/apache/qpid-dispatch/commit/eed8bb65497b23e512072f5ea9fefd8ed73921ef#diff-adc0a0fef2880417cb24cb072363fc29



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1148) auth plugin should indicate version in open properties

2018-10-18 Thread Gordon Sim (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved DISPATCH-1148.
--
Resolution: Fixed

> auth plugin should indicate version in open properties
> --
>
> Key: DISPATCH-1148
> URL: https://issues.apache.org/jira/browse/DISPATCH-1148
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1149) authz plugin can no longer override conf file policy

2018-10-18 Thread Gordon Sim (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved DISPATCH-1149.
--
Resolution: Fixed

> authz plugin can no longer override conf file policy
> 
>
> Key: DISPATCH-1149
> URL: https://issues.apache.org/jira/browse/DISPATCH-1149
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
>
> If enabled, the authz plugin should be allowed to defined the valid sources 
> and targets for a given connection and this should take precedence over 
> anything in the policy file (which may still be used for quotas).
> This was (I believe) an unintentional regression by 
> https://github.com/apache/qpid-dispatch/commit/dc981ecc6cf31d8c605e84703a589553281281c2#diff-adc0a0fef2880417cb24cb072363fc29
>  which reverted the necessary change made in 
> https://github.com/apache/qpid-dispatch/commit/eed8bb65497b23e512072f5ea9fefd8ed73921ef#diff-adc0a0fef2880417cb24cb072363fc29



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1149) authz plugin can no longer override conf file policy

2018-10-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655913#comment-16655913
 ] 

ASF subversion and git services commented on DISPATCH-1149:
---

Commit 7baa254aafb5699004d87587bd385f2df776bed3 in qpid-dispatch's branch 
refs/heads/master from Gordon Sim
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=7baa254 ]

DISPATCH-1149: allow authz plugin to override conf file policy


> authz plugin can no longer override conf file policy
> 
>
> Key: DISPATCH-1149
> URL: https://issues.apache.org/jira/browse/DISPATCH-1149
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
>
> If enabled, the authz plugin should be allowed to defined the valid sources 
> and targets for a given connection and this should take precedence over 
> anything in the policy file (which may still be used for quotas).
> This was (I believe) an unintentional regression by 
> https://github.com/apache/qpid-dispatch/commit/dc981ecc6cf31d8c605e84703a589553281281c2#diff-adc0a0fef2880417cb24cb072363fc29
>  which reverted the necessary change made in 
> https://github.com/apache/qpid-dispatch/commit/eed8bb65497b23e512072f5ea9fefd8ed73921ef#diff-adc0a0fef2880417cb24cb072363fc29



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1148) auth plugin should indicate version in open properties

2018-10-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655912#comment-16655912
 ] 

ASF subversion and git services commented on DISPATCH-1148:
---

Commit b4385f9e79ac981fdd2d1faf1d9b0588661da0b2 in qpid-dispatch's branch 
refs/heads/master from Gordon Sim
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=b4385f9 ]

DISPATCH-1148: set version in open frames sent to auth service


> auth plugin should indicate version in open properties
> --
>
> Key: DISPATCH-1148
> URL: https://issues.apache.org/jira/browse/DISPATCH-1148
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1149) authz plugin can no longer override conf file policy

2018-10-18 Thread Gordon Sim (JIRA)
Gordon Sim created DISPATCH-1149:


 Summary: authz plugin can no longer override conf file policy
 Key: DISPATCH-1149
 URL: https://issues.apache.org/jira/browse/DISPATCH-1149
 Project: Qpid Dispatch
  Issue Type: Bug
Reporter: Gordon Sim
Assignee: Gordon Sim


If enabled, the authz plugin should be allowed to defined the valid sources and 
targets for a given connection and this should take precedence over anything in 
the policy file (which may still be used for quotas).

This was (I believe) an unintentional regression by 
https://github.com/apache/qpid-dispatch/commit/dc981ecc6cf31d8c605e84703a589553281281c2#diff-adc0a0fef2880417cb24cb072363fc29
 which reverted the necessary change made in 
https://github.com/apache/qpid-dispatch/commit/eed8bb65497b23e512072f5ea9fefd8ed73921ef#diff-adc0a0fef2880417cb24cb072363fc29



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1148) auth plugin should indicate version in open properties

2018-10-18 Thread Gordon Sim (JIRA)
Gordon Sim created DISPATCH-1148:


 Summary: auth plugin should indicate version in open properties
 Key: DISPATCH-1148
 URL: https://issues.apache.org/jira/browse/DISPATCH-1148
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 1.4.0
Reporter: Gordon Sim
Assignee: Gordon Sim






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1144) Improve overview and getting started doc

2018-10-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655706#comment-16655706
 ] 

ASF GitHub Bot commented on DISPATCH-1144:
--

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/391


> Improve overview and getting started doc
> 
>
> Key: DISPATCH-1144
> URL: https://issues.apache.org/jira/browse/DISPATCH-1144
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
>
> Improve the Dispatch Router doc so that a user can quickly get up to speed 
> and get started with the router.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #391: DISPATCH-1144: Improve overview and getting...

2018-10-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/391


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1144) Improve overview and getting started doc

2018-10-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655705#comment-16655705
 ] 

ASF subversion and git services commented on DISPATCH-1144:
---

Commit 40de3931637e6986563524776dacfdd15b8b6aad in qpid-dispatch's branch 
refs/heads/master from [~bhardest]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=40de393 ]

DISPATCH-1144: Improve overview and getting started doc
This closes #391


> Improve overview and getting started doc
> 
>
> Key: DISPATCH-1144
> URL: https://issues.apache.org/jira/browse/DISPATCH-1144
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
>
> Improve the Dispatch Router doc so that a user can quickly get up to speed 
> and get started with the router.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-959) Rate limiting policy

2018-10-18 Thread michael goulish (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655668#comment-16655668
 ] 

michael goulish commented on DISPATCH-959:
--

This is not a bug, it's a new feature.

> Rate limiting policy
> 
>
> Key: DISPATCH-959
> URL: https://issues.apache.org/jira/browse/DISPATCH-959
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Policy Engine, Routing Engine
>Affects Versions: 1.0.1
>Reporter: Chuck Rolke
>Priority: Major
> Fix For: Backlog
>
>
> Router administrators would like rate-limiting policies to allow different 
> classes of users. A network-rate limit similar to how home cable networks are 
> provisioned for bandwidth is a classic model and is being considered as the 
> first choice.
> A message-per-second limit might be easier to enforce. But a single user 
> message may have a large data section, or have a small data section but have 
> huge message annotations. Thus a user might consume a lot of network 
> bandwidth with only a few messages.
> It is still unclear at what level the rate limiting should be applied. 
> Choices are:
>  * Per vhost
>  * Per vhost connection
>  * Per vhost user



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #336: No JIRA: Propose doc contribution guideline...

2018-10-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/336


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (DISPATCH-1139) support prioritized addresses

2018-10-18 Thread michael goulish (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

michael goulish closed DISPATCH-1139.
-
Resolution: Implemented

> support prioritized addresses
> -
>
> Key: DISPATCH-1139
> URL: https://issues.apache.org/jira/browse/DISPATCH-1139
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node, Routing Engine, Tests
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Support a new field in the address descriptor in router configuration files 
> that will assign a priority to the address.
> Any message that does not have an intrinsic priority already assigned will 
> inherit the priority of the address to which it is sent.  If no priority is 
> explicitly assigned to an address, then it will be assigned the default 
> priority.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1139) support prioritized addresses

2018-10-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655649#comment-16655649
 ] 

ASF subversion and git services commented on DISPATCH-1139:
---

Commit 57347bea6e143a58209dcf90865888fd1989b6c0 in qpid-dispatch's branch 
refs/heads/master from mgoulish
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=57347be ]

DISPATCH-1139 : no need for priority field in query struct.


> support prioritized addresses
> -
>
> Key: DISPATCH-1139
> URL: https://issues.apache.org/jira/browse/DISPATCH-1139
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node, Routing Engine, Tests
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Support a new field in the address descriptor in router configuration files 
> that will assign a priority to the address.
> Any message that does not have an intrinsic priority already assigned will 
> inherit the priority of the address to which it is sent.  If no priority is 
> explicitly assigned to an address, then it will be assigned the default 
> priority.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1145) Edge Router - Implement address proxy component

2018-10-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655560#comment-16655560
 ] 

ASF subversion and git services commented on DISPATCH-1145:
---

Commit bad9121428b1c30a3cac6875b93a20f8bb280b79 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=bad9121 ]

DISPATCH-1145 - Wired in the new edge-data link events.  Added an edge_context 
value to qdr_link_t.


> Edge Router - Implement address proxy component
> ---
>
> Key: DISPATCH-1145
> URL: https://issues.apache.org/jira/browse/DISPATCH-1145
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.5.0
>
>
> The Address Proxy is a component of the Edge Router module. It runs only on 
> an edge router. It has two main responsibilities:
> Address Proxy has three main responsibilities:
> # When an uplink becomes active, the "_uplink" address is properly linked to 
> an outgoing anonymous link on the active uplink connection.
> # When an uplink becomes active, an incoming link is established over the 
> uplink connection that is used to transfer deliveries to topological 
> (dynamic) addresses on the edge router.
> # Ensure that if there is an active uplink, that uplink should have one 
> incoming link for every address for which there is at least one local 
> consumer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1139) support prioritized addresses

2018-10-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1664#comment-1664
 ] 

ASF GitHub Bot commented on DISPATCH-1139:
--

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/392


> support prioritized addresses
> -
>
> Key: DISPATCH-1139
> URL: https://issues.apache.org/jira/browse/DISPATCH-1139
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node, Routing Engine, Tests
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Support a new field in the address descriptor in router configuration files 
> that will assign a priority to the address.
> Any message that does not have an intrinsic priority already assigned will 
> inherit the priority of the address to which it is sent.  If no priority is 
> explicitly assigned to an address, then it will be assigned the default 
> priority.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #392: DISPATCH-1139 : address priority support an...

2018-10-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/392


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1139) support prioritized addresses

2018-10-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1661#comment-1661
 ] 

ASF subversion and git services commented on DISPATCH-1139:
---

Commit bb4f3121989cb4b91d4e364287868da1594f3acf in qpid-dispatch's branch 
refs/heads/master from Michael Goulish
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=bb4f312 ]

DISPATCH-1139 : address priority support and test


> support prioritized addresses
> -
>
> Key: DISPATCH-1139
> URL: https://issues.apache.org/jira/browse/DISPATCH-1139
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node, Routing Engine, Tests
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Support a new field in the address descriptor in router configuration files 
> that will assign a priority to the address.
> Any message that does not have an intrinsic priority already assigned will 
> inherit the priority of the address to which it is sent.  If no priority is 
> explicitly assigned to an address, then it will be assigned the default 
> priority.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1139) support prioritized addresses

2018-10-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655415#comment-16655415
 ] 

ASF GitHub Bot commented on DISPATCH-1139:
--

Github user codecov-io commented on the issue:

https://github.com/apache/qpid-dispatch/pull/392
  
# 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=h1) 
Report
> Merging 
[#392](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/9c5666f6d1e36979d6d4b3e657c5c5246ffbf5df?src=pr=desc)
 will **increase** coverage by `0.04%`.
> The diff coverage is `85.71%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/392/graphs/tree.svg?width=650=rk2Cgd27pP=150=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #392  +/-   ##
==
+ Coverage  85%   85.04%   +0.04% 
==
  Files  76   76  
  Lines   1677016783  +13 
==
+ Hits1425514273  +18 
+ Misses   2515 2510   -5
```


| [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
 | `93.25% <100%> (-0.05%)` | :arrow_down: |
| 
[src/router\_core/route\_control.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX2NvbnRyb2wuYw==)
 | `95.9% <100%> (ø)` | :arrow_up: |
| 
[src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j)
 | `94.44% <100%> (ø)` | :arrow_up: |
| 
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
 | `95.24% <100%> (+0.23%)` | :arrow_up: |
| 
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
 | `93.04% <100%> (-0.28%)` | :arrow_down: |
| 
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==)
 | `88.69% <100%> (+0.39%)` | :arrow_up: |
| 
[src/router\_config.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb25maWcuYw==)
 | `96.32% <100%> (+0.04%)` | :arrow_up: |
| 
[src/router\_core/agent\_config\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19hZGRyZXNzLmM=)
 | `78.11% <60%> (-0.72%)` | :arrow_down: |
| 
[src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==)
 | `94.64% <0%> (-1.79%)` | :arrow_down: |
| ... and [7 
more](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree-more)
 | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=footer).
 Last update 
[9c5666f...bb4f312](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> support prioritized addresses
> -
>
> Key: DISPATCH-1139
> URL: https://issues.apache.org/jira/browse/DISPATCH-1139
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node, Routing Engine, Tests
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Support a new field in the address descriptor in router configuration files 
> that will assign a priority to the address.
> Any message that does not have an intrinsic priority already assigned will 
> inherit the priority of the address to which it is sent.  If no priority is 
> explicitly assigned to an address, then it will be assigned the default 
> priority.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For 

[GitHub] qpid-dispatch issue #392: DISPATCH-1139 : address priority support and test

2018-10-18 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/qpid-dispatch/pull/392
  
# 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=h1) 
Report
> Merging 
[#392](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/9c5666f6d1e36979d6d4b3e657c5c5246ffbf5df?src=pr=desc)
 will **increase** coverage by `0.04%`.
> The diff coverage is `85.71%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/392/graphs/tree.svg?width=650=rk2Cgd27pP=150=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #392  +/-   ##
==
+ Coverage  85%   85.04%   +0.04% 
==
  Files  76   76  
  Lines   1677016783  +13 
==
+ Hits1425514273  +18 
+ Misses   2515 2510   -5
```


| [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
 | `93.25% <100%> (-0.05%)` | :arrow_down: |
| 
[src/router\_core/route\_control.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX2NvbnRyb2wuYw==)
 | `95.9% <100%> (ø)` | :arrow_up: |
| 
[src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j)
 | `94.44% <100%> (ø)` | :arrow_up: |
| 
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
 | `95.24% <100%> (+0.23%)` | :arrow_up: |
| 
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
 | `93.04% <100%> (-0.28%)` | :arrow_down: |
| 
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==)
 | `88.69% <100%> (+0.39%)` | :arrow_up: |
| 
[src/router\_config.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb25maWcuYw==)
 | `96.32% <100%> (+0.04%)` | :arrow_up: |
| 
[src/router\_core/agent\_config\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19hZGRyZXNzLmM=)
 | `78.11% <60%> (-0.72%)` | :arrow_down: |
| 
[src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==)
 | `94.64% <0%> (-1.79%)` | :arrow_down: |
| ... and [7 
more](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr=tree-more)
 | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=footer).
 Last update 
[9c5666f...bb4f312](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1139) support prioritized addresses

2018-10-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655385#comment-16655385
 ] 

ASF GitHub Bot commented on DISPATCH-1139:
--

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/392

DISPATCH-1139 : address priority support and test

Code that implements address-priority. Also changes things so that address 
priority takes precedence if present, otherwise defaults to message priority -- 
and messages now always have priority, defaulting to 4 if not specified. (Same 
as Proton default.)
Also a python test that tests both message and address priority.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-1139-B

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #392


commit bb4f3121989cb4b91d4e364287868da1594f3acf
Author: Michael Goulish 
Date:   2018-10-18T15:07:45Z

DISPATCH-1139 : address priority support and test




> support prioritized addresses
> -
>
> Key: DISPATCH-1139
> URL: https://issues.apache.org/jira/browse/DISPATCH-1139
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node, Routing Engine, Tests
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Support a new field in the address descriptor in router configuration files 
> that will assign a priority to the address.
> Any message that does not have an intrinsic priority already assigned will 
> inherit the priority of the address to which it is sent.  If no priority is 
> explicitly assigned to an address, then it will be assigned the default 
> priority.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #392: DISPATCH-1139 : address priority support an...

2018-10-18 Thread mgoulish
GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/392

DISPATCH-1139 : address priority support and test

Code that implements address-priority. Also changes things so that address 
priority takes precedence if present, otherwise defaults to message priority -- 
and messages now always have priority, defaulting to 4 if not specified. (Same 
as Proton default.)
Also a python test that tests both message and address priority.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-1139-B

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #392


commit bb4f3121989cb4b91d4e364287868da1594f3acf
Author: Michael Goulish 
Date:   2018-10-18T15:07:45Z

DISPATCH-1139 : address priority support and test




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1147) Expose address priority

2018-10-18 Thread Ernest Allen (JIRA)
Ernest Allen created DISPATCH-1147:
--

 Summary: Expose address priority
 Key: DISPATCH-1147
 URL: https://issues.apache.org/jira/browse/DISPATCH-1147
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Management Agent, Tests, Tools
Affects Versions: 1.4.0
Reporter: Ernest Allen
Assignee: Ernest Allen


Expose the new address priority to management calls.

Modify qdstat -a to show priority

Add a test to ensure qdstat -a outputs address priority



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-420) Avoid overhead of missing thread singalling on inbound message enqueues

2018-10-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655288#comment-16655288
 ] 

ASF subversion and git services commented on QPIDJMS-420:
-

Commit add459362f3ce3544167c3bdb7ac9d9d2c7a6c0c in qpid-jms's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=add4593 ]

QPIDJMS-420: add a try-finally to ensure the decrement occurs


> Avoid overhead of missing thread singalling on inbound message enqueues
> ---
>
> Key: QPIDJMS-420
> URL: https://issues.apache.org/jira/browse/QPIDJMS-420
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.37.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
>Priority: Minor
> Fix For: 0.38.0
>
>
> Avoid the cost of attempting to signal waiters on the prefetch queue when 
> none are present to reduce time under lock when adding incoming messages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org