[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[
https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657336#comment-16657336
]
ASF GitHub Bot commented on DISPATCH-1143:
--
Github user kgiusti commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/393#discussion_r226763750
--- Diff: python/qpid_dispatch_internal/management/agent.py ---
@@ -417,6 +417,13 @@ def create(self):
def __str__(self):
return super(LinkRouteEntity, self).__str__().replace("Entity(",
"LinkRouteEntity(")
+class RouterConnectionAttachsubscriptionEntity(EntityAdapter):
--- End diff --
Ya know, the default error message isn't too bad:
2018-10-19 15:37:07.199514 -0400 ERROR (error) Python: Exception: Cannot
load configuration file X.conf: No such entity type
'org.apache.qpid.dispatch.attachSubscription'
2018-10-19 15:37:07.199789 -0400 ERROR (error) Traceback (most recent call
last):
File
"/home/kgiusti/work/dispatch/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
line 169, in configure_dispatch
config = Config(filename)
File
"/home/kgiusti/work/dispatch/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
line 56, in __init__
% (filename, e))
Exception: Cannot load configuration file X.conf: No such entity type
'org.apache.qpid.dispatch.attachSubscription'
2018-10-19 15:37:07.199805 -0400 MAIN (critical) Router start-up failed:
Python: Exception: Cannot load configuration file X.conf: No such entity type
'org.apache.qpid.dispatch.attachSubscription'
qdrouterd: Python: Exception: Cannot load configuration file X.conf: No
such entity type 'org.apache.qpid.dispatch.attachSubscription'
A little better than a generic parse error.
> Connection-scoped link routes
> -
>
> Key: DISPATCH-1143
> URL: https://issues.apache.org/jira/browse/DISPATCH-1143
> Project: Qpid Dispatch
> Issue Type: New Feature
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> A new type of link route that exists only as long as the connection over
> which it has been created remains open. The new link route is automatically
> bound to that connection (cannot specify a different container-id nor
> connection). Once the connection closes the link route's configuration
> vanishes.
> More detail TBA
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #393: DISPATCH-1143: New feature: connection-scop...
Github user kgiusti commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/393#discussion_r226763750
--- Diff: python/qpid_dispatch_internal/management/agent.py ---
@@ -417,6 +417,13 @@ def create(self):
def __str__(self):
return super(LinkRouteEntity, self).__str__().replace("Entity(",
"LinkRouteEntity(")
+class RouterConnectionAttachsubscriptionEntity(EntityAdapter):
--- End diff --
Ya know, the default error message isn't too bad:
2018-10-19 15:37:07.199514 -0400 ERROR (error) Python: Exception: Cannot
load configuration file X.conf: No such entity type
'org.apache.qpid.dispatch.attachSubscription'
2018-10-19 15:37:07.199789 -0400 ERROR (error) Traceback (most recent call
last):
File
"/home/kgiusti/work/dispatch/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
line 169, in configure_dispatch
config = Config(filename)
File
"/home/kgiusti/work/dispatch/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
line 56, in __init__
% (filename, e))
Exception: Cannot load configuration file X.conf: No such entity type
'org.apache.qpid.dispatch.attachSubscription'
2018-10-19 15:37:07.199805 -0400 MAIN (critical) Router start-up failed:
Python: Exception: Cannot load configuration file X.conf: No such entity type
'org.apache.qpid.dispatch.attachSubscription'
qdrouterd: Python: Exception: Cannot load configuration file X.conf: No
such entity type 'org.apache.qpid.dispatch.attachSubscription'
A little better than a generic parse error.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[ https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657254#comment-16657254 ] ASF GitHub Bot commented on DISPATCH-1143: -- Github user kgiusti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/393#discussion_r226743048 --- Diff: include/qpid/dispatch/router_core.h --- @@ -721,10 +723,11 @@ typedef struct qdr_query_t qdr_query_t; * @param name The name supplied for the entity * @param in_body The body of the request message * @param out_body A composed field for the body of the response message + * @param in_conn The identity of the connection over which the mgmt message arrived (0 if config file) */ void qdr_manage_create(qdr_core_t *core, void *context, qd_router_entity_type_t type, qd_iterator_t *name, qd_parsed_field_t *in_body, qd_composed_field_t *out_body, - qd_buffer_list_t body_buffers); + qd_buffer_list_t body_buffers, uint64_t in_conn); --- End diff -- I think that may introduce a timing window. Is it possible that the connection can be removed before the core gets the processing the create request? > Connection-scoped link routes > - > > Key: DISPATCH-1143 > URL: https://issues.apache.org/jira/browse/DISPATCH-1143 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > A new type of link route that exists only as long as the connection over > which it has been created remains open. The new link route is automatically > bound to that connection (cannot specify a different container-id nor > connection). Once the connection closes the link route's configuration > vanishes. > More detail TBA -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #393: DISPATCH-1143: New feature: connection-scop...
Github user kgiusti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/393#discussion_r226743048 --- Diff: include/qpid/dispatch/router_core.h --- @@ -721,10 +723,11 @@ typedef struct qdr_query_t qdr_query_t; * @param name The name supplied for the entity * @param in_body The body of the request message * @param out_body A composed field for the body of the response message + * @param in_conn The identity of the connection over which the mgmt message arrived (0 if config file) */ void qdr_manage_create(qdr_core_t *core, void *context, qd_router_entity_type_t type, qd_iterator_t *name, qd_parsed_field_t *in_body, qd_composed_field_t *out_body, - qd_buffer_list_t body_buffers); + qd_buffer_list_t body_buffers, uint64_t in_conn); --- End diff -- I think that may introduce a timing window. Is it possible that the connection can be removed before the core gets the processing the create request? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[ https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657253#comment-16657253 ] ASF GitHub Bot commented on DISPATCH-1143: -- Github user kgiusti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/393#discussion_r226742384 --- Diff: python/qpid_dispatch_internal/management/config.py --- @@ -67,6 +67,7 @@ def transform_sections(sections): if s[0] == "autoLink": s[0] = "router.config.autoLink" if s[0] == "exchange": s[0] = "router.config.exchange" if s[0] == "binding": s[0] = "router.config.binding" +if s[0] == "attachSubscription": s[0] = "router.connection.attachSubscription" --- End diff -- See previous. > Connection-scoped link routes > - > > Key: DISPATCH-1143 > URL: https://issues.apache.org/jira/browse/DISPATCH-1143 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > A new type of link route that exists only as long as the connection over > which it has been created remains open. The new link route is automatically > bound to that connection (cannot specify a different container-id nor > connection). Once the connection closes the link route's configuration > vanishes. > More detail TBA -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[
https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657252#comment-16657252
]
ASF GitHub Bot commented on DISPATCH-1143:
--
Github user kgiusti commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/393#discussion_r226742200
--- Diff: python/qpid_dispatch_internal/management/agent.py ---
@@ -417,6 +417,13 @@ def create(self):
def __str__(self):
return super(LinkRouteEntity, self).__str__().replace("Entity(",
"LinkRouteEntity(")
+class RouterConnectionAttachsubscriptionEntity(EntityAdapter):
--- End diff --
Error reporting. Without it the router fails with a generic parse error.
With this we get:
qdrouterd: Python: CError: Configuration: attachSubscription cannot be
created via the configuration file
I'm going to have to re-work this on changing the name in any case. I can
pull it if you want.
> Connection-scoped link routes
> -
>
> Key: DISPATCH-1143
> URL: https://issues.apache.org/jira/browse/DISPATCH-1143
> Project: Qpid Dispatch
> Issue Type: New Feature
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> A new type of link route that exists only as long as the connection over
> which it has been created remains open. The new link route is automatically
> bound to that connection (cannot specify a different container-id nor
> connection). Once the connection closes the link route's configuration
> vanishes.
> More detail TBA
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #393: DISPATCH-1143: New feature: connection-scop...
Github user kgiusti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/393#discussion_r226742384 --- Diff: python/qpid_dispatch_internal/management/config.py --- @@ -67,6 +67,7 @@ def transform_sections(sections): if s[0] == "autoLink": s[0] = "router.config.autoLink" if s[0] == "exchange": s[0] = "router.config.exchange" if s[0] == "binding": s[0] = "router.config.binding" +if s[0] == "attachSubscription": s[0] = "router.connection.attachSubscription" --- End diff -- See previous. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #393: DISPATCH-1143: New feature: connection-scop...
Github user kgiusti commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/393#discussion_r226742200
--- Diff: python/qpid_dispatch_internal/management/agent.py ---
@@ -417,6 +417,13 @@ def create(self):
def __str__(self):
return super(LinkRouteEntity, self).__str__().replace("Entity(",
"LinkRouteEntity(")
+class RouterConnectionAttachsubscriptionEntity(EntityAdapter):
--- End diff --
Error reporting. Without it the router fails with a generic parse error.
With this we get:
qdrouterd: Python: CError: Configuration: attachSubscription cannot be
created via the configuration file
I'm going to have to re-work this on changing the name in any case. I can
pull it if you want.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPIDJMS-421) Improve JMS MessageProducer performance by caching Message Annotation encodings
[ https://issues.apache.org/jira/browse/QPIDJMS-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish resolved QPIDJMS-421. -- Resolution: Fixed > Improve JMS MessageProducer performance by caching Message Annotation > encodings > --- > > Key: QPIDJMS-421 > URL: https://issues.apache.org/jira/browse/QPIDJMS-421 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.37.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 0.38.0 > > > Each message sent by a producer has a set of type values for Destination and > Message types added to the MessageAnnotation section of the AMQP message. We > can improve send performance by caching the encoded bytes of these > MessageAnnotations sections and write that instead of performing a fresh > encode on each message. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[ https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657230#comment-16657230 ] ASF GitHub Bot commented on DISPATCH-1143: -- Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/393#discussion_r226733245 --- Diff: include/qpid/dispatch/router_core.h --- @@ -721,10 +723,11 @@ typedef struct qdr_query_t qdr_query_t; * @param name The name supplied for the entity * @param in_body The body of the request message * @param out_body A composed field for the body of the response message + * @param in_conn The identity of the connection over which the mgmt message arrived (0 if config file) */ void qdr_manage_create(qdr_core_t *core, void *context, qd_router_entity_type_t type, qd_iterator_t *name, qd_parsed_field_t *in_body, qd_composed_field_t *out_body, - qd_buffer_list_t body_buffers); + qd_buffer_list_t body_buffers, uint64_t in_conn); --- End diff -- Is it possible to use the qdr_connection_t* here instead of an ID that's going to have to be searched for later? > Connection-scoped link routes > - > > Key: DISPATCH-1143 > URL: https://issues.apache.org/jira/browse/DISPATCH-1143 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > A new type of link route that exists only as long as the connection over > which it has been created remains open. The new link route is automatically > bound to that connection (cannot specify a different container-id nor > connection). Once the connection closes the link route's configuration > vanishes. > More detail TBA -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[ https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657232#comment-16657232 ] ASF GitHub Bot commented on DISPATCH-1143: -- Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/393#discussion_r226733939 --- Diff: python/qpid_dispatch_internal/management/config.py --- @@ -67,6 +67,7 @@ def transform_sections(sections): if s[0] == "autoLink": s[0] = "router.config.autoLink" if s[0] == "exchange": s[0] = "router.config.exchange" if s[0] == "binding": s[0] = "router.config.binding" +if s[0] == "attachSubscription": s[0] = "router.connection.attachSubscription" --- End diff -- Why go to all the trouble of adding support for configuration of a non-configurable entity? > Connection-scoped link routes > - > > Key: DISPATCH-1143 > URL: https://issues.apache.org/jira/browse/DISPATCH-1143 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > A new type of link route that exists only as long as the connection over > which it has been created remains open. The new link route is automatically > bound to that connection (cannot specify a different container-id nor > connection). Once the connection closes the link route's configuration > vanishes. > More detail TBA -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[
https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657231#comment-16657231
]
ASF GitHub Bot commented on DISPATCH-1143:
--
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/393#discussion_r226733581
--- Diff: python/qpid_dispatch_internal/management/agent.py ---
@@ -417,6 +417,13 @@ def create(self):
def __str__(self):
return super(LinkRouteEntity, self).__str__().replace("Entity(",
"LinkRouteEntity(")
+class RouterConnectionAttachsubscriptionEntity(EntityAdapter):
--- End diff --
Why is this even mentioned in the Python management code? It can't be
configured and management commands are handled in the router core.
> Connection-scoped link routes
> -
>
> Key: DISPATCH-1143
> URL: https://issues.apache.org/jira/browse/DISPATCH-1143
> Project: Qpid Dispatch
> Issue Type: New Feature
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> A new type of link route that exists only as long as the connection over
> which it has been created remains open. The new link route is automatically
> bound to that connection (cannot specify a different container-id nor
> connection). Once the connection closes the link route's configuration
> vanishes.
> More detail TBA
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #393: DISPATCH-1143: New feature: connection-scop...
Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/393#discussion_r226733245 --- Diff: include/qpid/dispatch/router_core.h --- @@ -721,10 +723,11 @@ typedef struct qdr_query_t qdr_query_t; * @param name The name supplied for the entity * @param in_body The body of the request message * @param out_body A composed field for the body of the response message + * @param in_conn The identity of the connection over which the mgmt message arrived (0 if config file) */ void qdr_manage_create(qdr_core_t *core, void *context, qd_router_entity_type_t type, qd_iterator_t *name, qd_parsed_field_t *in_body, qd_composed_field_t *out_body, - qd_buffer_list_t body_buffers); + qd_buffer_list_t body_buffers, uint64_t in_conn); --- End diff -- Is it possible to use the qdr_connection_t* here instead of an ID that's going to have to be searched for later? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #393: DISPATCH-1143: New feature: connection-scop...
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/393#discussion_r226733581
--- Diff: python/qpid_dispatch_internal/management/agent.py ---
@@ -417,6 +417,13 @@ def create(self):
def __str__(self):
return super(LinkRouteEntity, self).__str__().replace("Entity(",
"LinkRouteEntity(")
+class RouterConnectionAttachsubscriptionEntity(EntityAdapter):
--- End diff --
Why is this even mentioned in the Python management code? It can't be
configured and management commands are handled in the router core.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #393: DISPATCH-1143: New feature: connection-scop...
Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/393#discussion_r226733939 --- Diff: python/qpid_dispatch_internal/management/config.py --- @@ -67,6 +67,7 @@ def transform_sections(sections): if s[0] == "autoLink": s[0] = "router.config.autoLink" if s[0] == "exchange": s[0] = "router.config.exchange" if s[0] == "binding": s[0] = "router.config.binding" +if s[0] == "attachSubscription": s[0] = "router.connection.attachSubscription" --- End diff -- Why go to all the trouble of adding support for configuration of a non-configurable entity? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-421) Improve JMS MessageProducer performance by caching Message Annotation encodings
[ https://issues.apache.org/jira/browse/QPIDJMS-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657224#comment-16657224 ] ASF subversion and git services commented on QPIDJMS-421: - Commit 0089ed185c8e98c3a05e5724becf8091076134b8 in qpid-jms's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=0089ed1 ] QPIDJMS-421 Cache common message annotation encodings for sends Use a cache to store the msot commonly used message annotations that are applied to outbound messages in order to reduce overhead of sends that would otherwise be encoding the same annotations map each time. Only when additional JMS features like scheduled delivery time are used will we need to perform a full encode on the MessageAnnotations section of the outbound message. > Improve JMS MessageProducer performance by caching Message Annotation > encodings > --- > > Key: QPIDJMS-421 > URL: https://issues.apache.org/jira/browse/QPIDJMS-421 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.37.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 0.38.0 > > > Each message sent by a producer has a set of type values for Destination and > Message types added to the MessageAnnotation section of the AMQP message. We > can improve send performance by caching the encoded bytes of these > MessageAnnotations sections and write that instead of performing a fresh > encode on each message. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-421) Improve JMS MessageProducer performance by caching Message Annotation encodings
Timothy Bish created QPIDJMS-421: Summary: Improve JMS MessageProducer performance by caching Message Annotation encodings Key: QPIDJMS-421 URL: https://issues.apache.org/jira/browse/QPIDJMS-421 Project: Qpid JMS Issue Type: Improvement Components: qpid-jms-client Affects Versions: 0.37.0 Reporter: Timothy Bish Assignee: Timothy Bish Fix For: 0.38.0 Each message sent by a producer has a set of type values for Destination and Message types added to the MessageAnnotation section of the AMQP message. We can improve send performance by caching the encoded bytes of these MessageAnnotations sections and write that instead of performing a fresh encode on each message. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[ https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657092#comment-16657092 ] ASF GitHub Bot commented on DISPATCH-1143: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/393 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@7baa254`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `86.85%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #393 +/- ## = Coverage ? 85.08% = Files ? 77 Lines ?17028 Branches ?0 = Hits ?14488 Misses? 2540 Partials ?0 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `86.51% <100%> (ø)` | | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.99% <100%> (ø)` | | | [src/router\_core/route\_control.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX2NvbnRyb2wuYw==) | `96.47% <100%> (ø)` | | | [src/router\_core/agent\_config\_link\_route.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19saW5rX3JvdXRlLmM=) | `86.74% <100%> (ø)` | | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `77.59% <100%> (ø)` | | | [src/router\_config.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb25maWcuYw==) | `96.37% <100%> (ø)` | | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `93.33% <100%> (ø)` | | | [src/router\_core/agent\_attach\_subscription.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2F0dGFjaF9zdWJzY3JpcHRpb24uYw==) | `81.87% <81.87%> (ø)` | | | [src/router\_core/management\_agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21hbmFnZW1lbnRfYWdlbnQuYw==) | `92.61% <84.61%> (ø)` | | | [src/router\_core/agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50LmM=) | `78.9% <86.66%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=footer). Last update [7baa254...ead83d3](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Connection-scoped link routes > - > > Key: DISPATCH-1143 > URL: https://issues.apache.org/jira/browse/DISPATCH-1143 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > A new type of link route that exists only as long as the connection over > which it has been created remains open. The new link route is automatically > bound to that connection (cannot specify a different container-id nor > connection). Once the connection closes the link route's configuration > vanishes. > More detail TBA -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apac
[GitHub] qpid-dispatch issue #393: DISPATCH-1143: New feature: connection-scoped link...
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/393 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@7baa254`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `86.85%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #393 +/- ## = Coverage ? 85.08% = Files ? 77 Lines ?17028 Branches ?0 = Hits ?14488 Misses? 2540 Partials ?0 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=tree) | Coverage Π| | |---|---|---| | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `86.51% <100%> (ø)` | | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.99% <100%> (ø)` | | | [src/router\_core/route\_control.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX2NvbnRyb2wuYw==) | `96.47% <100%> (ø)` | | | [src/router\_core/agent\_config\_link\_route.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19saW5rX3JvdXRlLmM=) | `86.74% <100%> (ø)` | | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `77.59% <100%> (ø)` | | | [src/router\_config.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb25maWcuYw==) | `96.37% <100%> (ø)` | | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `93.33% <100%> (ø)` | | | [src/router\_core/agent\_attach\_subscription.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2F0dGFjaF9zdWJzY3JpcHRpb24uYw==) | `81.87% <81.87%> (ø)` | | | [src/router\_core/management\_agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21hbmFnZW1lbnRfYWdlbnQuYw==) | `92.61% <84.61%> (ø)` | | | [src/router\_core/agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/393/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50LmM=) | `78.9% <86.66%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=footer). Last update [7baa254...ead83d3](https://codecov.io/gh/apache/qpid-dispatch/pull/393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1139) support prioritized addresses
[ https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657086#comment-16657086 ] ASF subversion and git services commented on DISPATCH-1139: --- Commit 2519b1ecabf9d03b4ef3caf86813726341d9cb7c in qpid-dispatch's branch refs/heads/master from Kenneth Giusti [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=2519b1e ] DISPATCH-1139: minor test fix - xrange() removed in python3+ > support prioritized addresses > - > > Key: DISPATCH-1139 > URL: https://issues.apache.org/jira/browse/DISPATCH-1139 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node, Routing Engine, Tests >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > Support a new field in the address descriptor in router configuration files > that will assign a priority to the address. > Any message that does not have an intrinsic priority already assigned will > inherit the priority of the address to which it is sent. If no priority is > explicitly assigned to an address, then it will be assigned the default > priority. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1143) Connection-scoped link routes
[ https://issues.apache.org/jira/browse/DISPATCH-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657071#comment-16657071 ] ASF GitHub Bot commented on DISPATCH-1143: -- GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/393 DISPATCH-1143: New feature: connection-scoped link routes Haven't changed the name yet - still attachSubscription. Will do that with a separate patch once the link route replication stuff is done. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-1143 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/393.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #393 commit ead83d3a7ff9eb0c71624fd636e19cacacee6153 Author: Kenneth Giusti Date: 2018-10-08T20:06:45Z DISPATCH-1143: New feature: connection-scoped link routes > Connection-scoped link routes > - > > Key: DISPATCH-1143 > URL: https://issues.apache.org/jira/browse/DISPATCH-1143 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > A new type of link route that exists only as long as the connection over > which it has been created remains open. The new link route is automatically > bound to that connection (cannot specify a different container-id nor > connection). Once the connection closes the link route's configuration > vanishes. > More detail TBA -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #393: DISPATCH-1143: New feature: connection-scop...
GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/393 DISPATCH-1143: New feature: connection-scoped link routes Haven't changed the name yet - still attachSubscription. Will do that with a separate patch once the link route replication stuff is done. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-1143 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/393.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #393 commit ead83d3a7ff9eb0c71624fd636e19cacacee6153 Author: Kenneth Giusti Date: 2018-10-08T20:06:45Z DISPATCH-1143: New feature: connection-scoped link routes --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1149) authz plugin can no longer override conf file policy
[ https://issues.apache.org/jira/browse/DISPATCH-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1149: Fix Version/s: (was: 1.5.0) 1.4.1 > authz plugin can no longer override conf file policy > > > Key: DISPATCH-1149 > URL: https://issues.apache.org/jira/browse/DISPATCH-1149 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.1 > > > If enabled, the authz plugin should be allowed to defined the valid sources > and targets for a given connection and this should take precedence over > anything in the policy file (which may still be used for quotas). > This was (I believe) an unintentional regression by > https://github.com/apache/qpid-dispatch/commit/dc981ecc6cf31d8c605e84703a589553281281c2#diff-adc0a0fef2880417cb24cb072363fc29 > which reverted the necessary change made in > https://github.com/apache/qpid-dispatch/commit/eed8bb65497b23e512072f5ea9fefd8ed73921ef#diff-adc0a0fef2880417cb24cb072363fc29 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1148) auth plugin should indicate version in open properties
[ https://issues.apache.org/jira/browse/DISPATCH-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1148: Fix Version/s: (was: 1.5.0) 1.4.1 > auth plugin should indicate version in open properties > -- > > Key: DISPATCH-1148 > URL: https://issues.apache.org/jira/browse/DISPATCH-1148 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
