[jira] [Commented] (DISPATCH-1160) Add edge address tracking module to interior routers which will inform edges of mobile address receiver changes
[ https://issues.apache.org/jira/browse/DISPATCH-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669303#comment-16669303 ] ASF GitHub Bot commented on DISPATCH-1160: -- GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/410 DISPATCH-1160 - Added edge address tracking module to interior router You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch EDGE-ADDR-TRACKING Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/410.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #410 commit cf5f9b7f958fa88ca747b4ec29a1cf2b0932aa33 Author: Ganesh Murthy Date: 2018-10-18T15:46:42Z DISPATCH-1160 - Added edge address tracking module to interior router > Add edge address tracking module to interior routers which will inform edges > of mobile address receiver changes > --- > > Key: DISPATCH-1160 > URL: https://issues.apache.org/jira/browse/DISPATCH-1160 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.4.1 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1959) [c,cpp] API additions to simplify reconnect
[ https://issues.apache.org/jira/browse/PROTON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved PROTON-1959. - Resolution: Fixed > [c,cpp] API additions to simplify reconnect > --- > > Key: PROTON-1959 > URL: https://issues.apache.org/jira/browse/PROTON-1959 > Project: Qpid Proton > Issue Type: Improvement >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > Add some minor API extensions to make it easier to tell if a connection is > reconnecting, and to set up one-time events that only happen on the initial > connect. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #410: DISPATCH-1160 - Added edge address tracking...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/410 DISPATCH-1160 - Added edge address tracking module to interior router You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch EDGE-ADDR-TRACKING Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/410.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #410 commit cf5f9b7f958fa88ca747b4ec29a1cf2b0932aa33 Author: Ganesh Murthy Date: 2018-10-18T15:46:42Z DISPATCH-1160 - Added edge address tracking module to interior router --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1959) [c,cpp] API additions to simplify reconnect
[ https://issues.apache.org/jira/browse/PROTON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669297#comment-16669297 ] ASF subversion and git services commented on PROTON-1959: - Commit 77ddf4b03afb89a21e29698fcd90117e4d63b314 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=77ddf4b ] PROTON-1959: [cpp] Zero pn_listener_t* in proton::listener::stop() Pointer becomes invalid sometime after stop() so must not be used again. > [c,cpp] API additions to simplify reconnect > --- > > Key: PROTON-1959 > URL: https://issues.apache.org/jira/browse/PROTON-1959 > Project: Qpid Proton > Issue Type: Improvement >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > Add some minor API extensions to make it easier to tell if a connection is > reconnecting, and to set up one-time events that only happen on the initial > connect. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1959) [c,cpp] API additions to simplify reconnect
[ https://issues.apache.org/jira/browse/PROTON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669295#comment-16669295 ] ASF subversion and git services commented on PROTON-1959: - Commit 6e9bbe99326ad3e674f8b9701b3bd07c46b744ef in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6e9bbe9 ] PROTON-1959: [cpp] Update simple_send example to re-send on reconnect > [c,cpp] API additions to simplify reconnect > --- > > Key: PROTON-1959 > URL: https://issues.apache.org/jira/browse/PROTON-1959 > Project: Qpid Proton > Issue Type: Improvement >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > Add some minor API extensions to make it easier to tell if a connection is > reconnecting, and to set up one-time events that only happen on the initial > connect. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1959) [c,cpp] API additions to simplify reconnect
[ https://issues.apache.org/jira/browse/PROTON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669296#comment-16669296 ] ASF subversion and git services commented on PROTON-1959: - Commit 84b0129d636841d3b1e7f4cd76eb84b8d00163bf in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=84b0129 ] PROTON-1959: [c epoll] Fix crash in some reconnect scenarios. Proactor should release driver->collector *not* pn_connection_collector() as the driver always keeps a valid collector pointer, but the connection may be NULL if it has been released for reconnect. > [c,cpp] API additions to simplify reconnect > --- > > Key: PROTON-1959 > URL: https://issues.apache.org/jira/browse/PROTON-1959 > Project: Qpid Proton > Issue Type: Improvement >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > Add some minor API extensions to make it easier to tell if a connection is > reconnecting, and to set up one-time events that only happen on the initial > connect. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1959) [c,cpp] API additions to simplify reconnect
[ https://issues.apache.org/jira/browse/PROTON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669298#comment-16669298 ] ASF subversion and git services commented on PROTON-1959: - Commit f53c7683d7e903634b53db30d1f401006b43015a in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f53c768 ] PROTON-1959: [cpp] API additions to simplify reconnect messaging_handler::on_connection_start() - initial, exactly once event messaging_handler::on_connection_reconnecting() - disconnected with auto-reconnect pending bool connection::reconnected() - connection has been auto-reconnected Added connection life-cycle doc to the messaging_handler class API doc. > [c,cpp] API additions to simplify reconnect > --- > > Key: PROTON-1959 > URL: https://issues.apache.org/jira/browse/PROTON-1959 > Project: Qpid Proton > Issue Type: Improvement >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > Add some minor API extensions to make it easier to tell if a connection is > reconnecting, and to set up one-time events that only happen on the initial > connect. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1161) Handle edge routers in the console
Ernest Allen created DISPATCH-1161: -- Summary: Handle edge routers in the console Key: DISPATCH-1161 URL: https://issues.apache.org/jira/browse/DISPATCH-1161 Project: Qpid Dispatch Issue Type: Improvement Components: Console Affects Versions: 1.4.1 Reporter: Ernest Allen Assignee: Ernest Allen Show edge routers on the console's topology page. * Show them on the diagram in a unique color or size * Add them to the legend * Consolidate mulitple edge routers attached to a router as a group icon * Whem mouseover link between router and edge routers, show traffic stats for busiest edge routers -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-420) Improve performance of MessageConsumer processing
[ https://issues.apache.org/jira/browse/QPIDJMS-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669245#comment-16669245 ] ASF subversion and git services commented on QPIDJMS-420: - Commit 24d03437fb1695b2096989c3561007312d4169ee in qpid-jms's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=24d0343 ] QPIDJMS-420 Use local tracking in AmqpConsumer for prefetch refill Track the number of message that are currently in the prefetch buffer using local counters that mesh well with the already added delivered message counts to reduce access to synchronized code in the message queue. Reduce code paths where a message settlement might be missed or credit not replenished on error. > Improve performance of MessageConsumer processing > - > > Key: QPIDJMS-420 > URL: https://issues.apache.org/jira/browse/QPIDJMS-420 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.37.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Minor > Fix For: 0.38.0 > > > Refactor some of the code paths that handling inbound message processing and > eventually queue or deliver inbound messages to the MessageConsumer. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1160) Add edge address tracking module to interior routers which will inform edges of mobile address receiver changes
[ https://issues.apache.org/jira/browse/DISPATCH-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1160: Environment: (was: Create a interior router module called edge address tracking. This module will allow a receiver link (Edge Address Tracking Link - EATL) from interior to edge to be created on hard coded address _$qd.edge_addr_tracking When receivers are added/removed to a mobile address, this module will inform the edge router if necessary via the EATL allowing the edge router to act accordingly. This module will act only on mobile addresses.) > Add edge address tracking module to interior routers which will inform edges > of mobile address receiver changes > --- > > Key: DISPATCH-1160 > URL: https://issues.apache.org/jira/browse/DISPATCH-1160 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.4.1 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1160) Add edge address tracking module to interior routers which will inform edges of mobile address receiver changes
[ https://issues.apache.org/jira/browse/DISPATCH-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669139#comment-16669139 ] Ganesh Murthy commented on DISPATCH-1160: - Create a interior router module called edge address tracking. This module will allow a receiver link (Edge Address Tracking Link - EATL) from interior to edge to be created on hard coded address _$qd.edge_addr_tracking When receivers are added/removed to a mobile address, this module will inform the edge router if necessary via the EATL allowing the edge router to act accordingly. This module will act only on mobile addresses. > Add edge address tracking module to interior routers which will inform edges > of mobile address receiver changes > --- > > Key: DISPATCH-1160 > URL: https://issues.apache.org/jira/browse/DISPATCH-1160 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.4.1 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1160) Add edge address tracking module to interior routers which will inform edges of mobile address receiver changes
Ganesh Murthy created DISPATCH-1160: --- Summary: Add edge address tracking module to interior routers which will inform edges of mobile address receiver changes Key: DISPATCH-1160 URL: https://issues.apache.org/jira/browse/DISPATCH-1160 Project: Qpid Dispatch Issue Type: Improvement Affects Versions: 1.4.1 Environment: Create a interior router module called edge address tracking. This module will allow a receiver link (Edge Address Tracking Link - EATL) from interior to edge to be created on hard coded address _$qd.edge_addr_tracking When receivers are added/removed to a mobile address, this module will inform the edge router if necessary via the EATL allowing the edge router to act accordingly. This module will act only on mobile addresses. Reporter: Ganesh Murthy Assignee: Ganesh Murthy Fix For: 1.5.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1159) Remove the term "uplink" from the edge router - It's confusing
[ https://issues.apache.org/jira/browse/DISPATCH-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669116#comment-16669116 ] ASF subversion and git services commented on DISPATCH-1159: --- Commit 413d727b6e1772d87a23f88261cdced4940d33ee in qpid-dispatch's branch refs/heads/master from [~tr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=413d727 ] DISPATCH-1159 - Removed the term "uplink" from the edge router implementation. > Remove the term "uplink" from the edge router - It's confusing > -- > > Key: DISPATCH-1159 > URL: https://issues.apache.org/jira/browse/DISPATCH-1159 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.5.0 > > > Renamed "edge_uplink" to "edge_connection". > Changed "edge_uplink" connection role to "edge". > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1159) Remove the term "uplink" from the edge router - It's confusing
[ https://issues.apache.org/jira/browse/DISPATCH-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1159. Resolution: Fixed > Remove the term "uplink" from the edge router - It's confusing > -- > > Key: DISPATCH-1159 > URL: https://issues.apache.org/jira/browse/DISPATCH-1159 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.5.0 > > > Renamed "edge_uplink" to "edge_connection". > Changed "edge_uplink" connection role to "edge". > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1159) Remove the term "uplink" from the edge router - It's confusing
Ted Ross created DISPATCH-1159: -- Summary: Remove the term "uplink" from the edge router - It's confusing Key: DISPATCH-1159 URL: https://issues.apache.org/jira/browse/DISPATCH-1159 Project: Qpid Dispatch Issue Type: Improvement Components: Router Node Reporter: Ted Ross Assignee: Ted Ross Fix For: 1.5.0 Renamed "edge_uplink" to "edge_connection". Changed "edge_uplink" connection role to "edge". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8254) [Broker-J] Illegal ascii characters are used in keystore passwords
[
https://issues.apache.org/jira/browse/QPID-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669019#comment-16669019
]
ASF subversion and git services commented on QPID-8254:
---
Commit cc4821e344a0d23e71a4e4fcc8caf6cd75827c1a in qpid-broker-j's branch
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=cc4821e ]
QPID-8254: [Broker-J] Stop using illegal ascii characters in java keystore
passwords
(cherry picked from commit 16b5592f12ccb841e432f5e16c4851c21ccc66cf)
> [Broker-J] Illegal ascii characters are used in keystore passwords
> --
>
> Key: QPID-8254
> URL: https://issues.apache.org/jira/browse/QPID-8254
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-6.1.7, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Illegal keystore password characters are used on creation of
> {{AutoGeneratedSelfSignedKeyStoreImpl}} and {{NonJavaKeyStoreImpl}}:
> {code}
> char[] chars = new char[64];
> RANDOM.nextBytes(bytes);
> StandardCharsets.US_ASCII.decode(ByteBuffer.wrap(bytes)).get(chars);
> inMemoryKeyStore.load(null, chars);
> inMemoryKeyStore.setKeyEntry("1", _privateKey, chars, certs);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8254) [Broker-J] Illegal ascii characters are used in keystore passwords
[
https://issues.apache.org/jira/browse/QPID-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8254:
-
Status: Reviewable (was: In Progress)
> [Broker-J] Illegal ascii characters are used in keystore passwords
> --
>
> Key: QPID-8254
> URL: https://issues.apache.org/jira/browse/QPID-8254
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-6.1.7, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Illegal keystore password characters are used on creation of
> {{AutoGeneratedSelfSignedKeyStoreImpl}} and {{NonJavaKeyStoreImpl}}:
> {code}
> char[] chars = new char[64];
> RANDOM.nextBytes(bytes);
> StandardCharsets.US_ASCII.decode(ByteBuffer.wrap(bytes)).get(chars);
> inMemoryKeyStore.load(null, chars);
> inMemoryKeyStore.setKeyEntry("1", _privateKey, chars, certs);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8253) [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLEngine.getSSLParameters().getServerNames()
[ https://issues.apache.org/jira/browse/QPID-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8253: - Status: Reviewable (was: In Progress) > [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned > from SSLEngine.getSSLParameters().getServerNames() > -- > > Key: QPID-8253 > URL: https://issues.apache.org/jira/browse/QPID-8253 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.7, qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > QpidBestFitX509KeyManager does not handle null server names returned from > SSLENgine.getSSLParameters().getServerNames() -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8253) [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLEngine.getSSLParameters().getServerNames()
[ https://issues.apache.org/jira/browse/QPID-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8253: - Fix Version/s: (was: qpid-java-broker-7.0.7) > [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned > from SSLEngine.getSSLParameters().getServerNames() > -- > > Key: QPID-8253 > URL: https://issues.apache.org/jira/browse/QPID-8253 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.7, qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > QpidBestFitX509KeyManager does not handle null server names returned from > SSLENgine.getSSLParameters().getServerNames() -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8253) [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLEngine.getSSLParameters().getServerNames()
[ https://issues.apache.org/jira/browse/QPID-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-8253: Assignee: Alex Rudyy > [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned > from SSLEngine.getSSLParameters().getServerNames() > -- > > Key: QPID-8253 > URL: https://issues.apache.org/jira/browse/QPID-8253 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.7, qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > QpidBestFitX509KeyManager does not handle null server names returned from > SSLENgine.getSSLParameters().getServerNames() -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8254) [Broker-J] Illegal ascii characters are used in keystore passwords
[
https://issues.apache.org/jira/browse/QPID-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reassigned QPID-8254:
Assignee: Alex Rudyy
> [Broker-J] Illegal ascii characters are used in keystore passwords
> --
>
> Key: QPID-8254
> URL: https://issues.apache.org/jira/browse/QPID-8254
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-6.1.7, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Illegal keystore password characters are used on creation of
> {{AutoGeneratedSelfSignedKeyStoreImpl}} and {{NonJavaKeyStoreImpl}}:
> {code}
> char[] chars = new char[64];
> RANDOM.nextBytes(bytes);
> StandardCharsets.US_ASCII.decode(ByteBuffer.wrap(bytes)).get(chars);
> inMemoryKeyStore.load(null, chars);
> inMemoryKeyStore.setKeyEntry("1", _privateKey, chars, certs);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8132) Refresh Apache BCEL dependency to 6.2
[ https://issues.apache.org/jira/browse/QPID-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8132. -- Resolution: Fixed > Refresh Apache BCEL dependency to 6.2 > - > > Key: QPID-8132 > URL: https://issues.apache.org/jira/browse/QPID-8132 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Alex Rudyy >Priority: Minor > Fix For: qpid-java-broker-7.1.0 > > > The Apache BCEL dependency used by Broker-J is getting stale (5.2). 6.2 is > the latest release. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8196) [Broker-J] [WMC] Edit form controls are not populated with current values
[ https://issues.apache.org/jira/browse/QPID-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8196. -- Resolution: Fixed > [Broker-J] [WMC] Edit form controls are not populated with current values > - > > Key: QPID-8196 > URL: https://issues.apache.org/jira/browse/QPID-8196 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8196-Broker-J-WMC-Make-sure-that-edit-form-cont.patch > > > The form for editing BDB HA VHN does not populate reliably the UI controls > with current attribute values. Some of the attribute controls can be left > unset. As result, on submitting the form, null/empty values can be sent as > part of update request to the broker. > User impact: > Editing of attributes cannot be done reliably from WVM, as when the issue > occurs, the update requests from WMC fail due to broker side validation. > There is a possibility of unexpected change of attribute value to null. > Work around: REST API can be used to change the attribute values. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8216) [Broker-J] Operational log message CHN-1011 about moving message to dead letter queue is not reported
[
https://issues.apache.org/jira/browse/QPID-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy resolved QPID-8216.
--
Resolution: Fixed
> [Broker-J] Operational log message CHN-1011 about moving message to dead
> letter queue is not reported
> -
>
> Key: QPID-8216
> URL: https://issues.apache.org/jira/browse/QPID-8216
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2,
> qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Operational log message CHN-1011 about moving message to dead letter queue is
> not reported any more. The changes committed in [
> https://svn.apache.org/r1776037 ] against QPID-6028 removed reporting of
> operational log message CHN-1011:
> {noformat}
> CHN-1011 : Message : moved to dead letter queue : name>
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7885) [Java Broker] Support Java 9
[ https://issues.apache.org/jira/browse/QPID-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-7885: - Status: Reviewable (was: In Progress) > [Java Broker] Support Java 9 > > > Key: QPID-7885 > URL: https://issues.apache.org/jira/browse/QPID-7885 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Lorenz Quack >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > With the Java 9 on the horizon it is time to get Qpid's Java components ready. > * make sure component compile with JDK9 > * make sure components run with JRE9 > The task of modularization of broker-j is excluded from this JIRA, as it > seems, that many existing modules need to export the same packages which is > not permitted by Jigsaw module system. Some classes need to be moved into > separate packages which requires more substantial refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7885) [Java Broker] Support Java 9
[ https://issues.apache.org/jira/browse/QPID-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669001#comment-16669001 ] ASF subversion and git services commented on QPID-7885: --- Commit 73745fe8be84dd3b94e618b19c44dccbdee0d71f in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=73745fe ] QPID-7885: [Broker-J] Update PluggableProcessor to handle NoSuchFileException on generation of service files > [Java Broker] Support Java 9 > > > Key: QPID-7885 > URL: https://issues.apache.org/jira/browse/QPID-7885 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Lorenz Quack >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > With the Java 9 on the horizon it is time to get Qpid's Java components ready. > * make sure component compile with JDK9 > * make sure components run with JRE9 > The task of modularization of broker-j is excluded from this JIRA, as it > seems, that many existing modules need to export the same packages which is > not permitted by Jigsaw module system. Some classes need to be moved into > separate packages which requires more substantial refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7885) [Java Broker] Support Java 9
[ https://issues.apache.org/jira/browse/QPID-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669003#comment-16669003 ] ASF subversion and git services commented on QPID-7885: --- Commit a045ea8a749fa3ee6a76e6398b35d39b4bf8af76 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=a045ea8 ] QPID-7885: Fix failing tests > [Java Broker] Support Java 9 > > > Key: QPID-7885 > URL: https://issues.apache.org/jira/browse/QPID-7885 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Lorenz Quack >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > With the Java 9 on the horizon it is time to get Qpid's Java components ready. > * make sure component compile with JDK9 > * make sure components run with JRE9 > The task of modularization of broker-j is excluded from this JIRA, as it > seems, that many existing modules need to export the same packages which is > not permitted by Jigsaw module system. Some classes need to be moved into > separate packages which requires more substantial refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7885) [Java Broker] Support Java 9
[ https://issues.apache.org/jira/browse/QPID-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669005#comment-16669005 ] ASF subversion and git services commented on QPID-7885: --- Commit 35998c406fd22606c60202308ecad75cfed98f84 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=35998c4 ] QPID-7885: [Broker-J] Use jaxb dependency with legacy JMS client as it depends on jaxb base64 encoding > [Java Broker] Support Java 9 > > > Key: QPID-7885 > URL: https://issues.apache.org/jira/browse/QPID-7885 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Lorenz Quack >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > With the Java 9 on the horizon it is time to get Qpid's Java components ready. > * make sure component compile with JDK9 > * make sure components run with JRE9 > The task of modularization of broker-j is excluded from this JIRA, as it > seems, that many existing modules need to export the same packages which is > not permitted by Jigsaw module system. Some classes need to be moved into > separate packages which requires more substantial refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7885) [Java Broker] Support Java 9
[ https://issues.apache.org/jira/browse/QPID-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669000#comment-16669000 ] ASF subversion and git services commented on QPID-7885: --- Commit 3ff81dac366e77c99564e5434d5679fe9f835d02 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=3ff81da ] QPID-7885: [Broker-J] Upgrade apache parent pom to version 21 and update maven plugin versions > [Java Broker] Support Java 9 > > > Key: QPID-7885 > URL: https://issues.apache.org/jira/browse/QPID-7885 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Lorenz Quack >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > With the Java 9 on the horizon it is time to get Qpid's Java components ready. > * make sure component compile with JDK9 > * make sure components run with JRE9 > The task of modularization of broker-j is excluded from this JIRA, as it > seems, that many existing modules need to export the same packages which is > not permitted by Jigsaw module system. Some classes need to be moved into > separate packages which requires more substantial refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8253) [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLEngine.getSSLParameters().getServerNames()
[ https://issues.apache.org/jira/browse/QPID-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668998#comment-16668998 ] ASF subversion and git services commented on QPID-8253: --- Commit 4ebae1747328e19519fa670974dfac92fb852a71 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=4ebae17 ] QPID-8253: [Broker-J] Hanlde null server names returned from SSLEngine SSLParameters > [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned > from SSLEngine.getSSLParameters().getServerNames() > -- > > Key: QPID-8253 > URL: https://issues.apache.org/jira/browse/QPID-8253 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.7, qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7 > > > QpidBestFitX509KeyManager does not handle null server names returned from > SSLENgine.getSSLParameters().getServerNames() -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8254) [Broker-J] Illegal ascii characters are used in keystore passwords
[
https://issues.apache.org/jira/browse/QPID-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668999#comment-16668999
]
ASF subversion and git services commented on QPID-8254:
---
Commit 16b5592f12ccb841e432f5e16c4851c21ccc66cf in qpid-broker-j's branch
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=16b5592 ]
QPID-8254: [Broker-J] Stop using illegal ascii characters in java keystore
passwords
> [Broker-J] Illegal ascii characters are used in keystore passwords
> --
>
> Key: QPID-8254
> URL: https://issues.apache.org/jira/browse/QPID-8254
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0.8, qpid-java-6.1.7, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Illegal keystore password characters are used on creation of
> {{AutoGeneratedSelfSignedKeyStoreImpl}} and {{NonJavaKeyStoreImpl}}:
> {code}
> char[] chars = new char[64];
> RANDOM.nextBytes(bytes);
> StandardCharsets.US_ASCII.decode(ByteBuffer.wrap(bytes)).get(chars);
> inMemoryKeyStore.load(null, chars);
> inMemoryKeyStore.setKeyEntry("1", _privateKey, chars, certs);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8255) [JMS AMQP 0-x] Connection failure with connection option 'client_cert_priv_key_path' and java 11
Alex Rudyy created QPID-8255:
Summary: [JMS AMQP 0-x] Connection failure with connection option
'client_cert_priv_key_path' and java 11
Key: QPID-8255
URL: https://issues.apache.org/jira/browse/QPID-8255
Project: Qpid
Issue Type: Bug
Components: JMS AMQP 0-x
Affects Versions: qpid-java-client-0-x-6.3.3
Environment: java11
Reporter: Alex Rudyy
Connection establishment fails with java 11 when connection option
'client_cert_priv_key_path' is used:
{noformat}
javax.jms.JMSException: Error creating connection: Key protection algorithm
not found: java.security.UnrecoverableKeyException: Encrypt Private Key failed:
getSecretKey failed: Password is not ASCII
at
org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:169)
at
org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:143)
at
org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:57)
at
org.apache.qpid.systests.QpidJmsClient0xConnectionBuilder.build(QpidJmsClient0xConnectionBuilder.java:270)
at
org.apache.qpid.systests.jms_1_1.extensions.tls.TlsTest.testCreateSSLWithCertFileAndPrivateKey(TlsTest.java:508)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.apache.qpid.tests.utils.QpidTestRunner.runChild(QpidTestRunner.java:84)
at
org.apache.qpid.tests.utils.QpidTestRunner.runChild(QpidTestRunner.java:28)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.apache.qpid.tests.utils.QpidTestRunner.run(QpidTestRunner.java:59)
at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Caused by: org.apache.qpid.AMQConnectionFailureException: Key protection
algorithm not found: java.security.UnrecoverableKeyException: Encrypt Private
Key failed: getSecretKey failed: Password is not ASCII
at
org.apache.qpid.client.AMQConnection.makeConnection(AMQConnection.java:672)
at org.apache.qpid.client.AMQConnection.(AMQConnection.java:522)
at
org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:164)
... 32 more
Caused by: org.apache.qpid.transport.TransportException: Error creating SSL
Context
at
org.apache.qpid.transport.network.security.SecurityLayerFactory$SSLSecurityLayer.(SecurityLayerFactory.java:100)
at
org.apache.qpid.transport.network.security.SecurityLayerFactory.newInstance(SecurityLayerFactory.java:59)
at
org.apache.qpid.client.AMQConnectionDelegate_8_0.makeBrokerConnection(AMQConnectionDelegate_8_0.java:142)
at
org.apache.qpid.client.AMQConnection.makeBrokerConnection(AMQConnection.java:816)
at
org.apache.qpid.client.AMQConnection.makeConnection(AMQConnection.java:583)
... 34 more
Caused by: java.security.KeyStoreException: Key protection algorithm not
found: java.security.UnrecoverableKeyException: Encrypt Private Key failed:
getSecretKey failed: Password is not ASCII
at
java.base/sun.security.pkcs12.PKCS12KeyStore.setKe
[jira] [Created] (QPID-8254) [Broker-J] Illegal ascii characters are used in keystore passwords
Alex Rudyy created QPID-8254:
Summary: [Broker-J] Illegal ascii characters are used in keystore
passwords
Key: QPID-8254
URL: https://issues.apache.org/jira/browse/QPID-8254
Project: Qpid
Issue Type: Bug
Components: Broker-J
Affects Versions: qpid-java-broker-7.0.6, qpid-java-6.1.7, qpid-java-6.0.8
Reporter: Alex Rudyy
Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
Illegal keystore password characters are used on creation of
{{AutoGeneratedSelfSignedKeyStoreImpl}} and {{NonJavaKeyStoreImpl}}:
{code}
char[] chars = new char[64];
RANDOM.nextBytes(bytes);
StandardCharsets.US_ASCII.decode(ByteBuffer.wrap(bytes)).get(chars);
inMemoryKeyStore.load(null, chars);
inMemoryKeyStore.setKeyEntry("1", _privateKey, chars, certs);
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1938) misaligned Transport set/getErrorCondition and closed() behaviour
[ https://issues.apache.org/jira/browse/PROTON-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668845#comment-16668845 ] ASF GitHub Bot commented on PROTON-1938: Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton-j/pull/16 As noted on the JIRA, an alternate change was made in 19bf22f7e9b88e73db4b195f674d1527dbd713f3. > misaligned Transport set/getErrorCondition and closed() behaviour > - > > Key: PROTON-1938 > URL: https://issues.apache.org/jira/browse/PROTON-1938 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.29.0 >Reporter: Sreeram Garlapati >Priority: Minor > Fix For: proton-j-0.30.0 > > > Although at various places in proton library - transport.setCondition() was > invoked (for ex: IOHandler.java - invokes several places to communicate > socket IOExceptions) - this was overwritten in TransportImpl.closed method > and shows up as - ConnectionError.FRAMING_ERROR. > I created this PR: to help easily identify - where the problem was: > [https://github.com/apache/qpid-proton-j/pull/16] > Please let me know if you need more info or have any inputs finishing the PR > at sreer...@microsoft.com... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j issue #16: PROTON-1938: Fix error propagation in TransportImpl
Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton-j/pull/16 As noted on the JIRA, an alternate change was made in 19bf22f7e9b88e73db4b195f674d1527dbd713f3. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1938) misaligned Transport set/getErrorCondition and closed() behaviour
[ https://issues.apache.org/jira/browse/PROTON-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668844#comment-16668844 ] ASF GitHub Bot commented on PROTON-1938: Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton-j/pull/16 > misaligned Transport set/getErrorCondition and closed() behaviour > - > > Key: PROTON-1938 > URL: https://issues.apache.org/jira/browse/PROTON-1938 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.29.0 >Reporter: Sreeram Garlapati >Priority: Minor > Fix For: proton-j-0.30.0 > > > Although at various places in proton library - transport.setCondition() was > invoked (for ex: IOHandler.java - invokes several places to communicate > socket IOExceptions) - this was overwritten in TransportImpl.closed method > and shows up as - ConnectionError.FRAMING_ERROR. > I created this PR: to help easily identify - where the problem was: > [https://github.com/apache/qpid-proton-j/pull/16] > Please let me know if you need more info or have any inputs finishing the PR > at sreer...@microsoft.com... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1938) misaligned Transport set/getErrorCondition and closed() behaviour
[ https://issues.apache.org/jira/browse/PROTON-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668843#comment-16668843 ] ASF subversion and git services commented on PROTON-1938: - Commit 2951b4051466a4c0ee888a5f8fa012c62ed138d3 in qpid-proton-j's branch refs/heads/master from [~gemmellr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton-j.git;h=2951b40 ] PROTON-1938: cleanup PR, alternate change made in 19bf22f7e9b88e73db4b195f674d1527dbd713f3. This closes #16 > misaligned Transport set/getErrorCondition and closed() behaviour > - > > Key: PROTON-1938 > URL: https://issues.apache.org/jira/browse/PROTON-1938 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.29.0 >Reporter: Sreeram Garlapati >Priority: Minor > Fix For: proton-j-0.30.0 > > > Although at various places in proton library - transport.setCondition() was > invoked (for ex: IOHandler.java - invokes several places to communicate > socket IOExceptions) - this was overwritten in TransportImpl.closed method > and shows up as - ConnectionError.FRAMING_ERROR. > I created this PR: to help easily identify - where the problem was: > [https://github.com/apache/qpid-proton-j/pull/16] > Please let me know if you need more info or have any inputs finishing the PR > at sreer...@microsoft.com... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #16: PROTON-1938: Fix error propagation in Transp...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton-j/pull/16 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1938) misaligned Transport set/getErrorCondition and closed() behaviour
[ https://issues.apache.org/jira/browse/PROTON-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668833#comment-16668833 ] Robbie Gemmell commented on PROTON-1938: The existing behaviour was a bit more nuanced than described. Calling setCondition(ErrorCondition) on the TransportImpl object actually had no influence over the ErrorCondition returned from TransportImpl#getCondition() or used in certain Close frames at all. It operated on the EndpointImpl superclass state whereas the getCondition method was overridden in TransportImpl and only operated on a local field in that class which was set inside TransportImpl in the closed(TransportException) method, either setting a "connection aborted" 'framing error' condition if no exception is provided, or a 'framing error' with the exception message as its description if an exception was provided. I have made a different change, removing the extra ErrorCondition field from TransportImpl and aligning on use of the parent field used by other objects, but retaining as much of the earlier getCondition behaviour of TransportImpl as possible/sensible, and ensuring that an ErrorCondition previously set is retained in preference to creating a new one when closed(TransportException) is called. > misaligned Transport set/getErrorCondition and closed() behaviour > - > > Key: PROTON-1938 > URL: https://issues.apache.org/jira/browse/PROTON-1938 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.29.0 >Reporter: Sreeram Garlapati >Priority: Minor > Fix For: proton-j-0.30.0 > > > Although at various places in proton library - transport.setCondition() was > invoked (for ex: IOHandler.java - invokes several places to communicate > socket IOExceptions) - this was overwritten in TransportImpl.closed method > and shows up as - ConnectionError.FRAMING_ERROR. > I created this PR: to help easily identify - where the problem was: > [https://github.com/apache/qpid-proton-j/pull/16] > Please let me know if you need more info or have any inputs finishing the PR > at sreer...@microsoft.com... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1938) misaligned Transport set/getErrorCondition and closed() behaviour
[ https://issues.apache.org/jira/browse/PROTON-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-1938. Resolution: Fixed > misaligned Transport set/getErrorCondition and closed() behaviour > - > > Key: PROTON-1938 > URL: https://issues.apache.org/jira/browse/PROTON-1938 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.29.0 >Reporter: Sreeram Garlapati >Priority: Minor > Fix For: proton-j-0.30.0 > > > Although at various places in proton library - transport.setCondition() was > invoked (for ex: IOHandler.java - invokes several places to communicate > socket IOExceptions) - this was overwritten in TransportImpl.closed method > and shows up as - ConnectionError.FRAMING_ERROR. > I created this PR: to help easily identify - where the problem was: > [https://github.com/apache/qpid-proton-j/pull/16] > Please let me know if you need more info or have any inputs finishing the PR > at sreer...@microsoft.com... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1938) misaligned Transport set/getErrorCondition and closed() behaviour
[ https://issues.apache.org/jira/browse/PROTON-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-1938: --- Summary: misaligned Transport set/getErrorCondition and closed() behaviour (was: Transport error condition falsely pretends to be ConnectionError.FRAMING_ERROR) > misaligned Transport set/getErrorCondition and closed() behaviour > - > > Key: PROTON-1938 > URL: https://issues.apache.org/jira/browse/PROTON-1938 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.29.0 >Reporter: Sreeram Garlapati >Priority: Minor > Fix For: proton-j-0.30.0 > > > Although at various places in proton library - transport.setCondition() was > invoked (for ex: IOHandler.java - invokes several places to communicate > socket IOExceptions) - this was overwritten in TransportImpl.closed method > and shows up as - ConnectionError.FRAMING_ERROR. > I created this PR: to help easily identify - where the problem was: > [https://github.com/apache/qpid-proton-j/pull/16] > Please let me know if you need more info or have any inputs finishing the PR > at sreer...@microsoft.com... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1938) Transport error condition falsely pretends to be ConnectionError.FRAMING_ERROR
[ https://issues.apache.org/jira/browse/PROTON-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668826#comment-16668826 ] ASF subversion and git services commented on PROTON-1938: - Commit 19bf22f7e9b88e73db4b195f674d1527dbd713f3 in qpid-proton-j's branch refs/heads/master from [~gemmellr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton-j.git;h=19bf22f ] PROTON-1938: align TransportImpl set/getCondition behaviour, plus stop the closed method replacing an existing ErrorCondition > Transport error condition falsely pretends to be ConnectionError.FRAMING_ERROR > -- > > Key: PROTON-1938 > URL: https://issues.apache.org/jira/browse/PROTON-1938 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.29.0 >Reporter: Sreeram Garlapati >Priority: Minor > Fix For: proton-j-0.30.0 > > > Although at various places in proton library - transport.setCondition() was > invoked (for ex: IOHandler.java - invokes several places to communicate > socket IOExceptions) - this was overwritten in TransportImpl.closed method > and shows up as - ConnectionError.FRAMING_ERROR. > I created this PR: to help easily identify - where the problem was: > [https://github.com/apache/qpid-proton-j/pull/16] > Please let me know if you need more info or have any inputs finishing the PR > at sreer...@microsoft.com... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8253) [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLEngine.getSSLParameters().getServerNames()
[ https://issues.apache.org/jira/browse/QPID-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8253: - Summary: [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLEngine.getSSLParameters().getServerNames() (was: [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLENgine.getSSLParameters().getServerNames()) > [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned > from SSLEngine.getSSLParameters().getServerNames() > -- > > Key: QPID-8253 > URL: https://issues.apache.org/jira/browse/QPID-8253 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.7, qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7 > > > QpidBestFitX509KeyManager does not handle null server names returned from > SSLENgine.getSSLParameters().getServerNames() -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8253) [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLENgine.getSSLParameters().getServerNames()
Alex Rudyy created QPID-8253: Summary: [Broker-J] NPE is thrown in QpidBestFitX509KeyManager when null is returned from SSLENgine.getSSLParameters().getServerNames() Key: QPID-8253 URL: https://issues.apache.org/jira/browse/QPID-8253 Project: Qpid Issue Type: Bug Components: Broker-J Affects Versions: qpid-java-broker-7.0.6, qpid-java-6.1.7 Reporter: Alex Rudyy Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7 QpidBestFitX509KeyManager does not handle null server names returned from SSLENgine.getSSLParameters().getServerNames() -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7885) [Java Broker] Support Java 9
[ https://issues.apache.org/jira/browse/QPID-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-7885: - Description: With the Java 9 on the horizon it is time to get Qpid's Java components ready. * make sure component compile with JDK9 * make sure components run with JRE9 The task of modularization of broker-j is excluded from this JIRA, as it seems, that many existing modules need to export the same packages which is not permitted by Jigsaw module system. Some classes need to be moved into separate packages which requires more substantial refactoring. was: With the Java 9 on the horizon it is time to get Qpid's Java components ready. * make sure component compile with JDK9 * make sure components run with JRE9 * take advantage of the new Java Module System > [Java Broker] Support Java 9 > > > Key: QPID-7885 > URL: https://issues.apache.org/jira/browse/QPID-7885 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Lorenz Quack >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > With the Java 9 on the horizon it is time to get Qpid's Java components ready. > * make sure component compile with JDK9 > * make sure components run with JRE9 > The task of modularization of broker-j is excluded from this JIRA, as it > seems, that many existing modules need to export the same packages which is > not permitted by Jigsaw module system. Some classes need to be moved into > separate packages which requires more substantial refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-7885) [Java Broker] Support Java 9
[ https://issues.apache.org/jira/browse/QPID-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-7885: Assignee: Alex Rudyy > [Java Broker] Support Java 9 > > > Key: QPID-7885 > URL: https://issues.apache.org/jira/browse/QPID-7885 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Lorenz Quack >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > With the Java 9 on the horizon it is time to get Qpid's Java components ready. > * make sure component compile with JDK9 > * make sure components run with JRE9 > * take advantage of the new Java Module System -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (QPID-8158) [Broker-J] [System Tests] Refactor BDB HA system tests
[
https://issues.apache.org/jira/browse/QPID-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy closed QPID-8158.
Resolution: Fixed
> [Broker-J] [System Tests] Refactor BDB HA system tests
> --
>
> Key: QPID-8158
> URL: https://issues.apache.org/jira/browse/QPID-8158
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J, Java Tests
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
>
> Currently BDB HA system tests are extended from {{QpidBrokerTestCase}}. They
> need to be refactored to run with {{QpidTestRunner}} similar to other system
> tests.
> The BDB HA nodes should be started as spawn brokers using special
> {{BrokerAdmin}} allowing to start broker in a separate JVM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8245) [Broker-J] [AMQP 0-8..0-91] Decode FieldTable fields on demand
[ https://issues.apache.org/jira/browse/QPID-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8245: - Status: Reviewable (was: In Progress) > [Broker-J] [AMQP 0-8..0-91] Decode FieldTable fields on demand > -- > > Key: QPID-8245 > URL: https://issues.apache.org/jira/browse/QPID-8245 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8245-Broker-J-Stop-rellocating-message-headers-.patch, > 0002-QPID-8245-Add-factory-methods-to-create-field-table-.patch, > 0003-QPID-8245-Remove-FiledTable-setters-methods-modifyin.patch, > 0004-QPID-8245-Decode-field-table-properties-when-require.patch, > 0005-QPID-8245-Remove-methods-getXXX-in-order-to-simplify.patch, > 0006-QPID-8245-some-code-clean-up.patch, > 0007-QPID-8245-Change-decoding-to-decode-only-value-for-t.patch, > 0008-QPID-8245-Dispose-QpidByteBuffer-on-decoding-FieldTa.patch > > > At the moment all field table properties are decoded when decode > functionality is invoked. For use cases when only some of the field table > properties are queried, the decoding functionality can be changed to stop > decoding on getting the requested property. Potentially, such approach can > improve the performance of routing transient messages when destinations are > bound to the routing exchange using selector filters. As filter expression > contains only some properties, the decoding of message headers can be stopped > on getting all fields specified in selector expression. > The idea is illustrated by Rob Godfrey on > [QPID-8238|https://issues.apache.org/jira/browse/QPID-8238?focusedCommentId=16601936&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16601936] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8245) [Broker-J] [AMQP 0-8..0-91] Decode FieldTable fields on demand
[ https://issues.apache.org/jira/browse/QPID-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-8245: Assignee: Alex Rudyy > [Broker-J] [AMQP 0-8..0-91] Decode FieldTable fields on demand > -- > > Key: QPID-8245 > URL: https://issues.apache.org/jira/browse/QPID-8245 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8245-Broker-J-Stop-rellocating-message-headers-.patch, > 0002-QPID-8245-Add-factory-methods-to-create-field-table-.patch, > 0003-QPID-8245-Remove-FiledTable-setters-methods-modifyin.patch, > 0004-QPID-8245-Decode-field-table-properties-when-require.patch, > 0005-QPID-8245-Remove-methods-getXXX-in-order-to-simplify.patch, > 0006-QPID-8245-some-code-clean-up.patch, > 0007-QPID-8245-Change-decoding-to-decode-only-value-for-t.patch, > 0008-QPID-8245-Dispose-QpidByteBuffer-on-decoding-FieldTa.patch > > > At the moment all field table properties are decoded when decode > functionality is invoked. For use cases when only some of the field table > properties are queried, the decoding functionality can be changed to stop > decoding on getting the requested property. Potentially, such approach can > improve the performance of routing transient messages when destinations are > bound to the routing exchange using selector filters. As filter expression > contains only some properties, the decoding of message headers can be stopped > on getting all fields specified in selector expression. > The idea is illustrated by Rob Godfrey on > [QPID-8238|https://issues.apache.org/jira/browse/QPID-8238?focusedCommentId=16601936&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16601936] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8247) [Broker-J] Upgrade mockito to 2.x
[ https://issues.apache.org/jira/browse/QPID-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-8247: Assignee: Alex Rudyy > [Broker-J] Upgrade mockito to 2.x > - > > Key: QPID-8247 > URL: https://issues.apache.org/jira/browse/QPID-8247 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > The Qpid Broker tests depends on mockito version 1.9.5. In order to be able > to build broker with java9 and above we need to upgrade mockito at least to > version 2.20.0 where compatibility with java 11 was added. Mockito version > 2.22.0 is considered to upgrade to. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8247) [Broker-J] Upgrade mockito to 2.x
[ https://issues.apache.org/jira/browse/QPID-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8247: - Status: Reviewable (was: In Progress) > [Broker-J] Upgrade mockito to 2.x > - > > Key: QPID-8247 > URL: https://issues.apache.org/jira/browse/QPID-8247 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > The Qpid Broker tests depends on mockito version 1.9.5. In order to be able > to build broker with java9 and above we need to upgrade mockito at least to > version 2.20.0 where compatibility with java 11 was added. Mockito version > 2.22.0 is considered to upgrade to. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668743#comment-16668743 ] ASF GitHub Bot commented on DISPATCH-1155: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/409 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=h1) Report > Merging [#409](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/fcf457c981c262d5648d6c1a944059a3c3b47458?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #409 +/- ## == + Coverage 85.16% 85.19% +0.02% == Files 78 78 Lines 1742917430 +1 == + Hits1484314849 +6 + Misses 2586 2581 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `76.44% <66.66%> (-0.11%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.8% <0%> (-0.26%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.65% <0%> (ø)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.66% <0%> (+0.21%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.48% <0%> (+0.21%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.31% <0%> (+0.44%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.84% <0%> (+0.56%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=footer). Last update [fcf457c...61564b9](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #409: DISPATCH-1155 : force explicit config of http root...
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/409 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=h1) Report > Merging [#409](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/fcf457c981c262d5648d6c1a944059a3c3b47458?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #409 +/- ## == + Coverage 85.16% 85.19% +0.02% == Files 78 78 Lines 1742917430 +1 == + Hits1484314849 +6 + Misses 2586 2581 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=tree) | Coverage Π| | |---|---|---| | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `76.44% <66.66%> (-0.11%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.8% <0%> (-0.26%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.65% <0%> (ø)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.66% <0%> (+0.21%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.48% <0%> (+0.21%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.31% <0%> (+0.44%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.84% <0%> (+0.56%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=footer). Last update [fcf457c...61564b9](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668706#comment-16668706 ] ASF GitHub Bot commented on DISPATCH-1155: -- GitHub user mgoulish opened a pull request: https://github.com/apache/qpid-dispatch/pull/409 DISPATCH-1155 : force explicit config of http root dir Force the user to explicit specify HTTP root dir when requesting http support on a listener. Issue a warning log message if HTTP service is requested, but root dir not specified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-1155 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/409.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #409 commit 61564b930f25859702cce2b355d78c30ee3e75cd Author: Michael Goulish Date: 2018-10-30T13:40:23Z DISPATCH-1155 : force explicit config of http root dir > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #409: DISPATCH-1155 : force explicit config of ht...
GitHub user mgoulish opened a pull request: https://github.com/apache/qpid-dispatch/pull/409 DISPATCH-1155 : force explicit config of http root dir Force the user to explicit specify HTTP root dir when requesting http support on a listener. Issue a warning log message if HTTP service is requested, but root dir not specified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-1155 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/409.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #409 commit 61564b930f25859702cce2b355d78c30ee3e75cd Author: Michael Goulish Date: 2018-10-30T13:40:23Z DISPATCH-1155 : force explicit config of http root dir --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
