[jira] [Commented] (QPID-8269) [Broker-J] Enforce password complexity in authentication providers managing credentials
[ https://issues.apache.org/jira/browse/QPID-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733407#comment-16733407 ] Keith Wall commented on QPID-8269: -- I think for production use-cases, Broker-J users ought to be delegating authentication to an enterprise authentication system (such as one exposing an LDAP or Kerberos API). These systems are far better positioned to enforce password complexity/reuse rules /lock out. I wouldn't recommend that an enterprise user uses the built in file/config base authentication system for anything other development use-cases. > [Broker-J] Enforce password complexity in authentication providers managing > credentials > --- > > Key: QPID-8269 > URL: https://issues.apache.org/jira/browse/QPID-8269 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-8.0.0 > > > Validate the password credentials in Qpid authentication providers managing > credentials to meet the following requirements: > * Password length must be greater than predefined minimum password length > limit (8 or 16 characters, by default) > * Passwords included in the predefined blacklist must not be allowed > * Passwords must not include repetitive or sequential patterns of more than 3 > characters > * Passwords must not include the account username > * Password must be comprised of 3 out of the following 4 elements: > ** Lowercase characters (a through z) > ** Uppercase characters (A through Z) > ** Base 10 digits (0 through 9) > ** Special or non-alphanumeric characters (@,#,+,etc) > * Passwords must not be reused the last 12 times > The different password complexity policies can be applied for interactive and > non interactive accounts. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1232) Edge router test failing on RHEL6
[ https://issues.apache.org/jira/browse/DISPATCH-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733402#comment-16733402 ] ASF GitHub Bot commented on DISPATCH-1232: -- fgiorgetti commented on pull request #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed URL: https://github.com/apache/qpid-dispatch/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Edge router test failing on RHEL6 > - > > Key: DISPATCH-1232 > URL: https://issues.apache.org/jira/browse/DISPATCH-1232 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.5.0 > > > System tests for edge router are failing on RHEL6. > The test_broker.py is calling count attribute of collections.deque(), but > count was introduced in python2.7 and RHEL6 comes with python 2.6 only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] fgiorgetti opened a new pull request #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed
fgiorgetti opened a new pull request #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed URL: https://github.com/apache/qpid-dispatch/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1673#comment-1673 ] ASF GitHub Bot commented on DISPATCH-1234: -- kgiusti commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089295 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c ## @@ -308,13 +316,20 @@ static void on_link_event(void *context, qdrc_event_t event, qdr_link_t *link) if (addr && qdr_address_is_mobile_CT(addr)) { qdr_addr_endpoint_state_t *endpoint_state = qdrc_get_endpoint_state_for_connection(mc->endpoint_state_list, link->conn, link); link->edge_context = endpoint_state; +endpoint_state->link = link; if (qdrc_can_send_address(addr, link->conn) && endpoint_state) { qdrc_send_message(mc->core, addr, endpoint_state->endpoint, true); } } break; } +case QDRC_EVENT_LINK_EDGE_DATA_DETACHED : +{ +link->edge_context = 0; Review comment: should the corresponding endpoint_state->link be reset also? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1674#comment-1674 ] ASF GitHub Bot commented on DISPATCH-1234: -- kgiusti commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089130 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c ## @@ -237,7 +243,9 @@ static void on_addr_event(void *context, qdrc_event_t event, qdr_address_t *addr if(inlink->link->edge_context != 0) { qdr_addr_endpoint_state_t *endpoint_state = (qdr_addr_endpoint_state_t *)inlink->link->edge_context; qdrc_endpoint_t *endpoint = endpoint_state->endpoint; -qdrc_send_message(addr_tracking->core, addr, endpoint, false); +assert(endpoint != (void *)0x); Review comment: nuke me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…
kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089295 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c ## @@ -308,13 +316,20 @@ static void on_link_event(void *context, qdrc_event_t event, qdr_link_t *link) if (addr && qdr_address_is_mobile_CT(addr)) { qdr_addr_endpoint_state_t *endpoint_state = qdrc_get_endpoint_state_for_connection(mc->endpoint_state_list, link->conn, link); link->edge_context = endpoint_state; +endpoint_state->link = link; if (qdrc_can_send_address(addr, link->conn) && endpoint_state) { qdrc_send_message(mc->core, addr, endpoint_state->endpoint, true); } } break; } +case QDRC_EVENT_LINK_EDGE_DATA_DETACHED : +{ +link->edge_context = 0; Review comment: should the corresponding endpoint_state->link be reset also? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1671#comment-1671 ] ASF GitHub Bot commented on DISPATCH-1234: -- kgiusti commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089019 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c ## @@ -134,6 +135,10 @@ static void qdrc_address_endpoint_on_first_detach(void *link_context, qdrc_endpoint_detach_CT(endpoint_state->mc->core, endpoint_state->endpoint, 0); qdr_addr_tracking_module_context_t *mc = endpoint_state->mc; DEQ_REMOVE(mc->endpoint_state_list, endpoint_state); +endpoint_state->conn = 0; +endpoint_state->endpoint = 0; +endpoint_state->link->edge_context = 0; Review comment: Can (endpoint_state->link) be null? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…
kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089130 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c ## @@ -237,7 +243,9 @@ static void on_addr_event(void *context, qdrc_event_t event, qdr_address_t *addr if(inlink->link->edge_context != 0) { qdr_addr_endpoint_state_t *endpoint_state = (qdr_addr_endpoint_state_t *)inlink->link->edge_context; qdrc_endpoint_t *endpoint = endpoint_state->endpoint; -qdrc_send_message(addr_tracking->core, addr, endpoint, false); +assert(endpoint != (void *)0x); Review comment: nuke me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733296#comment-16733296 ] ASF GitHub Bot commented on DISPATCH-1234: -- codecov-io commented on issue #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#issuecomment-451225511 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@e54e0f4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/433/graphs/tree.svg?width=650=rk2Cgd27pP=150=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=tree) ```diff @@Coverage Diff@@ ## master #433 +/- ## = Coverage ? 86.99% = Files ? 85 Lines ?18696 Branches ?0 = Hits ?16265 Misses? 2431 Partials ?0 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=tree) | Coverage Δ | | |---|---|---| | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/433/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `89.88% <100%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=footer). Last update [e54e0f4...57c84d2](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] codecov-io commented on issue #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…
codecov-io commented on issue #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#issuecomment-451225511 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@e54e0f4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/433/graphs/tree.svg?width=650=rk2Cgd27pP=150=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=tree) ```diff @@Coverage Diff@@ ## master #433 +/- ## = Coverage ? 86.99% = Files ? 85 Lines ?18696 Branches ?0 = Hits ?16265 Misses? 2431 Partials ?0 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=tree) | Coverage Δ | | |---|---|---| | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/433/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `89.88% <100%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=footer). Last update [e54e0f4...57c84d2](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733282#comment-16733282 ] ASF GitHub Bot commented on DISPATCH-1234: -- ganeshmurthy commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433 … context is freed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] ganeshmurthy opened a new pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…
ganeshmurthy opened a new pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433 … context is freed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1235) peer deliveries for multicast are incorrectly unlinked
Ken Giusti created DISPATCH-1235: Summary: peer deliveries for multicast are incorrectly unlinked Key: DISPATCH-1235 URL: https://issues.apache.org/jira/browse/DISPATCH-1235 Project: Qpid Dispatch Issue Type: Bug Reporter: Ken Giusti Assignee: Ken Giusti In this case the delivery may have a single peer (e.g. inbound), while that peer has multiple peers (eg. outbounds). The current code assumes symmetry (either both have multiple or both have single peers). Can result it crash with backtrace when receiving clients unexpectedly disconnect while a large message is being multicast: #4 0x04ead2fa in qdr_deliver_continue_peers_CT (core=0x1a9c3550, in_dlv=0x1da28228) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:1217 #5 0x04ead439 in qdr_deliver_continue_CT (core=0x1a9c3550, action=0x1dc4c028, discard=false) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:1259 #6 0x04ea570f in router_core_thread (arg=0x1a9c3550) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:124 #7 0x0553b594 in start_thread () from /lib64/libpthread.so.0 #8 0x062caf4f in clone () from /lib64/libc.so.6 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
Ganesh Murthy created DISPATCH-1234: --- Summary: Router crash when edge tracking address handler tries to access freed endpoint Key: DISPATCH-1234 URL: https://issues.apache.org/jira/browse/DISPATCH-1234 Project: Qpid Dispatch Issue Type: Bug Components: Container Reporter: Ganesh Murthy Assignee: Ganesh Murthy Fix For: 1.5.0 {noformat} (gdb) bt #0 0x04e3d53f in raise () from /lib64/libc.so.6 #1 0x04e27895 in abort () from /lib64/libc.so.6 #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, addr=0x141158f0) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, event=524288, addr=0x141158f0) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, addr=0x141158f0, link=0x1410fda0) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, action=0x13c411c0, discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 #8 0x048add55 in router_core_thread (arg=0x15395d30) at /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 #10 0x04f026a3 in clone () from /lib64/libc.so.6 (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8271) [Broker-J] Distinguish interactive and non-interactive user credentials in authentication providers managing credentials
[ https://issues.apache.org/jira/browse/QPID-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8271: - Component/s: Broker-J > [Broker-J] Distinguish interactive and non-interactive user credentials in > authentication providers managing credentials > - > > Key: QPID-8271 > URL: https://issues.apache.org/jira/browse/QPID-8271 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-8.0.0 > > > Distinguish interactive and non-interactive user credentials in > authentication providers managing credentials in order to enforce different > password complexity, password expiration and password locking policies -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8269) [Broker-J] Enforce password complexity in authentication providers managing credentials
[ https://issues.apache.org/jira/browse/QPID-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8269: - Description: Validate the password credentials in Qpid authentication providers managing credentials to meet the following requirements: * Password length must be greater than predefined minimum password length limit (8 or 16 characters, by default) * Passwords included in the predefined blacklist must not be allowed * Passwords must not include repetitive or sequential patterns of more than 3 characters * Passwords must not include the account username * Password must be comprised of 3 out of the following 4 elements: ** Lowercase characters (a through z) ** Uppercase characters (A through Z) ** Base 10 digits (0 through 9) ** Special or non-alphanumeric characters (@,#,+,etc) * Passwords must not be reused the last 12 times The different password complexity policies can be applied for interactive and non interactive accounts. was: Validate the password credentials in Qpid authentication providers managing credentials to meet the following requirements: * Password length must be greater than predefined minimum password length limit (8 or 16 characters, by default) * Passwords included in the predefined blacklist must not be allowed * Passwords must not include repetitive or sequential patterns of more than 3 characters * Passwords must not include the account username * Password must be comprised of 3 out of the following 4 elements: ** Lowercase characters (a through z) ** Uppercase characters (A through Z) ** Base 10 digits (0 through 9) ** Special or non-alphanumeric characters (@,#,+,etc) * Passwords must not be reused the last 12 times > [Broker-J] Enforce password complexity in authentication providers managing > credentials > --- > > Key: QPID-8269 > URL: https://issues.apache.org/jira/browse/QPID-8269 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-8.0.0 > > > Validate the password credentials in Qpid authentication providers managing > credentials to meet the following requirements: > * Password length must be greater than predefined minimum password length > limit (8 or 16 characters, by default) > * Passwords included in the predefined blacklist must not be allowed > * Passwords must not include repetitive or sequential patterns of more than 3 > characters > * Passwords must not include the account username > * Password must be comprised of 3 out of the following 4 elements: > ** Lowercase characters (a through z) > ** Uppercase characters (A through Z) > ** Base 10 digits (0 through 9) > ** Special or non-alphanumeric characters (@,#,+,etc) > * Passwords must not be reused the last 12 times > The different password complexity policies can be applied for interactive and > non interactive accounts. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8272) [Broker-J] Add ability to disable(lock) the account and/or report the number of failed login attempts when the number of consecutive logon attempts exceeds predefined thre
Alex Rudyy created QPID-8272: Summary: [Broker-J] Add ability to disable(lock) the account and/or report the number of failed login attempts when the number of consecutive logon attempts exceeds predefined threshold Key: QPID-8272 URL: https://issues.apache.org/jira/browse/QPID-8272 Project: Qpid Issue Type: Improvement Components: Broker-J Reporter: Alex Rudyy Fix For: qpid-java-broker-8.0.0 Add ability to disable(lock) the account when the number of consecutive logon attempts exceeds predefined threshold. The different locking policies can be applied for interactive and non interactive accounts. For example, for interactive accounts the following can be used: * If the account password length is 8 to 15 characters the account must be locked out until reset after at most 10 consecutive login failures. * If the account password length is 16 characters the account must lock out for at least 1 minute after at most 10 consecutive login failures. For non-interactive accounts the following can be used: * Accounts must be locked out for at least 1 minute after at most 10 consecutive login failures. Lockout time should escalate by doubling with each sequential lockout or risk appropriate monitoring of repeated lockouts to detect brute force attacks should be implemented. * For accounts with availability concerns when account lockout is impractical, the risk appropriate monitoring of repeated failed login attempts needs to be added to detect brute force attacks -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8271) [Broker-J] Distinguish interactive and non-interactive user credentials in authentication providers managing credentials
Alex Rudyy created QPID-8271: Summary: [Broker-J] Distinguish interactive and non-interactive user credentials in authentication providers managing credentials Key: QPID-8271 URL: https://issues.apache.org/jira/browse/QPID-8271 Project: Qpid Issue Type: Improvement Reporter: Alex Rudyy Fix For: qpid-java-broker-8.0.0 Distinguish interactive and non-interactive user credentials in authentication providers managing credentials in order to enforce different password complexity, password expiration and password locking policies -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8270) [Broker-J] Enforce password expiration in authentication providers managing credentials
Alex Rudyy created QPID-8270: Summary: [Broker-J] Enforce password expiration in authentication providers managing credentials Key: QPID-8270 URL: https://issues.apache.org/jira/browse/QPID-8270 Project: Qpid Issue Type: Improvement Components: Broker-J Reporter: Alex Rudyy Fix For: qpid-java-broker-8.0.0 The account password must expire after predefined number of calendar days. The password length for interactive accounts can effect the expiration period. For example, if the account password is 15 characters or less in length it can expire after 90 calendar days, if the account password is 16 characters or greater in length the password can expire after 12 months. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8269) [Broker-J] Enforce password complexity in authentication providers managing credentials
Alex Rudyy created QPID-8269: Summary: [Broker-J] Enforce password complexity in authentication providers managing credentials Key: QPID-8269 URL: https://issues.apache.org/jira/browse/QPID-8269 Project: Qpid Issue Type: Improvement Components: Broker-J Reporter: Alex Rudyy Fix For: qpid-java-broker-8.0.0 Validate the password credentials in Qpid authentication providers managing credentials to meet the following requirements: * Password length must be greater than predefined minimum password length limit (8 or 16 characters, by default) * Passwords included in the predefined blacklist must not be allowed * Passwords must not include repetitive or sequential patterns of more than 3 characters * Passwords must not include the account username * Password must be comprised of 3 out of the following 4 elements: ** Lowercase characters (a through z) ** Uppercase characters (A through Z) ** Base 10 digits (0 through 9) ** Special or non-alphanumeric characters (@,#,+,etc) * Passwords must not be reused the last 12 times -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org